Page MenuHomePhabricator

Kayjukh (Jean-Michel Gorius)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 31 2020, 3:33 AM (8 w, 2 h)

Recent Activity

Fri, May 22

Kayjukh committed rG65cd2c7a8015: Revert "[CodeGen] Add support for multiple memory operands in MachineInstr… (authored by Kayjukh).
Revert "[CodeGen] Add support for multiple memory operands in MachineInstr…
Fri, May 22, 12:53 PM
Kayjukh added a reverting change for rG7019cea26dfe: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias: rG65cd2c7a8015: Revert "[CodeGen] Add support for multiple memory operands in MachineInstr….
Fri, May 22, 12:53 PM
Kayjukh added a comment to rG7019cea26dfe: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias.

@nemanjai The changes were reverted by commit 65cd2c7a8015577fea15c861f41d2e4b5768961f.

Fri, May 22, 12:52 PM
Kayjukh added a comment to rG7019cea26dfe: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias.

Sure. I didn't realize it would cause such an overhead. If I remember correctly, some MachineInstr instances sometimes have duplicate memory operands for the same load or store.

Fri, May 22, 12:52 PM

Thu, May 21

Kayjukh committed rG7019cea26dfe: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias (authored by Kayjukh).
[CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias
Thu, May 21, 2:07 PM
Kayjukh closed D80161: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias.
Thu, May 21, 2:06 PM · Restricted Project
Kayjukh added a comment to D80161: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias.

@efriedma Thanks for your feedback! I had to make some minor adjustments to ARM test cases. If it's still good for you, I will land the patch.

Thu, May 21, 1:33 PM · Restricted Project
Kayjukh updated the diff for D80161: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias.

Update FileCheck directives in

llvm/test/CodeGen/ARM/cortex-a57-misched-vldm-wrback.ll
llvm/test/CodeGen/ARM/cortex-a57-misched-vstm-wrback.ll
llvm/test/CodeGen/ARM/cortex-a57-misched-vstm.ll

to avoid matching the new instruction scheduler debug output.

Thu, May 21, 1:32 PM · Restricted Project
Kayjukh added a comment to D80161: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias.

On ARM specifically, operations don't usually more than one memoperand, with the exception of load store paired/multiple. So yes, I can see it would be hard to trigger outside of scheduling.

Maybe we could add some debug output to the scheduler showing when it does/does not add a dependency, and check that. So it would be checking scheduling, but not the final schedule.

Thu, May 21, 11:53 AM · Restricted Project
Kayjukh updated the diff for D80161: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias.

Add some debug output to the instruction sheduler to signal wether or not a chain dependency has been added between two given instructions. This change allows us to properly test the effect of handling multiple memory operands in alias queries on instruction scheduling.

Thu, May 21, 11:53 AM · Restricted Project
Kayjukh committed rGb6917a86fbb5: [ADT][Analysis] NFC: Fix some more typos (authored by Kayjukh).
[ADT][Analysis] NFC: Fix some more typos
Thu, May 21, 10:16 AM
Kayjukh committed rGcb2a8be8842a: [ADT] NFC: Fix typos in header comments (authored by Kayjukh).
[ADT] NFC: Fix typos in header comments
Thu, May 21, 9:09 AM
Kayjukh committed rG439c8b2884a0: [x86] NFC: Fix typo in command line option description (authored by Kayjukh).
[x86] NFC: Fix typo in command line option description
Thu, May 21, 8:04 AM

Wed, May 20

Kayjukh updated the summary of D80062: [x86] Propagate memory operands during call frame optimization.
Wed, May 20, 7:34 AM · Restricted Project
Kayjukh updated the diff for D80062: [x86] Propagate memory operands during call frame optimization.

Also propagate memory operands when folding non-MOV instructions. Add a test case.

Wed, May 20, 7:34 AM · Restricted Project

Tue, May 19

Kayjukh added a comment to D80161: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias.

I'd like to see an MIR test that shows the aliasing check actually working correctly.

I will have to find something that fits in a test case and covers this case. Working on it!

Tue, May 19, 10:55 AM · Restricted Project
Kayjukh added a reviewer for D80161: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias: dmgreen.
Tue, May 19, 5:22 AM · Restricted Project
Kayjukh updated the diff for D80161: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias.

Simplify the method's control flow by wrapping the old dependency checking code in a helper lambda and calling it for each pair of memory operands.

Tue, May 19, 5:22 AM · Restricted Project
Kayjukh added inline comments to D80161: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias.
Tue, May 19, 4:49 AM · Restricted Project
Kayjukh added a comment to D80161: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias.

I'd like to see an MIR test that shows the aliasing check actually working correctly.

Tue, May 19, 3:12 AM · Restricted Project

Mon, May 18

Kayjukh updated the diff for D80161: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias.

Update instruction ordering in failing test cases.

Mon, May 18, 5:22 PM · Restricted Project
Kayjukh created D80161: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias.
Mon, May 18, 2:07 PM · Restricted Project
Kayjukh committed rGcd12e79e6ddd: [x86] Propagate memory operands during ISel DAG postprocessing (authored by Kayjukh).
[x86] Propagate memory operands during ISel DAG postprocessing
Mon, May 18, 1:01 PM
Kayjukh closed D80140: [x86] Propagate memory operands during ISel DAG postprocessing.
Mon, May 18, 1:01 PM · Restricted Project
Kayjukh updated the diff for D80140: [x86] Propagate memory operands during ISel DAG postprocessing.

Add a test case.

Mon, May 18, 11:21 AM · Restricted Project
Kayjukh added inline comments to D80113: [mlir] Support optional attributes in assembly formats.
Mon, May 18, 11:21 AM · Restricted Project
Kayjukh added inline comments to D80113: [mlir] Support optional attributes in assembly formats.
Mon, May 18, 10:13 AM · Restricted Project
Kayjukh added a reviewer for D80062: [x86] Propagate memory operands during call frame optimization: lebedev.ri.
Mon, May 18, 10:13 AM · Restricted Project
Kayjukh updated the summary of D80062: [x86] Propagate memory operands during call frame optimization.
Mon, May 18, 10:13 AM · Restricted Project
Kayjukh created D80140: [x86] Propagate memory operands during ISel DAG postprocessing.
Mon, May 18, 10:13 AM · Restricted Project
Kayjukh updated the diff for D80062: [x86] Propagate memory operands during call frame optimization.

Split the call frame optimization patch from the ISel DAG postprocessing patch.

Mon, May 18, 9:41 AM · Restricted Project
Kayjukh committed rGa4cb9bec1ca3: [mlir] Support optional attributes in assembly formats (authored by gysit).
[mlir] Support optional attributes in assembly formats
Mon, May 18, 9:41 AM
Kayjukh closed D80113: [mlir] Support optional attributes in assembly formats.
Mon, May 18, 9:41 AM · Restricted Project
Kayjukh accepted D80113: [mlir] Support optional attributes in assembly formats.

LGTM after fixing the use of curly braces.

Mon, May 18, 9:40 AM · Restricted Project

Sat, May 16

Kayjukh updated the diff for D80062: [x86] Propagate memory operands during call frame optimization.

Also propagate store memory operands during call frame optimization.

Sat, May 16, 1:13 PM · Restricted Project
Kayjukh added inline comments to D80062: [x86] Propagate memory operands during call frame optimization.
Sat, May 16, 1:13 PM · Restricted Project
Kayjukh added inline comments to D80062: [x86] Propagate memory operands during call frame optimization.
Sat, May 16, 12:09 PM · Restricted Project
Kayjukh created D80062: [x86] Propagate memory operands during call frame optimization.
Sat, May 16, 5:41 AM · Restricted Project

Thu, May 14

Kayjukh accepted D79946: [mlir] Adopt changes in mlir-opt to standalone example.

LGTM, thanks!

Thu, May 14, 9:10 AM · Restricted Project

Tue, May 5

Kayjukh committed rG98b8b36d0009: [mlir][standalone] NFC: Update CMakeLists.txt to reflect best practices (authored by Kayjukh).
[mlir][standalone] NFC: Update CMakeLists.txt to reflect best practices
Tue, May 5, 4:48 AM

Tue, Apr 28

Kayjukh committed rGedb77864ef78: [mlir][assemblyFormat] Fix bug when using AttrSizedOperandSegments trait with… (authored by maerhart).
[mlir][assemblyFormat] Fix bug when using AttrSizedOperandSegments trait with…
Tue, Apr 28, 9:39 AM
Kayjukh closed D79004: [mlir][assemblyFormat] Fix bug when using AttrSizedOperandSegments trait with only non-buildable operand types.
Tue, Apr 28, 9:39 AM · Restricted Project, Restricted Project
Kayjukh accepted D79004: [mlir][assemblyFormat] Fix bug when using AttrSizedOperandSegments trait with only non-buildable operand types.
Tue, Apr 28, 9:06 AM · Restricted Project, Restricted Project
Kayjukh added a comment to D79004: [mlir][assemblyFormat] Fix bug when using AttrSizedOperandSegments trait with only non-buildable operand types.

nit: The commit message looks a little convoluted. Maybe you could simplify/structure it a little bit.
Otherwise, LGTM.

Tue, Apr 28, 8:34 AM · Restricted Project, Restricted Project
Kayjukh added inline comments to D79004: [mlir][assemblyFormat] Fix bug when using AttrSizedOperandSegments trait with only non-buildable operand types.
Tue, Apr 28, 8:01 AM · Restricted Project, Restricted Project

Apr 24 2020

Kayjukh committed rG505685a67a77: [llvm][CodeGen] Check for memory instructions when querying for alias status (authored by Kayjukh).
[llvm][CodeGen] Check for memory instructions when querying for alias status
Apr 24 2020, 2:07 PM
Kayjukh closed D78823: [llvm][CodeGen] Check for memory instructions when querying for alias status.
Apr 24 2020, 2:07 PM · Restricted Project
Kayjukh added a comment to D78823: [llvm][CodeGen] Check for memory instructions when querying for alias status.

It is just a cleanup. I ran into an issue related to this missing check in an out-of-tree project.

Apr 24 2020, 1:33 PM · Restricted Project
Kayjukh created D78823: [llvm][CodeGen] Check for memory instructions when querying for alias status.
Apr 24 2020, 12:26 PM · Restricted Project

Apr 21 2020

Kayjukh committed rG585a0af3790a: [mlir][NFC] Fix typo in the standalone dialect README. (authored by Kayjukh).
[mlir][NFC] Fix typo in the standalone dialect README.
Apr 21 2020, 8:04 AM

Apr 7 2020

Kayjukh added a comment to D77643: Keep output file after successful execution of mlir-opt.

I think it would make sense to propagate the changes to mlir-opt as well.

The changes to mlir-opt.cpp propagate the change of the file-management to mlir-opt. Or did you refer to something else?

Apr 7 2020, 11:55 AM · Restricted Project
Kayjukh added inline comments to D77643: Keep output file after successful execution of mlir-opt.
Apr 7 2020, 11:55 AM · Restricted Project
Kayjukh added inline comments to D77643: Keep output file after successful execution of mlir-opt.
Apr 7 2020, 9:12 AM · Restricted Project
Kayjukh added a comment to D77643: Keep output file after successful execution of mlir-opt.

I think it would make sense to propagate the changes to mlir-opt as well.

Apr 7 2020, 9:12 AM · Restricted Project

Apr 6 2020

Kayjukh committed rGd3df2da4a94c: [mlir] Fix typo in docs/DefiningAttributesAndTypes.md (authored by Kayjukh).
[mlir] Fix typo in docs/DefiningAttributesAndTypes.md
Apr 6 2020, 10:52 AM

Apr 4 2020

Kayjukh added a comment to D77133: [mlir] Add an out-of-tree dialect example.

Thanks for taking the time to comment on this.

Apr 4 2020, 2:30 AM · Restricted Project

Apr 3 2020

Kayjukh added inline comments to D77133: [mlir] Add an out-of-tree dialect example.
Apr 3 2020, 3:11 PM · Restricted Project
Kayjukh added inline comments to D77133: [mlir] Add an out-of-tree dialect example.
Apr 3 2020, 10:15 AM · Restricted Project
Kayjukh accepted D77133: [mlir] Add an out-of-tree dialect example.
Apr 3 2020, 8:02 AM · Restricted Project
Kayjukh updated the diff for D77133: [mlir] Add an out-of-tree dialect example.

Remove the using namespace directives in the standalone-opt source file. This follows standard coding guidelines and code styles of other out-of-tree MLIR projects.

Apr 3 2020, 8:02 AM · Restricted Project
Kayjukh accepted D77133: [mlir] Add an out-of-tree dialect example.
Apr 3 2020, 5:52 AM · Restricted Project
Kayjukh updated the diff for D77133: [mlir] Add an out-of-tree dialect example.

Minor update: remove unneeded braces at the end of the TableGen description for Standalone_Op.

Apr 3 2020, 2:39 AM · Restricted Project

Apr 2 2020

Kayjukh updated the diff for D77133: [mlir] Add an out-of-tree dialect example.

Further simplify the standalone-opt CMakeLists.txt by reflecting the changes on master for mlir-opt (commit b8c260c38d0ae93f8ae037fc1e9b94695b06d7ec).

Apr 2 2020, 3:45 AM · Restricted Project

Apr 1 2020

Kayjukh accepted D77133: [mlir] Add an out-of-tree dialect example.
Apr 1 2020, 11:31 AM · Restricted Project
Kayjukh updated the diff for D77133: [mlir] Add an out-of-tree dialect example.

The custom standalone.foo operation now makes use of the declarative assembly syntax form instead of manually providing a parser and a printer.

Apr 1 2020, 3:52 AM · Restricted Project

Mar 31 2020

Kayjukh accepted D77133: [mlir] Add an out-of-tree dialect example.
Mar 31 2020, 6:12 PM · Restricted Project
Kayjukh updated the diff for D77133: [mlir] Add an out-of-tree dialect example.

The main dialect include file now includes the tablegen'd declaration of the dialect instead of providing it manually.

Mar 31 2020, 6:12 PM · Restricted Project
Kayjukh added a comment to D77133: [mlir] Add an out-of-tree dialect example.

This is fantastic, thanks.

  1. Would it be possible to use libMLIR.so and a plugin library?
  2. LLVM opt has a -load option that allows one to load new passes. So I can do opt -load=libjulia.so and load all the Julia passes and then run them as part of opt.
Mar 31 2020, 5:39 PM · Restricted Project
Kayjukh accepted D77133: [mlir] Add an out-of-tree dialect example.
Mar 31 2020, 5:39 PM · Restricted Project
Kayjukh updated the diff for D77133: [mlir] Add an out-of-tree dialect example.

This update adds build instructions to the README file as well as an example of a user-defined operation.

Mar 31 2020, 5:39 PM · Restricted Project
Kayjukh updated the summary of D77133: [mlir] Add an out-of-tree dialect example.
Mar 31 2020, 4:23 AM · Restricted Project
Kayjukh retitled D77133: [mlir] Add an out-of-tree dialect example from Add an out-of-tree dialect example to [mlir] Add an out-of-tree dialect example.
Mar 31 2020, 4:23 AM · Restricted Project
Kayjukh created D77133: [mlir] Add an out-of-tree dialect example.
Mar 31 2020, 4:23 AM · Restricted Project