- User Since
- Mar 31 2020, 3:33 AM (8 w, 2 h)
Fri, May 22
Sure. I didn't realize it would cause such an overhead. If I remember correctly, some MachineInstr instances sometimes have duplicate memory operands for the same load or store.
Thu, May 21
@efriedma Thanks for your feedback! I had to make some minor adjustments to ARM test cases. If it's still good for you, I will land the patch.
Update FileCheck directives in
llvm/test/CodeGen/ARM/cortex-a57-misched-vldm-wrback.ll llvm/test/CodeGen/ARM/cortex-a57-misched-vstm-wrback.ll llvm/test/CodeGen/ARM/cortex-a57-misched-vstm.ll
to avoid matching the new instruction scheduler debug output.
Add some debug output to the instruction sheduler to signal wether or not a chain dependency has been added between two given instructions. This change allows us to properly test the effect of handling multiple memory operands in alias queries on instruction scheduling.
Wed, May 20
Also propagate memory operands when folding non-MOV instructions. Add a test case.
Tue, May 19
Simplify the method's control flow by wrapping the old dependency checking code in a helper lambda and calling it for each pair of memory operands.
Mon, May 18
Update instruction ordering in failing test cases.
Add a test case.
Split the call frame optimization patch from the ISel DAG postprocessing patch.
LGTM after fixing the use of curly braces.
Sat, May 16
Also propagate store memory operands during call frame optimization.
Thu, May 14
Tue, May 5
Tue, Apr 28
nit: The commit message looks a little convoluted. Maybe you could simplify/structure it a little bit.
Apr 24 2020
It is just a cleanup. I ran into an issue related to this missing check in an out-of-tree project.
Apr 21 2020
Apr 7 2020
I think it would make sense to propagate the changes to mlir-opt as well.
Apr 6 2020
Apr 4 2020
Thanks for taking the time to comment on this.
Apr 3 2020
Remove the using namespace directives in the standalone-opt source file. This follows standard coding guidelines and code styles of other out-of-tree MLIR projects.
Minor update: remove unneeded braces at the end of the TableGen description for Standalone_Op.
Apr 2 2020
Further simplify the standalone-opt CMakeLists.txt by reflecting the changes on master for mlir-opt (commit b8c260c38d0ae93f8ae037fc1e9b94695b06d7ec).
Apr 1 2020
The custom standalone.foo operation now makes use of the declarative assembly syntax form instead of manually providing a parser and a printer.
Mar 31 2020
The main dialect include file now includes the tablegen'd declaration of the dialect instead of providing it manually.
This update adds build instructions to the README file as well as an example of a user-defined operation.