Page MenuHomePhabricator

[CMake] Enforce the minimum CMake version to be at least 3.13.4
ClosedPublic

Authored by ldionne on Apr 22 2020, 8:25 AM.

Details

Summary

This commit changes the warning for CMake < 3.13.4 into a fatal error.
The intent is to revert and re-apply this simple commit until all build
bots are migrated to CMake >= 3.13.4.

This is part of the effort discussed on llvm-dev here:

http://lists.llvm.org/pipermail/llvm-dev/2020-April/140578.html

Diff Detail

Event Timeline

ldionne created this revision.Apr 22 2020, 8:25 AM

This review is for the upcoming CMake upgrade once we branch off the LLVM 11 release branch.

I won't apply it until after the branch has been created, which is around July.

Hmm, won't you be doing the upgrade by changing the cmake_minimum_required to 3.13.4? At that point, the fatal error would never be triggered, right?

Hmm, won't you be doing the upgrade by changing the cmake_minimum_required to 3.13.4? At that point, the fatal error would never be triggered, right?

This patch is meant to be as tiny as possible, because I expect to apply/revert it perhaps several times. The child patch https://reviews.llvm.org/D78648 is the one that will finish the job once this patch finally triggers no more errors.

smeenai accepted this revision.Apr 22 2020, 11:59 AM

Ah, makes sense. LGTM to ship after the branch cut!

This revision is now accepted and ready to land.Apr 22 2020, 11:59 AM

I'm pushing this now folks! Let's see what burns.

This revision was automatically updated to reflect the committed changes.