Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

whisperity (Whisperity)
Research

Projects

User does not belong to any projects.

User Details

User Since
Dec 6 2016, 10:52 AM (355 w, 6 d)

Recent Activity

Jul 6 2023

whisperity requested changes to D146712: [clang-tidy] Add portability-non-portable-integer-constant check.

Earlier (IIRC in March) we did an internal test of the check and the following results were obtained. The results are kinda weird, to say the least. Numbers are after CodeChecker has done a serverside uniqueing (most likely things such as "if X in H.h is reported in the compilation/analysis of A.cpp and B.cpp then store X only once") of the bugs.

Jul 6 2023, 8:34 AM · Restricted Project, Restricted Project

Mar 23 2023

whisperity updated subscribers of D146712: [clang-tidy] Add portability-non-portable-integer-constant check.
Mar 23 2023, 5:28 AM · Restricted Project, Restricted Project

Feb 17 2023

whisperity updated subscribers of D140562: [clang][ASTImporter] Improve import of InjectedClassNameType..

@vabridgers Please take a look at this, as per off-list discussion, in relation to D142822.

Feb 17 2023, 5:44 AM · Restricted Project, Restricted Project
whisperity added inline comments to D140562: [clang][ASTImporter] Improve import of InjectedClassNameType..
Feb 17 2023, 5:39 AM · Restricted Project, Restricted Project
whisperity added inline comments to D142822: [clang] ASTImporter: Fix importing of va_list types and declarations.
Feb 17 2023, 5:29 AM · Restricted Project, Restricted Project, Restricted Project
whisperity added inline comments to D142822: [clang] ASTImporter: Fix importing of va_list types and declarations.
Feb 17 2023, 5:17 AM · Restricted Project, Restricted Project, Restricted Project
whisperity updated the summary of D142822: [clang] ASTImporter: Fix importing of va_list types and declarations.
Feb 17 2023, 5:14 AM · Restricted Project, Restricted Project, Restricted Project

Feb 15 2023

whisperity updated subscribers of D142822: [clang] ASTImporter: Fix importing of va_list types and declarations.
/home/david.spickett/llvm-project/clang/test/CodeGenCXX/cxx20-module-std-subst-2b.cpp:14:18: error: reference to 'std' is ambiguous
void f(str<char, std::char_traits<char>> &s) {
                 ^
/home/david.spickett/llvm-project/clang/test/CodeGenCXX/cxx20-module-std-subst-2b.cpp:7:11: note: candidate found by name lookup is 'std'
namespace std {
          ^
Feb 15 2023, 7:28 AM · Restricted Project, Restricted Project, Restricted Project

Feb 2 2023

whisperity added a comment to D91000: [clang-tidy] Add bugprone-unsafe-functions checker..

To XFAIL the test, grep for lines with "XFAIL" and "ps4" and you should find some examples. It was recently changed how it worked lately.

Feb 2 2023, 7:44 AM · Restricted Project, Restricted Project, Restricted Project
whisperity added a reverting change for rGed740e741ec2: [clang-tidy] Attempt fixing wrong caching result in `bugprone-unsafe-functions`: rG9225d08ccca5: [NFC][clang-tidy] Disable test for `bugprone-unsafe-functions` for PlayStation.
Feb 2 2023, 7:35 AM · Restricted Project, Restricted Project
whisperity committed rG9225d08ccca5: [NFC][clang-tidy] Disable test for `bugprone-unsafe-functions` for PlayStation (authored by whisperity).
[NFC][clang-tidy] Disable test for `bugprone-unsafe-functions` for PlayStation
Feb 2 2023, 7:35 AM · Restricted Project, Restricted Project
whisperity added a comment to D91000: [clang-tidy] Add bugprone-unsafe-functions checker..
-DLLVM_DEFAULT_TARGET_TRIPLE=x86_64-scei-ps4

Hopefully this can help you to reproduce the problem.

Feb 2 2023, 7:00 AM · Restricted Project, Restricted Project, Restricted Project
whisperity updated subscribers of D91000: [clang-tidy] Add bugprone-unsafe-functions checker..

Ping @dyung, it looks like you're the owner of the relevant build-bot. I can't find any information what x86_64-sie is...

Feb 2 2023, 6:41 AM · Restricted Project, Restricted Project, Restricted Project
whisperity committed rGed740e741ec2: [clang-tidy] Attempt fixing wrong caching result in `bugprone-unsafe-functions` (authored by whisperity).
[clang-tidy] Attempt fixing wrong caching result in `bugprone-unsafe-functions`
Feb 2 2023, 6:25 AM · Restricted Project, Restricted Project
whisperity added a comment to D91000: [clang-tidy] Add bugprone-unsafe-functions checker..

Alright, right now, I have no meaningful idea why this failure appears, locally I'm trying every test command as they appear in the test, and all the tests are passing. It's as if on that system the whole Annex K support would not be allowed. Locally I added a few debug prints and I'm getting the right answers for "Whether Annex K is allowed?".

Feb 2 2023, 6:16 AM · Restricted Project, Restricted Project, Restricted Project
whisperity added a comment to D91000: [clang-tidy] Add bugprone-unsafe-functions checker..

Oddly enough, one of the buildbots caught a not matching test that was working locally... on it.

Feb 2 2023, 5:55 AM · Restricted Project, Restricted Project, Restricted Project
whisperity committed rGf27c8ac83e7c: [clang-tidy] Add the `bugprone-unsafe-functions` check (authored by futogergely).
[clang-tidy] Add the `bugprone-unsafe-functions` check
Feb 2 2023, 5:12 AM · Restricted Project, Restricted Project
whisperity closed D91000: [clang-tidy] Add bugprone-unsafe-functions checker..
Feb 2 2023, 5:12 AM · Restricted Project, Restricted Project, Restricted Project
whisperity accepted D91000: [clang-tidy] Add bugprone-unsafe-functions checker..

Alright, I've done a full reanalysis after a rebase. Overhead is not meaningfully measurable, even for complex TUs such as LLVM. The check is viable in C++ code as it finds cases (such as the one described in LLVM, but also Bitcoin is a primarily C++ project), so I won't rework the check to disable it in C++ mode explicitly. It seems the name lookup is implemented pretty well, helped by the fact that the names to match are short. No crashes had been observed in the test projects; let's hope it stays the same way; the matchers themselves are simple enough. The Annex K. matcher is only registered if in >= C11 mode.
I've also gone through the discussion earlier, and it looks to me as if all the concerns were either resolved or made obsolete due to the evolution of the check.

Feb 2 2023, 5:11 AM · Restricted Project, Restricted Project, Restricted Project

Jan 31 2023

whisperity added a comment to D91000: [clang-tidy] Add bugprone-unsafe-functions checker..

Alright, the tests came back from the CI positively and there were no crashes on like 15 projects (about 50:50 C and C++). There are some nice results:

Jan 31 2023, 2:24 AM · Restricted Project, Restricted Project, Restricted Project

Jan 30 2023

whisperity added a comment to D91000: [clang-tidy] Add bugprone-unsafe-functions checker..

Tentative LGTM, will still need to run the "usual test projects" in the CI for confirmation. What's missing from this patch are the .rst files for the CERT-specific aliases of the check, but those are trivial and we can "add them in post" anyway.

Jan 30 2023, 6:37 AM · Restricted Project, Restricted Project, Restricted Project
whisperity added a comment to D91000: [clang-tidy] Add bugprone-unsafe-functions checker..

What we could do is:

  1. add a new checker option to decide if we suggest replacements from AnnexK. We could avoid registering matchers this way, but I don't really like this, having an option for something we could decide from the defined macros.
  2. As a TODO, we could make possible to register checkers AFTER the preprocessor is executed. I have not looked into this, so I don't really know if it is possible at all in the current architecture.
Jan 30 2023, 6:27 AM · Restricted Project, Restricted Project, Restricted Project

Oct 21 2022

whisperity updated subscribers of D134588: [clang-tidy] Fix bugprone-exception-escape warn on noexcept calls.
Oct 21 2022, 1:26 AM · Restricted Project, Restricted Project

Oct 17 2022

whisperity added a comment to D91000: [clang-tidy] Add bugprone-unsafe-functions checker..

My concern with that approach was that we pay the full expense of doing the matches only get get into the check() function to bail out on all the Annex K functions, but now that there are replacements outside of Annex K, I don't see a way around paying that expense, so I think my concern has been addressed as well as it could have been.

Oct 17 2022, 7:11 AM · Restricted Project, Restricted Project, Restricted Project

Oct 15 2022

whisperity added a comment to D91000: [clang-tidy] Add bugprone-unsafe-functions checker..

In terms of whether we should expose the check in C++: I think we shouldn't. [...]

I think we should probably also not enable the check when the user compiles in C99 or earlier mode, because there is no Annex K available to provide replacement functions.

@aaron.ballman I think the current version of the check satisfies these conditions. It seems the check will run for every TU, but in case there is no alternative the check could suggest, it will do nothing:

if (!ReplacementFunctionName)
  return;

Is this good enough? This seems more future-proof than juggling the LangOpts instance in yet another member function.

Oct 15 2022, 7:09 AM · Restricted Project, Restricted Project, Restricted Project

Sep 27 2022

whisperity added inline comments to D133119: [clang-tidy] Add checker 'bugprone-suspicious-realloc-usage'..
Sep 27 2022, 4:39 AM · Restricted Project, Restricted Project
whisperity added inline comments to D133119: [clang-tidy] Add checker 'bugprone-suspicious-realloc-usage'..
Sep 27 2022, 4:38 AM · Restricted Project, Restricted Project
whisperity added a comment to D133119: [clang-tidy] Add checker 'bugprone-suspicious-realloc-usage'..

I agree with @martong that $ = realloc($, ...) is indicative of something going wrong, even if the developer has saved the original value somewhere. Are we trying to catch this with Tidy specifically for this reason (instead of CSA's stdlib checker, or some taint-related mechanism?). However, @steakhal has some merit in saying that developers might prioritise the original over the copy, even if they made a copy. I think an easy solution from a documentation perspective is to have a test for this at the bottom of the test file. And document that we cannot (for one reason or the other) catch this supposed solution, but if you have made a copy already(!), then you might as well could have done void* q = realloc(p, ...) anyway! Having this documented leaves at least some paths open for us to fix false positives later, if they become a tremendous problem. (I have a gut feeling that they will not, that much.)

Sep 27 2022, 4:30 AM · Restricted Project, Restricted Project

Sep 5 2022

whisperity added a comment to D91000: [clang-tidy] Add bugprone-unsafe-functions checker..

Generally LGTM. Please revisit the documentation and let's fix the style, and then we can land.

Sep 5 2022, 5:37 AM · Restricted Project, Restricted Project, Restricted Project

Aug 30 2022

whisperity accepted D131500: [Docs][CodeReview] Add a small paragraph on adding tokens, NFC..

Sorry, I'm not sure how I missed it. Been on vacations and such... either way, I think documenting this is a good practice.

Aug 30 2022, 1:43 AM · Restricted Project, Restricted Project

Aug 9 2022

whisperity removed a reviewer for D131319: [clang-tidy] Update llvm-prefer-isa-or-dyn-cast-in-conditionals with new syntax: bzcheeseman.

This is great, thank you for doing this! I'm not a competent reviewer for the actual clang-tidy code changes but the +1 for the idea :)

Aug 9 2022, 6:30 AM · Restricted Project, Restricted Project
whisperity added inline comments to D131319: [clang-tidy] Update llvm-prefer-isa-or-dyn-cast-in-conditionals with new syntax.
Aug 9 2022, 6:28 AM · Restricted Project, Restricted Project
whisperity added a comment to D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..

I got here from D131319, but I am not sure why this change is only touching comments but not the hand-written documentation. Is this CastInfo an internal detail that should not be publicly documented to the everyday documentation reader? Are the old-style "classof" method and enums still applicable?

Aug 9 2022, 6:25 AM · Restricted Project, Restricted Project
whisperity accepted D118996: [clang-tidy] Support C++14 in bugprone-signal-handler..
Aug 9 2022, 6:00 AM · Restricted Project, Restricted Project

Aug 1 2022

whisperity accepted D118996: [clang-tidy] Support C++14 in bugprone-signal-handler..

Alright, I think we should have this in and let C++17 things to be future work. Please see the inline comment, but otherwise this should be good enough. Can always improve in a future version. 😉

Aug 1 2022, 3:55 AM · Restricted Project, Restricted Project

Jul 21 2022

whisperity added a comment to D124447: [clang-tidy] Add infrastructure support for running on project-level information.

I will attempt to write a concise response to this today (and tomorrow)! Sorry, I was away travelling to and doing post-action bureaucracy of conferences the past few weeks.

Jul 21 2022, 1:20 AM · Restricted Project, Restricted Project

Jul 14 2022

whisperity added a comment to D124447: [clang-tidy] Add infrastructure support for running on project-level information.

In general, I think this is looking pretty close to good. Whether clang-tidy should get this functionality in this form or not is a bit less clear to me. *I* think it's helpful functionality and the current approach is reasonable, but I think it might be worthwhile to have a community RFC to see if others agree. CC @alexfh in case he wants to make a code owner decision instead.

+1 to a need for the RFC here, there are ecosystem questions that I think should be addressed first but aren't in scope of this patch.

Jul 14 2022, 1:48 AM · Restricted Project, Restricted Project

Jun 22 2022

whisperity accepted D112916: [clang-tidy] Confusable identifiers detection.

LGTM. Thanks!

Jun 22 2022, 2:04 AM · Restricted Project, Restricted Project

Jun 20 2022

whisperity added a comment to D126891: [clang-tidy] The check should ignore final classes.

(Please ensure a more appropriate commit message that actually mentions the check when committing, @steakhal.)

Jun 20 2022, 12:32 AM · Restricted Project, Restricted Project
whisperity requested changes to D112916: [clang-tidy] Confusable identifiers detection.

Because of the stability issues related to getName()-like constructs I'm putting a temporary ❌ on this (so it doesn't show up as faux accept). However, I have to emphasise that I do like the idea of the check!

Jun 20 2022, 12:26 AM · Restricted Project, Restricted Project
whisperity added inline comments to D112916: [clang-tidy] Confusable identifiers detection.
Jun 20 2022, 12:22 AM · Restricted Project, Restricted Project

Jun 19 2022

whisperity added inline comments to D126247: [clang-tidy][doc] Document readability-indentifier-naming resolution order and examples.
Jun 19 2022, 11:59 PM · Restricted Project, Restricted Project
whisperity retitled D126247: [clang-tidy][doc] Document readability-indentifier-naming resolution order and examples from `readability-indentifier-naming` resolution order and examples to [clang-tidy][doc] Document readability-indentifier-naming resolution order and examples.
Jun 19 2022, 11:54 PM · Restricted Project, Restricted Project
whisperity accepted D126891: [clang-tidy] The check should ignore final classes.

Thank you!

Jun 19 2022, 11:36 PM · Restricted Project, Restricted Project

Jun 14 2022

whisperity added a comment to D127599: [clang] small speed improvement of Sema::AddArgumentDependentLookupCandidates.

The context of the diff is missing. Please re-run the diff making with -U9999999999999999999.

Jun 14 2022, 12:22 AM · Restricted Project, Restricted Project

May 22 2022

whisperity added a comment to D124446: [clang-tidy] Add the misc-discarded-return-value check.

@aaron.ballman [...] I think I can put in a measurement job [...]

May 22 2022, 9:14 AM · Restricted Project, Restricted Project

May 18 2022

whisperity added inline comments to D124446: [clang-tidy] Add the misc-discarded-return-value check.
May 18 2022, 2:51 AM · Restricted Project, Restricted Project
whisperity added inline comments to D124446: [clang-tidy] Add the misc-discarded-return-value check.
May 18 2022, 2:49 AM · Restricted Project, Restricted Project
whisperity added inline comments to D125769: [clang-tidy] Introduce the CheckHeaderFile option to modernize-deprecated-headers.
May 18 2022, 2:22 AM · Restricted Project, Restricted Project
whisperity added a comment to D125771: [clang-tidy] Add a useful note about -std=c++11-or-later.

I thought there wasn't any support for validating fixits applied to header files?

May 18 2022, 2:13 AM · Restricted Project, Restricted Project

May 17 2022

whisperity added inline comments to D124446: [clang-tidy] Add the misc-discarded-return-value check.
May 17 2022, 4:06 AM · Restricted Project, Restricted Project

May 16 2022

whisperity added inline comments to D124446: [clang-tidy] Add the misc-discarded-return-value check.
May 16 2022, 6:44 AM · Restricted Project, Restricted Project

May 13 2022

whisperity committed rG9add949557d2: [ASTMatchers][clang-tidy][NFC] Hoist `forEachTemplateArgument` matcher into the… (authored by whisperity).
[ASTMatchers][clang-tidy][NFC] Hoist `forEachTemplateArgument` matcher into the…
May 13 2022, 3:57 AM · Restricted Project, Restricted Project, Restricted Project
whisperity closed D125383: [ASTMatchers][clang-tidy][NFC] Hoist 'forEachTemplateArgument' matcher into the core library.
May 13 2022, 3:56 AM · Restricted Project, Restricted Project, Restricted Project
whisperity added a comment to D125383: [ASTMatchers][clang-tidy][NFC] Hoist 'forEachTemplateArgument' matcher into the core library.
May 13 2022, 1:30 AM · Restricted Project, Restricted Project, Restricted Project
whisperity updated the diff for D125383: [ASTMatchers][clang-tidy][NFC] Hoist 'forEachTemplateArgument' matcher into the core library.
  • Added to ASTMatchers/Registry.cpp
  • Updated with release notes
May 13 2022, 1:28 AM · Restricted Project, Restricted Project, Restricted Project

May 12 2022

whisperity added a comment to D125383: [ASTMatchers][clang-tidy][NFC] Hoist 'forEachTemplateArgument' matcher into the core library.

Do you expect to use this matcher in a new check in the immediate future?

May 12 2022, 7:47 AM · Restricted Project, Restricted Project, Restricted Project
whisperity accepted D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks.
May 12 2022, 4:14 AM · Restricted Project, Restricted Project
whisperity added a comment to D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks.

(Also: this is a fix to an issue of your own finding and not something that was reported on Bugzilla? Just to make sure we cross-reference and close tickets.)

May 12 2022, 3:20 AM · Restricted Project, Restricted Project
whisperity added a comment to D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks.

LGTM. Some typos inline. Also I think this is a significant enough bug-fix that it warrants an entry in the Release Notes under Changes to existing checks.

May 12 2022, 3:20 AM · Restricted Project, Restricted Project
whisperity added inline comments to D123773: [clang][analyzer][ctu] Make CTU a two phase analysis.
May 12 2022, 3:05 AM · Restricted Project, Restricted Project
whisperity added inline comments to D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks.
May 12 2022, 1:22 AM · Restricted Project, Restricted Project
whisperity added inline comments to D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks.
May 12 2022, 1:19 AM · Restricted Project, Restricted Project

May 11 2022

whisperity added inline comments to D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks.
May 11 2022, 10:34 AM · Restricted Project, Restricted Project
whisperity added a comment to D124447: [clang-tidy] Add infrastructure support for running on project-level information.

precommit CI is showing a fair amount of failures that I believe are related to your patch.

I have no idea what is causing the CI issues, because all the CI issues are related to unit test libraries removing const from fixits and such(??) which this patch (or any in the current patch set) doesn't even touch, at all. I did run the test targets locally... it's likely that simply the rebase and the push happened against an unclean/breaking main branch...

Rebase & rerun against a current main branch produces the issues locally for me, too. So far I have no idea what might be causing this, but I'll keep on digging. However, let's continue with discussing the general approach meanwhile. 🙂

May 11 2022, 9:56 AM · Restricted Project, Restricted Project
whisperity added a comment to D118996: [clang-tidy] Support C++14 in bugprone-signal-handler..

@njames93 What do you think about the current approach? It will under-approximate the problem-inducing node set but at least cover what we know about C++ now.

May 11 2022, 9:44 AM · Restricted Project, Restricted Project
whisperity added a comment to D91000: [clang-tidy] Add bugprone-unsafe-functions checker..

Just one question if you could try this out for me: what happens if you run clang-tidy a.c b.c (two TUs in the invocation) where one of them (preferably the later one, i.e. b.c) does NOT have Annex K enabled? I believe the cached IsAnnexKAvailable (like any other TU-specific state of the check instance) should be invalidated/cleared in an overridden void onStartTranslationUnit() function.

May 11 2022, 9:28 AM · Restricted Project, Restricted Project, Restricted Project
whisperity added a comment to D124447: [clang-tidy] Add infrastructure support for running on project-level information.

precommit CI is showing a fair amount of failures that I believe are related to your patch.

I have no idea what is causing the CI issues, because all the CI issues are related to unit test libraries removing const from fixits and such(??) which this patch (or any in the current patch set) doesn't even touch, at all. I did run the test targets locally... it's likely that simply the rebase and the push happened against an unclean/breaking main branch...

May 11 2022, 9:12 AM · Restricted Project, Restricted Project
whisperity added inline comments to D124446: [clang-tidy] Add the misc-discarded-return-value check.
May 11 2022, 6:41 AM · Restricted Project, Restricted Project
whisperity requested review of D125383: [ASTMatchers][clang-tidy][NFC] Hoist 'forEachTemplateArgument' matcher into the core library.
May 11 2022, 6:36 AM · Restricted Project, Restricted Project, Restricted Project
whisperity committed rG06a98328fc7b: [ASTMatchers][NFC] Fix name of matcher in docs and add a missing test (authored by whisperity).
[ASTMatchers][NFC] Fix name of matcher in docs and add a missing test
May 11 2022, 5:16 AM · Restricted Project, Restricted Project

May 5 2022

whisperity added a comment to D124447: [clang-tidy] Add infrastructure support for running on project-level information.

precommit CI is showing a fair amount of failures that I believe are related to your patch.

May 5 2022, 7:52 AM · Restricted Project, Restricted Project

Apr 30 2022

whisperity added a comment to D124705: [ADT][NFC] Add missing closing comment for `llvm` namespace.

This is unrelated to Clang-Tidy, the change affects the LLVM ADT library.

Apr 30 2022, 5:12 AM · Restricted Project, Restricted Project
whisperity retitled D124705: [ADT][NFC] Add missing closing comment for `llvm` namespace from [clang-tidy] Add missing closing comment for `llvm` namespace to [ADT][NFC] Add missing closing comment for `llvm` namespace.
Apr 30 2022, 5:10 AM · Restricted Project, Restricted Project

Apr 28 2022

Herald added a project to D114317: [clang-tidy][WIP] Do not run perfect alias checks: Restricted Project.
Apr 28 2022, 4:55 AM · Restricted Project, Restricted Project
whisperity closed D123065: [clang-tidy] support --load in clang-tidy-diff.py/run-clang-tidy.py.
Apr 28 2022, 4:53 AM · Restricted Project, Restricted Project
whisperity added a comment to D123065: [clang-tidy] support --load in clang-tidy-diff.py/run-clang-tidy.py.

D'oh! I made a mistake when copying the URL and accidentally associated the commit with D12306 instead of D123065... Anyhow, this was committed in rGb1f1688e90b22dedc829f5abc9a912f18c034fbc.

Apr 28 2022, 4:53 AM · Restricted Project, Restricted Project
whisperity committed rGb1f1688e90b2: [clang-tidy] support --load in clang-tidy-diff.py/run-clang-tidy.py (authored by bernhardmgruber).
[clang-tidy] support --load in clang-tidy-diff.py/run-clang-tidy.py
Apr 28 2022, 4:51 AM · Restricted Project, Restricted Project
Herald added a reviewer for D12306: [OpenMP] Implement the creation and registration of the offloading descriptor.: jdoerfert.
Apr 28 2022, 4:51 AM · Restricted Project
whisperity added a reviewer for D124446: [clang-tidy] Add the misc-discarded-return-value check: baloghadamsoftware.
Apr 28 2022, 4:46 AM · Restricted Project, Restricted Project

Apr 27 2022

whisperity updated subscribers of D124448: [clang-tidy] Add project-level analysis support to misc-discarded-return-value.
Apr 27 2022, 1:50 AM · Restricted Project, Restricted Project
whisperity updated subscribers of D124447: [clang-tidy] Add infrastructure support for running on project-level information.
Apr 27 2022, 1:50 AM · Restricted Project, Restricted Project
whisperity added a reviewer for D124446: [clang-tidy] Add the misc-discarded-return-value check: steakhal.
Apr 27 2022, 1:50 AM · Restricted Project, Restricted Project

Apr 26 2022

whisperity added a comment to D123065: [clang-tidy] support --load in clang-tidy-diff.py/run-clang-tidy.py.

Ping.

Can someone merge this please for me? Thank you!

Apr 26 2022, 6:40 AM · Restricted Project, Restricted Project
whisperity added a comment to D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`.

Regarding FixIts... FixIts are implemented in the "Diagnostic" library, which is non-specific to neither Clang-Tidy nor Sema whatsoever, they use the same infrastructure under the hood. Why the apply logic in CSA might do the same FixIt multiple times is beyond me, but I know that both clang-apply-replacements and clang-tidy go to length to ensure that in case multiple checkers report to the same location with potentially conflicting FixIts, then none gets applied, because applying all of them would result in ridiculously broken source code. They internally become an object in the clang::tooling namespace which is implemented as a core Clang library. The relevant entrypoint to this logic, at least in Clang-Tidy, should be this one: http://github.com/llvm/llvm-project/blob/8f9dd5e608c0ac201ab682ccc89ac3be2dfd0d29/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp#L115-L134

Apr 26 2022, 1:50 AM · Restricted Project, Restricted Project
whisperity added a comment to D118996: [clang-tidy] Support C++14 in bugprone-signal-handler..

After adding improvements to the documentation, I think this will be good to go, and thank you! Perhaps just for a safety measure you could run it on a few projects (LLVM itself?) to ensure we didn't miss a case where it might magically crash, but I wonder how many specifically "C++14" projects will use signal handlers in the first place.

Apr 26 2022, 1:08 AM · Restricted Project, Restricted Project

Apr 20 2022

whisperity committed rGf4834815f439: [clang-tidy] Fix crash on calls to overloaded operators in `llvmlibc-callee… (authored by whisperity).
[clang-tidy] Fix crash on calls to overloaded operators in `llvmlibc-callee…
Apr 20 2022, 1:16 AM · Restricted Project, Restricted Project
whisperity closed D123992: [clang-tidy] Fix crash on calls to overloaded operators in llvmlibc-callee-namespace.
Apr 20 2022, 1:16 AM · Restricted Project, Restricted Project

Apr 19 2022

whisperity updated the diff for D123992: [clang-tidy] Fix crash on calls to overloaded operators in llvmlibc-callee-namespace.

[NFC] Fix the test.

Apr 19 2022, 5:16 AM · Restricted Project, Restricted Project
whisperity accepted D114292: [clang-tidy] Fix `altera-struct-pack-align` check for empty structs.

@aaron.ballman Alright, I think this can go. The ReleaseNotes.rst needs a rebase anyway.

Apr 19 2022, 2:34 AM · Restricted Project, Restricted Project
whisperity requested review of D123992: [clang-tidy] Fix crash on calls to overloaded operators in llvmlibc-callee-namespace.
Apr 19 2022, 2:30 AM · Restricted Project, Restricted Project

Mar 30 2022

whisperity added a comment to D121387: [analyzer] ClangSA should tablegen doc urls refering to the main doc page.

(Side note: you should avoid the list-expansion syntax in URLs because browsers do not understand them and result in links that are not leading anywhere.)

Mar 30 2022, 2:39 AM · Restricted Project, Restricted Project

Mar 29 2022

whisperity added inline comments to D118996: [clang-tidy] Support C++14 in bugprone-signal-handler..
Mar 29 2022, 2:24 AM · Restricted Project, Restricted Project
whisperity accepted D118370: [clang-tidy] bugprone-signal-handler: Message improvement and code refactoring..

Alright, I think this is good to go. I like that it makes it clear that the called function is coming from some external source (system header or otherwise).

Mar 29 2022, 2:17 AM · Restricted Project, Restricted Project

Mar 17 2022

whisperity added inline comments to D118370: [clang-tidy] bugprone-signal-handler: Message improvement and code refactoring..
Mar 17 2022, 6:32 AM · Restricted Project, Restricted Project

Mar 10 2022

whisperity added a comment to D121214: [clang-tidy][docs][NFC] Refer to the CERT rule in bugprone-shared-ptr-array-mismatch docs.

Drop the alias-related changes and preserve the note in the bugprone-shared-ptr-array-mismatch.rst stating this relationship with the cert rule?
If we do it like that, then this will be again NFC.

Mar 10 2022, 2:03 AM · Restricted Project, Restricted Project

Mar 9 2022

whisperity added a comment to D121214: [clang-tidy][docs][NFC] Refer to the CERT rule in bugprone-shared-ptr-array-mismatch docs.

I have some concerns about this. While it is now clear to me that the partialness refers to partial coverage of the guideline rule, it is indeed very, very partial. MEM51-CPP as of now lists 9 cases of non-compliant examples, from which std::shared_ptr<T> = new S[8]; is just one. bugprone-shared-ptr-array-mismatch (D117306) in itself is a check that inherits from a "more generic" smart pointer check.

Mar 9 2022, 5:28 AM · Restricted Project, Restricted Project

Mar 8 2022

whisperity added a comment to D121214: [clang-tidy][docs][NFC] Refer to the CERT rule in bugprone-shared-ptr-array-mismatch docs.

Is "partial aliasing" a new notion? Or... is the alias not partial, but the coverage?

Mar 8 2022, 9:52 AM · Restricted Project, Restricted Project

Mar 1 2022

whisperity added a reviewer for D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.: whisperity.
Mar 1 2022, 3:53 AM · Restricted Project, Restricted Project
whisperity added a comment to D120555: [clang-tidy] Fix `readability-suspicious-call-argument` crash for arguments without name-like identifier .

If you backport, the release notes change on trunk should then be reverted.

Mar 1 2022, 3:19 AM · Restricted Project