Page MenuHomePhabricator

whisperity (Whisperity)
Research

Projects

User does not belong to any projects.

User Details

User Since
Dec 6 2016, 10:52 AM (291 w, 19 h)

Recent Activity

Wed, Jun 22

whisperity accepted D112916: [clang-tidy] Confusable identifiers detection.

LGTM. Thanks!

Wed, Jun 22, 2:04 AM · Restricted Project, Restricted Project

Mon, Jun 20

whisperity added a comment to D126891: [clang-tidy] The check should ignore final classes.

(Please ensure a more appropriate commit message that actually mentions the check when committing, @steakhal.)

Mon, Jun 20, 12:32 AM · Restricted Project, Restricted Project
whisperity requested changes to D112916: [clang-tidy] Confusable identifiers detection.

Because of the stability issues related to getName()-like constructs I'm putting a temporary ❌ on this (so it doesn't show up as faux accept). However, I have to emphasise that I do like the idea of the check!

Mon, Jun 20, 12:26 AM · Restricted Project, Restricted Project
whisperity added inline comments to D112916: [clang-tidy] Confusable identifiers detection.
Mon, Jun 20, 12:22 AM · Restricted Project, Restricted Project

Sun, Jun 19

whisperity added inline comments to D126247: [clang-tidy][doc] Document readability-indentifier-naming resolution order and examples.
Sun, Jun 19, 11:59 PM · Restricted Project, Restricted Project
whisperity retitled D126247: [clang-tidy][doc] Document readability-indentifier-naming resolution order and examples from `readability-indentifier-naming` resolution order and examples to [clang-tidy][doc] Document readability-indentifier-naming resolution order and examples.
Sun, Jun 19, 11:54 PM · Restricted Project, Restricted Project
whisperity accepted D126891: [clang-tidy] The check should ignore final classes.

Thank you!

Sun, Jun 19, 11:36 PM · Restricted Project, Restricted Project

Tue, Jun 14

whisperity added a comment to D127599: [clang] small speed improvement of Sema::AddArgumentDependentLookupCandidates.

The context of the diff is missing. Please re-run the diff making with -U9999999999999999999.

Tue, Jun 14, 12:22 AM · Restricted Project, Restricted Project

May 22 2022

whisperity added a comment to D124446: [clang-tidy] Add the misc-discarded-return-value check.

@aaron.ballman [...] I think I can put in a measurement job [...]

May 22 2022, 9:14 AM · Restricted Project, Restricted Project

May 18 2022

whisperity added inline comments to D124446: [clang-tidy] Add the misc-discarded-return-value check.
May 18 2022, 2:51 AM · Restricted Project, Restricted Project
whisperity added inline comments to D124446: [clang-tidy] Add the misc-discarded-return-value check.
May 18 2022, 2:49 AM · Restricted Project, Restricted Project
whisperity added inline comments to D125769: [clang-tidy] Introduce the CheckHeaderFile option to modernize-deprecated-headers.
May 18 2022, 2:22 AM · Restricted Project, Restricted Project
whisperity added a comment to D125771: [clang-tidy] Add a useful note about -std=c++11-or-later.

I thought there wasn't any support for validating fixits applied to header files?

May 18 2022, 2:13 AM · Restricted Project, Restricted Project

May 17 2022

whisperity added inline comments to D124446: [clang-tidy] Add the misc-discarded-return-value check.
May 17 2022, 4:06 AM · Restricted Project, Restricted Project

May 16 2022

whisperity added inline comments to D124446: [clang-tidy] Add the misc-discarded-return-value check.
May 16 2022, 6:44 AM · Restricted Project, Restricted Project

May 13 2022

whisperity committed rG9add949557d2: [ASTMatchers][clang-tidy][NFC] Hoist `forEachTemplateArgument` matcher into the… (authored by whisperity).
[ASTMatchers][clang-tidy][NFC] Hoist `forEachTemplateArgument` matcher into the…
May 13 2022, 3:57 AM · Restricted Project, Restricted Project, Restricted Project
whisperity closed D125383: [ASTMatchers][clang-tidy][NFC] Hoist 'forEachTemplateArgument' matcher into the core library.
May 13 2022, 3:56 AM · Restricted Project, Restricted Project, Restricted Project
whisperity added a comment to D125383: [ASTMatchers][clang-tidy][NFC] Hoist 'forEachTemplateArgument' matcher into the core library.
May 13 2022, 1:30 AM · Restricted Project, Restricted Project, Restricted Project
whisperity updated the diff for D125383: [ASTMatchers][clang-tidy][NFC] Hoist 'forEachTemplateArgument' matcher into the core library.
  • Added to ASTMatchers/Registry.cpp
  • Updated with release notes
May 13 2022, 1:28 AM · Restricted Project, Restricted Project, Restricted Project

May 12 2022

whisperity added a comment to D125383: [ASTMatchers][clang-tidy][NFC] Hoist 'forEachTemplateArgument' matcher into the core library.

Do you expect to use this matcher in a new check in the immediate future?

May 12 2022, 7:47 AM · Restricted Project, Restricted Project, Restricted Project
whisperity accepted D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks.
May 12 2022, 4:14 AM · Restricted Project, Restricted Project
whisperity added a comment to D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks.

(Also: this is a fix to an issue of your own finding and not something that was reported on Bugzilla? Just to make sure we cross-reference and close tickets.)

May 12 2022, 3:20 AM · Restricted Project, Restricted Project
whisperity added a comment to D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks.

LGTM. Some typos inline. Also I think this is a significant enough bug-fix that it warrants an entry in the Release Notes under Changes to existing checks.

May 12 2022, 3:20 AM · Restricted Project, Restricted Project
whisperity added inline comments to D123773: [clang][analyzer][ctu] Make CTU a two phase analysis.
May 12 2022, 3:05 AM · Restricted Project, Restricted Project
whisperity added inline comments to D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks.
May 12 2022, 1:22 AM · Restricted Project, Restricted Project
whisperity added inline comments to D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks.
May 12 2022, 1:19 AM · Restricted Project, Restricted Project

May 11 2022

whisperity added inline comments to D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks.
May 11 2022, 10:34 AM · Restricted Project, Restricted Project
whisperity added a comment to D124447: [clang-tidy] Add infrastructure support for running on project-level information.

precommit CI is showing a fair amount of failures that I believe are related to your patch.

I have no idea what is causing the CI issues, because all the CI issues are related to unit test libraries removing const from fixits and such(??) which this patch (or any in the current patch set) doesn't even touch, at all. I did run the test targets locally... it's likely that simply the rebase and the push happened against an unclean/breaking main branch...

Rebase & rerun against a current main branch produces the issues locally for me, too. So far I have no idea what might be causing this, but I'll keep on digging. However, let's continue with discussing the general approach meanwhile. 🙂

May 11 2022, 9:56 AM · Restricted Project, Restricted Project
whisperity added a comment to D118996: [clang-tidy] Support C++14 in bugprone-signal-handler..

@njames93 What do you think about the current approach? It will under-approximate the problem-inducing node set but at least cover what we know about C++ now.

May 11 2022, 9:44 AM · Restricted Project, Restricted Project
whisperity added a comment to D91000: [clang-tidy] Add bugprone-unsafe-functions checker..

Just one question if you could try this out for me: what happens if you run clang-tidy a.c b.c (two TUs in the invocation) where one of them (preferably the later one, i.e. b.c) does NOT have Annex K enabled? I believe the cached IsAnnexKAvailable (like any other TU-specific state of the check instance) should be invalidated/cleared in an overridden void onStartTranslationUnit() function.

May 11 2022, 9:28 AM · Restricted Project, Restricted Project, Restricted Project
whisperity added a comment to D124447: [clang-tidy] Add infrastructure support for running on project-level information.

precommit CI is showing a fair amount of failures that I believe are related to your patch.

I have no idea what is causing the CI issues, because all the CI issues are related to unit test libraries removing const from fixits and such(??) which this patch (or any in the current patch set) doesn't even touch, at all. I did run the test targets locally... it's likely that simply the rebase and the push happened against an unclean/breaking main branch...

May 11 2022, 9:12 AM · Restricted Project, Restricted Project
whisperity added inline comments to D124446: [clang-tidy] Add the misc-discarded-return-value check.
May 11 2022, 6:41 AM · Restricted Project, Restricted Project
whisperity requested review of D125383: [ASTMatchers][clang-tidy][NFC] Hoist 'forEachTemplateArgument' matcher into the core library.
May 11 2022, 6:36 AM · Restricted Project, Restricted Project, Restricted Project
whisperity committed rG06a98328fc7b: [ASTMatchers][NFC] Fix name of matcher in docs and add a missing test (authored by whisperity).
[ASTMatchers][NFC] Fix name of matcher in docs and add a missing test
May 11 2022, 5:16 AM · Restricted Project, Restricted Project

May 5 2022

whisperity added a comment to D124447: [clang-tidy] Add infrastructure support for running on project-level information.

precommit CI is showing a fair amount of failures that I believe are related to your patch.

May 5 2022, 7:52 AM · Restricted Project, Restricted Project

Apr 30 2022

whisperity added a comment to D124705: [ADT][NFC] Add missing closing comment for `llvm` namespace.

This is unrelated to Clang-Tidy, the change affects the LLVM ADT library.

Apr 30 2022, 5:12 AM · Restricted Project, Restricted Project
whisperity retitled D124705: [ADT][NFC] Add missing closing comment for `llvm` namespace from [clang-tidy] Add missing closing comment for `llvm` namespace to [ADT][NFC] Add missing closing comment for `llvm` namespace.
Apr 30 2022, 5:10 AM · Restricted Project, Restricted Project

Apr 28 2022

Herald added a project to D114317: [clang-tidy][WIP] Do not run perfect alias checks: Restricted Project.
Apr 28 2022, 4:55 AM · Restricted Project, Restricted Project
whisperity closed D123065: [clang-tidy] support --load in clang-tidy-diff.py/run-clang-tidy.py.
Apr 28 2022, 4:53 AM · Restricted Project, Restricted Project
whisperity added a comment to D123065: [clang-tidy] support --load in clang-tidy-diff.py/run-clang-tidy.py.

D'oh! I made a mistake when copying the URL and accidentally associated the commit with D12306 instead of D123065... Anyhow, this was committed in rGb1f1688e90b22dedc829f5abc9a912f18c034fbc.

Apr 28 2022, 4:53 AM · Restricted Project, Restricted Project
whisperity committed rGb1f1688e90b2: [clang-tidy] support --load in clang-tidy-diff.py/run-clang-tidy.py (authored by bernhardmgruber).
[clang-tidy] support --load in clang-tidy-diff.py/run-clang-tidy.py
Apr 28 2022, 4:51 AM · Restricted Project, Restricted Project
Herald added a reviewer for D12306: [OpenMP] Implement the creation and registration of the offloading descriptor.: jdoerfert.
Apr 28 2022, 4:51 AM · Restricted Project
whisperity added a reviewer for D124446: [clang-tidy] Add the misc-discarded-return-value check: baloghadamsoftware.
Apr 28 2022, 4:46 AM · Restricted Project, Restricted Project

Apr 27 2022

whisperity updated subscribers of D124448: [clang-tidy] Add project-level analysis support to misc-discarded-return-value.
Apr 27 2022, 1:50 AM · Restricted Project, Restricted Project
whisperity updated subscribers of D124447: [clang-tidy] Add infrastructure support for running on project-level information.
Apr 27 2022, 1:50 AM · Restricted Project, Restricted Project
whisperity added a reviewer for D124446: [clang-tidy] Add the misc-discarded-return-value check: steakhal.
Apr 27 2022, 1:50 AM · Restricted Project, Restricted Project

Apr 26 2022

whisperity added a comment to D123065: [clang-tidy] support --load in clang-tidy-diff.py/run-clang-tidy.py.

Ping.

Can someone merge this please for me? Thank you!

Apr 26 2022, 6:40 AM · Restricted Project, Restricted Project
whisperity added a comment to D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`.

Regarding FixIts... FixIts are implemented in the "Diagnostic" library, which is non-specific to neither Clang-Tidy nor Sema whatsoever, they use the same infrastructure under the hood. Why the apply logic in CSA might do the same FixIt multiple times is beyond me, but I know that both clang-apply-replacements and clang-tidy go to length to ensure that in case multiple checkers report to the same location with potentially conflicting FixIts, then none gets applied, because applying all of them would result in ridiculously broken source code. They internally become an object in the clang::tooling namespace which is implemented as a core Clang library. The relevant entrypoint to this logic, at least in Clang-Tidy, should be this one: http://github.com/llvm/llvm-project/blob/8f9dd5e608c0ac201ab682ccc89ac3be2dfd0d29/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp#L115-L134

Apr 26 2022, 1:50 AM · Restricted Project, Restricted Project
whisperity added a comment to D118996: [clang-tidy] Support C++14 in bugprone-signal-handler..

After adding improvements to the documentation, I think this will be good to go, and thank you! Perhaps just for a safety measure you could run it on a few projects (LLVM itself?) to ensure we didn't miss a case where it might magically crash, but I wonder how many specifically "C++14" projects will use signal handlers in the first place.

Apr 26 2022, 1:08 AM · Restricted Project, Restricted Project

Apr 20 2022

whisperity committed rGf4834815f439: [clang-tidy] Fix crash on calls to overloaded operators in `llvmlibc-callee… (authored by whisperity).
[clang-tidy] Fix crash on calls to overloaded operators in `llvmlibc-callee…
Apr 20 2022, 1:16 AM · Restricted Project, Restricted Project
whisperity closed D123992: [clang-tidy] Fix crash on calls to overloaded operators in llvmlibc-callee-namespace.
Apr 20 2022, 1:16 AM · Restricted Project, Restricted Project

Apr 19 2022

whisperity updated the diff for D123992: [clang-tidy] Fix crash on calls to overloaded operators in llvmlibc-callee-namespace.

[NFC] Fix the test.

Apr 19 2022, 5:16 AM · Restricted Project, Restricted Project
whisperity accepted D114292: [clang-tidy] Fix `altera-struct-pack-align` check for empty structs.

@aaron.ballman Alright, I think this can go. The ReleaseNotes.rst needs a rebase anyway.

Apr 19 2022, 2:34 AM · Restricted Project, Restricted Project
whisperity requested review of D123992: [clang-tidy] Fix crash on calls to overloaded operators in llvmlibc-callee-namespace.
Apr 19 2022, 2:30 AM · Restricted Project, Restricted Project

Mar 30 2022

whisperity added a comment to D121387: [analyzer] ClangSA should tablegen doc urls refering to the main doc page.

(Side note: you should avoid the list-expansion syntax in URLs because browsers do not understand them and result in links that are not leading anywhere.)

Mar 30 2022, 2:39 AM · Restricted Project, Restricted Project

Mar 29 2022

whisperity added inline comments to D118996: [clang-tidy] Support C++14 in bugprone-signal-handler..
Mar 29 2022, 2:24 AM · Restricted Project, Restricted Project
whisperity accepted D118370: [clang-tidy] bugprone-signal-handler: Message improvement and code refactoring..

Alright, I think this is good to go. I like that it makes it clear that the called function is coming from some external source (system header or otherwise).

Mar 29 2022, 2:17 AM · Restricted Project, Restricted Project

Mar 17 2022

whisperity added inline comments to D118370: [clang-tidy] bugprone-signal-handler: Message improvement and code refactoring..
Mar 17 2022, 6:32 AM · Restricted Project, Restricted Project

Mar 10 2022

whisperity added a comment to D121214: [clang-tidy][docs][NFC] Refer to the CERT rule in bugprone-shared-ptr-array-mismatch docs.

Drop the alias-related changes and preserve the note in the bugprone-shared-ptr-array-mismatch.rst stating this relationship with the cert rule?
If we do it like that, then this will be again NFC.

Mar 10 2022, 2:03 AM · Restricted Project, Restricted Project

Mar 9 2022

whisperity added a comment to D121214: [clang-tidy][docs][NFC] Refer to the CERT rule in bugprone-shared-ptr-array-mismatch docs.

I have some concerns about this. While it is now clear to me that the partialness refers to partial coverage of the guideline rule, it is indeed very, very partial. MEM51-CPP as of now lists 9 cases of non-compliant examples, from which std::shared_ptr<T> = new S[8]; is just one. bugprone-shared-ptr-array-mismatch (D117306) in itself is a check that inherits from a "more generic" smart pointer check.

Mar 9 2022, 5:28 AM · Restricted Project, Restricted Project

Mar 8 2022

whisperity added a comment to D121214: [clang-tidy][docs][NFC] Refer to the CERT rule in bugprone-shared-ptr-array-mismatch docs.

Is "partial aliasing" a new notion? Or... is the alias not partial, but the coverage?

Mar 8 2022, 9:52 AM · Restricted Project, Restricted Project

Mar 1 2022

whisperity added a reviewer for D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.: whisperity.
Mar 1 2022, 3:53 AM · Restricted Project, Restricted Project
whisperity added a comment to D120555: [clang-tidy] Fix `readability-suspicious-call-argument` crash for arguments without name-like identifier .

If you backport, the release notes change on trunk should then be reverted.

Mar 1 2022, 3:19 AM · Restricted Project
whisperity committed rG94850918274c: [NFC][clang-tidy][docs] Remove mention of backported fix of `readability… (authored by whisperity).
[NFC][clang-tidy][docs] Remove mention of backported fix of `readability…
Mar 1 2022, 3:09 AM
whisperity added a reviewer for D118370: [clang-tidy] bugprone-signal-handler: Message improvement and code refactoring.: whisperity.

This generally looks good, and thank you! I have a few minor comments (mostly presentation and documentation).

Mar 1 2022, 2:27 AM · Restricted Project, Restricted Project

Feb 28 2022

whisperity added a comment to D120555: [clang-tidy] Fix `readability-suspicious-call-argument` crash for arguments without name-like identifier .

If you backport, the release notes change on trunk should then be reverted.

Feb 28 2022, 1:48 AM · Restricted Project

Feb 25 2022

whisperity added a comment to D120555: [clang-tidy] Fix `readability-suspicious-call-argument` crash for arguments without name-like identifier .

Thanks! I'll re-run the tests on top of 14.0 and do the backport too, soon. 🙂

Feb 25 2022, 7:36 AM · Restricted Project
whisperity committed rG416e689ecda6: [clang-tidy] Fix `readability-suspicious-call-argument` crash for arguments… (authored by whisperity).
[clang-tidy] Fix `readability-suspicious-call-argument` crash for arguments…
Feb 25 2022, 7:25 AM
whisperity closed D120555: [clang-tidy] Fix `readability-suspicious-call-argument` crash for arguments without name-like identifier .
Feb 25 2022, 7:25 AM · Restricted Project
whisperity updated the diff for D120555: [clang-tidy] Fix `readability-suspicious-call-argument` crash for arguments without name-like identifier .

Added Release notes entry.

Feb 25 2022, 7:25 AM · Restricted Project
whisperity requested review of D120555: [clang-tidy] Fix `readability-suspicious-call-argument` crash for arguments without name-like identifier .
Feb 25 2022, 5:25 AM · Restricted Project

Jan 24 2022

whisperity added a reviewer for D91000: [clang-tidy] Add bugprone-unsafe-functions checker.: whisperity.

Bump! Thanks @futogergely for picking up @ktomi996's work, and @steakhal for the help given during the implementation process!

Jan 24 2022, 4:41 AM · Restricted Project, Restricted Project, Restricted Project
whisperity committed rG3696c70e67d9: [clang-tidy] Add `readability-container-contains` check (authored by avogelsgesang).
[clang-tidy] Add `readability-container-contains` check
Jan 24 2022, 3:57 AM
whisperity closed D112646: [clang-tidy] Add `readability-container-contains` check.
Jan 24 2022, 3:57 AM · Restricted Project
whisperity accepted D112646: [clang-tidy] Add `readability-container-contains` check.

Please specify what name and e-mail address you'd like to have the Git commit author attributed with!

Jan 24 2022, 3:52 AM · Restricted Project
whisperity added a comment to D112646: [clang-tidy] Add `readability-container-contains` check.

@xazax.hun Can you please merge this to main on my behalf? (I don't have commit rights)

Jan 24 2022, 3:24 AM · Restricted Project

Nov 30 2021

whisperity added a comment to D91000: [clang-tidy] Add bugprone-unsafe-functions checker..

Should/does this work in C++ mode for std::whatever?

Nov 30 2021, 5:57 AM · Restricted Project, Restricted Project, Restricted Project

Nov 26 2021

whisperity added inline comments to D114197: [clang-tidy] Fix false positives involving type aliases in `misc-unconventional-assign-operator` check.
Nov 26 2021, 5:03 AM · Restricted Project
whisperity added inline comments to D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression.
Nov 26 2021, 4:55 AM · Restricted Project
whisperity added a comment to D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression.

I haven't looked at the patch in detail yet, but I know I've run into the issue this aims to fix when developing a Tidy check!

Nov 26 2021, 4:32 AM · Restricted Project
whisperity retitled D114602: [clang-tidy][docs][NFC] Improve documentation of bugprone-unhandled-exception-at-new from [clang-tidy] Improve documentation of bugprone-unhandled-exception-at-new [NFC] to [clang-tidy][docs][NFC] Improve documentation of bugprone-unhandled-exception-at-new.
Nov 26 2021, 4:28 AM · Restricted Project
whisperity added inline comments to D114602: [clang-tidy][docs][NFC] Improve documentation of bugprone-unhandled-exception-at-new.
Nov 26 2021, 4:28 AM · Restricted Project
whisperity added a comment to D113804: [clang-tidy] Fix behavior of `modernize-use-using` with nested structs/unions.

hasParent() is the direct upwards traversal, right? I remember some discussion about matchers like that being potentially costly. But I can't find any description of this, so I guess it's fine, rewriting the matcher to have the opposite logic (decl(hasDescendant(...the-real-matcher-here...)).bind("blah")) would just make everything ugly for no tangible benefit.

Nov 26 2021, 1:34 AM · Restricted Project, Restricted Project
whisperity added a comment to D113518: [clang][Sema] Create delegating constructors even in templates.

Thanks for the finding and sorry for delaying the review, I didn't know that :( Do you know if there's an option for signaling "LGTM but I want someone else to review?". Otherwise I can just leave a comment and don't accept the revision.

Nov 26 2021, 12:52 AM · Restricted Project, Restricted Project
whisperity edited reviewers for D113518: [clang][Sema] Create delegating constructors even in templates, added: Quuxplusone; removed: carlosgalvezp, whisperity.

(@carlosgalvezp Removing you from reviewers so the patch shows up as not yet reviewed for others! The significant part is the Sema which should be reviewed.)

Nov 26 2021, 12:39 AM · Restricted Project, Restricted Project
whisperity retitled D113518: [clang][Sema] Create delegating constructors even in templates from [clang] Create delegating constructors even in templates to [clang][Sema] Create delegating constructors even in templates.
Nov 26 2021, 12:38 AM · Restricted Project, Restricted Project
whisperity requested changes to D114292: [clang-tidy] Fix `altera-struct-pack-align` check for empty structs.

I believe this is worth a note in the ReleaseNotes.rst file. People who might have disabled the check specifically for the reason outlined in the PR would get to know it's safe to reenable it.

Nov 26 2021, 12:33 AM · Restricted Project, Restricted Project
whisperity added a comment to D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.

This generally looks fine for me, but I'd rather have other people who are more knowledgeable about the standard's intricacies looked at it too.

Nov 26 2021, 12:28 AM · Restricted Project
whisperity added a comment to D112646: [clang-tidy] Add `readability-container-contains` check.

Thank you, this is getting much better!

Nov 26 2021, 12:23 AM · Restricted Project
whisperity accepted D113558: [clang-tidy] Fix cppcoreguidelines-virtual-base-class-destructor in macros.

I'm not sure if it is a good idea to merge things on a Friday, but I am comfortable with this, let's get the check crash less.

Nov 26 2021, 12:12 AM · Restricted Project

Nov 22 2021

whisperity added inline comments to D114254: [libtooling][clang-tidy] Fix crashing on rendering invalid SourceRanges.
Nov 22 2021, 1:49 AM · Restricted Project

Nov 18 2021

whisperity added inline comments to D114149: [clang-tidy] Fix pr48613: "llvm-header-guard uses a reserved identifier".
Nov 18 2021, 4:53 AM · Restricted Project
whisperity added inline comments to D113251: [analyzer][doc] Add user documenation for taint analysis.
Nov 18 2021, 4:50 AM · Restricted Project
whisperity added a comment to D113004: [analyzer][docs] Add Configuration section to user-docs.

As a user, I'm not sure if this would be the right way moving forward. This patch conflates a lot of parallel (but related) executions of the idea. (I'm not against introducing points 1 and 2 in the same patch, but do not feel like it's right to do it this way!)

Nov 18 2021, 3:07 AM · Restricted Project
whisperity added inline comments to D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields.
Nov 18 2021, 12:06 AM · Restricted Project

Nov 17 2021

whisperity added a comment to D113588: [analyzer][NFC] Make the API of CallDescription safer slightly.

I've accidentally committed this without mentioning the Differential Revision stuff in the commit message. :(
This landed with 35ff3a0095d5b2dafa2fc8dd762377342aef9c50

How to address this?

Nov 17 2021, 7:21 AM

Nov 16 2021

whisperity added inline comments to D112646: [clang-tidy] Add `readability-container-contains` check.
Nov 16 2021, 2:44 AM · Restricted Project
whisperity added a comment to D112646: [clang-tidy] Add `readability-container-contains` check.

So I guess the name would have to be container-count-begin-end-contains or similar... which would be a bit much in my opinion

Nov 16 2021, 2:42 AM · Restricted Project
whisperity added inline comments to D112646: [clang-tidy] Add `readability-container-contains` check.
Nov 16 2021, 2:39 AM · Restricted Project

Nov 15 2021

whisperity added inline comments to D113804: [clang-tidy] Fix behavior of `modernize-use-using` with nested structs/unions.
Nov 15 2021, 4:27 AM · Restricted Project, Restricted Project