Page MenuHomePhabricator

whisperity (Whisperity)
Research

Projects

User does not belong to any projects.

User Details

User Since
Dec 6 2016, 10:52 AM (197 w, 4 d)

Recent Activity

Mon, Sep 14

whisperity added inline comments to D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer.
Mon, Sep 14, 2:51 AM · Restricted Project, Restricted Project
whisperity added a comment to D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer.

Minor inline comments.

Mon, Sep 14, 2:50 AM · Restricted Project, Restricted Project

Fri, Sep 11

whisperity added a comment to D87527: [ASTMatchers] Fix `hasBody` for the descendants of `FunctionDecl`.

What about http://clang.llvm.org/doxygen/classclang_1_1CXXConversionDecl.html ?

Fri, Sep 11, 10:15 AM · Restricted Project

Mon, Sep 7

whisperity added a comment to D86446: [analyzer][docs][NFC] Document the ento namespace in the llvm/Lexicon.

One minor "typo", otherwise I think we are saying everything that could be and needs to be said. Also, @steakhal, that must have been one massive blame.

Mon, Sep 7, 5:45 AM · Restricted Project

Wed, Aug 26

whisperity added inline comments to D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes.
Wed, Aug 26, 5:25 AM · Restricted Project
whisperity added inline comments to D86446: [analyzer][docs][NFC] Document the ento namespace in the llvm/Lexicon.
Wed, Aug 26, 4:07 AM · Restricted Project
whisperity added inline comments to D86446: [analyzer][docs][NFC] Document the ento namespace in the llvm/Lexicon.
Wed, Aug 26, 3:00 AM · Restricted Project

Tue, Aug 25

whisperity added inline comments to D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes.
Tue, Aug 25, 5:46 AM · Restricted Project
whisperity added a comment to D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes.

Some grammatical fixes and suggestions, inline. I might have absolutely butchered 80-col in the suggestions (thanks Phab for not showing any indication of line length...), so make sure you manually reformat the document before going forward!

Tue, Aug 25, 5:41 AM · Restricted Project

Mon, Aug 24

whisperity added inline comments to D86446: [analyzer][docs][NFC] Document the ento namespace in the llvm/Lexicon.
Mon, Aug 24, 10:21 AM · Restricted Project
whisperity added inline comments to D86446: [analyzer][docs][NFC] Document the ento namespace in the llvm/Lexicon.
Mon, Aug 24, 10:21 AM · Restricted Project

Aug 14 2020

whisperity added a comment to D81272: [clang-tidy] New check `bugprone-redundant-branch-condition`.

While I agree with your observation about data and flow sensitivity, I approved on the belief that the check as-is provides enough utility to warrant adding it as-is. If someone wants to improve the check into being a CSA check, we can always deprecate this one at that point. However, if there are strong opinions that the check should start out as a CSA check because it requires that sensitivity for your needs, now's a good time to bring up those concerns.

Aug 14 2020, 8:09 AM · Restricted Project, Restricted Project
whisperity added a comment to D81272: [clang-tidy] New check `bugprone-redundant-branch-condition`.

Thanks to the new info, I think the check basically LGTM. Can you add some negative tests and documentation wording to make it clear that the check doesn't currently handle all logically equivalent predicates, like:

if (foo) {
} else {
  if (!foo) {
  }
}

// or
if (foo > 5) {
  if (foo > 3) {
  }
}

// or
if (foo > 5) {
  if (5 < foo) {
  }
}

(I'm assuming these cases aren't handled currently and that handling them isn't necessary to land the patch.)

Aug 14 2020, 7:29 AM · Restricted Project, Restricted Project
whisperity awarded D81272: [clang-tidy] New check `bugprone-redundant-branch-condition` a Baby Tequila token.
Aug 14 2020, 7:28 AM · Restricted Project, Restricted Project

Aug 13 2020

whisperity added inline comments to D85728: [Analyzer] Support for the new variadic isa<> and isa_and_not_null<> in CastValueChecker.
Aug 13 2020, 2:16 AM · Restricted Project

Aug 12 2020

whisperity added a comment to D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'..

More results in CodeChecker: emacs_errorreturn

Aug 12 2020, 8:34 AM · Restricted Project
whisperity added a comment to D85752: [Analyzer] Store the pointed/referenced type for dynamic casts.

@baloghadamsoftware Maybe there is a typo in the summary of the patch

Aug 12 2020, 1:47 AM · Restricted Project

Aug 11 2020

whisperity updated the summary of D85728: [Analyzer] Support for the new variadic isa<> and isa_and_not_null<> in CastValueChecker.
Aug 11 2020, 6:30 AM · Restricted Project

Aug 10 2020

whisperity added inline comments to D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine.
Aug 10 2020, 6:26 AM · Restricted Project
whisperity added a comment to D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker..

Do the null pointer and invalid pointer dereference belong to the same checker, that is called NullDereference?

Aug 10 2020, 3:04 AM · Restricted Project

Aug 7 2020

whisperity added inline comments to D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine.
Aug 7 2020, 9:23 AM · Restricted Project
whisperity added inline comments to D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine.
Aug 7 2020, 9:22 AM · Restricted Project

Aug 5 2020

whisperity updated subscribers of D85319: [analyzer][RFC] Get info from the LLVM IR for precision.

What will happen with the ability to analyse a translation unit whose target was not part of LLVM_TARGETS_TO_BUILD of the current clang binary? Will it break, because the binary lacks the information on how to generate for the given target?

Aug 5 2020, 9:01 AM · Restricted Project
whisperity added inline comments to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.
Aug 5 2020, 5:05 AM · Restricted Project, Restricted Project, Restricted Project

Aug 3 2020

whisperity added inline comments to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.
Aug 3 2020, 5:25 AM · Restricted Project, Restricted Project, Restricted Project
whisperity added a comment to D75229: [clang-tidy] Add signal-in-multithreaded-program check.

I have managed to improve the checker, but could not set up the test files to work only in POSIX platforms. Could you help me or show me an example?

Aug 3 2020, 4:35 AM · Restricted Project, Restricted Project
whisperity added inline comments to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.
Aug 3 2020, 3:54 AM · Restricted Project, Restricted Project, Restricted Project

Jul 30 2020

whisperity updated the diff for D84176: [CMake][CTE] Add "check-clang-extra-..." targets to test only a particular Clang extra tool.

After using this for a while, it feels more natural and more obvious that these are the CTE targets, not the "clang/tools" test targets.

Jul 30 2020, 7:15 AM · Restricted Project, Restricted Project

Jul 29 2020

whisperity added inline comments to D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor.
Jul 29 2020, 6:02 AM · Restricted Project

Jul 28 2020

whisperity added a comment to D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling.

Since the analyzer cannot cannot model the size of the containers just yet (or precisely enough), what we are saying with this checker is to "always check the return value of the erase() function before use (for increment/decrement etc.) whether it is not past-end" .

Adam, are you sure that the user would like to enforce such a generic coding rule? Depending on the actual code analyzed, this would require this clumsy check at potentially too many places.

Jul 28 2020, 8:39 AM · Restricted Project

Jul 21 2020

whisperity added a comment to D84176: [CMake][CTE] Add "check-clang-extra-..." targets to test only a particular Clang extra tool.

@lebedev.ri If you have an idea on who's competent in accepting this change, please update the reviewers field, I'm in the dark here.

Jul 21 2020, 1:55 AM · Restricted Project, Restricted Project

Jul 20 2020

Herald added a project to D84176: [CMake][CTE] Add "check-clang-extra-..." targets to test only a particular Clang extra tool: Restricted Project.
Jul 20 2020, 8:17 AM · Restricted Project, Restricted Project

Jul 14 2020

Herald added projects to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C: Restricted Project, Restricted Project.
Jul 14 2020, 7:06 AM · Restricted Project, Restricted Project, Restricted Project

Jul 9 2020

whisperity added inline comments to D79437: [clang-tidy] Add fsetpos argument checker.
Jul 9 2020, 1:58 AM · Restricted Project
whisperity added inline comments to D77493: [clang-tidy] Add do-not-refer-atomic-twice check.
Jul 9 2020, 1:32 AM · Restricted Project, Restricted Project
whisperity added a comment to D75229: [clang-tidy] Add signal-in-multithreaded-program check.

In general, the test files should be cleaned up.

Jul 9 2020, 1:13 AM · Restricted Project, Restricted Project

Jul 2 2020

whisperity committed rG4cf24cb868b9: [NFC][clang] Add missing VALIDATE_DIAG_SIZE() (authored by whisperity).
[NFC][clang] Add missing VALIDATE_DIAG_SIZE()
Jul 2 2020, 5:21 AM

Jun 26 2020

whisperity added inline comments to D80504: [analyzer] CERT STR rule checkers: STR50-CPP.
Jun 26 2020, 6:30 AM · Restricted Project

Jun 25 2020

whisperity added a comment to D81272: [clang-tidy] New check `bugprone-redundant-branch-condition`.

As a future work, when something support ifs, it should also support ?:, and eliminate redundant conditionals from there, too.

Jun 25 2020, 2:08 AM · Restricted Project, Restricted Project

Jun 9 2020

whisperity added inline comments to D75665: [analyzer] On-demand parsing capability for CTU.
Jun 9 2020, 7:39 AM · Restricted Project

May 28 2020

whisperity resigned from D75665: [analyzer] On-demand parsing capability for CTU.
May 28 2020, 1:02 AM · Restricted Project

May 15 2020

whisperity added a comment to D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow..

I was looking at CERT ARR32-C "Ensure size arguments for variable length arrays are in a valid range". The VLA should not have a size that is larger than std::numeric_limits<size_t>::max(), in other words "fit into a size_t value", or not?

Yes creating the too large VLA in itself is not a bug, only when sizeof is called on it because it can not return the correct size. A non-fatal error is a better option, or delay the check until the sizeof call. But probably the create of such a big array in itself is sign of code smell. The array actually does not need to be created to make the problem happen, only a sizeof call on a typedef-ed and too large VLA. (What does mean that "result of sizeof is implementation-defined"? Probably it can return not the size in bytes or "chars" but something other? In such a case the checker would be not correct.)

May 15 2020, 3:02 AM · Restricted Project
whisperity added inline comments to D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow..
May 15 2020, 2:19 AM · Restricted Project

May 12 2020

whisperity requested changes to D75665: [analyzer] On-demand parsing capability for CTU.

(Maybe this will make Phab not show "✅ Accepted"...)

May 12 2020, 4:47 AM · Restricted Project
whisperity added a comment to D75665: [analyzer] On-demand parsing capability for CTU.

Please check the summary of the patch, it seems to contain old information as well.

May 12 2020, 4:47 AM · Restricted Project

May 6 2020

whisperity retitled D79415: [analyzer][MallocChecker] When modeling realloc-like functions, don't early return if the argument is symbolic from [analyzer][MalloChecker] When modeling realloc-like functions, don't early return if the argument is symbolic to [analyzer][MallocChecker] When modeling realloc-like functions, don't early return if the argument is symbolic.
May 6 2020, 5:20 AM · Restricted Project

Apr 24 2020

whisperity added inline comments to D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor.
Apr 24 2020, 3:13 AM · Restricted Project
whisperity added a comment to D78457: [analyzer][Z3-refutation] Fix a refutation BugReporterVisitor bug.

@steakhal You might want to update the patch summary before committing this to the upstream (it still mentions "not needing a visitor" 😄)

Apr 24 2020, 2:40 AM · Restricted Project

Apr 23 2020

whisperity planned changes to D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check.
Apr 23 2020, 3:45 AM · Restricted Project, Restricted Project
whisperity updated the summary of D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check.
Apr 23 2020, 3:45 AM · Restricted Project, Restricted Project
whisperity updated the diff for D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check.

First things first, we were 50 thousand (!) patches behind reality. Rebased to master. Fixed it to compile, too. Otherwise, NFC so far.

Apr 23 2020, 3:45 AM · Restricted Project, Restricted Project
whisperity commandeered D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check.

Assuming direct control. Previous colleagues and university mates departed for snowier pastures, time to try to do something with this check.

Apr 23 2020, 3:45 AM · Restricted Project, Restricted Project
Herald added a reviewer for D78648: [CMake] Bump CMake minimum version to 3.13.4: ftynse.
Apr 23 2020, 3:13 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
whisperity added inline comments to D75665: [analyzer] On-demand parsing capability for CTU.
Apr 23 2020, 3:13 AM · Restricted Project

Apr 22 2020

whisperity added inline comments to D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.
Apr 22 2020, 10:19 AM · Restricted Project, Restricted Project
whisperity added inline comments to D75041: [clang-tidy] Approximate implicit conversion issues in 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type'.
Apr 22 2020, 10:19 AM · Restricted Project, Restricted Project
whisperity retitled D75041: [clang-tidy] Approximate implicit conversion issues in 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' from [WIP][clang-tidy] Approximate implicit conversion issues for the 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check to [clang-tidy] Approximate implicit conversion issues for the 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.
Apr 22 2020, 10:19 AM · Restricted Project, Restricted Project
whisperity updated the diff for D75041: [clang-tidy] Approximate implicit conversion issues in 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type'.
  • Re-organised code, removed debug prints, rebased, the usual tidy-up.
  • Bug fixes on certain crashes like incomplete types, conversion operator templates, etc.
  • Even more bug fixes against crashes, hopefully... sorry I lost the individual commits in a squash I think
Apr 22 2020, 10:19 AM · Restricted Project, Restricted Project
whisperity created D78652: [clang-tidy] Add "ignore related parameters" heuristics to 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type'.
Apr 22 2020, 9:46 AM · Restricted Project, Restricted Project
whisperity updated the diff for D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.
  • Better organisation of code, cleanup of debug prints, fix nomenclature of functions
  • Explicitly mention the first and last param of the range for clarity
  • Downlift the logic of joining and breaking ranges to main patch (this isn't terribly useful at this point, but both subsequent improvements to the check depend on this change)
    • Basically no longer assume that if param N can be swapped with param 1, then it can also be swapped with 2, 3, etc. without checking.
  • Made the list of ignored parameter and type names configurable as a checker option
  • Changed the default value of MinimumLength to 2, as prescribed in the guideline's text.
Apr 22 2020, 9:46 AM · Restricted Project, Restricted Project
whisperity updated the summary of D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.
Apr 22 2020, 9:46 AM · Restricted Project, Restricted Project

Apr 21 2020

whisperity added inline comments to D77745: [analyzer] ASTMatchers: Extend with Static Analyzer data types.
Apr 21 2020, 8:37 AM · Restricted Project
whisperity added inline comments to D75665: [analyzer] On-demand parsing capability for CTU.
Apr 21 2020, 8:04 AM · Restricted Project

Apr 14 2020

whisperity added a reviewer for D78009: [analyzer][NFC] Remove SummaryManager.h: martong.

Adding @martong, he might have knowledge about the whole summary thing as he's tinkering the(?) STL checker.

Apr 14 2020, 8:32 AM · Restricted Project

Mar 23 2020

whisperity planned changes to D76545: [clang-tidy] Add a new check group 'experimental-'.
Mar 23 2020, 12:00 PM · Restricted Project, Restricted Project
whisperity added a comment to D76545: [clang-tidy] Add a new check group 'experimental-'.

@aaron.ballman @njames93 Should I write up a pitch mail to cfe-dev about this?

Mar 23 2020, 3:48 AM · Restricted Project, Restricted Project
whisperity committed rGdf5fa4873976: [clang-tidy][NFC] Add missing check group docs and order entries (authored by whisperity).
[clang-tidy][NFC] Add missing check group docs and order entries
Mar 23 2020, 3:16 AM
whisperity closed D76541: [clang-tidy][NFC] Add missing check group docs and order entries.
Mar 23 2020, 3:15 AM · Restricted Project, Restricted Project
whisperity added a comment to D76545: [clang-tidy] Add a new check group 'experimental-'.

I think we want to keep the experimental checks grouped to their parent module rather than being in a module of their own.

Mar 23 2020, 3:15 AM · Restricted Project, Restricted Project
whisperity added a comment to D76541: [clang-tidy][NFC] Add missing check group docs and order entries.

Forgive me if I'm wrong, but these kinds of changes typically don't require a review.

Mar 23 2020, 3:15 AM · Restricted Project, Restricted Project

Mar 21 2020

whisperity updated the diff for D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.
  • Renamed check to experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type.
  • s/argument/parameter/g in the code and output where appropriate.
Mar 21 2020, 5:53 AM · Restricted Project, Restricted Project
whisperity created D76545: [clang-tidy] Add a new check group 'experimental-'.
Mar 21 2020, 5:53 AM · Restricted Project, Restricted Project
whisperity updated the diff for D76541: [clang-tidy][NFC] Add missing check group docs and order entries.

ClangTidyForceLinker.h also contained the entries without alphabetic order.

Mar 21 2020, 5:53 AM · Restricted Project, Restricted Project
whisperity added a comment to D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.

@aaron.ballman I've gone over LLVM (and a few other projects). Some general observations:

Mar 21 2020, 5:20 AM · Restricted Project, Restricted Project
whisperity created D76541: [clang-tidy][NFC] Add missing check group docs and order entries.
Mar 21 2020, 3:43 AM · Restricted Project, Restricted Project

Mar 17 2020

whisperity added inline comments to D76287: [analysis][analyzer] Introduce the skeleton of a reaching definitions calculator.
Mar 17 2020, 10:43 AM · Restricted Project

Feb 26 2020

whisperity added a comment to D75171: [Analyzer] Fix for incorrect use of container and iterator checkers.

Also, errors should conceptually break the operation at hand, so this thing should be a warning instead?

Feb 26 2020, 8:04 AM · Restricted Project
whisperity added a comment to D75171: [Analyzer] Fix for incorrect use of container and iterator checkers.

Do you have access to the Driver somehow? Instead of a cerr (-ish) output, something that is formatted like a "true" error diagnostic (or warning), such as "no such file or directory" would be much better, I fear this [ERROR] will simply be flooded away with the usual diagnostic output on screen, especially if multiple files are concerned.

Feb 26 2020, 7:55 AM · Restricted Project

Feb 25 2020

whisperity added a reviewer for D75041: [clang-tidy] Approximate implicit conversion issues in 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type': aaron.ballman.

WIP because there's a lot of debug stuff that should be cleared out from here. This is a crude patch. It works fancy, but the code is crude.

Feb 25 2020, 5:59 AM · Restricted Project, Restricted Project
whisperity added a comment to D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.

Btw, we should update the terminology in the patch to use parameter instead of argument (parameters are what the function declares, arguments are what are passed in at the call site and they bind to parameters -- the issue this check is trying to solve is on the declaration side, not the caller side).

Feb 25 2020, 5:59 AM · Restricted Project, Restricted Project
whisperity added a comment to D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.

@aaron.ballman @vingeldal I'll go over the findings (as I've run this on LLVM and various other projects, a few examples are uploaded in my first comment as HTML renders of the bug report!) soon, but I want to wait until a research paper I have based on this topic gets a final decision. (It should happen soon.) I also plan to refurbish D20689 and have it upstreamed as a "co-checker" of this (one for the interface rule, one for the call sites, they kinda want to solve different aspects of the same issue, let it be up for the project how much they wish to enforce).

Feb 25 2020, 5:49 AM · Restricted Project, Restricted Project
whisperity added a comment to D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.

I think this value very well may strike a good balance in that compromise but I still think it is a clear deviation from the guideline as specified.
IMO all deviations from the guideline should be explicitly requested by the user, not set by default, no matter how useful that deviation is.

Feb 25 2020, 1:10 AM · Restricted Project, Restricted Project
whisperity added a comment to D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.

Doesn't clang-tidy exclude warnings from system headers by default though?

Third-party SDKs are not always brought in as system headers, unfortunately. Even ignoring system and third-party headers, having two parameters of the same type is a natural occurrence for some data types (like bool) where it is going to be extremely hard to tell whether they're related or unrelated parameters.

Feb 25 2020, 1:01 AM · Restricted Project, Restricted Project

Feb 24 2020

whisperity added a comment to D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.

I am also concerned about the false positives from this check because I don't think there's going to be an easy heuristic for determining whether two identifiers are "related" to one another.

Feb 24 2020, 8:49 AM · Restricted Project, Restricted Project
whisperity added a comment to D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.

I'd rather not call them false positive because the definition of false positive is ugly and mushy with regards to this check. This check attempts to enforce an interface rule, whether you(r project) wants to adhere the rule is a concise decision. A type equivalence (or convertibility in case of the follow-up patch D75041 that considers implicit conversions) should be a "true positive" in every case, as an indicator of potentially bad design.

Feb 24 2020, 8:49 AM · Restricted Project, Restricted Project
whisperity planned changes to D75041: [clang-tidy] Approximate implicit conversion issues in 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type'.
Feb 24 2020, 5:01 AM · Restricted Project, Restricted Project
whisperity created D75041: [clang-tidy] Approximate implicit conversion issues in 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type'.
Feb 24 2020, 5:01 AM · Restricted Project, Restricted Project

Jan 1 2020

whisperity planned changes to D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.

There are a few really minor bug fixes, test additions, documentation update, etc. coming along soon, but I've some more pressing matters. However, please feel free to review the patch as-is!

Jan 1 2020, 12:40 PM · Restricted Project, Restricted Project

Dec 31 2019

whisperity added a comment to D71963: clang-tidy doc: Add the severities description.

@vingeldal Apologies, in that case. However, I would still claim that style (as a potential severity) has its purpose for Tidy checkers, not just for clang-format.

Dec 31 2019, 4:04 AM · Restricted Project

Dec 30 2019

whisperity added a comment to D71963: clang-tidy doc: Add the severities description.
  • Style: things that are handled by clang-format rather than clang-tidy.
Dec 30 2019, 5:35 AM · Restricted Project

Dec 24 2019

whisperity added a comment to D70876: [clang-tidy] Add spuriously-wake-up-functions check.

The checks.rst has recently been updated to show "normal" (main entry) checks and "aliases" in different tables in D36051. Please register the alias-ness accordingly.

Dec 24 2019, 3:56 AM · Restricted Project, Restricted Project
whisperity committed rG002e07208a67: [clang] [ast] CXXRecordDecl::getVisibleConversionFunctions() could be const (authored by whisperity).
[clang] [ast] CXXRecordDecl::getVisibleConversionFunctions() could be const
Dec 24 2019, 2:16 AM
whisperity closed D71805: [clang] [ast] CXXRecordDecl::getVisibleConversionFunctions() could be const.
Dec 24 2019, 2:16 AM · Restricted Project

Dec 22 2019

whisperity updated subscribers of D71805: [clang] [ast] CXXRecordDecl::getVisibleConversionFunctions() could be const.
Dec 22 2019, 5:07 AM · Restricted Project
whisperity created D71805: [clang] [ast] CXXRecordDecl::getVisibleConversionFunctions() could be const.
Dec 22 2019, 5:05 AM · Restricted Project

Dec 20 2019

whisperity added a comment to D36051: Move from a long list of checkers to tables.

I am a little bit conflicted about the Severity column. While I know our people put a great deal of effort into keeping this classification sane, what was put into CodeChecker is, at the end of the day, a pretty arbitrary classification.

Dec 20 2019, 8:29 AM · Restricted Project
whisperity added a comment to D36051: Move from a long list of checkers to tables.


here is the result

Dec 20 2019, 5:12 AM · Restricted Project

Dec 17 2019

whisperity added a comment to D71612: [analyzer] Add PlacementNewChecker.

Are buffers otherwise modelled by the Analyser, such as results of the malloc family and alloca intentionally not matched, or are there some tests missing regarding this?

Dec 17 2019, 8:57 AM · Restricted Project

Dec 12 2019

whisperity added a comment to D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check.

I have developed a related check in D69560. That one considers types, but is an interface rule checker, and does not consider (any) potential call sites. Moreover, it does not consider "swaps" that happen across a function call, only, as the name implies, adjacent similar-type ranges.

Dec 12 2019, 2:53 AM · Restricted Project, Restricted Project

Dec 9 2019

whisperity added inline comments to D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer.
Dec 9 2019, 5:45 AM · Restricted Project, Restricted Project