Page MenuHomePhabricator

whisperity (Whisperity)
Research

Projects

User does not belong to any projects.

User Details

User Since
Dec 6 2016, 10:52 AM (215 w, 2 d)

Recent Activity

Today

whisperity abandoned D45094: [LibTooling] Make interface of VFS injection into ClangTool more user-friendly.
Thu, Jan 21, 9:04 AM · Restricted Project
whisperity abandoned D45095: [clang-tidy] Align usage of ClangTool interface with new VFS injection.
Thu, Jan 21, 9:04 AM · Restricted Project
whisperity abandoned D76545: [clang-tidy] Add a new check group 'experimental-'.

Obsolete. There was no community consensus, or even a large enough discussion about this. What's more, the only dependee of this patch has superseded in ellegance, dropping the need for this group.

Thu, Jan 21, 8:46 AM · Restricted Project, Restricted Project
whisperity planned changes to D75041: [clang-tidy] Approximate implicit conversion issues in 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type'.

This patch will be replaced with the refactoring of the base check.

Thu, Jan 21, 8:45 AM · Restricted Project, Restricted Project
whisperity planned changes to D78652: [clang-tidy] Add "ignore related parameters" heuristics to 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type'.

This patch will be replaced with the refactoring of the base check.

Thu, Jan 21, 8:45 AM · Restricted Project, Restricted Project
whisperity updated the diff for D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.

Refactored the check and rebased it against "current" master. This version now has the tests rewritten and fixed. In addition, this patch only introduces the very basic frame of the check (i.e. only strict type equality), nothing more. This is so that review can be done in a more digestible way.

Thu, Jan 21, 8:44 AM · Restricted Project, Restricted Project

Mon, Jan 18

whisperity added a comment to D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.

I have re-analysed Bitcoin and Xerces with the new version (not yet published to Phab), and the results are looking really good! There is an insignificant change in the number of reports, 1 or 2 new ones compared to the previous, all explained by the fact that "unnamed parameters" are marked as ignored, i.e. the previous report (which reported 3 swappable parameters, one unnamed) is marked "Resolved" (1), but there is the (2 swappable one without the unnamed at the start/end) as "New". Due to this, I will spare you from showing the essentially same table from above again: the total number of results are unchanged, only the details of each (and they are changed in a positive (towards more sensible) direction).

Mon, Jan 18, 4:23 AM · Restricted Project, Restricted Project

Fri, Jan 8

whisperity added a comment to D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.

Not sure what CVR-modelling's default should be... it finds less when "off", but too easily silences crucial issues (such as memcpy(T*, const T*)).

My instinct is that if you accidentally swap a qualified parameter you'll get some other diagnostic about dropped qualifiers and so perhaps the default should be off, but perhaps there's something I'm not thinking of there.

Fri, Jan 8, 9:08 AM · Restricted Project, Restricted Project
whisperity added a comment to D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.

I have posted two questions to GitHub, mostly related to the guideline rule and how free the implementation could be: #1732 and #1733, I think I tagged you on both.

Fri, Jan 8, 8:48 AM · Restricted Project, Restricted Project
whisperity added a comment to D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.

I was just about to write an issue to the CoreGuidelines project, but I was @vingeldal has posted about "relatedness" before me: https://github.com/isocpp/CppCoreGuidelines/issues/1579. It was in the list of closed issues.

Fri, Jan 8, 7:11 AM · Restricted Project, Restricted Project
whisperity updated the diff for D75041: [clang-tidy] Approximate implicit conversion issues in 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type'.

Ignore one-way implicit conversions

Fri, Jan 8, 6:48 AM · Restricted Project, Restricted Project
whisperity updated subscribers of D94251: [scan-build-py] Update scan-build-py to allow outputing as SARIF..
Fri, Jan 8, 2:42 AM
whisperity updated subscribers of D94251: [scan-build-py] Update scan-build-py to allow outputing as SARIF..
Fri, Jan 8, 2:41 AM

Tue, Jan 5

whisperity updated the summary of D91000: [clang-tidy] CERT MSC24-C Obsolescent Functions check.
Tue, Jan 5, 2:41 AM · Restricted Project, Restricted Project

Dec 16 2020

whisperity added a comment to D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.

Congrats on the SCAM acceptance, I hope the presentation goes well!

Dec 16 2020, 7:46 AM · Restricted Project, Restricted Project
whisperity added a comment to D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check.

But of course, after having written all of that, I forgot to upload the results themselves... 😲

Dec 16 2020, 6:48 AM · Restricted Project, Restricted Project
whisperity added a reviewer for D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check: aaron.ballman.

Right, let's bump. I've checked the output of the checker on a set of test projects (our usual testbed, I should say) which contains around 15 projects, half of which was C and the other half C++. All projects were analysed independently in a virtual machine. All projects were analysed after checking out the latest release tag that was closest to Jan 2019. (I know this sounds dated, but the whole reproduction image was originally constructed for another checker I'm working on, and I did not wish to re-do the whole "What is needed to install this particular version?" pipeline.) The more important thing is that releases were analysed, which should, in theory, under-approximate the findings because releases are generally more polished than in-the-works code. The check was run as-is (sans a minor rebase issue that does not affect functionality) currently in the patch, namely, Diff 259508.

Dec 16 2020, 6:44 AM · Restricted Project, Restricted Project
whisperity added inline comments to D93222: [RFC][analyzer] Introduce MacroExpansionContext to libAnalysis.
Dec 16 2020, 4:12 AM · Restricted Project

Nov 23 2020

whisperity added a comment to D91948: [WIP][analyzer][doc] Add Container- and IteratorModeling developer docs.

Actually, while the explanation is understandable for me with additional knowledge about the representation... I think it would be useful to add the most simple example from the iterator checkers to the end of the document, how this whole thing ties together and how it is useful in a checker.

Nov 23 2020, 4:01 AM · Restricted Project
whisperity added a comment to D91948: [WIP][analyzer][doc] Add Container- and IteratorModeling developer docs.

In general, perhaps you should go over the rendered text once again and make use of emph and bold some more.
Explanation looks okay from my part, although I'm really not knowledgeable about CSA internals. But there are plenty of "typesetting" issues.

Nov 23 2020, 4:00 AM · Restricted Project

Sep 29 2020

whisperity added a comment to D84176: [CMake][CTE] Add "check-clang-extra-..." targets to test only a particular Clang extra tool.

Is this an artefact of how check-clang-tools also depends on all clang-tools-extra targets.

Sep 29 2020, 6:43 AM · Restricted Project, Restricted Project

Sep 25 2020

whisperity committed rG9d2ef5e74eea: [CMake][CTE] Add "check-clang-extra-..." targets to test only a particular… (authored by whisperity).
[CMake][CTE] Add "check-clang-extra-..." targets to test only a particular…
Sep 25 2020, 4:35 AM
whisperity closed D84176: [CMake][CTE] Add "check-clang-extra-..." targets to test only a particular Clang extra tool.
Sep 25 2020, 4:34 AM · Restricted Project, Restricted Project

Sep 24 2020

whisperity added a comment to D84176: [CMake][CTE] Add "check-clang-extra-..." targets to test only a particular Clang extra tool.

Ping. Can this go in? Still using this on a local fork, and still feels nice to be able to specify just a single tool.

Sep 24 2020, 8:57 AM · Restricted Project, Restricted Project
whisperity retitled D75041: [clang-tidy] Approximate implicit conversion issues in 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type' from [clang-tidy] Approximate implicit conversion issues in 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' to [clang-tidy] Approximate implicit conversion issues in 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type'.
Sep 24 2020, 6:23 AM · Restricted Project, Restricted Project
whisperity retitled D78652: [clang-tidy] Add "ignore related parameters" heuristics to 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type' from [clang-tidy] Add "ignore related parameters" heuristics to 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' to [clang-tidy] Add "ignore related parameters" heuristics to 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type'.
Sep 24 2020, 6:23 AM · Restricted Project, Restricted Project
whisperity retitled D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check from [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check to [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type' check.
Sep 24 2020, 6:23 AM · Restricted Project, Restricted Project
whisperity added a comment to D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.

I'd like to resurrect the discussion about this. Unfortunately, the concept of experimental- group (in D76545) has fallen silent, too. We will present the results of this analysis soon at IEEE SCAM (Source Code Analysis and Manipulation) 2020. While a previous submission about this topic was rejected on the grounds of not being in line with the conference's usual, hyper-formalised nature, with one reviewer especially praising the paper for its nice touch with the empirical world and the fact that neither argument swaps (another checker worked on by a colleague) nor the interactions of this issue with the type system (this checker) was really investigated in the literature for C++ before, we've tailored both the paper and the implementation based on reviewer comments from the scientific world, and the comments here.
The reviews were mostly favourable, excl. comments about the lack of formalisation and the unfortunate lack of modelling for template instantiations. Such a cold cut, however, only introduces false negatives into the result set. Which is fine, as the users will never see those non-existent reports!

Sep 24 2020, 6:22 AM · Restricted Project, Restricted Project

Sep 14 2020

whisperity added inline comments to D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer.
Sep 14 2020, 2:51 AM · Restricted Project, Restricted Project
whisperity added a comment to D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer.

Minor inline comments.

Sep 14 2020, 2:50 AM · Restricted Project, Restricted Project

Sep 11 2020

whisperity added a comment to D87527: [ASTMatchers] Fix `hasBody` for the descendants of `FunctionDecl`.

What about http://clang.llvm.org/doxygen/classclang_1_1CXXConversionDecl.html ?

Sep 11 2020, 10:15 AM · Restricted Project

Sep 7 2020

whisperity added a comment to D86446: [analyzer][docs][NFC] Document the ento namespace in the llvm/Lexicon.

One minor "typo", otherwise I think we are saying everything that could be and needs to be said. Also, @steakhal, that must have been one massive blame.

Sep 7 2020, 5:45 AM · Restricted Project

Aug 26 2020

whisperity added inline comments to D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes.
Aug 26 2020, 5:25 AM · Restricted Project
whisperity added inline comments to D86446: [analyzer][docs][NFC] Document the ento namespace in the llvm/Lexicon.
Aug 26 2020, 4:07 AM · Restricted Project
whisperity added inline comments to D86446: [analyzer][docs][NFC] Document the ento namespace in the llvm/Lexicon.
Aug 26 2020, 3:00 AM · Restricted Project

Aug 25 2020

whisperity added inline comments to D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes.
Aug 25 2020, 5:46 AM · Restricted Project
whisperity added a comment to D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes.

Some grammatical fixes and suggestions, inline. I might have absolutely butchered 80-col in the suggestions (thanks Phab for not showing any indication of line length...), so make sure you manually reformat the document before going forward!

Aug 25 2020, 5:41 AM · Restricted Project

Aug 24 2020

whisperity added inline comments to D86446: [analyzer][docs][NFC] Document the ento namespace in the llvm/Lexicon.
Aug 24 2020, 10:21 AM · Restricted Project
whisperity added inline comments to D86446: [analyzer][docs][NFC] Document the ento namespace in the llvm/Lexicon.
Aug 24 2020, 10:21 AM · Restricted Project

Aug 14 2020

whisperity added a comment to D81272: [clang-tidy] New check `bugprone-redundant-branch-condition`.

While I agree with your observation about data and flow sensitivity, I approved on the belief that the check as-is provides enough utility to warrant adding it as-is. If someone wants to improve the check into being a CSA check, we can always deprecate this one at that point. However, if there are strong opinions that the check should start out as a CSA check because it requires that sensitivity for your needs, now's a good time to bring up those concerns.

Aug 14 2020, 8:09 AM · Restricted Project, Restricted Project
whisperity added a comment to D81272: [clang-tidy] New check `bugprone-redundant-branch-condition`.

Thanks to the new info, I think the check basically LGTM. Can you add some negative tests and documentation wording to make it clear that the check doesn't currently handle all logically equivalent predicates, like:

if (foo) {
} else {
  if (!foo) {
  }
}

// or
if (foo > 5) {
  if (foo > 3) {
  }
}

// or
if (foo > 5) {
  if (5 < foo) {
  }
}

(I'm assuming these cases aren't handled currently and that handling them isn't necessary to land the patch.)

Aug 14 2020, 7:29 AM · Restricted Project, Restricted Project
whisperity awarded D81272: [clang-tidy] New check `bugprone-redundant-branch-condition` a Baby Tequila token.
Aug 14 2020, 7:28 AM · Restricted Project, Restricted Project

Aug 13 2020

whisperity added inline comments to D85728: [Analyzer] Support for the new variadic isa<> and isa_and_not_null<> in CastValueChecker.
Aug 13 2020, 2:16 AM · Restricted Project

Aug 12 2020

whisperity added a comment to D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'..

More results in CodeChecker: emacs_errorreturn

Aug 12 2020, 8:34 AM · Restricted Project
whisperity added a comment to D85752: [Analyzer] Store the pointed/referenced type for dynamic casts.

@baloghadamsoftware Maybe there is a typo in the summary of the patch

Aug 12 2020, 1:47 AM · Restricted Project

Aug 11 2020

whisperity updated the summary of D85728: [Analyzer] Support for the new variadic isa<> and isa_and_not_null<> in CastValueChecker.
Aug 11 2020, 6:30 AM · Restricted Project

Aug 10 2020

whisperity added inline comments to D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine.
Aug 10 2020, 6:26 AM · Restricted Project
whisperity added a comment to D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker..

Do the null pointer and invalid pointer dereference belong to the same checker, that is called NullDereference?

Aug 10 2020, 3:04 AM · Restricted Project

Aug 7 2020

whisperity added inline comments to D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine.
Aug 7 2020, 9:23 AM · Restricted Project
whisperity added inline comments to D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine.
Aug 7 2020, 9:22 AM · Restricted Project

Aug 5 2020

whisperity updated subscribers of D85319: [analyzer][RFC] Get info from the LLVM IR for precision.

What will happen with the ability to analyse a translation unit whose target was not part of LLVM_TARGETS_TO_BUILD of the current clang binary? Will it break, because the binary lacks the information on how to generate for the given target?

Aug 5 2020, 9:01 AM · Restricted Project
whisperity added inline comments to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.
Aug 5 2020, 5:05 AM · Restricted Project, Restricted Project, Restricted Project

Aug 3 2020

whisperity added inline comments to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.
Aug 3 2020, 5:25 AM · Restricted Project, Restricted Project, Restricted Project
whisperity added a comment to D75229: [clang-tidy] Add signal-in-multithreaded-program check.

I have managed to improve the checker, but could not set up the test files to work only in POSIX platforms. Could you help me or show me an example?

Aug 3 2020, 4:35 AM · Restricted Project, Restricted Project
whisperity added inline comments to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.
Aug 3 2020, 3:54 AM · Restricted Project, Restricted Project, Restricted Project

Jul 30 2020

whisperity updated the diff for D84176: [CMake][CTE] Add "check-clang-extra-..." targets to test only a particular Clang extra tool.

After using this for a while, it feels more natural and more obvious that these are the CTE targets, not the "clang/tools" test targets.

Jul 30 2020, 7:15 AM · Restricted Project, Restricted Project

Jul 29 2020

whisperity added inline comments to D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor.
Jul 29 2020, 6:02 AM · Restricted Project

Jul 28 2020

whisperity added a comment to D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling.

Since the analyzer cannot cannot model the size of the containers just yet (or precisely enough), what we are saying with this checker is to "always check the return value of the erase() function before use (for increment/decrement etc.) whether it is not past-end" .

Adam, are you sure that the user would like to enforce such a generic coding rule? Depending on the actual code analyzed, this would require this clumsy check at potentially too many places.

Jul 28 2020, 8:39 AM · Restricted Project

Jul 21 2020

whisperity added a comment to D84176: [CMake][CTE] Add "check-clang-extra-..." targets to test only a particular Clang extra tool.

@lebedev.ri If you have an idea on who's competent in accepting this change, please update the reviewers field, I'm in the dark here.

Jul 21 2020, 1:55 AM · Restricted Project, Restricted Project

Jul 20 2020

Herald added a project to D84176: [CMake][CTE] Add "check-clang-extra-..." targets to test only a particular Clang extra tool: Restricted Project.
Jul 20 2020, 8:17 AM · Restricted Project, Restricted Project

Jul 14 2020

Herald added projects to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C: Restricted Project, Restricted Project.
Jul 14 2020, 7:06 AM · Restricted Project, Restricted Project, Restricted Project

Jul 9 2020

whisperity added inline comments to D79437: [clang-tidy] Add fsetpos argument checker.
Jul 9 2020, 1:58 AM · Restricted Project
whisperity added inline comments to D77493: [clang-tidy] Add do-not-refer-atomic-twice check.
Jul 9 2020, 1:32 AM · Restricted Project, Restricted Project
whisperity added a comment to D75229: [clang-tidy] Add signal-in-multithreaded-program check.

In general, the test files should be cleaned up.

Jul 9 2020, 1:13 AM · Restricted Project, Restricted Project

Jul 2 2020

whisperity committed rG4cf24cb868b9: [NFC][clang] Add missing VALIDATE_DIAG_SIZE() (authored by whisperity).
[NFC][clang] Add missing VALIDATE_DIAG_SIZE()
Jul 2 2020, 5:21 AM

Jun 26 2020

whisperity added inline comments to D80504: [analyzer] CERT STR rule checkers: STR50-CPP.
Jun 26 2020, 6:30 AM · Restricted Project

Jun 25 2020

whisperity added a comment to D81272: [clang-tidy] New check `bugprone-redundant-branch-condition`.

As a future work, when something support ifs, it should also support ?:, and eliminate redundant conditionals from there, too.

Jun 25 2020, 2:08 AM · Restricted Project, Restricted Project

Jun 9 2020

whisperity added inline comments to D75665: [analyzer] On-demand parsing capability for CTU.
Jun 9 2020, 7:39 AM · Restricted Project

May 28 2020

whisperity resigned from D75665: [analyzer] On-demand parsing capability for CTU.
May 28 2020, 1:02 AM · Restricted Project

May 15 2020

whisperity added a comment to D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow..

I was looking at CERT ARR32-C "Ensure size arguments for variable length arrays are in a valid range". The VLA should not have a size that is larger than std::numeric_limits<size_t>::max(), in other words "fit into a size_t value", or not?

Yes creating the too large VLA in itself is not a bug, only when sizeof is called on it because it can not return the correct size. A non-fatal error is a better option, or delay the check until the sizeof call. But probably the create of such a big array in itself is sign of code smell. The array actually does not need to be created to make the problem happen, only a sizeof call on a typedef-ed and too large VLA. (What does mean that "result of sizeof is implementation-defined"? Probably it can return not the size in bytes or "chars" but something other? In such a case the checker would be not correct.)

May 15 2020, 3:02 AM · Restricted Project
whisperity added inline comments to D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow..
May 15 2020, 2:19 AM · Restricted Project

May 12 2020

whisperity requested changes to D75665: [analyzer] On-demand parsing capability for CTU.

(Maybe this will make Phab not show "✅ Accepted"...)

May 12 2020, 4:47 AM · Restricted Project
whisperity added a comment to D75665: [analyzer] On-demand parsing capability for CTU.

Please check the summary of the patch, it seems to contain old information as well.

May 12 2020, 4:47 AM · Restricted Project

May 6 2020

whisperity retitled D79415: [analyzer][MallocChecker] When modeling realloc-like functions, don't early return if the argument is symbolic from [analyzer][MalloChecker] When modeling realloc-like functions, don't early return if the argument is symbolic to [analyzer][MallocChecker] When modeling realloc-like functions, don't early return if the argument is symbolic.
May 6 2020, 5:20 AM · Restricted Project

Apr 24 2020

whisperity added inline comments to D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor.
Apr 24 2020, 3:13 AM · Restricted Project
whisperity added a comment to D78457: [analyzer][Z3-refutation] Fix a refutation BugReporterVisitor bug.

@steakhal You might want to update the patch summary before committing this to the upstream (it still mentions "not needing a visitor" 😄)

Apr 24 2020, 2:40 AM · Restricted Project

Apr 23 2020

whisperity planned changes to D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check.
Apr 23 2020, 3:45 AM · Restricted Project, Restricted Project
whisperity updated the summary of D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check.
Apr 23 2020, 3:45 AM · Restricted Project, Restricted Project
whisperity updated the diff for D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check.

First things first, we were 50 thousand (!) patches behind reality. Rebased to master. Fixed it to compile, too. Otherwise, NFC so far.

Apr 23 2020, 3:45 AM · Restricted Project, Restricted Project
whisperity commandeered D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check.

Assuming direct control. Previous colleagues and university mates departed for snowier pastures, time to try to do something with this check.

Apr 23 2020, 3:45 AM · Restricted Project, Restricted Project
Herald added a reviewer for D78648: [CMake] Bump CMake minimum version to 3.13.4: ftynse.
Apr 23 2020, 3:13 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
whisperity added inline comments to D75665: [analyzer] On-demand parsing capability for CTU.
Apr 23 2020, 3:13 AM · Restricted Project

Apr 22 2020

whisperity added inline comments to D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.
Apr 22 2020, 10:19 AM · Restricted Project, Restricted Project
whisperity added inline comments to D75041: [clang-tidy] Approximate implicit conversion issues in 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type'.
Apr 22 2020, 10:19 AM · Restricted Project, Restricted Project
whisperity retitled D75041: [clang-tidy] Approximate implicit conversion issues in 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type' from [WIP][clang-tidy] Approximate implicit conversion issues for the 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check to [clang-tidy] Approximate implicit conversion issues for the 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.
Apr 22 2020, 10:19 AM · Restricted Project, Restricted Project
whisperity updated the diff for D75041: [clang-tidy] Approximate implicit conversion issues in 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type'.
  • Re-organised code, removed debug prints, rebased, the usual tidy-up.
  • Bug fixes on certain crashes like incomplete types, conversion operator templates, etc.
  • Even more bug fixes against crashes, hopefully... sorry I lost the individual commits in a squash I think
Apr 22 2020, 10:19 AM · Restricted Project, Restricted Project
whisperity created D78652: [clang-tidy] Add "ignore related parameters" heuristics to 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type'.
Apr 22 2020, 9:46 AM · Restricted Project, Restricted Project
whisperity updated the diff for D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.
  • Better organisation of code, cleanup of debug prints, fix nomenclature of functions
  • Explicitly mention the first and last param of the range for clarity
  • Downlift the logic of joining and breaking ranges to main patch (this isn't terribly useful at this point, but both subsequent improvements to the check depend on this change)
    • Basically no longer assume that if param N can be swapped with param 1, then it can also be swapped with 2, 3, etc. without checking.
  • Made the list of ignored parameter and type names configurable as a checker option
  • Changed the default value of MinimumLength to 2, as prescribed in the guideline's text.
Apr 22 2020, 9:46 AM · Restricted Project, Restricted Project
whisperity updated the summary of D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.
Apr 22 2020, 9:46 AM · Restricted Project, Restricted Project

Apr 21 2020

whisperity added inline comments to D77745: [analyzer] ASTMatchers: Extend with Static Analyzer data types.
Apr 21 2020, 8:37 AM · Restricted Project
whisperity added inline comments to D75665: [analyzer] On-demand parsing capability for CTU.
Apr 21 2020, 8:04 AM · Restricted Project

Apr 14 2020

whisperity added a reviewer for D78009: [analyzer][NFC] Remove SummaryManager.h: martong.

Adding @martong, he might have knowledge about the whole summary thing as he's tinkering the(?) STL checker.

Apr 14 2020, 8:32 AM · Restricted Project

Mar 23 2020

whisperity planned changes to D76545: [clang-tidy] Add a new check group 'experimental-'.
Mar 23 2020, 12:00 PM · Restricted Project, Restricted Project
whisperity added a comment to D76545: [clang-tidy] Add a new check group 'experimental-'.

@aaron.ballman @njames93 Should I write up a pitch mail to cfe-dev about this?

Mar 23 2020, 3:48 AM · Restricted Project, Restricted Project
whisperity committed rGdf5fa4873976: [clang-tidy][NFC] Add missing check group docs and order entries (authored by whisperity).
[clang-tidy][NFC] Add missing check group docs and order entries
Mar 23 2020, 3:16 AM
whisperity closed D76541: [clang-tidy][NFC] Add missing check group docs and order entries.
Mar 23 2020, 3:15 AM · Restricted Project, Restricted Project
whisperity added a comment to D76545: [clang-tidy] Add a new check group 'experimental-'.

I think we want to keep the experimental checks grouped to their parent module rather than being in a module of their own.

Mar 23 2020, 3:15 AM · Restricted Project, Restricted Project
whisperity added a comment to D76541: [clang-tidy][NFC] Add missing check group docs and order entries.

Forgive me if I'm wrong, but these kinds of changes typically don't require a review.

Mar 23 2020, 3:15 AM · Restricted Project, Restricted Project

Mar 21 2020

whisperity updated the diff for D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.
  • Renamed check to experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type.
  • s/argument/parameter/g in the code and output where appropriate.
Mar 21 2020, 5:53 AM · Restricted Project, Restricted Project
whisperity created D76545: [clang-tidy] Add a new check group 'experimental-'.
Mar 21 2020, 5:53 AM · Restricted Project, Restricted Project