This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][AsmParser] Implement .option (no)pic
ClosedPublic

Authored by rogfer01 on Apr 10 2020, 5:54 AM.

Details

Summary

This directive impacts assembly pseudoinstruction la.

Also add a test for codegen to assert that this directive behaves like other ones (i.e. no effect) when directly emitting ELF files from codegen.

Diff Detail

Event Timeline

rogfer01 created this revision.Apr 10 2020, 5:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 10 2020, 5:54 AM
lenary accepted this revision.Apr 13 2020, 6:38 AM

LGTM, Thanks!

This revision is now accepted and ready to land.Apr 13 2020, 6:38 AM

Thanks for the review @lenary!

This revision was automatically updated to reflect the committed changes.