Page MenuHomePhabricator

[Sema] Teach -Warm-interrupt-safety about func ptrs
Needs ReviewPublic

Authored by jroelofs on Feb 18 2020, 7:23 PM.

Diff Detail

Event Timeline

jroelofs created this revision.Feb 18 2020, 7:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 18 2020, 7:23 PM
jroelofs edited the summary of this revision. (Show Details)Feb 18 2020, 7:27 PM
jroelofs marked an inline comment as done.
jroelofs added inline comments.
clang/lib/Sema/SemaExpr.cpp
5931

This feels very fragile, and I know is missing at least one case. Is there a better way to reliably get at the typedef's attributes from here?

efriedma added inline comments.Feb 20 2020, 10:37 AM
clang/lib/Sema/SemaExpr.cpp
5931

Fundamentally, the way canonical types work in C and C++ means that you shouldn't be trying to dig attributes out of typedefs. If it's a property of the type, it should be stored as a member of the FunctionType, like we do with calling conventions etc.