User Details
- User Since
- Nov 19 2012, 2:50 AM (576 w, 6 d)
Oct 7 2019
Feb 28 2019
Nov 7 2018
Apr 20 2018
maybe we can apply the -Wweak-vtable flag lib by lib. does the CMakeList support it?
Apr 15 2018
Apr 14 2018
Apr 13 2018
split the original into two parts. This one supports -ffile-macro-prefix-to-remove function.
Sure. How about do it in a separate patch?
Apr 12 2018
Apr 11 2018
@dblaikie you're right. I modified CMakeLists.txt rather than LLVMBuild.txt
I put a dependency on tools/llvm-lto as well. From my build (default CMake config), it works.
Apr 10 2018
add dependency upon MCJIT for LTO due to the use of ObjectMemoryBuffer
Apr 9 2018
If I choose to define ObjectMemoryBuffer::anchor() in MCJIT.cpp (the module that uses ObjectMemoryBuffer), then I got error like:
../../lib/libLLVMLTO.a(ThinLTOCodeGenerator.cpp.o): In function `ObjectMemoryBuffer':
llvm/ExecutionEngine/ObjectMemoryBuffer.h:41: undefined reference to `vtable for llvm::ObjectMemoryBuffer'
Apr 5 2018
Thanks Eli!
Apr 4 2018
When I statically linking a project (built with RTTI) against LLVM OrcJIT (default built with no-RTTI), I got a couple of "undefined reference to type info" error.
Mar 7 2018
Mar 5 2018
gentle ping?
Feb 23 2018
ping?
Feb 12 2018
Modified the random generator in filesystem_test_helper to use high_resolution_clock as seed.
Feb 9 2018
ping?
Jan 30 2018
Disable tests that depend on random_device.
filesystem tests rely on random_device as seed to create random path. Although it's possible to avoid the random_device but if the build target has no random_device, it's very possible that neither filesystem nor other seeding device like clock is available.
Jan 24 2018
Jan 23 2018
As Sam suggests, add more checks in lit tests to make sure only "bl" is used.
Jan 22 2018
On Thumb1, i64 shift is lowered to 20 instructions. For example:
For code like
unsigned long long foo(unsigned long long x, unsigned y) { return x << y;}
Jan 11 2018
any suggestions?
Jan 5 2018
We can wrap the random_device as a minstd_rand, a linear congruential enginer that a lot of C lib uses for rand().
However based on documentation, we should just provides dummy implementation which throws an exception in the constructor of random_device [1,2]
But compared with run-time exception, a link time error is better if we simply skip the implementation. Any thoughts?
Jan 2 2018
Should we go with current patch? or provide a srand/rand based implementation as an option?
Dec 16 2017
Does it make sense to provide an implementation based on C99 rand?
like
#ifdef _LIBCPP_USING_C99_RANDOM
srand(0), rand()
Dec 15 2017
Nov 30 2017
Nov 28 2017
Nov 20 2017
Hold on. Why do we need this flag? There is no c++ code in builtins.
LGTM. Adding Saleem and Peter for confirming.
Nov 9 2017
Nov 7 2017
If compiler-rt is to provide optimized version, then, should MUSL just forwards the calls like memcpy ->__aeabi_memcpy ? Because libc is usually appear first in linking order, a standard implementation in libc will hide the optimized version in compiler-rt.
Nov 6 2017
add memcpy
Should we use "ARM" instead of "Arm" ?
Sep 26 2017
LGTM. (Let Saleem to sign off)
LGTM.
Sep 19 2017
minor change
Moved the inclusion from stdexcept.cpp into refstring.h
Sep 6 2017
Aug 30 2017
Aug 22 2017
LGTM. Adding Renato and Saleem to approve.
Aug 15 2017
guard the "DEFINE_CODE_STATE" with "__ARM_ARCH < 6" check.
Aug 14 2017
ping @EricWF
remove unreleated change (CMakefile) and address comments from Saleem
Aug 11 2017
ping?
Aug 7 2017
And since it's an assertion, in Release build, the flag will still be accepted silently.
rebased. Please review. Thanks
Aug 3 2017
Aug 2 2017
I tried to address it via checking pre-defined macros:
https://reviews.llvm.org/D31573
Jul 31 2017
add test case
Jul 27 2017
Jul 26 2017
ping?
Jul 18 2017
Jul 17 2017
rebased after reverting r307595 and moving __refstring header
Jul 14 2017
address the review comments by @peter.smith and @jamesduley
Jul 13 2017
rebased
Jul 10 2017
I should use existing include/atomic_support.h. Will upload the patch shortly.
simplify test case
missed to upload the change to include __atomic_support header file