- User Since
- Nov 19 2012, 2:50 AM (230 w, 6 d)
Thu, Apr 20
Just find that one case was fixed by r297871 ARM: avoid clobbering register in v6 jump-table expansion.
Wed, Apr 19
Below are the measurements of text size of benchmarks.
Build flag: "-Oz -mthumb -mcpu=cortex-m3 -fomit-frame-pointer"
Baseline has extra flag: " -mllvm -arm-favor-r4-r7=false"
This fixes some SPEC2000 fails when build for Thumb1 with -Os.
I do not upload the lit test because it's not easy to reduce to a simple/clean one as it needs specific reg alloc to show the problem.
Mon, Apr 10
btw, should we use "--rtlib=compiler-rt" rather than passing the libname explicitly?
Sat, Apr 8
Thanks for the info!
Thu, Apr 6
I tried to use the lib name from cmake/Module/AddCompilerRT.cmake : add_compiler_rt_runtime but no luck.
And I can't find where the suffix is set in compiler-rt project.
Not sure if it is the portable way to do.
I see cmake/base-config-ix.cmake has set(CMAKE_STATIC_LIBRARY_SUFFIX_C ".lib"), but I can't find where the variable is used and not sure if we can use it in test/CMakefile.
Wed, Apr 5
Thanks for the explanation. The current patch should address the problem, right?
move up the "divby0" block for the case with HW div to make the code easier to read.
I think the r7 (fp) was not set to initial SP, so it won't matter for stack-based unwinding. Anyway, use r7 now.
Mon, Apr 3
these tests are the only 4 tests that use 128 bit long long.
Other tests that uses HAS_80_BIT_LONG_DOUBLE should be replaced with __LDBL_MANT_DIG__ == 64
In my view, LDBL_MANT_DIG == 64 implies HAS_80_BIT_LONG_DOUBLE, but need t to exclude MIPS as it clang BE doesn't support it.
seems no way to detect if 80-bit ldbl is supported or not. Leave it to the build time flags.
Change to HAS_80_BIT_LONG_DOUBLE just like other tests.
Also, if HAS_80_BIT_LONG_DOUBLE is not defined, we can set it if CRT_HAS_128BIT && LDBL_MANT_DIG == 64. So even if the build doesn't specify it, the test won't be skipped by mistake.
If the platform doesn't support it, the LDBL_MANT_DIG will be 53 (refer to clang/test/Preprocessor/init.c )
I guess HAS_80_BIT_LONG_DOUBLE is passed as some build-time flags. I can't find it anywhere in the compiler-rt source tree that defines it.
Sun, Apr 2
I see. Should we mark the test as "Unsupported" for aarch64?
Sat, Apr 1
After we agree on the patch, __fixxfti() will be fixed similarly.
Wed, Mar 29
The same test passed on
But failed on
Looks good to me but I'm not very familiar with the build of sanitizer and xray.
pushed r298997 that removes XFAIL
We can remove the XFAIL for now
Interestingly, mulsc3_test.c XPASSed. Looks like the compiltion line has no hardfp flag, so the problem was not exposed. In my local build.
Tue, Mar 28
Mon, Mar 27
it was commited by mistake and was reverted immediately.
Mar 24 2017
Mar 23 2017
It's part of already-accepted patch ((https://reviews.llvm.org/D30802)
Will re-land it.
Mar 22 2017
need to include builtin-config-ix to get the right ARM32 variable.
This patch *should* address the issue of buildbot of powerpc (http://lab.llvm.org:8011/builders/sanitizer-ppc64le-linux/builds/1703).
I was using
It should be
Mar 21 2017
Mar 20 2017
I split the original patch into 2 parts: This one only contains the test case updates: adding "RUN" or "UNSUPPORT". A couple of test cases are XFAILed for armhf/aarch64 target (bugs were opened [1,2]). This part is also safe to commit; The second part will includes the CMake, lit.cfg files for easy reviewing.
Mar 14 2017
(sorry, please ignore the update)
Mar 13 2017
Mar 12 2017
Mar 11 2017
Most of the changes are guarded by __ARM_ARCH_ISA_THUMB == 1 and I reviewed again of the "else" part and they look OK except for one suspect:
Mar 10 2017
Thanks for trying it on x86, Michal.
I XFAILed cpu_model_test.c and gcc_personality_test.c for now and I leave "FIXME" around the %RUN line. We can fix them later on.
Address Jonathan's comments.
Just rebased and find that https://reviews.llvm.org/D30136 is adding TestCase support.
I'm not sure what's the TestCase is used for. Looks only for Darwin and the directory is empty.
Mar 9 2017
I tested it on ARM via QEMU with the CMAKE parames below: