Page MenuHomePhabricator

EricWF (Eric Fiselier)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 26 2014, 12:44 PM (290 w, 4 d)

Recent Activity

Yesterday

EricWF committed rGd15fad2653d4: [libc++][libc++abi] Fix or suppress failing tests in single-threaded builds. (authored by EricWF).
[libc++][libc++abi] Fix or suppress failing tests in single-threaded builds.
Sun, Jan 19, 6:56 PM

Sat, Jan 18

EricWF added a comment to D72990: [libc++][NFC] Fix experimental/type_traits namespace.

Does this header actually implement any of the V2 specification?

Sat, Jan 18, 6:25 PM · Restricted Project

Fri, Jan 17

EricWF committed rGa8a9c8e0a11a: [libc++] Optimize / partially inline basic_string copy constructor (authored by EricWF).
[libc++] Optimize / partially inline basic_string copy constructor
Fri, Jan 17, 1:55 PM
EricWF closed D72160: Optimize / partially inline basic_string copy constructor.

Committed as a8a9c8e0a11abc9ed4ed78fed528334371fedf87.

Fri, Jan 17, 1:55 PM · Restricted Project
EricWF accepted D72160: Optimize / partially inline basic_string copy constructor.

LGTM

Fri, Jan 17, 1:55 PM · Restricted Project
EricWF accepted D72640: [libcxx] Qualify make_pair in searcher implementations to prevent ADL.

I don't know that you needed to duplicate all the tests, but this works for me.

Fri, Jan 17, 12:18 PM · Restricted Project
EricWF added a comment to D72160: Optimize / partially inline basic_string copy constructor.

There are a couple of places that now duplicate the body of __init_long. Would it make sense to deduplicate that code in some way?

Fri, Jan 17, 12:09 PM · Restricted Project
EricWF accepted D72484: [clang-tidy] Fix check for Abseil internal namespace access.

The weird template test case might is derived from an old failure that I believe was addressed in Clang, but regression tests are fine by me.
The macro expansion fix is correct and correctly tested.

Fri, Jan 17, 10:41 AM · Restricted Project, Restricted Project

Thu, Jan 16

EricWF accepted D72862: [libcxx] Temporarily switch back to pthread backend for Fuchsia.

Can you open a bug somewhere and then add a // FIXME or TODO comment explaining that C11 is what we eventually want?

Thu, Jan 16, 12:28 PM · Restricted Project
EricWF committed rG59919c4d6b63: [libc++] Fix Windows DLL build for string. (authored by EricWF).
[libc++] Fix Windows DLL build for string.
Thu, Jan 16, 12:09 PM

Wed, Jan 15

EricWF accepted D72809: [libcxx] Use mtx_plain | mtx_recursive following C11 API.

We should backport this into the LLVM 10 release.
@hans Is that OK by you?

Wed, Jan 15, 3:15 PM · Restricted Project
EricWF added a comment to rG61bd19206f61: [libc++] Explicitly enumerate std::string external instantiations..

I've recommitted the libc++ changes. I believe each of the build failures mentioned here has been addressed.
Please inform me if you still hit errors.

Wed, Jan 15, 2:34 PM
EricWF committed rG313d89724ce3: [libc++] Fix parsing <string> in C++03. (authored by EricWF).
[libc++] Fix parsing <string> in C++03.
Wed, Jan 15, 2:34 PM
EricWF committed rG58c7fa5adeb2: [libc++] Optimize basic_string::operator=(const basic_string&) for SSO… (authored by EricWF).
[libc++] Optimize basic_string::operator=(const basic_string&) for SSO…
Wed, Jan 15, 2:34 PM
EricWF closed D72704: Optimize basic_string::operator=(const basic_string&) for SSO assignments.

Committed as 58c7fa5adeb218737f10ffeaeed0d9eb21f4a2f0

Wed, Jan 15, 2:34 PM · Restricted Project
EricWF accepted D72704: Optimize basic_string::operator=(const basic_string&) for SSO assignments.

LGTM.

Wed, Jan 15, 2:27 PM · Restricted Project
EricWF committed rG288a1436392f: [libc++] Explicitly enumerate std::string external instantiations - Attempt 2 (authored by EricWF).
[libc++] Explicitly enumerate std::string external instantiations - Attempt 2
Wed, Jan 15, 2:16 PM
EricWF committed rG2d8f23f57163: [libc++] Explicitly mark basic_string<...>::npos with default visibility. (authored by EricWF).
[libc++] Explicitly mark basic_string<...>::npos with default visibility.
Wed, Jan 15, 2:06 PM
EricWF committed rG24d2a015eade: [libc++] Make SFINAE'd member functions in string mutually exclusive. (authored by EricWF).
[libc++] Make SFINAE'd member functions in string mutually exclusive.
Wed, Jan 15, 2:06 PM
EricWF added a comment to rG61bd19206f61: [libc++] Explicitly enumerate std::string external instantiations..

Please reply on the libc++-commits email before reverting next time. These comments are not easily noticeable.

Wed, Jan 15, 8:55 AM

Thu, Jan 9

EricWF committed rG61bd19206f61: [libc++] Explicitly enumerate std::string external instantiations. (authored by EricWF).
[libc++] Explicitly enumerate std::string external instantiations.
Thu, Jan 9, 12:54 PM
EricWF updated the diff for D70336: Explicitly enumerate std::string external instantiations..

Update and merge with master.

Thu, Jan 9, 12:54 PM

Tue, Jan 7

EricWF committed rG0c5102bd9391: [libc++] Add additional benchmark functions to libcxx/benchmarks/string.bench (authored by EricWF).
[libc++] Add additional benchmark functions to libcxx/benchmarks/string.bench
Tue, Jan 7, 1:36 PM
EricWF closed D72343: Add additional benchmark functions to libcxx/benchmarks/string.bench.

Committed as 0c5102bd939131b27105b74e73fc25b90207ef36

Tue, Jan 7, 1:36 PM · Restricted Project
EricWF accepted D72343: Add additional benchmark functions to libcxx/benchmarks/string.bench.

I think this is fine as is. So long as you've looked at it.

Tue, Jan 7, 1:27 PM · Restricted Project
EricWF added inline comments to D72343: Add additional benchmark functions to libcxx/benchmarks/string.bench.
Tue, Jan 7, 9:37 AM · Restricted Project

Dec 20 2019

EricWF added a comment to D71744: [libc++] avoid g++9 Wdeprecated-copy in __hash_table & __tree.

Is this change against head? because I thought I already fixed this.

Dec 20 2019, 5:38 PM

Dec 16 2019

EricWF committed rGa53534a9f640: [libc++] Add __default_init_tag to basic_string constructors (authored by EricWF).
[libc++] Add __default_init_tag to basic_string constructors
Dec 16 2019, 4:07 PM
EricWF closed D70621: Add __default_init_tag to basic_string constructors.

Committed as a53534a9f6404d1727fd6e9b13b6dc3089523e10.

Dec 16 2019, 4:07 PM · Restricted Project
EricWF committed rG549545b64aab: [libc++] Rework compressed pair constructors. (authored by EricWF).
[libc++] Rework compressed pair constructors.
Dec 16 2019, 3:47 PM
EricWF closed D70617: Add default initialization to compressed_pair..

Committed as 0fa118a9da6786a0aaf81e309d8c3b38bc5f61dd.

Dec 16 2019, 2:26 PM · Restricted Project
EricWF committed rG0fa118a9da67: Add default initialization to compressed_pair. (authored by EricWF).
Add default initialization to compressed_pair.
Dec 16 2019, 2:16 PM

Dec 13 2019

EricWF committed rGfda3825c7a96: [libc++] Ensure __config always defines certain configuration macros. (authored by EricWF).
[libc++] Ensure __config always defines certain configuration macros.
Dec 13 2019, 12:51 PM

Dec 12 2019

EricWF committed rGf97936fabd26: [libc++] Cleanup and enable multiple warnings. (authored by EricWF).
[libc++] Cleanup and enable multiple warnings.
Dec 12 2019, 6:16 PM
EricWF committed rG9b540192b636: [libc++] Mark all fuzzing tests as unsupported in C++03 (authored by EricWF).
[libc++] Mark all fuzzing tests as unsupported in C++03
Dec 12 2019, 6:16 PM
EricWF added inline comments to D71096: __bit_reference: fix -Wdeprecated-copy warnings.
Dec 12 2019, 4:13 PM · Restricted Project
EricWF accepted D71096: __bit_reference: fix -Wdeprecated-copy warnings.

LGTM once the changes land. Let's shut this warning up.

Dec 12 2019, 4:12 PM · Restricted Project
EricWF added a comment to D71096: __bit_reference: fix -Wdeprecated-copy warnings.

LGTM given the use of = default and = delete.

Dec 12 2019, 4:11 PM · Restricted Project
EricWF committed rGc6b8c3d5d9a3: [libc++] Tolerate NaN returning random distributions for now (authored by EricWF).
[libc++] Tolerate NaN returning random distributions for now
Dec 12 2019, 3:56 PM
EricWF committed rG27ec4abeac4d: [libc++] Add check to ensure oss-fuzz properly targets libc++. (authored by EricWF).
[libc++] Add check to ensure oss-fuzz properly targets libc++.
Dec 12 2019, 3:55 PM
EricWF accepted D70621: Add __default_init_tag to basic_string constructors.
Dec 12 2019, 11:45 AM · Restricted Project
EricWF added inline comments to D70617: Add default initialization to compressed_pair..
Dec 12 2019, 11:38 AM · Restricted Project
EricWF accepted D70617: Add default initialization to compressed_pair..
Dec 12 2019, 11:37 AM · Restricted Project

Dec 11 2019

EricWF committed rGa9245e4f8616: [libc++abi] Fix non-constant initialization of default terminate handlers. (authored by EricWF).
[libc++abi] Fix non-constant initialization of default terminate handlers.
Dec 11 2019, 5:34 PM
EricWF committed rG72b41e6e2d56: [libc++] Require C++14 in all cases. (authored by EricWF).
[libc++] Require C++14 in all cases.
Dec 11 2019, 5:31 PM
EricWF committed rG5c9816b84e94: [libc++] Fix fuzzing tests with older GCC compilers. (authored by EricWF).
[libc++] Fix fuzzing tests with older GCC compilers.
Dec 11 2019, 1:42 PM
EricWF committed rG29b2f64ddb8b: [libc++] Fix fuzzing unit tests with exceptions disabled. (authored by EricWF).
[libc++] Fix fuzzing unit tests with exceptions disabled.
Dec 11 2019, 1:24 PM
EricWF committed rGdaacf5703245: [libc++] Add fuzzing tests for parts of <random>. (authored by EricWF).
[libc++] Add fuzzing tests for parts of <random>.
Dec 11 2019, 12:55 PM

Nov 18 2019

EricWF added a comment to D69708: [libcxx] Disable -Wconstant-evaluated for testsuite.

Why was this committed without review?

Nov 18 2019, 1:44 PM · Restricted Project

Nov 17 2019

EricWF committed rGf82dba019253: Rename __is_foo_iterator traits to reflect their Cpp17 nature. (authored by EricWF).
Rename __is_foo_iterator traits to reflect their Cpp17 nature.
Nov 17 2019, 10:51 PM

Nov 16 2019

EricWF committed rG6624fcba43be: [libc++] Add _ITER_CONCEPT and _ITER_TRAITS implementations from C++20 (authored by EricWF).
[libc++] Add _ITER_CONCEPT and _ITER_TRAITS implementations from C++20
Nov 16 2019, 5:30 PM
EricWF committed rG45d048c20440: [libc++] Add C++20 contiguous_iterator_tag. (authored by EricWF).
[libc++] Add C++20 contiguous_iterator_tag.
Nov 16 2019, 5:21 PM
EricWF committed rG0068c5913999: [libc++] Rename __to_raw_pointer to __to_address. (authored by EricWF).
[libc++] Rename __to_raw_pointer to __to_address.
Nov 16 2019, 2:19 PM

Nov 15 2019

EricWF added a comment to D70343: Add a `_LIBCPP_HARDEN` define.

What's the difference between _LIBCPP_HARDEN and simply defining _LIBCPP_DEBUG=0? That should turn on _LIBCPP_ASSERT in the same cases.

Nov 15 2019, 3:42 PM
EricWF created D70336: Explicitly enumerate std::string external instantiations..
Nov 15 2019, 12:54 PM
EricWF accepted D69806: [libcxx] use __builtin_isnan in std::isnan..

Sorry, I meant to LGTM this formally last time.

Nov 15 2019, 9:03 AM · Restricted Project

Nov 13 2019

EricWF added a comment to D69806: [libcxx] use __builtin_isnan in std::isnan..

Since the __libcpp_is_nan_or_builtin hacks are no longer needed (they can directly call isnan), could you please send a separate change to remove it?

Nov 13 2019, 12:15 PM · Restricted Project
EricWF added a comment to D69806: [libcxx] use __builtin_isnan in std::isnan..

OK, this LGTM.

Nov 13 2019, 12:14 PM · Restricted Project

Nov 8 2019

EricWF committed rZORGf296f7da2dd5: Remove LLVM from depset for the libc++ builders. (authored by EricWF).
Remove LLVM from depset for the libc++ builders.
Nov 8 2019, 2:52 AM

Oct 25 2019

EricWF added a comment to D69286: I implemented the features listed in this document: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0616r0.pdf and built libc++ using ninja without any errors/warnings. I Also ran the test suite it using `lit` and passed all the unit tests..

Please correct the patch description and title to be clearer and not all on one line.

Oct 25 2019, 5:15 PM · Restricted Project
EricWF added inline comments to D69286: I implemented the features listed in this document: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0616r0.pdf and built libc++ using ninja without any errors/warnings. I Also ran the test suite it using `lit` and passed all the unit tests..
Oct 25 2019, 2:02 PM · Restricted Project

Oct 24 2019

EricWF added a comment to D69344: [libcxx] Add move constructor to compressed pair.

I would have also expected = default to work but, it doesn't seem to. I think because __compressed_pair inherits from both its elements instead of storing them as members.

Oct 24 2019, 8:37 AM · Restricted Project
EricWF added a comment to D69344: [libcxx] Add move constructor to compressed pair.

I should have made it clear, my bad, this fixes the move constructor in C++03 mode.

Oct 24 2019, 7:48 AM · Restricted Project
EricWF requested changes to D69344: [libcxx] Add move constructor to compressed pair.

This test case already passes.

Oct 24 2019, 4:53 AM · Restricted Project

Oct 14 2019

EricWF accepted D68947: [libc++][test] Add license headers to test/support/archetypes.*.
Oct 14 2019, 10:43 AM · Restricted Project

Oct 10 2019

EricWF added a comment to D68480: Implementation of C++20's P1135R6 for libcxx.

Are the lock free algorithms used by this implementation published somewhere? That would give me a lot more confidence in their correctness.

Oct 10 2019, 6:08 PM
EricWF added a comment to D68480: Implementation of C++20's P1135R6 for libcxx.

Please see the Adding a new header section of NOTE.txt (https://github.com/llvm-mirror/libcxx/blob/master/NOTES.TXT#L19-L29)

Oct 10 2019, 8:12 AM
EricWF accepted D68756: [libc++][test] Change IsSmallObject's calculation for std::any's small object buffer.
Oct 10 2019, 1:44 AM · Restricted Project

Oct 8 2019

EricWF committed rG78153b3a9759: Optimize operator=(const basic_string&) for tail call. (authored by EricWF).
Optimize operator=(const basic_string&) for tail call.
Oct 8 2019, 8:12 PM
EricWF committed rL374137: Optimize operator=(const basic_string&) for tail call..
Optimize operator=(const basic_string&) for tail call.
Oct 8 2019, 8:05 PM

Oct 4 2019

EricWF added inline comments to D68480: Implementation of C++20's P1135R6 for libcxx.
Oct 4 2019, 11:15 PM
EricWF requested changes to D68075: Do not #error if no OS is #defined.
Oct 4 2019, 10:05 PM · Restricted Project, Restricted Project
EricWF added a comment to D68075: Do not #error if no OS is #defined.

threading support is required to implement a conforming standard library. if we don't have it we're non-conforming.

Oct 4 2019, 10:03 PM · Restricted Project, Restricted Project
EricWF accepted D68276: Optimize operator=(const basic_string&) for tail call..
Oct 4 2019, 12:23 PM · Restricted Project

Oct 3 2019

EricWF committed rG5e7e6f16d945: Attempt to remove linker workaround on the buildbots: Attempt 2 (authored by EricWF).
Attempt to remove linker workaround on the buildbots: Attempt 2
Oct 3 2019, 12:38 PM
EricWF committed rL373653: Attempt to remove linker workaround on the buildbots: Attempt 2.
Attempt to remove linker workaround on the buildbots: Attempt 2
Oct 3 2019, 12:37 PM
EricWF committed rGbed690e3700b: Attempt to remove linker workaround on the buildbots. (authored by EricWF).
Attempt to remove linker workaround on the buildbots.
Oct 3 2019, 12:13 PM
EricWF committed rL373650: Attempt to remove linker workaround on the buildbots..
Attempt to remove linker workaround on the buildbots.
Oct 3 2019, 12:13 PM
EricWF requested changes to D68269: [libc++abi] Do not define new/delete by default.
Oct 3 2019, 11:01 AM · Restricted Project

Sep 30 2019

EricWF committed rGc8ad8686ac07: Refactor default constructor SFINAE in pair and tuple. (authored by EricWF).
Refactor default constructor SFINAE in pair and tuple.
Sep 30 2019, 1:55 PM
EricWF committed rL373263: Refactor default constructor SFINAE in pair and tuple..
Refactor default constructor SFINAE in pair and tuple.
Sep 30 2019, 1:53 PM

Sep 25 2019

EricWF committed rGaf4a29af0179: Add forward declaration of operator<< in <string_view> as required. (authored by EricWF).
Add forward declaration of operator<< in <string_view> as required.
Sep 25 2019, 11:58 AM
EricWF committed rL372909: Add forward declaration of operator<< in <string_view> as required..
Add forward declaration of operator<< in <string_view> as required.
Sep 25 2019, 11:58 AM
EricWF committed rGa32717750d77: add tests that debug mode catches nullptr->string_view conversions in… (authored by EricWF).
add tests that debug mode catches nullptr->string_view conversions in…
Sep 25 2019, 11:44 AM
EricWF committed rL372907: add tests that debug mode catches nullptr->string_view conversions in….
add tests that debug mode catches nullptr->string_view conversions in…
Sep 25 2019, 11:42 AM

Sep 24 2019

EricWF added a comment to D67944: Implement LWG 3296.

Can you use clang-format instead of custom formatting?

Sep 24 2019, 10:49 AM · Restricted Project
EricWF accepted D67667: Add benchmarks for string assign methods.

LGTM.

Sep 24 2019, 10:11 AM · Restricted Project

Sep 19 2019

EricWF added inline comments to D67052: Add reference type transformation builtins.
Sep 19 2019, 3:08 PM · Restricted Project, Restricted Project
EricWF added inline comments to D67052: Add reference type transformation builtins.
Sep 19 2019, 2:53 PM · Restricted Project, Restricted Project

Sep 18 2019

EricWF requested changes to D67675: [libc++] Remove C++03 variadics in shared_ptr.

I don't see any changes to tests. are the tests already sufficient or should we enable the c+ +11 tests?

Sep 18 2019, 10:16 AM · Restricted Project

Sep 14 2019

EricWF committed rG6bc1236d3951: Add debug check for null pointers passed to <string_view> (authored by EricWF).
Add debug check for null pointers passed to <string_view>
Sep 14 2019, 12:55 PM
EricWF committed rL371925: Add debug check for null pointers passed to <string_view>.
Add debug check for null pointers passed to <string_view>
Sep 14 2019, 12:54 PM

Sep 13 2019

EricWF added a comment to D67524: P1144 "Trivially relocatable" (3/3): optimize std::vector reallocate/insert and std::swap for trivially relocatable types.

How were the performance benefits measured? Are they visible in the existing benchmarks?

Sep 13 2019, 9:17 PM · Restricted Project
EricWF committed rGcb9216b908de: Fix C++03 build failures due to >> (authored by EricWF).
Fix C++03 build failures due to >>
Sep 13 2019, 1:32 PM
EricWF committed rL371894: Fix C++03 build failures due to >>.
Fix C++03 build failures due to >>
Sep 13 2019, 1:32 PM
EricWF committed rGe210c0383bef: Mark [[nodiscard]] test as unsupported with GCC 5 (authored by EricWF).
Mark [[nodiscard]] test as unsupported with GCC 5
Sep 13 2019, 12:10 PM
EricWF committed rL371886: Mark [[nodiscard]] test as unsupported with GCC 5.
Mark [[nodiscard]] test as unsupported with GCC 5
Sep 13 2019, 12:08 PM
EricWF committed rG556027085583: Fix pretty printer test with GCC (authored by EricWF).
Fix pretty printer test with GCC
Sep 13 2019, 12:05 PM
EricWF committed rL371884: Fix pretty printer test with GCC.
Fix pretty printer test with GCC
Sep 13 2019, 12:03 PM
EricWF committed rG75c9eb5ab235: Update XFAIL list for new GCC versions (authored by EricWF).
Update XFAIL list for new GCC versions
Sep 13 2019, 11:43 AM