Page MenuHomePhabricator

EricWF (Eric Fiselier)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 26 2014, 12:44 PM (242 w, 6 d)

Recent Activity

Yesterday

EricWF added a comment to D58425: Fix the build with gcc 8.x when `-Wredundant-decls` is passed.

These aren't definitions. They're declarations. And the warning or broken. We should turn it off not fix it

Tue, Feb 19, 11:22 PM · Restricted Project
EricWF accepted D58425: Fix the build with gcc 8.x when `-Wredundant-decls` is passed.

I'm fine with this. But it's a bogus warning

Tue, Feb 19, 11:17 PM · Restricted Project
EricWF added a comment to D58425: Fix the build with gcc 8.x when `-Wredundant-decls` is passed.

but this isn't redundant... as evidenced by the fact there is green in this patch .

Tue, Feb 19, 11:16 PM · Restricted Project

Thu, Feb 14

EricWF added a comment to D57872: [CMake] Split linked libraries for shared and static libc++.
combining these together in LIBCXX_LIBRARIES and LIBCXX_INTERFACE_LIBRARIES can introduce unnecessary dependencies.
Thu, Feb 14, 12:56 AM · Restricted Project
EricWF added inline comments to D58203: [libc++] Inline stdexcept constructors, destructors, and assignment operators when using MSVC ABI.
Thu, Feb 14, 12:26 AM
EricWF added inline comments to D58201: Make std::memory_order an enum class (P0439R0).
Thu, Feb 14, 12:21 AM

Wed, Feb 13

EricWF requested changes to D58203: [libc++] Inline stdexcept constructors, destructors, and assignment operators when using MSVC ABI.

hanks for looping me in. I'm working on a similar problem but with libstdc++.

Wed, Feb 13, 2:21 PM

Mon, Feb 11

EricWF committed rG9ebc9dbd3c7d: Don't declare fenv.h functions when they're a macro. (authored by EricWF).
Don't declare fenv.h functions when they're a macro.
Mon, Feb 11, 4:05 PM
EricWF committed rL353774: Don't declare fenv.h functions when they're a macro..
Don't declare fenv.h functions when they're a macro.
Mon, Feb 11, 4:05 PM
EricWF committed rCXX353774: Don't declare fenv.h functions when they're a macro..
Don't declare fenv.h functions when they're a macro.
Mon, Feb 11, 4:04 PM
EricWF committed rG1eb19e52774a: Make the sym_diff utilities more useful. (authored by EricWF).
Make the sym_diff utilities more useful.
Mon, Feb 11, 4:02 PM
EricWF committed rL353772: Make the sym_diff utilities more useful..
Make the sym_diff utilities more useful.
Mon, Feb 11, 4:02 PM
EricWF committed rCXX353772: Make the sym_diff utilities more useful..
Make the sym_diff utilities more useful.
Mon, Feb 11, 4:02 PM
EricWF committed rGcf39dd44b8d0: Add fenv.h header (authored by EricWF).
Add fenv.h header
Mon, Feb 11, 3:48 PM
EricWF committed rL353767: Add fenv.h header.
Add fenv.h header
Mon, Feb 11, 3:47 PM
EricWF committed rCXX353767: Add fenv.h header.
Add fenv.h header
Mon, Feb 11, 3:47 PM
EricWF closed D57729: Add fenv.h header.
Mon, Feb 11, 3:46 PM
EricWF added a comment to D57729: Add fenv.h header.

Gentle ping.

Mon, Feb 11, 9:47 AM

Sun, Feb 10

EricWF accepted D58021: Win32 does not have popcnt64 function and fix bug with defines in ctz function.

LGTM other than inline nits.

Sun, Feb 10, 10:50 PM
EricWF requested changes to D58022: __builtin_strlen is not supported for MSVC e.g and it is not correct to use it without knowledge of this "builtin" in advance.

MSVC on godbolt provides a constexpr __builtin_strlen. https://godbolt.org/z/n_3vRY

Sun, Feb 10, 10:40 PM
EricWF added inline comments to D58022: __builtin_strlen is not supported for MSVC e.g and it is not correct to use it without knowledge of this "builtin" in advance.
Sun, Feb 10, 10:37 PM
EricWF accepted D58024: [libcxx] Preserve order, avoid duplicates when merging static archives.
Sun, Feb 10, 10:35 PM
EricWF accepted D58025: [libcxx] MSVC fails to compile `operator valarray<template>`.
Sun, Feb 10, 10:34 PM
EricWF requested changes to D58023: [libcxx] MSVC does not provide constexpr for typeid and typeid is probably not constexpr.

MSVC is wrong and this code is well formed. Please file a bug with MSVC.
The wording is somewhere in [expr.const].

Sun, Feb 10, 10:30 PM
EricWF added inline comments to D58022: __builtin_strlen is not supported for MSVC e.g and it is not correct to use it without knowledge of this "builtin" in advance.
Sun, Feb 10, 9:11 PM
EricWF added a comment to D58022: __builtin_strlen is not supported for MSVC e.g and it is not correct to use it without knowledge of this "builtin" in advance.

What version of MSVC are you trying to use?

Sun, Feb 10, 8:54 PM
EricWF added inline comments to D58018: Dummy revision.
Sun, Feb 10, 2:36 PM
EricWF created D58018: Dummy revision.
Sun, Feb 10, 2:34 PM
EricWF added inline comments to D57778: std::abs should not return double (2735).
Sun, Feb 10, 1:58 PM
EricWF added inline comments to D58011: Fix -fsanitize=vptr badness in <__debug>.
Sun, Feb 10, 11:40 AM · Restricted Project
EricWF updated the diff for D58011: Fix -fsanitize=vptr badness in <__debug>.

Address review comments.

Sun, Feb 10, 11:40 AM · Restricted Project
EricWF added inline comments to D57778: std::abs should not return double (2735).
Sun, Feb 10, 11:29 AM
EricWF committed rGe8adbae00a3e: fix -Wextra-semi warnings (authored by EricWF).
fix -Wextra-semi warnings
Sun, Feb 10, 10:30 AM
EricWF committed rCXX353650: fix -Wextra-semi warnings.
fix -Wextra-semi warnings
Sun, Feb 10, 10:30 AM
EricWF committed rL353650: fix -Wextra-semi warnings.
fix -Wextra-semi warnings
Sun, Feb 10, 10:30 AM
EricWF committed rG9d487c7d1eaf: Make LIBCXX_STANDARD_VER configurable (authored by EricWF).
Make LIBCXX_STANDARD_VER configurable
Sun, Feb 10, 10:30 AM
EricWF committed rL353649: Make LIBCXX_STANDARD_VER configurable.
Make LIBCXX_STANDARD_VER configurable
Sun, Feb 10, 10:29 AM
EricWF committed rCXX353649: Make LIBCXX_STANDARD_VER configurable.
Make LIBCXX_STANDARD_VER configurable
Sun, Feb 10, 10:29 AM

Sat, Feb 9

EricWF created D58011: Fix -fsanitize=vptr badness in <__debug>.
Sat, Feb 9, 9:14 PM · Restricted Project
EricWF committed rG609d676aab5a: Format sym_extract.py output to minimize diff output. (authored by EricWF).
Format sym_extract.py output to minimize diff output.
Sat, Feb 9, 8:52 PM
EricWF committed rL353634: Format sym_extract.py output to minimize diff output..
Format sym_extract.py output to minimize diff output.
Sat, Feb 9, 8:48 PM
EricWF committed rCXX353634: Format sym_extract.py output to minimize diff output..
Format sym_extract.py output to minimize diff output.
Sat, Feb 9, 8:48 PM
EricWF committed rG17f93313392d: Add missing symbols to Apple v2 abi list. (authored by EricWF).
Add missing symbols to Apple v2 abi list.
Sat, Feb 9, 8:42 PM
EricWF committed rCXX353633: Add missing symbols to Apple v2 abi list..
Add missing symbols to Apple v2 abi list.
Sat, Feb 9, 8:41 PM
EricWF committed rL353633: Add missing symbols to Apple v2 abi list..
Add missing symbols to Apple v2 abi list.
Sat, Feb 9, 8:41 PM
EricWF committed rG7cddb6829206: Add ABI list directories for 8.0 (authored by EricWF).
Add ABI list directories for 8.0
Sat, Feb 9, 8:10 PM
EricWF committed rL353632: Add ABI list directories for 8.0.
Add ABI list directories for 8.0
Sat, Feb 9, 8:10 PM
EricWF committed rCXX353632: Add ABI list directories for 8.0.
Add ABI list directories for 8.0
Sat, Feb 9, 8:10 PM

Mon, Feb 4

EricWF created D57729: Add fenv.h header.
Mon, Feb 4, 6:09 PM

Sun, Feb 3

EricWF added a comment to D57624: Support tests in freestanding.

This feels like a fix at the wrong level.

Sun, Feb 3, 3:34 AM · Restricted Project

Sat, Feb 2

EricWF created D57645: [C++2a] Fix PR40576: Turn destroying delete off prior to C++2a. Add -fdestroying-delete.
Sat, Feb 2, 8:29 PM · Restricted Project
EricWF committed rL352983: Correct test my *really really* overaligning a type..
Correct test my *really really* overaligning a type.
Sat, Feb 2, 8:10 PM
EricWF committed rC352983: Correct test my *really really* overaligning a type..
Correct test my *really really* overaligning a type.
Sat, Feb 2, 8:10 PM
EricWF committed rC352980: Fix handling of usual deallocation functions in various configuratios..
Fix handling of usual deallocation functions in various configuratios.
Sat, Feb 2, 7:44 PM
EricWF committed rL352980: Fix handling of usual deallocation functions in various configuratios..
Fix handling of usual deallocation functions in various configuratios.
Sat, Feb 2, 7:44 PM
EricWF added a comment to D55840: P0722R3: Implement library support for destroying delete.

In C++20 we should declare destroying_delete_t, even if __cpp_impl_destroying_delete isn't defined.
But in that case should be define __cpp_lib_destroying_delete? The library has the type, but users
can't actually perform destroying delete.

Sat, Feb 2, 3:18 PM
EricWF committed rCXX352970: Move the feature test macros script to the utils directory..
Move the feature test macros script to the utils directory.
Sat, Feb 2, 3:14 PM
EricWF committed rL352970: Move the feature test macros script to the utils directory..
Move the feature test macros script to the utils directory.
Sat, Feb 2, 3:13 PM
EricWF added inline comments to D55840: P0722R3: Implement library support for destroying delete.
Sat, Feb 2, 2:26 PM

Fri, Feb 1

EricWF committed rL352942: Handle cases where the dirent::d_type macros aren't defined.
Handle cases where the dirent::d_type macros aren't defined
Fri, Feb 1, 3:52 PM
EricWF committed rCXX352942: Handle cases where the dirent::d_type macros aren't defined.
Handle cases where the dirent::d_type macros aren't defined
Fri, Feb 1, 3:52 PM
EricWF committed rL352927: Improve diagnostic to tell you a type is incomplete..
Improve diagnostic to tell you a type is incomplete.
Fri, Feb 1, 2:06 PM
EricWF committed rC352927: Improve diagnostic to tell you a type is incomplete..
Improve diagnostic to tell you a type is incomplete.
Fri, Feb 1, 2:05 PM
EricWF committed rC352919: Don't use ASTContext in DeclOpenMP.h because it's still incomplete..
Don't use ASTContext in DeclOpenMP.h because it's still incomplete.
Fri, Feb 1, 1:19 PM
EricWF committed rL352919: Don't use ASTContext in DeclOpenMP.h because it's still incomplete..
Don't use ASTContext in DeclOpenMP.h because it's still incomplete.
Fri, Feb 1, 1:19 PM

Tue, Jan 29

EricWF accepted D57362: [libc++] Don't define operator new/delete when using vcruntime.
Tue, Jan 29, 5:44 PM
EricWF accepted D57425: [libc++] Don't define exception destructors when using vcruntime.
Tue, Jan 29, 5:40 PM
EricWF accepted D57355: [libc++] Fix Windows build error in <functional>.
Tue, Jan 29, 2:17 PM
EricWF committed rCXX352522: Fix PR40495 - is_invokable_v<void> does not compile.
Fix PR40495 - is_invokable_v<void> does not compile
Tue, Jan 29, 10:01 AM
EricWF committed rL352522: Fix PR40495 - is_invokable_v<void> does not compile.
Fix PR40495 - is_invokable_v<void> does not compile
Tue, Jan 29, 10:01 AM

Mon, Jan 28

EricWF accepted D57354: [libc++] Fix Windows build error in include/filesystem.
Mon, Jan 28, 9:51 PM
EricWF added inline comments to D57351: [libc++] Explicitly initialize std::nothrow.
Mon, Jan 28, 9:48 PM
EricWF added a comment to D57355: [libc++] Fix Windows build error in <functional>.

Please add __allocator to nasty_macros.hpp (https://github.com/llvm-mirror/libcxx/blob/master/test/support/nasty_macros.hpp#L57)

Mon, Jan 28, 9:47 PM
EricWF requested changes to D57364: Bug fix for PR#40495 is_invokable_v<void> does not compile.

This doesn't address cases where any of the arguments are *cv void*. I'll take a stab at a fix tomorrow since I wrote all this metaprogramming.

Mon, Jan 28, 8:44 PM

Sun, Jan 27

EricWF committed rCXX352339: update upcoming meeting issue status.
update upcoming meeting issue status
Sun, Jan 27, 7:06 PM
EricWF committed rL352339: update upcoming meeting issue status.
update upcoming meeting issue status
Sun, Jan 27, 7:01 PM
EricWF updated the diff for D57312: Implement LWG 3112 - system_error and filesystem_error constructors taking a string may not be able to meet their postconditions.
Sun, Jan 27, 6:58 PM
EricWF created D57312: Implement LWG 3112 - system_error and filesystem_error constructors taking a string may not be able to meet their postconditions.
Sun, Jan 27, 6:56 PM
EricWF created D57311: Add __cxa_guard_acquire hooks to support cooperative scheduling.
Sun, Jan 27, 5:20 PM

Wed, Jan 23

EricWF updated the diff for D55500: [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a.
  • Add or correct tests as requested.
  • Fix code gen for initializers of reference types to correctly evaluate the initializer as a constant expression.
Wed, Jan 23, 9:56 PM
EricWF added inline comments to D55500: [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a.
Wed, Jan 23, 9:07 PM

Mon, Jan 21

EricWF added inline comments to D56997: Fix implementation of P0966 - string::reserve Should Not Shrink.
Mon, Jan 21, 4:42 PM

Jan 20 2019

EricWF accepted D56979: [libcxxabi] Enable LLVM_ENABLE_WARNINGS when building standalone out of tree.

Does libc++ need a similar change?

Jan 20 2019, 10:14 PM
EricWF added inline comments to D56997: Fix implementation of P0966 - string::reserve Should Not Shrink.
Jan 20 2019, 8:55 PM

Jan 19 2019

EricWF committed rL351670: Fix aligned allocation availability XFAILs after D56445..
Fix aligned allocation availability XFAILs after D56445.
Jan 19 2019, 5:21 PM
EricWF committed rCXX351670: Fix aligned allocation availability XFAILs after D56445..
Fix aligned allocation availability XFAILs after D56445.
Jan 19 2019, 5:21 PM
EricWF committed rL351669: Revert "Fix aligned allocation availability XFAILs after D56445.".
Revert "Fix aligned allocation availability XFAILs after D56445."
Jan 19 2019, 5:13 PM
EricWF committed rCXX351669: Revert "Fix aligned allocation availability XFAILs after D56445.".
Revert "Fix aligned allocation availability XFAILs after D56445."
Jan 19 2019, 5:13 PM
EricWF committed rL351668: make XFAIL, REQUIRES, and UNSUPPORTED support multi-line expressions.
make XFAIL, REQUIRES, and UNSUPPORTED support multi-line expressions
Jan 19 2019, 4:51 PM
EricWF committed rCXX351667: Improve docker images and configuration; create compiler-zoo image.
Improve docker images and configuration; create compiler-zoo image
Jan 19 2019, 3:37 PM
EricWF committed rL351667: Improve docker images and configuration; create compiler-zoo image.
Improve docker images and configuration; create compiler-zoo image
Jan 19 2019, 3:36 PM
EricWF committed rCXX351638: Fix all the bots..
Fix all the bots.
Jan 19 2019, 1:15 AM
EricWF committed rL351638: Fix all the bots..
Fix all the bots.
Jan 19 2019, 1:15 AM

Jan 18 2019

EricWF committed rCXX351625: Fix aligned allocation availability XFAILs after D56445..
Fix aligned allocation availability XFAILs after D56445.
Jan 18 2019, 7:32 PM
EricWF committed rL351625: Fix aligned allocation availability XFAILs after D56445..
Fix aligned allocation availability XFAILs after D56445.
Jan 18 2019, 7:31 PM
EricWF requested changes to D56692: More calendar bits for <chrono>.
Jan 18 2019, 5:58 PM

Jan 17 2019

EricWF committed rC351484: Add -Wctad-maybe-unsupported to diagnose CTAD on types with no user defined….
Add -Wctad-maybe-unsupported to diagnose CTAD on types with no user defined…
Jan 17 2019, 1:50 PM
EricWF committed rL351484: Add -Wctad-maybe-unsupported to diagnose CTAD on types with no user defined….
Add -Wctad-maybe-unsupported to diagnose CTAD on types with no user defined…
Jan 17 2019, 1:50 PM
EricWF closed D56731: Add -Wctad-maybe-unsupported to diagnose CTAD on types with no user defined deduction guides..
Jan 17 2019, 1:49 PM
EricWF retitled D56731: Add -Wctad-maybe-unsupported to diagnose CTAD on types with no user defined deduction guides. from Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides. to Add -Wctad-maybe-unsupported to diagnose CTAD on types with no user defined deduction guides..
Jan 17 2019, 1:38 PM