EricWF (Eric Fiselier)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 26 2014, 12:44 PM (185 w, 6 d)

Recent Activity

Today

EricWF added a comment to D42220: libcxx: Use vcruntime declarations for typeinfo on Windows..

Is this really a "fix" or does it just hide the ODR issue?

Wed, Jan 17, 5:31 PM
EricWF added a comment to D41727: [libcxx] Disable tautological-type-limit-compare warning.

@bcain Can we land it and then revert it once Clang decides what it's up to? That way we can get the 32bit builder green?

Wed, Jan 17, 3:34 PM
EricWF added a comment to D41727: [libcxx] Disable tautological-type-limit-compare warning.

LGTM with the change mentioned by @lebedev.ri .

Wed, Jan 17, 3:09 PM
EricWF committed rCXX322776: Fix nodiscard failure tests on compilers w/o -verify..
Fix nodiscard failure tests on compilers w/o -verify.
Wed, Jan 17, 2:49 PM
EricWF committed rL322776: Fix nodiscard failure tests on compilers w/o -verify..
Fix nodiscard failure tests on compilers w/o -verify.
Wed, Jan 17, 2:49 PM
EricWF committed rCXXA322768: Fix standalone test-suite run..
Fix standalone test-suite run.
Wed, Jan 17, 2:47 PM
EricWF committed rL322768: Fix standalone test-suite run..
Fix standalone test-suite run.
Wed, Jan 17, 2:10 PM

Fri, Jan 12

EricWF updated the diff for D37035: Implement __builtin_LINE() et. al. to support source location capture..
  • Introduce SourceLocExprScope.h to help reduce code duplication.
  • Merge with upstream.
Fri, Jan 12, 6:56 PM
EricWF updated the diff for D41977: [libc++] Fix PR20855 -- libc++ incorrectly diagnoses illegal reference binding in std::tuple..
  • Address @rsmith's comments by removing the fallback implementation of the diagnostics.
Fri, Jan 12, 6:45 PM
EricWF added a comment to D41977: [libc++] Fix PR20855 -- libc++ incorrectly diagnoses illegal reference binding in std::tuple..

This will still diagnose valid and reasonable programs, such as:

struct ConvertToRef { operator int&(); };
std::tuple<int&> t = {ConvertToRef()};

... on compilers that don't provide the trait. You could maybe try to work around that by checking to see if the type has a member .operator int&(). But perhaps it's better to remove the non-conforming check entirely, at least in the case where you can't reasonably get it right.

Fri, Jan 12, 5:56 PM
EricWF updated the diff for D40218: [Clang] Add __builtin_launder.
  • Improve diagnostic handling.
Fri, Jan 12, 5:49 PM
EricWF updated the diff for D40218: [Clang] Add __builtin_launder.
  • Address inline comments about missing diagnostics for void pointers and function pointers.
  • Address inline comments about only enabling when -fstrict-vtable-pointers is specified, and only on types with vtables.
Fri, Jan 12, 5:25 PM
EricWF added inline comments to D40218: [Clang] Add __builtin_launder.
Fri, Jan 12, 5:23 PM

Thu, Jan 11

EricWF committed rL322349: [CMake] Add LLVM_ENABLE_IDE option to better process sources for IDE's.
[CMake] Add LLVM_ENABLE_IDE option to better process sources for IDE's
Thu, Jan 11, 8:03 PM
EricWF closed D40219: [CMake] Add LLVM_ENABLE_IDE option to better process sources for IDE's.
Thu, Jan 11, 8:02 PM
EricWF updated the diff for D40219: [CMake] Add LLVM_ENABLE_IDE option to better process sources for IDE's.
  • Address inline comments.
Thu, Jan 11, 8:00 PM
EricWF created D41977: [libc++] Fix PR20855 -- libc++ incorrectly diagnoses illegal reference binding in std::tuple..
Thu, Jan 11, 7:33 PM
EricWF added a comment to D41820: [coroutines] Pass coro func args to promise ctor.

Is this behavior specified somewhere? Or are we simply adding an extension to Clang? If so I would really prefer to add my co_promise solution (but I need to write a paper in favor of it first).

Thu, Jan 11, 5:09 PM
EricWF committed rC322334: Add `__reference_binds_to_temporary` trait for checking safe reference….
Add `__reference_binds_to_temporary` trait for checking safe reference…
Thu, Jan 11, 4:11 PM
EricWF committed rL322334: Add `__reference_binds_to_temporary` trait for checking safe reference….
Add `__reference_binds_to_temporary` trait for checking safe reference…
Thu, Jan 11, 4:11 PM
EricWF closed D29930: Add `__reference_binds_to_temporary` trait for checking safe reference initialization..
Thu, Jan 11, 4:10 PM
EricWF accepted D41958: Create a deduction guide for basic_string.

LGTM other than inline comments.

Thu, Jan 11, 4:08 PM
EricWF updated the diff for D29930: Add `__reference_binds_to_temporary` trait for checking safe reference initialization..

Address inline comments.

Thu, Jan 11, 3:43 PM
EricWF added a comment to D29930: Add `__reference_binds_to_temporary` trait for checking safe reference initialization..

@rsmith The trait is already documented in LanguageExtensions.rst, so I'll assumed you missed that and are not trying to suggest more documentation is needed.

Thu, Jan 11, 3:30 PM
EricWF accepted D41746: Make std::get_temporary_buffer respect overaligned types when possible.

This LGTM minus nits.

Thu, Jan 11, 2:34 PM
EricWF added inline comments to D41830: [libc++] Fix PR#35780 - make std::experimental::filesystem::remove and remove_all return false or 0 if the file doesn't exist.
Thu, Jan 11, 2:09 PM

Mon, Jan 8

EricWF accepted D40513: [libcxx] Support the use of compiler-rt in lit tests.

LGTM. Honestly, I'm surprised we don't already have a way to configure like this.

Mon, Jan 8, 3:17 PM

Sun, Jan 7

EricWF accepted D41805: Add pre-C++11 is_constructible wrappers for 3 arguments.

LGTM.

Sun, Jan 7, 12:43 AM

Dec 13 2017

EricWF updated the diff for D41223: [libc++] Fix PR35491 - std::array of zero-size doesn't work with non-default constructible types..

Fix begin/end/data.

Dec 13 2017, 11:17 PM
EricWF created D41223: [libc++] Fix PR35491 - std::array of zero-size doesn't work with non-default constructible types..
Dec 13 2017, 10:45 PM
EricWF added inline comments to D41148: [libcxx] implement <experimental/simd> declarations based on P0214R7..
Dec 13 2017, 2:05 PM

Nov 25 2017

EricWF committed rL318989: Fix installation of cxxabi.h through libc++..
Fix installation of cxxabi.h through libc++.
Nov 25 2017, 3:39 PM
EricWF accepted D40415: [libcxx] Define istream_iterator equality comparison operators out-of-line.

LGTM. Thanks.

Nov 25 2017, 1:13 AM

Nov 22 2017

EricWF committed rL318865: [libcxx] Implement std::to_address for C++20.
[libcxx] Implement std::to_address for C++20
Nov 22 2017, 11:50 AM
EricWF closed D35470: [libcxx] Implement std::to_address for C++20.
Nov 22 2017, 11:50 AM
EricWF requested changes to D40259: [libcxx] LWG2993: reference_wrapper<T> conversion from T&&.
Nov 22 2017, 11:40 AM
EricWF accepted D40144: Implement `std::launder`.
Nov 22 2017, 11:30 AM

Nov 21 2017

EricWF added inline comments to D40144: Implement `std::launder`.
Nov 21 2017, 7:32 PM
EricWF accepted D35470: [libcxx] Implement std::to_address for C++20.
Nov 21 2017, 7:27 PM
EricWF added inline comments to D40144: Implement `std::launder`.
Nov 21 2017, 7:22 PM
EricWF accepted D40324: [libcxx] [test] Resolve C1XX warning in new vector<bool>::size tests caused by assert(true).
Nov 21 2017, 2:58 PM
EricWF accepted D40323: [libcxx] Remove a broken win32 locale function redirection.
Nov 21 2017, 2:38 PM
EricWF accepted D40065: [libcxx] [test] Change (void)s to TEST_IGNORE_NODISCARD as requested by Eric..

LGTM.

Nov 21 2017, 8:38 AM
EricWF accepted D40279: [libcxxabi][demangler] Add demangling for __attribute__((abi_tag)).

LGTM. Thanks.

Nov 21 2017, 7:51 AM
EricWF updated the diff for D29930: Add `__reference_binds_to_temporary` trait for checking safe reference initialization..
  • Address spelling errors pointed out during review.
Nov 21 2017, 2:00 AM
EricWF added inline comments to D40279: [libcxxabi][demangler] Add demangling for __attribute__((abi_tag)).
Nov 21 2017, 1:57 AM
EricWF added inline comments to D29930: Add `__reference_binds_to_temporary` trait for checking safe reference initialization..
Nov 21 2017, 1:40 AM
EricWF added inline comments to D40259: [libcxx] LWG2993: reference_wrapper<T> conversion from T&&.
Nov 21 2017, 1:29 AM
EricWF added inline comments to D40259: [libcxx] LWG2993: reference_wrapper<T> conversion from T&&.
Nov 21 2017, 12:04 AM

Nov 20 2017

EricWF added a comment to D29930: Add `__reference_binds_to_temporary` trait for checking safe reference initialization..

@rsmith Ping.

Nov 20 2017, 12:36 PM
EricWF committed rL318690: Fix std::string::data() symbol during library build..
Fix std::string::data() symbol during library build.
Nov 20 2017, 12:23 PM
EricWF accepted D40181: [libcxx] Allow to set locale on Windows..

This LGTM. I would love if another party interested in Windows could review it though.

Nov 20 2017, 12:06 PM
EricWF added inline comments to D35470: [libcxx] Implement std::to_address for C++20.
Nov 20 2017, 11:47 AM
EricWF added a comment to D40259: [libcxx] LWG2993: reference_wrapper<T> conversion from T&&.

Also, you're lacking tests for noexcept and the deduction guide.

Nov 20 2017, 11:45 AM
EricWF requested changes to D40259: [libcxx] LWG2993: reference_wrapper<T> conversion from T&&.

I would much rather take this change in all dialects except for C++03.

Nov 20 2017, 11:41 AM
EricWF updated the diff for D40218: [Clang] Add __builtin_launder.
  • Improve quality of tests.
  • Format code.
Nov 20 2017, 11:20 AM

Nov 19 2017

EricWF added a comment to D35470: [libcxx] Implement std::to_address for C++20.

Initially this LGTM. I'll take another pass in the morning.

Nov 19 2017, 5:59 PM
EricWF updated the diff for D40218: [Clang] Add __builtin_launder.
  • Fix argument initialization.
  • Make constexpr.
Nov 19 2017, 2:24 PM
EricWF added inline comments to D40218: [Clang] Add __builtin_launder.
Nov 19 2017, 2:12 PM
EricWF committed rL318625: Attempt to fix template depth test failures on older Clang versions.
Attempt to fix template depth test failures on older Clang versions
Nov 19 2017, 1:46 AM

Nov 18 2017

EricWF committed rL318622: Fix min/max usage in variant.
Fix min/max usage in variant
Nov 18 2017, 8:57 PM
EricWF committed rL318621: [libc++] Shrink variant's index type when possible.
[libc++] Shrink variant's index type when possible
Nov 18 2017, 8:19 PM
EricWF closed D40210: [libc++] Shrink variant's index type when possible.
Nov 18 2017, 8:19 PM
EricWF committed rL318618: Fix nodiscard test when modules are enabled.
Fix nodiscard test when modules are enabled
Nov 18 2017, 7:52 PM
EricWF updated the diff for D40210: [libc++] Shrink variant's index type when possible.
  • Address inline comments.
Nov 18 2017, 7:48 PM
EricWF added inline comments to D40210: [libc++] Shrink variant's index type when possible.
Nov 18 2017, 7:47 PM
EricWF committed rL318607: [LIT] Fix testing out-of-tree Clang builds.
[LIT] Fix testing out-of-tree Clang builds
Nov 18 2017, 4:01 PM
EricWF closed D40217: [LIT] Fix testing out-of-tree Clang builds.
Nov 18 2017, 4:00 PM
EricWF accepted D40217: [LIT] Fix testing out-of-tree Clang builds.

Accepting for post-commit review. I don't want to be carrying this patch locally.

Nov 18 2017, 3:59 PM
EricWF added a comment to D40144: Implement `std::launder`.

I've made an attempt to add __builtin_launder to clang in D40218.

Nov 18 2017, 3:56 PM
EricWF created D40219: [CMake] Add LLVM_ENABLE_IDE option to better process sources for IDE's.
Nov 18 2017, 3:55 PM
EricWF committed rL318606: Default most libc++ builders to the latest C++ dialect.
Default most libc++ builders to the latest C++ dialect
Nov 18 2017, 3:24 PM
EricWF committed rL318604: Add libc++ C++2a buildbot.
Add libc++ C++2a buildbot
Nov 18 2017, 3:18 PM
EricWF updated the diff for D40217: [LIT] Fix testing out-of-tree Clang builds.
Nov 18 2017, 3:12 PM
EricWF updated the diff for D40218: [Clang] Add __builtin_launder.
  • Remove incorrect FIXME comment.
Nov 18 2017, 3:05 PM
EricWF created D40218: [Clang] Add __builtin_launder.
Nov 18 2017, 3:03 PM
EricWF committed rL318602: Fix use of config.h in public headers..
Fix use of config.h in public headers.
Nov 18 2017, 2:42 PM
EricWF created D40217: [LIT] Fix testing out-of-tree Clang builds.
Nov 18 2017, 2:24 PM
EricWF added inline comments to D39747: [globalisel][tablegen] Generate rule coverage and use it to identify untested rules.
Nov 18 2017, 1:05 PM
EricWF created D40210: [libc++] Shrink variant's index type when possible.
Nov 18 2017, 12:38 PM
EricWF added a comment to D40144: Implement `std::launder`.

I think we may want a __launder function that we can use internally in all dialects.

Nov 18 2017, 12:30 PM

Nov 14 2017

EricWF committed rL318247: Update Appveyor LLVM install link to be current and non-broken.
Update Appveyor LLVM install link to be current and non-broken
Nov 14 2017, 5:39 PM

Nov 7 2017

EricWF accepted D39751: [libc++] Add _LIBCPP_INLINE_VISIBILITY to __compressed_pair_elem members.
Nov 7 2017, 10:11 PM
EricWF committed rL317611: Teach test suite about C++2a dialect flag..
Teach test suite about C++2a dialect flag.
Nov 7 2017, 12:27 PM
EricWF committed rL317610: Change test suite to support c++17 dialect flag instead of c++1z..
Change test suite to support c++17 dialect flag instead of c++1z.
Nov 7 2017, 12:21 PM

Nov 6 2017

EricWF resigned from D39602: Update tuple/list/deque data formatters to work with newest libc++.
Nov 6 2017, 6:45 PM
EricWF accepted D39221: [libcxx] [test] Alignment must be > __STDCPP_DEFAULT_NEW_ALIGNMENT__ to call aligned new.
Nov 6 2017, 6:42 PM
EricWF accepted D38831: [libcxx] P0604, invoke_result and is_invocable.

@K-ballo I always forget. Do you have commit access?

Nov 6 2017, 6:39 PM
EricWF added a comment to D38635: Add 'first link flags' for building tests.

Are the changes that actually use this feature going to be upstreamed as well? Or are they specific to an internal build? It's never great to introduce seemingly dead or unused code.

Nov 6 2017, 6:33 PM
EricWF accepted D39080: [libcxx] [test] Tolerate even more [[nodiscard]] in the STL..

I think I would prefer if this patch "left an explicit trace" as to the reasons for all the (void) casts. Specifically I think a macro like TEST_IGNORE_DISCARD <expr> might be nice.

Nov 6 2017, 6:28 PM
EricWF accepted D39537: Rename identifiers named `__output`.

LGTM minus inline comments.

Nov 6 2017, 6:25 PM
EricWF accepted D39608: [Reland] [libc++] Don't alias quick_exit if __ANDROID_API__ < 21.

LGTM.

Nov 6 2017, 6:24 PM

Nov 3 2017

EricWF requested changes to D35472: Implement P0463R1: "Endian just Endian".
Nov 3 2017, 12:41 PM

Oct 30 2017

EricWF committed rL316941: Implement LWG 3013 - some filesystem members should not be noexcept..
Implement LWG 3013 - some filesystem members should not be noexcept.
Oct 30 2017, 12:00 PM
EricWF committed rL316939: Fix PR35078 - recursive directory iterator's increment method throws….
Fix PR35078 - recursive directory iterator's increment method throws…
Oct 30 2017, 11:44 AM
EricWF added a comment to D39405: std::set_union accesses values after move..

We should backport this, right @mclow.lists?

Oct 30 2017, 11:04 AM

Oct 17 2017

EricWF accepted D39033: [libcxx] [test] Tolerate [[nodiscard]] on STL functions in libcxx tests.
Oct 17 2017, 7:30 PM
EricWF committed rL316021: Refactor std::list node allocation logic..
Refactor std::list node allocation logic.
Oct 17 2017, 12:12 PM
EricWF committed rL316009: fix shadowing warnings in new tests, try 2.
fix shadowing warnings in new tests, try 2
Oct 17 2017, 9:07 AM
EricWF committed rL315997: fix shadowing warnings in new tests.
fix shadowing warnings in new tests
Oct 17 2017, 6:46 AM