- User Since
- Jun 26 2014, 12:44 PM (207 w, 5 d)
Sat, Jun 9
Remove -nostdinc++ check as requested.
Thu, Jun 7
Tue, Jun 5
I think we should sink the DiagnoseUnavailableAlignedAllocation into DiagnoseUseOfDecl, and then adds call's in the few places they're needed. Most paths we care about already pass through there.
@fidget324 Thanks for the patch! Unfortunatly I didn't know you were planning on contributing a fix, so I went ahead and fixed it myself in r334053.
Mon, Jun 4
As previously mentioned, most of these changes deal with symbols which are externally instantiated. These symbols cannot be inlined unless the inline keyword is explicitly specified. The addition of __attribute__((noinline)) likely has no effect in a large number of cases.
Fri, Jun 1
Update the patch with the form suggested in the previous conversation. See the updated summary for a description of the behavior.
The new path forward sounds good to me. I'll work on implementing it.
I should have asked, have we actually seen a midcompile caused by this? Is there a reproducer? Or is this purerly speculative?
Thu, May 31
Overall this change seems reasonable to me. Thanks for working on this. Initially I was concerned we would hit issues optimizing const objects,
but I should have read your description first! Thanks for ensuring Clang doesn't optimize on this.
LGTM after addressing inline comments.
So the reason there are atime tests at all is due to the implementation details of __last_write_time here. Essentially we have to do extra work trying to maintain the access time.
Wed, May 30
Tue, May 29
- Fix merge conflicts.
Actually I'm OK making this a post-commit review. @rsmith Please let me know if you have any thoughts in your own time.
- Merge with upstream.
Mon, May 28
FYI I have a full implementation of this laying around as D27402 (https://reviews.llvm.org/D27402). But I have never taken the time to resolve merge conflicts.
Feel free to steal any of the tests if they're still relevant.
Committed as r333384.
Mon, May 21
May 19 2018
This LGTM. Let's land it and see if anybody complains.
I should add that this is the approach I've taken with <experimental/filesystem> with no complaints.
May 18 2018
- Remove changes to Sema, and overload resolution diagnostics. Only change the special member function diagnostics as an example.
- Handle array types as requested.
I would prefer if we completed <experimental/memory_resource> (according to the current standard, not the LFTS spec), and then moved it.
Sorry @rsmith, I was just about to tackle this.
- Add error if a substitution and a diagnostic share the same name.
Committed as r332767.
Committed in r332763.
May 13 2018
- proof read and correct documentation.
May 12 2018
Address @rsmiths comments.
Document %sub in InternalsManual.rst
Looking at the actual raw diff, it looks like it's indented correctly - but phab's being a little weird about how it's displaying it.
I couldn't actually apply the phab patch directly, so I had to recreate it. So I'm not talking about any problem in specific.
OK, here's what I would do:
This also LGTM. Please make sure to correct the new blocks are properly indented before committing.
Sorry for the delay. This LGTM.
- Get argument renumbering work as @rsmith requested.
- Make the changes to existing diagnostics whitespace correct.
- Cleanup DiagnosticSemaKinds.td and SemaOverload.cpp to take advantage of this change.
@rsmith Can select indexes be negative? What's the correct type to represent them? Existing code seems to use int, but the LLVM style seems to suggest unsigned is more appropriate.
- Update tests.
@rsmith How does this look?
May 10 2018
- Update tests and improve diagnostics. Still more work to be done here though.
Fix fetching the correct source location information in CXXRewrittenOperatorExpr.
Do better english in diagnostics.