Page MenuHomePhabricator

EricWF (Eric Fiselier)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 26 2014, 12:44 PM (260 w, 5 d)

Recent Activity

Today

EricWF committed rGae9e42f614f8: Revert "Change the ABI version and ABI namespace to be `_LIBCPP_VERSION`" (authored by EricWF).
Revert "Change the ABI version and ABI namespace to be `_LIBCPP_VERSION`"
Tue, Jun 25, 5:06 PM
EricWF committed rL364363: Revert "Change the ABI version and ABI namespace to be `_LIBCPP_VERSION`".
Revert "Change the ABI version and ABI namespace to be `_LIBCPP_VERSION`"
Tue, Jun 25, 5:06 PM
EricWF added a comment to D63744: In the libc++ unstable ABI, use [[no_unique_address]] instead of __compressed_pair when available..

Thanks for working on this! __compressed_pair is a menace which causes serious template and code bloat.
And the code without it is much clearer and cleaner.

Tue, Jun 25, 4:04 PM · Restricted Project
EricWF added inline comments to D63748: Pass std::unique_ptr, std::shared_ptr and std::weak_ptr in registers when possible..
Tue, Jun 25, 3:19 PM · Restricted Project
EricWF committed rG1fa0f4b94241: Change the ABI version and ABI namespace to be `_LIBCPP_VERSION` when… (authored by EricWF).
Change the ABI version and ABI namespace to be `_LIBCPP_VERSION` when…
Tue, Jun 25, 3:15 PM
EricWF committed rL364354: Change the ABI version and ABI namespace to be `_LIBCPP_VERSION`.
Change the ABI version and ABI namespace to be `_LIBCPP_VERSION`
Tue, Jun 25, 3:13 PM
EricWF added inline comments to D60480: [libc++] Integrate the PSTL into libc++.
Tue, Jun 25, 3:09 PM · Restricted Project, Restricted Project
EricWF added a comment to D48680: Add missing visibility annotation for __base.

You have an ODR violation. You can't compile one TU with -fno-rtti -fno-exceptions and another without. You give the definitions of __base different vtables.

Tue, Jun 25, 2:26 AM

Yesterday

EricWF added inline comments to D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'.
Mon, Jun 24, 1:50 PM · Restricted Project, Restricted Project, Restricted Project
EricWF added a comment to D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'.

Generally this LGTM.
I'll take another pass after the comments are addressed.

Mon, Jun 24, 1:31 PM · Restricted Project, Restricted Project, Restricted Project

Sun, Jun 23

EricWF committed rGfb2bd4a9398b: Use C++11 implementation of unique_ptr in C++03. (authored by EricWF).
Use C++11 implementation of unique_ptr in C++03.
Sun, Jun 23, 1:48 PM
EricWF committed rL364161: Use C++11 implementation of unique_ptr in C++03..
Use C++11 implementation of unique_ptr in C++03.
Sun, Jun 23, 1:48 PM
EricWF committed rG3359a17b3aef: Apply new meta-programming traits throughout the library. (authored by EricWF).
Apply new meta-programming traits throughout the library.
Sun, Jun 23, 1:30 PM
EricWF committed rL364160: Apply new meta-programming traits throughout the library..
Apply new meta-programming traits throughout the library.
Sun, Jun 23, 1:29 PM
EricWF added a comment to D63230: Add observer_ptr.

The implementation looks great!

Sun, Jun 23, 12:38 PM
EricWF accepted D63346: [libcxx] [test] Read files as bytestrings to fix py3 encoding issues.

Thanks. Sorry for the delay.

Sun, Jun 23, 9:02 AM · Restricted Project

Sat, Jun 22

EricWF committed rG8d7924560eaf: Disable test by default (authored by EricWF).
Disable test by default
Sat, Jun 22, 9:01 PM
EricWF committed rGde2b633a4a06: Add super fast _IsSame trait for internal use. (authored by EricWF).
Add super fast _IsSame trait for internal use.
Sat, Jun 22, 9:01 PM
EricWF committed rL364149: Disable test by default.
Disable test by default
Sat, Jun 22, 9:00 PM
EricWF committed rL364148: Add super fast _IsSame trait for internal use..
Add super fast _IsSame trait for internal use.
Sat, Jun 22, 8:59 PM
EricWF committed rGcf92a1f6eb1b: Add noexcept throughout <atomic> (authored by EricWF).
Add noexcept throughout <atomic>
Sat, Jun 22, 7:50 PM
EricWF committed rL364146: Add noexcept throughout <atomic>.
Add noexcept throughout <atomic>
Sat, Jun 22, 7:50 PM
EricWF committed rG2a31c9ba6779: Fix placement of -Wno-ignored-attributes (authored by EricWF).
Fix placement of -Wno-ignored-attributes
Sat, Jun 22, 5:33 PM
EricWF committed rL364144: Fix placement of -Wno-ignored-attributes.
Fix placement of -Wno-ignored-attributes
Sat, Jun 22, 5:31 PM
EricWF committed rGbc85dbe2ba7a: Disable -Wignored-attributes for now (authored by EricWF).
Disable -Wignored-attributes for now
Sat, Jun 22, 5:18 PM
EricWF committed rL364142: Disable -Wignored-attributes for now.
Disable -Wignored-attributes for now
Sat, Jun 22, 5:17 PM

Fri, Jun 21

EricWF committed rL364114: Add new style meta-programming primatives..
Add new style meta-programming primatives.
Fri, Jun 21, 5:08 PM
EricWF committed rG51a741c87fa8: Add new style meta-programming primatives. (authored by EricWF).
Add new style meta-programming primatives.
Fri, Jun 21, 4:42 PM
EricWF accepted D63574: Implement P0340R3: Make `underlying_type` SFINAE-friendly.
Fri, Jun 21, 9:26 AM
EricWF committed rGe652f8097b80: Use rvalue references throughout the is_constructible traits. (authored by EricWF).
Use rvalue references throughout the is_constructible traits.
Fri, Jun 21, 8:35 AM
EricWF committed rL364065: Use rvalue references throughout the is_constructible traits..
Use rvalue references throughout the is_constructible traits.
Fri, Jun 21, 8:32 AM
EricWF committed rG000f25a37e76: Make move and forward work in C++03. (authored by EricWF).
Make move and forward work in C++03.
Fri, Jun 21, 8:19 AM
EricWF committed rL364063: Make move and forward work in C++03..
Make move and forward work in C++03.
Fri, Jun 21, 8:19 AM
EricWF committed rGf044ebeb8d06: Enable aligned_union in C++03 (authored by EricWF).
Enable aligned_union in C++03
Fri, Jun 21, 7:43 AM
EricWF committed rL364058: Enable aligned_union in C++03.
Enable aligned_union in C++03
Fri, Jun 21, 7:43 AM
EricWF committed rL364057: Get is_convertible tests passing in C++03 (except the fallback)..
Get is_convertible tests passing in C++03 (except the fallback).
Fri, Jun 21, 7:42 AM
EricWF committed rGb6a9afa8236b: Get is_convertible tests passing in C++03 (except the fallback). (authored by EricWF).
Get is_convertible tests passing in C++03 (except the fallback).
Fri, Jun 21, 7:42 AM
EricWF committed rG3503d84ae0f6: Remove dead non-variadic workarounds in <type_traits> (authored by EricWF).
Remove dead non-variadic workarounds in <type_traits>
Fri, Jun 21, 7:35 AM
EricWF committed rL364054: Remove dead non-variadic workarounds in <type_traits>.
Remove dead non-variadic workarounds in <type_traits>
Fri, Jun 21, 7:34 AM
EricWF committed rG87cf92d9cb93: Make rvalue metaprogramming traits work in C++03. (authored by EricWF).
Make rvalue metaprogramming traits work in C++03.
Fri, Jun 21, 7:29 AM
EricWF committed rL364053: Make rvalue metaprogramming traits work in C++03..
Make rvalue metaprogramming traits work in C++03.
Fri, Jun 21, 7:28 AM
EricWF committed rG5b4cc84b8723: Remove even more dead code. (authored by EricWF).
Remove even more dead code.
Fri, Jun 21, 7:10 AM
EricWF committed rL364050: Remove even more dead code..
Remove even more dead code.
Fri, Jun 21, 7:10 AM
EricWF committed rG395c7330e49f: Assume __is_final, __is_base_of, and friends. (authored by EricWF).
Assume __is_final, __is_base_of, and friends.
Fri, Jun 21, 6:55 AM
EricWF committed rL364047: Assume __is_final, __is_base_of, and friends..
Assume __is_final, __is_base_of, and friends.
Fri, Jun 21, 6:55 AM
EricWF committed rG8d30a6e40c6b: Remove dead config now that C++03 requires Clang. (authored by EricWF).
Remove dead config now that C++03 requires Clang.
Fri, Jun 21, 4:32 AM
EricWF committed rL364031: Remove dead config now that C++03 requires Clang..
Remove dead config now that C++03 requires Clang.
Fri, Jun 21, 4:31 AM
EricWF updated the diff for D62228: Make `vector` unconditionally move elements when exceptions are disabled..

Sorry, I think the previous patch was misleading. My ambitions don't extend beyond this small performance fix. There are no other places in libc++ that conditionally move.

Fri, Jun 21, 4:19 AM · Restricted Project
EricWF requested changes to D60480: [libc++] Integrate the PSTL into libc++.
Fri, Jun 21, 3:21 AM · Restricted Project, Restricted Project

Thu, Jun 20

EricWF requested changes to D63574: Implement P0340R3: Make `underlying_type` SFINAE-friendly.
Thu, Jun 20, 2:41 PM
EricWF added a comment to D63346: [libcxx] [test] Read files as bytestrings to fix py3 encoding issues.

Is this backwards compatible as well?

Thu, Jun 20, 10:11 AM · Restricted Project

Wed, Jun 19

EricWF added a comment to D63328: [libc++] Avoid using timespec when it might not be available.

This isn't a question of C11 because timespec has been a part of the POSIX spec forever.

Wed, Jun 19, 8:18 AM · Restricted Project, Restricted Project

Tue, Jun 18

EricWF committed rG5c739665a872: Remove GCC C++03 fallbacks for decltype and static_assert. (authored by EricWF).
Remove GCC C++03 fallbacks for decltype and static_assert.
Tue, Jun 18, 1:49 PM
EricWF committed rL363738: Remove GCC C++03 fallbacks for decltype and static_assert..
Remove GCC C++03 fallbacks for decltype and static_assert.
Tue, Jun 18, 1:47 PM
EricWF committed rGa8aa58fb3d3b: Reconfigure docker builders to be more modular. (authored by EricWF).
Reconfigure docker builders to be more modular.
Tue, Jun 18, 12:29 PM
EricWF committed rL363722: Reconfigure docker builders to be more modular..
Reconfigure docker builders to be more modular.
Tue, Jun 18, 12:29 PM

Mon, Jun 17

EricWF added inline comments to D63457: [libc++] Re-export libc++abi as a whole instead of using lists.
Mon, Jun 17, 2:17 PM · Restricted Project
EricWF added a comment to D63457: [libc++] Re-export libc++abi as a whole instead of using lists.

Did sym_extract.py remove those symbols from the list, or were they removed manually? Because they should still be present in the libc++ symbol table as imported definitions (I think).

Mon, Jun 17, 2:13 PM · Restricted Project

Sun, Jun 16

EricWF accepted D63345: [libcxxabi] Use an explicit list to export symbols from the dylib.

add_llvm_symbol_exports in the LLVM CMake files have a cross-platform way of doing export files: http://llvm-cs.pcc.me.uk/cmake/modules/AddLLVM.cmake#71

It compiles to exported_symbols_list on mac, creates a linker script on posix, and creates a def file on Windows.

Interesting, thanks for the heads up. It looks like it supports multiple calls with different export lists for the same target, too, right?

However, we'd have to either drop support for the standalone libc++ build or copy the function to libc++'s CMake modules. @EricWF Does this seem okay until we're fully on the monorepo and the standalone libc++ build is no more?

Sun, Jun 16, 5:11 AM · Restricted Project

Sat, Jun 15

EricWF committed rG186ca60e5123: add header to help with template testing (authored by EricWF).
add header to help with template testing
Sat, Jun 15, 2:14 PM
EricWF committed rL363503: add header to help with template testing.
add header to help with template testing
Sat, Jun 15, 2:14 PM

Fri, Jun 14

EricWF committed rG2ade4f6f72e0: attempt to unbreak buildbots (authored by EricWF).
attempt to unbreak buildbots
Fri, Jun 14, 12:30 PM
EricWF committed rL363442: attempt to unbreak buildbots.
attempt to unbreak buildbots
Fri, Jun 14, 12:29 PM

Thu, Jun 13

EricWF added a comment to D51262: Implement P0553 and P0556.

Please use Clang format on these changes.

Thu, Jun 13, 11:30 PM
EricWF added a comment to D63230: Add observer_ptr.

Questions:

Is it okay to use constexpr and noexcept or should I use the macros?

Thu, Jun 13, 11:20 PM
EricWF added a comment to D63063: Bug 42208: speeding up std::merge.

Binary size isn't

Thu, Jun 13, 10:00 PM
EricWF accepted D63296: [libc++] Fix build with gcc 4.8.

This change is OK.

Thu, Jun 13, 2:45 PM · Restricted Project, Restricted Project
EricWF accepted D63297: [libcxxabi] Remove the unused buildit script.

I think Apple was the last user of this?

Thu, Jun 13, 2:28 PM · Restricted Project, Restricted Project
EricWF added a comment to D63296: [libc++] Fix build with gcc 4.8.

We don't support GCC 4.8. We require GCC 5.

Thu, Jun 13, 1:56 PM · Restricted Project, Restricted Project
EricWF added reviewers for D62060: Make libc++'s libc++abi discovery work in the monorepo layout: ldionne, phosek.
Thu, Jun 13, 12:31 PM

Wed, Jun 12

EricWF committed rG5de7cacf0797: Make GCC in C++03 Unsupported (authored by EricWF).
Make GCC in C++03 Unsupported
Wed, Jun 12, 5:35 PM
EricWF committed rL363219: Make GCC in C++03 Unsupported.
Make GCC in C++03 Unsupported
Wed, Jun 12, 5:34 PM
EricWF closed D63154: Make GCC in C++03 Unsupported.
Wed, Jun 12, 5:34 PM · Restricted Project
EricWF accepted D63154: Make GCC in C++03 Unsupported.

I plan to commit this shortly.

Wed, Jun 12, 1:29 PM · Restricted Project

Tue, Jun 11

EricWF committed rG14d4869209cc: Apply [[nodebug]] to typedefs throughout the STL. (authored by EricWF).
Apply [[nodebug]] to typedefs throughout the STL.
Tue, Jun 11, 7:01 PM
EricWF committed rL363117: Apply [[nodebug]] to typedefs throughout the STL..
Apply [[nodebug]] to typedefs throughout the STL.
Tue, Jun 11, 7:01 PM
EricWF committed rG0e9b1d2a20c5: Move libc++ specific tests for std::function out of the std directory (authored by EricWF).
Move libc++ specific tests for std::function out of the std directory
Tue, Jun 11, 3:59 PM
EricWF committed rL363111: Move libc++ specific tests for std::function out of the std directory.
Move libc++ specific tests for std::function out of the std directory
Tue, Jun 11, 3:56 PM
EricWF committed rG4959542657ba: Add documentation and tests for Clangs C++11 extensions in C++03. (authored by EricWF).
Add documentation and tests for Clangs C++11 extensions in C++03.
Tue, Jun 11, 3:51 PM
EricWF committed rL363110: Add documentation and tests for Clangs C++11 extensions in C++03..
Add documentation and tests for Clangs C++11 extensions in C++03.
Tue, Jun 11, 3:50 PM
EricWF committed rG5d6626c7582c: Check in test that demonstrates ABI break for std::function. (authored by EricWF).
Check in test that demonstrates ABI break for std::function.
Tue, Jun 11, 11:39 AM
EricWF committed rL363092: Check in test that demonstrates ABI break for std::function..
Check in test that demonstrates ABI break for std::function.
Tue, Jun 11, 11:39 AM
EricWF created D63154: Make GCC in C++03 Unsupported.
Tue, Jun 11, 11:15 AM · Restricted Project

Mon, Jun 10

EricWF added inline comments to D44865: [libc++] Implement P0608R3 - A sane variant converting constructor.
Mon, Jun 10, 8:20 PM · Restricted Project

Sun, Jun 9

EricWF added inline comments to D61878: Change how containers are compared .
Sun, Jun 9, 12:12 AM

Sat, Jun 8

EricWF added inline comments to D63053: Add nullptr output operator overload (2221).
Sat, Jun 8, 11:44 PM

Fri, Jun 7

EricWF committed rG99dfd7084d62: update debugging docs to be less out of date (authored by EricWF).
update debugging docs to be less out of date
Fri, Jun 7, 9:57 PM
EricWF committed rL362866: update debugging docs to be less out of date.
update debugging docs to be less out of date
Fri, Jun 7, 9:56 PM
EricWF committed rGd63dd874ecbd: Substantially reduce instantiations and debug size of std::function (authored by EricWF).
Substantially reduce instantiations and debug size of std::function
Fri, Jun 7, 6:30 PM
EricWF committed rL362865: Substantially reduce instantiations and debug size of std::function.
Substantially reduce instantiations and debug size of std::function
Fri, Jun 7, 6:30 PM
EricWF committed rGcdff3806811d: Fix some incorrect std::function tests (authored by EricWF).
Fix some incorrect std::function tests
Fri, Jun 7, 5:45 PM
EricWF committed rL362861: Fix some incorrect std::function tests.
Fix some incorrect std::function tests
Fri, Jun 7, 5:44 PM

Wed, May 29

EricWF accepted D62618: [libcxx] Make std::tuple<> trivially constructible.

Thanks for the link Louis. This should be safe then. .

Wed, May 29, 1:51 PM · Restricted Project, Restricted Project
EricWF added a comment to D62618: [libcxx] Make std::tuple<> trivially constructible.

Changing the triviality of a type can be ABI breaking because it will change the calling conventions the compiler uses.
We have hacks in pair to keep it non-trivial on some platforms for this reason.

Wed, May 29, 1:27 PM · Restricted Project, Restricted Project

Tue, May 28

EricWF committed rG586831b2b098: Make __has_builtin work with __builtin_LINE and friends. (authored by EricWF).
Make __has_builtin work with __builtin_LINE and friends.
Tue, May 28, 8:15 PM
EricWF committed rL361920: Make __has_builtin work with __builtin_LINE and friends..
Make __has_builtin work with __builtin_LINE and friends.
Tue, May 28, 8:15 PM
EricWF committed rC361920: Make __has_builtin work with __builtin_LINE and friends..
Make __has_builtin work with __builtin_LINE and friends.
Tue, May 28, 8:15 PM
EricWF committed rCXXA361916: Update private_typeinfo's `is_equal` implementation after r361913.
Update private_typeinfo's `is_equal` implementation after r361913
Tue, May 28, 7:59 PM
EricWF committed rG82705e7d52b4: Fix build breakage on 32-bit machines (authored by EricWF).
Fix build breakage on 32-bit machines
Tue, May 28, 7:37 PM
EricWF committed rCXX361917: Fix build breakage on 32-bit machines.
Fix build breakage on 32-bit machines
Tue, May 28, 7:35 PM