EricWF (Eric Fiselier)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 26 2014, 12:44 PM (221 w, 1 d)

Recent Activity

Wed, Sep 19

EricWF committed rCXX342609: Fix diagnostic regex in variant tests to tolerate older clang versions.
Fix diagnostic regex in variant tests to tolerate older clang versions
Wed, Sep 19, 6:18 PM
EricWF committed rL342609: Fix diagnostic regex in variant tests to tolerate older clang versions.
Fix diagnostic regex in variant tests to tolerate older clang versions
Wed, Sep 19, 6:18 PM
EricWF committed rL342560: Don't require relops on variant alternatives to all return the same.
Don't require relops on variant alternatives to all return the same
Wed, Sep 19, 10:54 AM
EricWF committed rCXX342560: Don't require relops on variant alternatives to all return the same.
Don't require relops on variant alternatives to all return the same
Wed, Sep 19, 10:54 AM

Thu, Sep 6

EricWF added a comment to D45179: [libc++] Add _LIBCPP_ENABLE_NODISCARD and _LIBCPP_NODISCARD_EXT to allow pre-C++2a [[nodiscard]].

I don't think it ever landed. I'll try to get it in this week.

Thu, Sep 6, 7:12 AM

Aug 22 2018

EricWF committed rCXX340426: Add diagnostics for min/max algorithms when a InputIterator is used..
Add diagnostics for min/max algorithms when a InputIterator is used.
Aug 22 2018, 10:48 AM
EricWF committed rL340426: Add diagnostics for min/max algorithms when a InputIterator is used..
Add diagnostics for min/max algorithms when a InputIterator is used.
Aug 22 2018, 10:48 AM
EricWF committed rCXX340406: Attempt to unbreak filesystem tests on certain linux distros..
Attempt to unbreak filesystem tests on certain linux distros.
Aug 22 2018, 6:30 AM
EricWF committed rL340406: Attempt to unbreak filesystem tests on certain linux distros..
Attempt to unbreak filesystem tests on certain linux distros.
Aug 22 2018, 6:30 AM

Aug 10 2018

EricWF added a comment to D50549: [libcxx] [test] Repair thread unsafety in thread tests.

I was hoping my comment would summon them magically. I'll figure it out shortly.

Aug 10 2018, 8:38 PM

Aug 9 2018

EricWF added a comment to D50549: [libcxx] [test] Repair thread unsafety in thread tests.

We should add some TSAN folks to this review, since I think these are also TSAN false negatives; perhaps correctly, perhaps not.

Aug 9 2018, 10:26 PM

Aug 7 2018

EricWF accepted D50420: [libcxx] [test] Add missing <stdexcept> to several tests..
Aug 7 2018, 5:12 PM
EricWF accepted D50421: [libcxx] [test] Remove assertion that <bitset> includes <cstddef> and <stdexcept>..

This looks fine to me.

Aug 7 2018, 5:08 PM

Aug 3 2018

EricWF added a comment to D50205: [libc++] Add availability markup for aligned new/delete.

How does this work when a user provides their own definitions? Does the attribute from the declaration still produce a warning? If so, then I think an in-compiler approach is better.

Aug 3 2018, 8:47 PM
EricWF added a comment to D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable..

Hi, I'm in the process of moving cities. please take over.

Aug 3 2018, 3:45 PM

Jul 26 2018

EricWF committed rL338103: Move Filesystem namespace definition out of a clang specific ifdef block..
Move Filesystem namespace definition out of a clang specific ifdef block.
Jul 26 2018, 11:13 PM
EricWF committed rCXX338103: Move Filesystem namespace definition out of a clang specific ifdef block..
Move Filesystem namespace definition out of a clang specific ifdef block.
Jul 26 2018, 11:13 PM
EricWF committed rCXX338096: Add libc++fs to the test deps, and not to the target 'cxx'..
Add libc++fs to the test deps, and not to the target 'cxx'.
Jul 26 2018, 8:48 PM
EricWF committed rL338096: Add libc++fs to the test deps, and not to the target 'cxx'..
Add libc++fs to the test deps, and not to the target 'cxx'.
Jul 26 2018, 8:48 PM
EricWF committed rCXX338095: Attempt to unbreak *all the bots*.
Attempt to unbreak *all the bots*
Jul 26 2018, 8:43 PM
EricWF committed rL338095: Attempt to unbreak *all the bots*.
Attempt to unbreak *all the bots*
Jul 26 2018, 8:43 PM
EricWF committed rL338094: Correctly mark the Filesystem status as complete..
Correctly mark the Filesystem status as complete.
Jul 26 2018, 8:16 PM
EricWF committed rCXX338094: Correctly mark the Filesystem status as complete..
Correctly mark the Filesystem status as complete.
Jul 26 2018, 8:16 PM
EricWF committed rCXX338093: Implement <filesystem>.
Implement <filesystem>
Jul 26 2018, 8:11 PM
EricWF committed rL338093: Implement <filesystem>.
Implement <filesystem>
Jul 26 2018, 8:10 PM
EricWF accepted D49240: [libc++] Introduce _LIBCPP_HIDE_FROM_ABI to replace _LIBCPP_INLINE_VISIBILITY.

LGTM. Assuming this doesn't break the ABI list checks.

Jul 26 2018, 2:47 PM

Jul 25 2018

EricWF committed rCXX338005: Copy LLVM CMake configuration for CMake Policy CMP0068.
Copy LLVM CMake configuration for CMake Policy CMP0068
Jul 25 2018, 10:08 PM
EricWF committed rL338005: Copy LLVM CMake configuration for CMake Policy CMP0068.
Copy LLVM CMake configuration for CMake Policy CMP0068
Jul 25 2018, 10:08 PM
EricWF accepted D49834: [CMake] Don't generate linker script only when shared library isn't statically linked.
Jul 25 2018, 9:59 PM
EricWF committed rL338002: Be more consistent about which bool value means an error occurred.
Be more consistent about which bool value means an error occurred
Jul 25 2018, 9:02 PM
EricWF committed rCXX338002: Be more consistent about which bool value means an error occurred.
Be more consistent about which bool value means an error occurred
Jul 25 2018, 9:02 PM
EricWF committed rL338001: Cleanup the last_write_time internals.
Cleanup the last_write_time internals
Jul 25 2018, 8:57 PM
EricWF committed rCXX338001: Cleanup the last_write_time internals.
Cleanup the last_write_time internals
Jul 25 2018, 8:57 PM
EricWF committed rCXX338000: Correct comment about stat truncating st_mtimespec to seconds.
Correct comment about stat truncating st_mtimespec to seconds
Jul 25 2018, 8:42 PM
EricWF committed rL338000: Correct comment about stat truncating st_mtimespec to seconds.
Correct comment about stat truncating st_mtimespec to seconds
Jul 25 2018, 8:42 PM
EricWF committed rCXX337999: Fix attribute placement WRT extern C.
Fix attribute placement WRT extern C
Jul 25 2018, 8:37 PM
EricWF committed rL337999: Fix attribute placement WRT extern C.
Fix attribute placement WRT extern C
Jul 25 2018, 8:36 PM
EricWF committed rCXX337998: Workaround OS X 10.11 behavior where stat truncates st_mtimespec to seconds..
Workaround OS X 10.11 behavior where stat truncates st_mtimespec to seconds.
Jul 25 2018, 8:29 PM
EricWF committed rL337998: Workaround OS X 10.11 behavior where stat truncates st_mtimespec to seconds..
Workaround OS X 10.11 behavior where stat truncates st_mtimespec to seconds.
Jul 25 2018, 8:29 PM
EricWF committed rCXX337991: Add print statements to help debugging.
Add print statements to help debugging
Jul 25 2018, 6:11 PM
EricWF committed rL337991: Add print statements to help debugging.
Add print statements to help debugging
Jul 25 2018, 6:11 PM
EricWF committed rL337990: [libc++] Add hack to allow ubsan to work w/o compiler-rt (__muloti4 is….
[libc++] Add hack to allow ubsan to work w/o compiler-rt (__muloti4 is…
Jul 25 2018, 5:35 PM
EricWF committed rCXX337990: [libc++] Add hack to allow ubsan to work w/o compiler-rt (__muloti4 is….
[libc++] Add hack to allow ubsan to work w/o compiler-rt (__muloti4 is…
Jul 25 2018, 5:35 PM
EricWF closed D49828: [libc++] Add hack to allow ubsan to work w/o compiler-rt (__muloti4 is undefined).
Jul 25 2018, 5:35 PM
EricWF updated the summary of D49828: [libc++] Add hack to allow ubsan to work w/o compiler-rt (__muloti4 is undefined).
Jul 25 2018, 5:00 PM
EricWF created D49828: [libc++] Add hack to allow ubsan to work w/o compiler-rt (__muloti4 is undefined).
Jul 25 2018, 5:00 PM
EricWF abandoned D49827: [libc++] Add hack to allow ubsan to work w/o compiler-rt (__muloti4 is undefined).
Jul 25 2018, 4:56 PM
EricWF created D49827: [libc++] Add hack to allow ubsan to work w/o compiler-rt (__muloti4 is undefined).
Jul 25 2018, 4:56 PM
EricWF committed rCXX337976: Work around GCC bug in constexpr function.
Work around GCC bug in constexpr function
Jul 25 2018, 3:22 PM
EricWF committed rL337976: Work around GCC bug in constexpr function.
Work around GCC bug in constexpr function
Jul 25 2018, 3:22 PM
EricWF committed rL337974: Fix GCC build in C++14 w/o c++14 constexpr.
Fix GCC build in C++14 w/o c++14 constexpr
Jul 25 2018, 3:08 PM
EricWF committed rCXX337974: Fix GCC build in C++14 w/o c++14 constexpr.
Fix GCC build in C++14 w/o c++14 constexpr
Jul 25 2018, 3:07 PM
EricWF committed rL337971: Remove test which shouldn't have been committed.
Remove test which shouldn't have been committed
Jul 25 2018, 2:59 PM
EricWF committed rCXX337971: Remove test which shouldn't have been committed.
Remove test which shouldn't have been committed
Jul 25 2018, 2:58 PM
EricWF committed rL337970: Fix failing test under C++14.
Fix failing test under C++14
Jul 25 2018, 2:54 PM
EricWF committed rCXX337970: Fix failing test under C++14.
Fix failing test under C++14
Jul 25 2018, 2:54 PM
EricWF committed rL337962: Make <experimental/filesystem> compile with gcc 4.8.5.
Make <experimental/filesystem> compile with gcc 4.8.5
Jul 25 2018, 2:02 PM
EricWF committed rCXX337962: Make <experimental/filesystem> compile with gcc 4.8.5.
Make <experimental/filesystem> compile with gcc 4.8.5
Jul 25 2018, 2:02 PM
EricWF closed D49813: [libc++] Make <experimental/filesystem> compile with gcc 4.8.5.

r337962.

Jul 25 2018, 2:02 PM
EricWF committed rL337960: [libc++] Use __int128_t to represent file_time_type..
[libc++] Use __int128_t to represent file_time_type.
Jul 25 2018, 1:52 PM
EricWF committed rCXX337960: [libc++] Use __int128_t to represent file_time_type..
[libc++] Use __int128_t to represent file_time_type.
Jul 25 2018, 1:52 PM
EricWF closed D49774: [libc++] Use __int128_t to represent file_time_type..
Jul 25 2018, 1:52 PM
EricWF accepted D49774: [libc++] Use __int128_t to represent file_time_type..

I'm going to go ahead and commit this now. We can address concerns about the future C++20 spec in follow up commits.

Jul 25 2018, 1:48 PM
EricWF updated the diff for D49774: [libc++] Use __int128_t to represent file_time_type..

Update with misc cleanups.

Jul 25 2018, 1:36 PM
EricWF accepted D49813: [libc++] Make <experimental/filesystem> compile with gcc 4.8.5.

Urg. That's an old compiler. But this looks OK to me.

Jul 25 2018, 1:35 PM
EricWF added a comment to D49774: [libc++] Use __int128_t to represent file_time_type..

Another problem (that Eric and I discussed last night) is that filesystem is part of C++17, and file_clock is C++20. So we need a solution for C++17 as well.

It seems like we need to fix C++20 to allow that to be a typedef to a type in std::filesystem or that will be ABI breaking for MSVC++. IMO we should fix the spec to allow that rather than make libc++ jump through insane hoops.

We could also just provide file_clock "early" in C++17. Strictly speaking that may make our implementation non-conforming, but IDK how big of a deal this would be?

Sure, libc++ could do that. But because msvc++ and libstdc++ have already shipped this thing I think the spec will have to change.

No real user cares about the associated namespaces of a clock anyway.

Jul 25 2018, 1:01 PM
EricWF committed rCXXA337906: Fix dangling reference in test.
Fix dangling reference in test
Jul 25 2018, 4:20 AM
EricWF committed rL337906: Fix dangling reference in test.
Fix dangling reference in test
Jul 25 2018, 4:19 AM
EricWF committed rL337905: Fix diagnostic test to tolerate Clang diagnosing it as well..
Fix diagnostic test to tolerate Clang diagnosing it as well.
Jul 25 2018, 4:16 AM
EricWF committed rCXX337905: Fix diagnostic test to tolerate Clang diagnosing it as well..
Fix diagnostic test to tolerate Clang diagnosing it as well.
Jul 25 2018, 4:16 AM
EricWF accepted D49782: [libcxx] [windows] Fix warning about comparing ints of different signs.

LGTM.

Jul 25 2018, 3:43 AM
EricWF committed rCXX337900: Fix another typo in the FileTimeType docs.
Fix another typo in the FileTimeType docs
Jul 25 2018, 3:22 AM
EricWF committed rL337900: Fix another typo in the FileTimeType docs.
Fix another typo in the FileTimeType docs
Jul 25 2018, 3:22 AM
EricWF committed rCXX337897: Fix typos, spelling, and grammar in the FileTimeType design docs..
Fix typos, spelling, and grammar in the FileTimeType design docs.
Jul 25 2018, 3:17 AM
EricWF committed rL337897: Fix typos, spelling, and grammar in the FileTimeType design docs..
Fix typos, spelling, and grammar in the FileTimeType design docs.
Jul 25 2018, 3:17 AM

Jul 24 2018

EricWF added a comment to D49774: [libc++] Use __int128_t to represent file_time_type..

I haven't reviewed this closely, but you might want to look at http://wg21.link/P0355, where we added a file_clock and file_time types.

Jul 24 2018, 9:59 PM
EricWF committed rCXX337888: Fix bugs in create_directory implementation..
Fix bugs in create_directory implementation.
Jul 24 2018, 9:47 PM
EricWF committed rL337888: Fix bugs in create_directory implementation..
Fix bugs in create_directory implementation.
Jul 24 2018, 9:47 PM
EricWF committed rCXX337886: Fix missing includes in format_string.hpp helper.
Fix missing includes in format_string.hpp helper
Jul 24 2018, 9:22 PM
EricWF committed rL337886: Fix missing includes in format_string.hpp helper.
Fix missing includes in format_string.hpp helper
Jul 24 2018, 9:22 PM
EricWF accepted D49773: Add new file test/support/test_comparisons.h.

Otherwise, I'm quite happy with this patch.

Jul 24 2018, 8:48 PM
EricWF committed rCXX337884: Make <experimental/filesystem> explicitly require C++11..
Make <experimental/filesystem> explicitly require C++11.
Jul 24 2018, 8:42 PM
EricWF committed rL337884: Make <experimental/filesystem> explicitly require C++11..
Make <experimental/filesystem> explicitly require C++11.
Jul 24 2018, 8:42 PM
EricWF committed rL337883: Ensure path::iterator and PathParser share the same enumeration values..
Ensure path::iterator and PathParser share the same enumeration values.
Jul 24 2018, 8:32 PM
EricWF committed rCXX337883: Ensure path::iterator and PathParser share the same enumeration values..
Ensure path::iterator and PathParser share the same enumeration values.
Jul 24 2018, 8:32 PM
EricWF added a comment to D49774: [libc++] Use __int128_t to represent file_time_type..

This is the final change I need to land before adding <experimental/filesystem>, so I don't plan to let this review linger long.

Jul 24 2018, 8:15 PM
EricWF added a comment to D49773: Add new file test/support/test_comparisons.h.

Some of this stuff is marked constexpr despite it requiring C++14 constexpr semantics. Can they be non-constexpr in C++11 and still function? Or should the header explicitly require C++14 to be included?

Jul 24 2018, 8:04 PM
EricWF created D49774: [libc++] Use __int128_t to represent file_time_type..
Jul 24 2018, 8:00 PM
EricWF committed rCXX337880: Add design docs for upcoming file_time_type change..
Add design docs for upcoming file_time_type change.
Jul 24 2018, 7:54 PM
EricWF committed rL337880: Add design docs for upcoming file_time_type change..
Add design docs for upcoming file_time_type change.
Jul 24 2018, 7:54 PM
EricWF committed rCXX337817: Fix use of incorrect _LIBCXX macro (should be _LIBCPP)..
Fix use of incorrect _LIBCXX macro (should be _LIBCPP).
Jul 24 2018, 2:15 AM
EricWF committed rL337817: Fix use of incorrect _LIBCXX macro (should be _LIBCPP)..
Fix use of incorrect _LIBCXX macro (should be _LIBCPP).
Jul 24 2018, 2:15 AM

Jul 23 2018

EricWF committed rL337768: Handle DT_UNKNOWN correctly during directory iteration..
Handle DT_UNKNOWN correctly during directory iteration.
Jul 23 2018, 3:59 PM
EricWF committed rCXX337768: Handle DT_UNKNOWN correctly during directory iteration..
Handle DT_UNKNOWN correctly during directory iteration.
Jul 23 2018, 3:59 PM
EricWF committed rL337765: Recommit "Use possibly cached directory entry values when performing recursive….
Recommit "Use possibly cached directory entry values when performing recursive…
Jul 23 2018, 3:41 PM
EricWF committed rCXX337765: Recommit "Use possibly cached directory entry values when performing recursive….
Recommit "Use possibly cached directory entry values when performing recursive…
Jul 23 2018, 3:40 PM
EricWF committed rL337764: Fix accidentally removed test..
Fix accidentally removed test.
Jul 23 2018, 3:40 PM
EricWF committed rCXX337764: Fix accidentally removed test..
Fix accidentally removed test.
Jul 23 2018, 3:40 PM
EricWF added a reviewer for D49067: Stop wrapping __has_include in another macro: mclow.lists.

Where are the special lexing rules specified?

Jul 23 2018, 3:09 PM
EricWF committed rCXX337749: Revert "Use possibly cached directory entry values when performing recursive….
Revert "Use possibly cached directory entry values when performing recursive…
Jul 23 2018, 2:52 PM