EricWF (Eric Fiselier)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 26 2014, 12:44 PM (177 w, 3 d)

Recent Activity

Today

EricWF added a comment to D35470: [libcxx] Implement std::to_address for C++20.

Initially this LGTM. I'll take another pass in the morning.

Sun, Nov 19, 5:59 PM
EricWF updated the diff for D40218: [Clang] Add __builtin_launder.
  • Fix argument initialization.
  • Make constexpr.
Sun, Nov 19, 2:24 PM
EricWF added inline comments to D40218: [Clang] Add __builtin_launder.
Sun, Nov 19, 2:12 PM
EricWF committed rL318625: Attempt to fix template depth test failures on older Clang versions.
Attempt to fix template depth test failures on older Clang versions
Sun, Nov 19, 1:46 AM

Yesterday

EricWF committed rL318622: Fix min/max usage in variant.
Fix min/max usage in variant
Sat, Nov 18, 8:57 PM
EricWF committed rL318621: [libc++] Shrink variant's index type when possible.
[libc++] Shrink variant's index type when possible
Sat, Nov 18, 8:19 PM
EricWF closed D40210: [libc++] Shrink variant's index type when possible.
Sat, Nov 18, 8:19 PM
EricWF committed rL318618: Fix nodiscard test when modules are enabled.
Fix nodiscard test when modules are enabled
Sat, Nov 18, 7:52 PM
EricWF updated the diff for D40210: [libc++] Shrink variant's index type when possible.
  • Address inline comments.
Sat, Nov 18, 7:48 PM
EricWF added inline comments to D40210: [libc++] Shrink variant's index type when possible.
Sat, Nov 18, 7:47 PM
EricWF committed rL318607: [LIT] Fix testing out-of-tree Clang builds.
[LIT] Fix testing out-of-tree Clang builds
Sat, Nov 18, 4:01 PM
EricWF closed D40217: [LIT] Fix testing out-of-tree Clang builds.
Sat, Nov 18, 4:00 PM
EricWF accepted D40217: [LIT] Fix testing out-of-tree Clang builds.

Accepting for post-commit review. I don't want to be carrying this patch locally.

Sat, Nov 18, 3:59 PM
EricWF added a comment to D40144: Implement `std::launder`.

I've made an attempt to add __builtin_launder to clang in D40218.

Sat, Nov 18, 3:56 PM
EricWF created D40219: [CMake] Add LLVM_ENABLE_IDE option to better process sources for IDE's.
Sat, Nov 18, 3:55 PM
EricWF committed rL318606: Default most libc++ builders to the latest C++ dialect.
Default most libc++ builders to the latest C++ dialect
Sat, Nov 18, 3:24 PM
EricWF committed rL318604: Add libc++ C++2a buildbot.
Add libc++ C++2a buildbot
Sat, Nov 18, 3:18 PM
EricWF updated the diff for D40217: [LIT] Fix testing out-of-tree Clang builds.
Sat, Nov 18, 3:12 PM
EricWF updated the diff for D40218: [Clang] Add __builtin_launder.
  • Remove incorrect FIXME comment.
Sat, Nov 18, 3:05 PM
EricWF created D40218: [Clang] Add __builtin_launder.
Sat, Nov 18, 3:03 PM
EricWF committed rL318602: Fix use of config.h in public headers..
Fix use of config.h in public headers.
Sat, Nov 18, 2:42 PM
EricWF created D40217: [LIT] Fix testing out-of-tree Clang builds.
Sat, Nov 18, 2:24 PM
EricWF added inline comments to D39747: [globalisel][tablegen] Generate rule coverage and use it to identify untested rules.
Sat, Nov 18, 1:05 PM
EricWF created D40210: [libc++] Shrink variant's index type when possible.
Sat, Nov 18, 12:38 PM
EricWF added a comment to D40144: Implement `std::launder`.

I think we may want a __launder function that we can use internally in all dialects.

Sat, Nov 18, 12:30 PM

Tue, Nov 14

EricWF committed rL318247: Update Appveyor LLVM install link to be current and non-broken.
Update Appveyor LLVM install link to be current and non-broken
Tue, Nov 14, 5:39 PM

Tue, Nov 7

EricWF accepted D39751: [libc++] Add _LIBCPP_INLINE_VISIBILITY to __compressed_pair_elem members.
Tue, Nov 7, 10:11 PM
EricWF committed rL317611: Teach test suite about C++2a dialect flag..
Teach test suite about C++2a dialect flag.
Tue, Nov 7, 12:27 PM
EricWF committed rL317610: Change test suite to support c++17 dialect flag instead of c++1z..
Change test suite to support c++17 dialect flag instead of c++1z.
Tue, Nov 7, 12:21 PM

Mon, Nov 6

EricWF resigned from D39602: Update tuple/list/deque data formatters to work with newest libc++.
Mon, Nov 6, 6:45 PM
EricWF accepted D39221: [libcxx] [test] Alignment must be > __STDCPP_DEFAULT_NEW_ALIGNMENT__ to call aligned new.
Mon, Nov 6, 6:42 PM
EricWF accepted D38831: [libcxx] P0604, invoke_result and is_invocable.

@K-ballo I always forget. Do you have commit access?

Mon, Nov 6, 6:39 PM
EricWF added a comment to D38635: Add 'first link flags' for building tests.

Are the changes that actually use this feature going to be upstreamed as well? Or are they specific to an internal build? It's never great to introduce seemingly dead or unused code.

Mon, Nov 6, 6:33 PM
EricWF accepted D39080: [libcxx] [test] Tolerate even more [[nodiscard]] in the STL..

I think I would prefer if this patch "left an explicit trace" as to the reasons for all the (void) casts. Specifically I think a macro like TEST_IGNORE_DISCARD <expr> might be nice.

Mon, Nov 6, 6:28 PM
EricWF accepted D39537: Rename identifiers named `__output`.

LGTM minus inline comments.

Mon, Nov 6, 6:25 PM
EricWF accepted D39608: [Reland] [libc++] Don't alias quick_exit if __ANDROID_API__ < 21.

LGTM.

Mon, Nov 6, 6:24 PM

Fri, Nov 3

EricWF requested changes to D35472: Implement P0463R1: "Endian just Endian".
Fri, Nov 3, 12:41 PM

Mon, Oct 30

EricWF committed rL316941: Implement LWG 3013 - some filesystem members should not be noexcept..
Implement LWG 3013 - some filesystem members should not be noexcept.
Mon, Oct 30, 12:00 PM
EricWF committed rL316939: Fix PR35078 - recursive directory iterator's increment method throws….
Fix PR35078 - recursive directory iterator's increment method throws…
Mon, Oct 30, 11:44 AM
EricWF added a comment to D39405: std::set_union accesses values after move..

We should backport this, right @mclow.lists?

Mon, Oct 30, 11:04 AM

Oct 17 2017

EricWF accepted D39033: [libcxx] [test] Tolerate [[nodiscard]] on STL functions in libcxx tests.
Oct 17 2017, 7:30 PM
EricWF committed rL316021: Refactor std::list node allocation logic..
Refactor std::list node allocation logic.
Oct 17 2017, 12:12 PM
EricWF committed rL316009: fix shadowing warnings in new tests, try 2.
fix shadowing warnings in new tests, try 2
Oct 17 2017, 9:07 AM
EricWF committed rL315997: fix shadowing warnings in new tests.
fix shadowing warnings in new tests
Oct 17 2017, 6:46 AM
EricWF committed rL315995: Refactor _LIBCPP_<LITTLE|BIG>_ENDIAN.
Refactor _LIBCPP_<LITTLE|BIG>_ENDIAN
Oct 17 2017, 6:16 AM
EricWF committed rL315994: [libc++] Fix PR34898 - vector iterator constructors and assign method perform….
[libc++] Fix PR34898 - vector iterator constructors and assign method perform…
Oct 17 2017, 6:03 AM
EricWF closed D38757: [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back. by committing rL315994: [libc++] Fix PR34898 - vector iterator constructors and assign method perform….
Oct 17 2017, 6:03 AM
EricWF updated the diff for D38757: [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back..
  • Update whitespace.
Oct 17 2017, 6:01 AM
EricWF accepted D38757: [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back..
In D38757#897536, @dlj wrote:

Hmm, looking more at this change... while it does make the behaviour consistent for Forward and Input iterators, I think it's just making them both do the wrong thing.

Specifically, based on this:

"... i and j denote iterators satisfying input iterator requirements and refer to elements implicitly convertible to value_­type..."

https://timsong-cpp.github.io/cppwp/n4659/container.requirements#sequence.reqmts-3

So, for example, in test_emplacable_concept, the vector constructor should be diagnosed, because there is no way to *implicitly* convert from the dereferenced iterator type to the inserted type. The selected constructor is explicit. Using emplacement just omits a *second* potentially-expensive conversion: the explicit constructor behaviour (invoked through forwarding) may still be undesired.

Oct 17 2017, 5:31 AM

Oct 11 2017

EricWF added inline comments to D37784: Alternative to D35863 - Use the allocator's pointers for deallocation in `std::list`.
Oct 11 2017, 8:46 PM

Oct 10 2017

EricWF updated subscribers of D38757: [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back..
Oct 10 2017, 3:50 PM
EricWF updated the diff for D38757: [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back..
  • Add additional fixes for vector, deque, and list.
Oct 10 2017, 2:02 PM
EricWF created D38757: [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back..
Oct 10 2017, 12:39 PM

Oct 9 2017

EricWF accepted D38630: Avoid 'unused param' warnings for !_LIBCPP_HAS_CATOPEN.
Oct 9 2017, 11:46 AM

Oct 6 2017

EricWF accepted D38628: Remove unneeded typename from test.
Oct 6 2017, 9:56 AM

Oct 4 2017

EricWF committed rL314947: Fix accidental assignment inside test asserts.
Fix accidental assignment inside test asserts
Oct 4 2017, 4:23 PM

Oct 3 2017

EricWF committed rL314864: Add C++17 explicit deduction guides to std::pair..
Add C++17 explicit deduction guides to std::pair.
Oct 3 2017, 5:06 PM

Oct 2 2017

EricWF committed rL314755: Fix test suite misconfiguration on OS X.
Fix test suite misconfiguration on OS X
Oct 2 2017, 7:26 PM
EricWF committed rL314738: Remove dead ericwf-buildslave builder; move configurations to other slaves.
Remove dead ericwf-buildslave builder; move configurations to other slaves
Oct 2 2017, 4:18 PM
EricWF committed rL314735: Improve test runner output for broken configurations..
Improve test runner output for broken configurations.
Oct 2 2017, 3:54 PM

Sep 19 2017

EricWF accepted D35235: [libc++] Replace __sync_* functions with __libcpp_atomic_* functions.
Sep 19 2017, 2:54 PM

Sep 18 2017

EricWF committed rL313576: Fix failing ASAN test.
Fix failing ASAN test
Sep 18 2017, 3:02 PM
EricWF added a comment to D37997: [libcxx / lit] Make libcxx work correctly with the new testing workflow.

LGTM.

Sep 18 2017, 2:22 PM

Sep 17 2017

EricWF committed rL313502: Fix two failing -verify tests to tolerate old and new clang versions.
Fix two failing -verify tests to tolerate old and new clang versions
Sep 17 2017, 2:52 PM
EricWF closed D37830: [libcxx] ABI: Fix for undefined "___cxa_deleted_virtual" symbol in MacOSX.

Committed as r313500.

Sep 17 2017, 2:02 PM
EricWF committed rL313501: Update changelog revision.
Update changelog revision
Sep 17 2017, 2:02 PM
EricWF committed rL313500: ABI: Fix for undefined "___cxa_deleted_virtual" symbol in MacOSX.
ABI: Fix for undefined "___cxa_deleted_virtual" symbol in MacOSX
Sep 17 2017, 2:01 PM
EricWF committed rL313499: Fix failing -verify tests due to change in Clangs static_assert message..
Fix failing -verify tests due to change in Clangs static_assert message.
Sep 17 2017, 1:58 PM

Sep 15 2017

EricWF added a comment to D36870: [libcxx] Add missing __cxa_deleted_virtual.

...but I'm still curious as to why lib/abi/x86_64-unknown-linux-gnu.abilist should want to mention __cxa_pure_virtual but not __cxa_deleted_virtual

Sep 15 2017, 12:48 AM

Sep 14 2017

EricWF updated the diff for D37035: Implement __builtin_LINE() et. al. to support source location capture..
  • Improve test.
Sep 14 2017, 7:47 PM
EricWF accepted D37830: [libcxx] ABI: Fix for undefined "___cxa_deleted_virtual" symbol in MacOSX.

LGTM minus inline comments.

Sep 14 2017, 7:45 PM
EricWF updated the diff for D37035: Implement __builtin_LINE() et. al. to support source location capture..
  • Cleanup and address the inline comments I added earlier.
Sep 14 2017, 7:20 PM
EricWF added a comment to D37538: [libc++] Remove problematic ADL in container implementations..

@dlj I went ahead and committed the fixes to std::allocator_traits in r313324, because I think we agree those are bugs, and I didn't want this discussion to hold up that fix. I hope you don't mind.

Sep 14 2017, 5:36 PM
EricWF committed rL313324: Fix accidental ADL in std::allocator_traits meta-programming..
Fix accidental ADL in std::allocator_traits meta-programming.
Sep 14 2017, 5:33 PM
EricWF added inline comments to D37538: [libc++] Remove problematic ADL in container implementations..
Sep 14 2017, 5:02 PM
EricWF committed rL313308: Fix ASAN build with older compiler-rt versions..
Fix ASAN build with older compiler-rt versions.
Sep 14 2017, 3:39 PM
EricWF committed rL313306: [ASAN] Revert r313303 - Add macro denoting availability of new….
[ASAN] Revert r313303 - Add macro denoting availability of new…
Sep 14 2017, 3:33 PM
EricWF added a comment to D37871: [ASAN] Add macro denoting availability of new `__asan_handle_no_return()` function..

This function was added to the header recently, but it has been provided by ASan runtime library since the beginning. Why not simply declare it in libc++abi?

Sep 14 2017, 3:26 PM
EricWF committed rL313304: [libc++abi] Fix ASAN build with older compiler-rt versions..
[libc++abi] Fix ASAN build with older compiler-rt versions.
Sep 14 2017, 3:21 PM
EricWF closed D37872: [libc++abi] Fix ASAN build with older compiler-rt versions..
Sep 14 2017, 3:20 PM
EricWF committed rL313303: [ASAN] Add macro denoting availability of new `__asan_handle_no_return()`….
[ASAN] Add macro denoting availability of new `__asan_handle_no_return()`…
Sep 14 2017, 3:20 PM
EricWF closed D37871: [ASAN] Add macro denoting availability of new `__asan_handle_no_return()` function..
Sep 14 2017, 3:20 PM
EricWF updated the summary of D37871: [ASAN] Add macro denoting availability of new `__asan_handle_no_return()` function..
Sep 14 2017, 3:15 PM
EricWF created D37872: [libc++abi] Fix ASAN build with older compiler-rt versions..
Sep 14 2017, 3:10 PM
EricWF created D37871: [ASAN] Add macro denoting availability of new `__asan_handle_no_return()` function..
Sep 14 2017, 3:05 PM
EricWF accepted D28212: typeinfo: provide a partial implementation for Win32.

Woops. didn't mean to reject.

Sep 14 2017, 2:23 PM
EricWF requested changes to D28212: typeinfo: provide a partial implementation for Win32.
  • List Item
Sep 14 2017, 2:23 PM
EricWF added inline comments to D37035: Implement __builtin_LINE() et. al. to support source location capture..
Sep 14 2017, 3:10 AM

Sep 13 2017

EricWF updated the diff for D37035: Implement __builtin_LINE() et. al. to support source location capture..
  • Remove accidentally committed test files.
  • Attempt to remove incidental whitespace changes.
Sep 13 2017, 9:07 PM
EricWF added a comment to D37631: [libFuzzer] Support using libc++.
In D37631#865602, @kcc wrote:

So, how about linking a full private version of libc++?
Is that even possible?

I think it's possible but it won't be pretty. It's also complicated by the fact that libFuzzer is built as static library. What we would have to do is to build custom libc++ using a custom namespace, then build libFuzzer against that library, and finally combine the two static libraries together similarly to what libc++ is doing when merging libc++abi (https://github.com/llvm-mirror/libcxx/blob/master/lib/CMakeLists.txt#L268). I can give it a try if you're fine with that solution.

Sep 13 2017, 8:56 PM
EricWF added inline comments to D37035: Implement __builtin_LINE() et. al. to support source location capture..
Sep 13 2017, 8:51 PM
EricWF added inline comments to D37035: Implement __builtin_LINE() et. al. to support source location capture..
Sep 13 2017, 8:40 PM
EricWF updated the diff for D37035: Implement __builtin_LINE() et. al. to support source location capture..
  • Reimplement without rewriting the AST and instead during the substitution during constant expression evaluation and code gen.
Sep 13 2017, 8:35 PM
EricWF added a comment to D37830: [libcxx] ABI: Fix for undefined "___cxa_deleted_virtual" symbol in MacOSX.

Could you please add an entry into lib/abi/CHANGELOG.TXT, as well as a test that demonstrates the initial bug. I would put it under test/libcxx/language.support/cxa_deleted_virtual.pass.cpp.

Sep 13 2017, 3:21 PM

Sep 12 2017

EricWF requested changes to D36447: private_typeinfo: limit is_dst_type_derived_from_static_type optimization.

Could you please include the tests for this change in this review?

Sep 12 2017, 6:58 PM
EricWF requested changes to D36446: private_typeinfo: propagate static flags in vmi search_above_dst method.

Could you please include the tests for this change in this review?

Sep 12 2017, 6:57 PM
EricWF requested changes to D36449: Add dynamic_cast regression tests from PR33425, PR33439, and PR33487.

Can these tests be checked in with their respective fixes, so both the test and the fix can be committed atomically?

Sep 12 2017, 6:56 PM
EricWF added inline comments to D37538: [libc++] Remove problematic ADL in container implementations..
Sep 12 2017, 6:53 PM
EricWF created D37784: Alternative to D35863 - Use the allocator's pointers for deallocation in `std::list`.
Sep 12 2017, 6:25 PM
EricWF accepted D36719: [libc++] Add site config option for ABI macros.

There should probably be some documentation for this, but I couldn't think of the right place; the Using libc++ documentation only mentions the actual configuration macros, not their corresponding cmake defines. Any suggestions?

Sep 12 2017, 5:44 PM