- User Since
- Jun 26 2014, 12:44 PM (221 w, 1 d)
Wed, Sep 19
Thu, Sep 6
I don't think it ever landed. I'll try to get it in this week.
Aug 22 2018
Aug 10 2018
I was hoping my comment would summon them magically. I'll figure it out shortly.
Aug 9 2018
We should add some TSAN folks to this review, since I think these are also TSAN false negatives; perhaps correctly, perhaps not.
Aug 7 2018
This looks fine to me.
Aug 3 2018
How does this work when a user provides their own definitions? Does the attribute from the declaration still produce a warning? If so, then I think an in-compiler approach is better.
Hi, I'm in the process of moving cities. please take over.
Jul 26 2018
LGTM. Assuming this doesn't break the ABI list checks.
Jul 25 2018
I'm going to go ahead and commit this now. We can address concerns about the future C++20 spec in follow up commits.
Update with misc cleanups.
Urg. That's an old compiler. But this looks OK to me.
Jul 24 2018
Otherwise, I'm quite happy with this patch.
This is the final change I need to land before adding <experimental/filesystem>, so I don't plan to let this review linger long.
Some of this stuff is marked constexpr despite it requiring C++14 constexpr semantics. Can they be non-constexpr in C++11 and still function? Or should the header explicitly require C++14 to be included?
Jul 23 2018
Where are the special lexing rules specified?