- User Since
- Jun 26 2014, 12:44 PM (242 w, 6 d)
These aren't definitions. They're declarations. And the warning or broken. We should turn it off not fix it
I'm fine with this. But it's a bogus warning
but this isn't redundant... as evidenced by the fact there is green in this patch .
Thu, Feb 14
combining these together in LIBCXX_LIBRARIES and LIBCXX_INTERFACE_LIBRARIES can introduce unnecessary dependencies.
Wed, Feb 13
hanks for looping me in. I'm working on a similar problem but with libstdc++.
Mon, Feb 11
Sun, Feb 10
LGTM other than inline nits.
MSVC on godbolt provides a constexpr __builtin_strlen. https://godbolt.org/z/n_3vRY
MSVC is wrong and this code is well formed. Please file a bug with MSVC.
The wording is somewhere in [expr.const].
What version of MSVC are you trying to use?
Address review comments.
Sat, Feb 9
Mon, Feb 4
Sun, Feb 3
This feels like a fix at the wrong level.
Sat, Feb 2
In C++20 we should declare destroying_delete_t, even if __cpp_impl_destroying_delete isn't defined.
But in that case should be define __cpp_lib_destroying_delete? The library has the type, but users
can't actually perform destroying delete.
Fri, Feb 1
Tue, Jan 29
Mon, Jan 28
Please add __allocator to nasty_macros.hpp (https://github.com/llvm-mirror/libcxx/blob/master/test/support/nasty_macros.hpp#L57)
This doesn't address cases where any of the arguments are *cv void*. I'll take a stab at a fix tomorrow since I wrote all this metaprogramming.
Sun, Jan 27
Wed, Jan 23
- Add or correct tests as requested.
- Fix code gen for initializers of reference types to correctly evaluate the initializer as a constant expression.
Mon, Jan 21
Jan 20 2019
Does libc++ need a similar change?