Page MenuHomePhabricator

EricWF (Eric Fiselier)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 26 2014, 12:44 PM (277 w, 16 h)

Recent Activity

Mon, Oct 14

EricWF accepted D68947: [libc++][test] Add license headers to test/support/archetypes.*.
Mon, Oct 14, 10:43 AM · Restricted Project

Thu, Oct 10

EricWF added a comment to D68480: Implementation of C++20's P1135R6 for libcxx.

Are the lock free algorithms used by this implementation published somewhere? That would give me a lot more confidence in their correctness.

Thu, Oct 10, 6:08 PM
EricWF added a comment to D68480: Implementation of C++20's P1135R6 for libcxx.

Please see the Adding a new header section of NOTE.txt (https://github.com/llvm-mirror/libcxx/blob/master/NOTES.TXT#L19-L29)

Thu, Oct 10, 8:12 AM
EricWF accepted D68756: [libc++][test] Change IsSmallObject's calculation for std::any's small object buffer.
Thu, Oct 10, 1:44 AM · Restricted Project

Tue, Oct 8

EricWF committed rG78153b3a9759: Optimize operator=(const basic_string&) for tail call. (authored by EricWF).
Optimize operator=(const basic_string&) for tail call.
Tue, Oct 8, 8:12 PM
EricWF committed rL374137: Optimize operator=(const basic_string&) for tail call..
Optimize operator=(const basic_string&) for tail call.
Tue, Oct 8, 8:05 PM

Fri, Oct 4

EricWF added inline comments to D68480: Implementation of C++20's P1135R6 for libcxx.
Fri, Oct 4, 11:15 PM
EricWF requested changes to D68075: Do not #error if no OS is #defined.
Fri, Oct 4, 10:05 PM · Restricted Project, Restricted Project
EricWF added a comment to D68075: Do not #error if no OS is #defined.

threading support is required to implement a conforming standard library. if we don't have it we're non-conforming.

Fri, Oct 4, 10:03 PM · Restricted Project, Restricted Project
EricWF accepted D68276: Optimize operator=(const basic_string&) for tail call..
Fri, Oct 4, 12:23 PM · Restricted Project

Thu, Oct 3

EricWF committed rG5e7e6f16d945: Attempt to remove linker workaround on the buildbots: Attempt 2 (authored by EricWF).
Attempt to remove linker workaround on the buildbots: Attempt 2
Thu, Oct 3, 12:38 PM
EricWF committed rL373653: Attempt to remove linker workaround on the buildbots: Attempt 2.
Attempt to remove linker workaround on the buildbots: Attempt 2
Thu, Oct 3, 12:37 PM
EricWF committed rGbed690e3700b: Attempt to remove linker workaround on the buildbots. (authored by EricWF).
Attempt to remove linker workaround on the buildbots.
Thu, Oct 3, 12:13 PM
EricWF committed rL373650: Attempt to remove linker workaround on the buildbots..
Attempt to remove linker workaround on the buildbots.
Thu, Oct 3, 12:13 PM
EricWF requested changes to D68269: [libc++abi] Do not define new/delete by default.
Thu, Oct 3, 11:01 AM · Restricted Project

Mon, Sep 30

EricWF committed rGc8ad8686ac07: Refactor default constructor SFINAE in pair and tuple. (authored by EricWF).
Refactor default constructor SFINAE in pair and tuple.
Mon, Sep 30, 1:55 PM
EricWF committed rL373263: Refactor default constructor SFINAE in pair and tuple..
Refactor default constructor SFINAE in pair and tuple.
Mon, Sep 30, 1:53 PM

Wed, Sep 25

EricWF committed rGaf4a29af0179: Add forward declaration of operator<< in <string_view> as required. (authored by EricWF).
Add forward declaration of operator<< in <string_view> as required.
Wed, Sep 25, 11:58 AM
EricWF committed rL372909: Add forward declaration of operator<< in <string_view> as required..
Add forward declaration of operator<< in <string_view> as required.
Wed, Sep 25, 11:58 AM
EricWF committed rGa32717750d77: add tests that debug mode catches nullptr->string_view conversions in… (authored by EricWF).
add tests that debug mode catches nullptr->string_view conversions in…
Wed, Sep 25, 11:44 AM
EricWF committed rL372907: add tests that debug mode catches nullptr->string_view conversions in….
add tests that debug mode catches nullptr->string_view conversions in…
Wed, Sep 25, 11:42 AM

Tue, Sep 24

EricWF added a comment to D67944: Implement LWG 3296.

Can you use clang-format instead of custom formatting?

Tue, Sep 24, 10:49 AM · Restricted Project
EricWF accepted D67667: Add benchmarks for string assign methods.

LGTM.

Tue, Sep 24, 10:11 AM · Restricted Project

Thu, Sep 19

EricWF added inline comments to D67052: Add reference type transformation builtins.
Thu, Sep 19, 3:08 PM · Restricted Project, Restricted Project
EricWF added inline comments to D67052: Add reference type transformation builtins.
Thu, Sep 19, 2:53 PM · Restricted Project, Restricted Project

Wed, Sep 18

EricWF requested changes to D67675: [libc++] Remove C++03 variadics in shared_ptr.

I don't see any changes to tests. are the tests already sufficient or should we enable the c+ +11 tests?

Wed, Sep 18, 10:16 AM · Restricted Project

Sep 14 2019

EricWF committed rG6bc1236d3951: Add debug check for null pointers passed to <string_view> (authored by EricWF).
Add debug check for null pointers passed to <string_view>
Sep 14 2019, 12:55 PM
EricWF committed rL371925: Add debug check for null pointers passed to <string_view>.
Add debug check for null pointers passed to <string_view>
Sep 14 2019, 12:54 PM

Sep 13 2019

EricWF added a comment to D67524: P1144 "Trivially relocatable" (3/3): optimize std::vector and std::swap for trivially relocatable types.

How were the performance benefits measured? Are they visible in the existing benchmarks?

Sep 13 2019, 9:17 PM
EricWF committed rGcb9216b908de: Fix C++03 build failures due to >> (authored by EricWF).
Fix C++03 build failures due to >>
Sep 13 2019, 1:32 PM
EricWF committed rL371894: Fix C++03 build failures due to >>.
Fix C++03 build failures due to >>
Sep 13 2019, 1:32 PM
EricWF committed rGe210c0383bef: Mark [[nodiscard]] test as unsupported with GCC 5 (authored by EricWF).
Mark [[nodiscard]] test as unsupported with GCC 5
Sep 13 2019, 12:10 PM
EricWF committed rL371886: Mark [[nodiscard]] test as unsupported with GCC 5.
Mark [[nodiscard]] test as unsupported with GCC 5
Sep 13 2019, 12:08 PM
EricWF committed rG556027085583: Fix pretty printer test with GCC (authored by EricWF).
Fix pretty printer test with GCC
Sep 13 2019, 12:05 PM
EricWF committed rL371884: Fix pretty printer test with GCC.
Fix pretty printer test with GCC
Sep 13 2019, 12:03 PM
EricWF committed rG75c9eb5ab235: Update XFAIL list for new GCC versions (authored by EricWF).
Update XFAIL list for new GCC versions
Sep 13 2019, 11:43 AM
EricWF committed rL371881: Update XFAIL list for new GCC versions.
Update XFAIL list for new GCC versions
Sep 13 2019, 11:43 AM
EricWF committed rGffe8916cf2f6: Fix various test failures with GCC (authored by EricWF).
Fix various test failures with GCC
Sep 13 2019, 11:43 AM
EricWF committed rL371880: Fix various test failures with GCC.
Fix various test failures with GCC
Sep 13 2019, 11:40 AM
EricWF committed rG7ff9a9353c24: Fix failing negative compilation test for some versions of Clang (authored by EricWF).
Fix failing negative compilation test for some versions of Clang
Sep 13 2019, 10:43 AM
EricWF committed rL371874: Fix failing negative compilation test for some versions of Clang.
Fix failing negative compilation test for some versions of Clang
Sep 13 2019, 10:42 AM
EricWF committed rG2a573784f367: Recommit r370502: Make `vector` unconditionally move elements when exceptions… (authored by EricWF).
Recommit r370502: Make `vector` unconditionally move elements when exceptions…
Sep 13 2019, 9:09 AM
EricWF committed rL371867: Recommit r370502: Make `vector` unconditionally move elements when.
Recommit r370502: Make `vector` unconditionally move elements when
Sep 13 2019, 9:08 AM
EricWF committed rG24c1ab26331a: Fix build in C++20 (authored by EricWF).
Fix build in C++20
Sep 13 2019, 8:16 AM
EricWF committed rL371863: Fix build in C++20.
Fix build in C++20
Sep 13 2019, 8:11 AM

Aug 30 2019

EricWF updated the diff for D66836: [libc++] Add `__truncating_cast` for safely casting float types to integers.

Address review comments.

Aug 30 2019, 12:12 PM · Restricted Project
EricWF committed rG2dd37a31ce14: Make `vector` unconditionally move elements when exceptions are disabled. (authored by EricWF).
Make `vector` unconditionally move elements when exceptions are disabled.
Aug 30 2019, 12:02 PM
EricWF committed rL370502: Make `vector` unconditionally move elements when exceptions are disabled..
Make `vector` unconditionally move elements when exceptions are disabled.
Aug 30 2019, 12:02 PM
EricWF closed D62228: Make `vector` unconditionally move elements when exceptions are disabled..
Aug 30 2019, 12:02 PM · Restricted Project, Restricted Project
EricWF accepted D63748: Pass std::unique_ptr, std::shared_ptr and std::weak_ptr in registers when possible..

@rsmith Please address the inline comment. Otherwise this LGTM.

Aug 30 2019, 11:17 AM · Restricted Project
EricWF accepted D64378: [libcxx] Use C11 thread API on Fuchsia.

LGTM apart from inline comments.

Aug 30 2019, 11:17 AM

Aug 29 2019

EricWF accepted D66986: [libc++] Fix directory_iterator compilation on Win32.

Thanks for the patch

Aug 29 2019, 6:44 PM · Restricted Project

Aug 28 2019

EricWF added inline comments to D66836: [libc++] Add `__truncating_cast` for safely casting float types to integers.
Aug 28 2019, 1:17 PM · Restricted Project
EricWF updated the diff for D66836: [libc++] Add `__truncating_cast` for safely casting float types to integers.

Address review comments. I think this is good to go.

Aug 28 2019, 12:25 PM · Restricted Project
EricWF added inline comments to D66836: [libc++] Add `__truncating_cast` for safely casting float types to integers.
Aug 28 2019, 12:20 PM · Restricted Project

Aug 27 2019

EricWF created D66836: [libc++] Add `__truncating_cast` for safely casting float types to integers.
Aug 27 2019, 3:24 PM · Restricted Project

Aug 23 2019

EricWF added a comment to D65667: [libcxx] Avoid destructor call for error_category singletons.

Sorry for being late to the party, I've looked at the codege of this and other approachs. what we want is a single global than initializes all of objects we need. Right now we have function local static then may may not have make guards and that's less than ideal.

In other words, we only want to pay the cost of the destructor registration once for the entire library? I think this might need a new file and is a much larger scope than what this patch is attempting. @EricWF, is this patch being subsumed into a bigger effort?

Aug 23 2019, 11:31 AM · Restricted Project
EricWF accepted D66594: libcxx: Make gen_link_script.py only print contents in --dryrun mode.
Aug 23 2019, 6:29 AM · Restricted Project

Aug 22 2019

EricWF requested changes to D65667: [libcxx] Avoid destructor call for error_category singletons.

Sorry for being late to the party, I've looked at the codege of this and other approachs. what we want is a single global than initializes all of objects we need. Right now we have function local static then may may not have make guards and that's less than ideal.

Aug 22 2019, 10:54 PM · Restricted Project

Aug 21 2019

EricWF reopened D66518: [libcxx] Only declare contents of threading API when _LIBCPP_HAS_THREAD_API_EXTERNAL is not defined..

I don't fully understand this patch. The point of always declaring the interface was to enforce that it matches exactly what we expect. I'll grant that probably wasn't working, but can you explain more about?

Aug 21 2019, 5:58 PM · Restricted Project, Restricted Project
EricWF updated the diff for D66497: [libcxx] WIP DO NOT SUBMIT -- Iterator debugging cleanup..
Aug 21 2019, 3:55 PM
EricWF accepted D66544: libcxx: Rename last two .hpp files in libcxx to .h.
Aug 21 2019, 1:33 PM · Restricted Project

Aug 20 2019

EricWF accepted D66509: libcxx: Rename .hpp files in libcxx/benchmarks to .h.
Aug 20 2019, 6:41 PM · Restricted Project
EricWF committed rG5b5929501139: Fix missing __muloti4 function with UBSAN (authored by EricWF).
Fix missing __muloti4 function with UBSAN
Aug 20 2019, 5:18 PM
EricWF committed rGa6edef35639b: Attempt to fix MSAN failures in benchmarks (authored by EricWF).
Attempt to fix MSAN failures in benchmarks
Aug 20 2019, 5:18 PM
EricWF committed rL369483: Fix missing __muloti4 function with UBSAN.
Fix missing __muloti4 function with UBSAN
Aug 20 2019, 5:18 PM
EricWF committed rL369482: Attempt to fix MSAN failures in benchmarks.
Attempt to fix MSAN failures in benchmarks
Aug 20 2019, 5:17 PM
EricWF accepted D66104: libcxx: Rename .hpp files in libcxx/test/support to .h.
Aug 20 2019, 4:58 PM · Restricted Project
EricWF created D66497: [libcxx] WIP DO NOT SUBMIT -- Iterator debugging cleanup..
Aug 20 2019, 2:31 PM
EricWF committed rGbc2f42537708: fix buildbot start script to no longer hang (authored by EricWF).
fix buildbot start script to no longer hang
Aug 20 2019, 12:09 PM
EricWF committed rL369428: fix buildbot start script to no longer hang.
fix buildbot start script to no longer hang
Aug 20 2019, 12:08 PM
EricWF committed rG1d37ec1fda91: bump lld version used by buildbots (authored by EricWF).
bump lld version used by buildbots
Aug 20 2019, 10:43 AM
EricWF committed rL369416: bump lld version used by buildbots.
bump lld version used by buildbots
Aug 20 2019, 10:42 AM

Aug 12 2019

EricWF committed rGb0945e1bd2e2: Improve codegen for deque. (authored by EricWF).
Improve codegen for deque.
Aug 12 2019, 12:51 AM
EricWF committed rL368547: Improve codegen for deque..
Improve codegen for deque.
Aug 12 2019, 12:51 AM

Aug 9 2019

EricWF added inline comments to D65339: Implement std::condition_variable via pthread_cond_clockwait() where available.
Aug 9 2019, 11:25 PM
EricWF accepted D65981: libcxxabi: Rename .hpp files to .h.

LGTM.

Aug 9 2019, 10:58 PM · Restricted Project

Aug 8 2019

EricWF accepted D65900: [libc++] Use [[nodiscard]] for lock_guard, as an extension.
Aug 8 2019, 11:56 AM · Restricted Project, Restricted Project

Aug 4 2019

EricWF added inline comments to D60097: Fix implementation of ::abs and std::abs LWG 2192..
Aug 4 2019, 6:19 PM · Restricted Project
EricWF added inline comments to D60097: Fix implementation of ::abs and std::abs LWG 2192..
Aug 4 2019, 2:02 PM · Restricted Project
EricWF committed rG278d59301446: Revert "Suppress -Wctad-maybe-unsupported on types w/o deduction guides." (authored by EricWF).
Revert "Suppress -Wctad-maybe-unsupported on types w/o deduction guides."
Aug 4 2019, 12:16 AM
EricWF committed rL367777: Revert "Suppress -Wctad-maybe-unsupported on types w/o deduction guides.".
Revert "Suppress -Wctad-maybe-unsupported on types w/o deduction guides."
Aug 4 2019, 12:16 AM

Aug 3 2019

EricWF added a comment to D65609: Add gdb pretty printers for a wide variety of libc++ data structures..

wow. This is a fantastic amount of work. Thank you. No longer will libc++ accidentally break the pretty printers!

Aug 3 2019, 7:52 PM · Restricted Project
EricWF committed rGfcd549a7d828: Suppress -Wctad-maybe-unsupported on types w/o deduction guides. (authored by EricWF).
Suppress -Wctad-maybe-unsupported on types w/o deduction guides.
Aug 3 2019, 4:55 PM
EricWF committed rL367770: Suppress -Wctad-maybe-unsupported on types w/o deduction guides..
Suppress -Wctad-maybe-unsupported on types w/o deduction guides.
Aug 3 2019, 4:54 PM
EricWF committed rG208e8a1b6623: Revert accidental change to __member_pointer_traits_imp. (authored by EricWF).
Revert accidental change to __member_pointer_traits_imp.
Aug 3 2019, 12:05 PM
EricWF committed rL367762: Revert accidental change to __member_pointer_traits_imp..
Revert accidental change to __member_pointer_traits_imp.
Aug 3 2019, 12:03 PM

Aug 2 2019

EricWF committed rG10bf563171c5: Simplify <type_traits> implementations. (authored by EricWF).
Simplify <type_traits> implementations.
Aug 2 2019, 10:03 PM
EricWF committed rL367749: Simplify <type_traits> implementations..
Simplify <type_traits> implementations.
Aug 2 2019, 10:01 PM
EricWF requested changes to D65667: [libcxx] Avoid destructor call for error_category singletons.
Aug 2 2019, 5:28 PM · Restricted Project
EricWF added a comment to D65667: [libcxx] Avoid destructor call for error_category singletons.

Or alternatively, there's an example of how to fix this in memory_resource.cpp https://github.com/llvm-mirror/libcxx/blob/master/src/experimental/memory_resource.cpp#L67-L96

Aug 2 2019, 5:28 PM · Restricted Project
EricWF added a comment to D65667: [libcxx] Avoid destructor call for error_category singletons.

I think a better fix would be to apply [[clang::no_destroy]] to the category variable definitions instead.

Aug 2 2019, 5:22 PM · Restricted Project
EricWF committed rGc4952da40109: Add benchmarks to test the cost of allocator (authored by EricWF).
Add benchmarks to test the cost of allocator
Aug 2 2019, 2:14 PM
EricWF committed rL367722: Add benchmarks to test the cost of allocator.
Add benchmarks to test the cost of allocator
Aug 2 2019, 2:14 PM

Aug 1 2019

EricWF committed rGd544d1441d98: Refactor deque to centralize handling of spare blocks. (authored by EricWF).
Refactor deque to centralize handling of spare blocks.
Aug 1 2019, 4:12 PM
EricWF committed rL367631: Refactor deque to centralize handling of spare blocks..
Refactor deque to centralize handling of spare blocks.
Aug 1 2019, 4:10 PM
EricWF committed rG8f2124b47ad5: Teach malloc_allocator how to count bytes (authored by EricWF).
Teach malloc_allocator how to count bytes
Aug 1 2019, 12:57 PM
EricWF committed rL367606: Teach malloc_allocator how to count bytes.
Teach malloc_allocator how to count bytes
Aug 1 2019, 12:52 PM
EricWF committed rG3eb5aec61f68: Change default bucket count in hash_set/hash_map. (authored by EricWF).
Change default bucket count in hash_set/hash_map.
Aug 1 2019, 12:49 PM
EricWF committed rL367605: Change default bucket count in hash_set/hash_map..
Change default bucket count in hash_set/hash_map.
Aug 1 2019, 12:47 PM