Page MenuHomePhabricator

EricWF (Eric Fiselier)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 26 2014, 12:44 PM (269 w, 2 d)

Recent Activity

Yesterday

EricWF added a comment to D65667: [libcxx] Avoid destructor call for error_category singletons.

Sorry for being late to the party, I've looked at the codege of this and other approachs. what we want is a single global than initializes all of objects we need. Right now we have function local static then may may not have make guards and that's less than ideal.

In other words, we only want to pay the cost of the destructor registration once for the entire library? I think this might need a new file and is a much larger scope than what this patch is attempting. @EricWF, is this patch being subsumed into a bigger effort?

Fri, Aug 23, 11:31 AM · Restricted Project
EricWF accepted D66594: libcxx: Make gen_link_script.py only print contents in --dryrun mode.
Fri, Aug 23, 6:29 AM · Restricted Project

Thu, Aug 22

EricWF requested changes to D65667: [libcxx] Avoid destructor call for error_category singletons.

Sorry for being late to the party, I've looked at the codege of this and other approachs. what we want is a single global than initializes all of objects we need. Right now we have function local static then may may not have make guards and that's less than ideal.

Thu, Aug 22, 10:54 PM · Restricted Project

Wed, Aug 21

EricWF reopened D66518: [libcxx] Only declare contents of threading API when _LIBCPP_HAS_THREAD_API_EXTERNAL is not defined..

I don't fully understand this patch. The point of always declaring the interface was to enforce that it matches exactly what we expect. I'll grant that probably wasn't working, but can you explain more about?

Wed, Aug 21, 5:58 PM · Restricted Project, Restricted Project
EricWF updated the diff for D66497: [libcxx] WIP DO NOT SUBMIT -- Iterator debugging cleanup..
Wed, Aug 21, 3:55 PM
EricWF accepted D66544: libcxx: Rename last two .hpp files in libcxx to .h.
Wed, Aug 21, 1:33 PM · Restricted Project

Tue, Aug 20

EricWF accepted D66509: libcxx: Rename .hpp files in libcxx/benchmarks to .h.
Tue, Aug 20, 6:41 PM · Restricted Project
EricWF committed rG5b5929501139: Fix missing __muloti4 function with UBSAN (authored by EricWF).
Fix missing __muloti4 function with UBSAN
Tue, Aug 20, 5:18 PM
EricWF committed rGa6edef35639b: Attempt to fix MSAN failures in benchmarks (authored by EricWF).
Attempt to fix MSAN failures in benchmarks
Tue, Aug 20, 5:18 PM
EricWF committed rL369483: Fix missing __muloti4 function with UBSAN.
Fix missing __muloti4 function with UBSAN
Tue, Aug 20, 5:18 PM
EricWF committed rL369482: Attempt to fix MSAN failures in benchmarks.
Attempt to fix MSAN failures in benchmarks
Tue, Aug 20, 5:17 PM
EricWF accepted D66104: libcxx: Rename .hpp files in libcxx/test/support to .h.
Tue, Aug 20, 4:58 PM · Restricted Project
EricWF created D66497: [libcxx] WIP DO NOT SUBMIT -- Iterator debugging cleanup..
Tue, Aug 20, 2:31 PM
EricWF committed rGbc2f42537708: fix buildbot start script to no longer hang (authored by EricWF).
fix buildbot start script to no longer hang
Tue, Aug 20, 12:09 PM
EricWF committed rL369428: fix buildbot start script to no longer hang.
fix buildbot start script to no longer hang
Tue, Aug 20, 12:08 PM
EricWF committed rG1d37ec1fda91: bump lld version used by buildbots (authored by EricWF).
bump lld version used by buildbots
Tue, Aug 20, 10:43 AM
EricWF committed rL369416: bump lld version used by buildbots.
bump lld version used by buildbots
Tue, Aug 20, 10:42 AM

Mon, Aug 12

EricWF committed rGb0945e1bd2e2: Improve codegen for deque. (authored by EricWF).
Improve codegen for deque.
Mon, Aug 12, 12:51 AM
EricWF committed rL368547: Improve codegen for deque..
Improve codegen for deque.
Mon, Aug 12, 12:51 AM

Fri, Aug 9

EricWF added inline comments to D65339: Implement std::condition_variable via pthread_cond_clockwait() where available.
Fri, Aug 9, 11:25 PM
EricWF accepted D65981: libcxxabi: Rename .hpp files to .h.

LGTM.

Fri, Aug 9, 10:58 PM · Restricted Project

Thu, Aug 8

EricWF accepted D65900: [libc++] Use [[nodiscard]] for lock_guard, as an extension.
Thu, Aug 8, 11:56 AM · Restricted Project, Restricted Project

Sun, Aug 4

EricWF added inline comments to D60097: Fix implementation of ::abs and std::abs LWG 2192..
Sun, Aug 4, 6:19 PM · Restricted Project
EricWF added inline comments to D60097: Fix implementation of ::abs and std::abs LWG 2192..
Sun, Aug 4, 2:02 PM · Restricted Project
EricWF committed rG278d59301446: Revert "Suppress -Wctad-maybe-unsupported on types w/o deduction guides." (authored by EricWF).
Revert "Suppress -Wctad-maybe-unsupported on types w/o deduction guides."
Sun, Aug 4, 12:16 AM
EricWF committed rL367777: Revert "Suppress -Wctad-maybe-unsupported on types w/o deduction guides.".
Revert "Suppress -Wctad-maybe-unsupported on types w/o deduction guides."
Sun, Aug 4, 12:16 AM

Sat, Aug 3

EricWF added a comment to D65609: Add gdb pretty printers for a wide variety of libc++ data structures..

wow. This is a fantastic amount of work. Thank you. No longer will libc++ accidentally break the pretty printers!

Sat, Aug 3, 7:52 PM · Restricted Project
EricWF committed rGfcd549a7d828: Suppress -Wctad-maybe-unsupported on types w/o deduction guides. (authored by EricWF).
Suppress -Wctad-maybe-unsupported on types w/o deduction guides.
Sat, Aug 3, 4:55 PM
EricWF committed rL367770: Suppress -Wctad-maybe-unsupported on types w/o deduction guides..
Suppress -Wctad-maybe-unsupported on types w/o deduction guides.
Sat, Aug 3, 4:54 PM
EricWF committed rG208e8a1b6623: Revert accidental change to __member_pointer_traits_imp. (authored by EricWF).
Revert accidental change to __member_pointer_traits_imp.
Sat, Aug 3, 12:05 PM
EricWF committed rL367762: Revert accidental change to __member_pointer_traits_imp..
Revert accidental change to __member_pointer_traits_imp.
Sat, Aug 3, 12:03 PM

Fri, Aug 2

EricWF committed rG10bf563171c5: Simplify <type_traits> implementations. (authored by EricWF).
Simplify <type_traits> implementations.
Fri, Aug 2, 10:03 PM
EricWF committed rL367749: Simplify <type_traits> implementations..
Simplify <type_traits> implementations.
Fri, Aug 2, 10:01 PM
EricWF requested changes to D65667: [libcxx] Avoid destructor call for error_category singletons.
Fri, Aug 2, 5:28 PM · Restricted Project
EricWF added a comment to D65667: [libcxx] Avoid destructor call for error_category singletons.

Or alternatively, there's an example of how to fix this in memory_resource.cpp https://github.com/llvm-mirror/libcxx/blob/master/src/experimental/memory_resource.cpp#L67-L96

Fri, Aug 2, 5:28 PM · Restricted Project
EricWF added a comment to D65667: [libcxx] Avoid destructor call for error_category singletons.

I think a better fix would be to apply [[clang::no_destroy]] to the category variable definitions instead.

Fri, Aug 2, 5:22 PM · Restricted Project
EricWF committed rGc4952da40109: Add benchmarks to test the cost of allocator (authored by EricWF).
Add benchmarks to test the cost of allocator
Fri, Aug 2, 2:14 PM
EricWF committed rL367722: Add benchmarks to test the cost of allocator.
Add benchmarks to test the cost of allocator
Fri, Aug 2, 2:14 PM

Thu, Aug 1

EricWF committed rGd544d1441d98: Refactor deque to centralize handling of spare blocks. (authored by EricWF).
Refactor deque to centralize handling of spare blocks.
Thu, Aug 1, 4:12 PM
EricWF committed rL367631: Refactor deque to centralize handling of spare blocks..
Refactor deque to centralize handling of spare blocks.
Thu, Aug 1, 4:10 PM
EricWF committed rG8f2124b47ad5: Teach malloc_allocator how to count bytes (authored by EricWF).
Teach malloc_allocator how to count bytes
Thu, Aug 1, 12:57 PM
EricWF committed rL367606: Teach malloc_allocator how to count bytes.
Teach malloc_allocator how to count bytes
Thu, Aug 1, 12:52 PM
EricWF committed rG3eb5aec61f68: Change default bucket count in hash_set/hash_map. (authored by EricWF).
Change default bucket count in hash_set/hash_map.
Thu, Aug 1, 12:49 PM
EricWF committed rL367605: Change default bucket count in hash_set/hash_map..
Change default bucket count in hash_set/hash_map.
Thu, Aug 1, 12:47 PM

Wed, Jul 31

EricWF committed rG4ea8ed413562: [pstl] Fully qualify pstl names. (authored by EricWF).
[pstl] Fully qualify pstl names.
Wed, Jul 31, 12:15 PM
EricWF committed rL367468: [pstl] Fully qualify pstl names..
[pstl] Fully qualify pstl names.
Wed, Jul 31, 12:14 PM
EricWF added a comment to D60480: [libc++] Integrate the PSTL into libc++.

Oh, I forget to mention:

Wed, Jul 31, 11:19 AM · Restricted Project, Restricted Project
EricWF accepted D60480: [libc++] Integrate the PSTL into libc++.

I still have my concerns about how we find, package, and install the PSTL. But after offline discussions with Louis, it's clear this is on his radar as well, and improvements will be made going forward.
This is a good first step.

Wed, Jul 31, 11:15 AM · Restricted Project, Restricted Project

Tue, Jul 30

EricWF added a comment to D59999: Allow the compiler to optimize `string == "literal string"`..

@EricWF asked me:

Can you restate your concern over bypassing char_traits?

Tue, Jul 30, 8:35 AM · Restricted Project
EricWF committed rG54bb5413e652: add more information to benchmark test failures (authored by EricWF).
add more information to benchmark test failures
Tue, Jul 30, 8:15 AM
EricWF committed rL367319: add more information to benchmark test failures.
add more information to benchmark test failures
Tue, Jul 30, 8:15 AM
EricWF accepted D65370: libcxx: Define __STDCPP_THREADS__ to 1, not to __cplusplus..

LGTM after moving the define to <__config>.

Tue, Jul 30, 6:30 AM

Mon, Jul 29

EricWF requested changes to D60480: [libc++] Integrate the PSTL into libc++.
Mon, Jul 29, 4:30 PM · Restricted Project, Restricted Project
EricWF reopened D60480: [libc++] Integrate the PSTL into libc++.

I have some concerns I would like to see addressed before this lands again.

Mon, Jul 29, 4:30 PM · Restricted Project, Restricted Project
EricWF committed rGb49d45925c23: Fix tests with modules enabled (authored by EricWF).
Fix tests with modules enabled
Mon, Jul 29, 3:53 PM
EricWF committed rG0c045f135d18: Ensure __config_site definitions are passed to modules tests. (authored by EricWF).
Ensure __config_site definitions are passed to modules tests.
Mon, Jul 29, 3:53 PM
EricWF committed rL367268: Fix tests with modules enabled.
Fix tests with modules enabled
Mon, Jul 29, 3:51 PM
EricWF committed rL367267: Ensure __config_site definitions are passed to modules tests..
Ensure __config_site definitions are passed to modules tests.
Mon, Jul 29, 3:48 PM
EricWF committed rGa2a6f8536621: [clang-tidy]: Google: new check 'google-upgrade-googletest-case' (authored by EricWF).
[clang-tidy]: Google: new check 'google-upgrade-googletest-case'
Mon, Jul 29, 2:43 PM
EricWF committed rL367263: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'.
[clang-tidy]: Google: new check 'google-upgrade-googletest-case'
Mon, Jul 29, 2:42 PM
EricWF added inline comments to D65004: [libc++] Unconditionally enable module tests when they're supported.
Mon, Jul 29, 2:42 PM · Restricted Project
EricWF closed D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'.

Committed in r367263. Thanks for the change, sorry about the delay.

Mon, Jul 29, 2:42 PM · Restricted Project, Restricted Project, Restricted Project

Sun, Jul 28

EricWF added inline comments to D63063: Bug 42208: speeding up std::merge.
Sun, Jul 28, 2:38 PM
EricWF added inline comments to D65370: libcxx: Define __STDCPP_THREADS__ to 1, not to __cplusplus..
Sun, Jul 28, 9:19 AM

Sat, Jul 27

EricWF committed rGd4ace50ed0e5: Fix PR35637: suboptimal codegen for `vector<unsigned char>`. (authored by EricWF).
Fix PR35637: suboptimal codegen for `vector<unsigned char>`.
Sat, Jul 27, 9:38 PM
EricWF committed rL367183: Fix PR35637: suboptimal codegen for `vector<unsigned char>`..
Fix PR35637: suboptimal codegen for `vector<unsigned char>`.
Sat, Jul 27, 9:38 PM

Jul 18 2019

EricWF accepted D64941: [libc++] Fix link error with _LIBCPP_HIDE_FROM_ABI_PER_TU and std::string.

@ldionne pointed out to me that I'm all kinds of wrong.

Jul 18 2019, 8:11 PM · Restricted Project, Restricted Project
EricWF added a comment to D64961: [libcxxabi] Define _LIBCXXABI_GUARD_ABI_ARM on WebAssembly.

ARM is the correct monacer for this configuration. The spec we're implementing was written by ARM.

Jul 18 2019, 7:44 PM · Restricted Project, Restricted Project
EricWF added a comment to D64941: [libc++] Fix link error with _LIBCPP_HIDE_FROM_ABI_PER_TU and std::string.

This change isn't strictly correct. A lot of these constructors were externally instantiated before we made them templates.
I suspect this will break the ABI.

Jul 18 2019, 3:32 PM · Restricted Project, Restricted Project

Jul 17 2019

EricWF added a comment to D64299: Make ~mutex and ~condition_variable trivial with Bionic pthreads.

Thanks for bringing this up. Indeed this change really hurts TSAN.
I'll look for ways to work around this issue.

Jul 17 2019, 8:31 PM

Jul 16 2019

EricWF added a comment to D64299: Make ~mutex and ~condition_variable trivial with Bionic pthreads.

For sanitizers I wonder if we could continue to catch use after destrot without losing triviality. Doesn't MSAN poison the objects memory at the end of the destructor?

Jul 16 2019, 9:50 PM

Jul 15 2019

EricWF committed rGc5d7b0c45472: Constrain workaround to avoid affecting other buildbots (authored by EricWF).
Constrain workaround to avoid affecting other buildbots
Jul 15 2019, 12:54 PM
EricWF committed rL366122: Constrain workaround to avoid affecting other buildbots.
Constrain workaround to avoid affecting other buildbots
Jul 15 2019, 12:53 PM

Jul 14 2019

EricWF committed rG4066978cb7a4: Improve compile time of variant. (authored by EricWF).
Improve compile time of variant.
Jul 14 2019, 2:32 PM
EricWF committed rL366033: Improve compile time of variant..
Improve compile time of variant.
Jul 14 2019, 2:29 PM
EricWF committed rG3c0e2bb0cba2: Add test for variant construction with duplicate types. (authored by EricWF).
Add test for variant construction with duplicate types.
Jul 14 2019, 2:01 PM
EricWF committed rL366032: Add test for variant construction with duplicate types..
Add test for variant construction with duplicate types.
Jul 14 2019, 1:59 PM
EricWF committed rGaae0cb67ed79: Cleanup whitespace in <variant>. NFC. (authored by EricWF).
Cleanup whitespace in <variant>. NFC.
Jul 14 2019, 11:33 AM
EricWF committed rL366026: Cleanup whitespace in <variant>. NFC..
Cleanup whitespace in <variant>. NFC.
Jul 14 2019, 11:32 AM
EricWF committed rG273857d1ea9a: Harden variant test added in r366022 (authored by EricWF).
Harden variant test added in r366022
Jul 14 2019, 11:32 AM
EricWF committed rL366025: Harden variant test added in r366022.
Harden variant test added in r366022
Jul 14 2019, 11:30 AM
EricWF committed rG194b337f3327: Avoid eager template instantiation caused by the variant narrowing checks. (authored by EricWF).
Avoid eager template instantiation caused by the variant narrowing checks.
Jul 14 2019, 11:22 AM
EricWF committed rL366022: Avoid eager template instantiation caused by the variant narrowing checks..
Avoid eager template instantiation caused by the variant narrowing checks.
Jul 14 2019, 11:21 AM

Jul 12 2019

EricWF committed rG882fdf68b74d: Fix non-conformance it `std::tuple`. (authored by EricWF).
Fix non-conformance it `std::tuple`.
Jul 12 2019, 4:03 PM
EricWF committed rL365973: Fix non-conformance it `std::tuple`..
Fix non-conformance it `std::tuple`.
Jul 12 2019, 4:01 PM
EricWF committed rG128af315957e: Add option to disable variant narrowing conversion changes. (authored by EricWF).
Add option to disable variant narrowing conversion changes.
Jul 12 2019, 2:33 PM
EricWF committed rL365960: Add option to disable variant narrowing conversion changes..
Add option to disable variant narrowing conversion changes.
Jul 12 2019, 2:33 PM

Jul 11 2019

EricWF committed rGd49103bd2ff3: Mark destroying delete test as UNSUPPORTED with clang 7 (authored by EricWF).
Mark destroying delete test as UNSUPPORTED with clang 7
Jul 11 2019, 6:20 PM
EricWF committed rL365856: Mark destroying delete test as UNSUPPORTED with clang 7.
Mark destroying delete test as UNSUPPORTED with clang 7
Jul 11 2019, 6:19 PM
EricWF committed rGa780216fb3ad: Tolerate import errors in "not.py" implementation (authored by EricWF).
Tolerate import errors in "not.py" implementation
Jul 11 2019, 6:14 PM
EricWF committed rL365855: Tolerate import errors in "not.py" implementation.
Tolerate import errors in "not.py" implementation
Jul 11 2019, 6:13 PM
EricWF committed rG02fdc51c0440: Add another buildbot username to the workaround list (authored by EricWF).
Add another buildbot username to the workaround list
Jul 11 2019, 5:19 PM
EricWF committed rL365848: Add another buildbot username to the workaround list.
Add another buildbot username to the workaround list
Jul 11 2019, 5:17 PM
EricWF committed rGce13f6761808: Attempt to override broken buildbot config for libc++abi. (authored by EricWF).
Attempt to override broken buildbot config for libc++abi.
Jul 11 2019, 5:04 PM
EricWF committed rL365847: Attempt to override broken buildbot config for libc++abi..
Attempt to override broken buildbot config for libc++abi.
Jul 11 2019, 5:02 PM
EricWF committed rG41798c05cd20: Fix memory leak in set and map. (authored by EricWF).
Fix memory leak in set and map.
Jul 11 2019, 4:14 PM
EricWF committed rL365840: Fix memory leak in set and map..
Fix memory leak in set and map.
Jul 11 2019, 4:13 PM

Jul 8 2019

EricWF added inline comments to D64378: [libcxx] Use C11 thread API on Fuchsia.
Jul 8 2019, 8:24 PM
EricWF added inline comments to D64378: [libcxx] Use C11 thread API on Fuchsia.
Jul 8 2019, 8:00 PM
EricWF added inline comments to D64378: [libcxx] Use C11 thread API on Fuchsia.
Jul 8 2019, 7:55 PM