- User Since
- Jun 26 2014, 12:44 PM (277 w, 16 h)
Mon, Oct 14
Thu, Oct 10
Are the lock free algorithms used by this implementation published somewhere? That would give me a lot more confidence in their correctness.
Please see the Adding a new header section of NOTE.txt (https://github.com/llvm-mirror/libcxx/blob/master/NOTES.TXT#L19-L29)
Tue, Oct 8
Fri, Oct 4
threading support is required to implement a conforming standard library. if we don't have it we're non-conforming.
Thu, Oct 3
Mon, Sep 30
Wed, Sep 25
Tue, Sep 24
Can you use clang-format instead of custom formatting?
Thu, Sep 19
Wed, Sep 18
I don't see any changes to tests. are the tests already sufficient or should we enable the c+ +11 tests?
Sep 14 2019
Sep 13 2019
How were the performance benefits measured? Are they visible in the existing benchmarks?
Aug 30 2019
Address review comments.
@rsmith Please address the inline comment. Otherwise this LGTM.
LGTM apart from inline comments.
Aug 29 2019
Thanks for the patch
Aug 28 2019
Address review comments. I think this is good to go.
Aug 27 2019
Aug 23 2019
Aug 22 2019
Sorry for being late to the party, I've looked at the codege of this and other approachs. what we want is a single global than initializes all of objects we need. Right now we have function local static then may may not have make guards and that's less than ideal.
Aug 21 2019
I don't fully understand this patch. The point of always declaring the interface was to enforce that it matches exactly what we expect. I'll grant that probably wasn't working, but can you explain more about?
Aug 20 2019
Aug 12 2019
Aug 9 2019
Aug 8 2019
Aug 4 2019
Aug 3 2019
wow. This is a fantastic amount of work. Thank you. No longer will libc++ accidentally break the pretty printers!
Aug 2 2019
Or alternatively, there's an example of how to fix this in memory_resource.cpp https://github.com/llvm-mirror/libcxx/blob/master/src/experimental/memory_resource.cpp#L67-L96
I think a better fix would be to apply [[clang::no_destroy]] to the category variable definitions instead.