We need to make sure that we are sensibly dealing with vectors of type v2i64 and v2f64, even if most of the time we cannot generate native operations for them. This mostly adds a lot of testing, plus fixes up a couple of the issues found. And, Or and xor can be legal for v2i64, and shifts combining needs a slight fixup.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
llvm/lib/Target/ARM/ARMISelLowering.cpp | ||
---|---|---|
337 ↗ | (On Diff #208352) | Do we need to predicate this on MVE? |
llvm/lib/Target/ARM/ARMISelLowering.cpp | ||
---|---|---|
337 ↗ | (On Diff #208352) | Yep, we only call this if we have MVEIntegerOps. Neon is handled elsewhere and I think will promote all and/or/xors to v4i32. |
Comment Actions
looks good to me
llvm/lib/Target/ARM/ARMISelLowering.cpp | ||
---|---|---|
337 ↗ | (On Diff #208352) | Ah, of course, cheers |