This adds the patterns for minnm and maxnm from the fminnum and fmaxnum nodes, similar to scalar types.
Patch by Simon Tatham
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
| llvm/test/CodeGen/Thumb2/mve-minmax.ll | ||
|---|---|---|
| 4 ↗ | (On Diff #208624) | I am going to be annoying and ask the same question again.... I know all this gets selected when we have HasMVEFloat, but is it perhaps useful to check what happens when we only have -mattr=+mve? |
| llvm/test/CodeGen/Thumb2/mve-minmax.ll | ||
|---|---|---|
| 4 ↗ | (On Diff #208624) | This one works like all the others, with the -mattr=+mve,+fullfp16 line checking that we expand when we don't have mve.fp. The "nofp+mve" expansion will just be a more verbose version of the same thing (it's already pretty verbose for fp16!) The idea was that we had a test that shows nofloat+mve expansion worked correctly for some instruction, and then these tests just needed to show expansion/selection at the correct times. I haven't added that test yet though, I will do so now. |
Comment Actions
That test was added in rL365496, to show MVE codegen where no fp instructions are present. This case would be like that without any fpu, just with more __aeabi_fcmpgt and movne's. I think this at least shows the expansion is happening correctly (plus is sidesteps an issues with these being turned into selects, which are not handled yet).