Paths
| Differential D159333
[RISCV] Replace RISCVVInversePseudosTable with a SearchIndex AbandonedPublic Authored by wangpc on Aug 31 2023, 9:05 PM.
Details
Summary The contents of RISCVVInversePseudosTable and RISCVVPseudosTable I was hoping that this change can reduce generated file but the diff This patch also puts RISCVVPseudosTable back to RISCVBaseInfo so
Diff Detail
Event TimelineComment Actions It looks like the InversePseudo table was only included for MCA directory. I wonder if this led to it only being a part of the llvm-mca binary, and not part of tools that do not depend on llvm-mca (such as llc). Could you check this by comparing the size of llc binary? It should have gotten larger after this change if it had not previously included the InversePseudo table. Comment Actions
Yes, the size will increase about 100KB for llc. class VPseudoUSLoadNoMask<VReg RetClass,
int EEW> :
Pseudo<(outs RetClass:$rd),
(ins RetClass:$dest, GPRMem:$rs1, AVL:$vl, ixlenimm:$sew,
ixlenimm:$policy), []>becomes: class VPseudoUSLoadNoMask<VReg RetClass,
int EEW> :
Pseudo<(outs RetClass:$rd),
(ins RetClass:$dest, GPRMem:$rs1, AVL:$vl,
ixlenimm:$policy), []>,This may simplify the generated patterns I think. Comment Actions
Won't that require adding more pseudos for each SEW. Many pseudos don't have SEW today. Comment Actions
I think almost all pseudos has HasSEWOp being true? Comment Actions
So there will 2 kinds of pseudos? Those with SEW in their name and those with an SEW operand? Comment Actions
Yes. Comment Actions
Where does the 30K text section reduction come from? What code are we reducing? There should be a comment in RISCVGenDAGISel.inc that says "Total Array size is" can give the reduction on that value. That's more interesting than lines. Comment Actions
Posted in D159368.
Because we don't need to match and add SEW operand, the size of MatcherTable can be reduced by about 23000 bytes, I think most of the reduction comes from here. RISCVGenInstrInfo has some reductions too. wangpc added a child revision: D159368: [RISCV] Remove SEW operand for load/store and SEW-aware pseudos.Sep 1 2023, 10:33 AM Comment Actions
Is the matcher table in the .text section? Comment Actions
I am curious about it too because it should be in .data I think, but I only saw text diff when using size llc. wangpc removed a child revision: D159368: [RISCV] Remove SEW operand for load/store and SEW-aware pseudos.Sep 5 2023, 7:22 AM
Revision Contents
Diff 555245 llvm/lib/Target/RISCV/MCA/RISCVCustomBehaviour.cpp
llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.h
llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.cpp
llvm/lib/Target/RISCV/RISCVInstrInfo.h
llvm/lib/Target/RISCV/RISCVInstrInfo.cpp
llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||