This is an archive of the discontinued LLVM Phabricator instance.

[clang][modules] Add a c23 module feature
ClosedPublic

Authored by iana on Aug 28 2023, 2:36 PM.

Details

Diff Detail

Event Timeline

iana created this revision.Aug 28 2023, 2:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 28 2023, 2:36 PM
Herald added a subscriber: ributzka. · View Herald Transcript
iana requested review of this revision.Aug 28 2023, 2:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 28 2023, 2:36 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
iana added a comment.Aug 28 2023, 2:40 PM

Would we want to back port this to llvm 17?

iana updated this revision to Diff 554158.Aug 28 2023, 9:11 PM

remove the extra #endif (which oddly didn't produce an error locally so I must've ran the tests wrong the first time...)

v.g.vassilev accepted this revision.Aug 28 2023, 11:15 PM

LGTM!

Would we want to back port this to llvm 17?

Yes probably.

This revision is now accepted and ready to land.Aug 28 2023, 11:15 PM
ChuanqiXu accepted this revision.Aug 28 2023, 11:25 PM
aaron.ballman accepted this revision.Aug 29 2023, 6:16 AM

LGTM!

Would we want to back port this to llvm 17?

Yes probably.

I believe we're only backporting critical fixes or fixes for regressions at this point, so I don't think we should try to backport this one right now.

That said, the changes LGTM!

This revision was automatically updated to reflect the committed changes.