Page MenuHomePhabricator

v.g.vassilev (Vassil Vassilev)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 21 2016, 7:16 AM (323 w, 6 d)

Recent Activity

Yesterday

v.g.vassilev added a reviewer for D129175: [ORC] Fix weak hidden symbols failure on PPC with runtimedyld: hubert.reinterpretcast.
Wed, Jul 6, 10:41 PM · Restricted Project, Restricted Project
v.g.vassilev added a comment to D126266: Mark the file entry invalid, until reread. Invalidate SLocEntry cache, readd it on reread. Do not use translateFile, because it pulls in parts of the pch..

Hmm, I'm concerned with the pieces added purely for testing. Specifically, FileEntriesToReread and TestHelper friend functions. Need to think how else we can test it.

Wed, Jul 6, 3:08 AM · Restricted Project, Restricted Project, Restricted Project

Sun, Jul 3

v.g.vassilev accepted D129042: Reland "[NFC] Add a missing test for for clang-repl".

Let's move forward and we can remove the XFAIL once https://reviews.llvm.org/D128968 lands.

Sun, Jul 3, 3:14 AM · Restricted Project, Restricted Project

Sat, Jul 2

v.g.vassilev added reviewers for D128782: [CodeGen] Keep track of decls that were deferred and have been emitted.: rsmith, rjmccall.

I am adding some more reviewers as I think this patch is ready to go.

Sat, Jul 2, 10:33 PM · Restricted Project, Restricted Project

Fri, Jul 1

v.g.vassilev accepted D128991: [NFC] Add a missing test for for clang-repl.
Fri, Jul 1, 7:15 AM · Restricted Project, Restricted Project

Wed, Jun 29

v.g.vassilev accepted D128853: [Interpreter] Pass target features to JIT.

Thanks for the clarification! LGTM.

Wed, Jun 29, 1:56 PM · Restricted Project, Restricted Project
v.g.vassilev added a comment to D128853: [Interpreter] Pass target features to JIT.

Looks good to me but can we add a test? Do we have builders with that target?

Wed, Jun 29, 1:39 PM · Restricted Project, Restricted Project

Tue, Jun 28

v.g.vassilev added a comment to D128319: Survive #pragma once from virtual file..

Historically, the patch was developed before the extended support of virtual files in Clang. Given that this is very hard to test and it looks like this is not needed on our end anymore. I'd propose to pause this for now.

Tue, Jun 28, 8:41 AM · Restricted Project, Restricted Project

Mon, Jun 27

v.g.vassilev abandoned D34444: Teach codegen to work in incremental processing mode..

This landed slightly modified here: https://github.com/llvm/llvm-project/commit/4d54e543abd5d0a8b0a321f8c292252f4895693a

Mon, Jun 27, 7:23 AM · Restricted Project

Sun, Jun 26

v.g.vassilev committed rGb5eaf500f244: [clang] Add missing Interpreter -> ClangDriverOptions dependency (authored by v.g.vassilev).
[clang] Add missing Interpreter -> ClangDriverOptions dependency
Sun, Jun 26, 6:51 AM · Restricted Project, Restricted Project
v.g.vassilev closed D115827: [clang]: add missing Interpreter -> ClangDriverOptions dependency.
Sun, Jun 26, 6:51 AM · Restricted Project, Restricted Project
v.g.vassilev committed rGe881d85371bf: Allow interfaces to operate on in-memory buffers with no source location info. (authored by tapaswenipathak).
Allow interfaces to operate on in-memory buffers with no source location info.
Sun, Jun 26, 6:47 AM · Restricted Project, Restricted Project
v.g.vassilev closed D88780: Allow interfaces to operate on in-memory buffers with no source location info..
Sun, Jun 26, 6:46 AM · Restricted Project, Restricted Project
v.g.vassilev accepted D126682: [clang-repl] Implement code undo.

LGTM!

Sun, Jun 26, 3:29 AM · Restricted Project, Restricted Project

Sat, Jun 25

v.g.vassilev resigned from D32952: Follow up patch for D31495.
Sat, Jun 25, 1:16 PM · Restricted Project
v.g.vassilev resigned from D37797: Fix crash in Sema when wrongly assuming VarDecl init is not value dependent..

According to godbolt this example does not crash anymore.

Sat, Jun 25, 1:15 PM · Restricted Project
v.g.vassilev added a comment to D125944: Template instantiation error recovery.

@Purva-Chaudhari, can you rebase this patch, seems that it is not buildable.

@rsmith, we need to do something similar in cling to handle pending template instantiations, I guess the question is if we can avoid instantiating the templates we don't need and still survive.

Sat, Jun 25, 1:13 PM · Restricted Project
v.g.vassilev added inline comments to D125946: Handles failing driver tests of clang.
Sat, Jun 25, 1:11 PM · Restricted Project
v.g.vassilev resigned from D54986: Make CodeGen choose when to emit vtables..

I think this landed in a different form.

Sat, Jun 25, 1:08 PM · Restricted Project
v.g.vassilev accepted D128589: [clang-repl] Support destructors of global objects..

LGTM, modulo the comment.

Sat, Jun 25, 12:37 PM · Restricted Project, Restricted Project, Restricted Project
v.g.vassilev added a comment to D126266: Mark the file entry invalid, until reread. Invalidate SLocEntry cache, readd it on reread. Do not use translateFile, because it pulls in parts of the pch..

After landing https://reviews.llvm.org/D126682 we might be able to write a test in clang-repl such as:

Sat, Jun 25, 9:17 AM · Restricted Project, Restricted Project, Restricted Project
v.g.vassilev added a comment to D128257: invalidateCache in addModule and removeModules.

I think this patch is not needed in the main branch as https://github.com/llvm/llvm-project/commit/f91b6f8159b101688eef87c75179209699c0d405 removes the need of calling invalidateCache altogether.

Sat, Jun 25, 9:11 AM · Restricted Project, Restricted Project
v.g.vassilev added a reviewer for D128319: Survive #pragma once from virtual file.: rsmith.

Can we write a test for this?

Sat, Jun 25, 8:56 AM · Restricted Project, Restricted Project
v.g.vassilev added inline comments to D126682: [clang-repl] Implement code undo.
Sat, Jun 25, 8:55 AM · Restricted Project, Restricted Project
v.g.vassilev added a comment to D126682: [clang-repl] Implement code undo.

Thanks for working on this. Here are some more comments.

Sat, Jun 25, 8:54 AM · Restricted Project, Restricted Project

Fri, Jun 24

v.g.vassilev committed rG946c45a4ed5d: Implement soft reset of the diagnostics engine. (authored by tapaswenipathak).
Implement soft reset of the diagnostics engine.
Fri, Jun 24, 7:47 AM · Restricted Project, Restricted Project
v.g.vassilev closed D126183: Implement soft reset of the diagnostics engine..
Fri, Jun 24, 7:47 AM · Restricted Project, Restricted Project, Restricted Project
Herald added a project to D115827: [clang]: add missing Interpreter -> ClangDriverOptions dependency: Restricted Project.

@t184256, do we still need this? Should I commit it in case you don't have commit access?

Fri, Jun 24, 4:16 AM · Restricted Project, Restricted Project
v.g.vassilev added a reverting change for rG575e297fcb28: Revert "[clang-repl] Recover the lookup tables of the primary context.": rGac6c5c5e8f20: Reland "[clang-repl] Recover the lookup tables of the primary context.".
Fri, Jun 24, 1:36 AM · Restricted Project, Restricted Project
v.g.vassilev committed rGac6c5c5e8f20: Reland "[clang-repl] Recover the lookup tables of the primary context." (authored by v.g.vassilev).
Reland "[clang-repl] Recover the lookup tables of the primary context."
Fri, Jun 24, 1:36 AM · Restricted Project, Restricted Project
v.g.vassilev accepted D88780: Allow interfaces to operate on in-memory buffers with no source location info..

I'd propose to move forward here and rely on eventual post-commit review.

Fri, Jun 24, 12:36 AM · Restricted Project, Restricted Project

Fri, Jun 17

v.g.vassilev accepted D127991: [clang-repl] Remove memory leak of ASTContext/TargetMachine..

Lgtm!

Fri, Jun 17, 8:12 AM · Restricted Project, Restricted Project

Tue, Jun 14

v.g.vassilev accepted D126620: [clang] AST/Print: honor AlwaysIncludeTypeForTemplateArgument policy.

Let's move forward with this and rely on eventual post-commit review.

Tue, Jun 14, 5:11 AM · Restricted Project, Restricted Project
v.g.vassilev added reviewers for D126682: [clang-repl] Implement code undo: sgraenitz, lhames, rjmccall.

I think we are in a good shape to broaden the list of reviewers.

Tue, Jun 14, 5:10 AM · Restricted Project, Restricted Project

Sun, Jun 12

v.g.vassilev added inline comments to D126682: [clang-repl] Implement code undo.
Sun, Jun 12, 4:43 AM · Restricted Project, Restricted Project

Thu, Jun 9

v.g.vassilev added inline comments to D126682: [clang-repl] Implement code undo.
Thu, Jun 9, 9:48 PM · Restricted Project, Restricted Project
v.g.vassilev added a comment to D126682: [clang-repl] Implement code undo.
Thu, Jun 9, 9:49 AM · Restricted Project, Restricted Project
v.g.vassilev added inline comments to D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder.
Thu, Jun 9, 9:46 AM · Restricted Project, Restricted Project

Wed, Jun 8

v.g.vassilev requested review of D127284: [WIP] [clang-repl] Support statements on global scope in incremental mode..
Wed, Jun 8, 3:13 AM · Restricted Project

Jun 6 2022

v.g.vassilev added inline comments to D126183: Implement soft reset of the diagnostics engine..
Jun 6 2022, 9:49 AM · Restricted Project, Restricted Project, Restricted Project
v.g.vassilev added a comment to D88780: Allow interfaces to operate on in-memory buffers with no source location info..

This looks reasonable to me...

Jun 6 2022, 6:39 AM · Restricted Project, Restricted Project
v.g.vassilev added inline comments to D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder.
Jun 6 2022, 6:34 AM · Restricted Project, Restricted Project
v.g.vassilev accepted D126183: Implement soft reset of the diagnostics engine..

This looks good to me, modulo the inline comment.

Jun 6 2022, 6:32 AM · Restricted Project, Restricted Project, Restricted Project

Jun 3 2022

v.g.vassilev added a comment to D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder.

Okay, I understand. So, first off, I wouldn't really call that a "weak" symbol rather than, say, a lazily-emitted symbol; "weak" already has plenty of different senses, and we should try to avoid coining more. Also, your patch description makes it sound like there's a general bug you're fixing rather than specifically an issue with re-using a single CodeGenerator to generate a succession of modules; please remember that people reading your commit messages don't necessarily know you or contextualize your patches by knowing that you work on Cling.

Jun 3 2022, 1:02 AM · Restricted Project, Restricted Project

Jun 2 2022

v.g.vassilev added a comment to D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder.

Thanks for the prompt reply.

Jun 2 2022, 2:43 PM · Restricted Project, Restricted Project

Jun 1 2022

v.g.vassilev added reviewers for D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder: rsmith, lhames, sgraenitz, karies.
Jun 1 2022, 10:33 AM · Restricted Project, Restricted Project

May 30 2022

v.g.vassilev added a comment to D123674: Clang-Repl Error Recovery Bug Fix.

Hi,

I noticed that the testcase Interpreter/execute.cpp starts failing with this patch when run/compiled with asan:

Failed Tests (1):
  Clang :: Interpreter/execute.cpp

Seen in the buildbot run
https://lab.llvm.org/buildbot/#/builders/5/builds/24221

The run on the commit before passed:
https://lab.llvm.org/buildbot/#/builders/5/builds/24220

May 30 2022, 11:34 PM · Restricted Project, Restricted Project
v.g.vassilev added a reverting change for rG5ff27fe1ff03: [clang-repl] Recover the lookup tables of the primary context.: rG575e297fcb28: Revert "[clang-repl] Recover the lookup tables of the primary context.".
May 30 2022, 11:33 PM · Restricted Project, Restricted Project
v.g.vassilev committed rG575e297fcb28: Revert "[clang-repl] Recover the lookup tables of the primary context." (authored by v.g.vassilev).
Revert "[clang-repl] Recover the lookup tables of the primary context."
May 30 2022, 11:33 PM · Restricted Project, Restricted Project
v.g.vassilev added a reverting change for D123674: Clang-Repl Error Recovery Bug Fix: rG575e297fcb28: Revert "[clang-repl] Recover the lookup tables of the primary context.".
May 30 2022, 11:33 PM · Restricted Project, Restricted Project
v.g.vassilev added a comment to D126620: [clang] AST/Print: honor AlwaysIncludeTypeForTemplateArgument policy.

This patch fixes our test case which we intended to fix with:

From 17e94a6a2adc3eb8d5fcc532eb1f3e57cc59b0fd Mon Sep 17 00:00:00 2001
From: Vassil Vassilev <v.g.vassilev@gmail.com>
Date: Mon, 23 May 2022 21:36:43 +0000
Subject: [PATCH] Fix type printing to not include the suffix when not needed.
May 30 2022, 10:07 PM · Restricted Project, Restricted Project
v.g.vassilev accepted D126674: [clang] NFC: introduce test for D126620.

LGTM!

May 30 2022, 1:42 PM · Restricted Project, Restricted Project

May 29 2022

v.g.vassilev added inline comments to D125946: Handles failing driver tests of clang.
May 29 2022, 11:48 AM · Restricted Project

May 28 2022

v.g.vassilev abandoned D33468: Enable unicode output on terminals..

This is not an issue anymore for us.

May 28 2022, 11:37 PM · Restricted Project
v.g.vassilev added a reviewer for D125944: Template instantiation error recovery: rsmith.

@Purva-Chaudhari, can you rebase this patch, seems that it is not buildable.

May 28 2022, 10:10 PM · Restricted Project
v.g.vassilev added reviewers for D125946: Handles failing driver tests of clang: rsmith, lhames, dblaikie, sgraenitz.

@Purva-Chaudhari, this looks reasonable to me. I am adding more reviewers to discuss the way we refer other tests from clang-repl.

May 28 2022, 10:04 PM · Restricted Project
v.g.vassilev committed rG5ff27fe1ff03: [clang-repl] Recover the lookup tables of the primary context. (authored by Purva-Chaudhari).
[clang-repl] Recover the lookup tables of the primary context.
May 28 2022, 10:00 PM · Restricted Project, Restricted Project
v.g.vassilev closed D123674: Clang-Repl Error Recovery Bug Fix.
May 28 2022, 10:00 PM · Restricted Project, Restricted Project
v.g.vassilev accepted D123674: Clang-Repl Error Recovery Bug Fix.

LGTM! Apologies for the delay.

May 28 2022, 2:47 PM · Restricted Project, Restricted Project

May 27 2022

v.g.vassilev committed rG8c0eb32d2aa0: Also remove the empty StoredDeclsList entry from the lookup table (authored by v.g.vassilev).
Also remove the empty StoredDeclsList entry from the lookup table
May 27 2022, 5:37 AM · Restricted Project, Restricted Project
v.g.vassilev closed D119675: Also remove the empty StoredDeclsList entry from the lookup table.
May 27 2022, 5:37 AM · Restricted Project, Restricted Project
v.g.vassilev closed D121413: [clang-repl] Add an accessor to our underlying execution engine.

Landed in https://github.com/llvm/llvm-project/commit/788e0f7f3e96a9d61c2412e452c4589e2693b79a

May 27 2022, 4:13 AM · Restricted Project

May 23 2022

v.g.vassilev added reviewers for D126266: Mark the file entry invalid, until reread. Invalidate SLocEntry cache, readd it on reread. Do not use translateFile, because it pulls in parts of the pch.: rsmith, vsapsai.

Just to add that the invalidateCache is important for cling and clang-repl where we do something like:

May 23 2022, 10:04 PM · Restricted Project, Restricted Project, Restricted Project
v.g.vassilev added a reviewer for D126183: Implement soft reset of the diagnostics engine.: rsmith.
May 23 2022, 5:39 AM · Restricted Project, Restricted Project, Restricted Project

Apr 13 2022

v.g.vassilev updated subscribers of D123674: Clang-Repl Error Recovery Bug Fix.
Apr 13 2022, 5:48 AM · Restricted Project, Restricted Project

Mar 28 2022

v.g.vassilev accepted D122546: Let clang-repl link privately against Clang components.

Thanks for the clarification! LGTM!

Mar 28 2022, 9:07 AM · Restricted Project, Restricted Project

Mar 11 2022

v.g.vassilev committed rG788e0f7f3e96: [clang-repl] Add an accessor to our underlying execution engine (authored by v.g.vassilev).
[clang-repl] Add an accessor to our underlying execution engine
Mar 11 2022, 1:25 AM · Restricted Project

Mar 10 2022

v.g.vassilev updated the diff for D121413: [clang-repl] Add an accessor to our underlying execution engine.

Order fwd decls alphabetically.

Mar 10 2022, 2:04 PM · Restricted Project
v.g.vassilev requested review of D121413: [clang-repl] Add an accessor to our underlying execution engine.
Mar 10 2022, 1:59 PM · Restricted Project
Herald added a project to D119675: Also remove the empty StoredDeclsList entry from the lookup table: Restricted Project.

ping.

Mar 10 2022, 1:40 PM · Restricted Project, Restricted Project

Feb 21 2022

v.g.vassilev abandoned D120206: Fix the "good first issue" type of failures.

I have a patch for this already: D117745. I will commit it now.

Feb 21 2022, 8:15 AM

Feb 20 2022

v.g.vassilev requested review of D120206: Fix the "good first issue" type of failures.
Feb 20 2022, 4:06 AM

Feb 17 2022

v.g.vassilev committed rWbf521597688b: [GSoC22] Add a GSoC22 overview and move past projects into the new section. (authored by v.g.vassilev).
[GSoC22] Add a GSoC22 overview and move past projects into the new section.
Feb 17 2022, 11:58 PM
v.g.vassilev committed rWa9f86184f27f: [GSoC22] Re-add the clang type desugaring project. (authored by v.g.vassilev).
[GSoC22] Re-add the clang type desugaring project.
Feb 17 2022, 2:13 PM
v.g.vassilev committed rW97bb11a466b2: [GSoC22] Re-add the llvm jit-related projects. (authored by v.g.vassilev).
[GSoC22] Re-add the llvm jit-related projects.
Feb 17 2022, 2:13 PM

Feb 13 2022

v.g.vassilev requested review of D119675: Also remove the empty StoredDeclsList entry from the lookup table.
Feb 13 2022, 12:00 PM · Restricted Project, Restricted Project

Feb 12 2022

v.g.vassilev closed D112663: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name..

That change landed in 4fb0805c6525b13e50067b9ddfe8677a0b7b2d7c

Feb 12 2022, 12:08 AM

Dec 15 2021

v.g.vassilev accepted D115827: [clang]: add missing Interpreter -> ClangDriverOptions dependency.

Lgtm!

Dec 15 2021, 1:29 PM · Restricted Project, Restricted Project

Dec 1 2021

v.g.vassilev added inline comments to D112663: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name..
Dec 1 2021, 5:33 AM

Nov 30 2021

v.g.vassilev added inline comments to D112663: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name..
Nov 30 2021, 12:53 PM

Nov 10 2021

v.g.vassilev committed rG4fb0805c6525: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name. (authored by v.g.vassilev).
[clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name.
Nov 10 2021, 4:59 AM
v.g.vassilev added inline comments to D112663: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name..
Nov 10 2021, 2:24 AM
v.g.vassilev updated the diff for D112663: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name..

Address comments and fix the windows bot failure.

Nov 10 2021, 2:14 AM

Nov 5 2021

v.g.vassilev added a comment to D112349: [Verifier] Add verification logic for GlobalIFuncs.

And how is Cling expecting CFE to deal with partial knowledge situations at the implementation level? To deal with exactly the non-local cases that the current violations address?
If there's no prescriptive way forward to dealing with these cases (so they're tech debt without a remediation plan), then as far as I'm concerned this case sits exactly under the same tech-debt umbrella of the existing violations and the way forward is using the same violating solution for this case too.
We definitely shouldn't block the IR verification indefinitely on this impasse. Once an acceptable solution is found, this will also be part of that refactor.

My understanding is that the REPL setup is that the 'IR' just needs to be in a state where it doesn't require reverts/rewrites later, so that we can do partial-back-end-code-generation as we go along. That said, I'm not positive as to the implications. I'm just repeating the discussion the CFE code-owner made at the time.

IMO, the 'acceptable' solution is to have a way to forward-declare an ifunc in IR so that we can fill in the resolver later on. From your description earlier, it seems that this would work as we could emit it as an 'unknown symbol' (as if it was an undefined function declaration), and would be completely implementable in the CFE.

So it would change your plan from earlier to:

When processing cpu_specific, emit the ifunc "x.ifunc", with no resolver;
When processing cpu_dispatch:

Get/Create the ifunc, then pull up the resolver.
If the resolver is null (as it should be), create one and update the 'ifunc'.
Generate said resolver.
Nov 5 2021, 10:49 AM · Restricted Project, Restricted Project, Restricted Project

Nov 1 2021

v.g.vassilev added a comment to D107049: [clang-repl] Re-implement clang-interpreter as a test case..

Can you share your cmake config line, the target triple and architecture?

CC='/mycompiler/compiler-clang/bin/clang -march=corei7' CXX='/mycompiler/compiler-clang/bin/clang++ -march=corei7' LDFLAGS='-L/mycompiler/compiler-clang/lib64 -Wl,--disable-new-dtags,-R/mycompiler/compiler-clang/lib/x86_64-unknown-linux-gnu/c++:/mycompiler/compiler-clang/lib64:/proj/bbi_twh/wh_bbi/x86_64-Linux3/z3/4.8.8-1/lib64 -ldl' cmake /repo/llvm --debug-trycompile -G Ninja -DCMAKE_MAKE_PROGRAM=ninja -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_FLAGS='-Wno-error=unused-command-line-argument' -DCMAKE_CXX_FLAGS='-stdlib=libc++' -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_INSTALL_PREFIX=/compiler-clang -DLLVM_APPEND_VC_REV=OFF -DLLVM_CCACHE_DIR=/repo/.ccache -DLLVM_CCACHE_BUILD=ON -DLLVM_CCACHE_PROGRAM=/app/vbuild/RHEL7-x86_64/ccache/3.2.2/bin/ccache -DLLVM_CCACHE_NOHASHDIR=ON -DLLVM_CCACHE_BASEDIR=/repo -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_ENABLE_WERROR=ON -DLLVM_ENABLE_PROJECTS='clang;clang-tools-extra;lld' -DLLVM_ENABLE_Z3_SOLVER=ON -DLLVM_Z3_INSTALL_DIR=/proj/bbi_twh/wh_bbi/x86_64-Linux3/z3/4.8.8-1 -DLLVM_LIT_ARGS='-sv --threads 14' -DLLVM_ENABLE_PLUGINS=OFF -DLLVM_USE_SANITIZER='Address' -DLLVM_ENABLE_LIBPFM=OFF -DLLVM_ENABLE_LIBXML2=OFF -DLLVM_ENABLE_TERMINFO=OFF -DLLVM_STATIC_LINK_CXX_STDLIB=ON -DCLANG_ENABLE_ARCMT=OFF -DCLANG_TOOLING_BUILD_AST_INTROSPECTION=OFF -DCLANG_ROUND_TRIP_CC1_ARGS=OFF

Nov 1 2021, 3:54 AM · Restricted Project

Oct 29 2021

v.g.vassilev added a comment to D107049: [clang-repl] Re-implement clang-interpreter as a test case..

Hi,

We're seeing a problem with this patch in our downstream (not public) buildbots. With an asan-built compiler we see the following:

10:08:55 FAIL: Clang-Unit :: Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests/InterpreterTest.CatchException (25832 of 79960)
10:08:55 ******************** TEST 'Clang-Unit :: Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests/InterpreterTest.CatchException' FAILED ********************
10:08:55 Script:
10:08:55 --
10:08:55 /repo/bbiswjenk/fem2s10-eiffel176/workspace/llvm/llvm-main-sanitize-asan/llvm/build-all-bbisdk-asan/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests --gtest_filter=InterpreterTest.CatchException
10:08:55 --
10:08:55 Note: Google Test filter = InterpreterTest.CatchException
10:08:55 [==========] Running 1 test from 1 test suite.
10:08:55 [----------] Global test environment set-up.
10:08:55 [----------] 1 test from InterpreterTest
10:08:55 [ RUN      ] InterpreterTest.CatchException
10:08:55 libunwind: __unw_add_dynamic_fde: bad fde: FDE is really a CIE
10:08:55 libc++abi: terminating with uncaught exception of type custom_exception
10:08:55  #0 0x000000000052072b backtrace /repo/uabelho/flacc_6.144/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:4205:13
10:08:55  #1 0x0000000001873774 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) /repo/bbiswjenk/fem2s10-eiffel176/workspace/llvm/llvm-main-sanitize-asan/llvm/build-all-bbisdk-asan/../lib/Support/Unix/Signals.inc:565:13
10:08:55  #2 0x000000000186c328 llvm::sys::RunSignalHandlers() /repo/bbiswjenk/fem2s10-eiffel176/workspace/llvm/llvm-main-sanitize-asan/llvm/build-all-bbisdk-asan/../lib/Support/Signals.cpp:0:5
10:08:55  #3 0x00000000018745a8 SignalHandler(int) /repo/bbiswjenk/fem2s10-eiffel176/workspace/llvm/llvm-main-sanitize-asan/llvm/build-all-bbisdk-asan/../lib/Support/Unix/Signals.inc:0:3
10:08:55  #4 0x00007f61246da630 __restore_rt sigaction.c:0:0
10:08:55  #5 0x00007f6122025387 raise (/lib64/libc.so.6+0x36387)
10:08:55  #6 0x00007f6122026a78 abort (/lib64/libc.so.6+0x37a78)
10:08:55  #7 0x000000000cbdedd6 (/repo/bbiswjenk/fem2s10-eiffel176/workspace/llvm/llvm-main-sanitize-asan/llvm/build-all-bbisdk-asan/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests+0xcbdedd6)
10:08:55  #8 0x000000000cbe4407 (/repo/bbiswjenk/fem2s10-eiffel176/workspace/llvm/llvm-main-sanitize-asan/llvm/build-all-bbisdk-asan/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests+0xcbe4407)
10:08:55  #9 0x000000000cbdecb3 std::__terminate(void (*)()) crtstuff.c:0:0
10:08:55 #10 0x000000000cbdca26 (/repo/bbiswjenk/fem2s10-eiffel176/workspace/llvm/llvm-main-sanitize-asan/llvm/build-all-bbisdk-asan/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests+0xcbdca26)
10:08:55 #11 0x000000000cbdc9c0 __cxxabiv1::exception_cleanup_func(_Unwind_Reason_Code, _Unwind_Exception*) cxa_exception.cpp:0:0
10:08:55 #12 0x00007f611ea00171 
10:08:55 
10:08:55 ********************
10:08:55 Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
10:25:10 
10:25:10 1 warning(s) in tests
10:25:10 ********************
10:25:10 Failed Tests (1):
10:25:10   Clang-Unit :: Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests/InterpreterTest.CatchException
10:25:10

Does an asan-build run clean for everyone else?

Oct 29 2021, 8:32 AM · Restricted Project

Oct 28 2021

v.g.vassilev updated the diff for D112663: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name..

Address comments

Oct 28 2021, 12:37 AM

Oct 27 2021

v.g.vassilev requested review of D112663: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name..
Oct 27 2021, 1:56 PM
v.g.vassilev added inline comments to D107049: [clang-repl] Re-implement clang-interpreter as a test case..
Oct 27 2021, 3:14 AM · Restricted Project
v.g.vassilev committed rGf0d527b28d07: [clang-repl] Remove redundant link libraries and drop unused file. (authored by v.g.vassilev).
[clang-repl] Remove redundant link libraries and drop unused file.
Oct 27 2021, 3:14 AM

Oct 26 2021

v.g.vassilev added inline comments to D107049: [clang-repl] Re-implement clang-interpreter as a test case..
Oct 26 2021, 1:20 PM · Restricted Project
v.g.vassilev committed rGc24a58081b52: Reinstate "[clang-repl] Re-implement clang-interpreter as a test case." (authored by v.g.vassilev).
Reinstate "[clang-repl] Re-implement clang-interpreter as a test case."
Oct 26 2021, 12:30 PM

Oct 8 2021

v.g.vassilev added a comment to D107049: [clang-repl] Re-implement clang-interpreter as a test case..

Hi. I think our clang builders are failing from this after the reland (https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8833962834812688769/overview):

Script:
--
/b/s/w/ir/x/w/staging/llvm_build/tools/clang/unittests/Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests --gtest_filter=InterpreterTest.CatchException
--
Note: Google Test filter = InterpreterTest.CatchException
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from InterpreterTest
[ RUN      ] InterpreterTest.CatchException
JIT session error: Symbols not found: [ _Unwind_Resume, _ZSt9terminatev, _ZTVN10__cxxabiv117__class_type_infoE, __cxa_allocate_exception, __cxa_begin_catch, __cxa_end_catch, __cxa_free_exception, __cxa_throw, __gxx_personality_v0 ]
Failure value returned from cantFail wrapped call
Failed to materialize symbols: { (main, { __clang_call_terminate, _ZTI16custom_exception, _ZN16custom_exceptionC2EPKc, _ZTS16custom_exception, throw_exception }) }
UNREACHABLE executed at llvm/include/llvm/Support/Error.h:778!

Would you be able to send out a fix or revert?

Oct 8 2021, 10:15 PM · Restricted Project
v.g.vassilev added inline comments to D107049: [clang-repl] Re-implement clang-interpreter as a test case..
Oct 8 2021, 11:13 AM · Restricted Project

Oct 7 2021

v.g.vassilev committed rG1dba6b37bdc7: Reland "[clang-repl] Re-implement clang-interpreter as a test case." (authored by v.g.vassilev).
Reland "[clang-repl] Re-implement clang-interpreter as a test case."
Oct 7 2021, 11:05 PM
v.g.vassilev added a comment to D111198: [Support] Make consumeError, toString callable from code compiled with RTTI..

Vassil -- This is a generalization of the error fix that we discussed. Could you double check that it fixes the linker error that you saw?

After thinking about it for a while I'm on the fence about this approach -- on the one hand it's a reasonable cleanup, on the other hand I don't think we generally support linking -no-rtti LLVM libraries from -rtti code, and support for doing that (even partial support) might be an explicit non-goal for the project.

Another approach to fixing the example might just be to split it into two files. Pros of that approach: it deals with no-rtti/rtti crossover code The Right Way, Con: it complicates the example for everyone else.

@lhames, thanks a lot for the patch -- this makes D107049 compile. I do not have a strong opinion on how/should we bridge rtti/no-rtti. I feel this will come up more often due to clang-repl...

Oct 7 2021, 12:36 PM · Restricted Project
v.g.vassilev added a comment to D111198: [Support] Make consumeError, toString callable from code compiled with RTTI..

Vassil -- This is a generalization of the error fix that we discussed. Could you double check that it fixes the linker error that you saw?

After thinking about it for a while I'm on the fence about this approach -- on the one hand it's a reasonable cleanup, on the other hand I don't think we generally support linking -no-rtti LLVM libraries from -rtti code, and support for doing that (even partial support) might be an explicit non-goal for the project.

Another approach to fixing the example might just be to split it into two files. Pros of that approach: it deals with no-rtti/rtti crossover code The Right Way, Con: it complicates the example for everyone else.

Oct 7 2021, 11:04 AM · Restricted Project
v.g.vassilev accepted D111315: Workaround build error for mingw-g++.

Thanks for the patch!

Oct 7 2021, 10:32 AM · Restricted Project
v.g.vassilev added a comment to D111315: Workaround build error for mingw-g++.

Can you map state_not_recoverable to not_supported?

Oct 7 2021, 9:59 AM · Restricted Project

Oct 5 2021

v.g.vassilev added inline comments to D107049: [clang-repl] Re-implement clang-interpreter as a test case..
Oct 5 2021, 11:13 AM · Restricted Project