Page MenuHomePhabricator

v.g.vassilev (Vassil Vassilev)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 21 2016, 7:16 AM (268 w, 2 d)

Recent Activity

Fri, May 21

v.g.vassilev committed rG49f9532165f0: [clang-repl] Tell the LLJIT the exact target triple we use. (authored by v.g.vassilev).
[clang-repl] Tell the LLJIT the exact target triple we use.
Fri, May 21, 1:17 AM

Wed, May 19

v.g.vassilev added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

@uweigand, thanks again for confirming the patch works for you. The differential revision is here https://reviews.llvm.org/D102756

Wed, May 19, 3:53 AM · Restricted Project
v.g.vassilev requested review of D102756: [clang-repl] Tell the LLJIT the exact target triple we use..
Wed, May 19, 3:51 AM

Tue, May 18

v.g.vassilev added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

@hubert.reinterpretcast, thanks for the feedback. I have created a patch as discussed -- https://reviews.llvm.org/D102688

@uweigand, thanks for reaching out. I believe the patch above should fix your setup. Could you confirm?

Unfortunately, it does not. Changing the triple doesn't affect the architecture the compiler generates code for. If you wanted to change the compiler to generate code for the architecture the JIT detects, the easiest way would probably be to use (the equivalent of) "-march=native", which causes the compiler to also auto-detect the current processor in the same way as the JIT does.

Tue, May 18, 1:01 PM · Restricted Project
v.g.vassilev committed rG8dd5ef01ef13: [clang-repl] Better match the underlying architecture. (authored by v.g.vassilev).
[clang-repl] Better match the underlying architecture.
Tue, May 18, 12:15 PM
v.g.vassilev closed D102688: [clang-repl] Better match the underlying architecture..
Tue, May 18, 12:14 PM · Restricted Project
v.g.vassilev added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

We've started seeing LLVM ERROR: out of memory on our 2-stage LTO Linux builders after this change landed. It looks like linking clang-repl always fails on our bot, but I've also seen OOM when linking ClangCodeGenTests and FrontendTests. Do you have any idea why this could be happening? We'd appreciate any help since our bots have been broken for several days now.

Tue, May 18, 10:00 AM · Restricted Project
v.g.vassilev added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

@hubert.reinterpretcast, thanks for the feedback. I have created a patch as discussed -- https://reviews.llvm.org/D102688

Tue, May 18, 6:43 AM · Restricted Project
v.g.vassilev requested review of D102688: [clang-repl] Better match the underlying architecture..
Tue, May 18, 6:41 AM · Restricted Project

Sun, May 16

v.g.vassilev added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

IIUC, AIX has a default fno-integrated-as and I am still puzzled (and cannot find the relevant code) what is the program action kind for AIX in that case (frontend::???).

This is rooted in IsIntegratedAssemblerDefault and the relevant code is more a relevant lack of code. The default implementation, ToolChain::IsIntegratedAssemblerDefault, returns false.

Maybe applying that diff can give us a hint:

Output is:

$ cat /home/hstong/.Liodine/llvmproj/clang/test/Interpreter/execute.cpp | /home/hstong/.Nrtphome/.Liodine/llcrossbld/dev/build/bin/clang-repl
ActionKind=7
clang-repl: Driver initialization failed. Incremental mode for action is not supported
Sun, May 16, 11:27 AM · Restricted Project
v.g.vassilev added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

If you have some ideas, please let me know. Meanwhile, I am trying out system-aix as the "feature" to XFAIL on.

https://reviews.llvm.org/D102560 posted to use system-aix so other PPC configurations will run the test. Possible further changes is for the code to choose the process triple, for the test to possibly specify -fintegrated-as, and (alternatively) for the system assembler step to be integrated into this use scenario.

Sun, May 16, 8:48 AM · Restricted Project

Sat, May 15

v.g.vassilev added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

Hi @hubert.reinterpretcast,

Would you mind testing this patch:

Does the test try to generate native object files in some way? There is functionality (with some limitations) for that under 32-bit AIX; however, we're running a 64-bit build and we don't have integrated-as capability for that at this time. This is what I'm seeing:

******************** TEST 'Clang :: Interpreter/execute.cpp' FAILED ********************
Script:
--
: 'RUN: at line 1';   cat /home/hstong/.Liodine/llvmproj/clang/test/Interpreter/execute.cpp | /home/hstong/.Nrtphome/.Liodine/llcrossbld/dev/build/bin/clang-repl | /home/hstong/.Nrtphome/.Liodine/llcrossbld/dev/build/bin/FileCheck /home/hstong/.Liodine/llvmproj/clang/test/Interpreter/execute.cpp
--
Exit Code: 2

Command Output (stderr):
--
clang-repl: Driver initialization failed. Incremental mode for action is not supported
FileCheck error: '<stdin>' is empty.
FileCheck command line:  /home/hstong/.Nrtphome/.Liodine/llcrossbld/dev/build/bin/FileCheck /home/hstong/.Liodine/llvmproj/clang/test/Interpreter/execute.cpp

--

********************
Sat, May 15, 4:09 AM · Restricted Project

Fri, May 14

v.g.vassilev added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

Would you mind testing this patch:

diff
diff --git a/clang/lib/Interpreter/Interpreter.cpp b/clang/lib/Interpreter/Interpreter.cpp
index 8de38c0afcd9..79acb5bd6898 100644
--- a/clang/lib/Interpreter/Interpreter.cpp
+++ b/clang/lib/Interpreter/Interpreter.cpp
@@ -157,7 +157,7 @@ IncrementalCompilerBuilder::create(std::vector<const char *> &ClangArgv) {
   ParseDiagnosticArgs(*DiagOpts, ParsedArgs, &Diags);
Fri, May 14, 8:57 AM · Restricted Project

May 13 2021

v.g.vassilev abandoned D90998: Allow in-place compound statment body replacement.

Thanks to @Hahnfeld, that's not needed anymore.

May 13 2021, 9:24 AM
v.g.vassilev added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

@v.g.vassilev, the test does not appear to be appropriately set up for builds that default to a non-native target:
https://lab.llvm.org/staging/#/builders/126/builds/371/steps/5/logs/FAIL__Clang__execute_cpp

Can you fix or revert until there is a fix?

Apologies. Do you know if REQUIRES: native is sufficient to fix (trying to avoid churn)?

May 13 2021, 9:23 AM · Restricted Project
v.g.vassilev added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

@v.g.vassilev, the test does not appear to be appropriately set up for builds that default to a non-native target:
https://lab.llvm.org/staging/#/builders/126/builds/371/steps/5/logs/FAIL__Clang__execute_cpp

Can you fix or revert until there is a fix?

May 13 2021, 9:03 AM · Restricted Project
v.g.vassilev committed rG4624412367f9: [clang-repl] Fix ClangReplInterpreterTests unittest dependency. (authored by v.g.vassilev).
[clang-repl] Fix ClangReplInterpreterTests unittest dependency.
May 13 2021, 3:32 AM
v.g.vassilev committed rGb2186a69c169: [clang-repl] Add final set of missing library dependencies. (authored by v.g.vassilev).
[clang-repl] Add final set of missing library dependencies.
May 13 2021, 1:07 AM
v.g.vassilev committed rG3f4c5185926a: [clang-repl] Add exhaustive list of libInterpreter dependencies. (authored by v.g.vassilev).
[clang-repl] Add exhaustive list of libInterpreter dependencies.
May 13 2021, 12:21 AM

May 12 2021

v.g.vassilev committed rG92f9852fc99b: [clang-repl] Recommit "Land initial infrastructure for incremental parsing" (authored by v.g.vassilev).
[clang-repl] Recommit "Land initial infrastructure for incremental parsing"
May 12 2021, 11:31 PM
v.g.vassilev added a reverting change for rG44a4000181e1: [clang-repl] Land initial infrastructure for incremental parsing: rGf6907152db3d: Revert "[clang-repl] Land initial infrastructure for incremental parsing".
May 12 2021, 9:44 PM
v.g.vassilev committed rGf6907152db3d: Revert "[clang-repl] Land initial infrastructure for incremental parsing" (authored by v.g.vassilev).
Revert "[clang-repl] Land initial infrastructure for incremental parsing"
May 12 2021, 9:44 PM
v.g.vassilev added a reverting change for D96033: [clang-repl] Land initial infrastructure for incremental parsing: rGf6907152db3d: Revert "[clang-repl] Land initial infrastructure for incremental parsing".
May 12 2021, 9:44 PM · Restricted Project
v.g.vassilev added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

Thanks everybody for reviewing and help making this patch better!!

May 12 2021, 9:26 PM · Restricted Project
v.g.vassilev committed rG44a4000181e1: [clang-repl] Land initial infrastructure for incremental parsing (authored by v.g.vassilev).
[clang-repl] Land initial infrastructure for incremental parsing
May 12 2021, 9:25 PM
v.g.vassilev closed D96033: [clang-repl] Land initial infrastructure for incremental parsing.
May 12 2021, 9:24 PM · Restricted Project
v.g.vassilev updated the diff for D96033: [clang-repl] Land initial infrastructure for incremental parsing.

clang-tidy and clang-format

May 12 2021, 1:29 PM · Restricted Project
v.g.vassilev committed rG99d63ccff04b: Add type information to integral template argument if required. (authored by reikdas).
Add type information to integral template argument if required.
May 12 2021, 12:00 PM
v.g.vassilev closed D77598: Integral template argument suffix and cast printing.
May 12 2021, 12:00 PM · Restricted Project, Restricted Project

May 5 2021

v.g.vassilev added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

Thanks, @teemperor. I have addressed your last comments, too.

May 5 2021, 9:22 AM · Restricted Project
v.g.vassilev updated the diff for D96033: [clang-repl] Land initial infrastructure for incremental parsing.
  • Check if we can use death tests;
  • Do not install clang-repl as being an early stage development.
May 5 2021, 3:22 AM · Restricted Project

May 3 2021

v.g.vassilev added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

Sorry for the delay. I think all my points have been resolved beside the insertion SourceLoc.

May 3 2021, 11:48 AM · Restricted Project
v.g.vassilev updated the diff for D96033: [clang-repl] Land initial infrastructure for incremental parsing.

Address source location comment of teemperor.

May 3 2021, 11:47 AM · Restricted Project

May 1 2021

v.g.vassilev committed rG8518742104ab: Fix type printing of array template args (authored by reikdas).
Fix type printing of array template args
May 1 2021, 11:53 AM
v.g.vassilev closed D36368: Fix type printing of array template args.
May 1 2021, 11:53 AM · Restricted Project, Restricted Project

Apr 28 2021

v.g.vassilev added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

@rsmith ping2...

Apr 28 2021, 1:35 PM · Restricted Project

Apr 22 2021

v.g.vassilev added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

@rsmith ping...

Apr 22 2021, 3:20 AM · Restricted Project

Apr 18 2021

v.g.vassilev added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

@teemperor, could you take another look at this patch -- I believe most of your concerns are addressed now.

Apr 18 2021, 6:21 AM · Restricted Project

Apr 16 2021

v.g.vassilev added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

Would it make sense to have each Decl point to its owning PTU, similarly to what we do for the owning module (Decl::getOwningModule)?

I think that's the interface we want, but actually storing the PTU in every Decl that way is probably prohibitive in memory overhead; we need some more compact way to recover it. But maybe it's okay to do something like that if we can spare a bit in Decl. Richard, thoughts here?

Apr 16 2021, 1:10 PM · Restricted Project
v.g.vassilev added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

Thank you for the details -- will be really useful to me and that architecture will define away several hard problems we tried to solve over the years.

Apr 16 2021, 12:14 PM · Restricted Project
v.g.vassilev accepted D100590: DeclContext: Fix iterator category.

Nice catch! Thanks!

Apr 16 2021, 4:41 AM · Restricted Project, Restricted Project, Restricted Project

Apr 10 2021

v.g.vassilev added a comment to D36368: Fix type printing of array template args.

ping...

Apr 10 2021, 5:42 AM · Restricted Project, Restricted Project
v.g.vassilev added a comment to D37797: Fix crash in Sema when wrongly assuming VarDecl init is not value dependent..

@teemperor, should we land this?

Apr 10 2021, 12:02 AM
v.g.vassilev added a comment to D50763: [Parser] Refactor and fix bugs in late-parsing.

@hamzasood, I suppose this is still worth pursuing. Could you address the comment?

Apr 10 2021, 12:01 AM · Restricted Project

Apr 9 2021

v.g.vassilev added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

@rjmccall, @rsmith, ping...

Apr 9 2021, 1:26 PM · Restricted Project

Mar 31 2021

v.g.vassilev added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

We probably need to talk about it.

+1. Do you use discord/slack/skype?

Mar 31 2021, 12:41 AM · Restricted Project

Mar 19 2021

v.g.vassilev updated subscribers of D98560: [RuntimeDyld] Fix range checks for R_X86_64_{8,16}.

Adding Jonas as our Arm JIT expert (as per https://github.com/cms-sw/cmssw/issues/31123)

Mar 19 2021, 12:03 PM · Restricted Project

Mar 18 2021

v.g.vassilev added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

I'm nervous in general about the looming idea of declaration unloading, but the fact that it's been working in Cling for a long time gives me some confidence that we can do that in a way that's not prohibitively expensive and invasive.

I don't really know the jargon here.

"Code unloading" is mentioned here https://reviews.llvm.org/D96033?id=323531#inline-911819

I see. So you want to be able to sort of "roll back" Sema to a previous version of the semantic state, and yet you also need IRGen to *not* be rolled back because of lazy emission.

Mar 18 2021, 7:32 AM · Restricted Project

Mar 17 2021

v.g.vassilev added a comment to D91524: Make iteration over the DeclContext::lookup_result safe..

argh... I only now see the pre-merge suggestions -- almost all of them seem not super essential -- let me know if I should address them in a subsequent commit...

Mar 17 2021, 2:09 AM · Restricted Project, Restricted Project, Restricted Project
v.g.vassilev committed rG0cb7e7ca0c86: Make iteration over the DeclContext::lookup_result safe. (authored by v.g.vassilev).
Make iteration over the DeclContext::lookup_result safe.
Mar 17 2021, 2:00 AM
v.g.vassilev closed D91524: Make iteration over the DeclContext::lookup_result safe..
Mar 17 2021, 2:00 AM · Restricted Project, Restricted Project, Restricted Project
v.g.vassilev added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

I'm nervous in general about the looming idea of declaration unloading, but the fact that it's been working in Cling for a long time gives me some confidence that we can do that in a way that's not prohibitively expensive and invasive.

I don't really know the jargon here.

Mar 17 2021, 12:55 AM · Restricted Project

Mar 13 2021

v.g.vassilev updated the diff for D96033: [clang-repl] Land initial infrastructure for incremental parsing.

Formatting.

Mar 13 2021, 12:47 AM · Restricted Project

Mar 12 2021

v.g.vassilev added inline comments to D96033: [clang-repl] Land initial infrastructure for incremental parsing.
Mar 12 2021, 3:05 PM · Restricted Project
v.g.vassilev updated the diff for D96033: [clang-repl] Land initial infrastructure for incremental parsing.

Address comments -- rename test file; add a logging diagnostic consumer.

Mar 12 2021, 3:05 PM · Restricted Project

Mar 11 2021

v.g.vassilev updated the diff for D96033: [clang-repl] Land initial infrastructure for incremental parsing.

Address most of the formatting suggestions.

Mar 11 2021, 2:39 AM · Restricted Project
v.g.vassilev updated the diff for D91524: Make iteration over the DeclContext::lookup_result safe..

Add changes proposed by @rsmith, add an assertion for duplicate entries.

Mar 11 2021, 1:40 AM · Restricted Project, Restricted Project, Restricted Project

Mar 9 2021

v.g.vassilev updated the diff for D96033: [clang-repl] Land initial infrastructure for incremental parsing.
  • Do not rely on process exit code for --host-supports-jit but parse the true/false flag.
Mar 9 2021, 12:27 AM · Restricted Project

Mar 8 2021

v.g.vassilev updated the diff for D96033: [clang-repl] Land initial infrastructure for incremental parsing.

Add a lit feature to check if llvm has jit support to selectively run tests.

Mar 8 2021, 1:50 PM · Restricted Project

Feb 23 2021

v.g.vassilev added inline comments to D96033: [clang-repl] Land initial infrastructure for incremental parsing.
Feb 23 2021, 4:27 AM · Restricted Project

Feb 22 2021

v.g.vassilev updated the diff for D91524: Make iteration over the DeclContext::lookup_result safe..

Adjust the two tests I failed to merge.

Feb 22 2021, 3:22 PM · Restricted Project, Restricted Project, Restricted Project
v.g.vassilev updated the diff for D91524: Make iteration over the DeclContext::lookup_result safe..

More fixes suggested by @rsmith

Feb 22 2021, 3:03 PM · Restricted Project, Restricted Project, Restricted Project

Feb 20 2021

v.g.vassilev added inline comments to D96033: [clang-repl] Land initial infrastructure for incremental parsing.
Feb 20 2021, 2:45 PM · Restricted Project
v.g.vassilev updated the diff for D96033: [clang-repl] Land initial infrastructure for incremental parsing.

Address Lang's comments.

Feb 20 2021, 2:44 PM · Restricted Project
v.g.vassilev updated the diff for D91524: Make iteration over the DeclContext::lookup_result safe..

Make visitation of multiversion functions independent on the lookup ordering; adjust tests.

Feb 20 2021, 10:30 AM · Restricted Project, Restricted Project, Restricted Project

Feb 19 2021

v.g.vassilev updated the diff for D91524: Make iteration over the DeclContext::lookup_result safe..

Address some of Richard's comments.

Feb 19 2021, 3:28 PM · Restricted Project, Restricted Project, Restricted Project
v.g.vassilev added inline comments to D96033: [clang-repl] Land initial infrastructure for incremental parsing.
Feb 19 2021, 12:54 PM · Restricted Project
v.g.vassilev updated the diff for D96033: [clang-repl] Land initial infrastructure for incremental parsing.

Address comments from Raphael and Stefan.

Feb 19 2021, 12:53 PM · Restricted Project

Feb 17 2021

v.g.vassilev committed rWdc5c745fa34b: [GSoC] Remove desirable skills duplicate. (authored by v.g.vassilev).
[GSoC] Remove desirable skills duplicate.
Feb 17 2021, 7:15 AM
v.g.vassilev committed rWbcb3db843e44: [GSoC] Add GSoC 2021 projects (authored by v.g.vassilev).
[GSoC] Add GSoC 2021 projects
Feb 17 2021, 7:15 AM

Feb 16 2021

v.g.vassilev added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

Hi Stefan,

Feb 16 2021, 12:27 PM · Restricted Project

Feb 13 2021

v.g.vassilev added inline comments to D96033: [clang-repl] Land initial infrastructure for incremental parsing.
Feb 13 2021, 12:41 AM · Restricted Project
v.g.vassilev added inline comments to D96033: [clang-repl] Land initial infrastructure for incremental parsing.
Feb 13 2021, 12:25 AM · Restricted Project
v.g.vassilev updated the diff for D96033: [clang-repl] Land initial infrastructure for incremental parsing.

Address more review comments.

Feb 13 2021, 12:25 AM · Restricted Project

Feb 5 2021

v.g.vassilev added a reviewer for D96033: [clang-repl] Land initial infrastructure for incremental parsing: hfinkel.
Feb 5 2021, 8:58 AM · Restricted Project

Feb 4 2021

v.g.vassilev added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

@teemperor, thanks for the hints.

Feb 4 2021, 12:28 PM · Restricted Project
v.g.vassilev updated the diff for D96033: [clang-repl] Land initial infrastructure for incremental parsing.

Address comments.

Feb 4 2021, 12:28 PM · Restricted Project
v.g.vassilev requested review of D96033: [clang-repl] Land initial infrastructure for incremental parsing.
Feb 4 2021, 6:31 AM · Restricted Project

Jan 26 2021

v.g.vassilev added inline comments to D91524: Make iteration over the DeclContext::lookup_result safe..
Jan 26 2021, 11:55 AM · Restricted Project, Restricted Project, Restricted Project
v.g.vassilev updated the diff for D91524: Make iteration over the DeclContext::lookup_result safe..

Address most of the comments.

Jan 26 2021, 11:14 AM · Restricted Project, Restricted Project, Restricted Project

Jan 5 2021

v.g.vassilev committed rG02eb8e20b51b: Inform the consumer on invalid template instantiations. (authored by v.g.vassilev).
Inform the consumer on invalid template instantiations.
Jan 5 2021, 1:44 AM
v.g.vassilev closed D92248: Inform the consumer on invalid template instantiations..
Jan 5 2021, 1:43 AM · Restricted Project

Jan 3 2021

v.g.vassilev updated the diff for D91524: Make iteration over the DeclContext::lookup_result safe..

Add documentation, resolve address comments, update in-tree clients.

Jan 3 2021, 12:34 AM · Restricted Project, Restricted Project, Restricted Project

Dec 12 2020

v.g.vassilev updated the diff for D91524: Make iteration over the DeclContext::lookup_result safe..

Minor typos, conciseness..

Dec 12 2020, 2:14 AM · Restricted Project, Restricted Project, Restricted Project

Dec 11 2020

v.g.vassilev updated the diff for D91524: Make iteration over the DeclContext::lookup_result safe..

Store current state, address some comments, a few bugs still to address...

Dec 11 2020, 1:49 PM · Restricted Project, Restricted Project, Restricted Project

Dec 8 2020

v.g.vassilev updated the diff for D91524: Make iteration over the DeclContext::lookup_result safe..

Upload the current changes. I need to update the users such as lldb, clang-tools-extra and clangd. It has some rough edges wrt modules.

Dec 8 2020, 7:59 AM · Restricted Project, Restricted Project, Restricted Project

Nov 27 2020

v.g.vassilev requested review of D92248: Inform the consumer on invalid template instantiations..
Nov 27 2020, 2:09 PM · Restricted Project
Herald added a project to D57018: Fix lvm::is_trivially_copyable portability issues: Restricted Project.
Nov 27 2020, 1:59 PM · Restricted Project

Nov 21 2020

v.g.vassilev added inline comments to D91524: Make iteration over the DeclContext::lookup_result safe..
Nov 21 2020, 3:29 PM · Restricted Project, Restricted Project, Restricted Project
v.g.vassilev updated the diff for D91524: Make iteration over the DeclContext::lookup_result safe..

Invert the diff, fix a typo.

Nov 21 2020, 3:20 PM · Restricted Project, Restricted Project, Restricted Project
v.g.vassilev updated the diff for D91524: Make iteration over the DeclContext::lookup_result safe..

Take another approach at solving this issue. Instead we are making the lookup_result safe.

Nov 21 2020, 3:14 PM · Restricted Project, Restricted Project, Restricted Project

Nov 16 2020

v.g.vassilev committed rG54e655b3f8dc: Reland "Move the test compiler setup in a common place. NFCI" (authored by v.g.vassilev).
Reland "Move the test compiler setup in a common place. NFCI"
Nov 16 2020, 5:23 AM
v.g.vassilev closed D91061: Move the test compiler setup in a common place. NFCI.
Nov 16 2020, 5:23 AM · Restricted Project
v.g.vassilev requested review of D91524: Make iteration over the DeclContext::lookup_result safe..
Nov 16 2020, 2:48 AM · Restricted Project, Restricted Project, Restricted Project

Nov 14 2020

v.g.vassilev added a comment to D54986: Make CodeGen choose when to emit vtables..

@rsmith, what was the fate of this patch? I thought it landed but cannot find a trace of it in the master...

Nov 14 2020, 3:16 PM
v.g.vassilev closed D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute.

Landed in aca191cce1c4dbab28a65cfe4caa6348e698a2b3

Nov 14 2020, 3:09 PM · Restricted Project
v.g.vassilev abandoned D34912: Handle cases where the value is too large to fit into the underlying type..

Closing this in favor of D77598

Nov 14 2020, 3:02 PM
v.g.vassilev abandoned D53925: [modules] Defer emission of inline key functions..

Landed as D54986

Nov 14 2020, 3:00 PM
v.g.vassilev committed rG23cc838099e1: Add forgotten in 888d06d file. (authored by v.g.vassilev).
Add forgotten in 888d06d file.
Nov 14 2020, 1:33 PM
v.g.vassilev committed rG888d06dfb8b5: Move the test compiler setup in a common place. NFCI (authored by v.g.vassilev).
Move the test compiler setup in a common place. NFCI
Nov 14 2020, 1:31 PM