- User Since
- Apr 21 2016, 7:16 AM (323 w, 6 d)
Sun, Jul 3
Let's move forward and we can remove the XFAIL once https://reviews.llvm.org/D128968 lands.
Sat, Jul 2
I am adding some more reviewers as I think this patch is ready to go.
Fri, Jul 1
Wed, Jun 29
Thanks for the clarification! LGTM.
Looks good to me but can we add a test? Do we have builders with that target?
Tue, Jun 28
Historically, the patch was developed before the extended support of virtual files in Clang. Given that this is very hard to test and it looks like this is not needed on our end anymore. I'd propose to pause this for now.
Mon, Jun 27
This landed slightly modified here: https://github.com/llvm/llvm-project/commit/4d54e543abd5d0a8b0a321f8c292252f4895693a
Sun, Jun 26
Sat, Jun 25
According to godbolt this example does not crash anymore.
I think this landed in a different form.
LGTM, modulo the comment.
After landing https://reviews.llvm.org/D126682 we might be able to write a test in clang-repl such as:
I think this patch is not needed in the main branch as https://github.com/llvm/llvm-project/commit/f91b6f8159b101688eef87c75179209699c0d405 removes the need of calling invalidateCache altogether.
Can we write a test for this?
Thanks for working on this. Here are some more comments.
Fri, Jun 24
@t184256, do we still need this? Should I commit it in case you don't have commit access?
I'd propose to move forward here and rely on eventual post-commit review.
Fri, Jun 17
Tue, Jun 14
Let's move forward with this and rely on eventual post-commit review.
I think we are in a good shape to broaden the list of reviewers.
Sun, Jun 12
Thu, Jun 9
Wed, Jun 8
Jun 6 2022
This looks reasonable to me...
This looks good to me, modulo the inline comment.
Jun 3 2022
Jun 2 2022
Thanks for the prompt reply.
Jun 1 2022
May 30 2022
This patch fixes our test case which we intended to fix with:
From 17e94a6a2adc3eb8d5fcc532eb1f3e57cc59b0fd Mon Sep 17 00:00:00 2001 From: Vassil Vassilev <email@example.com> Date: Mon, 23 May 2022 21:36:43 +0000 Subject: [PATCH] Fix type printing to not include the suffix when not needed.
May 29 2022
May 28 2022
This is not an issue anymore for us.
@Purva-Chaudhari, can you rebase this patch, seems that it is not buildable.
@Purva-Chaudhari, this looks reasonable to me. I am adding more reviewers to discuss the way we refer other tests from clang-repl.
LGTM! Apologies for the delay.
May 27 2022
May 23 2022
Just to add that the invalidateCache is important for cling and clang-repl where we do something like:
Apr 13 2022
Mar 28 2022
Thanks for the clarification! LGTM!
Mar 11 2022
Mar 10 2022
Order fwd decls alphabetically.
Feb 21 2022
Feb 20 2022
Feb 17 2022
Feb 13 2022
Feb 12 2022
That change landed in 4fb0805c6525b13e50067b9ddfe8677a0b7b2d7c
Dec 15 2021
Dec 1 2021
Nov 30 2021
Nov 10 2021
Address comments and fix the windows bot failure.
Nov 5 2021
Nov 1 2021
Oct 29 2021
Oct 28 2021
Oct 27 2021
Oct 26 2021
Oct 8 2021
Oct 7 2021
Thanks for the patch!
Can you map state_not_recoverable to not_supported?