- User Since
- Apr 21 2016, 7:16 AM (360 w, 6 d)
Tue, Mar 14
Tue, Feb 28
Fri, Feb 24
Thu, Feb 23
Tue, Feb 21
Feb 17 2023
This seems like a good candidate for a post commit review.
Feb 15 2023
Feb 14 2023
We should probably add some tests here. Alternatively we can add the tests from https://reviews.llvm.org/D143148 but that'd make this patch bulkier and probably harder to review.
Feb 10 2023
Feb 9 2023
Feb 7 2023
Feb 6 2023
Jan 28 2023
Jan 24 2023
Jan 20 2023
Added a testcase by Sunho!
Jan 19 2023
Jan 18 2023
Jan 17 2023
Jan 14 2023
Jan 13 2023
Thanks a lot @rsmith for providing a fix and thanks a lot @aaron.ballman and @erichkeane for the efforts saving @mizvekov work over the summer. I believe he has sporadic access to internet and soon he will be back to normal. Great example of team work here!!
Jan 12 2023
Dec 14 2022
Dec 11 2022
Dec 5 2022
Latest test run: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/48911/execution/node/74/log/
I modified the expected string slightly to make it work: https://reviews.llvm.org/rG811ad246ac7b
Should be all good now. Thanks for looking into this!
Dec 4 2022
UPDATE: fails with clean build too
Might be best to revert it for now while we figure out what's wrong
Dec 3 2022
Dec 2 2022
Dec 1 2022
Fixed the diff. I accidentally have added the commits from https://reviews.llvm.org/D139016
I screwed up with the last diff. Let me fix it in a bit...
Address comments, fix a fixme.
Nov 30 2022
I have modified it a little before landing it to capture better the intent and our off-list conversation.
Nov 28 2022
Sorry, selected the wrong option. This looks good to me. I can commit that change for you as I know you do not have commit access.
This looks good to me. I can commit that change for you as I know you do not have commit access.
I think I have addressed all comments from @aaron.ballman and @rsmith.
Nov 22 2022
Teach CodeGen to squash contiguous top-level stmt decl blocks into a single llvm::Function. Rebase.
Address comments, support better C in clang-repl.
Nov 17 2022
Nov 15 2022
Rebase + fix the failure on windows
Nov 14 2022
Usually @rsmith has something up in the sleeve in these situations ;)
Nov 6 2022
Remove several fixmes. Now we can deal with templates, deduction guides and operators.
Address comments. Call isCurrentClassName before calling isConstructorDeclarator.
Nov 3 2022
This LGTM but I'd like to add reviewers who changed this area recently.
Nov 2 2022
Address more comments.
Nov 1 2022
Sep 28 2022
This looks reasonable to me but let's have another pair of eyes.
Sep 27 2022
Sep 25 2022
Sep 3 2022
Address review comments
Sep 1 2022
Adding Aaron as a reviewer who hopefully could speed up the review.
Aug 25 2022
Let's move forward with this patch and rely on a post-commit review if necessary.
Aug 18 2022
Thanks for working on this! I left some comments. I did not look very deep in the patch but it seems quite consistent to the rest of the code in Sema.
Aug 11 2022
Aug 9 2022
Aug 5 2022
Maybe we can add a little more context. In the case of static compilation the file system is pretty much read-only and taking a snapshot of it usually is sufficient. In the interactive C++ case the compilation is longer and people can create and include files, etc. In that case we often do not want to open files or cache failures unless is absolutely necessary. We might be able to write a test for this in clang/unittests/Lex/HeaderSearchTest.cpp. However, this patch improves consistency in the interfaces by forwarding the already provided flags to the callees and if we cannot write a reasonable test we should be able to accept it without.
Aug 1 2022
Rely on the CXXScopeSpec to detect more accurately if we are parsing a constructor declarator.