This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Rewrite CheckInvalidVLENandLMUL to avoid floating point.
ClosedPublic

Authored by craig.topper on Aug 10 2023, 1:53 PM.

Details

Summary

This avoids needing an FP value to represent LMUL.

Diff Detail

Event Timeline

craig.topper created this revision.Aug 10 2023, 1:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2023, 1:53 PM
craig.topper requested review of this revision.Aug 10 2023, 1:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2023, 1:53 PM
4vtomat accepted this revision.Aug 11 2023, 4:45 AM

LGTM, thanks!

clang/lib/Sema/SemaChecking.cpp
4479

Does the EGS here mean the ElemCount?
If it does, can we change the EGS in the comment to other name, since when I first see this comment, I just thought the EGS here means the argument name lol~

This revision is now accepted and ready to land.Aug 11 2023, 4:45 AM

Revise coment, rename variable.

This revision was landed with ongoing or failed builds.Aug 12 2023, 11:18 AM
This revision was automatically updated to reflect the committed changes.