clang: Add elementwise bitreverse builtin

[bob80905]

Summary

Add codegen for llvm bitreverse elementwise builtin
The bitreverse elementwise builtin is necessary for HLSL codegen.
Tests were added to make sure that the expected errors are encountered when these functions are given inputs of incompatible types, or too many inputs.
The new builtin is restricted to integer types only.

[bob80905]

add attempt 1 commit

[bob80905]

• remove strictfp test, add cgbuiltin case and update test in codegen

[bob80905]

• remove tests that only test floating point inputs

[bob80905]

• apply clang-format on CGBuiltin.cpp

[arsenm]

clang/docs/LanguageExtensions.rst

634 ↗

(On Diff #544830)

Unrelated but I noticed a couple of the elementwise builtins are missing from this list if you're fixing up the docs for them. Can't remember which off the top of my head

clang/test/Sema/builtins-elementwise-math.c

272

Test the vector of float case?

[bob80905]

• add float4 test

clang/docs/LanguageExtensions.rst

634 ↗

(On Diff #544830)

Are you sure?
I double checked CGBuiltin.cpp and Builtins.def for all "builtin_elementwise*"'s, there's only the 24 listed here.

clang/lib/Sema/SemaChecking.cpp

if (!EltTy->isIntegerType()) {
           << 1 << /* integer ty */ 6 << ArgTy;
       return ExprError();
     }
     break;
   }
 
   case Builtin::BI__builtin_elementwise_min:
   case Builtin::BI__builtin_elementwise_max:
-  case Builtin::BI__builtin_elementwise_bitreverse:
     if (SemaBuiltinElementwiseMath(TheCall))
       return ExprError();
     break;
+
+  case Builtin::BI__builtin_elementwise_bitreverse: {
+    if (PrepareBuiltinElementwiseMathOneArgCall(TheCall))
+      return ExprError();
+
+    const Expr *Arg = TheCall->getArg(0);
+    QualType ArgTy = Arg->getType();
+    QualType EltTy = ArgTy;
+
+    if (auto *VecTy = EltTy->getAs<VectorType>())
+      EltTy = VecTy->getElementType();
+
+    if (!EltTy->isIntegerType()) {
+      Diag(Arg->getBeginLoc(), diag::err_builtin_invalid_arg_type)
+          << 1 << /* integer ty */ 6 << ArgTy;
+      return ExprError();
+    }
+    break;
+  }
+
   case Builtin::BI__builtin_elementwise_copysign: {
     if (checkArgCount(*this, TheCall, 2))
       return ExprError();
 
     ExprResult Magnitude = UsualUnaryConversions(TheCall->getArg(0));
     ExprResult Sign = UsualUnaryConversions(TheCall->getArg(1));
     if (Magnitude.isInvalid() || Sign.isInvalid())
       return ExprError();

clang/test/Sema/builtins-elementwise-math.c

void test_builtin_elementwise_min(int i, short s, double d, float4 v, int3 iv, unsigned3 uv, int *p) {
   int j;
   j = __builtin_elementwise_min(i, j);
 
   _Complex float c1, c2;
   c1 = __builtin_elementwise_min(c1, c2);
   // expected-error@-1 {{1st argument must be a vector, integer or floating point type (was '_Complex float')}}
 }
 
 void test_builtin_elementwise_bitreverse(int i, float f, double d, float4 v, int3 iv, unsigned u, unsigned4 uv) {
 
   struct Foo s = __builtin_elementwise_ceil(f);
   // expected-error@-1 {{initializing 'struct Foo' with an expression of incompatible type 'float'}}
 
   i = __builtin_elementwise_bitreverse();
   // expected-error@-1 {{too few arguments to function call, expected 1, have 0}}
 
   i = __builtin_elementwise_bitreverse(f);
-  // expected-error@-1 {{1st argument must be a integer type (was 'float')}}
+  // expected-error@-1 {{1st argument must be a vector of integers (was 'float')}}
   
   i = __builtin_elementwise_bitreverse(f, f);
   // expected-error@-1 {{too many arguments to function call, expected 1, have 2}}
 
   u = __builtin_elementwise_bitreverse(d);
-  // expected-error@-1 {{1st argument must be a integer type (was 'double')}}
+  // expected-error@-1 {{1st argument must be a vector of integers (was 'double')}}
 }
 
 void test_builtin_elementwise_ceil(int i, float f, double d, float4 v, int3 iv, unsigned u, unsigned4 uv) {
 
   struct Foo s = __builtin_elementwise_ceil(f);
   // expected-error@-1 {{initializing 'struct Foo' with an expression of incompatible type 'float'}}
 
   i = __builtin_elementwise_ceil();