Page MenuHomePhabricator

bob80905 (Joshua Batista)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 3 2022, 6:08 PM (17 w, 1 d)

Recent Activity

Yesterday

bob80905 requested review of D139137: add floor library function.
Thu, Dec 1, 12:36 PM · Restricted Project, Restricted Project

Wed, Nov 16

bob80905 retitled D138161: [HLSL] add sin library function from add sin library function to [HLSL] add sin library function.
Wed, Nov 16, 4:22 PM · Restricted Project, Restricted Project
bob80905 updated the diff for D138161: [HLSL] add sin library function.

[HLSL] add cos library function

Wed, Nov 16, 4:21 PM · Restricted Project, Restricted Project
bob80905 requested review of D138161: [HLSL] add sin library function.
Wed, Nov 16, 4:19 PM · Restricted Project, Restricted Project
bob80905 updated the diff for D134921: [HLSL] add cos library function.
  • clang format
Wed, Nov 16, 10:08 AM · Restricted Project, Restricted Project

Tue, Nov 15

bob80905 updated the diff for D134921: [HLSL] add cos library function.
  • remove int overloads
  • remove double
  • update tests after new builtin landed
Tue, Nov 15, 4:53 PM · Restricted Project, Restricted Project

Thu, Nov 10

bob80905 updated the diff for D135011: Add builtin_elementwise_sin and builtin_elementwise_cos.
  • add dependency on architecture before testing
Thu, Nov 10, 4:16 PM · Restricted Project, Restricted Project
bob80905 updated the diff for D135011: Add builtin_elementwise_sin and builtin_elementwise_cos.
  • make format change
Thu, Nov 10, 10:16 AM · Restricted Project, Restricted Project

Wed, Nov 9

bob80905 added a comment to D135011: Add builtin_elementwise_sin and builtin_elementwise_cos.

Ping

Wed, Nov 9, 11:38 AM · Restricted Project, Restricted Project

Wed, Nov 2

bob80905 added a comment to D135011: Add builtin_elementwise_sin and builtin_elementwise_cos.

Ping

Wed, Nov 2, 10:10 AM · Restricted Project, Restricted Project

Oct 26 2022

bob80905 added a comment to D135011: Add builtin_elementwise_sin and builtin_elementwise_cos.

Ping

Oct 26 2022, 10:26 AM · Restricted Project, Restricted Project

Oct 19 2022

bob80905 added a comment to D135011: Add builtin_elementwise_sin and builtin_elementwise_cos.

Ping, could someone please take a look?

Oct 19 2022, 10:12 AM · Restricted Project, Restricted Project

Oct 12 2022

bob80905 updated the diff for D135011: Add builtin_elementwise_sin and builtin_elementwise_cos.
  • drop llvm from release notes description.
Oct 12 2022, 11:05 AM · Restricted Project, Restricted Project
bob80905 added a comment to D135011: Add builtin_elementwise_sin and builtin_elementwise_cos.

Ping

Oct 12 2022, 10:40 AM · Restricted Project, Restricted Project

Oct 11 2022

bob80905 added inline comments to D135721: [HLSL] Added HLSL this as a reference.
Oct 11 2022, 3:44 PM · Restricted Project, Restricted Project

Oct 5 2022

bob80905 updated the diff for D135011: Add builtin_elementwise_sin and builtin_elementwise_cos.
  • shorten builtin description, group sin and cos
Oct 5 2022, 10:09 AM · Restricted Project, Restricted Project

Oct 4 2022

bob80905 updated the diff for D135011: Add builtin_elementwise_sin and builtin_elementwise_cos.
  • add new line to end of new files
Oct 4 2022, 5:26 PM · Restricted Project, Restricted Project
bob80905 updated the diff for D135011: Add builtin_elementwise_sin and builtin_elementwise_cos.
  • add sve tests to prove compiler doesn't crash
Oct 4 2022, 5:24 PM · Restricted Project, Restricted Project
bob80905 added a comment to D135011: Add builtin_elementwise_sin and builtin_elementwise_cos.

Here is the code I used to test the machine code output:

Oct 4 2022, 1:20 PM · Restricted Project, Restricted Project
bob80905 added a comment to D135011: Add builtin_elementwise_sin and builtin_elementwise_cos.

Does these support scalable vector types from ARM SVE or RISC-V? I can't remember what the rest of the __builtin_elementwise do. I ask because the backends will probably crash for them.

Oct 4 2022, 1:04 PM · Restricted Project, Restricted Project

Oct 3 2022

bob80905 retitled D135011: Add builtin_elementwise_sin and builtin_elementwise_cos from Add sin and cos llvm builtins to Add builtin_elementwise_sin and builtin_elementwise_cos.
Oct 3 2022, 4:42 PM · Restricted Project, Restricted Project
bob80905 updated the diff for D135011: Add builtin_elementwise_sin and builtin_elementwise_cos.
  • add release note
Oct 3 2022, 11:01 AM · Restricted Project, Restricted Project
bob80905 updated the summary of D135011: Add builtin_elementwise_sin and builtin_elementwise_cos.
Oct 3 2022, 10:54 AM · Restricted Project, Restricted Project
bob80905 updated the diff for D135011: Add builtin_elementwise_sin and builtin_elementwise_cos.
  • add docs, add new line
Oct 3 2022, 10:51 AM · Restricted Project, Restricted Project
bob80905 retitled D135011: Add builtin_elementwise_sin and builtin_elementwise_cos from Add sin and cos llvm intrinsics to Add sin and cos llvm builtins.
Oct 3 2022, 10:30 AM · Restricted Project, Restricted Project
bob80905 updated the diff for D135011: Add builtin_elementwise_sin and builtin_elementwise_cos.

run git clang-format on changes rather than whole document

Oct 3 2022, 10:25 AM · Restricted Project, Restricted Project

Sep 30 2022

bob80905 updated the diff for D135011: Add builtin_elementwise_sin and builtin_elementwise_cos.
  • make format consistent, update test copy mistake
Sep 30 2022, 10:21 PM · Restricted Project, Restricted Project
bob80905 updated the diff for D135011: Add builtin_elementwise_sin and builtin_elementwise_cos.

rever format commit

Sep 30 2022, 10:18 PM · Restricted Project, Restricted Project
bob80905 requested review of D135011: Add builtin_elementwise_sin and builtin_elementwise_cos.
Sep 30 2022, 10:15 PM · Restricted Project, Restricted Project
bob80905 updated the diff for D134921: [HLSL] add cos library function.

revert revision, remove int overloads

Sep 30 2022, 5:40 PM · Restricted Project, Restricted Project
bob80905 removed a reviewer for D134921: [HLSL] add cos library function: aaron.ballman.
Sep 30 2022, 5:16 PM · Restricted Project, Restricted Project
bob80905 added a reviewer for D134921: [HLSL] add cos library function: aaron.ballman.
Sep 30 2022, 4:17 PM · Restricted Project, Restricted Project
bob80905 updated the diff for D134921: [HLSL] add cos library function.
  • lower cos to llvm
Sep 30 2022, 4:12 PM · Restricted Project, Restricted Project
bob80905 updated the diff for D134921: [HLSL] add cos library function.
  • remove double
Sep 30 2022, 2:40 PM · Restricted Project, Restricted Project

Sep 29 2022

bob80905 updated the diff for D134921: [HLSL] add cos library function.
  • remove int overloads
Sep 29 2022, 4:33 PM · Restricted Project, Restricted Project
bob80905 requested review of D134921: [HLSL] add cos library function.
Sep 29 2022, 4:20 PM · Restricted Project, Restricted Project
bob80905 updated the diff for D134319: [HLSL] add ceil library function.
  • got clang-format working on VS2022
Sep 29 2022, 10:41 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 28 2022

bob80905 updated the diff for D134319: [HLSL] add ceil library function.
  • whitespace try 2
Sep 28 2022, 5:06 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bob80905 updated the diff for D134319: [HLSL] add ceil library function.
  • adhere to clang format
Sep 28 2022, 3:13 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 21 2022

bob80905 removed reviewers for D134319: [HLSL] add ceil library function: antiagainst, nicolasvasilache, aartbik, sscalpone, dcaballe.
Sep 21 2022, 10:09 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 20 2022

bob80905 updated the diff for D134319: [HLSL] add ceil library function.

fix attempt 2

Sep 20 2022, 4:09 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bob80905 updated the diff for D134319: [HLSL] add ceil library function.

fix attempt 1

Sep 20 2022, 4:03 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bob80905 updated the diff for D134319: [HLSL] add ceil library function.
  • add elementwise function tests
  • remove int attribute links in hlsl_intrinsics.h
  • rebase
Sep 20 2022, 3:53 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bob80905 updated the summary of D134319: [HLSL] add ceil library function.
Sep 20 2022, 3:26 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bob80905 added reviewers for D134319: [HLSL] add ceil library function: pow2clk, python3kgae.
Sep 20 2022, 3:24 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bob80905 updated the diff for D134319: [HLSL] add ceil library function.
  • remove int attribute links in hlsl_intrinsics.h
Sep 20 2022, 3:11 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bob80905 updated the diff for D134319: [HLSL] add ceil library function.
  • add elementwise function tests. Remove integer tests, ceil will not take integer types as an arg
Sep 20 2022, 3:08 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bob80905 requested review of D134319: [HLSL] add ceil library function.
Sep 20 2022, 2:42 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bob80905 requested review of D134312: [HLSL] remove unnecessary abs attributes.
Sep 20 2022, 1:56 PM · Restricted Project, Restricted Project
bob80905 updated the diff for D132711: [HLSL] add sqrt library function.
  • add empty line to end of file sqrt.hlsl
Sep 20 2022, 1:17 PM · Restricted Project, Restricted Project
bob80905 updated the diff for D132711: [HLSL] add sqrt library function.

Include previous commit

Sep 20 2022, 12:16 PM · Restricted Project, Restricted Project
bob80905 abandoned D133438: change SM target to 6.2, that's when fnative-half-type was introduced.
Sep 20 2022, 12:13 PM · Restricted Project, Restricted Project
bob80905 updated the diff for D133438: change SM target to 6.2, that's when fnative-half-type was introduced.
  • merge hlsl_intr.h
Sep 20 2022, 12:12 PM · Restricted Project, Restricted Project
bob80905 abandoned D134297: [HLSL] add sqrt library function.
Sep 20 2022, 12:03 PM · Restricted Project, Restricted Project
bob80905 added a reviewer for D134297: [HLSL] add sqrt library function: beanz.
Sep 20 2022, 11:50 AM · Restricted Project, Restricted Project
bob80905 requested review of D134297: [HLSL] add sqrt library function.
Sep 20 2022, 11:49 AM · Restricted Project, Restricted Project
bob80905 updated the diff for D132711: [HLSL] add sqrt library function.

add hlslintr.h file

Sep 20 2022, 11:30 AM · Restricted Project, Restricted Project
bob80905 updated the diff for D132711: [HLSL] add sqrt library function.

include both commits

Sep 20 2022, 11:24 AM · Restricted Project, Restricted Project

Sep 19 2022

bob80905 updated the diff for D132711: [HLSL] add sqrt library function.

rebase
rebasing review to latest origin/main.

Sep 19 2022, 4:18 PM · Restricted Project, Restricted Project

Sep 7 2022

bob80905 abandoned D133438: change SM target to 6.2, that's when fnative-half-type was introduced.
Sep 7 2022, 10:46 AM · Restricted Project, Restricted Project
bob80905 updated the diff for D132711: [HLSL] add sqrt library function.

Shader Model target update
Change the shader model target to 6.2, because that is when fnative-half-type was introduced.

Sep 7 2022, 10:45 AM · Restricted Project, Restricted Project
bob80905 requested review of D133438: change SM target to 6.2, that's when fnative-half-type was introduced.
Sep 7 2022, 10:43 AM · Restricted Project, Restricted Project

Aug 25 2022

bob80905 requested review of D132711: [HLSL] add sqrt library function.
Aug 25 2022, 5:21 PM · Restricted Project, Restricted Project

Aug 24 2022

bob80905 requested review of D132612: [HLSL] add asin library function.
Aug 24 2022, 2:47 PM · Restricted Project, Restricted Project
bob80905 abandoned D132597: remove scalar types lld and ld from test since hlsl won't support them.
Aug 24 2022, 2:42 PM · Restricted Project, Restricted Project
bob80905 updated the diff for D132589: [HLSL] Add acos library function.

remove scalar types lld and ld from test since hlsl won't support them

Aug 24 2022, 1:21 PM · Restricted Project, Restricted Project
bob80905 requested review of D132597: remove scalar types lld and ld from test since hlsl won't support them.
Aug 24 2022, 1:03 PM · Restricted Project, Restricted Project
bob80905 retitled D132589: [HLSL] Add acos library function from [HLSL] Add acos library function This change exposes the acos library function for HLSL scalar types, excluding long long doubles. Acos is supported for all scalar, vector, and matrix types. This patch only adds a subset of scalar type support. to [HLSL] Add acos library function.
Aug 24 2022, 12:16 PM · Restricted Project, Restricted Project
bob80905 requested review of D132589: [HLSL] Add acos library function.
Aug 24 2022, 12:15 PM · Restricted Project, Restricted Project
bob80905 added inline comments to D131718: [HLSL] Add abs library function.
Aug 24 2022, 10:00 AM · Restricted Project, Restricted Project
bob80905 added inline comments to D131718: [HLSL] Add abs library function.
Aug 24 2022, 9:54 AM · Restricted Project, Restricted Project