Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Paths

Table of Contentst

[RISCV] Enable more builtin for zvfhmin without zvfh
ClosedPublic
Actions

Authored by jacquesguan on Jun 1 2023, 2:03 AM.

Details

Reviewers

craig.topper
asb
luismarques
frasercrmck
michaelmaitland
eopXD

Commits

rG4d2536c82fc4: [RISCV] Enable more builtin for zvfhmin without zvfh

Summary

This patch enables some fp16 vector type builtins that don't use fp arithmetic instruction for zvfhmin without zvfh.
Include following builtins:

vector load/store,
vector reinterpret,
vmerge_vvm,
vmv_v.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

jacquesguan created this revision.Jun 1 2023, 2:03 AM

Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2023, 2:03 AM

Herald added subscribers: jobnoorman, luke, VincentWu and 24 others. · View Herald Transcript

jacquesguan requested review of this revision.Jun 1 2023, 2:03 AM

Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2023, 2:03 AM

Herald added subscribers: cfe-commits, • pcwang-thead, eopXD, MaskRay. · View Herald Transcript

jacquesguan added a parent revision: D150253: [RISCV] Add Zvfhmin extension for clang.Jun 1 2023, 2:03 AM

Harbormaster completed remote builds in B235767: Diff 527324.Jun 1 2023, 5:39 AM

craig.topper added a reviewer: eopXD.Jun 1 2023, 10:20 AM

I think the topic of this patch is not accurate. The compiler already support these intrinsics with zvfh specified. Implementing zvfhmin is relaxing the implementation and let some of the intrinsics available when only zvfhmin and not zvfm is specified. So I think we can adjust the patch description a bit.

I think you may relax the extension specified, which is currently zvfh, to using zvfhmin, under the existing test cases under clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated to verify your implementation.

rebase

Herald added subscribers: wangpc, sunshaoce. · View Herald TranscriptThu, Aug 24, 2:45 AM

jacquesguan retitled this revision from [RISCV] Support more builtin for zvfhmin. to [RISCV] Enable more builtin for zvfhmin without zvfh.Thu, Aug 24, 2:46 AM

jacquesguan edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B254581: Diff 553051.Thu, Aug 24, 3:05 AM

ping

LGTM

This revision is now accepted and ready to land.Thu, Sep 7, 1:13 PM

This revision was landed with ongoing or failed builds.Thu, Sep 7, 7:55 PM

Closed by commit rG4d2536c82fc4: [RISCV] Enable more builtin for zvfhmin without zvfh (authored by jacquesguan). · Explain Why

This revision was automatically updated to reflect the committed changes.

jacquesguan added a commit: rG4d2536c82fc4: [RISCV] Enable more builtin for zvfhmin without zvfh.