This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Naturally align internal global variables in the OpenMPIRBuilder
ClosedPublic

Authored by jhuber6 on May 12 2023, 10:11 AM.

Details

Summary

We use this helper to make several internal global variables during
codegen. currently we do not specify any alignment which allows the
alignment to be set incorrectly after some changes in how alignment was
handled. This patch explicitly aligns these variables to the natural
alignment as specified by the data layout

Fixes https://github.com/llvm/llvm-project/issues/62668

Diff Detail

Event Timeline

jhuber6 created this revision.May 12 2023, 10:11 AM
jhuber6 requested review of this revision.May 12 2023, 10:11 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 12 2023, 10:11 AM
This revision is now accepted and ready to land.May 12 2023, 10:13 AM
gchatelet accepted this revision.May 12 2023, 10:59 AM

You beat me to it :)
Thx for the fix.

quick question, did you try to build the openmp runtime as well to check if the tests still pass?

quick question, did you try to build the openmp runtime as well to check if the tests still pass?

I'm an OpenMP developer so I always have it built : ). Yes they still pass.

quick question, did you try to build the openmp runtime as well to check if the tests still pass?

I'm an OpenMP developer so I always have it built : ). Yes they still pass.

👍

This revision was landed with ongoing or failed builds.May 12 2023, 11:14 AM
This revision was automatically updated to reflect the committed changes.