This is an archive of the discontinued LLVM Phabricator instance.

[IR] Change shufflevector undef mask to poison
ClosedPublic

Authored by ManuelJBrito on Apr 25 2023, 3:36 PM.

Details

Summary

With this patch an undefined mask in a shufflevector will be printed as poison.
This change is done to support the new shufflevector semantics for undefined mask elements (see D148637).

Diff Detail

Event Timeline

ManuelJBrito created this revision.Apr 25 2023, 3:36 PM
Herald added a project: Restricted Project. · View Herald Transcript
ManuelJBrito requested review of this revision.Apr 25 2023, 3:36 PM
Herald added a reviewer: sstefan1. · View Herald Transcript
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
LiDongjin added inline comments.
llvm/include/llvm-c/Core.h
4088 ↗(On Diff #516957)

undefined to poison

nikic requested changes to this revision.Apr 26 2023, 12:33 AM

Could you please split the change to printing + the test updates from all the other changes? The code changes get lost in the large diff.

llvm/include/llvm-c/Core.h
4090 ↗(On Diff #516957)

This breaks C API compatibility without good cause. Either leave this name alone or add a function with the new name and mark this one as deprecated.

This revision now requires changes to proceed.Apr 26 2023, 12:33 AM

Could you please split the change to printing + the test updates from all the other changes? The code changes get lost in the large diff.

Yes, that makes sense. The internal representation can be addressed separately from the printing.

Split patch into print update and internal representation.

nikic accepted this revision.Apr 26 2023, 11:53 AM

LGTM assuming tests pass.

This revision is now accepted and ready to land.Apr 26 2023, 11:53 AM
This revision was landed with ongoing or failed builds.Apr 27 2023, 6:41 AM
This revision was automatically updated to reflect the committed changes.