- User Since
- Sep 8 2022, 2:21 AM (54 w, 4 d)
Mon, Sep 11
Remove changes to demangle test
Mon, Aug 28
Thanks!! The problem here is when we hit a non clobbering memPhi, we should just continue. Instead we are trying to cast it to a memUseOrDef which causes the failure.
Aug 18 2023
Update : fill mask with poison mask elem in shufflevector
Aug 17 2023
Aug 13 2023
I don't think doing phi-of-ops on the following is valid :
Aug 10 2023
Perhaps we could add this case as a check to OpIsSafeForPHIOfOps. While walking the operands we could check if they are used in an assume until we hit a dominator. Not sure this makes complete sense, but we already do something similar to prevent InstSimplify from code walking through non-dominating phis.
Aug 8 2023
Add assert, as per Alina's request.
This patch isn't really useful, the value will be moved to the correct congruence class regardless. Sorry for wasting your time.
Aug 7 2023
Aug 4 2023
Thanks for the review!
Aug 3 2023
Aug 1 2023
Jul 30 2023
Jul 28 2023
Jul 26 2023
Forgot to add the diff link to the commit message, closing manually.
Remove old checks.
Jul 24 2023
Minor simplifications and comment rewriting.
We don't need to check that the memPhi is in the same block to deem it unsafe.
A clobbering memPhi that doesn't strictly dominate the original access implies that there are different versions of memory reaching the load and that using the loaded value between iterations isn't safe.
Jul 23 2023
Jul 21 2023
Adding Guozhi Wei as a reviewer.
Jul 18 2023
Hello @aqjune thanks for the comments !! Some users of SimplifyDemandedVectorElts might need some more tweaking to prevent regressions for the cases you noted. I'll work on this as soon as I can!
Jul 17 2023
Jul 16 2023
Jul 14 2023
Jul 11 2023
Jul 3 2023
rebase & ping
Jul 1 2023
Jun 30 2023
Jun 29 2023
Uploaded the fixed tests by mistake.
Address @nikic 's comments.
Jun 26 2023
Jun 20 2023
Jun 19 2023
Cannot use poison for undefined part of result in SSE4A intrinsics.
Jun 16 2023
Jun 13 2023
Jun 11 2023
Completely drop alignment.
Jun 9 2023
May 18 2023
Adding some PowerPC folks to review the change in codegen for vec_promote.
AFAICT its OK to have the undefined values be poison.
May 16 2023
Remove redundant check
May 7 2023
May 6 2023
Hello Nemanja is the change in codegen for vec_promote OK?
May 3 2023
May 1 2023
This change is visible in clang in particular in codegen for the vec_promote builtin.
It now produces poison instead of undef for the undefined elements.
I think this is OK according to IBM's documentation[https://www.ibm.com/docs/en/epfz/5.3?topic=book-semantics]:
Apr 30 2023
Apr 28 2023
Apr 27 2023
- simplify wordings
- remove undef to poison recommendation
Apr 26 2023
Split patch into print update and internal representation.
Apr 25 2023
Apr 18 2023
Apr 17 2023
Thanks for the review! I'll simplify the masks.
Apr 14 2023
Any further comments @RKSimon ?
Apr 7 2023
Update to remove multiple uses of freeze poison.
I am unsure about the code style used in the 128 to 512 casts. Any comments are appreciated.
Mar 17 2023
Implementing the 128 to 512 casts by filling the rest of the vector with the same definition of a nondeterministic_value is not correct because :
Mar 10 2023
Reverted. I'll reassess what can be done here.