This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Rewrite all found class-based subroutines to functions
AcceptedPublic

Authored by wangpc on Apr 23 2023, 3:06 AM.

Details

Summary

In this patch, we rewrite all found class-based subroutines in
RISCV target to functions.

This can be considered as a test of D148915.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptApr 23 2023, 3:06 AM
pcwang-thead requested review of this revision.Apr 23 2023, 3:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 23 2023, 3:06 AM

Rewrite all found subroutines.

Herald added a project: Restricted Project. · View Herald TranscriptApr 23 2023, 8:31 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
pcwang-thead retitled this revision from [RISCV] Rewrite RVV-related class-based subroutines to functions to [RISCV] Rewrite all found class-based subroutines to functions.Apr 23 2023, 8:32 PM
pcwang-thead edited the summary of this revision. (Show Details)
pcwang-thead added a reviewer: kito-cheng.
pcwang-thead added a reviewer: eopXD.
llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td
703

Typo with the '? This also happens multiple times below.

llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td
703

No, it is by design. A single quote is added before ( to solve the grammar ambiguity between DAG and function call. The design may be changed however.
Please see https://discourse.llvm.org/t/tablegen-introduce-function-and-lambda/70160#h-13-function-call-5 also. :-)

pcwang-thead marked an inline comment as done.Apr 25 2023, 7:10 PM
This revision is now accepted and ready to land.Apr 25 2023, 7:11 PM
evandro removed a subscriber: evandro.Jun 12 2023, 2:32 PM
wangpc commandeered this revision.Jul 5 2023, 12:47 AM
wangpc added a reviewer: pcwang-thead.
wangpc removed a reviewer: pcwang-thead.

Is it going to commit?

Is it going to commit?

This patch is stuck since the patch to support function/lambda is WIP (I may not work on it recently).