Adopt Properties to store operations inherent Attributes in the SPIRV dialect

[mehdi_amini]

Summary

This is part of an on-going migration to adopt Properties inside MLIR.

[mehdi_amini]

Rebase

[mehdi_amini]

Rebase after improving diagnostic on invalid IR

[mehdi_amini]

Rebase

[mehdi_amini]

Remove test removal

[antiagainst]

Thanks, Mehdi!

mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td

def SPIRV_Dialect : Dialect {
   }];
 
   let cppNamespace = "::mlir::spirv";
   let useDefaultTypePrinterParser = 1;
   let hasConstantMaterializer = 1;
   let hasOperationAttrVerify = 1;
   let hasRegionArgAttrVerify = 1;
   let hasRegionResultAttrVerify = 1;
+  let usePropertiesForAttributes = 1;
 
   let extraClassDeclaration = [{
     void registerAttributes();
     void registerTypes();
 
     //===------------------------------------------------------------------===//
     // Attribute
     //===------------------------------------------------------------------===//

mlir/test/Dialect/SPIRV/IR/memory-ops.mlir

func.func @load_unknown_memory_access() -> () {
   %0 = spirv.Variable : !spirv.ptr<f32, Function>
   // expected-error @+1 {{custom op 'spirv.Load' invalid memory_access attribute specification: "Volatile|Something"}}
   %1 = spirv.Load "Function" %0 ["Volatile|Something"] : f32
   return
 }
 
 // -----
 
-func.func @load_unknown_memory_access() -> () {
-  %0 = spirv.Variable : !spirv.ptr<f32, Function>
-  // expected-error @+1 {{failed to satisfy constraint: valid SPIR-V MemoryAccess}}
-  %1 = "spirv.Load"(%0) {memory_access = 0x80000000 : i32} : (!spirv.ptr<f32, Function>) -> (f32)
-  return
-}
-
-// -----
-
 func.func @aligned_load_incorrect_attributes() -> () {
   %0 = spirv.Variable : !spirv.ptr<f32, Function>
   // expected-error @+1 {{expected ']'}}
   %1 = spirv.Load "Function" %0 ["Aligned", 4, 23] : f32
   return
 }
 
 // -----