This is an archive of the discontinued LLVM Phabricator instance.

Differential D148896

Adopt Properties to store operations inherent Attributes in the OpenACC dialect
ClosedPublic

Authored by mehdi_amini on Apr 21 2023, 12:05 AM.

Details

Reviewers
rriddle
jpienaar
clementval
nicolasvasilache
Commits
rG23b952304632: Adopt Properties to store operations inherent Attributes in the OpenACC dialect
Summary

This is part of an on-going migration to adopt Properties inside MLIR.

Diff Detail

Event Timeline

mehdi_amini created this revision.Apr 21 2023, 12:05 AM
Herald added a reviewer: clementval. · View Herald TranscriptApr 21 2023, 12:05 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: bviyer, sunshaoce, Moerafaat and 21 others. · View Herald Transcript
mehdi_amini requested review of this revision.Apr 21 2023, 12:05 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptApr 21 2023, 12:05 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B227099: Diff 515624.Apr 21 2023, 12:34 AM
clementval added a comment.Apr 21 2023, 8:50 AM

The pre-commit ci is failing. Probably because there is no dependent revision.

mehdi_amini added a comment.Apr 21 2023, 9:02 AM
In D148896#4287404, @clementval wrote:

The pre-commit ci is failing. Probably because there is no dependent revision.

Yeah I have quite a few patch chained here!

mehdi_amini added a parent revision: D148895: Adopt Properties to store operations inherent Attributes in the NVGPU dialect.Apr 21 2023, 9:02 AM
mehdi_amini added a child revision: D148897: Adopt Properties to store operations inherent Attributes in the OpenMP dialect.Apr 21 2023, 9:07 AM
clementval accepted this revision.Apr 21 2023, 9:09 AM

LGTM

This revision is now accepted and ready to land.Apr 21 2023, 9:09 AM
mehdi_amini updated this revision to Diff 515787.Apr 21 2023, 9:30 AM

Rebase

Harbormaster completed remote builds in B227224: Diff 515787.Apr 21 2023, 11:11 AM
mehdi_amini updated this revision to Diff 516007.Apr 21 2023, 8:22 PM

Rebase

Harbormaster completed remote builds in B227402: Diff 516007.Apr 21 2023, 9:59 PM
mehdi_amini updated this revision to Diff 516261.Apr 23 2023, 10:32 PM

Rebase after improving diagnostic on invalid IR

Harbormaster completed remote builds in B227616: Diff 516261.Apr 23 2023, 11:48 PM
mehdi_amini updated this revision to Diff 516671.Apr 25 2023, 12:20 AM

Rebase

This revision was landed with ongoing or failed builds.May 10 2023, 6:54 AM
Closed by commit rG23b952304632: Adopt Properties to store operations inherent Attributes in the OpenACC dialect (authored by mehdi_amini). · Explain Why
This revision was automatically updated to reflect the committed changes.
mehdi_amini added a commit: rG23b952304632: Adopt Properties to store operations inherent Attributes in the OpenACC dialect.

Revision Contents

PathSize
mlir/
include/
mlir/
Dialect/
OpenACC/
1 line

Diff 516261

mlir/include/mlir/Dialect/OpenACC/OpenACCBase.td

Show All 20 Linesdef OpenACC_Dialect : Dialect {
let summary = "An OpenACC dialect for MLIR."; let summary = "An OpenACC dialect for MLIR.";
let description = [{ let description = [{
This dialect models the construct from the OpenACC 3.1 directive language. This dialect models the construct from the OpenACC 3.1 directive language.
}]; }];
let useDefaultAttributePrinterParser = 1; let useDefaultAttributePrinterParser = 1;
let useDefaultTypePrinterParser = 1; let useDefaultTypePrinterParser = 1;
let usePropertiesForAttributes = 1;
let cppNamespace = "::mlir::acc"; let cppNamespace = "::mlir::acc";
let dependentDialects = ["::mlir::memref::MemRefDialect","::mlir::LLVM::LLVMDialect"]; let dependentDialects = ["::mlir::memref::MemRefDialect","::mlir::LLVM::LLVMDialect"];
} }
#endif // OPENACC_BASE #endif // OPENACC_BASE