This is an archive of the discontinued LLVM Phabricator instance.

Differential D148887

Adopt Properties to store operations inherent Attributes in the DLTI dialect
ClosedPublic

Authored by mehdi_amini on Apr 21 2023, 12:04 AM.

Details

Reviewers
rriddle
jpienaar
nicolasvasilache
ftynse
Commits
rGff1516ae3025: Adopt Properties to store operations inherent Attributes in the DLTI dialect
Summary

This is part of an on-going migration to adopt Properties inside MLIR.

Diff Detail

Event Timeline

mehdi_amini created this revision.Apr 21 2023, 12:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2023, 12:04 AM
Herald added subscribers: bviyer, Moerafaat, zero9178 and 20 others. · View Herald Transcript
mehdi_amini requested review of this revision.Apr 21 2023, 12:04 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptApr 21 2023, 12:04 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
mehdi_amini added a child revision: D148888: Adopt Properties to store operations inherent Attributes in the EmitC dialect.Apr 21 2023, 9:04 AM
mehdi_amini added a parent revision: D148886: Adopt Properties to store operations inherent Attributes in the ControlFlow dialect.Apr 21 2023, 9:07 AM
mehdi_amini updated this revision to Diff 515778.Apr 21 2023, 9:29 AM

Rebase

Harbormaster completed remote builds in B227215: Diff 515778.Apr 21 2023, 11:09 AM
mehdi_amini updated this revision to Diff 515998.Apr 21 2023, 8:21 PM

Rebase

Harbormaster completed remote builds in B227393: Diff 515998.Apr 21 2023, 9:50 PM
mehdi_amini updated this revision to Diff 516252.Apr 23 2023, 10:32 PM

Rebase after improving diagnostic on invalid IR

rriddle accepted this revision.Apr 23 2023, 11:12 PM
This revision is now accepted and ready to land.Apr 23 2023, 11:12 PM
Harbormaster completed remote builds in B227607: Diff 516252.Apr 23 2023, 11:24 PM
ftynse accepted this revision.Apr 24 2023, 12:40 AM
mehdi_amini updated this revision to Diff 516662.Apr 25 2023, 12:19 AM

Rebase

Harbormaster completed remote builds in B227916: Diff 516662.Apr 25 2023, 1:53 AM
This revision was landed with ongoing or failed builds.May 9 2023, 7:00 AM
Closed by commit rGff1516ae3025: Adopt Properties to store operations inherent Attributes in the DLTI dialect (authored by mehdi_amini). · Explain Why
This revision was automatically updated to reflect the committed changes.
mehdi_amini added a commit: rGff1516ae3025: Adopt Properties to store operations inherent Attributes in the DLTI dialect.

Revision Contents

PathSize
mlir/
include/
mlir/
Dialect/
DLTI/
1 line

Diff 516662

mlir/include/mlir/Dialect/DLTI/DLTIBase.td

Show All 39 Lines let extraClassDeclaration = [{
constexpr const static ::llvm::StringLiteral constexpr const static ::llvm::StringLiteral
kDataLayoutAllocaMemorySpaceKey = "dlti.alloca_memory_space"; kDataLayoutAllocaMemorySpaceKey = "dlti.alloca_memory_space";
constexpr const static ::llvm::StringLiteral constexpr const static ::llvm::StringLiteral
kDataLayoutStackAlignmentKey = "dlti.stack_alignment"; kDataLayoutStackAlignmentKey = "dlti.stack_alignment";
}]; }];
let useDefaultAttributePrinterParser = 1; let useDefaultAttributePrinterParser = 1;
let usePropertiesForAttributes = 1;
} }
def DLTI_DataLayoutEntryAttr : DialectAttr< def DLTI_DataLayoutEntryAttr : DialectAttr<
DLTI_Dialect, DLTI_Dialect,
CPred<"$_self.isa<::mlir::DataLayoutEntryAttr>()">, CPred<"$_self.isa<::mlir::DataLayoutEntryAttr>()">,
"Target data layout entry"> { "Target data layout entry"> {
let storageType = "::mlir::DataLayoutEntryAttr"; let storageType = "::mlir::DataLayoutEntryAttr";
let returnType = "::mlir::DataLayoutEntryAttr"; let returnType = "::mlir::DataLayoutEntryAttr";
Show All 17 Lines