This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Bump Zfa version to 0.2 and correct RISCVUsage description
ClosedPublic

Authored by asb on Apr 18 2023, 6:48 AM.

Details

Summary

As of this commit in the riscv-isa-manual, Zfa is at version 0.2. Reviewing the commit history for zfa.tex there are no relevant changes since 0.1. As such, we can simply increment the version number.

This change also removes the claim in RISCVUsage that we implement a "subset of" Zfa, as I believe this is no longer true. That sentence previously incorrectly claimed we didn't implement fli.{h,s,d} (I corrected this a couple of weeks ago) but I think should have removed the "subset of" wording too.

Diff Detail

Event Timeline

asb created this revision.Apr 18 2023, 6:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 18 2023, 6:48 AM
asb requested review of this revision.Apr 18 2023, 6:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 18 2023, 6:48 AM
craig.topper added inline comments.Apr 18 2023, 10:07 AM
llvm/docs/ReleaseNotes.rst
169

Zfa wasn't in 16 right? So it looks like we failed to mention adding Zfa here when it was added. Can we have something like "Added support for Zfa extension version 0.2" instead?

asb updated this revision to Diff 514677.Apr 18 2023, 10:21 AM

Address review comments.

asb marked an inline comment as done.Apr 18 2023, 10:21 AM
This revision is now accepted and ready to land.Apr 18 2023, 10:44 AM
This revision was landed with ongoing or failed builds.Apr 18 2023, 10:28 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 18 2023, 10:28 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript