Page MenuHomePhabricator
Differential D146612

[Flang][OpenMP][MLIR] Lower OpenMP target attributes
ClosedPublic
Actions

Authored by domada on Mar 22 2023, 2:27 AM.

Details

Reviewers
jsjodin
kiranktp
kiranchandramohan
agozillon
TIFitis
RogerV-AMD
dpalermo
raghavendhra
NimishMishra
skatrak
ftynse
jdoerfert
nicolasvasilache
sscalpone
Commits
rGbdbc9429fcc1: [MLIR][OpenMP][Flang] Set OpenMP target attributes in MLIR module
Summary

Added functionality which allows to attach information about target features to OpenMP MLIR code.

Scope of changes:

  1. Add attribute to OpenMP MLIR dialect which stores target cpu and target features
  2. Store target information in MLIR module

Diff Detail

Event Timeline

domada created this revision.Mar 22 2023, 2:27 AM
Herald added a reviewer: ftynse. · View Herald TranscriptMar 22 2023, 2:27 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: sunshaoce, Moerafaat, zero9178 and 26 others. · View Herald Transcript
domada requested review of this revision.Mar 22 2023, 2:27 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptMar 22 2023, 2:27 AM
Herald added a reviewer: nicolasvasilache. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, jplehr, sstefan1 and 2 others. · View Herald Transcript
domada added a parent revision: D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver.Mar 22 2023, 2:28 AM
Harbormaster completed remote builds in B220957: Diff 507271.Mar 22 2023, 3:30 AM
domada mentioned this in D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver.Mar 22 2023, 6:18 AM
domada updated this revision to Diff 507338.Mar 22 2023, 6:29 AM
domada retitled this revision from [OpenMP][MLIR][OpenMPIRBuilder] Lower OpenMP target attributes to [Flang][OpenMP][MLIR][OpenMPIRBuilder] Lower OpenMP target attributes.
domada edited the summary of this revision. (Show Details)

Added OpenMP target attributes from parent review D145579 .

This review contains complete set of changes required to add target attributes for OpenMP dialect.

Herald added a reviewer: sscalpone. · View Herald TranscriptMar 22 2023, 6:29 AM
Harbormaster completed remote builds in B221010: Diff 507338.Mar 22 2023, 7:40 AM
domada mentioned this in D146721: [Flang][OpenMP] WIP: Add a Device Interface.Mar 23 2023, 11:57 AM
domada updated this revision to Diff 509677.Mar 30 2023, 7:43 AM
domada edited the summary of this revision. (Show Details)

Scope of changes:

  1. Applied @kiranchandramohan suggestion ( https://reviews.llvm.org/D146721 ) for target interface.
  2. Patch rebased.
  3. Limited scope of patch. Lowering from MLIR to LLVM IR will be present in different patch
domada retitled this revision from [Flang][OpenMP][MLIR][OpenMPIRBuilder] Lower OpenMP target attributes to [Flang][OpenMP][MLIR] Lower OpenMP target attributes.Mar 30 2023, 7:43 AM
Harbormaster completed remote builds in B222751: Diff 509677.Mar 30 2023, 8:15 AM
agozillon mentioned this in D145264: [OpenMP][MLIR][Flang][Driver][bbc] Lower and apply Module FlagsAttr.Mar 30 2023, 8:30 AM
domada updated this revision to Diff 509956.Mar 31 2023, 3:18 AM

Updated mlir definition of target attributes. Use MLIR class StringRefParameter instead std::string

kiranchandramohan accepted this revision.Mar 31 2023, 3:29 AM

LGTM.

mlir/include/mlir/Dialect/OpenMP/OpenMPOpsInterfaces.td
116
128
This revision is now accepted and ready to land.Mar 31 2023, 3:29 AM
This revision was landed with ongoing or failed builds.Mar 31 2023, 3:53 AM
Closed by commit rGbdbc9429fcc1: [MLIR][OpenMP][Flang] Set OpenMP target attributes in MLIR module (authored by domada). · Explain Why
This revision was automatically updated to reflect the committed changes.
domada added a commit: rGbdbc9429fcc1: [MLIR][OpenMP][Flang] Set OpenMP target attributes in MLIR module.
Herald added a project: Restricted Project. · View Herald TranscriptMar 31 2023, 3:53 AM
Harbormaster completed remote builds in B222954: Diff 509956.Mar 31 2023, 4:41 AM
domada mentioned this in D149450: [RFC] Flang - generation of LLVM IR function attributes.Apr 28 2023, 7:52 AM

Revision Contents
Changeset List

PathSize
flang/
include/
flang/
Tools/
11 lines
lib/
Frontend/
7 lines
test/
Lower/
OpenMP/
16 lines
mlir/
include/
mlir/
Dialect/
OpenMP/
10 lines
34 lines

Diff 509981

View Options

flang/include/flang/Tools/CrossToolHelpers.h

Loading...
View Options

flang/lib/Frontend/FrontendActions.cpp

Loading...
View Options

flang/test/Lower/OpenMP/target_cpu_features.f90

Loading...
View Options

mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td

Loading...
View Options

mlir/include/mlir/Dialect/OpenMP/OpenMPOpsInterfaces.td

Loading...