Page MenuHomePhabricator

NimishMishra (Nimish Mishra)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 29 2021, 9:36 PM (65 w, 1 d)

Recent Activity

Oct 29 2022

NimishMishra updated the diff for D133686: [flang][OpenMP] Handle lastprivate on sections construct.

Added a test case for nowait clause on sections construct as well.

Oct 29 2022, 7:53 PM · Restricted Project, Restricted Project, Restricted Project

Oct 17 2022

NimishMishra added inline comments to D133686: [flang][OpenMP] Handle lastprivate on sections construct.
Oct 17 2022, 8:06 PM · Restricted Project, Restricted Project, Restricted Project

Oct 13 2022

NimishMishra added inline comments to D133686: [flang][OpenMP] Handle lastprivate on sections construct.
Oct 13 2022, 11:10 PM · Restricted Project, Restricted Project, Restricted Project
NimishMishra updated the diff for D133686: [flang][OpenMP] Handle lastprivate on sections construct.

Rebased and added comment to explain need of a dummy scf.if operation.

Oct 13 2022, 11:03 PM · Restricted Project, Restricted Project, Restricted Project

Oct 2 2022

NimishMishra updated the diff for D133686: [flang][OpenMP] Handle lastprivate on sections construct.

Rebase with main

Oct 2 2022, 10:13 PM · Restricted Project, Restricted Project, Restricted Project
NimishMishra added inline comments to D133686: [flang][OpenMP] Handle lastprivate on sections construct.
Oct 2 2022, 10:08 PM · Restricted Project, Restricted Project, Restricted Project
NimishMishra updated the diff for D133686: [flang][OpenMP] Handle lastprivate on sections construct.

Updated the patch as per @kiranchandramohan's suggestion.

Oct 2 2022, 10:06 PM · Restricted Project, Restricted Project, Restricted Project

Sep 21 2022

NimishMishra added a reviewer for D133686: [flang][OpenMP] Handle lastprivate on sections construct: SouraVX.
Sep 21 2022, 6:49 AM · Restricted Project, Restricted Project, Restricted Project
NimishMishra updated the diff for D133686: [flang][OpenMP] Handle lastprivate on sections construct.

Updated the patch:

Sep 21 2022, 6:44 AM · Restricted Project, Restricted Project, Restricted Project

Sep 13 2022

NimishMishra added inline comments to D133686: [flang][OpenMP] Handle lastprivate on sections construct.
Sep 13 2022, 9:21 PM · Restricted Project, Restricted Project, Restricted Project

Sep 12 2022

NimishMishra added reviewers for D133686: [flang][OpenMP] Handle lastprivate on sections construct: kiranchandramohan, kiranktp, peixin, MatsPetersson.
Sep 12 2022, 5:24 AM · Restricted Project, Restricted Project, Restricted Project
NimishMishra requested review of D133686: [flang][OpenMP] Handle lastprivate on sections construct.
Sep 12 2022, 4:20 AM · Restricted Project, Restricted Project, Restricted Project

Sep 4 2022

NimishMishra committed rG1f734b0d1731: [flang][OpenMP] Handle private/firstprivate clauses on sections construct (authored by NimishMishra).
[flang][OpenMP] Handle private/firstprivate clauses on sections construct
Sep 4 2022, 7:51 AM · Restricted Project, Restricted Project
NimishMishra closed D131463: [flang][OpenMP] Handle private/firstprivate clauses on sections construct.
Sep 4 2022, 7:50 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 31 2022

NimishMishra added inline comments to D127272: [flang][OpenMP] Lowering support for atomic capture.
Aug 31 2022, 6:36 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
NimishMishra updated the diff for D127272: [flang][OpenMP] Lowering support for atomic capture.

Changed design of the patch to evaluate LHS and RHS of the two assignment statements before generating the omp.atomic.capture operation.

Aug 31 2022, 6:36 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 30 2022

NimishMishra added inline comments to D127272: [flang][OpenMP] Lowering support for atomic capture.
Aug 30 2022, 6:52 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
NimishMishra added a comment to D131463: [flang][OpenMP] Handle private/firstprivate clauses on sections construct.

Re-triggered build. CI passes now.

Aug 30 2022, 2:47 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
NimishMishra added a comment to D130157: [mlir][OpenMP] Translation to LLVM IR for omp.taskgroup.

@shraiysh Possible to land this? If not, do let me know. I will land it on your behalf.

Aug 30 2022, 2:28 AM · Restricted Project, Restricted Project

Aug 25 2022

NimishMishra updated the diff for D131463: [flang][OpenMP] Handle private/firstprivate clauses on sections construct.

Fixed formatting issues

Aug 25 2022, 6:12 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
NimishMishra added inline comments to D131463: [flang][OpenMP] Handle private/firstprivate clauses on sections construct.
Aug 25 2022, 6:01 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
NimishMishra updated the diff for D131463: [flang][OpenMP] Handle private/firstprivate clauses on sections construct.

Addressed comments.

Aug 25 2022, 5:59 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
NimishMishra accepted D127047: [flang][OpenMP] Support lowering of threadprivate directive for non global variables.

I am OK with reusing createGlobalInitialization from ConvertVariable.cpp

Aug 25 2022, 2:01 AM · Restricted Project, Restricted Project

Aug 22 2022

NimishMishra added inline comments to D127047: [flang][OpenMP] Support lowering of threadprivate directive for non global variables.
Aug 22 2022, 5:06 AM · Restricted Project, Restricted Project
NimishMishra added a comment to D127047: [flang][OpenMP] Support lowering of threadprivate directive for non global variables.

Thanks for the patch. I have a few comments and questions.

Aug 22 2022, 3:57 AM · Restricted Project, Restricted Project

Aug 21 2022

NimishMishra committed rGd9ff670330a8: [flang][OpenMP] Parser support for Target directive and Device clause (authored by Sesha Kalyur <SeshaP.Kalyur@amd.com>).
[flang][OpenMP] Parser support for Target directive and Device clause
Aug 21 2022, 9:56 AM · Restricted Project, Restricted Project, Restricted Project
NimishMishra closed D126441: [flang][OpenMP] Parser support for Target directive and Device clause.
Aug 21 2022, 9:55 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 20 2022

NimishMishra added inline comments to D131463: [flang][OpenMP] Handle private/firstprivate clauses on sections construct.
Aug 20 2022, 8:33 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
NimishMishra updated the diff for D131463: [flang][OpenMP] Handle private/firstprivate clauses on sections construct.

Addressed comments.

Aug 20 2022, 8:27 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 18 2022

NimishMishra added inline comments to D131832: [flang][OpenMP] Handle the data race for firstprivate and lastprivate.
Aug 18 2022, 6:41 PM · Restricted Project, Restricted Project
NimishMishra planned changes to D126612: [flang][OpenMP] Added semantic checks for atomic capture construct.

The design of this solution could be improved. Following whatever reviews come in https://reviews.llvm.org/D127272, we can use the same basic structural checks from that patch here to understand what the statements 1 and 2 of the atomic capture construct actually are (among read/write/update statements). That would remove dependence on global boolean flags, which don't look good design wise.

Aug 18 2022, 6:38 PM · Restricted Project, Restricted Project, Restricted Project
NimishMishra added inline comments to D131463: [flang][OpenMP] Handle private/firstprivate clauses on sections construct.
Aug 18 2022, 6:26 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
NimishMishra added a comment to D127954: [NFC][flang][OpenMP] Refactor the privatization positions.

This might require a rebase

Aug 18 2022, 6:19 PM · Restricted Project, Restricted Project
NimishMishra accepted D131832: [flang][OpenMP] Handle the data race for firstprivate and lastprivate.

LGTM.

Aug 18 2022, 6:16 PM · Restricted Project, Restricted Project
NimishMishra added a comment to D127272: [flang][OpenMP] Lowering support for atomic capture.

Ping for review!

Aug 18 2022, 3:31 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
NimishMishra added a comment to D131832: [flang][OpenMP] Handle the data race for firstprivate and lastprivate.

Thank you for the patch. I have a couple of questions.

Aug 18 2022, 2:43 AM · Restricted Project, Restricted Project

Aug 12 2022

NimishMishra added a comment to D123930: [flang][OpenMP] Lowering support for default clause.

I have landed the patch with https://reviews.llvm.org/rG435feefbdd6c91faf24fa5e69c4e7c3bc127568a.

Aug 12 2022, 4:33 AM · Restricted Project, Restricted Project, Restricted Project
NimishMishra committed rG435feefbdd6c: [flang][OpenMP] Lowering support for default clause (authored by NimishMishra).
[flang][OpenMP] Lowering support for default clause
Aug 12 2022, 4:19 AM · Restricted Project, Restricted Project
NimishMishra added a reverting change for rG6a305c9b49dd: [flang][OpenMP] Lowering support for default clause: rG30b779d515e6: Revert "[flang][OpenMP] Lowering support for default clause".
Aug 12 2022, 4:19 AM · Restricted Project, Restricted Project
NimishMishra committed rG30b779d515e6: Revert "[flang][OpenMP] Lowering support for default clause" (authored by NimishMishra).
Revert "[flang][OpenMP] Lowering support for default clause"
Aug 12 2022, 4:19 AM · Restricted Project, Restricted Project
NimishMishra added a reverting change for D123930: [flang][OpenMP] Lowering support for default clause: rG30b779d515e6: Revert "[flang][OpenMP] Lowering support for default clause".
Aug 12 2022, 4:19 AM · Restricted Project, Restricted Project, Restricted Project
NimishMishra committed rG6a305c9b49dd: [flang][OpenMP] Lowering support for default clause (authored by NimishMishra).
[flang][OpenMP] Lowering support for default clause
Aug 12 2022, 4:09 AM · Restricted Project, Restricted Project
NimishMishra closed D123930: [flang][OpenMP] Lowering support for default clause.
Aug 12 2022, 4:09 AM · Restricted Project, Restricted Project, Restricted Project

Aug 9 2022

NimishMishra added reviewers for D131463: [flang][OpenMP] Handle private/firstprivate clauses on sections construct: kiranchandramohan, kiranktp, peixin, domada.
Aug 9 2022, 10:33 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
NimishMishra added inline comments to D131463: [flang][OpenMP] Handle private/firstprivate clauses on sections construct.
Aug 9 2022, 10:29 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 8 2022

NimishMishra requested review of D131463: [flang][OpenMP] Handle private/firstprivate clauses on sections construct.
Aug 8 2022, 8:52 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 3 2022

NimishMishra added inline comments to D123930: [flang][OpenMP] Lowering support for default clause.
Aug 3 2022, 7:50 PM · Restricted Project, Restricted Project, Restricted Project
NimishMishra updated the diff for D123930: [flang][OpenMP] Lowering support for default clause.

Addressed comments.

Aug 3 2022, 7:50 PM · Restricted Project, Restricted Project, Restricted Project

Aug 1 2022

NimishMishra added inline comments to D127272: [flang][OpenMP] Lowering support for atomic capture.
Aug 1 2022, 4:55 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
NimishMishra updated the diff for D127272: [flang][OpenMP] Lowering support for atomic capture.

Improved design of the solution

Aug 1 2022, 4:49 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
NimishMishra updated the diff for D123930: [flang][OpenMP] Lowering support for default clause.

Merged the two symbol collector methods into one

Aug 1 2022, 4:48 AM · Restricted Project, Restricted Project, Restricted Project

Jul 28 2022

NimishMishra added inline comments to D123930: [flang][OpenMP] Lowering support for default clause.
Jul 28 2022, 2:59 AM · Restricted Project, Restricted Project, Restricted Project
NimishMishra added a comment to D123930: [flang][OpenMP] Lowering support for default clause.

This latest update closely follows @peixin's suggestions and avoids std::map and inserting/deleting symbols. Because of this, one test that was earlier passing is now failing. I have added the same in flang/test/Lower/OpenMP/Todo/omp-default-clause-inner-loop.f90. Rest all nested constructs are passing.

Jul 28 2022, 2:54 AM · Restricted Project, Restricted Project, Restricted Project
NimishMishra updated the diff for D123930: [flang][OpenMP] Lowering support for default clause.
Jul 28 2022, 2:49 AM · Restricted Project, Restricted Project, Restricted Project

Jul 27 2022

NimishMishra added a comment to D123930: [flang][OpenMP] Lowering support for default clause.

@NimishMishra Do you have a plan on how to go forward with this? I am away for a couple of weeks. Could you discuss with peixin and shraiysh either here or in tomorrows call and make progress and submit?

Jul 27 2022, 9:03 AM · Restricted Project, Restricted Project, Restricted Project

Jul 26 2022

NimishMishra added a comment to D123930: [flang][OpenMP] Lowering support for default clause.

Sorry for the confusion. I mistook it as in we get the implementation in before the code freeze, and later change it to a semantic pass. Should I revert the commit?

Jul 26 2022, 5:48 AM · Restricted Project, Restricted Project, Restricted Project
NimishMishra committed rG05e6fce84fd3: [flang][OpenMP] Lowering support for default clause (authored by NimishMishra).
[flang][OpenMP] Lowering support for default clause
Jul 26 2022, 1:41 AM · Restricted Project, Restricted Project
NimishMishra closed D123930: [flang][OpenMP] Lowering support for default clause.
Jul 26 2022, 1:40 AM · Restricted Project, Restricted Project, Restricted Project

Jul 25 2022

NimishMishra added a comment to D123930: [flang][OpenMP] Lowering support for default clause.

If nested default clause is the issue, we can consider adding a TODO for that particular case and get the rest of the implementation in. What do you think @NimishMishra @peixin @shraiysh ?
Longer-term I think leaving the expansion of the default clause to private, firstprivate, shared to a pass between semantics and pre-fir tree generation seems to be a possible way. Doing all these traversals and collection of symbols during lowering seems to be mixing issues of frontend and lowering.

Jul 25 2022, 6:18 PM · Restricted Project, Restricted Project, Restricted Project
NimishMishra added a comment to D123930: [flang][OpenMP] Lowering support for default clause.

@NimishMishra where are we with this? Do you need any help here? Would you be able to reply to @peixin's question and get this ready for submission today?

Jul 25 2022, 7:19 AM · Restricted Project, Restricted Project, Restricted Project
NimishMishra added inline comments to D126612: [flang][OpenMP] Added semantic checks for atomic capture construct.
Jul 25 2022, 5:32 AM · Restricted Project, Restricted Project, Restricted Project
NimishMishra updated the diff for D126612: [flang][OpenMP] Added semantic checks for atomic capture construct.
Jul 25 2022, 5:28 AM · Restricted Project, Restricted Project, Restricted Project

Jul 19 2022

NimishMishra added inline comments to D123930: [flang][OpenMP] Lowering support for default clause.
Jul 19 2022, 1:36 AM · Restricted Project, Restricted Project, Restricted Project

Jul 15 2022

NimishMishra committed rG58753dea15c8: [flang][OpenMP] Fix warning due to uninitialized pointer dereference during… (authored by NimishMishra).
[flang][OpenMP] Fix warning due to uninitialized pointer dereference during…
Jul 15 2022, 11:53 PM · Restricted Project, Restricted Project
NimishMishra closed D129914: [flang][OpenMP] Fix warning due to uninitialized pointer dereference during atomic update lowering.
Jul 15 2022, 11:52 PM · Restricted Project, Restricted Project
NimishMishra updated the diff for D129914: [flang][OpenMP] Fix warning due to uninitialized pointer dereference during atomic update lowering.

Addressed comment.

Jul 15 2022, 11:29 PM · Restricted Project, Restricted Project
NimishMishra updated the diff for D129914: [flang][OpenMP] Fix warning due to uninitialized pointer dereference during atomic update lowering.
Jul 15 2022, 10:59 PM · Restricted Project, Restricted Project
NimishMishra updated the diff for D129914: [flang][OpenMP] Fix warning due to uninitialized pointer dereference during atomic update lowering.

Addressed comments.

Jul 15 2022, 10:55 PM · Restricted Project, Restricted Project
NimishMishra added a comment to D125668: [flang][OpenMP] Lowering support for atomic update construct.

I am getting:

/.../llvm-project/flang/lib/Lower/OpenMP.cpp:1134:21: error: variable 'updateSymbol' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]

If I understand the code correctly, updateSymbol is sometimes initialized. Then, we always dereference the pointer later in the function:

converter.bindSymbol(*updateSymbol, val);

I could silence the warning with:

const Fortran::semantics::Symbol *updateSymbol = nullptr;

but that wouldn't fix the fundamental problem. Would you mind taking a look? Thanks!

Jul 15 2022, 7:00 PM · Restricted Project, Restricted Project, Restricted Project
NimishMishra requested review of D129914: [flang][OpenMP] Fix warning due to uninitialized pointer dereference during atomic update lowering.
Jul 15 2022, 6:56 PM · Restricted Project, Restricted Project

Jul 14 2022

NimishMishra updated the diff for D127620: [flang][OpenMP] Added semantic checks for atomic capture, write, and update statements.
Jul 14 2022, 11:31 PM · Restricted Project, Restricted Project
NimishMishra added a comment to D127620: [flang][OpenMP] Added semantic checks for atomic capture, write, and update statements.

Landed of hint clause patch unblocks this now. Ping for review!

Jul 14 2022, 6:01 AM · Restricted Project, Restricted Project
NimishMishra committed rG7dc18a62e40e: [flang][OpenMP] Added semantic checks for hint clause (authored by NimishMishra).
[flang][OpenMP] Added semantic checks for hint clause
Jul 14 2022, 5:56 AM · Restricted Project, Restricted Project
NimishMishra closed D127615: [flang][OpenMP] Added semantic checks for hint clause.
Jul 14 2022, 5:56 AM · Restricted Project, Restricted Project, Restricted Project
NimishMishra committed rGa56b76d9ca52: [flang][OpenMP] Lowering support for atomic update construct (authored by NimishMishra).
[flang][OpenMP] Lowering support for atomic update construct
Jul 14 2022, 5:52 AM · Restricted Project, Restricted Project
NimishMishra closed D125668: [flang][OpenMP] Lowering support for atomic update construct.
Jul 14 2022, 5:52 AM · Restricted Project, Restricted Project, Restricted Project
NimishMishra updated the diff for D125668: [flang][OpenMP] Lowering support for atomic update construct.

Addressed comments

Jul 14 2022, 2:31 AM · Restricted Project, Restricted Project, Restricted Project

Jul 13 2022

NimishMishra added inline comments to D123930: [flang][OpenMP] Lowering support for default clause.
Jul 13 2022, 12:16 AM · Restricted Project, Restricted Project, Restricted Project

Jul 11 2022

NimishMishra added inline comments to D128151: [flang][OpenMP] Added semantic checks for 'operator' in atomic update assignment statements.
Jul 11 2022, 7:26 AM · Restricted Project, Restricted Project, Restricted Project
NimishMishra added a comment to D127615: [flang][OpenMP] Added semantic checks for hint clause.

@peixin @kiranchandramohan does this look in good shape now?

Jul 11 2022, 7:25 AM · Restricted Project, Restricted Project, Restricted Project
NimishMishra added a comment to D126441: [flang][OpenMP] Parser support for Target directive and Device clause.

Ping for review!

Jul 11 2022, 7:24 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
NimishMishra committed rG5cbe39ef880e: [flang][OpenMP] Allow default(none) to access variables with PARAMETER attribute (authored by NimishMishra).
[flang][OpenMP] Allow default(none) to access variables with PARAMETER attribute
Jul 11 2022, 6:35 AM · Restricted Project, Restricted Project
NimishMishra closed D129444: [flang][OpenMP] Allow default(none) to access variables with PARAMETER attribute.
Jul 11 2022, 6:34 AM · Restricted Project, Restricted Project
NimishMishra updated the diff for D129444: [flang][OpenMP] Allow default(none) to access variables with PARAMETER attribute.

Shifted position of the check

Jul 11 2022, 3:26 AM · Restricted Project, Restricted Project

Jul 10 2022

NimishMishra added inline comments to D129444: [flang][OpenMP] Allow default(none) to access variables with PARAMETER attribute.
Jul 10 2022, 7:29 AM · Restricted Project, Restricted Project
NimishMishra added reviewers for D129444: [flang][OpenMP] Allow default(none) to access variables with PARAMETER attribute: kiranchandramohan, kiranktp, shraiysh, peixin, MatsPetersson.
Jul 10 2022, 7:27 AM · Restricted Project, Restricted Project
NimishMishra requested review of D129444: [flang][OpenMP] Allow default(none) to access variables with PARAMETER attribute.
Jul 10 2022, 7:05 AM · Restricted Project, Restricted Project
NimishMishra added inline comments to D123930: [flang][OpenMP] Lowering support for default clause.
Jul 10 2022, 6:29 AM · Restricted Project, Restricted Project, Restricted Project
NimishMishra updated the diff for D123930: [flang][OpenMP] Lowering support for default clause.
  • Addressed comments
Jul 10 2022, 6:23 AM · Restricted Project, Restricted Project, Restricted Project

Jul 4 2022

NimishMishra updated the diff for D127615: [flang][OpenMP] Added semantic checks for hint clause.
  • Addressed comments.
Jul 4 2022, 4:48 AM · Restricted Project, Restricted Project, Restricted Project
NimishMishra updated the diff for D125668: [flang][OpenMP] Lowering support for atomic update construct.

Addressed comments.

Jul 4 2022, 2:53 AM · Restricted Project, Restricted Project, Restricted Project
NimishMishra added inline comments to D123930: [flang][OpenMP] Lowering support for default clause.
Jul 4 2022, 2:46 AM · Restricted Project, Restricted Project, Restricted Project
NimishMishra added inline comments to D123930: [flang][OpenMP] Lowering support for default clause.
Jul 4 2022, 2:43 AM · Restricted Project, Restricted Project, Restricted Project
NimishMishra added inline comments to D123930: [flang][OpenMP] Lowering support for default clause.
Jul 4 2022, 2:35 AM · Restricted Project, Restricted Project, Restricted Project
NimishMishra added inline comments to D123930: [flang][OpenMP] Lowering support for default clause.
Jul 4 2022, 2:08 AM · Restricted Project, Restricted Project, Restricted Project
NimishMishra updated the summary of D123930: [flang][OpenMP] Lowering support for default clause.
Jul 4 2022, 1:56 AM · Restricted Project, Restricted Project, Restricted Project
NimishMishra added a comment to D123930: [flang][OpenMP] Lowering support for default clause.

The build fails with "502 Bad Gateway". I will restart the build later

Jul 4 2022, 12:50 AM · Restricted Project, Restricted Project, Restricted Project
NimishMishra updated the diff for D123930: [flang][OpenMP] Lowering support for default clause.

Addressed comments

Jul 4 2022, 12:44 AM · Restricted Project, Restricted Project, Restricted Project

Jun 30 2022

NimishMishra added inline comments to D125668: [flang][OpenMP] Lowering support for atomic update construct.
Jun 30 2022, 5:16 AM · Restricted Project, Restricted Project, Restricted Project
NimishMishra updated the diff for D125668: [flang][OpenMP] Lowering support for atomic update construct.
  • created a new function for atomic update lowering
Jun 30 2022, 5:00 AM · Restricted Project, Restricted Project, Restricted Project