Page MenuHomePhabricator

NimishMishra (Nimish Mishra)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 29 2021, 9:36 PM (7 w, 6 d)

Recent Activity

Tue, Oct 12

NimishMishra added a comment to D110502: [Flang][openmp] Add semantic checks for OpenMP critical construct name resolution.

Thanks @kiranchandramohan and @clementval for comments on the patch. I am working on another hint clause related patch and am taking forward a little TODO to it: improving hint clause comparison.

Tue, Oct 12, 9:43 AM · Unknown Object (Project), Restricted Project, Restricted Project
NimishMishra updated the diff for D110502: [Flang][openmp] Add semantic checks for OpenMP critical construct name resolution.
Tue, Oct 12, 6:53 AM · Unknown Object (Project), Restricted Project, Restricted Project
NimishMishra added a comment to D110502: [Flang][openmp] Add semantic checks for OpenMP critical construct name resolution.

I have one request for change.

I think the other hint clause specific checks can come in a separate patch.

Tue, Oct 12, 5:21 AM · Unknown Object (Project), Restricted Project, Restricted Project
NimishMishra updated the diff for D110502: [Flang][openmp] Add semantic checks for OpenMP critical construct name resolution.
Tue, Oct 12, 4:28 AM · Unknown Object (Project), Restricted Project, Restricted Project
NimishMishra added a comment to D110502: [Flang][openmp] Add semantic checks for OpenMP critical construct name resolution.

@NimishMishra Can you prioritise this patch for completion today?

Tue, Oct 12, 2:46 AM · Unknown Object (Project), Restricted Project, Restricted Project

Mon, Oct 11

NimishMishra added inline comments to D110714: [Flang][openmp] Added semantic checks for atomic construct.
Mon, Oct 11, 10:28 PM · Restricted Project, Restricted Project, Unknown Object (Project)

Fri, Oct 8

NimishMishra added reviewers for D111438: [flang][OpenMP] Added test case for OpenMP 5.0 specification based semantic checks for parallel sections construct: kiranchandramohan, kiranktp, clementval, arnamoy10, Leporacanthicus, ftynse, Meinersbur, abidmalikwaterloo, peixin.
Fri, Oct 8, 9:34 AM · Restricted Project, Restricted Project, Unknown Object (Project)
NimishMishra requested review of D111438: [flang][OpenMP] Added test case for OpenMP 5.0 specification based semantic checks for parallel sections construct.
Fri, Oct 8, 9:29 AM · Restricted Project, Restricted Project, Unknown Object (Project)
NimishMishra updated the diff for D110714: [Flang][openmp] Added semantic checks for atomic construct.
Fri, Oct 8, 3:27 AM · Restricted Project, Restricted Project, Unknown Object (Project)
NimishMishra added a comment to D110502: [Flang][openmp] Add semantic checks for OpenMP critical construct name resolution.

Thanks @NimishMishra for taking this forward. Can you include the parser changes also from https://reviews.llvm.org/D93051?

Thanks for the comment. I analyzed this as well as worked on a few semantic checks related to hint clause. Are we sure that we require this as a clause list? Because everything is working smoothly anyway. In D93051, parser changes involves changing the optional clause to a list, of which I do not presently understand the requirement.

Also the clause list is no longer a std::optional. However, clauses are actually optional. But there exist examples in https://www.openmp.org/wp-content/uploads/openmp-examples-5.0.0.pdf on page 221 which indicates that it is indeed optional.

The clause list should never be optional. Only the clauses inside of the list should be optional or not. D93051 is important to make sure we have a homogenous way of dealing with clauses and the OMP.td is correctly defined. Anyway D93051 should probably be updated and landed separately if you don't bring these changes in.

Fri, Oct 8, 1:37 AM · Unknown Object (Project), Restricted Project, Restricted Project
NimishMishra added inline comments to D110714: [Flang][openmp] Added semantic checks for atomic construct.
Fri, Oct 8, 1:31 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Thu, Oct 7

NimishMishra added a comment to D110502: [Flang][openmp] Add semantic checks for OpenMP critical construct name resolution.

Thanks @NimishMishra for taking this forward. Can you include the parser changes also from https://reviews.llvm.org/D93051?

Thu, Oct 7, 7:48 AM · Unknown Object (Project), Restricted Project, Restricted Project

Mon, Oct 4

NimishMishra added a comment to D110714: [Flang][openmp] Added semantic checks for atomic construct.

Thank you for the comments. Please find my views on the same and let me know what you think about this

Mon, Oct 4, 8:12 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Thu, Sep 30

NimishMishra added a comment to D108904: [flang][OpenMP] Added semantic checks for sections (associated section(s) should be structured block(s)) and simd constructs (associated loop(s) should be structured block(s)).

Thanks a lot @kiranchandramohan and @peixin for suggestions on the patch.

Thu, Sep 30, 10:44 AM · Restricted Project, Unknown Object (Project), Restricted Project
NimishMishra updated the diff for D108904: [flang][OpenMP] Added semantic checks for sections (associated section(s) should be structured block(s)) and simd constructs (associated loop(s) should be structured block(s)).
Thu, Sep 30, 8:20 AM · Restricted Project, Unknown Object (Project), Restricted Project

Wed, Sep 29

NimishMishra added inline comments to D110502: [Flang][openmp] Add semantic checks for OpenMP critical construct name resolution.
Wed, Sep 29, 11:16 PM · Unknown Object (Project), Restricted Project, Restricted Project
NimishMishra updated the diff for D110502: [Flang][openmp] Add semantic checks for OpenMP critical construct name resolution.
Wed, Sep 29, 11:01 PM · Unknown Object (Project), Restricted Project, Restricted Project
NimishMishra added inline comments to D108904: [flang][OpenMP] Added semantic checks for sections (associated section(s) should be structured block(s)) and simd constructs (associated loop(s) should be structured block(s)).
Wed, Sep 29, 10:46 PM · Restricted Project, Unknown Object (Project), Restricted Project
NimishMishra added inline comments to D110502: [Flang][openmp] Add semantic checks for OpenMP critical construct name resolution.
Wed, Sep 29, 7:18 AM · Unknown Object (Project), Restricted Project, Restricted Project
NimishMishra added reviewers for D110714: [Flang][openmp] Added semantic checks for atomic construct: kiranktp, kiranchandramohan, clementval, arnamoy10, Leporacanthicus, ftynse, Meinersbur, abidmalikwaterloo, peixin.
Wed, Sep 29, 7:10 AM · Restricted Project, Restricted Project, Unknown Object (Project)
NimishMishra requested review of D110714: [Flang][openmp] Added semantic checks for atomic construct.
Wed, Sep 29, 6:47 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Mon, Sep 27

NimishMishra added inline comments to D108904: [flang][OpenMP] Added semantic checks for sections (associated section(s) should be structured block(s)) and simd constructs (associated loop(s) should be structured block(s)).
Mon, Sep 27, 9:00 PM · Restricted Project, Unknown Object (Project), Restricted Project

Sun, Sep 26

NimishMishra updated the summary of D110502: [Flang][openmp] Add semantic checks for OpenMP critical construct name resolution.
Sun, Sep 26, 8:27 AM · Unknown Object (Project), Restricted Project, Restricted Project
NimishMishra requested review of D110502: [Flang][openmp] Add semantic checks for OpenMP critical construct name resolution.
Sun, Sep 26, 8:12 AM · Unknown Object (Project), Restricted Project, Restricted Project
NimishMishra retitled D93051: [Flang][openmp] Add semantic checks for OpenMP critical construct. from [Flang][openmp] Add semantic checks for OpenMP critical construct name resolution to [Flang][openmp] Add semantic checks for OpenMP critical construct..
Sun, Sep 26, 8:08 AM · Unknown Object (Project), Restricted Project
NimishMishra updated the diff for D108904: [flang][OpenMP] Added semantic checks for sections (associated section(s) should be structured block(s)) and simd constructs (associated loop(s) should be structured block(s)).
Sun, Sep 26, 8:01 AM · Restricted Project, Unknown Object (Project), Restricted Project
NimishMishra updated the diff for D108904: [flang][OpenMP] Added semantic checks for sections (associated section(s) should be structured block(s)) and simd constructs (associated loop(s) should be structured block(s)).
Sun, Sep 26, 8:00 AM · Restricted Project, Unknown Object (Project), Restricted Project
NimishMishra retitled D93051: [Flang][openmp] Add semantic checks for OpenMP critical construct. from [Flang][openmp] Add semantic checks for OpenMP critical construct. to [Flang][openmp] Add semantic checks for OpenMP critical construct name resolution.
Sun, Sep 26, 7:57 AM · Unknown Object (Project), Restricted Project

Sat, Sep 25

NimishMishra updated the summary of D108904: [flang][OpenMP] Added semantic checks for sections (associated section(s) should be structured block(s)) and simd constructs (associated loop(s) should be structured block(s)).
Sat, Sep 25, 12:35 AM · Restricted Project, Unknown Object (Project), Restricted Project
NimishMishra added inline comments to D108904: [flang][OpenMP] Added semantic checks for sections (associated section(s) should be structured block(s)) and simd constructs (associated loop(s) should be structured block(s)).
Sat, Sep 25, 12:31 AM · Restricted Project, Unknown Object (Project), Restricted Project
NimishMishra updated the diff for D108904: [flang][OpenMP] Added semantic checks for sections (associated section(s) should be structured block(s)) and simd constructs (associated loop(s) should be structured block(s)).
Sat, Sep 25, 12:20 AM · Restricted Project, Unknown Object (Project), Restricted Project

Sep 5 2021

NimishMishra added inline comments to D108904: [flang][OpenMP] Added semantic checks for sections (associated section(s) should be structured block(s)) and simd constructs (associated loop(s) should be structured block(s)).
Sep 5 2021, 11:16 PM · Restricted Project, Unknown Object (Project), Restricted Project

Sep 3 2021

NimishMishra added a comment to D108904: [flang][OpenMP] Added semantic checks for sections (associated section(s) should be structured block(s)) and simd constructs (associated loop(s) should be structured block(s)).

I think your implementation does deal with the first point in your summary. You only add one test case, right?

Sep 3 2021, 2:10 AM · Restricted Project, Unknown Object (Project), Restricted Project

Sep 2 2021

NimishMishra updated the diff for D108904: [flang][OpenMP] Added semantic checks for sections (associated section(s) should be structured block(s)) and simd constructs (associated loop(s) should be structured block(s)).
Sep 2 2021, 2:59 PM · Restricted Project, Unknown Object (Project), Restricted Project
NimishMishra added inline comments to D108904: [flang][OpenMP] Added semantic checks for sections (associated section(s) should be structured block(s)) and simd constructs (associated loop(s) should be structured block(s)).
Sep 2 2021, 2:56 PM · Restricted Project, Unknown Object (Project), Restricted Project
NimishMishra changed the edit policy for D108904: [flang][OpenMP] Added semantic checks for sections (associated section(s) should be structured block(s)) and simd constructs (associated loop(s) should be structured block(s)).
Sep 2 2021, 4:55 AM · Restricted Project, Unknown Object (Project), Restricted Project

Aug 30 2021

NimishMishra updated the diff for D108904: [flang][OpenMP] Added semantic checks for sections (associated section(s) should be structured block(s)) and simd constructs (associated loop(s) should be structured block(s)).

Fixed !$omp do's handling of unlabeled CYCLEs

Aug 30 2021, 2:33 PM · Restricted Project, Unknown Object (Project), Restricted Project
NimishMishra updated the summary of D108904: [flang][OpenMP] Added semantic checks for sections (associated section(s) should be structured block(s)) and simd constructs (associated loop(s) should be structured block(s)).
Aug 30 2021, 11:37 AM · Restricted Project, Unknown Object (Project), Restricted Project
NimishMishra updated the diff for D108904: [flang][OpenMP] Added semantic checks for sections (associated section(s) should be structured block(s)) and simd constructs (associated loop(s) should be structured block(s)).
Aug 30 2021, 10:39 AM · Restricted Project, Unknown Object (Project), Restricted Project
NimishMishra updated the diff for D108904: [flang][OpenMP] Added semantic checks for sections (associated section(s) should be structured block(s)) and simd constructs (associated loop(s) should be structured block(s)).
Aug 30 2021, 12:16 AM · Restricted Project, Unknown Object (Project), Restricted Project

Aug 29 2021

NimishMishra updated the diff for D108904: [flang][OpenMP] Added semantic checks for sections (associated section(s) should be structured block(s)) and simd constructs (associated loop(s) should be structured block(s)).

git-clang-format-7 changes

Aug 29 2021, 10:59 PM · Restricted Project, Unknown Object (Project), Restricted Project
NimishMishra changed the edit policy for D108904: [flang][OpenMP] Added semantic checks for sections (associated section(s) should be structured block(s)) and simd constructs (associated loop(s) should be structured block(s)).
Aug 29 2021, 10:26 PM · Restricted Project, Unknown Object (Project), Restricted Project
NimishMishra added reviewers for D108904: [flang][OpenMP] Added semantic checks for sections (associated section(s) should be structured block(s)) and simd constructs (associated loop(s) should be structured block(s)): kiranchandramohan, clementval, arnamoy10, Leporacanthicus, ftynse, Meinersbur, abidmalikwaterloo, peixin.
Aug 29 2021, 10:26 PM · Restricted Project, Unknown Object (Project), Restricted Project
NimishMishra requested review of D108904: [flang][OpenMP] Added semantic checks for sections (associated section(s) should be structured block(s)) and simd constructs (associated loop(s) should be structured block(s)).
Aug 29 2021, 10:18 PM · Restricted Project, Unknown Object (Project), Restricted Project