D143422 test AArch64/reg-usage.ll has an issue with the output ordering due to use of unordered container. This was discovered by
-DLLVM_REVERSE_ITERATION:BOOL=ON cmake option.
This patch tries to address it by making use of ordered container.
Differential D145472
[LV][AArch64] Resolve test failure due use of unordered container sushgokh on Mar 6 2023, 10:30 PM. Authored by
Details
D143422 test AArch64/reg-usage.ll has an issue with the output ordering due to use of unordered container. This was discovered by This patch tries to address it by making use of ordered container.
Diff Detail
Unit Tests
Event TimelineComment Actions LGTM, thanks! The commit title could be a bit more descriptive by explicitly mentioning what the code change is, e.g. something like: [LV] Use SetVector to collect invariants in calculateRegisterUsage. Also, this is not AArch64 specific, so it would be good to drop the [AArch64] part. Comment Actions Thanks @fhahn for the suggestion. Regarding inclusion of AArch64 in title, I thought this was more about AArch64 test failure. But I was incorrect. Will keep this in mind that its more about the change |