This is an archive of the discontinued LLVM Phabricator instance.

[RFC][GlobalISel] Allow match against iPTR operand in leaf node
Needs RevisionPublic

Authored by lkail on Feb 13 2023, 8:52 PM.

Details

Reviewers
qcolombet
dsanders
arsenm
Kai
nemanjai
shchenz
amyk
aemerson
Group Reviewers
Restricted Project
Summary

When using MVTToLLT to check corresponding LLT, also allow iPTR to pass the check. Thus we can import more patterns like ComplexPattern<iPTR, ...> in SDAG.

Diff Detail

Event Timeline

lkail created this revision.Feb 13 2023, 8:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 13 2023, 8:52 PM
lkail requested review of this revision.Feb 13 2023, 8:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 13 2023, 8:52 PM
lkail retitled this revision from [GISel]]RFC] Allow match against iPTR operand in leaf node to [GISel]RFC] Allow match against iPTR operand in leaf node.Feb 13 2023, 8:58 PM
lkail retitled this revision from [GISel]RFC] Allow match against iPTR operand in leaf node to [RFC][GlobalISel] Allow match against iPTR operand in leaf node.
shchenz added inline comments.Mar 3 2023, 1:26 AM
llvm/utils/TableGen/GlobalISelEmitter.cpp
4607

Can you show an imported rule with ptr type in GISel's MatchTable after this change? I don't think GIM_CheckType can check a pointer type for now?

Also, any tests?

arsenm requested changes to this revision.Jun 22 2023, 7:18 AM

Test would be nice

This revision now requires changes to proceed.Jun 22 2023, 7:18 AM