Page MenuHomePhabricator

amyk (Amy Kwan)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 4 2018, 10:36 AM (145 w, 6 d)

Recent Activity

Sun, Apr 18

amyk updated the diff for D94498: [PowerPC][NFC] Update atomic patterns to use the refactored load/store implementation.

Update patch based on dependent D93370 patch.

Sun, Apr 18, 7:49 PM · Restricted Project, Restricted Project
amyk updated the diff for D95115: [PowerPC] Update Refactored Load/Store Implementation, XForm VSX Patterns, and Tests.
  • Rebase patch in order to update test cases
Sun, Apr 18, 7:48 PM · Restricted Project, Restricted Project
amyk updated the diff for D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..
  • Rebase patch
  • Add documentation regarding refactored load and store implementation
  • Add the PPC::MOF_SubtargetP10 flag if the subtarget has prefixed instructions
Sun, Apr 18, 7:48 PM · Restricted Project, Restricted Project

Wed, Apr 14

amyk accepted D100482: [PowerPC] Provide MMA builtins for compatibility.

LGTM.

Wed, Apr 14, 7:05 PM · Restricted Project, Restricted Project

Tue, Apr 6

amyk committed rGbd6033eca7be: [PowerPC] Materialize 34-bit constants with pli directly (authored by amyk).
[PowerPC] Materialize 34-bit constants with pli directly
Tue, Apr 6, 11:39 AM
amyk closed D99906: [PowerPC] Materialize 34-bit constants with pli directly .
Tue, Apr 6, 11:38 AM · Restricted Project, Restricted Project
amyk updated the diff for D99906: [PowerPC] Materialize 34-bit constants with pli directly .

Address review comments:

  • Update the comment for emitting pli directly
  • Remove the case to ReplaceNode() if the resulting node from selectI64Imm() is not a constant.
Tue, Apr 6, 11:37 AM · Restricted Project, Restricted Project
amyk added a comment to rG9be8f8b34d9b: [sanitizer] Simplify GetTls with dl_iterate_phdr.

I saw that the patch, along with the temporary workaround for clang-ppc64le-linux has been reverted. I also saw that you committed https://reviews.llvm.org/rGec575e3b0a462ff7a3d23d0f39a22147606050de without a work around for PPC, although that has also been reverted at this time.
Was your recent patch still problematic for PPC and would you still like us to investigate it?

Tue, Apr 6, 9:23 AM

Mon, Apr 5

amyk added inline comments to D99377: [PowerPC] Add ROP Protection to prologue and epilogue.
Mon, Apr 5, 4:38 PM · Restricted Project
amyk requested review of D99906: [PowerPC] Materialize 34-bit constants with pli directly .
Mon, Apr 5, 4:23 PM · Restricted Project, Restricted Project
amyk accepted D99375: [PowerPC] Add ROP Protection Instructions for PowerPC.

Overall this LGTM.

Mon, Apr 5, 2:58 PM · Restricted Project

Thu, Mar 25

amyk updated the diff for D95115: [PowerPC] Update Refactored Load/Store Implementation, XForm VSX Patterns, and Tests.
  • Moved setting FrameIndex alignment flags implementation to D93370 (with added comments from Nemanja's review)
Thu, Mar 25, 6:59 AM · Restricted Project, Restricted Project
amyk updated the diff for D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..
  • Create a static function to compute flags for address computation
  • Create static function to set alignment flags for FrameIndex
  • Update comments
Thu, Mar 25, 6:57 AM · Restricted Project, Restricted Project

Tue, Mar 23

amyk accepted D99193: [PowerPC] Add mprivileged option.

LGTM.

Tue, Mar 23, 2:21 PM · Restricted Project, Restricted Project
amyk accepted D99185: [PowerPC] Change option to mrop-protect.

This also LGTM.

Tue, Mar 23, 10:33 AM · Restricted Project, Restricted Project
amyk added a comment to D96075: [PowerPC] Exploit Prefixed Load/Stores using the refactored Load/Store Implementation.

Gentle ping.

Tue, Mar 23, 7:51 AM · Restricted Project, Restricted Project
amyk added inline comments to D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..
Tue, Mar 23, 7:51 AM · Restricted Project, Restricted Project

Mar 19 2021

amyk added inline comments to D98791: [PowerPC][NFC] Do not enter prefix selection if it cannot do better..
Mar 19 2021, 3:06 PM · Restricted Project

Mar 18 2021

amyk added a comment to D98862: [clang] Update unit-tests after linker selection fix for *-msvc targets.

Thanks for fixing the tests. I've tested this patch on the environment of clang-ppc64le-rhel (https://lab.llvm.org/buildbot/#/builders/57), and there seems to be two failures that still remain:

Failed Tests (2):
  Clang :: OpenMP/linking.c
  Clang :: Driver/msvc-link.c
Mar 18 2021, 2:44 PM · Restricted Project

Mar 15 2021

amyk committed rGe582c073d19b: [NFC][PowerPC] Add additional load/store test cases (authored by amyk).
[NFC][PowerPC] Add additional load/store test cases
Mar 15 2021, 6:55 AM
amyk closed D97391: [NFC][PowerPC] Add additional load/store test cases.
Mar 15 2021, 6:55 AM · Restricted Project
amyk updated the diff for D96075: [PowerPC] Exploit Prefixed Load/Stores using the refactored Load/Store Implementation.

Update patch based on dependent patch (D95116) update, and update test cases with necessary changes.

Mar 15 2021, 6:44 AM · Restricted Project, Restricted Project
amyk updated the diff for D95116: [NFC][PowerPC] Update PC-Relative Load/Store Patterns to use the refactored Load/Store Implementation.

Update patch based on dependent patch (D95115) update.

Mar 15 2021, 6:43 AM · Restricted Project, Restricted Project
amyk updated the diff for D95115: [PowerPC] Update Refactored Load/Store Implementation, XForm VSX Patterns, and Tests.

Update patch based on dependent patch (D93370), update newly added test cases, address review on comment updates.

Mar 15 2021, 6:42 AM · Restricted Project, Restricted Project
amyk updated the diff for D94498: [PowerPC][NFC] Update atomic patterns to use the refactored load/store implementation.

Update patch based on dependent patch (D93370).

Mar 15 2021, 6:41 AM · Restricted Project, Restricted Project
amyk updated the diff for D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..

Rebase this patch to the latest changes.

Mar 15 2021, 6:41 AM · Restricted Project, Restricted Project
amyk updated the diff for D97391: [NFC][PowerPC] Add additional load/store test cases.

This patch is NFC as it is just adding test cases. Update the revision to combine some of the files together and to reflect the final version that will be committed.

Mar 15 2021, 6:37 AM · Restricted Project

Mar 10 2021

amyk added inline comments to D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars.
Mar 10 2021, 12:16 PM · Restricted Project, Restricted Project, Restricted Project
amyk committed rG8b540c542ce3: [PowerPC] Implement patterns for PC-Rel zextload/extload byte loads (authored by amyk).
[PowerPC] Implement patterns for PC-Rel zextload/extload byte loads
Mar 10 2021, 10:19 AM
amyk closed D98042: [PowerPC] Implement patterns for PC-Rel zextload/extload byte loads.
Mar 10 2021, 10:19 AM · Restricted Project
amyk accepted D93300: [PowerPC] Exploit paddi instruction on Power 10 for constant materialization.

Sorry for the delay and thank you for addressing my previous comments. I think this LGTM.

Mar 10 2021, 7:20 AM · Restricted Project

Mar 8 2021

amyk added a reviewer for D98042: [PowerPC] Implement patterns for PC-Rel zextload/extload byte loads: stefanp.
Mar 8 2021, 12:20 PM · Restricted Project
amyk accepted D94816: [P10] [Power PC] Exploiting new load rightmost vector element instructions..

I think this LGTM aside from the minor nit on the test case. I am OK with it being updated on the commit.

Mar 8 2021, 9:35 AM · Restricted Project

Mar 5 2021

amyk added inline comments to D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars.
Mar 5 2021, 9:38 AM · Restricted Project, Restricted Project, Restricted Project
amyk requested review of D98042: [PowerPC] Implement patterns for PC-Rel zextload/extload byte loads.
Mar 5 2021, 6:23 AM · Restricted Project

Mar 4 2021

amyk added a comment to D97575: [runtimes] Use standalone build only for compiler-rt.

Hi,

I believe this commit is causing failures on the following PowerPC buildbots:
https://lab.llvm.org/buildbot/#/builders/19/builds/2678
https://lab.llvm.org/buildbot/#/builders/18/builds/868

An example of the errors I am seeing:

CMake Error at /home/buildbots/ppc64be-sanitizer/sanitizer-ppc64be/build/llvm-project/libcxx/benchmarks/CMakeLists.txt:198 (include):
  include could not find load file:
    AddLLVM
CMake Error at /home/buildbots/ppc64be-sanitizer/sanitizer-ppc64be/build/llvm-project/libcxx/benchmarks/CMakeLists.txt:204 (configure_lit_site_cfg):
  Unknown CMake command "configure_lit_site_cfg".
[ 28%] Building IntrinsicsVE.h...
-- Configuring incomplete, errors occurred!
See also "/home/buildbots/ppc64be-sanitizer/sanitizer-ppc64be/build/clang_build/projects/compiler-rt/lib/tsan/libcxx_tsan_powerpc64-bins/CMakeFiles/CMakeOutput.log".
See also "/home/buildbots/ppc64be-sanitizer/sanitizer-ppc64be/build/clang_build/projects/compiler-rt/lib/tsan/libcxx_tsan_powerpc64-bins/CMakeFiles/CMakeError.log".
make[3]: *** [projects/compiler-rt/lib/tsan/CMakeFiles/libcxx_tsan_powerpc64-build.dir/build.make:87: projects/compiler-rt/lib/tsan/libcxx_tsan_powerpc64-stamps/libcxx_tsan_powerpc64-configure] Error 1
make[2]: *** [CMakeFiles/Makefile2:35496: projects/compiler-rt/lib/tsan/CMakeFiles/libcxx_tsan_powerpc64-build.dir/all] Error 2
make[2]: *** Waiting for unfinished jobs....
[ 28%] Built target ClangARMMveBuiltinCG
[ 30%] Built target LLVMMC
[ 30%] Built target ClangDriverOptions
[ 30%] Built target ClangARMSveSemaRangeChecks
[ 30%] Built target ClangARMSveBuiltins
[ 30%] Built target ClangARMSveBuiltinCG
[ 30%] Built target intrinsics_gen
[ 36%] Built target clang-resource-headers
make[1]: *** [CMakeFiles/Makefile2:37499: projects/compiler-rt/test/tsan/CMakeFiles/check-tsan.dir/rule] Error 2
make: *** [Makefile:10086: check-tsan] Error 2

Do you by any chance have an idea of a solution for this? Otherwise, would it be possible to pull this patch?

Mar 4 2021, 10:59 AM · Restricted Project
amyk added a comment to D97575: [runtimes] Use standalone build only for compiler-rt.

I believe this commit is causing failures on the following PowerPC buildbots:
https://lab.llvm.org/buildbot/#/builders/19/builds/2678
https://lab.llvm.org/buildbot/#/builders/18/builds/868

Mar 4 2021, 6:06 AM · Restricted Project

Feb 25 2021

amyk updated the diff for D97391: [NFC][PowerPC] Add additional load/store test cases.

Updated the patch to remove duplicate test cases.

Feb 25 2021, 7:01 AM · Restricted Project

Feb 24 2021

amyk requested review of D97391: [NFC][PowerPC] Add additional load/store test cases.
Feb 24 2021, 7:58 AM · Restricted Project

Feb 18 2021

amyk added inline comments to D93300: [PowerPC] Exploit paddi instruction on Power 10 for constant materialization.
Feb 18 2021, 11:49 AM · Restricted Project
amyk added inline comments to D94454: [PowerPC] Exploit the vinsw, vinsd, and vins[wd][lr]x instructions on P10.
Feb 18 2021, 6:19 AM · Restricted Project, Restricted Project
amyk committed rG34dc1ccb9606: [PowerPC] Exploit the vinsw, vinsd, and vins[wd][lr]x instructions on P10 (authored by bsaleil).
[PowerPC] Exploit the vinsw, vinsd, and vins[wd][lr]x instructions on P10
Feb 18 2021, 6:18 AM
amyk closed D94454: [PowerPC] Exploit the vinsw, vinsd, and vins[wd][lr]x instructions on P10.
Feb 18 2021, 6:18 AM · Restricted Project, Restricted Project

Feb 17 2021

amyk added a comment to D93300: [PowerPC] Exploit paddi instruction on Power 10 for constant materialization.

Just a few minor nit comments.

Feb 17 2021, 2:58 PM · Restricted Project

Feb 16 2021

amyk added a comment to D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs.

Thanks for answering the questions I previously had on this patch.

Feb 16 2021, 2:06 PM · Restricted Project, Restricted Project, Restricted Project
amyk added a comment to D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars.

In addition to the nit comments, I also have the same question as Stefan for getFPAs64BitIntHi/getFPAs64BitIntLo.

Feb 16 2021, 2:02 PM · Restricted Project, Restricted Project, Restricted Project
amyk accepted D96512: [PowerPC] Add option for ROP Protection.

I just have a small question about the patch but overall I think this LGTM.

Feb 16 2021, 1:38 PM · Restricted Project, Restricted Project
amyk commandeered D94454: [PowerPC] Exploit the vinsw, vinsd, and vins[wd][lr]x instructions on P10.

Commandeering this patch.

Feb 16 2021, 12:34 PM · Restricted Project, Restricted Project

Feb 15 2021

amyk updated the diff for D96075: [PowerPC] Exploit Prefixed Load/Stores using the refactored Load/Store Implementation.

Address clang-format comments.

Feb 15 2021, 6:09 PM · Restricted Project, Restricted Project
amyk updated the diff for D95116: [NFC][PowerPC] Update PC-Relative Load/Store Patterns to use the refactored Load/Store Implementation.

Update patch based on dependent patches, and update a comment when checking for P10 specific flags.

Feb 15 2021, 6:06 PM · Restricted Project, Restricted Project
amyk updated the diff for D95115: [PowerPC] Update Refactored Load/Store Implementation, XForm VSX Patterns, and Tests.

Update patch based on dependent patch changes.

Feb 15 2021, 6:04 PM · Restricted Project, Restricted Project
amyk updated the diff for D94498: [PowerPC][NFC] Update atomic patterns to use the refactored load/store implementation.

Update patch based on dependent patch (D93370).

Feb 15 2021, 6:03 PM · Restricted Project, Restricted Project
amyk updated the diff for D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..

Update patch to fix a small issue when setting the Base and Disp for DForms when we have constant that fits in 32-bits.
Previously I used a uint64_t when it should have been a uint16_t.

Feb 15 2021, 6:00 PM · Restricted Project, Restricted Project

Feb 12 2021

amyk updated the diff for D95116: [NFC][PowerPC] Update PC-Relative Load/Store Patterns to use the refactored Load/Store Implementation.

Update patch to rebase from latest change on D93370.

Feb 12 2021, 6:57 AM · Restricted Project, Restricted Project

Feb 11 2021

amyk updated the summary of D96075: [PowerPC] Exploit Prefixed Load/Stores using the refactored Load/Store Implementation.
Feb 11 2021, 6:11 AM · Restricted Project, Restricted Project
amyk updated the diff for D96075: [PowerPC] Exploit Prefixed Load/Stores using the refactored Load/Store Implementation.
  • Update LIT test cases with prefixed load/store checks.
  • Added a PrefixInstrs flag.
Feb 11 2021, 6:08 AM · Restricted Project, Restricted Project
amyk updated the diff for D95115: [PowerPC] Update Refactored Load/Store Implementation, XForm VSX Patterns, and Tests.
  • Rebase the patch with the latest trunk.
  • Updated alignment checks for the frame index.
Feb 11 2021, 6:03 AM · Restricted Project, Restricted Project
amyk updated the diff for D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..

Update patch to move the check for if we have a value with an offset that fits into a 34-bit immediate into it's own condition instead of inside an else if.

Feb 11 2021, 5:58 AM · Restricted Project, Restricted Project

Feb 9 2021

amyk added inline comments to D96346: [NFC][PPC] Refactor TOC representation to allow several entries for the same symbol.
Feb 9 2021, 2:28 PM · Restricted Project, Restricted Project
amyk added inline comments to D96184: [AIX][TLS] Generate TLS variables in assembly files.
Feb 9 2021, 7:51 AM · Restricted Project, Restricted Project

Feb 5 2021

amyk updated the summary of D96075: [PowerPC] Exploit Prefixed Load/Stores using the refactored Load/Store Implementation.
Feb 5 2021, 10:02 AM · Restricted Project, Restricted Project

Feb 4 2021

amyk requested review of D96075: [PowerPC] Exploit Prefixed Load/Stores using the refactored Load/Store Implementation.
Feb 4 2021, 1:20 PM · Restricted Project, Restricted Project

Feb 2 2021

amyk updated the diff for D95116: [NFC][PowerPC] Update PC-Relative Load/Store Patterns to use the refactored Load/Store Implementation.

Update patch to:

  • rebase patch
  • Update the naming of the variable to Parent
Feb 2 2021, 6:05 AM · Restricted Project, Restricted Project
amyk updated the diff for D94498: [PowerPC][NFC] Update atomic patterns to use the refactored load/store implementation.

Update patch to rebase with latest trunk.

Feb 2 2021, 5:59 AM · Restricted Project, Restricted Project
amyk updated the diff for D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..

Update patch to rebase with latest trunk, and rearrange/clean up code slightly.

Feb 2 2021, 5:59 AM · Restricted Project, Restricted Project

Jan 27 2021

amyk updated the diff for D95115: [PowerPC] Update Refactored Load/Store Implementation, XForm VSX Patterns, and Tests.

Rebase patch and also add additional handling for frame index (if the frame index is not aligned, match to an XForm instruction).

Jan 27 2021, 6:11 PM · Restricted Project, Restricted Project

Jan 22 2021

amyk added a comment to D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs.

A few general comments.

Jan 22 2021, 2:09 PM · Restricted Project, Restricted Project, Restricted Project

Jan 21 2021

amyk added inline comments to D94816: [P10] [Power PC] Exploiting new load rightmost vector element instructions..
Jan 21 2021, 3:48 PM · Restricted Project
amyk accepted D95004: [PowerPC] Add missing negate for VPERMXOR on little endian subtargets.

Also LGTM.

Jan 21 2021, 3:41 PM · Restricted Project
amyk added inline comments to D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..
Jan 21 2021, 3:12 PM · Restricted Project, Restricted Project

Jan 20 2021

amyk requested review of D95116: [NFC][PowerPC] Update PC-Relative Load/Store Patterns to use the refactored Load/Store Implementation.
Jan 20 2021, 11:01 PM · Restricted Project, Restricted Project
amyk requested review of D95115: [PowerPC] Update Refactored Load/Store Implementation, XForm VSX Patterns, and Tests.
Jan 20 2021, 10:56 PM · Restricted Project, Restricted Project
amyk updated the diff for D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..

Addressed review comments:

  • Rename some of the MemOpFlags
  • Fixed typo in comments
  • Moved variables near their use
  • Made some of the methods private
Jan 20 2021, 10:54 PM · Restricted Project, Restricted Project

Jan 12 2021

amyk requested review of D94498: [PowerPC][NFC] Update atomic patterns to use the refactored load/store implementation.
Jan 12 2021, 7:58 AM · Restricted Project, Restricted Project

Jan 7 2021

amyk added a comment to D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..

Removed the addition of isIntS32Immediate() - it is no longer needed after addressing the comment of using APInt.

Jan 7 2021, 6:28 AM · Restricted Project, Restricted Project
amyk updated the diff for D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..
  • Updated names of the selection functions in the td patterns
  • Address the comment of using APInt when computing address flags
  • Removed NFC from the title as there is one test case update that we expect a DSForm in (instead of an XForm instruction)
Jan 7 2021, 6:26 AM · Restricted Project, Restricted Project

Jan 6 2021

amyk added a comment to D92879: [PowerPC] Materialize 34 bit constants with pli on Power 10..

Thanks for updating. I just noticed one more minor nit.

Jan 6 2021, 1:27 PM · Restricted Project

Jan 4 2021

amyk abandoned D51750: Simply specific sequences involving XXSPLTW (ld->permute->splat, ld->splat).
Jan 4 2021, 9:53 AM · Restricted Project

Dec 17 2020

amyk accepted D89195: [PowerPC][Power10] Exploit store rightmost vector element instructions..

LGTM. Thanks for the update Albion.

Dec 17 2020, 1:28 PM · Restricted Project, Restricted Project
amyk accepted D92879: [PowerPC] Materialize 34 bit constants with pli on Power 10..

I just have a minor nit, but overall it looks good to me.

Dec 17 2020, 7:46 AM · Restricted Project
amyk retitled D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns. from [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns. to [PowerPC][NFC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..
Dec 17 2020, 7:04 AM · Restricted Project, Restricted Project
amyk accepted D90349: [DAGCombiner] Improve shift by select of constant.

I'm really sorry for the delay. LGTM to me, as well.

Dec 17 2020, 6:49 AM · Restricted Project

Dec 16 2020

amyk added inline comments to D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..
Dec 16 2020, 5:26 PM · Restricted Project, Restricted Project
amyk updated the summary of D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..
Dec 16 2020, 5:17 PM · Restricted Project, Restricted Project
amyk added a comment to D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..

I think it is better to explicitly give some reasons why we need this big refactoring, in other words, what's the disadvantage/limitation of legacy implementation? Thank you for the big effort.

Dec 16 2020, 5:14 PM · Restricted Project, Restricted Project
amyk updated the diff for D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..

Add more comments to functions, make provablyDisjointOr() static, fix pattern in PPCInstr64Bit.td.

Dec 16 2020, 5:01 PM · Restricted Project, Restricted Project
amyk added a comment to D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..

@steven.zhang The idea is that this patch should be NFC. All existing load/store test cases should pass with this refactoring. I do think there should be more tests added, perhaps in a follow up patch. What do you think?

Dec 16 2020, 10:32 AM · Restricted Project, Restricted Project

Dec 15 2020

amyk requested review of D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..
Dec 15 2020, 10:37 PM · Restricted Project, Restricted Project
amyk requested changes to D89195: [PowerPC][Power10] Exploit store rightmost vector element instructions..

Please address the comments regarding the test cases.

Dec 15 2020, 1:40 PM · Restricted Project, Restricted Project

Dec 4 2020

amyk accepted D91974: [PowerPC] Rename the vector pair intrinsics and builtins to replace the _mma_ prefix by _vsx_.

Just a minor comment but LGTM overall.

Dec 4 2020, 2:49 PM · Restricted Project, Restricted Project, Restricted Project
amyk added inline comments to D91819: [PowerPC] Enable paired vector type and intrinsics when MMA is disabled.
Dec 4 2020, 2:47 PM · Restricted Project, Restricted Project, Restricted Project

Dec 3 2020

amyk added inline comments to D91983: [PowerPC] Fix missing nop after call to weak callee..
Dec 3 2020, 7:49 AM · Restricted Project
amyk added inline comments to D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10.
Dec 3 2020, 7:32 AM · Restricted Project, Restricted Project, Restricted Project

Nov 12 2020

amyk added inline comments to D91391: [PowerPC] Fix for excessive ACC copies due to PHI nodes.
Nov 12 2020, 3:43 PM · Restricted Project
amyk accepted D91323: [PowerPC] Add support for intrinsics dcbfps and dcbstps in P10..

This LGTM.

Nov 12 2020, 3:29 PM · Restricted Project
amyk accepted D90498: Fix the compilation assertion due to unreachable BB pruning not deleting the associated BB from the jump tables.

Minor nit but LGTM

Nov 12 2020, 2:42 PM · Restricted Project
amyk accepted D91200: [PowerPC] Prevent the use of MMA with P9 and earlier.

Overall LGTM.

Nov 12 2020, 7:05 AM · Restricted Project, Restricted Project

Nov 11 2020

amyk added a comment to D91279: [PowerPC] DForm instructions should be preferred when using zero register.

Please also address the clang-format comment.

Nov 11 2020, 3:22 PM · Restricted Project, Restricted Project, Restricted Project

Nov 10 2020

amyk accepted D90616: [PowerPC] Accumulator/Unprimed Accumulator register copy, spill and restore.

Aside from the clang-format, LGTM.

Nov 10 2020, 8:40 AM · Restricted Project
amyk accepted D90799: [PowerPC] Add paired vector load and store builtins and intrinsics.

Thanks for fixing for tests and formatting. LGTM if there are no other concerns.

Nov 10 2020, 7:02 AM · Restricted Project, Restricted Project, Restricted Project