Page MenuHomePhabricator

amyk (Amy Kwan)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 4 2018, 10:36 AM (119 w, 5 d)

Recent Activity

Today

amyk added a comment to D89727: [PowerPC] Fix the Predicates for enabling pcrelative-memops and PLXVP/PSTXVP definitions .

Agreed that a test should be added.

Tue, Oct 20, 12:07 AM · Restricted Project

Yesterday

amyk accepted D89727: [PowerPC] Fix the Predicates for enabling pcrelative-memops and PLXVP/PSTXVP definitions .

I think it overall LGTM.

Mon, Oct 19, 4:59 PM · Restricted Project
amyk committed rG6a946fd06fa0: [DAGCombiner][PowerPC] Remove isMulhCheaperThanMulShift TLI hook, Use… (authored by amyk).
[DAGCombiner][PowerPC] Remove isMulhCheaperThanMulShift TLI hook, Use…
Mon, Oct 19, 10:24 AM
amyk closed D80485: [DAGCombiner][PowerPC] Remove isMulhCheaperThanMulShift TLI hook. Use isOperationLegalOrCustom directly instead..
Mon, Oct 19, 10:23 AM · Restricted Project

Thu, Oct 15

amyk added a comment to D80485: [DAGCombiner][PowerPC] Remove isMulhCheaperThanMulShift TLI hook. Use isOperationLegalOrCustom directly instead..

Thanks @dmgreen and @craig.topper for reviewing. :-)
I will fix the indentation in DAGCombiner on the commit, if that's okay.

Thu, Oct 15, 8:56 AM · Restricted Project

Tue, Oct 13

amyk updated the diff for D80485: [DAGCombiner][PowerPC] Remove isMulhCheaperThanMulShift TLI hook. Use isOperationLegalOrCustom directly instead..
  • Update the patch with the latest master.
  • Remove isMulhCheaperThanMulShift TLI Hook from all code segments.
  • Update test/CodeGen/X86/pmulh.ll.
Tue, Oct 13, 10:40 AM · Restricted Project
amyk commandeered D80485: [DAGCombiner][PowerPC] Remove isMulhCheaperThanMulShift TLI hook. Use isOperationLegalOrCustom directly instead..
Tue, Oct 13, 9:17 AM · Restricted Project

Thu, Oct 1

amyk added inline comments to D88538: [PowerPC] Materialize the immediate that is Uint32 but not Int32..
Thu, Oct 1, 3:34 PM · Restricted Project
amyk accepted D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp)..

Overall I think this LGTM.

Thu, Oct 1, 10:25 AM · Restricted Project, Restricted Project

Wed, Sep 30

amyk added a comment to D80485: [DAGCombiner][PowerPC] Remove isMulhCheaperThanMulShift TLI hook. Use isOperationLegalOrCustom directly instead..

So, my goal was to introduce a DAG combine to combine multiply+shifts into mulh. This is done in a function I introduced within DAGCombiner.cpp (called combineShiftToMULH).

Since I was implementing something that is in target independent code, I thought it may be better to enable it on PowerPC only first since I was not quite sure if other targets were interested it this and I was seeing many other LIT failures at the time.
Thus, I introduced the hook (isMulhCheaperThanMulShift) and targets who wish to combine multiply+shifts into mulh could implement that hook. Within combineShiftToMULH, there is a check to isMulhCheaperThanMulShift.

If we wanted to enable this for everyone, I think the check isOperationLegalOrCustom would probably be sufficient. I just tried this patch again, and made the following changes for combineShiftToMULH:

@@ -8099,12 +8101,6 @@ static SDValue combineShiftToMULH(SDNode *N, SelectionDAG &DAG,
   if (NarrowVT !=  RightOp.getOperand(0).getValueType())
     return SDValue();

-  // Only transform into mulh if mulh for the narrow type is cheaper than
-  // a multiply followed by a shift. This should also check if mulh is
-  // legal for NarrowVT on the target.
-  if (!TLI.isMulhCheaperThanMulShift(NarrowVT))
-      return SDValue();
-
   // Proceed with the transformation if the wide type is twice as large
   // as the narrow type.
   unsigned NarrowVTSize = NarrowVT.getScalarSizeInBits();
@@ -8122,6 +8118,12 @@ static SDValue combineShiftToMULH(SDNode *N, SelectionDAG &DAG,
   // we use mulhs. Othewise, zero extends (zext) use mulhu.
   unsigned MulhOpcode = IsSignExt ? ISD::MULHS : ISD::MULHU;

+  // Only transform into mulh if mulh for the narrow type is cheaper than
+  // a multiply followed by a shift. This should also check if mulh is
+  // legal for NarrowVT on the target.
+  if (!TLI.isOperationLegalOrCustom(MulhOpcode, NarrowVT))
+      return SDValue();
+
   SDValue Result = DAG.getNode(MulhOpcode, DL, NarrowVT, LeftOp.getOperand(0),
                                RightOp.getOperand(0));
   return (N->getOpcode() == ISD::SRA ? DAG.getSExtOrTrunc(Result, DL, WideVT1)

I only see one LIT failure now:

Failed Tests (1):
  LLVM :: CodeGen/X86/pmulh.ll

Would this now be enabled on PPC32 or whatever !PPC64 is called? Are there tests for that?

Wed, Sep 30, 2:52 PM · Restricted Project

Tue, Sep 29

amyk accepted D88043: [PowerPC] Add outer product instructions for MMA.

LGTM.

Tue, Sep 29, 1:57 PM · Restricted Project

Sat, Sep 26

amyk committed rG6f24774fc4e2: [NFC][PowerPC] Change PPCSubTarget (introduced from D87671) to Subtarget (authored by amyk).
[NFC][PowerPC] Change PPCSubTarget (introduced from D87671) to Subtarget
Sat, Sep 26, 3:54 PM

Thu, Sep 24

amyk added a comment to D80485: [DAGCombiner][PowerPC] Remove isMulhCheaperThanMulShift TLI hook. Use isOperationLegalOrCustom directly instead..

So, my goal was to introduce a DAG combine to combine multiply+shifts into mulh. This is done in a function I introduced within DAGCombiner.cpp (called combineShiftToMULH).

Thu, Sep 24, 3:47 PM · Restricted Project

Wed, Sep 23

amyk committed rG6b136b19cbe4: [Power10] Implement custom codegen for the vec_replace_elt and… (authored by amyk).
[Power10] Implement custom codegen for the vec_replace_elt and…
Wed, Sep 23, 8:56 PM
amyk closed D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins..
Wed, Sep 23, 8:55 PM · Restricted Project, Restricted Project, Restricted Project
amyk updated the diff for D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins..
  • Updated the isEltOfVectorTy() to the correct semantics; making it take in a vector type and then getting the element type within the function.
Wed, Sep 23, 9:56 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Sep 22

amyk added inline comments to D87721: [PowerPC][PCRelative] Thread Local Storage Support for Local Dynamic.
Tue, Sep 22, 4:41 PM · Restricted Project
amyk added inline comments to D88043: [PowerPC] Add outer product instructions for MMA.
Tue, Sep 22, 4:35 PM · Restricted Project
amyk committed rG079757b551f3: [PowerPC] Implement Vector String Isolate Builtins in Clang/LLVM (authored by amyk).
[PowerPC] Implement Vector String Isolate Builtins in Clang/LLVM
Tue, Sep 22, 9:32 AM
amyk committed rGb3147058dec7: [PowerPC] Implement the 128-bit Vector Divide Extended Builtins in Clang/LLVM (authored by amyk).
[PowerPC] Implement the 128-bit Vector Divide Extended Builtins in Clang/LLVM
Tue, Sep 22, 9:32 AM
amyk closed D87671: [PowerPC] Implement Vector String Isolate Builtins in Clang/LLVM.
Tue, Sep 22, 9:32 AM · Restricted Project, Restricted Project, Restricted Project
amyk closed D87729: [PowerPC] Implement the 128-bit Vector Divide Extended Builtins in Clang/LLVM.
Tue, Sep 22, 9:32 AM · Restricted Project, Restricted Project, Restricted Project
amyk added a comment to D87705: [PowerPC] Implement Set Boolean Condition Instructions.

Ping.

Tue, Sep 22, 9:16 AM · Restricted Project, Restricted Project
amyk added a comment to D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins..

@nemanjai Would you please take another look to see if I have addressed your comments when you get a chance? Thanks.

Tue, Sep 22, 8:00 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Sep 21

amyk updated the diff for D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins..

Address Nemanja's review comments:

  • More specific comments when bitcasting the inputs
  • Pull out conditions to bitcast the input, use ternary op depending if the input is 32 or 64-bits
  • Create new static function to check if a given type is the same type as a vector element
Mon, Sep 21, 7:10 PM · Restricted Project, Restricted Project, Restricted Project
amyk updated the diff for D87910: [PowerPC] Implement the 128-bit vec_[all|any]_[eq | ne | lt | gt | le | ge] builtins in Clang/LLVM.

Updated identation/formatting of code in CGExprScalar.cpp and altivec.h.

Mon, Sep 21, 7:13 AM · Restricted Project, Restricted Project, Restricted Project
amyk accepted D87394: [PowerPC][Power10] Implementation of 128-bit Binary Vector Mod and Sign Extend builtins.

Thanks for open coding. Aside from Nemanja's nits, I believe all my concerns have been addressed. LGTM.

Mon, Sep 21, 6:56 AM · Restricted Project, Restricted Project, Restricted Project

Sep 18 2020

amyk committed rG37e7673c21af: [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang (authored by amyk).
[PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang
Sep 18 2020, 4:16 PM
amyk closed D82725: [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang.
Sep 18 2020, 4:16 PM · Restricted Project, Restricted Project, Restricted Project
amyk added inline comments to D84968: [PowerPC] Legalize v256i1 and v512i1 and implement load and store of these types.
Sep 18 2020, 1:58 PM · Restricted Project, Restricted Project, Restricted Project
amyk accepted D84359: [PowerPC] Add vector pair load/store instructions and vector pair register class.

Aside from the clang-format issues that can be addressed on commit this looks good to me.

Sep 18 2020, 1:51 PM · Restricted Project, Restricted Project
amyk accepted D84847: [PowerPC] Add accumulator register class and instructions.

Overall LGTM as well.

Sep 18 2020, 11:38 AM · Restricted Project, Restricted Project
amyk accepted D87804: [PowerPC][Power10] Implement Vector signed/unsigned __int128 overloads for the comparison builtins.

Forgot to approve this patch.

Sep 18 2020, 9:45 AM · Restricted Project, Restricted Project, Restricted Project
amyk updated the diff for D87671: [PowerPC] Implement Vector String Isolate Builtins in Clang/LLVM.

Address clang-format concerns.

Sep 18 2020, 9:44 AM · Restricted Project, Restricted Project, Restricted Project
amyk requested review of D87910: [PowerPC] Implement the 128-bit vec_[all|any]_[eq | ne | lt | gt | le | ge] builtins in Clang/LLVM.
Sep 18 2020, 8:53 AM · Restricted Project, Restricted Project, Restricted Project
amyk added a comment to D87804: [PowerPC][Power10] Implement Vector signed/unsigned __int128 overloads for the comparison builtins.

Please address clang-format issues and Lei's comments. Other than that, I think the patch LGTM.

Sep 18 2020, 8:44 AM · Restricted Project, Restricted Project, Restricted Project

Sep 17 2020

amyk committed rG6f3c0991bf9b: [PowerPC] Add Set Boolean Condition Instruction Definitions and MC Tests (authored by amyk).
[PowerPC] Add Set Boolean Condition Instruction Definitions and MC Tests
Sep 17 2020, 4:40 PM
amyk committed rG2c3bc918db35: [PowerPC] Implement Vector Count Mask Bits builtins in LLVM/Clang (authored by amyk).
[PowerPC] Implement Vector Count Mask Bits builtins in LLVM/Clang
Sep 17 2020, 4:40 PM
amyk closed D86252: [PowerPC] Add Set Boolean Condition Instruction Definitions and MC Tests.
Sep 17 2020, 4:40 PM · Restricted Project
amyk closed D82726: [PowerPC] Implement Vector Count Mask Bits builtins in LLVM/Clang.
Sep 17 2020, 4:40 PM · Restricted Project, Restricted Project
amyk updated the diff for D82725: [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang.
  • Rebased patch.
  • Update patch to remove unnecessary immediate handling.
Sep 17 2020, 3:08 PM · Restricted Project, Restricted Project, Restricted Project
amyk added inline comments to D82725: [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang.
Sep 17 2020, 3:05 PM · Restricted Project, Restricted Project, Restricted Project
amyk added inline comments to D86819: [PowerPC][Power10] Implementation of 128-bit Binary Vector Rotate builtins.
Sep 17 2020, 2:29 PM · Restricted Project, Restricted Project, Restricted Project

Sep 16 2020

amyk added a comment to D87729: [PowerPC] Implement the 128-bit Vector Divide Extended Builtins in Clang/LLVM.

Looks like there's some unit test failures; could you double check?

Sep 16 2020, 7:20 AM · Restricted Project, Restricted Project, Restricted Project

Sep 15 2020

amyk requested changes to D87394: [PowerPC][Power10] Implementation of 128-bit Binary Vector Mod and Sign Extend builtins.

A question I have is, is it possible for the 128-bit vector modulo instructions be open coded?

Sep 15 2020, 4:40 PM · Restricted Project, Restricted Project, Restricted Project
amyk requested review of D87729: [PowerPC] Implement the 128-bit Vector Divide Extended Builtins in Clang/LLVM.
Sep 15 2020, 4:24 PM · Restricted Project, Restricted Project, Restricted Project
amyk updated the diff for D87705: [PowerPC] Implement Set Boolean Condition Instructions.

Update the run line of crbits.ll test.

Sep 15 2020, 10:28 AM · Restricted Project, Restricted Project
amyk requested review of D87705: [PowerPC] Implement Set Boolean Condition Instructions.
Sep 15 2020, 9:03 AM · Restricted Project, Restricted Project

Sep 14 2020

amyk added inline comments to D87671: [PowerPC] Implement Vector String Isolate Builtins in Clang/LLVM.
Sep 14 2020, 10:45 PM · Restricted Project, Restricted Project, Restricted Project
amyk requested review of D87671: [PowerPC] Implement Vector String Isolate Builtins in Clang/LLVM.
Sep 14 2020, 10:44 PM · Restricted Project, Restricted Project, Restricted Project
amyk added a comment to D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins..

@nemanjai Could you please take another look to see if I have addressed your comments?

Sep 14 2020, 7:03 AM · Restricted Project, Restricted Project, Restricted Project

Sep 6 2020

amyk committed rGefa57f9a7adb: [PowerPC] Implement Vector Expand Mask builtins in LLVM/Clang (authored by amyk).
[PowerPC] Implement Vector Expand Mask builtins in LLVM/Clang
Sep 6 2020, 3:14 PM
amyk closed D82727: [PowerPC] Implement Vector Expand Mask builtins in LLVM/Clang.
Sep 6 2020, 3:13 PM · Restricted Project, Restricted Project

Sep 3 2020

amyk added a comment to D86252: [PowerPC] Add Set Boolean Condition Instruction Definitions and MC Tests.

Ping.

Sep 3 2020, 10:18 AM · Restricted Project
amyk added a comment to D82726: [PowerPC] Implement Vector Count Mask Bits builtins in LLVM/Clang.

Ping.

Sep 3 2020, 10:18 AM · Restricted Project, Restricted Project
amyk added a comment to D82725: [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang.

Ping.

Sep 3 2020, 10:18 AM · Restricted Project, Restricted Project, Restricted Project

Sep 1 2020

amyk committed rG0c2d872d5dec: [PowerPC] Implement builtins for xvcvspbf16 and xvcvbf16spn (authored by amyk).
[PowerPC] Implement builtins for xvcvspbf16 and xvcvbf16spn
Sep 1 2020, 3:19 PM
amyk closed D86795: [PowerPC] Implement builtins for xvcvspbf16 and xvcvbf16spn.
Sep 1 2020, 3:19 PM · Restricted Project, Restricted Project, Restricted Project
amyk committed rGca2227c1b3f5: [PowerPC] Implement instruction definitions/MC Tests for xvcvspbf16 and… (authored by amyk).
[PowerPC] Implement instruction definitions/MC Tests for xvcvspbf16 and…
Sep 1 2020, 9:00 AM
amyk closed D86794: [PowerPC] Implement instruction definitions/MC Tests for xvcvspbf16 and xvcvbf16spn.
Sep 1 2020, 9:00 AM · Restricted Project, Restricted Project

Aug 28 2020

amyk requested review of D86795: [PowerPC] Implement builtins for xvcvspbf16 and xvcvbf16spn.
Aug 28 2020, 10:13 AM · Restricted Project, Restricted Project, Restricted Project
amyk requested review of D86794: [PowerPC] Implement instruction definitions/MC Tests for xvcvspbf16 and xvcvbf16spn.
Aug 28 2020, 10:08 AM · Restricted Project, Restricted Project

Aug 26 2020

amyk committed rG76b0f99ea854: [PowerPC] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang (authored by amyk).
[PowerPC] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang
Aug 26 2020, 9:15 PM
amyk closed D82609: [PowerPC] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang.
Aug 26 2020, 9:14 PM · Restricted Project, Restricted Project, Restricted Project

Aug 24 2020

amyk updated the diff for D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins..

Update to address clang-format.

Aug 24 2020, 10:35 AM · Restricted Project, Restricted Project, Restricted Project
amyk added a comment to D82726: [PowerPC] Implement Vector Count Mask Bits builtins in LLVM/Clang.

Ping.

Aug 24 2020, 10:22 AM · Restricted Project, Restricted Project
amyk added a comment to D82725: [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang.

Ping.

Aug 24 2020, 10:21 AM · Restricted Project, Restricted Project, Restricted Project
amyk updated the diff for D82727: [PowerPC] Implement Vector Expand Mask builtins in LLVM/Clang.

Update clang test names for vec_expandm.

Aug 24 2020, 10:20 AM · Restricted Project, Restricted Project

Aug 21 2020

amyk updated the diff for D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins..

Address review comments:

  • Further consolidate the custom codegen of the two builtins
  • Add SemaChecking for if the third argument is a constant, if the third argument is in range and if the second argument is the same type as the element type of the first argument
  • Add extra test to test the semantic checks that were added
Aug 21 2020, 6:42 PM · Restricted Project, Restricted Project, Restricted Project

Aug 19 2020

amyk requested review of D86252: [PowerPC] Add Set Boolean Condition Instruction Definitions and MC Tests.
Aug 19 2020, 4:25 PM · Restricted Project

Aug 17 2020

amyk added inline comments to D82609: [PowerPC] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang.
Aug 17 2020, 7:32 PM · Restricted Project, Restricted Project, Restricted Project
amyk committed rGc7ec3a7e338c: [PowerPC] Implement Vector Extract Mask builtins in LLVM/Clang (authored by amyk).
[PowerPC] Implement Vector Extract Mask builtins in LLVM/Clang
Aug 17 2020, 7:15 PM
amyk closed D82675: [PowerPC] Implement Vector Extract Mask builtins in LLVM/Clang.
Aug 17 2020, 7:14 PM · Restricted Project, Restricted Project, Restricted Project

Aug 11 2020

amyk added a comment to D83560: [DebugInfo] Emit DW_OP_implicit_value for Floating point constants.

Thanks @MaskRay for pointers. Tried similar approach(slightly different, since expression has to be emitted by a separate streamer owned by DebugLocDwarfExpression) to take care of Endianess.

  • Temporarily removed long double support since IMHO this might require a deeper surgery. Patch reflects the overall skeleton required for suporting DW_OP_implicit_value.
  • @amyk, is it possible for you to try this patch on PPC targets ? So that we won't end up having surprises.
Aug 11 2020, 8:49 AM · debug-info, Restricted Project

Aug 10 2020

amyk added a comment to D82609: [PowerPC] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang.

Ping.

Aug 10 2020, 9:44 AM · Restricted Project, Restricted Project, Restricted Project

Aug 9 2020

amyk accepted D83338: [PowerPC][Power10] Implemented Vector Shift Builtins.

Thanks for addressing the comments. LGTM.

Aug 9 2020, 9:04 PM · Restricted Project, Restricted Project, Restricted Project

Aug 7 2020

amyk added a comment to D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend.

I realized I didn't put a comment on this earlier but this overall LGTM, but I think it would be good to see if @nemanjai has any additional comments on this patch.

Aug 7 2020, 10:50 AM · Restricted Project, Restricted Project, Restricted Project
amyk committed rG98eccec3ae3e: [PowerPC] Add Vector Extract/Expand/Count with Mask, Move to VSR Mask… (authored by amyk).
[PowerPC] Add Vector Extract/Expand/Count with Mask, Move to VSR Mask…
Aug 7 2020, 9:06 AM
amyk closed D83724: [PowerPC][Power10] Add Vector Extract/Expand/Count with Mask, Move to VSR Mask Instruction Definitions and MC Tests.
Aug 7 2020, 9:06 AM · Restricted Project, Restricted Project

Aug 6 2020

amyk accepted D85453: [PowerPC] Implement __int128 vector divide operations.

Overall LGTM.

Aug 6 2020, 10:45 PM · Restricted Project, Restricted Project, Restricted Project
amyk added inline comments to D83338: [PowerPC][Power10] Implemented Vector Shift Builtins.
Aug 6 2020, 10:41 PM · Restricted Project, Restricted Project, Restricted Project
amyk accepted D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend.
Aug 6 2020, 7:58 AM · Restricted Project, Restricted Project, Restricted Project

Aug 5 2020

amyk added inline comments to D83338: [PowerPC][Power10] Implemented Vector Shift Builtins.
Aug 5 2020, 12:22 PM · Restricted Project, Restricted Project, Restricted Project

Aug 4 2020

amyk updated the diff for D82725: [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang.

Rebased patch, and removed MC tests from the original patch.

Aug 4 2020, 8:02 PM · Restricted Project, Restricted Project, Restricted Project
amyk updated the diff for D82726: [PowerPC] Implement Vector Count Mask Bits builtins in LLVM/Clang.

Rebased patch and removed MC tests from the patch.

Aug 4 2020, 7:17 PM · Restricted Project, Restricted Project
amyk added inline comments to D82727: [PowerPC] Implement Vector Expand Mask builtins in LLVM/Clang.
Aug 4 2020, 5:03 PM · Restricted Project, Restricted Project
amyk updated the diff for D82727: [PowerPC] Implement Vector Expand Mask builtins in LLVM/Clang.

Rebased the patch and removed MC tests.

Aug 4 2020, 5:01 PM · Restricted Project, Restricted Project
amyk added inline comments to D84359: [PowerPC] Add vector pair load/store instructions and vector pair register class.
Aug 4 2020, 4:41 PM · Restricted Project, Restricted Project
amyk added inline comments to D83338: [PowerPC][Power10] Implemented Vector Shift Builtins.
Aug 4 2020, 7:33 AM · Restricted Project, Restricted Project, Restricted Project
amyk accepted D84622: [PowerPC] Implement Vector Extract Low/High Order Builtins in LLVM/Clang.

I think overall it LGTM and the indentation can be addressed when committing.

Aug 4 2020, 7:07 AM · Restricted Project, Restricted Project

Jul 31 2020

amyk committed rG93fd8dbdc250: [PowerPC] Add Vector String Isolate instruction definitions and MC Tests (authored by Conanap).
[PowerPC] Add Vector String Isolate instruction definitions and MC Tests
Jul 31 2020, 10:33 AM
amyk closed D84197: [PowerPC][Power10] Vector String Isolate instruction definitions and MC Tests.
Jul 31 2020, 10:32 AM · Restricted Project, Restricted Project, Restricted Project
amyk committed rGc4e574323210: [PowerPC] Implement low-order Vector Modulus Builtins, and add Vector… (authored by amyk).
[PowerPC] Implement low-order Vector Modulus Builtins, and add Vector…
Jul 31 2020, 9:16 AM
amyk closed D82576: [PowerPC][Power10] Implement low-order Vector Modulus Builtins, and add Vector Multiply/Divide/Modulus Builtins Tests.
Jul 31 2020, 9:15 AM · Restricted Project, Restricted Project, Restricted Project

Jul 27 2020

amyk added a comment to D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend.

Could we also elaborate in the description on how we are utilizing the new load instructions for zero extend case but not the sign extend case?

Jul 27 2020, 9:45 PM · Restricted Project, Restricted Project, Restricted Project
amyk accepted D84197: [PowerPC][Power10] Vector String Isolate instruction definitions and MC Tests.

Thanks for recovering the tests. LGTM.

Jul 27 2020, 9:45 PM · Restricted Project, Restricted Project, Restricted Project
amyk updated the diff for D82675: [PowerPC] Implement Vector Extract Mask builtins in LLVM/Clang.
  • Rebased patch
  • Updated patch to remove instruction definitions and MC tests
Jul 27 2020, 9:45 PM · Restricted Project, Restricted Project, Restricted Project
amyk updated the diff for D82609: [PowerPC] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang.

Addressed the following comments:

  • updated CHECK lines to check for the full intrinsic call
  • updated indentation
Jul 27 2020, 4:28 PM · Restricted Project, Restricted Project, Restricted Project
amyk updated the summary of D82675: [PowerPC] Implement Vector Extract Mask builtins in LLVM/Clang.
Jul 27 2020, 4:00 PM · Restricted Project, Restricted Project, Restricted Project
amyk updated the summary of D82727: [PowerPC] Implement Vector Expand Mask builtins in LLVM/Clang.
Jul 27 2020, 4:00 PM · Restricted Project, Restricted Project