Page MenuHomePhabricator

amyk (Amy Kwan)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 4 2018, 10:36 AM (80 w, 5 d)

Recent Activity

Fri, Jan 17

amyk added a comment to D72250: [NFC][PowerPC] Refactor the tryAndWithMask().

Just some minor comments, I think it overall LGTM but am curious in knowing any comments from others.

Fri, Jan 17, 3:49 PM · Restricted Project

Thu, Jan 16

amyk added inline comments to D72574: [PowerPC][Future] Add pld and pstd to future CPU.
Thu, Jan 16, 4:12 PM · Restricted Project, Restricted Project
amyk added inline comments to D72569: [PowerPC][Future] Add prefixed instruction paddi to future CPU.
Thu, Jan 16, 3:53 PM · Restricted Project, Restricted Project

Mon, Jan 13

amyk added inline comments to D72572: [PowerPC][Future] Branch Distance Estimation For Prefixed Instructions.
Mon, Jan 13, 6:50 PM · Restricted Project, Restricted Project

Thu, Jan 9

amyk added inline comments to D69066: Add support for intrinsic llvm.ppc.eieio.
Thu, Jan 9, 8:44 PM · Restricted Project
amyk added inline comments to D69835: Add options for PPC to enable/disable using non-volatile CR.
Thu, Jan 9, 8:43 PM · Restricted Project

Thu, Jan 2

amyk added a comment to D71829: [PowerPC] Exploit the rlwinm instructions for "and" with constant..

Just curious about a specific portion of your patch, so I posted a comment.

Thu, Jan 2, 8:34 PM · Restricted Project
amyk added a comment to D71693: [NFC][PowerPC] Add a function tryAndWithMask.

One minor comment from me. I also agree with what has been stated previously (to try to simplify tryAndWithMask()).

Thu, Jan 2, 7:58 PM · Restricted Project

Nov 23 2019

amyk committed rGd1dded28da28: [PowerPC] Spill CR LT bits on P9 using setb (authored by amyk).
[PowerPC] Spill CR LT bits on P9 using setb
Nov 23 2019, 10:52 PM
amyk closed D68443: [PowerPC] Spill CR LT bits on P9 using setb.
Nov 23 2019, 10:52 PM · Restricted Project
amyk accepted D69730: [compiler-rt][builtins][PowerPC] Add __fixtfti builtin on PowerPC.

This also LGTM.

Nov 23 2019, 8:38 PM · Restricted Project, Restricted Project
amyk added inline comments to D69168: [PowerPC] Fold redundant load immediates of zero and delete if possible.
Nov 23 2019, 3:21 PM · Restricted Project

Nov 21 2019

amyk committed rGc84c62c50aa8: [CMake] Fix LLVM build non-determinism on RHEL (authored by amyk).
[CMake] Fix LLVM build non-determinism on RHEL
Nov 21 2019, 9:19 PM
amyk closed D64817: [CMake] Fix LLVM build non-determinism on RHEL.
Nov 21 2019, 9:19 PM · Restricted Project
amyk added a comment to D64817: [CMake] Fix LLVM build non-determinism on RHEL.

@tstellar Yes, I will commit this patch and also open a bugzilla for back porting.

Nov 21 2019, 9:09 PM · Restricted Project

Nov 12 2019

amyk added a comment to D64817: [CMake] Fix LLVM build non-determinism on RHEL.

Does anyone else have any specific comments regarding this patch?

Nov 12 2019, 8:56 PM · Restricted Project

Nov 3 2019

amyk added inline comments to D69601: [Power9] Implement the vector extend sign instruction pattern match.
Nov 3 2019, 7:27 PM · Restricted Project
amyk accepted D69443: [PowerPC] Test case for vector float gather on ppc64le and ppc64.

LGTM.

Nov 3 2019, 7:24 PM · Restricted Project

Oct 30 2019

amyk accepted D69193: [compiler-rt][builtins][PowerPC] Fix __fixunstfti builtin on PowerPC.

This also LGTM. Thanks for fixing.

Oct 30 2019, 10:12 AM · Restricted Project, Restricted Project

Oct 19 2019

amyk added inline comments to D69168: [PowerPC] Fold redundant load immediates of zero and delete if possible.
Oct 19 2019, 10:18 PM · Restricted Project

Oct 18 2019

amyk added inline comments to D62908: [PowerPC] Improve float vector gather codegen.
Oct 18 2019, 3:37 PM · Restricted Project
amyk added inline comments to D69108: [PowerPC] Clang Option for enabling absolute jumptables with command line.
Oct 18 2019, 3:37 PM · Restricted Project

Oct 17 2019

amyk added a comment to D69108: [PowerPC] Clang Option for enabling absolute jumptables with command line.

I have the same nits as @NeHuang, but this overall also looks good to me.

Oct 17 2019, 1:22 PM · Restricted Project
amyk updated the diff for D64817: [CMake] Fix LLVM build non-determinism on RHEL.

Updated with more specific comment.

Oct 17 2019, 12:17 PM · Restricted Project
amyk added inline comments to D64817: [CMake] Fix LLVM build non-determinism on RHEL.
Oct 17 2019, 12:17 PM · Restricted Project

Oct 16 2019

amyk updated the diff for D64817: [CMake] Fix LLVM build non-determinism on RHEL.

Updated with appropriate diff.

Oct 16 2019, 9:22 AM · Restricted Project

Oct 15 2019

amyk added a comment to D64817: [CMake] Fix LLVM build non-determinism on RHEL.

The intention was simply to fix non determinism when building on RHEL, and the version checks were simply to make sure that this patch only gets applied to versions of ar/ranlib that support it.

Oct 15 2019, 12:41 PM · Restricted Project

Oct 11 2019

amyk added inline comments to D68576: [PowerPC] Fix VSX clobbers of CSR registers.
Oct 11 2019, 10:46 PM · Restricted Project
amyk added a comment to D68443: [PowerPC] Spill CR LT bits on P9 using setb.

Ping.

Oct 11 2019, 7:27 PM · Restricted Project

Oct 6 2019

amyk committed rGe36415cacffb: [NFC][PowerPC] Reorganize CRNotPat multiclass patterns in PPCInstrInfo.td (authored by amyk).
[NFC][PowerPC] Reorganize CRNotPat multiclass patterns in PPCInstrInfo.td
Oct 6 2019, 12:46 PM
amyk committed rL373869: [NFC][PowerPC] Reorganize CRNotPat multiclass patterns in PPCInstrInfo.td.
[NFC][PowerPC] Reorganize CRNotPat multiclass patterns in PPCInstrInfo.td
Oct 6 2019, 12:43 PM
amyk closed D67975: [NFC][PowerPC] Reorganize CRNotPat multiclass patterns in PPCInstrInfo.td.
Oct 6 2019, 12:43 PM · Restricted Project

Oct 3 2019

amyk created D68443: [PowerPC] Spill CR LT bits on P9 using setb.
Oct 3 2019, 10:10 PM · Restricted Project
amyk abandoned D67981: [NFC][PowerPC] Adding FeatureFPU in the definition of FeatureISA3_0 .

Thanks @jsji and @nemanjai for your insights on this patch. I will abandon this for now.

Oct 3 2019, 9:50 PM · Restricted Project

Oct 1 2019

amyk updated the diff for D67981: [NFC][PowerPC] Adding FeatureFPU in the definition of FeatureISA3_0 .

I've realized I forgot to attach a full context patch.
Updated with full context.

Oct 1 2019, 5:02 PM · Restricted Project
amyk updated the diff for D67975: [NFC][PowerPC] Reorganize CRNotPat multiclass patterns in PPCInstrInfo.td.

I've realized I forgot to attach a full context patch.
Updated with full context.

Oct 1 2019, 4:59 PM · Restricted Project

Sep 26 2019

amyk added inline comments to D67722: [PowerPC] Remove redundant CRSET/CRUNSET in custom lowering of known CR bit spills.
Sep 26 2019, 12:37 PM · Restricted Project

Sep 24 2019

amyk created D67981: [NFC][PowerPC] Adding FeatureFPU in the definition of FeatureISA3_0 .
Sep 24 2019, 1:49 PM · Restricted Project
amyk created D67975: [NFC][PowerPC] Reorganize CRNotPat multiclass patterns in PPCInstrInfo.td.
Sep 24 2019, 11:22 AM · Restricted Project

Sep 13 2019

amyk added inline comments to D66329: [PowerPC] [Peephole] fold frame offset by using index form to save add..
Sep 13 2019, 9:07 PM · Restricted Project

Sep 12 2019

amyk added inline comments to D62993: [PowerPC] Emit scalar min/max instructions with unsafe fp math.
Sep 12 2019, 11:04 PM · Restricted Project
amyk added a comment to D66991: [PowerPC] Fix SH field overflow issue.

I think this also LGTM overall.

Sep 12 2019, 7:23 PM · Restricted Project

Sep 3 2019

amyk accepted D66902: [PowerPC] Implementing overflow version for XO-Form instructions.

I think this overall LGTM.

Sep 3 2019, 5:29 PM · Restricted Project

Aug 20 2019

amyk added inline comments to D64817: [CMake] Fix LLVM build non-determinism on RHEL.
Aug 20 2019, 6:52 AM · Restricted Project

Jul 16 2019

amyk created D64817: [CMake] Fix LLVM build non-determinism on RHEL.
Jul 16 2019, 1:35 PM · Restricted Project

Jul 11 2019

amyk added inline comments to D63624: [PowerPC] Exploit single instruction load-and-splat for word and doubleword.
Jul 11 2019, 1:42 PM · Restricted Project
amyk accepted D63624: [PowerPC] Exploit single instruction load-and-splat for word and doubleword.

I think this overall looks good. Thanks for extending this to handle the load->shuffle case!

Jul 11 2019, 12:14 PM · Restricted Project

Jun 26 2019

amyk added a comment to D63624: [PowerPC] Exploit single instruction load-and-splat for word and doubleword.

Thanks @jsji for letting me know, and thanks @nemanjai for the handling of the load and splats!

Jun 26 2019, 7:14 AM · Restricted Project

Jun 12 2019

amyk added inline comments to D61249: [NFC] Refactor the systemZ scheduler strategy to adapt with the new schedule state forwarding infrastructure.
Jun 12 2019, 10:41 AM · Restricted Project
amyk committed rG7eddb16fed94: [compiler-rt] Fix name_to_handle_at.cc test on Overlay2 (for Docker) (authored by amyk).
[compiler-rt] Fix name_to_handle_at.cc test on Overlay2 (for Docker)
Jun 12 2019, 7:17 AM
amyk committed rL363167: [compiler-rt] Fix name_to_handle_at.cc test on Overlay2 (for Docker).
[compiler-rt] Fix name_to_handle_at.cc test on Overlay2 (for Docker)
Jun 12 2019, 7:16 AM
amyk closed D63094: [compiler-rt] Fix name_to_handle_at.cc test on Overlay2.
Jun 12 2019, 7:16 AM · Restricted Project, Restricted Project

Jun 10 2019

amyk created D63094: [compiler-rt] Fix name_to_handle_at.cc test on Overlay2.
Jun 10 2019, 1:41 PM · Restricted Project, Restricted Project

May 28 2019

amyk updated the diff for D40554: [PowerPC] Fix bugs in sign-/zero-extension elimination.
  • Rebased to the latest source (fix conflicts, ran functional tests)
  • Fixed llvm/test/CodeGen/PowerPC/ppc64-P9-setb.ll to remove redundant sign extend instruction
  • Added the following check in PPCMIPeephole.cpp to only perform the LWZ->LWA transformation when the displacement is a multiple of 4
// The transformation from a zero-extending load to a sign-extending
// load is only legal when the displacement is a multiple of 4.
// If the displacement is not at least 4 byte aligned, don't perform
// the transformation.
if (SrcMI->getOperand(1).isGlobal() &&
    SrcMI->getOperand(1).getGlobal()->getAlignment() < 4)
  break;
May 28 2019, 6:34 AM · Restricted Project

May 13 2019

amyk commandeered D40554: [PowerPC] Fix bugs in sign-/zero-extension elimination.

Hi @inouehrs, I will be commandeering this revision since we are revisiting this patch.

May 13 2019, 9:43 AM · Restricted Project

May 9 2019

amyk added a comment to D61265: [lit][tests]Add feature libcxx-used and use it in llvm-*-fuzzer tests.

LGTM.

May 9 2019, 7:07 AM · Restricted Project

May 2 2019

amyk accepted D59633: [PowerPC] Look through copies for compare elimination.

This looks good to me.

May 2 2019, 1:35 PM · Restricted Project

Apr 30 2019

amyk committed rG31dbbf1df911: [compiler-rt][builtins][sanitizers] Update compiler-rt test cases for… (authored by amyk).
[compiler-rt][builtins][sanitizers] Update compiler-rt test cases for…
Apr 30 2019, 1:08 PM
amyk committed rL359606: [compiler-rt][builtins][sanitizers] Update compiler-rt test cases for.
[compiler-rt][builtins][sanitizers] Update compiler-rt test cases for
Apr 30 2019, 1:08 PM
amyk committed rCRT359606: [compiler-rt][builtins][sanitizers] Update compiler-rt test cases for.
[compiler-rt][builtins][sanitizers] Update compiler-rt test cases for
Apr 30 2019, 1:08 PM
amyk closed D60644: [compiler-rt][builtins][sanitizers] Update compiler-rt test cases for compatibility with system's toolchain .
Apr 30 2019, 1:07 PM · Restricted Project, Restricted Project
amyk added inline comments to D60644: [compiler-rt][builtins][sanitizers] Update compiler-rt test cases for compatibility with system's toolchain .
Apr 30 2019, 1:07 PM · Restricted Project, Restricted Project
amyk accepted D61016: [lit][tests]Add libc++ to link XRay test cases if libc++ is used to build CLANG.

I think this LGTM.

Apr 30 2019, 12:33 PM · Restricted Project

Apr 26 2019

amyk added inline comments to D60644: [compiler-rt][builtins][sanitizers] Update compiler-rt test cases for compatibility with system's toolchain .
Apr 26 2019, 1:55 PM · Restricted Project, Restricted Project
amyk updated the diff for D60644: [compiler-rt][builtins][sanitizers] Update compiler-rt test cases for compatibility with system's toolchain .

Updated the compiler_rt_logb_test.c to:

  • run on non-GLIBC systems
  • consistent use of _GLIBC_PREREQ macros in compiler-rt
Apr 26 2019, 1:54 PM · Restricted Project, Restricted Project

Apr 25 2019

amyk updated the diff for D60644: [compiler-rt][builtins][sanitizers] Update compiler-rt test cases for compatibility with system's toolchain .

With the assistance of @hubert.reinterpretcast, I have updated the sanitizer-common test case, getpw_getgr.cc to avoid the use of std::string as this can result in a false positive.

Apr 25 2019, 6:57 PM · Restricted Project, Restricted Project
amyk added inline comments to D60644: [compiler-rt][builtins][sanitizers] Update compiler-rt test cases for compatibility with system's toolchain .
Apr 25 2019, 8:22 AM · Restricted Project, Restricted Project

Apr 24 2019

amyk added inline comments to D60644: [compiler-rt][builtins][sanitizers] Update compiler-rt test cases for compatibility with system's toolchain .
Apr 24 2019, 12:39 PM · Restricted Project, Restricted Project

Apr 23 2019

amyk added a comment to D60644: [compiler-rt][builtins][sanitizers] Update compiler-rt test cases for compatibility with system's toolchain .

@rupprecht Thanks for the insight regarding compiler_rt_logb_test.c. I have updated the patch slightly, so I am no longer modifying the other compiler-rt builtins test. Does this update look more suitable? If you're OK with the current logb test, I can just keep it as is.

Apr 23 2019, 1:23 PM · Restricted Project, Restricted Project
amyk updated the diff for D60644: [compiler-rt][builtins][sanitizers] Update compiler-rt test cases for compatibility with system's toolchain .

Originally, this patch modified the following to check for the version of GLIBC:

  • Compiler-RT builtins test cases: compiler_rt_logb_test.c, divsc3_test.c, ppc/qdiv_test.c
  • Sanitizer test case: getpw_getgr.cc
Apr 23 2019, 1:21 PM · Restricted Project, Restricted Project

Apr 15 2019

amyk added a comment to D60644: [compiler-rt][builtins][sanitizers] Update compiler-rt test cases for compatibility with system's toolchain .

@rupprecht That is true. However, isn't it possible that a system's most up to date GLIBC version is still lower than say, GLIBC 2.23? Starting a conversation on which GLIBC versions are important can possibly be something that can be done.

Apr 15 2019, 5:29 PM · Restricted Project, Restricted Project
amyk added a comment to D60644: [compiler-rt][builtins][sanitizers] Update compiler-rt test cases for compatibility with system's toolchain .

@hubert.reinterpretcast Thank you for reviewing and bringing up these concerns, I do understand and you do have a point.

Apr 15 2019, 5:14 PM · Restricted Project, Restricted Project

Apr 14 2019

amyk updated the diff for D60644: [compiler-rt][builtins][sanitizers] Update compiler-rt test cases for compatibility with system's toolchain .

I have forgot to attach the full context of my initial patch. I apologize for this.

Apr 14 2019, 12:39 PM · Restricted Project, Restricted Project
amyk added a comment to D60644: [compiler-rt][builtins][sanitizers] Update compiler-rt test cases for compatibility with system's toolchain .

@hubert.reinterpretcast My apologies, you're right, I forgot to upload the full context. I will do that first, and address your comments afterwards.

Apr 14 2019, 12:38 PM · Restricted Project, Restricted Project

Apr 12 2019

amyk created D60644: [compiler-rt][builtins][sanitizers] Update compiler-rt test cases for compatibility with system's toolchain .
Apr 12 2019, 7:14 PM · Restricted Project, Restricted Project
amyk updated subscribers of D60539: Add -std=c++14 language standard option to tests that require C++14 default.
Apr 12 2019, 7:13 AM · Restricted Project, Restricted Project

Apr 10 2019

amyk created D60539: Add -std=c++14 language standard option to tests that require C++14 default.
Apr 10 2019, 2:19 PM · Restricted Project, Restricted Project
amyk accepted D59843: [PowerPC] Add support for __dcbf builtin.

I think this still looks good to me, with the addition of the documentation.

Apr 10 2019, 1:52 PM · Restricted Project, Restricted Project

Mar 29 2019

amyk accepted D59384: Fix reversed bit issue in DCMX mask for "xvtstdcdp" and "xvtstdcsp" P9 implementation.

Looks good, thank you for fixing and adding the test case.

Mar 29 2019, 7:46 AM · Restricted Project

Mar 28 2019

amyk accepted D59843: [PowerPC] Add support for __dcbf builtin.

This looks good to me.

Mar 28 2019, 11:26 AM · Restricted Project, Restricted Project

Feb 13 2019

amyk added inline comments to D57857: [PowerPC] custom lower `v2f64 fpext v2f32`.
Feb 13 2019, 9:45 AM · Restricted Project

Feb 1 2019

amyk added a comment to rL352803: Make clang/test/Index/pch-from-libclang.c pass in more places.

Hi, I believe this is causing Buildbot failures for PowerPC: http://lab.llvm.org:8011/builders/clang-ppc64le-linux-multistage

Feb 1 2019, 4:46 AM

Jan 22 2019

amyk added a comment to rL351792: [clangd] Support clang-tidy configuration in clangd..

This is causing buildbot failures for PowerPC: http://lab.llvm.org:8011/builders/clang-ppc64le-linux-multistage

Jan 22 2019, 10:34 AM

Jan 15 2019

amyk closed D54313: [compiler-rt][builtins][PowerPC] Add floattitf builtin compiler-rt method support for PowerPC .

Amy, can we get this committed?

Jan 15 2019, 3:58 AM

Jan 10 2019

amyk committed rL350818: [compiler-rt][builtins][PowerPC] Implemented __floattitf builtin on PowerPC.
[compiler-rt][builtins][PowerPC] Implemented __floattitf builtin on PowerPC
Jan 10 2019, 5:27 AM
amyk committed rCRT350818: [compiler-rt][builtins][PowerPC] Implemented __floattitf builtin on PowerPC.
[compiler-rt][builtins][PowerPC] Implemented __floattitf builtin on PowerPC
Jan 10 2019, 5:27 AM
amyk committed rCRT350815: [compiler-rt][builtins][PowerPC] Implemented __fixunstfti builtin on PowerPC.
[compiler-rt][builtins][PowerPC] Implemented __fixunstfti builtin on PowerPC
Jan 10 2019, 4:35 AM
amyk committed rL350815: [compiler-rt][builtins][PowerPC] Implemented __fixunstfti builtin on PowerPC.
[compiler-rt][builtins][PowerPC] Implemented __fixunstfti builtin on PowerPC
Jan 10 2019, 4:35 AM
amyk closed D54911: [compiler-rt][builtins][PowerPC] Add ___fixunstfti builtin compiler-rt method support for PowerPC .
Jan 10 2019, 4:35 AM

Jan 3 2019

amyk updated the diff for D54313: [compiler-rt][builtins][PowerPC] Add floattitf builtin compiler-rt method support for PowerPC .

Updated patch to address:

  • renamed variables for names that adhere more to LLVM naming conventions
  • changed the low part of the function argument to unsigned, as it will later be passed into a function that expects an unsigned argument
  • Removed a temporary that represented 2^64.
Jan 3 2019, 5:25 AM
amyk added inline comments to D54313: [compiler-rt][builtins][PowerPC] Add floattitf builtin compiler-rt method support for PowerPC .
Jan 3 2019, 5:23 AM

Dec 20 2018

amyk updated the diff for D54313: [compiler-rt][builtins][PowerPC] Add floattitf builtin compiler-rt method support for PowerPC .

Updated this patch with:

  • initialization of int128 macro to simplify test cases
Dec 20 2018, 1:11 PM
amyk updated the diff for D54911: [compiler-rt][builtins][PowerPC] Add ___fixunstfti builtin compiler-rt method support for PowerPC .

Updated this patch to address:

  • Updated comments that are more descriptive
  • Renamed variables
  • Removed the macro originally used to group up common code. Since the code that seems duplicated is not entirely identical, the code will remain duplicated as utilizing a macro still requires an if-condition to control the conversion depending if we are converting and high double or a low double
Dec 20 2018, 12:05 PM
amyk added inline comments to D54911: [compiler-rt][builtins][PowerPC] Add ___fixunstfti builtin compiler-rt method support for PowerPC .
Dec 20 2018, 11:59 AM
amyk updated the diff for D54313: [compiler-rt][builtins][PowerPC] Add floattitf builtin compiler-rt method support for PowerPC .

Updated patch to address @renenkel's review :

  • Renamed union type to represent the long double
  • Updated comments
  • Updated variable names
  • Updated algorithm to be more concise and succinct
Dec 20 2018, 10:40 AM

Dec 19 2018

amyk committed rCRT349634: [compiler-rt][builtins][PowerPC] Enable builtins tests on PowerPC 64 bit LE.
[compiler-rt][builtins][PowerPC] Enable builtins tests on PowerPC 64 bit LE
Dec 19 2018, 7:56 AM
amyk committed rL349634: [compiler-rt][builtins][PowerPC] Enable builtins tests on PowerPC 64 bit LE.
[compiler-rt][builtins][PowerPC] Enable builtins tests on PowerPC 64 bit LE
Dec 19 2018, 7:56 AM
amyk closed D54449: [compiler-rt][builtins][PowerPC] Enable builtins tests on PowerPC 64 bit LE .
Dec 19 2018, 7:56 AM
amyk committed rL349633: Test commit.
Test commit
Dec 19 2018, 7:24 AM

Dec 18 2018

amyk updated the diff for D54911: [compiler-rt][builtins][PowerPC] Add ___fixunstfti builtin compiler-rt method support for PowerPC .

Previously uploaded the wrong diff by accident.

Dec 18 2018, 9:23 AM