Page MenuHomePhabricator

amyk (Amy Kwan)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 4 2018, 10:36 AM (202 w, 5 d)

Recent Activity

Fri, May 20

amyk added a comment to D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions.

I was wondering where are the test cases in this patch. Did they get missed when updating the revision?

Fri, May 20, 3:15 PM · Restricted Project, Restricted Project

Thu, May 19

amyk committed rGc35ca3a1c78f: [PowerPC] Implement XL compat __fnabs and __fnabss builtins. (authored by amyk).
[PowerPC] Implement XL compat __fnabs and __fnabss builtins.
Thu, May 19, 9:29 AM · Restricted Project, Restricted Project, Restricted Project
amyk closed D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins..
Thu, May 19, 9:29 AM · Restricted Project, Restricted Project, Restricted Project
amyk updated the diff for D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins..
  • Add a P6+VSX run line and remove extra P7/P8 lines for backend test
Thu, May 19, 7:25 AM · Restricted Project, Restricted Project, Restricted Project
amyk added inline comments to D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins..
Thu, May 19, 7:22 AM · Restricted Project, Restricted Project, Restricted Project

Wed, May 18

amyk added a comment to D125389: [PowerPC][AIX] Allow VSX patterns to be 32-bit and 64-bit safe on P8+..

Ping.

Wed, May 18, 9:29 PM · Restricted Project, Restricted Project
amyk updated the diff for D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins..

Address review comments:

  • Remove -no-opaque-pointers and updates CHECKs
  • Simplify runs and checks of C and IR test files
Wed, May 18, 6:58 AM · Restricted Project, Restricted Project, Restricted Project

Thu, May 12

amyk updated the summary of D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins..
Thu, May 12, 4:14 PM · Restricted Project, Restricted Project, Restricted Project
amyk requested review of D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins..
Thu, May 12, 4:08 PM · Restricted Project, Restricted Project, Restricted Project

Wed, May 11

amyk added a reviewer for D125389: [PowerPC][AIX] Allow VSX patterns to be 32-bit and 64-bit safe on P8+.: RolandF.
Wed, May 11, 7:36 AM · Restricted Project, Restricted Project
amyk requested review of D125389: [PowerPC][AIX] Allow VSX patterns to be 32-bit and 64-bit safe on P8+..
Wed, May 11, 7:33 AM · Restricted Project, Restricted Project

Tue, May 10

amyk committed rG0c1000cbd6d2: [NFC][PowerPC] Add 32-bit AIX RUN lines to test cases. (authored by amyk).
[NFC][PowerPC] Add 32-bit AIX RUN lines to test cases.
Tue, May 10, 7:44 AM · Restricted Project, Restricted Project

Mon, May 2

amyk added inline comments to D124060: [PowerPC] Enable CR bits support for Power8 and above..
Mon, May 2, 10:10 AM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project
amyk committed rG2534dc120a4c: [PowerPC] Enable CR bits support for Power8 and above. (authored by amyk).
[PowerPC] Enable CR bits support for Power8 and above.
Mon, May 2, 10:07 AM · Restricted Project, Restricted Project, Restricted Project
amyk closed D124060: [PowerPC] Enable CR bits support for Power8 and above..
Mon, May 2, 10:06 AM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project

Tue, Apr 26

amyk added inline comments to D124060: [PowerPC] Enable CR bits support for Power8 and above..
Tue, Apr 26, 10:36 PM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project
amyk updated the diff for D124060: [PowerPC] Enable CR bits support for Power8 and above..

Address review comments of adding documentation to clang/docs/ClangCommandLineReference.rst and adding AIX checks to clang/test/Driver/ppc-crbits.cpp.

Tue, Apr 26, 10:35 PM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project

Apr 22 2022

amyk accepted D123997: [PowerPC] Bail out of FISel when lowering long calls.

LGTM.

Apr 22 2022, 3:38 PM · Restricted Project, Restricted Project

Apr 20 2022

amyk added a comment to D119136: [clang] Implement Change scope of lambda trailing-return-type.

We've also been seeing failures in our downstream Arm compiler when running the Perennial C++14 compliance tests related to this change. Specifically, the tests expect a diagnostic to be issued when the lambda capture variable is outside of the lambda's {} scope. Another tests uses the lambda capture variable in a decltype-style return type which is also outside of the scope.

Do these failures sound like what others have run into?

Apr 20 2022, 11:44 AM · Restricted Project, Restricted Project

Apr 19 2022

amyk requested review of D124060: [PowerPC] Enable CR bits support for Power8 and above..
Apr 19 2022, 8:09 PM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project

Apr 17 2022

amyk added a comment to D123543: [NFC][PowerPC] Move the Regsiter Operands for PowerPC into PPCRegisterInfo.td.

Also, a minor nit I found, but please do update the title and description of the revision to say register rather than regsiter.

Apr 17 2022, 11:02 PM · Restricted Project, Restricted Project

Apr 15 2022

amyk accepted D123543: [NFC][PowerPC] Move the Regsiter Operands for PowerPC into PPCRegisterInfo.td.

I think this LGTM.

Apr 15 2022, 7:33 PM · Restricted Project, Restricted Project

Apr 4 2022

amyk accepted D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once.

Thanks Quinn. I think this overall LGTM.

Apr 4 2022, 6:24 AM · Restricted Project, Restricted Project

Mar 28 2022

amyk added a comment to D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once.

Overall this change looks good to me, although I do have one question.

Mar 28 2022, 6:19 AM · Restricted Project, Restricted Project

Mar 26 2022

amyk accepted D121430: [PowerPC] Fix lowering of byval parameters for sizes greater than 8 bytes..

I think this also LGTM.

Mar 26 2022, 8:47 AM · Restricted Project, Restricted Project

Mar 8 2022

Herald added a project to D119109: [clang][AIX] Enable LTO and teach the driver to pass options to the plugin: Restricted Project.

Thanks for adding this David, I think this makes sense and LGTM, too.

Mar 8 2022, 7:18 AM · Restricted Project
amyk added inline comments to D120980: [PowerPC] make splat struct like an array for function arguments.
Mar 8 2022, 7:18 AM · Restricted Project, Restricted Project

Feb 15 2022

amyk committed rG5dc0a1657be1: [PowerPC] Fix __builtin_pdepd and __builtin_pextd to be 64-bit and P10 only. (authored by amyk).
[PowerPC] Fix __builtin_pdepd and __builtin_pextd to be 64-bit and P10 only.
Feb 15 2022, 10:31 AM
amyk closed D118753: [PowerPC] Fix __builtin_pdepd and __builtin_pextd to be 64-bit and P10 only..
Feb 15 2022, 10:31 AM · Restricted Project, Unknown Object (Project), Restricted Project
amyk committed rGac5a5a9cfe7c: [PowerPC] Add default handling for single element vectors, and split/promote… (authored by amyk).
[PowerPC] Add default handling for single element vectors, and split/promote…
Feb 15 2022, 6:44 AM
amyk closed D119521: [PowerPC] Add default handling for single element vectors, and split/promote vNi1 vectors..
Feb 15 2022, 6:44 AM · Unknown Object (Project), Restricted Project

Feb 14 2022

amyk added a comment to D118753: [PowerPC] Fix __builtin_pdepd and __builtin_pextd to be 64-bit and P10 only..

Ping.

Feb 14 2022, 6:53 AM · Restricted Project, Unknown Object (Project), Restricted Project

Feb 11 2022

amyk committed rGdb691903d268: [test-release.sh] Add option to disable building clang-tools-extra during… (authored by amyk).
[test-release.sh] Add option to disable building clang-tools-extra during…
Feb 11 2022, 5:50 AM
amyk closed D119520: [test-release.sh] Add option to disable building clang-tools-extra during release testing..
Feb 11 2022, 5:50 AM · Unknown Object (Project), Restricted Project

Feb 10 2022

amyk requested review of D119521: [PowerPC] Add default handling for single element vectors, and split/promote vNi1 vectors..
Feb 10 2022, 10:13 PM · Unknown Object (Project), Restricted Project
amyk requested review of D119520: [test-release.sh] Add option to disable building clang-tools-extra during release testing..
Feb 10 2022, 10:04 PM · Unknown Object (Project), Restricted Project
amyk added inline comments to D117355: [PowerPC] Fix the undef virtual register reading failure for PPC backend trap optimization .
Feb 10 2022, 9:18 AM · Restricted Project

Feb 7 2022

amyk updated subscribers of rG413b35cd74e4: [test-release.sh] Set TEST_SUITE_HOST_CC to the release testing build compiler….

@tstellar I was wondering if it's possible to cherry-pick this patch to the LLVM 14 release branch/how can we go about backporting this patch? Any assistance is greatly appreciated!

Feb 7 2022, 11:25 AM

Feb 4 2022

amyk added a comment to D118357: [test-release.sh] Set TEST_SUITE_HOST_CC to the release testing build compiler when compiling test-suite tools..

This seems fine.

Feb 4 2022, 8:21 AM · Restricted Project

Feb 3 2022

amyk committed rG413b35cd74e4: [test-release.sh] Set TEST_SUITE_HOST_CC to the release testing build compiler… (authored by amyk).
[test-release.sh] Set TEST_SUITE_HOST_CC to the release testing build compiler…
Feb 3 2022, 7:32 PM
amyk closed D118357: [test-release.sh] Set TEST_SUITE_HOST_CC to the release testing build compiler when compiling test-suite tools..
Feb 3 2022, 7:32 PM · Restricted Project
amyk added a comment to D118357: [test-release.sh] Set TEST_SUITE_HOST_CC to the release testing build compiler when compiling test-suite tools..

@tstellar Just wanted to double check with you in case you had any objections to this patch. I'd like to commit it and would also like it added to the release branch (after it's committed).

Feb 3 2022, 1:25 PM · Restricted Project

Feb 1 2022

amyk requested review of D118753: [PowerPC] Fix __builtin_pdepd and __builtin_pextd to be 64-bit and P10 only..
Feb 1 2022, 8:51 PM · Restricted Project, Unknown Object (Project), Restricted Project
amyk added a comment to D112748: [release] Use the Bootstrapping build for building LLVM releases.

Rebase onto main. Gentle ping!

Feb 1 2022, 2:58 PM · Restricted Project
amyk committed rG0d6e64755acf: [PowerPC] Update P10 vector insert patterns to use refactored load/stores, and… (authored by amyk).
[PowerPC] Update P10 vector insert patterns to use refactored load/stores, and…
Feb 1 2022, 6:48 AM
amyk closed D115691: [PowerPC] Update P10 vector insert patterns to use refactored load/stores, and update handling of v4f32 vector insert..
Feb 1 2022, 6:48 AM · Unknown Object (Project), Restricted Project

Jan 29 2022

amyk committed rT9c7e64ebbf94: [test-suite][AIX] Disable SingleSource/UnitTests/2007-04-25-weak on AIX. (authored by amyk).
[test-suite][AIX] Disable SingleSource/UnitTests/2007-04-25-weak on AIX.
Jan 29 2022, 7:22 AM
amyk closed D115285: [test-suite][AIX] Disable SingleSource/UnitTests/2007-04-25-weak on AIX..
Jan 29 2022, 7:22 AM · Unknown Object (Project)

Jan 28 2022

amyk accepted D117716: [zorg] Remove the clang-ppc64be-linux bot.

Also LGTM.

Jan 28 2022, 6:24 AM
amyk committed rG9cc5b064f185: [PowerPC] Update handling of splat loads for v4i32/v4f32/v2i64 to require non… (authored by amyk).
[PowerPC] Update handling of splat loads for v4i32/v4f32/v2i64 to require non…
Jan 28 2022, 6:23 AM
amyk closed D117803: [PowerPC] Update handling of splat loads for v4i32/v4f32/v2i64 to require non-extending loads..
Jan 28 2022, 6:23 AM · Unknown Object (Project), Restricted Project

Jan 27 2022

amyk requested review of D118357: [test-release.sh] Set TEST_SUITE_HOST_CC to the release testing build compiler when compiling test-suite tools..
Jan 27 2022, 5:49 AM · Restricted Project

Jan 26 2022

amyk added inline comments to D112748: [release] Use the Bootstrapping build for building LLVM releases.
Jan 26 2022, 10:26 AM · Restricted Project

Jan 25 2022

amyk added inline comments to D117355: [PowerPC] Fix the undef virtual register reading failure for PPC backend trap optimization .
Jan 25 2022, 7:00 AM · Restricted Project
amyk added inline comments to D118142: [PowerPC] Update ppc-prevent-mma-types.ll with custom opt pipeline.
Jan 25 2022, 6:48 AM · Restricted Project
amyk added inline comments to D113900: [PowerPC] Prevent the optimizer from producing wide vector types in IR..
Jan 25 2022, 6:45 AM · Restricted Project, Unknown Object (Project)
amyk requested review of D118142: [PowerPC] Update ppc-prevent-mma-types.ll with custom opt pipeline.
Jan 25 2022, 6:45 AM · Restricted Project
amyk accepted D117006: [PowerPC] Add custom lowering for SELECT_CC fp128 using xsmaxcqp.

Overall LGTM.

Jan 25 2022, 6:20 AM · Restricted Project
amyk accepted D118036: [PowerPC] Add the Power10 XS[MAX|MIN]CQP instruction..

LGTM, too.

Jan 25 2022, 6:20 AM · Restricted Project

Jan 21 2022

amyk accepted D116743: [PowerPC] Add assembly comments for instructions that use the vector registers..

nit: The description has regsiter a number of times, please update it to register

This a ver useful patch. Thanks Stefan! I have a question (might be silly but...), if verbose asm is enabled by default, does it require an update to more than the two test cases that you've updated in this patch?
(I guess what I am getting at here is if verbose asm is enabled by default, I would have expected a whole bunch of other tests to also require updating, but I may be misunderstanding here.)

For some reason I always seem to typo the word register. Not sure why... Anyway, thank you for finding them.

Not a silly question at all!
Initially I thought that I didn't need to update the tests because I wan't changing code and the CHECK/CHECK-NEXT lines don't really care that there are comments that come after the instructions. This is true in most cases but there are tests that already have a comment after the instruction line (for example # 8-byte Folded Spill) and in those cases by adding a second comment I'm adding a new line and the CHECK-NEXT lines don't work anymore. Anyway, I'm going to update those tests now.

Jan 21 2022, 2:20 PM · Restricted Project
amyk updated the diff for D115691: [PowerPC] Update P10 vector insert patterns to use refactored load/stores, and update handling of v4f32 vector insert..

Address Nemanja's comments:

  • Pulling out the code and guarding it for P9 and above
  • Update test cases affected by the change
  • Update the handling to:
    • Bitcast the vector
    • Bitcast the scalar
    • Produce the v4i32 vector insert
    • Bitcast and return the result
Jan 21 2022, 1:17 PM · Unknown Object (Project), Restricted Project
amyk updated the diff for D117803: [PowerPC] Update handling of splat loads for v4i32/v4f32/v2i64 to require non-extending loads..

Address Nemanja's review comments:

  • Add a comment as to why extending loads are allowed for i8/i16 types (because they're not legal types)
  • Change the cast to LoadSDNode to dyn_cast, add early exits
Jan 21 2022, 12:13 PM · Unknown Object (Project), Restricted Project

Jan 20 2022

amyk requested review of D117803: [PowerPC] Update handling of splat loads for v4i32/v4f32/v2i64 to require non-extending loads..
Jan 20 2022, 9:45 AM · Unknown Object (Project), Restricted Project

Jan 19 2022

amyk added a comment to D115691: [PowerPC] Update P10 vector insert patterns to use refactored load/stores, and update handling of v4f32 vector insert..

Ping.

Jan 19 2022, 7:46 AM · Unknown Object (Project), Restricted Project

Jan 11 2022

amyk added a comment to D115691: [PowerPC] Update P10 vector insert patterns to use refactored load/stores, and update handling of v4f32 vector insert..

Ping.

Jan 11 2022, 7:35 PM · Unknown Object (Project), Restricted Project

Jan 7 2022

amyk added inline comments to D40554: [PowerPC] Fix bugs in sign-/zero-extension elimination.
Jan 7 2022, 7:11 AM · Restricted Project, Restricted Project
amyk added inline comments to D114800: [PowerPC] Replace MFVSRLD with MFVSRD when the vector is symmetrical.
Jan 7 2022, 7:03 AM · Restricted Project
amyk added a comment to D116743: [PowerPC] Add assembly comments for instructions that use the vector registers..

nit: The description has regsiter a number of times, please update it to register

Jan 7 2022, 6:59 AM · Restricted Project

Jan 6 2022

amyk added a comment to D115042: [test-suite] Use CMAKE_C_COMPILER as TEST_SUITE_HOST_CC when compiling test-suite tools. .

Thanks for the insight into the problem on the macOS side, @paquette.
@Meinersbur I was also wondering if you also have any thoughts regarding this issue?

Jan 6 2022, 5:54 AM

Dec 16 2021

amyk added a reverting change for rTe736520bca48: [test-suite] Use CMAKE_C_COMPILER as TEST_SUITE_HOST_CC when compiling test…: rTa77ad335b95d: Revert "[test-suite] Use CMAKE_C_COMPILER as TEST_SUITE_HOST_CC when compiling….
Dec 16 2021, 10:48 PM
amyk added a reverting change for D115042: [test-suite] Use CMAKE_C_COMPILER as TEST_SUITE_HOST_CC when compiling test-suite tools. : rTa77ad335b95d: Revert "[test-suite] Use CMAKE_C_COMPILER as TEST_SUITE_HOST_CC when compiling….
Dec 16 2021, 10:48 PM
amyk committed rTa77ad335b95d: Revert "[test-suite] Use CMAKE_C_COMPILER as TEST_SUITE_HOST_CC when compiling… (authored by amyk).
Revert "[test-suite] Use CMAKE_C_COMPILER as TEST_SUITE_HOST_CC when compiling…
Dec 16 2021, 10:48 PM
amyk added a comment to D115042: [test-suite] Use CMAKE_C_COMPILER as TEST_SUITE_HOST_CC when compiling test-suite tools. .

Hi @amyk, this seems to have broken our public CTMark builders. Can you take a look? Thanks!

https://green.lab.llvm.org/green/job/lnt-ctmark-aarch64-O0-g/11207/

Dec 16 2021, 10:30 PM

Dec 13 2021

amyk requested review of D115691: [PowerPC] Update P10 vector insert patterns to use refactored load/stores, and update handling of v4f32 vector insert..
Dec 13 2021, 6:40 PM · Unknown Object (Project), Restricted Project
amyk accepted D115424: [PowerPC] Do not increase cost for getUserCost with MMA types.

LGTM, thank you Nemanja.

Dec 13 2021, 5:37 PM · Restricted Project

Dec 10 2021

amyk added inline comments to D112748: [release] Use the Bootstrapping build for building LLVM releases.
Dec 10 2021, 5:29 PM · Restricted Project
amyk added a comment to D115285: [test-suite][AIX] Disable SingleSource/UnitTests/2007-04-25-weak on AIX..

The change seems fine but would you mind adding the reason why this test is not expected to pass on AIX in the description?

Dec 10 2021, 12:01 PM · Unknown Object (Project)
amyk updated the summary of D115285: [test-suite][AIX] Disable SingleSource/UnitTests/2007-04-25-weak on AIX..
Dec 10 2021, 12:01 PM · Unknown Object (Project)

Dec 9 2021

amyk committed rTe736520bca48: [test-suite] Use CMAKE_C_COMPILER as TEST_SUITE_HOST_CC when compiling test… (authored by amyk).
[test-suite] Use CMAKE_C_COMPILER as TEST_SUITE_HOST_CC when compiling test…
Dec 9 2021, 4:32 PM
amyk closed D115042: [test-suite] Use CMAKE_C_COMPILER as TEST_SUITE_HOST_CC when compiling test-suite tools. .
Dec 9 2021, 4:32 PM
amyk added a comment to D115042: [test-suite] Use CMAKE_C_COMPILER as TEST_SUITE_HOST_CC when compiling test-suite tools. .

LGTM

Dec 9 2021, 10:16 AM
amyk committed rG0ae1b1ce1a17: [test-release.sh] Respect the given width in LIT runs by adding `-j` in… (authored by amyk).
[test-release.sh] Respect the given width in LIT runs by adding `-j` in…
Dec 9 2021, 6:37 AM
amyk closed D115350: [test-release.sh] Respect the given width in LIT runs by adding `-j` in LLVM_LIT_ARGS..
Dec 9 2021, 6:37 AM · Unknown Object (Project), Restricted Project
amyk updated the diff for D115042: [test-suite] Use CMAKE_C_COMPILER as TEST_SUITE_HOST_CC when compiling test-suite tools. .

Updated the revision to use CMAKE_C_COMPILER_ID as suggested by @Meinersbur.
This approach will set TEST_SUITE_HOST_CC as clang is the CMAKE_C_COMPILER is also clang. It also respects if I set TEST_SUITE_HOST_CC in CMake.

Dec 9 2021, 6:28 AM

Dec 8 2021

amyk requested review of D115350: [test-release.sh] Respect the given width in LIT runs by adding `-j` in LLVM_LIT_ARGS..
Dec 8 2021, 7:44 AM · Unknown Object (Project), Restricted Project
amyk added a comment to D115042: [test-suite] Use CMAKE_C_COMPILER as TEST_SUITE_HOST_CC when compiling test-suite tools. .

CMAKE_C_COMPILER does not work here in all cases. In particular, when cross-compiling using gcc. For instance, I would like to cross-compile to an embedded ARM board on my x86_64 desktop. I'd configure CMake to aarch64-linux-gnu-gcc as CMAKE_C_COMPILER. Hence that llvm_add_host_executable would compile to aarch64, not my x86_64 host.

TEST_SUITE_HOST_CC is a cmake configuration parameter, the idea is that you change it to something else if your host compiler is not cc. You could detect whether CMAKE_C_COMPILER is clang and if so, use that compiler has default host compiler since it uses -target to cross-compile.

Dec 8 2021, 6:51 AM

Dec 7 2021

amyk added a comment to D115105: [test-release.sh] Add an option to build lib projects as a part of default runtimes. .

Nitpick: In your commit message, I think you mean LLVM_ENABLE_RUNTIMES, not LLVM_ENABLE_PROJECTS.

I'm fine-ish with this change. Another approach would be D112748, where we automatically route various runtimes to LLVM_ENABLE_RUNTIMES without having to change how test-release.sh is invoked. I'm fine with either, I don't really have a preference.

Dec 7 2021, 2:16 PM · Restricted Project
amyk added a comment to D112748: [release] Use the Bootstrapping build for building LLVM releases.

Thanks for putting up this patch (and taking a look at the revision I've put up). I've left a question on this patch to keep the conversation more contained.

Dec 7 2021, 2:16 PM · Restricted Project
amyk updated the summary of D115105: [test-release.sh] Add an option to build lib projects as a part of default runtimes. .
Dec 7 2021, 2:03 PM · Restricted Project
amyk requested review of D115285: [test-suite][AIX] Disable SingleSource/UnitTests/2007-04-25-weak on AIX..
Dec 7 2021, 1:57 PM · Unknown Object (Project)

Dec 4 2021

amyk added a comment to D115105: [test-release.sh] Add an option to build lib projects as a part of default runtimes. .

My initial thought with this patch was to add the ability to supply the list of projects by a semicolon delimited
list with the --runtimes option, but of course, feedback is welcome with how exactly we want to achieve this
with test-release.sh and this method may not be the best way.

Dec 4 2021, 1:37 PM · Restricted Project
amyk requested review of D115105: [test-release.sh] Add an option to build lib projects as a part of default runtimes. .
Dec 4 2021, 1:37 PM · Restricted Project

Dec 3 2021

amyk added a comment to D114640: [PowerPC] Handle Vector Sum Reduction.

Also, I noticed that I think you may have meant to put [PowerPC] Handle Vector Sum Reduction instead of [PowerPC] Handle Vector Sum Reducation for the title. :-)

Dec 3 2021, 1:49 PM · Restricted Project
amyk committed rG97eb3bb80ff9: [test-release.sh] Do not run chrpath on AIX. (authored by amyk).
[test-release.sh] Do not run chrpath on AIX.
Dec 3 2021, 1:40 PM
amyk closed D115046: [test-release.sh] Do not run chrpath on AIX..
Dec 3 2021, 1:39 PM · Restricted Project
amyk added inline comments to D114640: [PowerPC] Handle Vector Sum Reduction.
Dec 3 2021, 1:26 PM · Restricted Project
amyk added inline comments to D114800: [PowerPC] Replace MFVSRLD with MFVSRD when the vector is symmetrical.
Dec 3 2021, 1:01 PM · Restricted Project
amyk requested review of D115046: [test-release.sh] Do not run chrpath on AIX..
Dec 3 2021, 8:03 AM · Restricted Project
amyk added a comment to D115042: [test-suite] Use CMAKE_C_COMPILER as TEST_SUITE_HOST_CC when compiling test-suite tools. .

I put up this patch as when trying to configure and build test-suite on an AIX system, I was not able to use the default cc on the machine to compile the test-suite tools.
I figured the proper solution would probably be to use ${CMAKE_C_COMPILER}, and perhaps this was the original intention, but are you able to confirm if this is the proper thing to do? Was there any justification for doing just cc in the first place?

Dec 3 2021, 7:44 AM
amyk requested review of D115042: [test-suite] Use CMAKE_C_COMPILER as TEST_SUITE_HOST_CC when compiling test-suite tools. .
Dec 3 2021, 7:42 AM