amyk (Amy Kwan)
User

Projects

User does not belong to any projects.

User Details

User Since: Jul 4 2018, 10:36 AM (245 w, 5 d)

Recent Activity
View All

Fri, Mar 3

amyk added a comment to D144967: [PowerPC] Recognize long CPU name for -mtune in Clang.

In D144967#4164858, @nathanchance wrote:

Could this be merged into main and backported to release/16.x? If this makes 16.0.0 final, I think the kernel can avoid working around this issue altogether, as -mtune was only wired up to do something on PowerPC in during the 16 development cycle; in prior versions, it was ignored so any value was accepted.

Fri, Mar 3, 4:26 AM · Restricted Project, Restricted Project

Thu, Feb 23

amyk added a comment to D130487: [PowerPC] Fix vector_shuffle combines when inputs are scalar_to_vector of differing types..

Ping.

Thu, Feb 23, 10:07 AM · Restricted Project, Restricted Project, Restricted Project

amyk added a comment to D137504: [PowerPC] Implement 64-bit ELFv2 Calling Convention in TableGen (for integers/floats/vectors in registers).

Ping.

Thu, Feb 23, 10:07 AM · Restricted Project, Restricted Project, Restricted Project

amyk added a comment to D139430: scudo-standalone: Add GetRSS method on Linux.

In D139430#4147344, @amyk wrote:

In D139430#4143314, @vitalybuka wrote:

In D139430#4141870, @amyk wrote:

In D139430#4127089, @vitalybuka wrote:

it's totally made up: 3 out of 10

Thanks @vitalybuka for the explanation. Were we still planning to update this test case in the future?

I am not looking into that. Would you be interested to send a patch to improves the test for your platform?

Thanks for getting back to me, @vitalybuka! I've discussed this offline with a few others from our backend and we are deciding to disable this test on Power for the time being. I will follow up with a commit shortly for this.

Thu, Feb 23, 9:58 AM · Restricted Project, Restricted Project

amyk committed rG0e3ef5f89749: [scudo] Disable the GetRssFromBuffer scudo test on PPC (authored by amyk).

[scudo] Disable the GetRssFromBuffer scudo test on PPC

Thu, Feb 23, 9:58 AM · Restricted Project, Restricted Project

amyk added a comment to D139430: scudo-standalone: Add GetRSS method on Linux.

In D139430#4143314, @vitalybuka wrote:

In D139430#4141870, @amyk wrote:

In D139430#4127089, @vitalybuka wrote:

it's totally made up: 3 out of 10

Thanks @vitalybuka for the explanation. Were we still planning to update this test case in the future?

I am not looking into that. Would you be interested to send a patch to improves the test for your platform?

Thu, Feb 23, 6:28 AM · Restricted Project, Restricted Project

Tue, Feb 21

amyk added inline comments to D144293: [PowerPC] Fix the implicit casting for the emulated intrinsics.

Tue, Feb 21, 11:44 AM · Restricted Project, Restricted Project

amyk added a comment to D139430: scudo-standalone: Add GetRSS method on Linux.

In D139430#4127089, @vitalybuka wrote:

it's totally made up: 3 out of 10

Tue, Feb 21, 8:25 AM · Restricted Project, Restricted Project

Feb 17 2023

amyk accepted D144068: [PowerPC] Add Binary Coded Decimal Assist Instructions.

LGTM.

Feb 17 2023, 7:36 AM · Restricted Project, Restricted Project

Feb 15 2023

amyk retitled D143210: [PowerPC] Include vector bool and pixel when emitting lax warning from PowerPC] Include vector bool and pixel when emitting lax warning to [PowerPC] Include vector bool and pixel when emitting lax warning.

Feb 15 2023, 7:05 AM · Restricted Project, Restricted Project

amyk added inline comments to D143210: [PowerPC] Include vector bool and pixel when emitting lax warning.

Feb 15 2023, 7:05 AM · Restricted Project, Restricted Project

Feb 14 2023

amyk added a comment to D139430: scudo-standalone: Add GetRSS method on Linux.

In D139430#4127024, @vitalybuka wrote:

Anther way to test this is instead of failure on the first EXPECT_LE, we rather count mismatches and after the loop we check that count is e.g. <=3

Feb 14 2023, 12:46 PM · Restricted Project, Restricted Project

amyk added a comment to D139430: scudo-standalone: Add GetRSS method on Linux.

Hi there @vitalybuka @1c3t3a! I am now realizing that we are experiencing some intermittent failures with the GetRssFromBuffer test case (sometimes it fails, and sometimes it passes) on PPC.

Feb 14 2023, 12:09 PM · Restricted Project, Restricted Project

Feb 13 2023

amyk added a comment to D130487: [PowerPC] Fix vector_shuffle combines when inputs are scalar_to_vector of differing types..

Ping.

Feb 13 2023, 6:29 AM · Restricted Project, Restricted Project, Restricted Project

amyk added a comment to D137504: [PowerPC] Implement 64-bit ELFv2 Calling Convention in TableGen (for integers/floats/vectors in registers).

Ping.

Feb 13 2023, 6:28 AM · Restricted Project, Restricted Project, Restricted Project

Feb 7 2023

amyk committed rG71513f761cb8: [Flang] Restrict emit-asm-from-mlir.mlir to be ran on specific targets using… (authored by amyk).

[Flang] Restrict emit-asm-from-mlir.mlir to be ran on specific targets using…

Feb 7 2023, 7:04 AM · Restricted Project, Restricted Project

amyk closed D143366: [Flang] Restrict emit-asm-from-mlir.mlir to be ran on specific targets using 'target=...'.

Feb 7 2023, 7:04 AM · Restricted Project, Restricted Project, Restricted Project

amyk retitled D143366: [Flang] Restrict emit-asm-from-mlir.mlir to be ran on specific targets using 'target=...' from [Flang] Mark emit-asm-from-mlir.mlir as UNSUPPORTED for PowerPC using 'target=...' to [Flang] Restrict emit-asm-from-mlir.mlir to be ran on specific targets using 'target=...'.

Feb 7 2023, 6:59 AM · Restricted Project, Restricted Project, Restricted Project

Feb 6 2023

amyk updated the diff for D143366: [Flang] Restrict emit-asm-from-mlir.mlir to be ran on specific targets using 'target=...'.

Address review comment to update the REQUIRES line instead.

Feb 6 2023, 6:04 PM · Restricted Project, Restricted Project, Restricted Project

amyk added inline comments to D143366: [Flang] Restrict emit-asm-from-mlir.mlir to be ran on specific targets using 'target=...'.

Feb 6 2023, 6:03 PM · Restricted Project, Restricted Project, Restricted Project

amyk added a comment to D130487: [PowerPC] Fix vector_shuffle combines when inputs are scalar_to_vector of differing types..

Ping.

Feb 6 2023, 7:57 AM · Restricted Project, Restricted Project, Restricted Project

amyk added a comment to D137504: [PowerPC] Implement 64-bit ELFv2 Calling Convention in TableGen (for integers/floats/vectors in registers).

Ping.

Feb 6 2023, 7:57 AM · Restricted Project, Restricted Project, Restricted Project

Feb 5 2023

amyk updated the summary of D143366: [Flang] Restrict emit-asm-from-mlir.mlir to be ran on specific targets using 'target=...'.

Feb 5 2023, 9:21 PM · Restricted Project, Restricted Project, Restricted Project

amyk requested review of D143366: [Flang] Restrict emit-asm-from-mlir.mlir to be ran on specific targets using 'target=...'.

Feb 5 2023, 9:21 PM · Restricted Project, Restricted Project, Restricted Project

Jan 30 2023

amyk added a comment to D142844: [LTO] Demangle the function name in DiagnosticInfoDontCall message.

This patch appears to be causing an issue on the clang-ppc64le-linux-multistage bot (https://lab.llvm.org/buildbot/#/builders/121/builds/27524/steps/4/logs/stdio):

FAILED: lib/libLLVMCore.so.17git 
: && /usr/lib64/ccache/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/buildbots/ppc64le-clang-multistage-test/clang-ppc64le-multistage/stage1/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMCore.so.17git -o lib/libLLVMCore.so.17git lib/IR/CMakeFiles/LLVMCore.dir/AbstractCallSite.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/AsmWriter.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/Assumptions.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/Attributes.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/AutoUpgrade.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/BasicBlock.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/BuiltinGCs.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/Comdat.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/ConstantFold.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/ConstantRange.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/Constants.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/Core.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/DIBuilder.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/DataLayout.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/DebugInfo.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/DebugInfoMetadata.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/DebugLoc.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/DiagnosticHandler.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/DiagnosticInfo.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/DiagnosticPrinter.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/Dominators.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/EHPersonalities.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/FPEnv.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/Function.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/GCStrategy.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/GVMaterializer.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/Globals.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/IRBuilder.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/IRPrintingPasses.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/SSAContext.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/InlineAsm.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/Instruction.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/Instructions.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/IntrinsicInst.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/LLVMContext.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/LLVMContextImpl.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/LLVMRemarkStreamer.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/LegacyPassManager.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/MDBuilder.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/Mangler.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/Metadata.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/Module.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/ModuleSummaryIndex.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/Operator.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/OptBisect.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/Pass.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/PassInstrumentation.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/PassManager.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/PassRegistry.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/PassTimingInfo.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/PrintPasses.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/SafepointIRVerifier.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/ProfileSummary.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/PseudoProbe.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/ReplaceConstant.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/Statepoint.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/StructuralHash.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/Type.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/TypedPointerType.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/TypeFinder.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/Use.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/User.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/Value.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/ValueSymbolTable.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/VectorBuilder.cpp.o lib/IR/CMakeFiles/LLVMCore.dir/Verifier.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib"  -lpthread  lib/libLLVMBinaryFormat.so.17git  lib/libLLVMRemarks.so.17git  lib/libLLVMTargetParser.so.17git  lib/libLLVMSupport.so.17git  -Wl,-rpath-link,/home/buildbots/ppc64le-clang-multistage-test/clang-ppc64le-multistage/stage1/lib && :
lib/IR/CMakeFiles/LLVMCore.dir/DiagnosticInfo.cpp.o: In function `llvm::DiagnosticInfoDontCall::print(llvm::DiagnosticPrinter&) const [clone .localalias.29]':
DiagnosticInfo.cpp:(.text._ZNK4llvm22DiagnosticInfoDontCall5printERNS_17DiagnosticPrinterE+0xa4): undefined reference to `llvm::demangle(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
collect2: error: ld returned 1 exit status

Would you be able to take a look at this? Thanks in advance.

Jan 30 2023, 11:13 AM · Restricted Project, Restricted Project

Jan 27 2023

amyk added inline comments to D137504: [PowerPC] Implement 64-bit ELFv2 Calling Convention in TableGen (for integers/floats/vectors in registers).

Jan 27 2023, 2:17 PM · Restricted Project, Restricted Project, Restricted Project

amyk added a comment to D130487: [PowerPC] Fix vector_shuffle combines when inputs are scalar_to_vector of differing types..

Ping.

Jan 27 2023, 7:07 AM · Restricted Project, Restricted Project, Restricted Project

amyk added inline comments to D137504: [PowerPC] Implement 64-bit ELFv2 Calling Convention in TableGen (for integers/floats/vectors in registers).

Jan 27 2023, 7:00 AM · Restricted Project, Restricted Project, Restricted Project

amyk updated the diff for D137504: [PowerPC] Implement 64-bit ELFv2 Calling Convention in TableGen (for integers/floats/vectors in registers).

Address review comments from Nemanja to simplify the register allocation function and also to add documentation to parts of the code.

Jan 27 2023, 7:00 AM · Restricted Project, Restricted Project, Restricted Project

Jan 26 2023

amyk added a comment to D133103: [PowerPC] Improve kill flag computation and add verification after MI peephole.

Some additional comments and questions I thought of after our previous review/discussion.

Jan 26 2023, 10:42 AM · Restricted Project, Restricted Project

Jan 25 2023

amyk updated the diff for D137785: [PowerPC][GISel] Add initial GlobalISel support for vector functions. .

Update revision to resolve failing test cases.

Jan 25 2023, 2:24 PM · Restricted Project, Restricted Project, Restricted Project

amyk accepted D142417: test-release.sh: Use parallel xz for packaging the binaries.

LGTM as well.

Jan 25 2023, 7:55 AM · Restricted Project, Restricted Project

Jan 24 2023

amyk updated the diff for D137785: [PowerPC][GISel] Add initial GlobalISel support for vector functions. .

Rebased patch, as well as demorgan a condition in PPCLegalizerInfo.cpp.

Jan 24 2023, 6:46 AM · Restricted Project, Restricted Project, Restricted Project

Jan 20 2023

amyk accepted D142120: [PowerPC] Fix float materialization patterns..

LGTM.

Jan 20 2023, 5:59 AM · Restricted Project, Restricted Project

Jan 19 2023

amyk added inline comments to D133340: [PowerPC][GISel]select floating point constant from TOC.

Jan 19 2023, 12:41 PM · Restricted Project, Restricted Project

Jan 18 2023

amyk added a comment to D130487: [PowerPC] Fix vector_shuffle combines when inputs are scalar_to_vector of differing types..

Ping.

Jan 18 2023, 7:22 AM · Restricted Project, Restricted Project, Restricted Project

amyk added a comment to D137504: [PowerPC] Implement 64-bit ELFv2 Calling Convention in TableGen (for integers/floats/vectors in registers).

Ping.

Jan 18 2023, 7:22 AM · Restricted Project, Restricted Project, Restricted Project

Jan 17 2023

amyk added a comment to D141751: test-release.sh: Only build native target for stage 1 and stage 2.

I've tested this on the PPC side. I am seeing object file differences at the end since we're no longer building for the native target for stage 3, for example:

# Comparing Phase 2 and Phase 3 files
file llvm-config.cpp.o differs between phase 2 and phase 3
file LTODisassembler.cpp.o differs between phase 2 and phase 3
file lto.cpp.o differs between phase 2 and phase 3
file llvm-ar.cpp.o differs between phase 2 and phase 3
file llvm-lto.cpp.o differs between phase 2 and phase 3
file DependencyScanningService.cpp.o differs between phase 2 and phase 3
file cc1as_main.cpp.o differs between phase 2 and phase 3
file driver.cpp.o differs between phase 2 and phase 3
file cc1_main.cpp.o differs between phase 2 and phase 3
file ClangLinkerWrapper.cpp.o differs between phase 2 and phase 3
file ClangCheck.cpp.o differs between phase 2 and phase 3
file CIndex.cpp.o differs between phase 2 and phase 3
file bugpoint.cpp.o differs between phase 2 and phase 3
file dsymutil.cpp.o differs between phase 2 and phase 3
file llc.cpp.o differs between phase 2 and phase 3
file disassemble.c.o differs between phase 2 and phase 3
file targets.c.o differs between phase 2 and phase 3
file llvm-cfi-verify.cpp.o differs between phase 2 and phase 3
file llvm-cxxdump.cpp.o differs between phase 2 and phase 3
file llvm-dwarfdump.cpp.o differs between phase 2 and phase 3
file llvm-dwarfutil.cpp.o differs between phase 2 and phase 3
file llvm-dwp.cpp.o differs between phase 2 and phase 3
file llvm-gsymutil.cpp.o differs between phase 2 and phase 3
file llvm-isel-fuzzer.cpp.o differs between phase 2 and phase 3
file llvm-jitlink.cpp.o differs between phase 2 and phase 3
file llvm-libtool-darwin.cpp.o differs between phase 2 and phase 3
file llvm-lto2.cpp.o differs between phase 2 and phase 3
file llvm-mc.cpp.o differs between phase 2 and phase 3
file llvm-mca.cpp.o differs between phase 2 and phase 3
file llvm-ml.cpp.o differs between phase 2 and phase 3
file llvm-nm.cpp.o differs between phase 2 and phase 3
file llvm-objdump.cpp.o differs between phase 2 and phase 3
file llvm-opt-fuzzer.cpp.o differs between phase 2 and phase 3
file llvm-profgen.cpp.o differs between phase 2 and phase 3
file ReducerWorkItem.cpp.o differs between phase 2 and phase 3
file llvm-rtdyld.cpp.o differs between phase 2 and phase 3
file opt.cpp.o differs between phase 2 and phase 3
file sancov.cpp.o differs between phase 2 and phase 3

Are others also seeing this issue with this change?

Jan 17 2023, 11:23 AM · Restricted Project, Restricted Project

amyk accepted D141552: test-release.sh: Only build clang for stage1 and stage2.

I think this LGTM as well.

Jan 17 2023, 11:21 AM · Restricted Project, Restricted Project

Jan 16 2023

amyk added a comment to D140932: Dynamically allocate scudo allocation buffer..

Hi, I realized that the clang-ppc64le-rhel bot is exhibiting the following error when building this patch (https://lab.llvm.org/buildbot/#/builders/57/builds/23848/steps/7/logs/stdio):

FAILED: compiler-rt/lib/scudo/standalone/tests/ScudoUnitTestsObjects.combined_test.cpp.powerpc64le.o /home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/build/runtimes/runtimes-bins/compiler-rt/lib/scudo/standalone/tests/ScudoUnitTestsObjects.combined_test.cpp.powerpc64le.o 
cd /home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/build/runtimes/runtimes-bins/compiler-rt/lib/scudo/standalone/tests && /home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/build/./bin/clang -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wall -Werror -Wno-unused-parameter -Wno-unknown-warning-option -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta -g -Wno-covered-switch-default -Wno-suggest-override -DGTEST_NO_LLVM_SUPPORT=1 -DGTEST_HAS_RTTI=0 -I/home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/runtimes/../third-party/unittest/googletest/include -I/home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/runtimes/../third-party/unittest/googletest -I/home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/compiler-rt/include -I/home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/compiler-rt/lib -I/home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/compiler-rt/lib/scudo/standalone -I/home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/compiler-rt/lib/scudo/standalone/include -DGTEST_HAS_RTTI=0 -g -Wno-mismatched-new-delete -m64 -fno-function-sections -c -o ScudoUnitTestsObjects.combined_test.cpp.powerpc64le.o /home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/compiler-rt/lib/scudo/standalone/tests/combined_test.cpp
In file included from /home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/compiler-rt/lib/scudo/standalone/tests/combined_test.cpp:10:
In file included from /home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/compiler-rt/lib/scudo/standalone/tests/scudo_unit_test.h:15:
/home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/runtimes/../third-party/unittest/googletest/include/gtest/gtest.h:1628:28: error: comparison of integers of different signs: 'const unsigned long' and 'const int' [-Werror,-Wsign-compare]
GTEST_IMPL_CMP_HELPER_(GT, >);
~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
/home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/runtimes/../third-party/unittest/googletest/include/gtest/gtest.h:1608:12: note: expanded from macro 'GTEST_IMPL_CMP_HELPER_'
  if (val1 op val2) {\
      ~~~~ ^  ~~~~
/home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/compiler-rt/lib/scudo/standalone/tests/combined_test.cpp:708:3: note: in instantiation of function template specialization 'testing::internal::CmpHelperGT<unsigned long, int>' requested here
  ASSERT_GT(Size, 0);
  ^
/home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/runtimes/../third-party/unittest/googletest/include/gtest/gtest.h:2076:32: note: expanded from macro 'ASSERT_GT'
# define ASSERT_GT(val1, val2) GTEST_ASSERT_GT(val1, val2)
                               ^
/home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/runtimes/../third-party/unittest/googletest/include/gtest/gtest.h:2050:44: note: expanded from macro 'GTEST_ASSERT_GT'
  ASSERT_PRED_FORMAT2(::testing::internal::CmpHelperGT, val1, val2)
                                           ^
/home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/compiler-rt/lib/scudo/standalone/tests/combined_test.cpp:705:1: note: in instantiation of member function 'ScudoCombinedTestRingBufferSize<scudo::AndroidSvelteConfig>::Run' requested here
SCUDO_TYPED_TEST(ScudoCombinedTest, RingBufferSize) {
^
/home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/compiler-rt/lib/scudo/standalone/tests/combined_test.cpp:129:3: note: expanded from macro 'SCUDO_TYPED_TEST'
  SCUDO_TYPED_TEST_ALL_TYPES(FIXTURE, NAME)                                    \
  ^
/home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/compiler-rt/lib/scudo/standalone/tests/combined_test.cpp:115:3: note: expanded from macro 'SCUDO_TYPED_TEST_ALL_TYPES'
  SCUDO_TYPED_TEST_TYPE(FIXTURE, NAME, AndroidSvelteConfig)                    \
  ^
/home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/compiler-rt/lib/scudo/standalone/tests/combined_test.cpp:122:70: note: expanded from macro 'SCUDO_TYPED_TEST_TYPE'
  TEST_F(FIXTURE##NAME##_##TYPE, NAME) { FIXTURE##NAME<scudo::TYPE>::Run(); }
                                                                     ^
1 error generated.

Would you be able to assist in resolving this issue?

Jan 16 2023, 9:32 AM · Restricted Project, Restricted Project

Jan 13 2023

amyk accepted D141566: [PowerPC] Use default attributes for more intrinsics.

I think this LGTM as well.

Jan 13 2023, 12:23 PM · Restricted Project, Restricted Project

amyk accepted D141697: [P10] Fix the implementation for BRH.

LGTM as well.

Jan 13 2023, 8:21 AM · Restricted Project, Restricted Project

Jan 10 2023

amyk added a comment to D130487: [PowerPC] Fix vector_shuffle combines when inputs are scalar_to_vector of differing types..

Ping.

Jan 10 2023, 8:51 AM · Restricted Project, Restricted Project, Restricted Project

amyk added a comment to D137504: [PowerPC] Implement 64-bit ELFv2 Calling Convention in TableGen (for integers/floats/vectors in registers).

Ping.

Jan 10 2023, 8:51 AM · Restricted Project, Restricted Project, Restricted Project

Dec 14 2022

amyk added a comment to D138675: [flang] Add -ffast-math and -Ofast.

In D138675#3995282, @probinson wrote:

See D139967 for why UNSUPPORTED: powerpc didn't work. That patch will put it back, and also update the lit config so the check will work now.

Dec 14 2022, 8:42 AM · Restricted Project, Restricted Project, Restricted Project

Dec 12 2022

amyk added a comment to D138675: [flang] Add -ffast-math and -Ofast.

In D138675#3989997, @tblah wrote:
In D138675#3989826, @amyk wrote:
Thanks for the follow up patch! I tested the patch locally and also saw the buildbot results, and it doesn't appear like the follow up patch marked powerpc as unsupported as the error still persists (https://lab.llvm.org/buildbot/#/builders/21/builds/57850).
I was playing around with the test case locally and what appears to work is doing something like:
! UNSUPPORTED: powerpc-registered-target
Thanks https://github.com/llvm/llvm-project/commit/9d86f2dc4f1d2e4e1a991be82384bbdb310f0618

Dec 12 2022, 2:18 PM · Restricted Project, Restricted Project, Restricted Project

amyk added a comment to D130487: [PowerPC] Fix vector_shuffle combines when inputs are scalar_to_vector of differing types..

Ping.

Dec 12 2022, 1:03 PM · Restricted Project, Restricted Project, Restricted Project

amyk added a comment to D137504: [PowerPC] Implement 64-bit ELFv2 Calling Convention in TableGen (for integers/floats/vectors in registers).

Ping.

Dec 12 2022, 1:03 PM · Restricted Project, Restricted Project, Restricted Project

amyk added a comment to D138675: [flang] Add -ffast-math and -Ofast.

In D138675#3989634, @tblah wrote:
In D138675#3989403, @amyk wrote:
Hi,

The ppc64le-flang-rhel-clang bot is also experiencing some failures with the Driver/fast_math.f90 test case. In particular, crtfastmath.o is not found at all for CHECK-CRT as we can see in the failure details.
llvm-project/flang/test/Driver/fast_math.f90:64:19: error: CHECK-CRT-SAME: expected string not found in input
! CHECK-CRT-SAME: crtfastmath.o
The output for the CHECK-CRT line on the bot looks like the following:
"/home/buildbots/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/build/bin/flang-new" "-fc1" "-triple" "powerpc64le-unknown-linux-gnu" "-emit-obj" "-mrelocation-model" "pic" "-pic-level" "2" "-pic-is-pie" "-ffast-math" "-target-cpu" "ppc64le" "-o" "/tmp/lit-tmp-x_okwzug/fast_math-e9ab49.o" "-x" "f95-cpp-input" "/home/buildbots/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/test/Driver/fast_math.f90" 

"/usr/bin/ld" "-pie" "--hash-style=gnu" "--eh-frame-hdr" "-m" "elf64lppc" "-dynamic-linker" "/lib64/ld64.so.2" "-o" "/home/buildbots/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/build/tools/flang/test/Driver/Output/fast_math.f90.tmp" "/usr/lib/gcc/ppc64le-redhat-linux/8/../../../../lib64/Scrt1.o" "/usr/lib/gcc/ppc64le-redhat-linux/8/../../../../lib64/crti.o" "/usr/lib/gcc/ppc64le-redhat-linux/8/crtbeginS.o" "-L/usr/lib/gcc/ppc64le-redhat-linux/8" "-L/usr/lib/gcc/ppc64le-redhat-linux/8/../../../../lib64" "-L/lib/../lib64" "-L/usr/lib/../lib64" "-L/lib" "-L/usr/lib" "/tmp/lit-tmp-x_okwzug/fast_math-e9ab49.o" "-lFortran_main" "-lFortranRuntime" "-lFortranDecimal" "-lm" "-lgcc" "--as-needed" "-lgcc_s" "--no-as-needed" "-lc" "-lgcc" "--as-needed" "-lgcc_s" "--no-as-needed" "/usr/lib/gcc/ppc64le-redhat-linux/8/crtendS.o" "/usr/lib/gcc/ppc64le-redhat-linux/8/../../../../lib64/crtn.o"
Would it be possible to follow up with a fix for this test case?
Thanks for letting me know. I thought I had already disabled that test on powerpc (in https://github.com/llvm/llvm-project/commit/20cd3153f3775fcdc1eeeb54062849eead51e24a) but apparently it didn't work. I don't have a powerpc system available to test this. I have pushed a second attempt at https://github.com/llvm/llvm-project/commit/6442b4da4e7018e8f264965768b9e4fdee393c8f. Please let me know if that works.

Dec 12 2022, 12:58 PM · Restricted Project, Restricted Project, Restricted Project

amyk added a comment to D138675: [flang] Add -ffast-math and -Ofast.

The ppc64le-flang-rhel-clang bot is also experiencing some failures with the Driver/fast_math.f90 test case. In particular, crtfastmath.o is not found at all for CHECK-CRT as we can see in the failure details.

llvm-project/flang/test/Driver/fast_math.f90:64:19: error: CHECK-CRT-SAME: expected string not found in input
! CHECK-CRT-SAME: crtfastmath.o

The output for the CHECK-CRT line on the bot looks like the following:

"/home/buildbots/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/build/bin/flang-new" "-fc1" "-triple" "powerpc64le-unknown-linux-gnu" "-emit-obj" "-mrelocation-model" "pic" "-pic-level" "2" "-pic-is-pie" "-ffast-math" "-target-cpu" "ppc64le" "-o" "/tmp/lit-tmp-x_okwzug/fast_math-e9ab49.o" "-x" "f95-cpp-input" "/home/buildbots/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/test/Driver/fast_math.f90"

Dec 12 2022, 11:11 AM · Restricted Project, Restricted Project, Restricted Project

Dec 9 2022

amyk added a comment to D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu.

It might be good to add a test case to illustrate the 'unknown target CPU' error that is issued as a result of this patch.

Dec 9 2022, 1:08 PM · Restricted Project, Restricted Project

Dec 8 2022

amyk added inline comments to D133340: [PowerPC][GISel]select floating point constant from TOC.

Dec 8 2022, 7:08 AM · Restricted Project, Restricted Project

amyk added inline comments to D131296: [PowerPC] Add support for extending and truncating values.

Dec 8 2022, 7:01 AM · Restricted Project, Restricted Project

Dec 6 2022

amyk committed rG48634b3b935f: [NFC][PowerPC] Add NFC fixes to PPCInstrinfo.cpp when getting the defined… (authored by amyk).

[NFC][PowerPC] Add NFC fixes to PPCInstrinfo.cpp when getting the defined…

Dec 6 2022, 12:24 PM · Restricted Project, Restricted Project

amyk closed D137483: [NFC][PowerPC] Add NFC fixes to PPCInstrinfo.cpp when getting the defined machine instruction..

Dec 6 2022, 12:24 PM · Restricted Project, Restricted Project, Restricted Project

amyk updated the diff for D137483: [NFC][PowerPC] Add NFC fixes to PPCInstrinfo.cpp when getting the defined machine instruction..

Add back the typo fix that I accidentally removed in the last revision.

Dec 6 2022, 9:49 AM · Restricted Project, Restricted Project, Restricted Project

amyk added a comment to D137483: [NFC][PowerPC] Add NFC fixes to PPCInstrinfo.cpp when getting the defined machine instruction..

In D137483#3973000, @shchenz wrote:

Thanks very much for addressing this potential bug. LGTM.

nit: I saw there was a typo fix for flat to flag in the first revision, just a reminder. Maybe you have other plan for that change?

Dec 6 2022, 7:24 AM · Restricted Project, Restricted Project, Restricted Project

Dec 5 2022

amyk updated the diff for D137483: [NFC][PowerPC] Add NFC fixes to PPCInstrinfo.cpp when getting the defined machine instruction..

Apply @shchenz's suggestion to this patch.

Dec 5 2022, 6:19 PM · Restricted Project, Restricted Project, Restricted Project

amyk added inline comments to D137483: [NFC][PowerPC] Add NFC fixes to PPCInstrinfo.cpp when getting the defined machine instruction..

Dec 5 2022, 6:18 PM · Restricted Project, Restricted Project, Restricted Project

Dec 4 2022

amyk added a comment to D130487: [PowerPC] Fix vector_shuffle combines when inputs are scalar_to_vector of differing types..

@nemanjai Yeah, at the time of posting the patch, I did do little endian and big endian system tests as you mentioned. Since it's been awhile and I need update the patch, I'd like to retest these particular runs with this patch.

Dec 4 2022, 9:18 AM · Restricted Project, Restricted Project, Restricted Project

amyk updated the diff for D130487: [PowerPC] Fix vector_shuffle combines when inputs are scalar_to_vector of differing types..

Discussed this patch with Nemanja outside of the review.

Dec 4 2022, 9:15 AM · Restricted Project, Restricted Project, Restricted Project

Dec 2 2022

amyk updated the diff for D137785: [PowerPC][GISel] Add initial GlobalISel support for vector functions. .

Rebase patch.

Dec 2 2022, 8:04 PM · Restricted Project, Restricted Project, Restricted Project

amyk added a comment to D137504: [PowerPC] Implement 64-bit ELFv2 Calling Convention in TableGen (for integers/floats/vectors in registers).

@stefanp Thanks for the review and the questions!

Can we now get rid of CC_PPC64_ELF_FIS completely?

That’s a good question! This is related to your question about updating PPCFastISel. From what I can tell, it looks like mine covers everything the PPCFastISel one covers:

// Simple calling convention for 64-bit ELF PowerPC fast isel.
// Only handle ints and floats.  All ints are promoted to i64.
// Vector types and quadword ints are not handled.
let Entry = 1 in
def CC_PPC64_ELF_FIS : CallingConv<[
  CCIfCC<“CallingConv::AnyReg”, CCDelegateTo<CC_PPC64_AnyReg>>,

Dec 2 2022, 8:04 PM · Restricted Project, Restricted Project, Restricted Project

amyk updated the diff for D137504: [PowerPC] Implement 64-bit ELFv2 Calling Convention in TableGen (for integers/floats/vectors in registers).

Address review comments:

Update comments.
Clean up section involving shadowing GPRs for float/double.

Dec 2 2022, 8:03 PM · Restricted Project, Restricted Project, Restricted Project

amyk added inline comments to D137504: [PowerPC] Implement 64-bit ELFv2 Calling Convention in TableGen (for integers/floats/vectors in registers).

Dec 2 2022, 8:02 PM · Restricted Project, Restricted Project, Restricted Project

Nov 30 2022

amyk added inline comments to D134792: [PowerPC][GISel] support 64 bit load/store.

Nov 30 2022, 7:01 AM · Restricted Project, Restricted Project

amyk added inline comments to D135535: [PowerPC][GISel] support 32 bit load/store.

Nov 30 2022, 7:01 AM · Restricted Project, Restricted Project

Nov 27 2022

amyk added inline comments to D137785: [PowerPC][GISel] Add initial GlobalISel support for vector functions. .

Nov 27 2022, 2:07 PM · Restricted Project, Restricted Project, Restricted Project

Nov 25 2022

amyk added a comment to D138317: [PowerPC] Add support for tune-cpu attribute.

Do we require an IR test for this new attribute?

Nov 25 2022, 2:04 PM · Restricted Project, Restricted Project

Nov 24 2022

amyk updated the diff for D137504: [PowerPC] Implement 64-bit ELFv2 Calling Convention in TableGen (for integers/floats/vectors in registers).

Rebase patch. I also sync'd with Kai offline and the current implementation using a static const MCPhysReg array and keeping ELF64NumArgGPRs is OK to keep.

Nov 24 2022, 10:28 PM · Restricted Project, Restricted Project, Restricted Project

amyk accepted D138592: [PowerPC] Implement xscmpeqqp, xscmpgeqp, xscmpgtqp instructions.

LGTM.

Nov 24 2022, 9:35 AM · Restricted Project, Restricted Project

amyk added a reverting change for rTd52a93a891cd: Reland "Disable benchmarks that require _ALL_SOURCE on AIX": rTca94de843078: Revert "Reland "Disable benchmarks that require _ALL_SOURCE on AIX"".

Nov 24 2022, 9:32 AM

amyk committed rTca94de843078: Revert "Reland "Disable benchmarks that require _ALL_SOURCE on AIX"" (authored by amyk).

Revert "Reland "Disable benchmarks that require _ALL_SOURCE on AIX""

Nov 24 2022, 9:32 AM · Restricted Project

amyk committed rT2a2427ae0e77: [test-suite] Add strings.h header to ClamAV and define _XOPEN_SOURCE=600 on AIX… (authored by amyk).

[test-suite] Add strings.h header to ClamAV and define _XOPEN_SOURCE=600 on AIX…

Nov 24 2022, 7:28 AM · Restricted Project