Page MenuHomePhabricator

Kai (Kai Nacke)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 3 2012, 7:10 AM (444 w, 5 d)

Recent Activity

Tue, May 18

Kai committed rGec4706be8e72: [SystemZ] [z/OS] Add XPLINK64 Calling Convention to SystemZ (authored by Everybody0523).
[SystemZ] [z/OS] Add XPLINK64 Calling Convention to SystemZ
Tue, May 18, 1:53 PM
Kai closed D101010: [SystemZ] [z/OS] Add XPLINK64 Calling Convention to SystemZ.
Tue, May 18, 1:53 PM · Restricted Project

Fri, May 14

Kai committed rG8a7e2fb5f207: [SystemZ] [z/OS] Add SystemZCallingConventionRegisters class (authored by Neumann Hon <neumann.hon@ibm.com>).
[SystemZ] [z/OS] Add SystemZCallingConventionRegisters class
Fri, May 14, 1:52 PM
Kai closed D102370: [SystemZ] [z/OS] Add SystemZCallingConventionRegisters class.
Fri, May 14, 1:52 PM · Restricted Project

May 4 2021

Kai accepted D101660: [AsmParser][SystemZ][z/OS] Reject character and string literals for HLASM.

LGTM.

May 4 2021, 12:05 PM · Restricted Project

Apr 30 2021

Kai accepted D98276: [AsmParser][SystemZ][z/OS] Introducing HLASM Parser support to AsmParser - Part 1.

LGTM.

Apr 30 2021, 8:54 AM · Restricted Project

Apr 22 2021

Kai accepted D100987: [AsmParser][SystemZ][z/OS] Implement HLASM location counter syntax ("*") for Z PC-relative instructions..

LGTM.

Apr 22 2021, 12:06 PM · Restricted Project
Kai added inline comments to D100975: [AsmParser][SystemZ][z/OS] Reject "Dot" as current PC on z/OS.
Apr 22 2021, 12:05 PM · Restricted Project
Kai added inline comments to D101010: [SystemZ] [z/OS] Add XPLINK64 Calling Convention to SystemZ.
Apr 22 2021, 11:59 AM · Restricted Project
Kai committed rG832340ca879a: Fix the triple used in llvm-mca. (authored by Kai).
Fix the triple used in llvm-mca.
Apr 22 2021, 11:28 AM
Kai closed D100992: Fix the triple used in llvm-mca.
Apr 22 2021, 11:28 AM · Restricted Project

Apr 21 2021

Kai requested review of D100992: Fix the triple used in llvm-mca.
Apr 21 2021, 1:08 PM · Restricted Project
Kai added inline comments to D98276: [AsmParser][SystemZ][z/OS] Introducing HLASM Parser support to AsmParser - Part 1.
Apr 21 2021, 11:26 AM · Restricted Project

Apr 20 2021

Kai added inline comments to D88741: [SystemZ/z/OS] Add utility class for char set conversion..
Apr 20 2021, 1:45 PM · Restricted Project
Kai added a comment to D88741: [SystemZ/z/OS] Add utility class for char set conversion..

The CI on Windows is failing because it seems that the iconv header exists but the path is unknown. Is it possible to set a variable to Iconv_INCLUDE_DIRS and use that instead of writing out <iconv.h> ? I'm seeing this failure on the CI on my fexec-charset patch as well.

Apr 20 2021, 1:39 PM · Restricted Project
Kai updated the diff for D88741: [SystemZ/z/OS] Add utility class for char set conversion..

Use the right CMake variable Iconv_INCLUDE_DIRS.

Apr 20 2021, 1:37 PM · Restricted Project
Kai updated the diff for D88741: [SystemZ/z/OS] Add utility class for char set conversion..

Added the path of the <iconv.h> header as additional include path,

Apr 20 2021, 1:23 PM · Restricted Project
Kai added inline comments to D88741: [SystemZ/z/OS] Add utility class for char set conversion..
Apr 20 2021, 1:13 PM · Restricted Project
Kai updated the diff for D88741: [SystemZ/z/OS] Add utility class for char set conversion..

Renamed enum members to include 8 for UTF8.

Apr 20 2021, 1:12 PM · Restricted Project

Mar 16 2021

Kai accepted D98666: [AsmParser][SystemZ][z/OS] Reland "Introduce HLASM Comment Syntax".

LGTM.

Mar 16 2021, 11:47 AM · Restricted Project

Mar 12 2021

Kai committed rGbcdd40f802a5: [AsmParser][SystemZ][z/OS] Introducing HLASM Comment Syntax (authored by anirudhp).
[AsmParser][SystemZ][z/OS] Introducing HLASM Comment Syntax
Mar 12 2021, 8:57 AM
Kai closed D97703: [AsmParser][SystemZ][z/OS] Introducing HLASM Comment Syntax.
Mar 12 2021, 8:57 AM · Restricted Project
Kai accepted D97703: [AsmParser][SystemZ][z/OS] Introducing HLASM Comment Syntax.

LGTM.
It's nice to have this test!

Mar 12 2021, 8:42 AM · Restricted Project

Mar 10 2021

Kai committed rG023b5c1ed8d1: [SystemZ][NFC] Renaming of ELF specific variables. (authored by yusra.syeda).
[SystemZ][NFC] Renaming of ELF specific variables.
Mar 10 2021, 7:15 AM
Kai closed D98199: [SystemZ][NFC] Renaming of ELF specific variables.
Mar 10 2021, 7:15 AM · Restricted Project

Mar 9 2021

Kai accepted D98199: [SystemZ][NFC] Renaming of ELF specific variables.

LGTM.

Mar 9 2021, 11:35 AM · Restricted Project

Mar 8 2021

Kai committed rG7a46d34a1953: [SystemZ][z/OS] Add support to validate a HLASM Label. (authored by anirudhp).
[SystemZ][z/OS] Add support to validate a HLASM Label.
Mar 8 2021, 6:56 AM
Kai closed D97748: [SystemZ][z/OS] Add support to validate a HLASM Label..
Mar 8 2021, 6:56 AM · Restricted Project

Mar 5 2021

Kai accepted D97748: [SystemZ][z/OS] Add support to validate a HLASM Label..

LGTM.
The mentioned issue with the encoding does not affect this change. It's nevertheless a very valuable hint, as there are some implications with char/string literals inside an inline asm string, but this is not part of this change.

Mar 5 2021, 9:58 AM · Restricted Project

Mar 1 2021

Kai committed rG5cb417527cbc: [SystemZ] Introduce distinction between the jg/jl family of mnemonics for GNU… (authored by anirudhp).
[SystemZ] Introduce distinction between the jg/jl family of mnemonics for GNU…
Mar 1 2021, 1:37 PM
Kai closed D97581: [SystemZ] Introduce distinction between the jg/jl family of mnemonics for GNU as vs HLASM.
Mar 1 2021, 1:37 PM · Restricted Project

Feb 26 2021

Kai committed rGbcc1aba6c4ee: [SystemZ] Introducing assembler dialects for the Z backend (authored by anirudhp).
[SystemZ] Introducing assembler dialects for the Z backend
Feb 26 2021, 12:15 PM
Kai closed D94250: [SystemZ] Introducing assembler dialects for the Z backend.
Feb 26 2021, 12:14 PM · Restricted Project

Feb 19 2021

Kai committed rGb006f555448a: [SystemZ/z/OS] Add XPLINK 64-bit calling convention to tablegen. (authored by yusra.syeda).
[SystemZ/z/OS] Add XPLINK 64-bit calling convention to tablegen.
Feb 19 2021, 3:40 PM
Kai closed D96887: [SystemZ/z/OS] Initial changes to add the XPLink calling convention to tablegen.
Feb 19 2021, 3:40 PM · Restricted Project

Feb 17 2021

Kai committed rG8b624a316491: [SystemZ] Separate LoZ ELF specifics in tablegen. (authored by yusra.syeda).
[SystemZ] Separate LoZ ELF specifics in tablegen.
Feb 17 2021, 1:13 PM
Kai closed D96867: [SystemZ] Separate LoZ ELF specifics in tablegen.
Feb 17 2021, 1:12 PM · Restricted Project

Jan 18 2021

Kai committed rG9399681a57ce: [Doc] Fix example in codegen doc. (authored by Kai).
[Doc] Fix example in codegen doc.
Jan 18 2021, 5:26 AM
Kai closed D94683: [Doc] Fix syntax error in CodeGenerator documentation example.
Jan 18 2021, 5:26 AM · Restricted Project

Jan 14 2021

Kai requested review of D94683: [Doc] Fix syntax error in CodeGenerator documentation example.
Jan 14 2021, 5:13 AM · Restricted Project

Dec 16 2020

Kai committed rGe2e86f4e77ec: [Doc][SystemZ] Add Linux/SystemZ to Getting Started guide. (authored by Kai).
[Doc][SystemZ] Add Linux/SystemZ to Getting Started guide.
Dec 16 2020, 7:46 AM
Kai closed D93388: [Doc][SystemZ] Add Linux/SystemZ to Getting Started guide..
Dec 16 2020, 7:46 AM · Restricted Project
Kai added reviewers for D93388: [Doc][SystemZ] Add Linux/SystemZ to Getting Started guide.: meikeb, jyknight.
Dec 16 2020, 3:08 AM · Restricted Project
Kai requested review of D93388: [Doc][SystemZ] Add Linux/SystemZ to Getting Started guide..
Dec 16 2020, 3:05 AM · Restricted Project

Dec 2 2020

Kai committed rGf03c21df7b84: [SystemZ] Adding extra extended mnemonics for SystemZ target (authored by anirudhp).
[SystemZ] Adding extra extended mnemonics for SystemZ target
Dec 2 2020, 5:27 AM
Kai closed D92185: [SystemZ] Adding extra extended mnemonics for SystemZ target.
Dec 2 2020, 5:27 AM · Restricted Project

Nov 4 2020

Kai updated the diff for D88741: [SystemZ/z/OS] Add utility class for char set conversion..

Sorry for taking so long - I was on vacation.

Nov 4 2020, 5:28 AM · Restricted Project

Oct 2 2020

Kai added a comment to D88741: [SystemZ/z/OS] Add utility class for char set conversion..

Seems ok to me. Be good to send your RFC as well to clang-dev to get a view into -finput-charset translations as well if we wanted to go there.

Oct 2 2020, 11:11 AM · Restricted Project
Kai accepted D88467: fix out-of-tree clang build due to sysexits change.

LGTM. Sorry for causing the build break.

Oct 2 2020, 9:28 AM · Restricted Project, Restricted Project
Kai requested review of D88741: [SystemZ/z/OS] Add utility class for char set conversion..
Oct 2 2020, 8:50 AM · Restricted Project

Aug 26 2020

Kai committed rGed07e1fe0ffd: [SystemZ/ZOS] Add header file to encapsulate use of <sysexits.h> (authored by Kai).
[SystemZ/ZOS] Add header file to encapsulate use of <sysexits.h>
Aug 26 2020, 9:46 AM
Kai closed D83472: [SystemZ/ZOS] Add header file to encapsulate use of <sysexits.h>.
Aug 26 2020, 9:46 AM · Restricted Project, Restricted Project
Kai committed rG00d5f1ecccc6: [SystemZ/ZOS] Additions to the build system. (authored by Kai).
[SystemZ/ZOS] Additions to the build system.
Aug 26 2020, 3:55 AM
Kai closed D83866: [SystemZ/ZOS] Additions to the build system..
Aug 26 2020, 3:55 AM · Restricted Project

Aug 17 2020

Kai committed rGc2ae7934c809: [SystemZ/ZOS]__(de)register_frame are not available on z/OS. (authored by Kai).
[SystemZ/ZOS]__(de)register_frame are not available on z/OS.
Aug 17 2020, 6:01 AM
Kai closed D84787: [SystemZ/ZOS] __(de)register_frame are not available on z/OS..
Aug 17 2020, 6:00 AM · Restricted Project

Aug 14 2020

Kai added reviewers for D84787: [SystemZ/ZOS] __(de)register_frame are not available on z/OS.: abhina.sreeskantharajan, hubert.reinterpretcast.
Aug 14 2020, 2:56 AM · Restricted Project
Kai updated the diff for D83866: [SystemZ/ZOS] Additions to the build system..
  • Added a TODO comment to the linker strip section
  • Both z/OS and AIX now use CMAKE_SYSTEM_NAME to determine the host system
Aug 14 2020, 2:55 AM · Restricted Project

Aug 12 2020

Kai added inline comments to D83866: [SystemZ/ZOS] Additions to the build system..
Aug 12 2020, 5:51 AM · Restricted Project
Kai committed rGbca1b8ed9943: [SystemZ/ZOS] Implement computeHostNumPhysicalCores (authored by Kai).
[SystemZ/ZOS] Implement computeHostNumPhysicalCores
Aug 12 2020, 5:33 AM
Kai closed D85531: [SystemZ/ZOS] Add support for getHostNumPhysicalCores().
Aug 12 2020, 5:33 AM · Restricted Project

Aug 11 2020

Kai updated the diff for D83866: [SystemZ/ZOS] Additions to the build system..
  • Position-independent code needs not to be disabled
  • Removed message stating that static symbol export is not supported
Aug 11 2020, 5:24 AM · Restricted Project
Kai added inline comments to D83866: [SystemZ/ZOS] Additions to the build system..
Aug 11 2020, 5:22 AM · Restricted Project
Kai added a comment to D84787: [SystemZ/ZOS] __(de)register_frame are not available on z/OS..

Any comments on this change?

Aug 11 2020, 4:27 AM · Restricted Project
Kai updated the diff for D85531: [SystemZ/ZOS] Add support for getHostNumPhysicalCores().
  • Remove list of systems from comment.
Aug 11 2020, 3:07 AM · Restricted Project
Kai committed rGd6f710fd46dc: [NFC] Fix typo in comment. (authored by Kai).
[NFC] Fix typo in comment.
Aug 11 2020, 2:29 AM
Kai committed rGb3aece05313e: [SystemZ/ZOS] Add binary format goff and operating system zos to the triple (authored by Kai).
[SystemZ/ZOS] Add binary format goff and operating system zos to the triple
Aug 11 2020, 2:27 AM
Kai closed D82081: [z/OS] Add binary format goff and operating system zos to the triple.
Aug 11 2020, 2:26 AM · Restricted Project, Restricted Project

Aug 10 2020

Kai added inline comments to D85531: [SystemZ/ZOS] Add support for getHostNumPhysicalCores().
Aug 10 2020, 5:08 AM · Restricted Project
Kai updated the diff for D85531: [SystemZ/ZOS] Add support for getHostNumPhysicalCores().
  • Sorted condition according to OS
  • Updated/fixed comment
Aug 10 2020, 5:06 AM · Restricted Project
Kai added inline comments to D85531: [SystemZ/ZOS] Add support for getHostNumPhysicalCores().
Aug 10 2020, 3:11 AM · Restricted Project

Aug 7 2020

Kai requested review of D85531: [SystemZ/ZOS] Add support for getHostNumPhysicalCores().
Aug 7 2020, 8:45 AM · Restricted Project

Jul 28 2020

Kai requested review of D84787: [SystemZ/ZOS] __(de)register_frame are not available on z/OS..
Jul 28 2020, 12:16 PM · Restricted Project
Kai accepted D84764: Fix computeHostNumPhysicalCores() for Linux on POWER and Linux on Z.

LGTM.

Jul 28 2020, 11:21 AM · Restricted Project
Kai committed rGd3557ecede8e: [Support] Use InitLLVM in llvm-stress, sancov and TableGen (authored by anirudhp).
[Support] Use InitLLVM in llvm-stress, sancov and TableGen
Jul 28 2020, 4:51 AM
Kai closed D83484: Use InitLLVM in llvm-stress, sancov and TableGen.
Jul 28 2020, 4:51 AM · Restricted Project
Kai committed rG7294ca3f6eca: [SystemZ/ZOS] Implement setLastAccessAndModificationTime() (authored by Kai).
[SystemZ/ZOS] Implement setLastAccessAndModificationTime()
Jul 28 2020, 3:37 AM
Kai closed D83945: [SystemZ/ZOS] Implement setLastAccessAndModificationTime().
Jul 28 2020, 3:37 AM · Restricted Project

Jul 27 2020

Kai added reviewers for D82081: [z/OS] Add binary format goff and operating system zos to the triple: RKSimon, SjoerdMeijer, dexonsmith, rjmccall.

Still looking for opinions on the clang part!

Jul 27 2020, 4:34 AM · Restricted Project, Restricted Project

Jul 22 2020

Kai updated the diff for D83945: [SystemZ/ZOS] Implement setLastAccessAndModificationTime().

Changed check for error condition according to review comment.

Jul 22 2020, 7:12 AM · Restricted Project

Jul 16 2020

Herald added a project to D83945: [SystemZ/ZOS] Implement setLastAccessAndModificationTime(): Restricted Project.
Jul 16 2020, 5:48 AM · Restricted Project

Jul 15 2020

Kai accepted D83889: [NFC] [AIX] [z/OS] Fix build failure on AIX and z/OS.

LGTM.

Jul 15 2020, 11:05 AM · Restricted Project
Herald added a project to D83866: [SystemZ/ZOS] Additions to the build system.: Restricted Project.
Jul 15 2020, 5:10 AM · Restricted Project
Kai added a comment to D82081: [z/OS] Add binary format goff and operating system zos to the triple.

Is there a comment on the clang part?

Jul 15 2020, 4:58 AM · Restricted Project, Restricted Project
Kai added a comment to D83472: [SystemZ/ZOS] Add header file to encapsulate use of <sysexits.h>.

Thank you for pointing out the typo!

Jul 15 2020, 4:57 AM · Restricted Project, Restricted Project
Kai updated the diff for D83472: [SystemZ/ZOS] Add header file to encapsulate use of <sysexits.h>.

Fixed two typos in the comment.

Jul 15 2020, 4:56 AM · Restricted Project, Restricted Project

Jul 9 2020

Kai accepted D83484: Use InitLLVM in llvm-stress, sancov and TableGen.

LGTM.

Jul 9 2020, 12:22 PM · Restricted Project
Kai added a reviewer for D82081: [z/OS] Add binary format goff and operating system zos to the triple: compnerd.
Jul 9 2020, 4:34 AM · Restricted Project, Restricted Project
Herald added a project to D83472: [SystemZ/ZOS] Add header file to encapsulate use of <sysexits.h>: Restricted Project.
Jul 9 2020, 4:15 AM · Restricted Project, Restricted Project

Jul 7 2020

Kai accepted D83251: [SystemZ] Allow specifying integer registers as part of the address calculation.

LGTM.

Jul 7 2020, 5:41 AM · Restricted Project

Jul 6 2020

Kai committed rGbfd84b1c034d: [SystemZ/ZOS] Implement getMainExecutable() and is_local_impl() (authored by Kai).
[SystemZ/ZOS] Implement getMainExecutable() and is_local_impl()
Jul 6 2020, 3:49 AM
Kai committed rG0663844b064d: [SystemZ/ZOS] Define Endian constants for z/OS. (authored by Kai).
[SystemZ/ZOS] Define Endian constants for z/OS.
Jul 6 2020, 3:49 AM
Kai closed D82368: [SystemZ/zos] Define Endian constants for z/OS..
Jul 6 2020, 3:49 AM · Restricted Project
Kai closed D82544: [SystemZ][ZOS] Implement getMainExecutable() and is_local_impl().
Jul 6 2020, 3:49 AM · Restricted Project

Jun 29 2020

Kai added a reviewer for D82368: [SystemZ/zos] Define Endian constants for z/OS.: hubert.reinterpretcast.
Jun 29 2020, 6:26 AM · Restricted Project
Kai updated the diff for D82544: [SystemZ][ZOS] Implement getMainExecutable() and is_local_impl().
  • Moved comment inside #if defined(__GNU__)
Jun 29 2020, 5:54 AM · Restricted Project

Jun 25 2020

Kai updated the diff for D82544: [SystemZ][ZOS] Implement getMainExecutable() and is_local_impl().
  • Moved the first #if defined(__MVS__) into the if/elif casecade right above
  • Rearranged the #if !defined(PATH_MAX) guarded section
Jun 25 2020, 7:25 AM · Restricted Project
Kai added a reviewer for D82544: [SystemZ][ZOS] Implement getMainExecutable() and is_local_impl(): JDevlieghere.
Jun 25 2020, 6:20 AM · Restricted Project
Kai added a reviewer for D82544: [SystemZ][ZOS] Implement getMainExecutable() and is_local_impl(): chandlerc.
Jun 25 2020, 6:20 AM · Restricted Project
Kai created D82544: [SystemZ][ZOS] Implement getMainExecutable() and is_local_impl().
Jun 25 2020, 6:20 AM · Restricted Project