Page MenuHomePhabricator

Kai (Kai Nacke)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 3 2012, 7:10 AM (500 w, 22 h)

Recent Activity

Thu, Jun 30

Kai committed rG50b26de3c528: [SystemZ] Add support for tune-cpu attribute (authored by Kai).
[SystemZ] Add support for tune-cpu attribute
Thu, Jun 30, 9:51 AM · Restricted Project, Restricted Project
Kai closed D128910: [SystemZ] Add support for tune-cpu attribute.
Thu, Jun 30, 9:51 AM · Restricted Project, Restricted Project
Kai requested review of D128910: [SystemZ] Add support for tune-cpu attribute.
Thu, Jun 30, 7:11 AM · Restricted Project, Restricted Project

Tue, Jun 21

Kai added a comment to D127530: [PowerPC] Extend GlobalISel implementation to emit and/or/xor..

Thanks for the comments!

Tue, Jun 21, 1:41 PM · Restricted Project, Restricted Project
Kai updated the diff for D127530: [PowerPC] Extend GlobalISel implementation to emit and/or/xor..
  • Removed function guessRegClass()
  • selectCopy() now constraints both src and dst
  • Simplified case COPY: in RegisterBankInfo
Tue, Jun 21, 1:29 PM · Restricted Project, Restricted Project

Mon, Jun 20

Kai added inline comments to D128106: [PowerPC] Add support for G_ADD and G_SUB..
Mon, Jun 20, 12:23 PM · Restricted Project, Restricted Project
Kai updated the diff for D128106: [PowerPC] Add support for G_ADD and G_SUB..
  • Removed test in ppc-irtranslator.ll
  • Added tests for i8, i16, i32.
Mon, Jun 20, 12:21 PM · Restricted Project, Restricted Project

Fri, Jun 17

Kai requested review of D128106: [PowerPC] Add support for G_ADD and G_SUB..
Fri, Jun 17, 4:13 PM · Restricted Project, Restricted Project

Wed, Jun 15

Kai updated the diff for D127530: [PowerPC] Extend GlobalISel implementation to emit and/or/xor..
  • Add G8RC_NOX0 to register bank
  • Add new test to check lowering to GMIR
Wed, Jun 15, 11:37 AM · Restricted Project, Restricted Project

Mon, Jun 13

Kai updated the diff for D127530: [PowerPC] Extend GlobalISel implementation to emit and/or/xor..
  • clamp scalars
  • more tests
Mon, Jun 13, 1:33 PM · Restricted Project, Restricted Project
Kai added a comment to D127546: [GISel] Fix narrowScalar() for big endian targets.

Thanks for the insight! The architecture I am working on (ppc64) uses register pairs to pass integers. Apology for not producing a proper test case for m68k.
Currently my code is also very basic, so I might missed something. I'll check out the changes you pointed to, to get a better understanding.

Mon, Jun 13, 12:07 PM · Restricted Project, Restricted Project

Fri, Jun 10

Kai requested review of D127551: [GISel] Fix unmerging of constants for big endian target.
Fri, Jun 10, 4:16 PM · Restricted Project, Restricted Project
Kai added a reviewer for D127546: [GISel] Fix narrowScalar() for big endian targets: myhsu.
Fri, Jun 10, 3:49 PM · Restricted Project, Restricted Project
Kai added a reviewer for D127546: [GISel] Fix narrowScalar() for big endian targets: nemanjai.
Fri, Jun 10, 3:47 PM · Restricted Project, Restricted Project
Kai requested review of D127546: [GISel] Fix narrowScalar() for big endian targets.
Fri, Jun 10, 3:47 PM · Restricted Project, Restricted Project
Kai updated the diff for D127530: [PowerPC] Extend GlobalISel implementation to emit and/or/xor..
  • Fixed a wrong comment
  • Legalize G_CONSTANT
  • Finish test case for nand
Fri, Jun 10, 2:01 PM · Restricted Project, Restricted Project
Kai added a comment to D127530: [PowerPC] Extend GlobalISel implementation to emit and/or/xor..

Nice! My only comment is that my need some more space in PPCLegalizerInfo. You will have to add a lot more code, see e.g. AARCH64:
https://github.com/llvm/llvm-project/blob/275b2e5243639268033d6f0183b9b3b1a30574be/llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp#L41

Fri, Jun 10, 1:23 PM · Restricted Project, Restricted Project
Kai requested review of D127530: [PowerPC] Extend GlobalISel implementation to emit and/or/xor..
Fri, Jun 10, 12:42 PM · Restricted Project, Restricted Project
Kai committed rGb5019ffc8efd: [SystemZ/z/OS] Set DWARF version to 4 for z/OS. (authored by Kai).
[SystemZ/z/OS] Set DWARF version to 4 for z/OS.
Fri, Jun 10, 10:39 AM · Restricted Project, Restricted Project
Kai closed D127498: [SystemZ/z/OS] Set DWARF version to 4 for z/OS..
Fri, Jun 10, 10:39 AM · Restricted Project, Restricted Project
Kai requested review of D127498: [SystemZ/z/OS] Set DWARF version to 4 for z/OS..
Fri, Jun 10, 7:24 AM · Restricted Project, Restricted Project

Thu, Jun 9

Kai committed rG390111511614: [SystemZ/z/OS] Fix failing dynamic library unit test. (authored by Kai).
[SystemZ/z/OS] Fix failing dynamic library unit test.
Thu, Jun 9, 10:49 AM · Restricted Project, Restricted Project
Kai closed D127416: [SystemZ/z/OS] Fix failing dynamic library unit test..
Thu, Jun 9, 10:48 AM · Restricted Project, Restricted Project
Kai requested review of D127416: [SystemZ/z/OS] Fix failing dynamic library unit test..
Thu, Jun 9, 9:38 AM · Restricted Project, Restricted Project
Kai accepted D127412: [Systemz/z/OS] Add llvm.read_register() intrinsic support for zOS.

LGTM.

Thu, Jun 9, 9:07 AM · Restricted Project, Restricted Project
Kai added a comment to D127328: [Systemz/z/OS] Introduce CCAssignToRegAndStack to calling convention.

Since this change is potential useful for other platforms, it would be nice to also mention CCAssignToRegAndStack in WritingAnLLVMBackend.txt (in the bullet list at the end of chapter "Calling Conventions").

Thu, Jun 9, 6:19 AM · Restricted Project, Restricted Project

Wed, Jun 8

Kai committed rGd897a14c2ef7: [SystemZ] Fix check for zero size when lowering memcmp. (authored by Kai).
[SystemZ] Fix check for zero size when lowering memcmp.
Wed, Jun 8, 11:53 AM · Restricted Project, Restricted Project
Kai closed D126900: [SystemZ] Fix check for zero size when lowering memcmp..
Wed, Jun 8, 11:52 AM · Restricted Project, Restricted Project

Jun 2 2022

Kai requested review of D126900: [SystemZ] Fix check for zero size when lowering memcmp..
Jun 2 2022, 10:56 AM · Restricted Project, Restricted Project

May 18 2022

Kai accepted D125921: [SystemZ][z/OS] Add missing include .

LGTM.

May 18 2022, 12:54 PM · Restricted Project, Restricted Project
Kai accepted D125725: [SystemZ][z/OS] Add PPA1 support.

LGTM.

May 18 2022, 9:50 AM · Restricted Project, Restricted Project

May 9 2022

Kai committed rGb2206d1de3d3: [SystemZ] Fix argument type of tdc instruction. (authored by Kai).
[SystemZ] Fix argument type of tdc instruction.
May 9 2022, 10:14 AM · Restricted Project, Restricted Project
Kai closed D125230: [SystemZ] Fix argument type of tdc instruction..
May 9 2022, 10:14 AM · Restricted Project, Restricted Project
Kai requested review of D125230: [SystemZ] Fix argument type of tdc instruction..
May 9 2022, 7:00 AM · Restricted Project, Restricted Project

Mar 16 2022

Herald added a project to D119121: [test-suite] Add unit tests for vectorizer memory runtime checks.: Restricted Project.
Mar 16 2022, 6:30 AM · Restricted Project

Feb 22 2022

Kai updated the diff for D111437: [SystemZ/z/OS] Implement GOFF writer for empty files.

Removed unnecessary #ifndef.

Feb 22 2022, 2:16 PM · Restricted Project
Kai added a comment to D111437: [SystemZ/z/OS] Implement GOFF writer for empty files.

Thanks for the review!

Feb 22 2022, 2:15 PM · Restricted Project
Kai updated the diff for D111437: [SystemZ/z/OS] Implement GOFF writer for empty files.

Addressed review comments.

Feb 22 2022, 2:06 PM · Restricted Project
Kai added inline comments to D111437: [SystemZ/z/OS] Implement GOFF writer for empty files.
Feb 22 2022, 2:03 PM · Restricted Project
Kai committed rG30053c1445e2: [SystemZ/z/OS] Add va intrinsics for XPLINK (authored by Kai).
[SystemZ/z/OS] Add va intrinsics for XPLINK
Feb 22 2022, 11:35 AM
Kai closed D120148: [SystemZ/z/OS] Add va intrinsics for XPLINK.
Feb 22 2022, 11:35 AM · Restricted Project

Feb 18 2022

Kai updated the diff for D120148: [SystemZ/z/OS] Add va intrinsics for XPLINK.

Fix formatting.

Feb 18 2022, 12:01 PM · Restricted Project
Kai requested review of D120148: [SystemZ/z/OS] Add va intrinsics for XPLINK.
Feb 18 2022, 10:41 AM · Restricted Project

Feb 16 2022

Kai added a comment to D111437: [SystemZ/z/OS] Implement GOFF writer for empty files.

Please wait a couple of days in case there are any comments from anyone else.

Feb 16 2022, 2:07 PM · Restricted Project

Feb 15 2022

Kai updated the diff for D111437: [SystemZ/z/OS] Implement GOFF writer for empty files.
  • Renamed flags_t to Flags
  • Minimized formatting changes
Feb 15 2022, 1:08 PM · Restricted Project

Feb 14 2022

Kai committed rG713496d9c908: [SystemZ/z/OS] Add XPLINK dynamic stack allocation (authored by Kai).
[SystemZ/z/OS] Add XPLINK dynamic stack allocation
Feb 14 2022, 10:36 AM
Kai closed D119732: [SystemZ/z/OS] Add XPLINK dynamic stack allocation.
Feb 14 2022, 10:35 AM · Restricted Project
Kai requested review of D119732: [SystemZ/z/OS] Add XPLINK dynamic stack allocation.
Feb 14 2022, 9:12 AM · Restricted Project
Kai committed rG62ba528a6869: [Systemz/z/OS] Centralize emitting the call type information (authored by Kai).
[Systemz/z/OS] Centralize emitting the call type information
Feb 14 2022, 9:01 AM
Kai closed D119557: [Systemz/z/OS] Centralize emitting the call type information.
Feb 14 2022, 9:01 AM · Restricted Project

Feb 11 2022

Kai added a comment to D111437: [SystemZ/z/OS] Implement GOFF writer for empty files.

I wouldn't use `flags_t'. Isn't that namespace reserved by the standard?

Feb 11 2022, 11:55 AM · Restricted Project
Kai requested review of D119557: [Systemz/z/OS] Centralize emitting the call type information.
Feb 11 2022, 9:45 AM · Restricted Project
Kai committed rGff99f3a5c0b3: [SystemZ/z/OS] Add alias for XPLINK return (authored by Kai).
[SystemZ/z/OS] Add alias for XPLINK return
Feb 11 2022, 8:52 AM
Kai closed D119437: [SystemZ/z/OS] Add alias for XPLINK return.
Feb 11 2022, 8:52 AM · Restricted Project

Feb 10 2022

Kai requested review of D119437: [SystemZ/z/OS] Add alias for XPLINK return.
Feb 10 2022, 6:46 AM · Restricted Project

Feb 9 2022

Kai updated the diff for D111437: [SystemZ/z/OS] Implement GOFF writer for empty files.

Rebase on latest main branch.

Feb 9 2022, 6:54 AM · Restricted Project

Jan 21 2022

Kai committed rGd5ae039ed7b8: [SystemZ] Properly register machine passes. (authored by Kai).
[SystemZ] Properly register machine passes.
Jan 21 2022, 6:11 AM
Kai closed D117823: [SystemZ] Properly register machine passes..
Jan 21 2022, 6:11 AM · Restricted Project

Jan 20 2022

Kai updated the diff for D117823: [SystemZ] Properly register machine passes..

Fix formatting in SystemZ.h header file.

Jan 20 2022, 2:07 PM · Restricted Project
Kai requested review of D117823: [SystemZ] Properly register machine passes..
Jan 20 2022, 11:32 AM · Restricted Project

Jan 11 2022

Kai added a comment to D117050: [GISel] Extend code emitter to emit #undef symbol.

In most other cases, it is done in this way. E.g. from AArch64RegisterInfo.h:

Jan 11 2022, 1:56 PM · Restricted Project
Kai requested review of D117050: [GISel] Extend code emitter to emit #undef symbol.
Jan 11 2022, 1:17 PM · Restricted Project

Dec 13 2021

Kai committed rGffad4d777b22: [z/OS] Implement prologue and epilogue generation for z/OS target. (authored by Everybody0523).
[z/OS] Implement prologue and epilogue generation for z/OS target.
Dec 13 2021, 2:03 PM
Kai closed D114457: [z/OS] Implement prologue and epilogue generation for z/OS target..
Dec 13 2021, 2:03 PM · Restricted Project

Dec 6 2021

Kai added a comment to D114457: [z/OS] Implement prologue and epilogue generation for z/OS target..

Reading the long comment, I guess that there is a systematic error in the calculation of the stack offsets.

Dec 6 2021, 1:27 PM · Restricted Project

Nov 15 2021

Kai added a comment to D113894: [x86/asm] Make variants work when converting at&t inline asm input to intel asm output.

The z/OS test coverage is still a bit weak -- @Kai, do we have inline assembler tests in the tree already?

Nov 15 2021, 10:42 AM · Restricted Project

Nov 10 2021

Kai added inline comments to D88741: [SystemZ/z/OS] Add utility class for char set conversion..
Nov 10 2021, 1:44 PM · Restricted Project
Kai updated the diff for D88741: [SystemZ/z/OS] Add utility class for char set conversion..

Fix a couple of review comments.

Nov 10 2021, 1:41 PM · Restricted Project
Kai added reviewers for D111437: [SystemZ/z/OS] Implement GOFF writer for empty files: RKSimon, nikic, rnk, mstorsjo.
Nov 10 2021, 8:14 AM · Restricted Project
Kai updated the diff for D111437: [SystemZ/z/OS] Implement GOFF writer for empty files.

Update formatting.

Nov 10 2021, 7:59 AM · Restricted Project

Nov 9 2021

Kai updated the diff for D111437: [SystemZ/z/OS] Implement GOFF writer for empty files.

Fix path of moved include.

Nov 9 2021, 4:14 PM · Restricted Project

Nov 3 2021

Kai added inline comments to D88741: [SystemZ/z/OS] Add utility class for char set conversion..
Nov 3 2021, 12:53 PM · Restricted Project
Kai updated the diff for D88741: [SystemZ/z/OS] Add utility class for char set conversion..
  • only support reversible conversions
  • make sure that all converters behave in the same way
  • updated comments
Nov 3 2021, 12:40 PM · Restricted Project

Nov 1 2021

Kai added a comment to D111437: [SystemZ/z/OS] Implement GOFF writer for empty files.

More comments about the implementation?
E.g. is the name flags_t acceptable?

Nov 1 2021, 7:17 AM · Restricted Project

Oct 19 2021

Kai added inline comments to D88741: [SystemZ/z/OS] Add utility class for char set conversion..
Oct 19 2021, 7:59 AM · Restricted Project
Kai added a comment to D88741: [SystemZ/z/OS] Add utility class for char set conversion..

I've looked at the new changes and verified that the recent updates are an improvement. There remain unaddressed comments.

Oct 19 2021, 7:18 AM · Restricted Project
Kai updated the diff for D88741: [SystemZ/z/OS] Add utility class for char set conversion..
  • Update table-based algorithm to map Unicode characters outside the range [U+0080, U+00FF] to the SUB character. This is the same behavior as iconv.
  • Add a new identify transformation which does not alter UTF-8 sequences
  • Use resize_for_overwrite for memory allocation
Oct 19 2021, 7:17 AM · Restricted Project

Oct 14 2021

Kai added inline comments to D88741: [SystemZ/z/OS] Add utility class for char set conversion..
Oct 14 2021, 1:04 PM · Restricted Project
Kai updated the diff for D88741: [SystemZ/z/OS] Add utility class for char set conversion..

Changes based on review comments:

Oct 14 2021, 12:29 PM · Restricted Project
Kai committed rGb050564d3e93: [AIX] Ignore case when comparing output from od (authored by Kai).
[AIX] Ignore case when comparing output from od
Oct 14 2021, 10:53 AM
Kai closed D111427: [AIX] Ignore case when comparing output from od.
Oct 14 2021, 10:52 AM · Restricted Project

Oct 13 2021

Kai added inline comments to D111437: [SystemZ/z/OS] Implement GOFF writer for empty files.
Oct 13 2021, 1:44 PM · Restricted Project
Kai updated the diff for D111437: [SystemZ/z/OS] Implement GOFF writer for empty files.
  • Removed writing logical record count in END record
  • Fixed formatting
Oct 13 2021, 1:43 PM · Restricted Project
Kai committed rG0a950a2e94f2: [SystemZ/z/OS] Implement save of non-volatile registers on z/OS XPLINK (authored by Kai).
[SystemZ/z/OS] Implement save of non-volatile registers on z/OS XPLINK
Oct 13 2021, 9:59 AM
Kai closed D111653: [z/OS] Implement save of non-volatile registers on z/OS XPLINK.
Oct 13 2021, 9:59 AM · Restricted Project
Kai accepted D111653: [z/OS] Implement save of non-volatile registers on z/OS XPLINK.

LGTM.

Oct 13 2021, 9:12 AM · Restricted Project

Oct 12 2021

Kai added inline comments to D111437: [SystemZ/z/OS] Implement GOFF writer for empty files.
Oct 12 2021, 1:17 PM · Restricted Project
Kai updated the diff for D88741: [SystemZ/z/OS] Add utility class for char set conversion..

Rebased on latest main.

Oct 12 2021, 1:05 PM · Restricted Project

Oct 8 2021

Kai requested review of D111437: [SystemZ/z/OS] Implement GOFF writer for empty files.
Oct 8 2021, 9:25 AM · Restricted Project
Kai requested review of D111427: [AIX] Ignore case when comparing output from od.
Oct 8 2021, 8:37 AM · Restricted Project

Sep 30 2021

Kai accepted D110730: [SystemZ][z/OS] Introduce initial support for GOFF asm parser.

LGTM.

Sep 30 2021, 1:28 PM · Restricted Project
Kai added inline comments to D110730: [SystemZ][z/OS] Introduce initial support for GOFF asm parser.
Sep 30 2021, 10:53 AM · Restricted Project

Sep 29 2021

Kai requested changes to D110730: [SystemZ][z/OS] Introduce initial support for GOFF asm parser.
Sep 29 2021, 10:39 AM · Restricted Project

Sep 9 2021

Kai updated the diff for D88741: [SystemZ/z/OS] Add utility class for char set conversion..

Fix wrong use of #ifdef

Sep 9 2021, 4:12 PM · Restricted Project
Kai updated the diff for D88741: [SystemZ/z/OS] Add utility class for char set conversion..

Fixed a problem in the CMake files.
This should finally fix the problem seen on the Windows builder.

Sep 9 2021, 3:11 PM · Restricted Project
Kai committed rG0782e55c26bf: [SystemZ] [NFC] Add SystemZELFFrameLowering and SystemZXPLINKFrameLowering… (authored by Everybody0523).
[SystemZ] [NFC] Add SystemZELFFrameLowering and SystemZXPLINKFrameLowering…
Sep 9 2021, 9:26 AM
Kai closed D108777: [SystemZ] [NFC] Add SystemZELFFrameLowering and SystemZXPLINKFrameLowering classes..
Sep 9 2021, 9:26 AM · Restricted Project
Kai accepted D108777: [SystemZ] [NFC] Add SystemZELFFrameLowering and SystemZXPLINKFrameLowering classes..

LGTM.

Sep 9 2021, 8:36 AM · Restricted Project

Sep 7 2021

Kai requested changes to D108777: [SystemZ] [NFC] Add SystemZELFFrameLowering and SystemZXPLINKFrameLowering classes..

Sorry, after seeing the pre-check builds, I checked the formatting again.
The code looks ok, but almost all function heads with argument lists running over several lines needs reformatting.

Sep 7 2021, 1:14 PM · Restricted Project
Kai accepted D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout.

LGTM. Thanks for the documentation update.

Sep 7 2021, 9:47 AM · Restricted Project, Restricted Project