• Added a TODO comment to the linker strip section
• Both z/OS and AIX now use CMAKE_SYSTEM_NAME to determine the host system

• Position-independent code needs not to be disabled
• Removed message stating that static symbol export is not supported

Any comments on this change?

• Remove list of systems from comment.

• Sorted condition according to OS
• Updated/fixed comment

LGTM.

Still looking for opinions on the clang part!

Changed check for error condition according to review comment.

LGTM.

Is there a comment on the clang part?

Thank you for pointing out the typo!

Fixed two typos in the comment.

LGTM.

LGTM.

• Moved comment inside #if defined(__GNU__)

• Moved the first #if defined(__MVS__) into the if/elif casecade right above
• Rearranged the #if !defined(PATH_MAX) guarded section

• Added a break; in several places
• Follow local formatting style in triple.cpp

I would like to get a 2nd opinion before committing.

• In Triple.cpp: Keep list of binary formats sorted
• In Triple.cpp: Use isOSzOS() for check

• Relative order is now consistently GOFF before XCOFF
• llvm_report_fatal() now follows guideline
• Updated formatting

LGTM.

LGTM. Thanks!

This PR requires TLS support even if LLVM_ENABLE_THREADS is set to OFF. Is this intended?

In D68146#1704250, @rupprecht wrote:

In D68146#1703693, @thakis wrote:

The test fails on Linux: http://lab.llvm.org:8011/builders/clang-cmake-x86_64-sde-avx512-linux/builds/28537/steps/ninja%20check%201/logs/FAIL%3A%20LLVM%3A%3Acheck-ignore-case.txt If it takes a while to fix please revert while you investigate.

Also, https://github.com/llvm/llvm-project/commit/dfd2b6f07fc40a190335f580d8a965bbebfe94df looks like you touched ~all lines in docs/CommandGuide/FileCheck.rst and llvm/include/llvm/Support/FileCheck.h Maybe you converted them to windows line endings? If so, please undo that. (Maybe revert and reland with fixed line endings so that the diff for the actual change is readable.)

As described in http://llvm.org/docs/GettingStarted.html#checkout-llvm-from-git, the right way to checkout the repository on windows is:

% git clone --config core.autocrlf=false https://github.com/llvm/llvm-project.git

This is the second time I've reviewed a change like this without realizing, would appreciate tips if this could be more visible in Phab somehow...

Updated test case:

Changed description of option.

Added a test for CHECK-SAME and for -implicit-check-not.

Added newline at end of test case.

Change single digit in test case to form a sequence.

In D68146#1691246, @MaskRay wrote:

To make it really --ignore-case, the pattern should also be changed to lowercase.

Added a test case and documentation for the --ignore-case option.
Removed the changed test cases.

FileCheck has now a new option --ignore-case.
I updated the test cases to use the new option. I touched only test cases which have the lower case/upper case letter problem. I also did not add -A n because some tests also check for the address.

Yeah, I agree that this is painful. I'll have a look at FileCheck because this really feels like the right solution.
I am not on AIX but z/OS USS.

• Add OF_Text for opt assembly output
• Fix RemarkStreamer
• Use OF_None instead of F_None in new code

Fixed an error introduced in the previous revision.

In D67696#1674254, @rnk wrote:

The main effect that I'm aware of here is that this will do CRLF conversion on Windows. Are we sure we really want that? I just did the opposite to TableGen output in rL371683. In general, I think the majority of tools that write text use OF_Text, so your change makes this minority of tools consistent with the other ones.

Use OF_Text for the RemarkStreamer only if format is YAML.

Superceded by latest additions for AIX.