This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][MC] Mark Zawrs extension as non-experimental
ClosedPublic

Authored by asb on Feb 7 2023, 8:40 AM.

Details

Summary

Support for the unratified 1.0-rc3 specification was introduced in D133443. The specification has since been ratified (in November 2022 according to the recently ratified extensions list.

A review of the diff of the 1.0-rc3 spec vs the current/ratified document shows no changes to the instruction encoding or naming. At one point, a note was added indicating Zawrs depends on the Zalrsc extension (not officially specified, but I believe to be just the LR/SC instructions from the A extension). The final text ended up as "The instructions in the Zawrs extension are only useful in conjunction with the LR instructions, which are provided by the A extension, and which we also expect to be provided by a narrower Zalrsc extension in the future." I think it's consistent with this phrasing to not require the A extension for Zawrs, which matches what was implemented.

No intrinsics are implemented for Zawrs currently, meaning we don't need to additionally review whether those intrinsics can be considered finalised and ready for exposure to end users.

Diff Detail

Event Timeline

asb created this revision.Feb 7 2023, 8:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 7 2023, 8:40 AM
asb requested review of this revision.Feb 7 2023, 8:40 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 7 2023, 8:40 AM
asb edited the summary of this revision. (Show Details)Feb 7 2023, 8:41 AM
reames accepted this revision.Feb 8 2023, 7:44 AM

LGTM

This revision is now accepted and ready to land.Feb 8 2023, 7:44 AM
kito-cheng accepted this revision.Feb 10 2023, 1:45 AM
This revision was automatically updated to reflect the committed changes.