Page MenuHomePhabricator
Differential D143018

[DAGCombiner][NFC] Factor out ByteProvider
Needs ReviewPublic
Actions

Authored by jrbyrnes on Jan 31 2023, 2:30 PM.

Details

Reviewers
arsenm
RKSimon
spatel
tschuett
Summary

Bring ByteProvider into header to serve as generic utility.

Diff Detail

Event Timeline

jrbyrnes created this revision.Jan 31 2023, 2:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2023, 2:30 PM
Herald added subscribers: ecnelises, hiraditya. · View Herald Transcript
jrbyrnes requested review of this revision.Jan 31 2023, 2:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2023, 2:30 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
jrbyrnes mentioned this in D142782: [AMDGPU] Add basic support for extended i8 perm matching.Jan 31 2023, 2:36 PM
jrbyrnes updated this revision to Diff 493741.Jan 31 2023, 2:41 PM

Fix comments.

Harbormaster completed remote builds in B211078: Diff 493741.Jan 31 2023, 5:26 PM
jrbyrnes updated this revision to Diff 494442.Feb 2 2023, 3:05 PM

Restructure

jrbyrnes added a subscriber: arsenm.Feb 2 2023, 3:05 PM

@arsenm is that what you had in mind?

Harbormaster completed remote builds in B211590: Diff 494442.Feb 2 2023, 5:23 PM
jrbyrnes updated this revision to Diff 495567.Feb 7 2023, 8:47 AM

Format + Comments

jrbyrnes added a reviewer: arsenm.Feb 7 2023, 9:49 AM

Factor out common code for use in https://reviews.llvm.org/D142782 . Template class for eventual porting to GlobalISel.

Herald added a subscriber: wdng. · View Herald TranscriptFeb 7 2023, 9:49 AM
Harbormaster completed remote builds in B212416: Diff 495567.Feb 7 2023, 10:52 AM
jrbyrnes updated this revision to Diff 499912.Thu, Feb 23, 10:36 AM

Require contained class in ByteProvider to have getOpcode (class must be node in selection DAG)

jrbyrnes updated this revision to Diff 499914.Thu, Feb 23, 10:38 AM

Typo

tschuett added a subscriber: tschuett.Thu, Feb 23, 11:35 AM
tschuett added inline comments.
llvm/include/llvm/ADT/ByteProvider.h
27

Why struct, when you use private and public?

30

using instead of typedef?

52

Why struct?

92

Newline missing

Harbormaster completed remote builds in B215557: Diff 499914.Thu, Feb 23, 12:39 PM
jrbyrnes updated this revision to Diff 500262.Fri, Feb 24, 11:19 AM
jrbyrnes marked 4 inline comments as done.

Address review comments -- thanks @tschuett

Harbormaster completed remote builds in B215808: Diff 500262.Fri, Feb 24, 9:27 PM
jrbyrnes added reviewers: RKSimon, spatel, tschuett.Thu, Mar 16, 11:05 AM

Add outside reviewers

Herald added a subscriber: StephenFan. · View Herald TranscriptThu, Mar 16, 11:05 AM
arsenm added inline comments.Fri, Mar 17, 9:46 AM
llvm/include/llvm/ADT/ByteProvider.h
54

probably should use int64_t offsets?

jrbyrnes updated this revision to Diff 506212.Fri, Mar 17, 3:34 PM
jrbyrnes marked an inline comment as done.

int64_t offsets

Harbormaster completed remote builds in B220157: Diff 506212.Fri, Mar 17, 5:50 PM

Revision Contents
Changeset List

PathSize
llvm/
include/
llvm/
ADT/
91 lines
lib/
CodeGen/
SelectionDAG/
78 lines

Diff 506212

View Options

llvm/include/llvm/ADT/ByteProvider.h

Loading...
View Options

llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

Loading...