This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Move Processors and Features from RISCV.td to their own files.
ClosedPublic

Authored by craig.topper on Jan 20 2023, 10:31 AM.

Details

Summary

This reduces RISCV.td to mainly being a top level include file.

Diff Detail

Event Timeline

craig.topper created this revision.Jan 20 2023, 10:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2023, 10:31 AM
craig.topper requested review of this revision.Jan 20 2023, 10:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2023, 10:31 AM
asb accepted this revision.Jan 20 2023, 11:27 AM

Seems like a reasonable refactoring to me. Perhaps worth waiting a day or two to check nobody else has strong opinions on this.

llvm/lib/Target/RISCV/RISCV.td
34

Nit: would "RISC-V Scheduling Models" be more -inline with usual LLVM terminology? (I _think_ that's what I've seen more commonly, but I could be wrong!)

This revision is now accepted and ready to land.Jan 20 2023, 11:27 AM

Scheduler -> Scheduling

I don't have any strong preference on this one.

luismarques accepted this revision.Jan 23 2023, 9:49 AM
This revision was landed with ongoing or failed builds.Jan 23 2023, 10:17 AM
This revision was automatically updated to reflect the committed changes.