This is an archive of the discontinued LLVM Phabricator instance.

[docs] add early Arm arch support improvements to release notes
ClosedPublic

Authored by stuij on Jan 20 2023, 9:05 AM.

Download Raw Diff

Details

Reviewers

peter.smith
pratlucas

Commits

rGb1d1a1a59243: [docs] add early Arm arch support improvements to release notes

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	60,030 ms	x64 debian > libFuzzer.libFuzzer::minimize_crash.test
	60,080 ms	x64 debian > libFuzzer.libFuzzer::value-profile-load.test
	60,140 ms	x64 debian > libFuzzer.libFuzzer::value-profile-switch.test

Event Timeline

stuij created this revision.Jan 20 2023, 9:05 AM

Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2023, 9:05 AM

Herald added a subscriber: kristof.beyls. · View Herald Transcript

stuij requested review of this revision.Jan 20 2023, 9:05 AM

Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2023, 9:05 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

stuij added reviewers: peter.smith, pratlucas.Jan 20 2023, 9:06 AM

tschuett added a subscriber: tschuett.Jan 20 2023, 9:14 AM

tschuett added inline comments.

llvm/docs/ReleaseNotes.rst
135	Armv4

fix typo

stuij marked an inline comment as done.Jan 20 2023, 9:18 AM

Harbormaster completed remote builds in B209018: Diff 490891.Jan 20 2023, 11:47 AM

I think this is pretty close. I think we shouldn't claim full support for Armv4 as we don't support the R_ARMV4BX relocation yet.

llvm/docs/ReleaseNotes.rst
133	Sadly I think we'll need to drop full support for Armv4 as we are missing support for the R_ARM_V4BX relocation (https://github.com/llvm/llvm-project/blob/main/lld/ELF/Arch/ARM.cpp#L166) . This isn't important for clang as it uses mov pc,lr when compiling for -march=armv4, but it is possible that some GNU input objects will have bx lr along with a R_ARM_V4BX relocation. I suggest Added Armv4 and Armv4T compatible thunks. LLD will no longer generate BX instructions for Armv4 or BLX instructions for either Armv4 or Armv4T. Armv4T is now fully supported.

rephrasing after review comment

stuij marked an inline comment as done.Jan 23 2023, 7:27 AM

stuij added inline comments.

llvm/docs/ReleaseNotes.rst
133	Thanks! Done.

Thanks for the update, LGTM.

This revision is now accepted and ready to land.Jan 23 2023, 7:38 AM

This revision was landed with ongoing or failed builds.Jan 23 2023, 8:12 AM

Closed by commit rGb1d1a1a59243: [docs] add early Arm arch support improvements to release notes (authored by stuij). · Explain Why

This revision was automatically updated to reflect the committed changes.

stuij marked an inline comment as done.

stuij added a commit: rGb1d1a1a59243: [docs] add early Arm arch support improvements to release notes.

Harbormaster completed remote builds in B209374: Diff 491370.Jan 23 2023, 9:40 AM

Revision Contents

Path

Size

llvm/

docs/

ReleaseNotes.rst

6 lines

Diff 490891

llvm/docs/ReleaseNotes.rst

	Show First 20 Lines • Show All 121 Lines • ▼ Show 20 Lines
	* Added support for assembly for RME MEC (Memory Encryption Contexts).			* Added support for assembly for RME MEC (Memory Encryption Contexts).

	Changes to the AMDGPU Backend			Changes to the AMDGPU Backend
	-----------------------------			-----------------------------

	Changes to the ARM Backend			Changes to the ARM Backend
	--------------------------			--------------------------

	* Support for targeting armv2, armv2A, armv3 and armv3M has been removed.			* Support for targeting Armv2, Armv2A, Armv3 and Armv3M has been removed.
	LLVM did not, and was not ever likely to generate correct code for those			LLVM did not, and was not ever likely to generate correct code for those
	architecture versions so their presence was misleading.			architecture versions so their presence was misleading.
				* Added full LLD support for Armv4 and Armv4T by adding support for Armv4 and
				peter.smithUnsubmitted Done Reply Inline Actions Sadly I think we'll need to drop full support for Armv4 as we are missing support for the R_ARM_V4BX relocation (https://github.com/llvm/llvm-project/blob/main/lld/ELF/Arch/ARM.cpp#L166) . This isn't important for clang as it uses mov pc,lr when compiling for -march=armv4, but it is possible that some GNU input objects will have bx lr along with a R_ARM_V4BX relocation. I suggest Added Armv4 and Armv4T compatible thunks. LLD will no longer generate BX instructions for Armv4 or BLX instructions for either Armv4 or Armv4T. Armv4T is now fully supported. peter.smith: Sadly I think we'll need to drop full support for Armv4 as we are missing support for the…
				stuijAuthorUnsubmitted Done Reply Inline Actions Thanks! Done. stuij: Thanks! Done.
				Armv4T thunks. LLD will no longer generate BX instructions for Armv4 or BLX
				instructions for either Armv4 or Armv4T.
				tschuettUnsubmitted Done Reply Inline Actions Armv4 tschuett: Armv4
				* Added compiler-rt builtins support for Armv4T, Armv5TE and Armv6.

	Changes to the AVR Backend			Changes to the AVR Backend
	--------------------------			--------------------------

	* ...			* ...

	Changes to the DirectX Backend			Changes to the DirectX Backend
	------------------------------			------------------------------
	▲ Show 20 Lines • Show All 155 Lines • Show Last 20 Lines