User Details
- User Since
- Apr 24 2018, 8:11 AM (213 w, 3 d)
Fri, Apr 29
Thu, Apr 28
Apr 21 2022
addressing review comment
Apr 20 2022
Apr 7 2022
Mar 28 2022
fix typo
Mar 15 2022
Mar 14 2022
Mar 11 2022
addressed review comments
Mar 8 2022
Feb 4 2022
Jan 31 2022
Jan 27 2022
Jan 21 2022
addressed review comments
Thanks for the update. Same(ish) questions for the Arm side. Otherwise this LGTM
Jan 20 2022
addressed review comments
Jan 13 2022
Jan 10 2022
I did some more testing, and unfortunately we can't rely on LRSpilled being set correctly.
Jan 7 2022
Yea, good point. I amended the patch.
Nit: perhaps make the commit message a little bit clearer.
Dec 23 2021
Dec 10 2021
removed accidentally included Clang release notes draft
Dec 9 2021
rebasing
Dec 8 2021
rebased as per review request
Dec 7 2021
@danielkiss Yes that needs to be addressed, but we are doing that in another patch that will (hopefully) cover all permutations of architecture and branch protection values on both the cmdline and as function attributes.
rebasing
Dec 6 2021
another tickle
tickling the commit so the buildbot picks up the dependency
@erichkeane : thanks so much for going through the trouble to see what the problem is!
I've put up a fix with your suggested change at https://reviews.llvm.org/D115141
Dec 1 2021
Yes, pushed a temporary fix.
rebased and resolved merge conflict
Nov 30 2021
slight rewording
Nov 29 2021
reuploading after rebase to resolve patch apply failure
uploading after rebase as per reviewer request (no changes in the patch itself)
address review comments
address review comments, and obey clang-format
obeying clang-format
minor clang-format conformance changes
addressed review comment and clang-format suggestions
Nov 26 2021
addressed review comments
Nov 24 2021
address review comments
Nov 23 2021
Disable shrinkwrapping for now when using PAC. A separate patch will tackle PAC and shrinkwrapping playing nice.
Nov 22 2021
addressed review comments, namely adding a commandline argument, -mno-bti-at-return-twice, to not place a bti instruction after a setjmp call.