- User Since
- Apr 24 2018, 8:11 AM (135 w, 3 d)
Oct 27 2020
If this cannot be reproduced with the OSS LLVM, I am not sure you should adjust such a test.
Abandoned because lack of reaction for such an unimportant issue.
Oct 20 2020
Oct 13 2020
Oct 12 2020
addressed review comment to hardwire non-MS target platforms
Oct 7 2020
Hi @MaskRay. Yes, so we're seeing a warning specific to our Armcompiler toolchain, so I'm guessing that isn't relevant to OSS LLVM:
armclang: warning: '--target=x86_64-unknown-linux' is not supported.
After committing this patch, clang/test/CodeGen/volatile.c failed on Arm/AArch64 buildbot hosts. The reason for this is that %itanium_abi_triple, a run line Lit target triple substitution at the top of the file, is filled in with the host arch triple. For example: aarch64-unknown-linux-gnu. I've amended the tests to take into account the changes to code generation in this patch.
Reopening as this commit made clang/test/CodeGen/volatile.c fail on Arm/AArch64 buildbot hosts.
Sep 30 2020
slight change in commit message
Sep 11 2020
I'm not sure what the procedure is to get patches into LLVM 11, but I think there's still time. Could you try to get this in there as well @c-rhodes ?
Sep 10 2020
Thanks, this one crept in during mass-renaming.
Sep 8 2020
addressed review comment
Commandeering as I've made some changes to the patch.
Aug 28 2020
Looks harmless :o) Thanks, LGTM.
Aug 27 2020
addressing review comments
Aug 3 2020
Aug 2 2020
Jul 8 2020
addressed review comment
Jul 6 2020
Jun 23 2020
Jun 22 2020
Jun 18 2020
Jun 16 2020
We only remove clang-side lowering for non-vector bfloat types.
Jun 15 2020
LGTM. Thanks :)
I would have expected changes for neon as well.
adjust arm bfloat mangle tests for these changes
Jun 12 2020
Jun 11 2020
Jun 7 2020
Jun 5 2020
Ah, awesome. Thanks :)
Yup, LLVM now builds and check-all's. Thanks for fixing!
ah sorry, I guess that might have been the wrong link. My copy pasting skills are flaky.
Seems like this is breaking on buildbot (and also my local checkout): http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/16759
Jun 4 2020
addressed remaining nits
Resolved merge conflicts with head. Fixed minor oversight.
For the backend tests, I suggest using -asm-verbose=0 with llc to only print instructions and get rid of // kill: .. and friends. Use update_cc_test_checks.py again to regenerate the testing.
Jun 3 2020
Addressed review comments. Notably what to do in combination with -mfloat-abi=soft.
Jun 2 2020
Jun 1 2020
May 29 2020
May 28 2020
We need testing for the backend code.