- User Since
- Apr 24 2018, 8:11 AM (109 w, 12 h)
add bfloat header test
replanted arg passing test from other patch
addressed review comments and some related general changes:
- renamed IsSoftFloatABI -> IsFloatABISoftFP
- split bfloat tests out of arm-mangle-16bit-float.cpp
- bfloat shouldn't be checking for NativeHalfType
- err_cast_(from|to)_bfloat -> err_cast_(from|to)_bfloat16
- reworded comments and other minor fixes
Fri, May 22
moving 'CartesianProductWith' to more apt patch
no explicit float-abi cmdline arg should default to softfp
making testing more robust as per review comments
Thanks Francesco, that was enlightening, and great info to know. I took on all your suggestions, and changed the testing accordingly.
Thu, May 21
addressed review comments, most of all changed license header on the generated bfloat file
added testcases, following fp16's lead
Hiya Francesco, thanks for the thorough comment :)
Wed, May 20
Note that these argument passing tests discussed above aren't present in the follow-up patch at the moment. I'm currently implementing them.
Having a think, I think the calling convention test would be more meaningful if we have a bit more bfloat lowering support. Which we have in the bfloat lowering follow-up patch: https://reviews.llvm.org/D79712
Mon, May 18
adhere to attribution conventions: change author to Ties, add all the contributors
adhere to patch attribution conventions: change author to Ties, add all the contributors
adhere to attribution conventions
adhere to patch attribution conventions
added bfloat SVE MVT type
fix bug that failed webassembly test
redo: addressing review comments and adding Simon Tatham to contributers
addressing review comments and adding Simon Tatham to contributers
Sat, May 16
@LukeGeeson: you're already mentioned :) See the commits tab on this review. But Simon Tatham needs a mention as well. I shall add him.
@fpetrogalli: Yes, good point. It was on my todo. I had tested these changes with such a snippet, so there's no good reason I didn't add it in the first place.
Fri, May 15
Wed, May 13
fix bug in ReplaceBITCASTResults
- addressed asmith's comments
- Bfloat doesn't depend on half cmdline options and correct code is generation for AArch32 hard and softfp CC
@asmith: Thanks for reviewing :) Fixed your suggestions in the coming revision.
Mon, May 11
Hi there, a gentle ping: does this look good to you?
Tue, May 5
So are we happy with the patch as it is? Anybody else wants to LGTM?
added vector tests