Page MenuHomePhabricator
People stuij

stuij (Ties Stuij)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 24 2018, 8:11 AM (213 w, 3 d)

Recent Activity
View All

Fri, Apr 29

stuij added inline comments to D123763: [randstruct] Enforce using a designated init for a randomized struct.
Fri, Apr 29, 3:09 AM · Restricted Project, Restricted Project

Thu, Apr 28

stuij committed rG051deb2d9d34: [ARM] add Armv9 build attribute (authored by stuij).
[ARM] add Armv9 build attribute
Thu, Apr 28, 2:49 AM · Restricted Project, Restricted Project
stuij closed D124090: [ARM] add Armv9 build attribute.
Thu, Apr 28, 2:48 AM · Restricted Project, Restricted Project

Apr 21 2022

stuij added inline comments to D124090: [ARM] add Armv9 build attribute.
Apr 21 2022, 3:17 AM · Restricted Project, Restricted Project
stuij updated the diff for D124090: [ARM] add Armv9 build attribute.

addressing review comment

Apr 21 2022, 3:10 AM · Restricted Project, Restricted Project

Apr 20 2022

stuij added reviewers for D124090: [ARM] add Armv9 build attribute: MaskRay, simon_tatham, vhscampos, tmatheson.
Apr 20 2022, 6:58 AM · Restricted Project, Restricted Project
stuij requested review of D124090: [ARM] add Armv9 build attribute.
Apr 20 2022, 6:44 AM · Restricted Project, Restricted Project

Apr 7 2022

stuij committed rGedeceb8647ff: remove dead code in parseRegisterList checking for ARM::RA_AUTH_CODE (authored by stuij).
remove dead code in parseRegisterList checking for ARM::RA_AUTH_CODE
Apr 7 2022, 6:54 AM · Restricted Project, Restricted Project
stuij closed D122577: remove dead code in parseRegisterList checking for ARM::RA_AUTH_CODE.
Apr 7 2022, 6:54 AM · Restricted Project, Restricted Project

Mar 28 2022

stuij updated the diff for D122577: remove dead code in parseRegisterList checking for ARM::RA_AUTH_CODE.

fix typo

Mar 28 2022, 5:37 AM · Restricted Project, Restricted Project
Herald added a project to D112429: [ARM] Implement PAC return address signing mechanism for PACBTI-M: Restricted Project.
Mar 28 2022, 5:30 AM · Restricted Project, Restricted Project
stuij added reviewers for D122577: remove dead code in parseRegisterList checking for ARM::RA_AUTH_CODE: RKSimon, chill.
Mar 28 2022, 5:29 AM · Restricted Project, Restricted Project
stuij requested review of D122577: remove dead code in parseRegisterList checking for ARM::RA_AUTH_CODE.
Mar 28 2022, 5:27 AM · Restricted Project, Restricted Project

Mar 15 2022

stuij committed rG352453569b2b: [AARCH64] ssbs should be enabled by default for cortex-x1, cortex-x1c, cortex… (authored by stuij).
[AARCH64] ssbs should be enabled by default for cortex-x1, cortex-x1c, cortex…
Mar 15 2022, 6:45 AM · Restricted Project
stuij closed D121206: [AARCH64] ssbs should be enabled by default for cortex-x1, cortex-x1c, cortex-a77.
Mar 15 2022, 6:44 AM · Restricted Project, Restricted Project, Restricted Project

Mar 14 2022

stuij added inline comments to D121206: [AARCH64] ssbs should be enabled by default for cortex-x1, cortex-x1c, cortex-a77.
Mar 14 2022, 7:32 AM · Restricted Project, Restricted Project, Restricted Project

Mar 11 2022

stuij added inline comments to D121206: [AARCH64] ssbs should be enabled by default for cortex-x1, cortex-x1c, cortex-a77.
Mar 11 2022, 4:27 AM · Restricted Project, Restricted Project, Restricted Project
stuij retitled D121206: [AARCH64] ssbs should be enabled by default for cortex-x1, cortex-x1c, cortex-a77 from [AARCH64] ssbs should be enabled by default for cortex-x1c to [AARCH64] ssbs should be enabled by default for cortex-x1, cortex-x1c, cortex-a77.
Mar 11 2022, 4:24 AM · Restricted Project, Restricted Project, Restricted Project
stuij updated the diff for D121206: [AARCH64] ssbs should be enabled by default for cortex-x1, cortex-x1c, cortex-a77.

addressed review comments

Mar 11 2022, 4:22 AM · Restricted Project, Restricted Project, Restricted Project

Mar 8 2022

stuij added reviewers for D121206: [AARCH64] ssbs should be enabled by default for cortex-x1, cortex-x1c, cortex-a77: vhscampos, keith.walker.arm, DavidSpickett.
Mar 8 2022, 4:34 AM · Restricted Project, Restricted Project, Restricted Project
stuij requested review of D121206: [AARCH64] ssbs should be enabled by default for cortex-x1, cortex-x1c, cortex-a77.
Mar 8 2022, 3:48 AM · Restricted Project, Restricted Project, Restricted Project

Feb 4 2022

stuij added reviewers for D119008: Add Cortex-X1C to Clang LLVM 14 release notes: keith.walker.arm, amilendra, simpal01.
Feb 4 2022, 9:00 AM · Restricted Project
stuij requested review of D119008: Add Cortex-X1C to Clang LLVM 14 release notes.
Feb 4 2022, 8:58 AM · Restricted Project

Jan 31 2022

stuij committed rG1adfbfcf39f9: Add info on PACBTI-M to the Clang release notes (authored by stuij).
Add info on PACBTI-M to the Clang release notes
Jan 31 2022, 11:02 AM
stuij closed D118380: Add info on PACBTI-M to the Clang release notes.
Jan 31 2022, 11:02 AM · Restricted Project
stuij committed rG6b1e844b69f1: [ARM] Add Cortex-X1C Support for Clang and LLVM (authored by stuij).
[ARM] Add Cortex-X1C Support for Clang and LLVM
Jan 31 2022, 6:24 AM
stuij closed D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM.
Jan 31 2022, 6:23 AM · Restricted Project, Restricted Project

Jan 27 2022

stuij added reviewers for D118380: Add info on PACBTI-M to the Clang release notes: chill, amilendra.
Jan 27 2022, 8:47 AM · Restricted Project
stuij requested review of D118380: Add info on PACBTI-M to the Clang release notes.
Jan 27 2022, 8:45 AM · Restricted Project

Jan 21 2022

stuij updated the diff for D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM.

addressed review comments

Jan 21 2022, 4:09 AM · Restricted Project, Restricted Project
stuij added a comment to D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM.

Thanks for the update. Same(ish) questions for the Arm side. Otherwise this LGTM

Jan 21 2022, 4:09 AM · Restricted Project, Restricted Project

Jan 20 2022

stuij updated the diff for D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM.

addressed review comments

Jan 20 2022, 2:29 AM · Restricted Project, Restricted Project
stuij added inline comments to D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM.
Jan 20 2022, 2:15 AM · Restricted Project, Restricted Project

Jan 13 2022

stuij committed rG7c70f96a917f: [ARM] fix bug causing shrinkwrapping not always being off using PAC (authored by stuij).
[ARM] fix bug causing shrinkwrapping not always being off using PAC
Jan 13 2022, 2:38 AM
stuij closed D116213: [ARM] fix bug causing shrinkwrapping not always being off using PAC.
Jan 13 2022, 2:38 AM · Restricted Project
stuij added a reviewer for D117112: [AArch64] Support for Ampere1 core: stuij.
Jan 13 2022, 2:07 AM · Restricted Project, Restricted Project, Restricted Project
stuij added reviewers for D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM: simon_tatham, vhscampos, keith.walker.arm, philipp.tomsich.
Jan 13 2022, 2:06 AM · Restricted Project, Restricted Project
stuij requested review of D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM.
Jan 13 2022, 1:48 AM · Restricted Project, Restricted Project

Jan 10 2022

stuij updated the diff for D116213: [ARM] fix bug causing shrinkwrapping not always being off using PAC.

I did some more testing, and unfortunately we can't rely on LRSpilled being set correctly.

Jan 10 2022, 1:42 PM · Restricted Project

Jan 7 2022

stuij updated the diff for D116213: [ARM] fix bug causing shrinkwrapping not always being off using PAC.

Yea, good point. I amended the patch.

Jan 7 2022, 7:57 AM · Restricted Project
stuij accepted D116509: [Builtins] Add missing the macro 'y' description in comments.

Nit: perhaps make the commit message a little bit clearer.

Jan 7 2022, 7:37 AM · Restricted Project

Dec 23 2021

stuij added reviewers for D116213: [ARM] fix bug causing shrinkwrapping not always being off using PAC: miyuki, vhscampos.
Dec 23 2021, 1:25 AM · Restricted Project
stuij requested review of D116213: [ARM] fix bug causing shrinkwrapping not always being off using PAC.
Dec 23 2021, 1:23 AM · Restricted Project

Dec 10 2021

stuij committed rGfbf489cd1b4b: Add PACBTI-M support to LLVM release notes. (authored by stuij).
Add PACBTI-M support to LLVM release notes.
Dec 10 2021, 3:54 AM
stuij closed D115507: Add PACBTI-M support to LLVM release notes..
Dec 10 2021, 3:54 AM · Restricted Project, Restricted Project
stuij updated the diff for D115507: Add PACBTI-M support to LLVM release notes..

removed accidentally included Clang release notes draft

Dec 10 2021, 3:38 AM · Restricted Project, Restricted Project
stuij added a reviewer for D115507: Add PACBTI-M support to LLVM release notes.: vhscampos.
Dec 10 2021, 3:36 AM · Restricted Project, Restricted Project
stuij requested review of D115507: Add PACBTI-M support to LLVM release notes..
Dec 10 2021, 3:35 AM · Restricted Project, Restricted Project
stuij committed rG69faae2376c1: [ARM][libcxxabi] Add PACBTI-M support to libcxxabi (authored by stuij).
[ARM][libcxxabi] Add PACBTI-M support to libcxxabi
Dec 10 2021, 1:54 AM
stuij closed D112432: [ARM][libcxxabi] Add PACBTI-M support to libcxxabi.
Dec 10 2021, 1:53 AM · Restricted Project

Dec 9 2021

stuij committed rGbfe07195bb1f: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT (authored by stuij).
[ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT
Dec 9 2021, 5:38 AM
stuij closed D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT.
Dec 9 2021, 5:38 AM · Restricted Project
stuij updated the diff for D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT.

rebasing

Dec 9 2021, 3:22 AM · Restricted Project
stuij committed rGe32b818db187: [ARM][clang] Define feature test macro for the PACBTI-M extension (authored by stuij).
[ARM][clang] Define feature test macro for the PACBTI-M extension
Dec 9 2021, 2:40 AM
stuij closed D112431: [ARM][clang] Define feature test macro for the PACBTI-M extension.
Dec 9 2021, 2:39 AM · Restricted Project

Dec 8 2021

stuij committed rGe6d0b851f854: [ARM][libunwind] add PACBTI-M support for libunwind (authored by stuij).
[ARM][libunwind] add PACBTI-M support for libunwind
Dec 8 2021, 2:05 AM
stuij closed D112430: [ARM][libunwind] add PACBTI-M support for libunwind.
Dec 8 2021, 2:05 AM · Restricted Project, Restricted Project
stuij updated the diff for D112432: [ARM][libcxxabi] Add PACBTI-M support to libcxxabi.

rebased as per review request

Dec 8 2021, 1:10 AM · Restricted Project

Dec 7 2021

stuij added a comment to D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT.

@danielkiss Yes that needs to be addressed, but we are doing that in another patch that will (hopefully) cover all permutations of architecture and branch protection values on both the cmdline and as function attributes.

Dec 7 2021, 9:28 AM · Restricted Project
stuij committed rG63eb7ff47de5: [ARM] Implement PAC return address signing mechanism for PACBTI-M (authored by stuij).
[ARM] Implement PAC return address signing mechanism for PACBTI-M
Dec 7 2021, 2:16 AM
stuij closed D112429: [ARM] Implement PAC return address signing mechanism for PACBTI-M.
Dec 7 2021, 2:16 AM · Restricted Project, Restricted Project
stuij updated the diff for D112429: [ARM] Implement PAC return address signing mechanism for PACBTI-M.

rebasing

Dec 7 2021, 2:12 AM · Restricted Project, Restricted Project

Dec 6 2021

stuij committed rG53154a83aee0: [ARM][clang] Add back branch protection tests (authored by stuij).
[ARM][clang] Add back branch protection tests
Dec 6 2021, 7:23 AM
stuij closed D115141: [ARM][clang] Add back branch protection tests.
Dec 6 2021, 7:23 AM · Restricted Project
stuij added reviewers for D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT: vhscampos, miyuki, danielkiss, olista01.
Dec 6 2021, 4:24 AM · Restricted Project
stuij updated the diff for D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT.

another tickle

Dec 6 2021, 4:17 AM · Restricted Project
stuij updated the diff for D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT.

tickling the commit so the buildbot picks up the dependency

Dec 6 2021, 3:28 AM · Restricted Project
stuij added reviewers for D115141: [ARM][clang] Add back branch protection tests: erichkeane, vhscampos, miyuki.
Dec 6 2021, 3:13 AM · Restricted Project
stuij added a comment to D112421: [clang][ARM] PACBTI-M frontend support.

@erichkeane : thanks so much for going through the trouble to see what the problem is!
I've put up a fix with your suggested change at https://reviews.llvm.org/D115141

Dec 6 2021, 3:12 AM · Restricted Project, Restricted Project
stuij committed rG0fbb17458a01: [ARM] Implement setjmp BTI placement for PACBTI-M (authored by stuij).
[ARM] Implement setjmp BTI placement for PACBTI-M
Dec 6 2021, 3:08 AM
stuij closed D112427: [ARM] Implement setjmp BTI placement for PACBTI-M.
Dec 6 2021, 3:07 AM · Restricted Project, Restricted Project
stuij requested review of D115141: [ARM][clang] Add back branch protection tests.
Dec 6 2021, 2:57 AM · Restricted Project
stuij requested review of D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT.
Dec 6 2021, 2:56 AM · Restricted Project

Dec 1 2021

stuij committed rGf5f28d5b0ce7: [ARM] Implement BTI placement pass for PACBTI-M (authored by stuij).
[ARM] Implement BTI placement pass for PACBTI-M
Dec 1 2021, 4:55 AM
stuij closed D112426: [ARM] Implement BTI placement pass for PACBTI-M.
Dec 1 2021, 4:54 AM · Restricted Project
stuij added a comment to D112421: [clang][ARM] PACBTI-M frontend support.

Yes, pushed a temporary fix.

Dec 1 2021, 4:11 AM · Restricted Project, Restricted Project
stuij committed rG5b4746f94aed: [clang][ARM] removing branch protection error cmdline test (authored by stuij).
[clang][ARM] removing branch protection error cmdline test
Dec 1 2021, 4:10 AM
stuij committed rGb430782be34b: [ARM] emit PACBTI-M build attributes (authored by stuij).
[ARM] emit PACBTI-M build attributes
Dec 1 2021, 3:06 AM
stuij closed D112425: [ARM] emit PACBTI-M build attributes.
Dec 1 2021, 3:05 AM · Restricted Project
stuij committed rGc12c7a84b03b: [ARM] add common parts for PACBTI-M support in the backend (authored by stuij).
[ARM] add common parts for PACBTI-M support in the backend
Dec 1 2021, 2:50 AM
stuij closed D112423: [ARM] add common parts for PACBTI-M support in the backend.
Dec 1 2021, 2:50 AM · Restricted Project
stuij committed rGab2611d0998c: [clang][ARM] emit PACBTI-M feature defines (authored by stuij).
[clang][ARM] emit PACBTI-M feature defines
Dec 1 2021, 2:47 AM
stuij closed D112422: [clang][ARM] emit PACBTI-M feature defines.
Dec 1 2021, 2:47 AM · Restricted Project
stuij committed rGe3b2f0226bc0: [clang][ARM] PACBTI-M frontend support (authored by stuij).
[clang][ARM] PACBTI-M frontend support
Dec 1 2021, 2:38 AM
stuij closed D112421: [clang][ARM] PACBTI-M frontend support.
Dec 1 2021, 2:37 AM · Restricted Project, Restricted Project
stuij updated the diff for D112421: [clang][ARM] PACBTI-M frontend support.

rebased and resolved merge conflict

Dec 1 2021, 2:19 AM · Restricted Project, Restricted Project

Nov 30 2021

stuij updated the diff for D112427: [ARM] Implement setjmp BTI placement for PACBTI-M.

slight rewording

Nov 30 2021, 2:11 AM · Restricted Project, Restricted Project

Nov 29 2021

stuij updated the diff for D112431: [ARM][clang] Define feature test macro for the PACBTI-M extension.

reuploading after rebase to resolve patch apply failure

Nov 29 2021, 6:34 AM · Restricted Project
stuij updated the diff for D112430: [ARM][libunwind] add PACBTI-M support for libunwind.

uploading after rebase as per reviewer request (no changes in the patch itself)

Nov 29 2021, 6:20 AM · Restricted Project, Restricted Project
stuij updated the diff for D112429: [ARM] Implement PAC return address signing mechanism for PACBTI-M.

address review comments

Nov 29 2021, 6:16 AM · Restricted Project, Restricted Project
stuij updated the diff for D112426: [ARM] Implement BTI placement pass for PACBTI-M.

address review comments, and obey clang-format

Nov 29 2021, 6:04 AM · Restricted Project
stuij updated the diff for D112422: [clang][ARM] emit PACBTI-M feature defines.

obeying clang-format

Nov 29 2021, 5:52 AM · Restricted Project
stuij updated the diff for D112421: [clang][ARM] PACBTI-M frontend support.

minor clang-format conformance changes

Nov 29 2021, 5:42 AM · Restricted Project, Restricted Project
stuij updated the diff for D112420: [clang][ARM] PACBTI-M assembly support.

addressed review comment and clang-format suggestions

Nov 29 2021, 5:38 AM · Restricted Project, Restricted Project

Nov 26 2021

stuij updated the diff for D112421: [clang][ARM] PACBTI-M frontend support.

addressed review comments

Nov 26 2021, 5:04 AM · Restricted Project, Restricted Project

Nov 24 2021

stuij updated the summary of D112427: [ARM] Implement setjmp BTI placement for PACBTI-M.
Nov 24 2021, 6:53 AM · Restricted Project, Restricted Project
stuij updated the diff for D112430: [ARM][libunwind] add PACBTI-M support for libunwind.

address review comments

Nov 24 2021, 6:18 AM · Restricted Project, Restricted Project
stuij added reviewers for D112430: [ARM][libunwind] add PACBTI-M support for libunwind: mstorsjo, compnerd.
Nov 24 2021, 1:41 AM · Restricted Project, Restricted Project

Nov 23 2021

stuij updated the diff for D112429: [ARM] Implement PAC return address signing mechanism for PACBTI-M.

Disable shrinkwrapping for now when using PAC. A separate patch will tackle PAC and shrinkwrapping playing nice.

Nov 23 2021, 3:34 AM · Restricted Project, Restricted Project

Nov 22 2021

stuij updated the diff for D112427: [ARM] Implement setjmp BTI placement for PACBTI-M.

addressed review comments, namely adding a commandline argument, -mno-bti-at-return-twice, to not place a bti instruction after a setjmp call.

Nov 22 2021, 5:39 AM · Restricted Project, Restricted Project