User Details
- User Since
- Apr 24 2018, 8:11 AM (257 w, 9 h)
Yesterday
This was breaking for us because can_use_perf_counters() in lit.local.cfg couldn't find llvm-exegesis in the first place.
amend commit message
Tue, Mar 7
FWIW, at Arm we decided to keep the old name mangling to minimise friction with existing code/libraries, but allow more operations with this same name-mangling. We also discussed with Red Hat and they were ok with this.
Mon, Feb 27
LGTM
Jan 26 2023
@tmatheson -^ ?
Jan 25 2023
I meant to mark this as dropped after Tomas' comment, but searching through the codebase I don't see any tests for convert<X>to<Y>. Are those not needed at all anymore, or were they accidentally cut?
Jan 23 2023
rephrasing after review comment
Jan 20 2023
fix typo
Jan 13 2023
Jan 11 2023
Jan 10 2023
I went back and forth on this for a bit. There's a review outstanding to change the mangling name for X86: https://reviews.llvm.org/D136919 to align with the C++23 std::bfloat16_t issue from above. I settled on preferring to be conservative, and not risk at some point accidentally opting an arch into a name that doesn't conform with their ABI.
Jan 9 2023
simplified code some more
Jan 6 2023
addressed review comments
addressed review comment
Jan 5 2023
Thanks for the manual. It uses "b (2)" which resolves my question. Where does "extra range of 2048 bytes" come from?
The maximum range of a BL is 4MB. So of course the max a ThunkSection can be placed from this BL is also 4MB. At this point we could use a short Thunk which for Thumb on v4/5/6 is a maximum of 2048 bytes (our friend b (2). But this seems like an unlikely scenario as the ThunkSection would have to be placed exactly 4MB away from the call site, or at least within 2048 bytes from 4MB away to have any effect.
removed the lambdas as with the other CSSC patches
address review comment
removed lambdas, addressed review comment
Dec 23 2022
Dec 22 2022
unlambdify actions
Dec 21 2022
Dec 20 2022
addressed review comments
Dec 19 2022
flip around .legalIf and .minScalarIf in the action definition builder
addressed review comment
spun out minScalarIf definition into it's own patch
remove changes to select-abs.mir
minor code cleanup
Dec 16 2022
moved HasCSSC further up the file
addressed review comments
Dec 15 2022
LGTM
Dec 14 2022
edit commit message to reflect thunk renaming
change thunk names to agreed upon wording
Dec 13 2022
addressed various review comments
NDS has a v5T and a v4T, not sure what the development story was for it, whether the software used v4T exclusively or the chips were programmed independently.
renamed commit message