Page MenuHomePhabricator

stuij (Ties Stuij)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 24 2018, 8:11 AM (109 w, 12 h)

Recent Activity

Today

stuij retitled D79711: [ARM] Add poly64_t on AArch32. from [ARM][BFloat] Add poly64_t on AArch32. to [ARM] Add poly64_t on AArch32..
Tue, May 26, 4:17 AM · Restricted Project

Yesterday

stuij updated the diff for D79708: [clang][BFloat] add NEON emitter for bfloat.

add bfloat header test

Mon, May 25, 4:37 PM · Restricted Project
stuij updated the diff for D79711: [ARM] Add poly64_t on AArch32..

added testing

Mon, May 25, 3:10 AM · Restricted Project
stuij added inline comments to D76077: [ARM] Add __bf16 as new Bfloat16 C Type.
Mon, May 25, 3:10 AM · Restricted Project
stuij updated the diff for D79708: [clang][BFloat] add NEON emitter for bfloat.

replanted arg passing test from other patch

Mon, May 25, 3:10 AM · Restricted Project
stuij updated the diff for D76077: [ARM] Add __bf16 as new Bfloat16 C Type.

addressed review comments and some related general changes:

  • renamed IsSoftFloatABI -> IsFloatABISoftFP
  • split bfloat tests out of arm-mangle-16bit-float.cpp
  • bfloat shouldn't be checking for NativeHalfType
  • err_cast_(from|to)_bfloat -> err_cast_(from|to)_bfloat16
  • reworded comments and other minor fixes
Mon, May 25, 3:10 AM · Restricted Project

Fri, May 22

stuij updated the diff for D79710: [clang][BFloat] add create/set/get/dup intrinsics.

moving 'CartesianProductWith' to more apt patch

Fri, May 22, 10:10 AM · Restricted Project
stuij updated the diff for D76077: [ARM] Add __bf16 as new Bfloat16 C Type.

no explicit float-abi cmdline arg should default to softfp

Fri, May 22, 9:07 AM · Restricted Project
stuij updated the diff for D79712: [AArch64][BFloat] add BFloat instruction support for AArch64.

making testing more robust as per review comments

Fri, May 22, 9:05 AM · Restricted Project
stuij added a comment to D79712: [AArch64][BFloat] add BFloat instruction support for AArch64.

Thanks Francesco, that was enlightening, and great info to know. I took on all your suggestions, and changed the testing accordingly.

Fri, May 22, 8:34 AM · Restricted Project
stuij added a reviewer for D79706: [CodeGen][BFloat] Add bfloat MVT type: ostannard.
Fri, May 22, 3:36 AM · Restricted Project
stuij updated the summary of D79869: [clang][BFloat] Add reinterpret cast intrinsics.
Fri, May 22, 3:36 AM · Restricted Project
stuij updated the summary of D79710: [clang][BFloat] add create/set/get/dup intrinsics.
Fri, May 22, 3:36 AM · Restricted Project
stuij updated the summary of D79709: [AArch64][BFloat] basic AArch64 bfloat support.
Fri, May 22, 3:36 AM · Restricted Project
stuij updated the summary of D79712: [AArch64][BFloat] add BFloat instruction support for AArch64.
Fri, May 22, 3:36 AM · Restricted Project
stuij updated the summary of D79708: [clang][BFloat] add NEON emitter for bfloat.
Fri, May 22, 3:36 AM · Restricted Project
stuij updated the summary of D79706: [CodeGen][BFloat] Add bfloat MVT type.
Fri, May 22, 3:36 AM · Restricted Project
stuij updated the summary of D79707: [IR][BFloat] add BFloat IR intrinsics support.
Fri, May 22, 3:36 AM · Restricted Project
stuij updated the summary of D76077: [ARM] Add __bf16 as new Bfloat16 C Type.
Fri, May 22, 3:36 AM · Restricted Project

Thu, May 21

stuij added inline comments to D79708: [clang][BFloat] add NEON emitter for bfloat.
Thu, May 21, 10:15 AM · Restricted Project
stuij updated the diff for D79708: [clang][BFloat] add NEON emitter for bfloat.

addressed review comments, most of all changed license header on the generated bfloat file

Thu, May 21, 9:41 AM · Restricted Project
stuij added inline comments to D79708: [clang][BFloat] add NEON emitter for bfloat.
Thu, May 21, 9:09 AM · Restricted Project
stuij added a comment to D79710: [clang][BFloat] add create/set/get/dup intrinsics.

Can you update the commit message in this differential as well please? Same for the other commits :)

Thu, May 21, 5:22 AM · Restricted Project
stuij updated the diff for D79712: [AArch64][BFloat] add BFloat instruction support for AArch64.

added testcases, following fp16's lead

Thu, May 21, 5:22 AM · Restricted Project
stuij added a comment to D79709: [AArch64][BFloat] basic AArch64 bfloat support.

Hiya Francesco, thanks for the thorough comment :)

Thu, May 21, 2:08 AM · Restricted Project

Wed, May 20

stuij added inline comments to D79710: [clang][BFloat] add create/set/get/dup intrinsics.
Wed, May 20, 10:22 AM · Restricted Project
stuij added a comment to D79709: [AArch64][BFloat] basic AArch64 bfloat support.

Note that these argument passing tests discussed above aren't present in the follow-up patch at the moment. I'm currently implementing them.

Wed, May 20, 8:10 AM · Restricted Project
stuij added a comment to D79709: [AArch64][BFloat] basic AArch64 bfloat support.

Having a think, I think the calling convention test would be more meaningful if we have a bit more bfloat lowering support. Which we have in the bfloat lowering follow-up patch: https://reviews.llvm.org/D79712

Wed, May 20, 7:37 AM · Restricted Project
stuij updated the summary of D79711: [ARM] Add poly64_t on AArch32..
Wed, May 20, 4:18 AM · Restricted Project
stuij updated the summary of D76077: [ARM] Add __bf16 as new Bfloat16 C Type.
Wed, May 20, 4:18 AM · Restricted Project
stuij updated the summary of D79708: [clang][BFloat] add NEON emitter for bfloat.
Wed, May 20, 3:46 AM · Restricted Project
stuij updated the summary of D79869: [clang][BFloat] Add reinterpret cast intrinsics.
Wed, May 20, 3:45 AM · Restricted Project
stuij updated the summary of D79710: [clang][BFloat] add create/set/get/dup intrinsics.
Wed, May 20, 3:45 AM · Restricted Project

Mon, May 18

stuij added inline comments to D76077: [ARM] Add __bf16 as new Bfloat16 C Type.
Mon, May 18, 8:34 AM · Restricted Project
stuij updated the diff for D79869: [clang][BFloat] Add reinterpret cast intrinsics.

adhere to attribution conventions: change author to Ties, add all the contributors

Mon, May 18, 5:19 AM · Restricted Project
stuij updated the diff for D79710: [clang][BFloat] add create/set/get/dup intrinsics.

adhere to patch attribution conventions: change author to Ties, add all the contributors

Mon, May 18, 4:47 AM · Restricted Project
stuij updated the diff for D79711: [ARM] Add poly64_t on AArch32..

adhere to attribution conventions

Mon, May 18, 4:47 AM · Restricted Project
stuij updated the diff for D79708: [clang][BFloat] add NEON emitter for bfloat.

adhere to patch attribution conventions

Mon, May 18, 4:47 AM · Restricted Project
stuij updated the diff for D79707: [IR][BFloat] add BFloat IR intrinsics support.

added bfloat SVE MVT type

Mon, May 18, 4:47 AM · Restricted Project
stuij updated the diff for D79706: [CodeGen][BFloat] Add bfloat MVT type.

fix bug that failed webassembly test

Mon, May 18, 4:47 AM · Restricted Project
stuij updated the diff for D76077: [ARM] Add __bf16 as new Bfloat16 C Type.

redo: addressing review comments and adding Simon Tatham to contributers

Mon, May 18, 2:05 AM · Restricted Project
stuij updated the diff for D76077: [ARM] Add __bf16 as new Bfloat16 C Type.

addressing review comments and adding Simon Tatham to contributers

Mon, May 18, 2:05 AM · Restricted Project

Sat, May 16

stuij added a comment to D76077: [ARM] Add __bf16 as new Bfloat16 C Type.

@LukeGeeson: you're already mentioned :) See the commits tab on this review. But Simon Tatham needs a mention as well. I shall add him.

Sat, May 16, 4:57 PM · Restricted Project
stuij added a comment to D79709: [AArch64][BFloat] basic AArch64 bfloat support.

@fpetrogalli: Yes, good point. It was on my todo. I had tested these changes with such a snippet, so there's no good reason I didn't add it in the first place.

Sat, May 16, 2:17 PM · Restricted Project

Fri, May 15

stuij committed rG8c24f33158d8: [IR][BFloat] Add BFloat IR type (authored by stuij).
[IR][BFloat] Add BFloat IR type
Fri, May 15, 7:01 AM
stuij closed D78190: Add Bfloat IR type.
Fri, May 15, 7:01 AM · Restricted Project, Restricted Project

Wed, May 13

stuij added a parent revision for D79869: [clang][BFloat] Add reinterpret cast intrinsics: D79710: [clang][BFloat] add create/set/get/dup intrinsics.
Wed, May 13, 9:10 AM · Restricted Project
stuij added a child revision for D79710: [clang][BFloat] add create/set/get/dup intrinsics: D79869: [clang][BFloat] Add reinterpret cast intrinsics.
Wed, May 13, 9:10 AM · Restricted Project
stuij added reviewers for D79869: [clang][BFloat] Add reinterpret cast intrinsics: t.p.northover, LukeGeeson, fpetrogalli, sdesmalen, momchil.velikov.
Wed, May 13, 9:10 AM · Restricted Project
stuij retitled D79869: [clang][BFloat] Add reinterpret cast intrinsics from [clangd][BFloat] Add reinterpret cast intrinsics to [clang][BFloat] Add reinterpret cast intrinsics.
Wed, May 13, 8:39 AM · Restricted Project
stuij created D79869: [clang][BFloat] Add reinterpret cast intrinsics.
Wed, May 13, 8:38 AM · Restricted Project
stuij updated the diff for D79712: [AArch64][BFloat] add BFloat instruction support for AArch64.

fix bug in ReplaceBITCASTResults

Wed, May 13, 8:37 AM · Restricted Project
stuij updated the diff for D76077: [ARM] Add __bf16 as new Bfloat16 C Type.

changes:

  • addressed asmith's comments
  • Bfloat doesn't depend on half cmdline options and correct code is generation for AArch32 hard and softfp CC
Wed, May 13, 8:05 AM · Restricted Project
stuij added a comment to D79712: [AArch64][BFloat] add BFloat instruction support for AArch64.

Could you add some tests (unless they're added in a later patch)?

Wed, May 13, 6:59 AM · Restricted Project
stuij added a comment to D76077: [ARM] Add __bf16 as new Bfloat16 C Type.

@asmith: Thanks for reviewing :) Fixed your suggestions in the coming revision.

Wed, May 13, 6:27 AM · Restricted Project

Mon, May 11

stuij added a reviewer for D79709: [AArch64][BFloat] basic AArch64 bfloat support: ab.
Mon, May 11, 6:56 AM · Restricted Project
stuij added reviewers for D79710: [clang][BFloat] add create/set/get/dup intrinsics: t.p.northover, sdesmalen, fpetrogalli, LukeGeeson.
Mon, May 11, 6:56 AM · Restricted Project
stuij added reviewers for D79712: [AArch64][BFloat] add BFloat instruction support for AArch64: ab, t.p.northover, john.brawn, fpetrogalli, sdesmalen, LukeGeeson.
Mon, May 11, 6:56 AM · Restricted Project
stuij added a reviewer for D79709: [AArch64][BFloat] basic AArch64 bfloat support: LukeGeeson.
Mon, May 11, 6:24 AM · Restricted Project
stuij added a reviewer for D79708: [clang][BFloat] add NEON emitter for bfloat: LukeGeeson.
Mon, May 11, 6:24 AM · Restricted Project
stuij added a reviewer for D79711: [ARM] Add poly64_t on AArch32.: LukeGeeson.
Mon, May 11, 6:24 AM · Restricted Project
stuij added a reviewer for D79707: [IR][BFloat] add BFloat IR intrinsics support: LukeGeeson.
Mon, May 11, 6:24 AM · Restricted Project
stuij added a reviewer for D79706: [CodeGen][BFloat] Add bfloat MVT type: LukeGeeson.
Mon, May 11, 6:24 AM · Restricted Project
stuij added reviewers for D79709: [AArch64][BFloat] basic AArch64 bfloat support: t.p.northover, c-rhodes, fpetrogalli, sdesmalen, ostannard.
Mon, May 11, 6:24 AM · Restricted Project
stuij added reviewers for D79708: [clang][BFloat] add NEON emitter for bfloat: t.p.northover, fpetrogalli, sdesmalen, az.
Mon, May 11, 5:52 AM · Restricted Project
stuij added reviewers for D79711: [ARM] Add poly64_t on AArch32.: ostannard, sdesmalen, fpetrogalli, labrinea, t.p.northover.
Mon, May 11, 5:52 AM · Restricted Project
stuij added reviewers for D79707: [IR][BFloat] add BFloat IR intrinsics support: scanon, fpetrogalli, sdesmalen, craig.topper.
Mon, May 11, 5:52 AM · Restricted Project
stuij added reviewers for D79706: [CodeGen][BFloat] Add bfloat MVT type: aemerson, huntergr, craig.topper, fpetrogalli, sdesmalen.
Mon, May 11, 5:19 AM · Restricted Project
stuij added a parent revision for D79710: [clang][BFloat] add create/set/get/dup intrinsics: D79712: [AArch64][BFloat] add BFloat instruction support for AArch64.
Mon, May 11, 5:19 AM · Restricted Project
stuij added a child revision for D79712: [AArch64][BFloat] add BFloat instruction support for AArch64: D79710: [clang][BFloat] add create/set/get/dup intrinsics.
Mon, May 11, 5:19 AM · Restricted Project
stuij added a child revision for D79709: [AArch64][BFloat] basic AArch64 bfloat support: D79712: [AArch64][BFloat] add BFloat instruction support for AArch64.
Mon, May 11, 5:19 AM · Restricted Project
stuij added a parent revision for D79712: [AArch64][BFloat] add BFloat instruction support for AArch64: D79709: [AArch64][BFloat] basic AArch64 bfloat support.
Mon, May 11, 5:19 AM · Restricted Project
stuij created D79712: [AArch64][BFloat] add BFloat instruction support for AArch64.
Mon, May 11, 5:19 AM · Restricted Project
stuij created D79711: [ARM] Add poly64_t on AArch32..
Mon, May 11, 4:47 AM · Restricted Project
stuij edited parent revisions for D79708: [clang][BFloat] add NEON emitter for bfloat, added: 1; removed: 1.
Mon, May 11, 4:47 AM · Restricted Project
stuij removed a child revision for D76077: [ARM] Add __bf16 as new Bfloat16 C Type: D79708: [clang][BFloat] add NEON emitter for bfloat.
Mon, May 11, 4:47 AM · Restricted Project
stuij added a child revision for D79711: [ARM] Add poly64_t on AArch32.: D79708: [clang][BFloat] add NEON emitter for bfloat.
Mon, May 11, 4:47 AM · Restricted Project
stuij added a child revision for D76077: [ARM] Add __bf16 as new Bfloat16 C Type: D79711: [ARM] Add poly64_t on AArch32..
Mon, May 11, 4:47 AM · Restricted Project
stuij added a parent revision for D79711: [ARM] Add poly64_t on AArch32.: D76077: [ARM] Add __bf16 as new Bfloat16 C Type.
Mon, May 11, 4:47 AM · Restricted Project
stuij created D79710: [clang][BFloat] add create/set/get/dup intrinsics.
Mon, May 11, 4:47 AM · Restricted Project
stuij added a child revision for D79706: [CodeGen][BFloat] Add bfloat MVT type: D79709: [AArch64][BFloat] basic AArch64 bfloat support.
Mon, May 11, 4:47 AM · Restricted Project
stuij added a parent revision for D79708: [clang][BFloat] add NEON emitter for bfloat: D76077: [ARM] Add __bf16 as new Bfloat16 C Type.
Mon, May 11, 4:47 AM · Restricted Project
stuij created D79709: [AArch64][BFloat] basic AArch64 bfloat support.
Mon, May 11, 4:47 AM · Restricted Project
stuij added a parent revision for D79709: [AArch64][BFloat] basic AArch64 bfloat support: D79706: [CodeGen][BFloat] Add bfloat MVT type.
Mon, May 11, 4:47 AM · Restricted Project
stuij added a child revision for D76077: [ARM] Add __bf16 as new Bfloat16 C Type: D79708: [clang][BFloat] add NEON emitter for bfloat.
Mon, May 11, 4:47 AM · Restricted Project
stuij created D79708: [clang][BFloat] add NEON emitter for bfloat.
Mon, May 11, 4:47 AM · Restricted Project
stuij created D79707: [IR][BFloat] add BFloat IR intrinsics support.
Mon, May 11, 4:47 AM · Restricted Project
stuij added a parent revision for D79707: [IR][BFloat] add BFloat IR intrinsics support: D78190: Add Bfloat IR type.
Mon, May 11, 4:47 AM · Restricted Project
stuij added a child revision for D78190: Add Bfloat IR type: D79707: [IR][BFloat] add BFloat IR intrinsics support.
Mon, May 11, 4:47 AM · Restricted Project, Restricted Project
stuij added a parent revision for D79706: [CodeGen][BFloat] Add bfloat MVT type: D78190: Add Bfloat IR type.
Mon, May 11, 4:47 AM · Restricted Project
stuij created D79706: [CodeGen][BFloat] Add bfloat MVT type.
Mon, May 11, 4:47 AM · Restricted Project
stuij added a child revision for D78190: Add Bfloat IR type: D79706: [CodeGen][BFloat] Add bfloat MVT type.
Mon, May 11, 4:47 AM · Restricted Project, Restricted Project
stuij added a comment to D78190: Add Bfloat IR type.

Hi there, a gentle ping: does this look good to you?

Mon, May 11, 3:10 AM · Restricted Project, Restricted Project

Tue, May 5

stuij added a comment to D78190: Add Bfloat IR type.

So are we happy with the patch as it is? Anybody else wants to LGTM?

Tue, May 5, 10:14 AM · Restricted Project, Restricted Project
stuij added a comment to D78190: Add Bfloat IR type.
  1. Do you need those changes in the Hexagon and x86 backend? Could they be submitted separately, with some testing?

This is a backend agnostic patch. If the Hexagon and/or x86 communities want to make use of the IR type in some way, then yes, they can for sure submit the necessary patches.

Tue, May 5, 10:14 AM · Restricted Project, Restricted Project
stuij added a comment to D78190: Add Bfloat IR type.
  1. Shouldn't we test also that the parser is happy with the following expressions?
Tue, May 5, 9:42 AM · Restricted Project, Restricted Project
stuij updated the diff for D78190: Add Bfloat IR type.

added vector tests

Tue, May 5, 8:36 AM · Restricted Project, Restricted Project

Mon, May 4

stuij added a reviewer for D76077: [ARM] Add __bf16 as new Bfloat16 C Type: fpetrogalli.
Mon, May 4, 10:43 AM · Restricted Project
stuij added a reviewer for D78190: Add Bfloat IR type: fpetrogalli.
Mon, May 4, 10:43 AM · Restricted Project, Restricted Project
stuij added a comment to D78190: Add Bfloat IR type.

Hi all. Are you OK for me to commit this change?

Mon, May 4, 10:09 AM · Restricted Project, Restricted Project