Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.cpp | ||
---|---|---|
94 | First, second, third (from previous) | |
572 | You use s and non-s forms (Skip, Generates, Finds) Typically, we use s form in top comment, and non-s form in code doc | |
mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.h | ||
185 | user's or users' | |
mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp | ||
1070 | is the attr test needed since already done in if? in that case, can you just break out first and second if for readability? | |
1071 | // break on either on same line as break (preferred) or otherwise in right style // Break on ... . | |
mlir/test/Dialect/SparseTensor/sparse_1d.mlir | ||
1302–1303 | should we make the load a CHECK-DAG if order may change (often) over time? | |
mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_matmul_slice.mlir | ||
48 | commend needs refining on format | |
60 | in DCSR is no longer valid in the comment |
address comments.
mlir/test/Dialect/SparseTensor/sparse_1d.mlir | ||
---|---|---|
1302–1303 | Yeah, good idea |
address comment.
mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp | ||
---|---|---|
1071 | Yeah, you are right! no need to test attr != nullptr as they are pointer comparison afterall! |
user's or users'