Page MenuHomePhabricator

bixia (Bixia Zheng)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 17 2017, 12:00 PM (279 w, 6 d)

Recent Activity

Today

bixia committed rG6071f6fd67aa: [mlir][sparse] Fix a problem in handling data type conversion. (authored by bixia).
[mlir][sparse] Fix a problem in handling data type conversion.
Thu, Mar 30, 2:55 PM · Restricted Project, Restricted Project
bixia closed D147272: [mlir][sparse] Fix a problem in handling data type conversion..
Thu, Mar 30, 2:55 PM · Restricted Project, Restricted Project
bixia added inline comments to D147011: [mlir][sparse] Replace Element with ElementId for sorting..
Thu, Mar 30, 2:49 PM · Restricted Project, Restricted Project
bixia updated the diff for D147011: [mlir][sparse] Replace Element with ElementId for sorting..

Add definitions for iterator trait.

Thu, Mar 30, 2:49 PM · Restricted Project, Restricted Project
bixia updated the summary of D147272: [mlir][sparse] Fix a problem in handling data type conversion..
Thu, Mar 30, 2:04 PM · Restricted Project, Restricted Project
bixia requested review of D147272: [mlir][sparse] Fix a problem in handling data type conversion..
Thu, Mar 30, 1:59 PM · Restricted Project, Restricted Project
bixia added inline comments to D147011: [mlir][sparse] Replace Element with ElementId for sorting..
Thu, Mar 30, 9:37 AM · Restricted Project, Restricted Project
bixia updated the diff for D147011: [mlir][sparse] Replace Element with ElementId for sorting..

Address review comments.

Thu, Mar 30, 9:31 AM · Restricted Project, Restricted Project

Yesterday

bixia updated the diff for D147011: [mlir][sparse] Replace Element with ElementId for sorting..

Replace typedef ElementId with a struct and simplify getValueForId/getCoordsforId with getValue/getCoords.

Wed, Mar 29, 12:31 PM · Restricted Project, Restricted Project
bixia added a comment to D147011: [mlir][sparse] Replace Element with ElementId for sorting..

Nit: in the CL summary it should be "Previously, we represented a"

Wed, Mar 29, 12:07 PM · Restricted Project, Restricted Project
bixia updated the diff for D147011: [mlir][sparse] Replace Element with ElementId for sorting..

Address review comments.

Wed, Mar 29, 12:07 PM · Restricted Project, Restricted Project
bixia updated the summary of D147011: [mlir][sparse] Replace Element with ElementId for sorting..
Wed, Mar 29, 7:41 AM · Restricted Project, Restricted Project

Mon, Mar 27

bixia added a reviewer for D147011: [mlir][sparse] Replace Element with ElementId for sorting.: wrengr.
Mon, Mar 27, 4:13 PM · Restricted Project, Restricted Project
bixia requested review of D147011: [mlir][sparse] Replace Element with ElementId for sorting..
Mon, Mar 27, 4:12 PM · Restricted Project, Restricted Project

Thu, Mar 16

bixia accepted D146074: [mlir][sparse] add test cases for sparse tensor slices on COO tensors.
Thu, Mar 16, 9:24 AM · Restricted Project, Restricted Project

Wed, Mar 15

bixia committed rGabb05014f904: [mlir][sparse] Modify the pivot selection method for quick sort. (authored by bixia).
[mlir][sparse] Modify the pivot selection method for quick sort.
Wed, Mar 15, 1:53 PM · Restricted Project, Restricted Project
bixia closed D145534: [mlir][sparse] Modify the pivot selection method for quick sort..
Wed, Mar 15, 1:53 PM · Restricted Project, Restricted Project
bixia updated the diff for D145534: [mlir][sparse] Modify the pivot selection method for quick sort..

Fix a comment.

Wed, Mar 15, 9:44 AM · Restricted Project, Restricted Project

Tue, Mar 14

bixia updated the diff for D145534: [mlir][sparse] Modify the pivot selection method for quick sort..

Fixed comment. Rebased. Fixed FileCheck test.

Tue, Mar 14, 4:17 PM · Restricted Project, Restricted Project
bixia committed rG2ef416273f85: [mlir][sparse] Improve sort operation by generating inlined code to compare… (authored by bixia).
[mlir][sparse] Improve sort operation by generating inlined code to compare…
Tue, Mar 14, 3:15 PM · Restricted Project, Restricted Project
bixia closed D145442: [mlir][sparse] Improve sort operation by generating inlined code to compare values..
Tue, Mar 14, 3:15 PM · Restricted Project, Restricted Project

Fri, Mar 10

bixia updated the diff for D145442: [mlir][sparse] Improve sort operation by generating inlined code to compare values..

Rebase.

Fri, Mar 10, 8:44 PM · Restricted Project, Restricted Project
bixia committed rGf6424d11cb3f: [mlir][sparse] Improve quick sort by using a loop to sort the bigger partition. (authored by bixia).
[mlir][sparse] Improve quick sort by using a loop to sort the bigger partition.
Fri, Mar 10, 8:43 PM · Restricted Project, Restricted Project
bixia closed D145440: [mlir][sparse] Improve quick sort by using a loop to sort the bigger partition..
Fri, Mar 10, 8:43 PM · Restricted Project, Restricted Project

Thu, Mar 9

bixia retitled D145442: [mlir][sparse] Improve sort operation by generating inlined code to compare values. from [mlir][sparse] Modify the compare functions to use less if-stmts. to [mlir][sparse] Improve sort operation by generating inlined code to compare values..
Thu, Mar 9, 9:39 AM · Restricted Project, Restricted Project
bixia updated the diff for D145442: [mlir][sparse] Improve sort operation by generating inlined code to compare values..

Generate inlined code to compare values.

Thu, Mar 9, 9:38 AM · Restricted Project, Restricted Project

Wed, Mar 8

bixia updated the diff for D145440: [mlir][sparse] Improve quick sort by using a loop to sort the bigger partition..

Add more detail CHECK to FileCheck test.

Wed, Mar 8, 6:57 AM · Restricted Project, Restricted Project

Tue, Mar 7

bixia added a comment to D145440: [mlir][sparse] Improve quick sort by using a loop to sort the bigger partition..

any perf results?

Tue, Mar 7, 5:50 PM · Restricted Project, Restricted Project
bixia requested review of D145534: [mlir][sparse] Modify the pivot selection method for quick sort..
Tue, Mar 7, 5:46 PM · Restricted Project, Restricted Project

Mon, Mar 6

bixia requested review of D145442: [mlir][sparse] Improve sort operation by generating inlined code to compare values..
Mon, Mar 6, 3:24 PM · Restricted Project, Restricted Project
bixia requested review of D145440: [mlir][sparse] Improve quick sort by using a loop to sort the bigger partition..
Mon, Mar 6, 3:22 PM · Restricted Project, Restricted Project

Thu, Mar 2

bixia added a comment to D144804: [mlir][AsmParser] Improve parse{Attribute,Type} error handling.

The input contains the "meaningfule string for string attr" and followed by comment lines. Do you know why the parser stop in the middle of a comment line?

Thu, Mar 2, 10:38 AM · Restricted Project, Restricted Project

Wed, Mar 1

bixia added a comment to D144804: [mlir][AsmParser] Improve parse{Attribute,Type} error handling.

This change breaks tensorflow test github.com/tensorflow/tensorflow/blob/master/tensorflow/compiler/mlir/tensorflow/tests/compile_mlir_util/mlir-module-serialized-str-attr.mlir

Wed, Mar 1, 4:16 PM · Restricted Project, Restricted Project
bixia committed rG2c81d43241f7: [mlir][sparse] Improve the implementation of sparse_tensor.new for the codegen… (authored by bixia).
[mlir][sparse] Improve the implementation of sparse_tensor.new for the codegen…
Wed, Mar 1, 7:30 AM · Restricted Project, Restricted Project
bixia closed D144504: [mlir][sparse] Improve the implementation of sparse_tensor.new for the codegen path..
Wed, Mar 1, 7:29 AM · Restricted Project, Restricted Project

Feb 28 2023

bixia updated the diff for D144504: [mlir][sparse] Improve the implementation of sparse_tensor.new for the codegen path..

Fix codegen.mlir

Feb 28 2023, 12:53 PM · Restricted Project, Restricted Project
bixia updated the diff for D144504: [mlir][sparse] Improve the implementation of sparse_tensor.new for the codegen path..

Rebase.

Feb 28 2023, 8:38 AM · Restricted Project, Restricted Project
bixia committed rG27ea470f22ab: [mlir][sparse] Add runtime support for reading a COO tensor and writing the… (authored by bixia).
[mlir][sparse] Add runtime support for reading a COO tensor and writing the…
Feb 28 2023, 8:29 AM · Restricted Project, Restricted Project
bixia closed D143862: [mlir][sparse] Add runtime support for reading a COO tensor and writing the data to the given indices and values buffers..
Feb 28 2023, 8:28 AM · Restricted Project, Restricted Project
bixia updated the diff for D143862: [mlir][sparse] Add runtime support for reading a COO tensor and writing the data to the given indices and values buffers..

Fix comment.

Feb 28 2023, 7:46 AM · Restricted Project, Restricted Project

Feb 27 2023

bixia added inline comments to D143862: [mlir][sparse] Add runtime support for reading a COO tensor and writing the data to the given indices and values buffers..
Feb 27 2023, 12:57 PM · Restricted Project, Restricted Project

Feb 26 2023

bixia updated the diff for D143862: [mlir][sparse] Add runtime support for reading a COO tensor and writing the data to the given indices and values buffers..

Address review comments: use ASSERT_USIZE_EQ, rename dimRank to lvlRank, fix comments.

Feb 26 2023, 7:54 PM · Restricted Project, Restricted Project

Feb 24 2023

bixia added inline comments to D143862: [mlir][sparse] Add runtime support for reading a COO tensor and writing the data to the given indices and values buffers..
Feb 24 2023, 8:32 AM · Restricted Project, Restricted Project
bixia updated the diff for D143862: [mlir][sparse] Add runtime support for reading a COO tensor and writing the data to the given indices and values buffers..

Rename d->l, dimInd->dimCoords, prevlvlCoordinates->prevLvlCoords.

Feb 24 2023, 8:32 AM · Restricted Project, Restricted Project

Feb 23 2023

bixia added inline comments to D143862: [mlir][sparse] Add runtime support for reading a COO tensor and writing the data to the given indices and values buffers..
Feb 23 2023, 4:28 PM · Restricted Project, Restricted Project
bixia updated the diff for D143862: [mlir][sparse] Add runtime support for reading a COO tensor and writing the data to the given indices and values buffers..

Rename I to C, indices to coordinates.

Feb 23 2023, 4:27 PM · Restricted Project, Restricted Project
bixia updated the diff for D143862: [mlir][sparse] Add runtime support for reading a COO tensor and writing the data to the given indices and values buffers..

Rename indices to lvlCoordinates, add assert(lvlRank == dimRank && "Rank mismatch").

Feb 23 2023, 4:15 PM · Restricted Project, Restricted Project
bixia updated the diff for D143862: [mlir][sparse] Add runtime support for reading a COO tensor and writing the data to the given indices and values buffers..

Remove IsSymmetric in comment.

Feb 23 2023, 3:42 PM · Restricted Project, Restricted Project
bixia updated the diff for D143862: [mlir][sparse] Add runtime support for reading a COO tensor and writing the data to the given indices and values buffers..

Split a macro into variadic version and non-variadic version to avoid warnings.

Feb 23 2023, 9:31 AM · Restricted Project, Restricted Project

Feb 22 2023

bixia added inline comments to D144504: [mlir][sparse] Improve the implementation of sparse_tensor.new for the codegen path..
Feb 22 2023, 9:05 AM · Restricted Project, Restricted Project
bixia updated the diff for D144504: [mlir][sparse] Improve the implementation of sparse_tensor.new for the codegen path..

Address review comments.

Feb 22 2023, 9:04 AM · Restricted Project, Restricted Project
bixia updated the diff for D143862: [mlir][sparse] Add runtime support for reading a COO tensor and writing the data to the given indices and values buffers..

Avoid writing isSorted with the same value. Add comments to the code.

Feb 22 2023, 8:28 AM · Restricted Project, Restricted Project

Feb 21 2023

bixia added reviewers for D144504: [mlir][sparse] Improve the implementation of sparse_tensor.new for the codegen path.: Peiming, wrengr.
Feb 21 2023, 9:33 AM · Restricted Project, Restricted Project
bixia requested review of D144504: [mlir][sparse] Improve the implementation of sparse_tensor.new for the codegen path..
Feb 21 2023, 9:27 AM · Restricted Project, Restricted Project

Feb 20 2023

bixia updated the diff for D143862: [mlir][sparse] Add runtime support for reading a COO tensor and writing the data to the given indices and values buffers..

Trying to fix the build.

Feb 20 2023, 7:12 AM · Restricted Project, Restricted Project

Feb 17 2023

bixia added inline comments to D143862: [mlir][sparse] Add runtime support for reading a COO tensor and writing the data to the given indices and values buffers..
Feb 17 2023, 3:56 PM · Restricted Project, Restricted Project
bixia updated the diff for D143862: [mlir][sparse] Add runtime support for reading a COO tensor and writing the data to the given indices and values buffers..

Reorder parameters. Rename local nnz to nse. Combines two lambdas.

Feb 17 2023, 3:56 PM · Restricted Project, Restricted Project

Feb 16 2023

bixia added inline comments to D143862: [mlir][sparse] Add runtime support for reading a COO tensor and writing the data to the given indices and values buffers..
Feb 16 2023, 2:29 PM · Restricted Project, Restricted Project
bixia updated the diff for D143862: [mlir][sparse] Add runtime support for reading a COO tensor and writing the data to the given indices and values buffers..

Update after removing expand_symmetry property. Rename nnz to nse.

Feb 16 2023, 2:29 PM · Restricted Project, Restricted Project
bixia abandoned D143863: [mlir][sparse] Add sparse_tensor.specifier and sparse_tensor.set_specifier..
Feb 16 2023, 1:22 PM · Restricted Project, Restricted Project
bixia committed rGc2e248c6aea6: [mlir][sparse] Remove the expansion of symmetric MTX in the sparse tensor… (authored by bixia).
[mlir][sparse] Remove the expansion of symmetric MTX in the sparse tensor…
Feb 16 2023, 1:02 PM · Restricted Project, Restricted Project
bixia closed D144059: [mlir][sparse] Remove the expansion of symmetric MTX in the sparse tensor storage..
Feb 16 2023, 1:02 PM · Restricted Project, Restricted Project
bixia updated the diff for D144059: [mlir][sparse] Remove the expansion of symmetric MTX in the sparse tensor storage..

Fix doc for symmetry. Fix assembly format.

Feb 16 2023, 9:54 AM · Restricted Project, Restricted Project

Feb 15 2023

bixia updated the diff for D144059: [mlir][sparse] Remove the expansion of symmetric MTX in the sparse tensor storage..

Address review comment: keep symmetric property, keep two tests with symmetric input with TODO, add to doc about symmetric handling is TBD.

Feb 15 2023, 11:49 AM · Restricted Project, Restricted Project

Feb 14 2023

bixia requested review of D144059: [mlir][sparse] Remove the expansion of symmetric MTX in the sparse tensor storage..
Feb 14 2023, 4:39 PM · Restricted Project, Restricted Project

Feb 13 2023

bixia added inline comments to D143862: [mlir][sparse] Add runtime support for reading a COO tensor and writing the data to the given indices and values buffers..
Feb 13 2023, 4:11 PM · Restricted Project, Restricted Project
bixia updated the diff for D143862: [mlir][sparse] Add runtime support for reading a COO tensor and writing the data to the given indices and values buffers..

Address review comments.

Feb 13 2023, 4:11 PM · Restricted Project, Restricted Project
bixia committed rGe800c664f0e9: [mlir][sparse] Extend readCOOIndices to support overhead types beyond… (authored by bixia).
[mlir][sparse] Extend readCOOIndices to support overhead types beyond…
Feb 13 2023, 2:52 PM · Restricted Project, Restricted Project
bixia closed D143861: [mlir][sparse] Extend readCOOIndices to support overhead types beyond index_type..
Feb 13 2023, 2:52 PM · Restricted Project, Restricted Project
bixia updated the diff for D143861: [mlir][sparse] Extend readCOOIndices to support overhead types beyond index_type..

Rename variables, rank => dimRank, r => d.

Feb 13 2023, 12:43 PM · Restricted Project, Restricted Project
bixia updated the diff for D143861: [mlir][sparse] Extend readCOOIndices to support overhead types beyond index_type..

Apply clang-format.

Feb 13 2023, 8:01 AM · Restricted Project, Restricted Project

Feb 12 2023

bixia added reviewers for D143863: [mlir][sparse] Add sparse_tensor.specifier and sparse_tensor.set_specifier.: Peiming, wrengr.
Feb 12 2023, 2:31 PM · Restricted Project, Restricted Project
bixia added reviewers for D143862: [mlir][sparse] Add runtime support for reading a COO tensor and writing the data to the given indices and values buffers.: Peiming, wrengr.
Feb 12 2023, 2:30 PM · Restricted Project, Restricted Project
bixia added reviewers for D143861: [mlir][sparse] Extend readCOOIndices to support overhead types beyond index_type.: Peiming, wrengr.
Feb 12 2023, 2:29 PM · Restricted Project, Restricted Project
bixia requested review of D143863: [mlir][sparse] Add sparse_tensor.specifier and sparse_tensor.set_specifier..
Feb 12 2023, 2:24 PM · Restricted Project, Restricted Project
bixia requested review of D143862: [mlir][sparse] Add runtime support for reading a COO tensor and writing the data to the given indices and values buffers..
Feb 12 2023, 2:23 PM · Restricted Project, Restricted Project
bixia requested review of D143861: [mlir][sparse] Extend readCOOIndices to support overhead types beyond index_type..
Feb 12 2023, 2:23 PM · Restricted Project, Restricted Project

Feb 8 2023

bixia committed rGa1507668807e: [mlir][sparse] Implement hybrid quick sort for sparse_tensor.sort. (authored by bixia).
[mlir][sparse] Implement hybrid quick sort for sparse_tensor.sort.
Feb 8 2023, 2:07 PM · Restricted Project, Restricted Project
bixia closed D143227: [mlir][sparse] Implement hybrid quick sort for sparse_tensor.sort..
Feb 8 2023, 2:06 PM · Restricted Project, Restricted Project
bixia added inline comments to D143227: [mlir][sparse] Implement hybrid quick sort for sparse_tensor.sort..
Feb 8 2023, 9:12 AM · Restricted Project, Restricted Project
bixia updated the diff for D143227: [mlir][sparse] Implement hybrid quick sort for sparse_tensor.sort..

Change _sparse_quick_sort to _sparse_qsort. Rebase.

Feb 8 2023, 9:05 AM · Restricted Project, Restricted Project

Feb 6 2023

bixia accepted D143309: [mlir][sparse] compute allocation size_hint.
Feb 6 2023, 1:33 PM · Restricted Project, Restricted Project
bixia added inline comments to D143230: [mlir][sparse] implement lowering rules for sparse_tensor.pack operation.
Feb 6 2023, 9:21 AM · Restricted Project, Restricted Project
bixia added inline comments to D143230: [mlir][sparse] implement lowering rules for sparse_tensor.pack operation.
Feb 6 2023, 9:15 AM · Restricted Project, Restricted Project

Feb 3 2023

bixia accepted D143292: [mlir][sparse] start using size_hint provided in allocation op.
Feb 3 2023, 1:45 PM · Restricted Project, Restricted Project

Feb 2 2023

bixia added reviewers for D143227: [mlir][sparse] Implement hybrid quick sort for sparse_tensor.sort.: Peiming, wrengr.
Feb 2 2023, 3:57 PM · Restricted Project, Restricted Project
bixia requested review of D143227: [mlir][sparse] Implement hybrid quick sort for sparse_tensor.sort..
Feb 2 2023, 3:57 PM · Restricted Project, Restricted Project
bixia committed rG3b1c86cd0f6d: [mlir][sparse] Implement heap sort for sparse_tensor.sort. (authored by bixia).
[mlir][sparse] Implement heap sort for sparse_tensor.sort.
Feb 2 2023, 3:37 PM · Restricted Project, Restricted Project
bixia closed D142913: [mlir][sparse] Implement heap sort for sparse_tensor.sort..
Feb 2 2023, 3:36 PM · Restricted Project, Restricted Project
bixia added inline comments to D142913: [mlir][sparse] Implement heap sort for sparse_tensor.sort..
Feb 2 2023, 2:56 PM · Restricted Project, Restricted Project
bixia updated the diff for D142913: [mlir][sparse] Implement heap sort for sparse_tensor.sort..

Fix comments to address review feedback.

Feb 2 2023, 2:55 PM · Restricted Project, Restricted Project
bixia abandoned D141732: [mlir][sparse] Improve the rewriting for dense-to-annotated-dense convert operator..
Feb 2 2023, 1:47 PM · Restricted Project, Restricted Project

Jan 31 2023

bixia updated the diff for D142913: [mlir][sparse] Implement heap sort for sparse_tensor.sort..

Rebase.

Jan 31 2023, 10:25 AM · Restricted Project, Restricted Project
bixia committed rG8550aebd57d0: [mlir][sparse] Extend sorting function generator to support operand beyond (lo… (authored by bixia).
[mlir][sparse] Extend sorting function generator to support operand beyond (lo…
Jan 31 2023, 10:22 AM · Restricted Project, Restricted Project
bixia closed D142731: [mlir][sparse] Extend sorting function generator to support operand beyond (lo, hi, xs, ys)..
Jan 31 2023, 10:22 AM · Restricted Project, Restricted Project
bixia updated the diff for D142731: [mlir][sparse] Extend sorting function generator to support operand beyond (lo, hi, xs, ys)..

Rebase.

Jan 31 2023, 8:36 AM · Restricted Project, Restricted Project
bixia updated the diff for D142731: [mlir][sparse] Extend sorting function generator to support operand beyond (lo, hi, xs, ys)..

Rebase.

Jan 31 2023, 8:20 AM · Restricted Project, Restricted Project

Jan 30 2023

bixia added reviewers for D142913: [mlir][sparse] Implement heap sort for sparse_tensor.sort.: Peiming, wrengr.
Jan 30 2023, 10:15 AM · Restricted Project, Restricted Project
bixia requested review of D142913: [mlir][sparse] Implement heap sort for sparse_tensor.sort..
Jan 30 2023, 10:15 AM · Restricted Project, Restricted Project

Jan 29 2023

bixia updated the summary of D141732: [mlir][sparse] Improve the rewriting for dense-to-annotated-dense convert operator..
Jan 29 2023, 8:31 PM · Restricted Project, Restricted Project