This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] enable more sparse convolution kernels.
ClosedPublic

Authored by Peiming on Apr 5 2023, 4:44 PM.

Diff Detail

Event Timeline

Peiming created this revision.Apr 5 2023, 4:44 PM
Herald added a project: Restricted Project. · View Herald Transcript
Peiming requested review of this revision.Apr 5 2023, 4:44 PM
Peiming updated this revision to Diff 511234.Apr 5 2023, 4:57 PM

revert debug code.

aartbik added inline comments.Apr 17 2023, 10:23 AM
mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.cpp
1620

typo: outermost

then, in terms of reading the code, seeing

if (!outermost)

this is outermost

is very confusing ;-)
Can you rephrase so that your logic is more clear

Peiming updated this revision to Diff 514294.Apr 17 2023, 10:25 AM

address comments.

aartbik accepted this revision.Apr 17 2023, 10:31 AM
This revision is now accepted and ready to land.Apr 17 2023, 10:31 AM
This revision was landed with ongoing or failed builds.Apr 17 2023, 10:44 AM
This revision was automatically updated to reflect the committed changes.