First, second, third (from previous)
You use s and non-s forms (Skip, Generates, Finds)
Typically, we use s form in top comment, and non-s form in code doc
user's or users'
is the attr test needed since already done in if?
in that case, can you just break out first and second if for readability?
// break on
either on same line as break (preferred)
or otherwise in right style
// Break on ... .
should we make the load a CHECK-DAG if order may change (often) over time?
commend needs refining on format
in DCSR is no longer valid in the comment
Yeah, good idea
Yeah, you are right! no need to test attr != nullptr as they are pointer comparison afterall!