Page MenuHomePhabricator
Differential D142927

[mlir][sparse] add new sparisification option for dependent index reduction-based codegen
ClosedPublic
Actions

Authored by Peiming on Jan 30 2023, 1:23 PM.

Details

Reviewers
aartbik
nicolasvasilache
bixia
wrengr
Commits
rGee928fcde2b0: [mlir][sparse] add new sparisification option for dependent index reduction…

Diff Detail

Event Timeline

Peiming created this revision.Jan 30 2023, 1:23 PM
Herald added a reviewer: aartbik. · View Herald TranscriptJan 30 2023, 1:23 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: hanchung, jsetoain, Moerafaat and 23 others. · View Herald Transcript
Peiming requested review of this revision.Jan 30 2023, 1:23 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptJan 30 2023, 1:23 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Peiming added a child revision: D142928: [mlir][sparse] add merger/topo sort support for slice-based affine sparse index codegen.Jan 30 2023, 1:31 PM
Peiming added a parent revision: D141532: [mlir][sparse] support dynamic sparse tensor slices..
Peiming added reviewers: bixia, wrengr.Jan 30 2023, 1:33 PM
Harbormaster completed remote builds in B210841: Diff 493393.Jan 30 2023, 1:44 PM
Peiming retitled this revision from [mlir][sparse] add new sparisification option for slice-based codegen to [mlir][sparse] add new sparisification option for dependent index reduction-based codegen.Fri, Mar 10, 2:55 PM
Herald added a subscriber: arphaman. · View Herald TranscriptFri, Mar 10, 2:55 PM
aartbik accepted this revision.Thu, Mar 16, 11:30 AM
aartbik added inline comments.
mlir/include/mlir/Dialect/SparseTensor/Pipelines/Passes.h
58

I would move (experimental) to the end, so e.g.

Enable slice-based algorithm to generate affine indices on sparse inputs (experimental feature)

mlir/include/mlir/Dialect/SparseTensor/Transforms/Passes.td
85

same

This revision is now accepted and ready to land.Thu, Mar 16, 11:30 AM
Peiming updated this revision to Diff 505904.Thu, Mar 16, 12:47 PM

address comment, rename terminologies

Harbormaster completed remote builds in B219939: Diff 505904.Thu, Mar 16, 1:08 PM
This revision was landed with ongoing or failed builds.Thu, Mar 16, 1:11 PM
Closed by commit rGee928fcde2b0: [mlir][sparse] add new sparisification option for dependent index reduction… (authored by Peiming). · Explain Why
This revision was automatically updated to reflect the committed changes.
Peiming added a commit: rGee928fcde2b0: [mlir][sparse] add new sparisification option for dependent index reduction….

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
SparseTensor/
Pipelines/
9 lines
Transforms/
7 lines
3 lines
lib/
Dialect/
SparseTensor/
Transforms/
3 lines
137 lines

Diff 505910

View Options

mlir/include/mlir/Dialect/SparseTensor/Pipelines/Passes.h

Loading...
View Options

mlir/include/mlir/Dialect/SparseTensor/Transforms/Passes.h

Loading...
View Options

mlir/include/mlir/Dialect/SparseTensor/Transforms/Passes.td

Loading...
View Options

mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorPasses.cpp

Loading...
View Options

mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp

Loading...