Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
| mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.cpp | ||
|---|---|---|
| 89 | First, second, third (from previous) | |
| 566 | You use s and non-s forms (Skip, Generates, Finds) Typically, we use s form in top comment, and non-s form in code doc | |
| mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.h | ||
| 185 | user's or users' | |
| mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp | ||
| 1104 | is the attr test needed since already done in if? in that case, can you just break out first and second if for readability? | |
| 1105 | // break on either on same line as break (preferred) or otherwise in right style // Break on ... . | |
| mlir/test/Dialect/SparseTensor/sparse_1d.mlir | ||
| 1303 | should we make the load a CHECK-DAG if order may change (often) over time? | |
| mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_matmul_slice.mlir | ||
| 48 | commend needs refining on format | |
| 60 | in DCSR is no longer valid in the comment | |
address comment.
| mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp | ||
|---|---|---|
| 1105 | Yeah, you are right! no need to test attr != nullptr as they are pointer comparison afterall! | |
user's or users'