[readobj] Make JSON output consistent for Other flags

[paulkirth]

Summary

Currently in the LLVM/JSON output, the Other field can either be an
integer(when it is 0) or an object/list for other cases. This patch makes the
formatting consistent for all value ranges. This is particularly important for
machine readable output in JSON, as it makes handling the Other field a special
case

Depends on D134843

[phosek]

llvm/test/tools/llvm-readobj/ELF/dyn-symbols-size-from-hash-table.test

40–41

Can we modify https://github.com/llvm/llvm-project/blob/f4e8f44811e25fd5547d879aafafd621386eb927/llvm/include/llvm/Support/ScopedPrinter.h#L444 to avoid printing \n and startLine() when Flags are empty so we end up with Other [ (0x0) ] for this case.

[paulkirth]

llvm/test/tools/llvm-readobj/ELF/dyn-symbols-size-from-hash-table.test

40–41

Yeah, that's a good suggestion. I'll look into handling that case more gracefully.

[paulkirth]

I still need to update a number of tests outside of readobj, in addition to the suggestion from @phosek.

[jhenderson]

I think the approach seems reasonable to me, and am happy with @phosek's suggestion too, though that should probably be a separate patch (I assume it impacts more than this specific case...)?

[paulkirth]

Still looking into this, but one thing I'm increasingly hesitant about is how closely the LLVM and JSON implementations are coupled. It may make sense to separate the implementations more before we start introducing changes that affect more than the JSON output.

@jhenderson do we have any stability guarantees for the LLVM format? I don't want to introduce churn just for the sake of it, but is the LLVM output intended to be easily machine parsable, or to follow some format we've outlined somewhere? where changes to both formats make sense, I'm happy to share the implementation, but I expect there will eventually reach a point where the JSON and LLVM formats need to diverge to satisfy consumers. If possible, I'd like to establish where that point is, so that we can plan for/recognize it apriori.

[jhenderson]

In D135419#3869971, @paulkirth wrote:

Still looking into this, but one thing I'm increasingly hesitant about is how closely the LLVM and JSON implementations are coupled. It may make sense to separate the implementations more before we start introducing changes that affect more than the JSON output.

@jhenderson do we have any stability guarantees for the LLVM format? I don't want to introduce churn just for the sake of it, but is the LLVM output intended to be easily machine parsable, or to follow some format we've outlined somewhere? where changes to both formats make sense, I'm happy to share the implementation, but I expect there will eventually reach a point where the JSON and LLVM formats need to diverge to satisfy consumers. If possible, I'd like to establish where that point is, so that we can plan for/recognize it apriori.

I don't think there's any specific stability guarantees for the LLVM format output, but we'd have to have justifiable reasons to change it. In particular, there are large numbers of tests that use llvm-readobj for testing things, and changing the output may impact those tests. It's possible the changes will be in such a way that a test no longer would fail when a bug was introduced, for example, so you have to be very careful what changes. If you think any non-trivial changes are needed, it would be worth raising on Discourse first too, because other developers may well have a different point of view. In fact, this whole discussion about stability of the output might be worth a Discourse thread, though it would be worth coming up with one or two examples as to what you might want to change in order to make things work.

[paulkirth]

Abandoning in favor of D137088

llvm/test/tools/llvm-readobj/ELF/dyn-symbols-size-from-hash-table.test

 
 # LLVM1:      DynamicSymbols [
 # LLVM1-NEXT:   Symbol {
 # LLVM1-NEXT:     Name:  (0)
 # LLVM1-NEXT:     Value: 0x0
 # LLVM1-NEXT:     Size: 0
 # LLVM1-NEXT:     Binding: Local (0x0)
 # LLVM1-NEXT:     Type: None (0x0)
-# LLVM1-NEXT:     Other: 0
+# LLVM1-NEXT:     Other [ (0x0)
+# LLVM1-NEXT:     ]
 # LLVM1-NEXT:     Section: Undefined (0x0)
 # LLVM1-NEXT:   }
 # LLVM1-NEXT:   Symbol {
 # LLVM1-NEXT:     Name: foo (5)
 # LLVM1-NEXT:     Value: 0x100
 # LLVM1-NEXT:     Size: 0
 # LLVM1-NEXT:     Binding: Local (0x0)
 # LLVM1-NEXT:     Type: Function (0x2)
-# LLVM1-NEXT:     Other: 0
+# LLVM1-NEXT:     Other [ (0x0)
+# LLVM1-NEXT:     ]
 # STRIP-NEXT:     Section: <?> (0x1)
 # NOSTRIP-NEXT:   Section: .text (0x1)
 # LLVM1-NEXT:   }
 # LLVM1-NEXT:   Symbol {
 # LLVM1-NEXT:     Name: bar (1)
 # LLVM1-NEXT:     Value: 0x200
 # LLVM1-NEXT:     Size: 0
 # LLVM1-NEXT:     Binding: Local (0x0)
 # LLVM1-NEXT:     Type: Object (0x1)
-# LLVM1-NEXT:     Other: 0
+# LLVM1-NEXT:     Other [ (0x0)
+# LLVM1-NEXT:     ]
 # STRIP-NEXT:     Section: <?> (0x2)
 # NOSTRIP-NEXT:   Section: .data (0x2)
 # LLVM1-NEXT:   }
 # LLVM1-NEXT: ]
 
 # GNU1-STRIP:   Symbol table for image contains 3 entries:
 # GNU1-NOSTRIP: Symbol table '.dynsym' contains 3 entries:
 # GNU1-NEXT:      Num:    Value        Size Type    Bind   Vis       Ndx Name

 
 # LLVM2:           DynamicSymbols [
 # LLVM2-NEXT:        Symbol {
 # LLVM2-NEXT:          Name:  (0)
 # LLVM2-NEXT:          Value: 0x0
 # LLVM2-NEXT:          Size: 0
 # LLVM2-NEXT:          Binding: Local (0x0)
 # LLVM2-NEXT:          Type: None (0x0)
-# LLVM2-NEXT:          Other: 0
+# LLVM2-NEXT:          Other [ (0x0)
+# LLVM2-NEXT:          ]
 # LLVM2-NEXT:          Section: Undefined (0x0)
 # LLVM2-NEXT:        }
 # LLVM2-NEXT:        Symbol {
 # LLVM2-NEXT:          Name: foo (9)
 # LLVM2-NEXT:          Value: 0x100
 # LLVM2-NEXT:          Size: 0
 # LLVM2-NEXT:          Binding: Local (0x0)
 # LLVM2-NEXT:          Type: Function (0x2)
-# LLVM2-NEXT:          Other: 0
+# LLVM2-NEXT:          Other [ (0x0)
+# LLVM2-NEXT:          ]
 # LLVM2-NEXT:          Section: .text (0x1)
 # LLVM2-NEXT:        }
 # LLVM2-MORE-NEXT:   Symbol {
 # LLVM2-MORE-NEXT:     Name: bar (5)
 # LLVM2-MORE-NEXT:     Value: 0x200
 # LLVM2-MORE-NEXT:     Size: 0
 # LLVM2-MORE-NEXT:     Binding: Local (0x0)
 # LLVM2-MORE-NEXT:     Type: Object (0x1)
-# LLVM2-MORE-NEXT:     Other: 0
+# LLVM2-MORE-NEXT:     Other [ (0x0)
+# LLVM2-MORE-NEXT:     ]
 # LLVM2-MORE-NEXT:     Section: .data (0x2)
 # LLVM2-MORE-NEXT:   }
 # LLVM2-ALL-NEXT:    Symbol {
 # LLVM2-ALL-NEXT:      Name: baz (1)
 # LLVM2-ALL-NEXT:      Value: 0x300
 # LLVM2-ALL-NEXT:      Size: 0
 # LLVM2-ALL-NEXT:      Binding: Local (0x0)
 # LLVM2-ALL-NEXT:      Type: Object (0x1)
-# LLVM2-ALL-NEXT:      Other: 0
+# LLVM2-ALL-NEXT:      Other [ (0x0)
+# LLVM2-ALL-NEXT:      ]
 # LLVM2-ALL-NEXT:      Section: .data (0x2)
 # LLVM2-ALL-NEXT:    }
 # LLVM2-NEXT:      ]
 
 # GNU2:           Symbol table '.dynsym' contains [[NCHAIN]] entries:
 # GNU2-NEXT:        Num:    Value        Size Type    Bind   Vis       Ndx Name
 # GNU2-NEXT:          0: {{0*}}00000000     0 NOTYPE  LOCAL  DEFAULT   UND
 # GNU2-NEXT:          1: {{0*}}00000100     0 FUNC    LOCAL  DEFAULT     1 foo

llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test

 ## In this test we test that dynamic symbols are dumped as expected.
 
 ## Case 1: Dynamic symbol table found via the DT_SYMTAB dynamic tag.
 # RUN: yaml2obj --docnum=1 %s -o %t1.so
 # RUN: llvm-readobj --dyn-symbols %t1.so 2>&1 \
 # RUN:   | FileCheck %s --implicit-check-not="warning:" --check-prefix=DYNSYMS-LLVM
 # RUN: llvm-readelf --dyn-symbols %t1.so 2>&1 \
 # RUN:   | FileCheck %s --implicit-check-not="warning:" --check-prefix=DYNSYMS-GNU
 
 # DYNSYMS-LLVM:      DynamicSymbols [
 # DYNSYMS-LLVM-NEXT:   Symbol {
 # DYNSYMS-LLVM-NEXT:     Name:  (0)
 # DYNSYMS-LLVM-NEXT:     Value: 0x0
 # DYNSYMS-LLVM-NEXT:     Size: 0
 # DYNSYMS-LLVM-NEXT:     Binding: Local (0x0)
 # DYNSYMS-LLVM-NEXT:     Type: None (0x0)
-# DYNSYMS-LLVM-NEXT:     Other: 0
+# DYNSYMS-LLVM-NEXT:     Other [ (0x0)
+# DYNSYMS-LLVM-NEXT:     ]
 # DYNSYMS-LLVM-NEXT:     Section: Undefined (0x0)
 # DYNSYMS-LLVM-NEXT:   }
 # DYNSYMS-LLVM-NEXT:   Symbol {
 # DYNSYMS-LLVM-NEXT:     Name: foo (5)
 # DYNSYMS-LLVM-NEXT:     Value: 0x0
 # DYNSYMS-LLVM-NEXT:     Size: 0
 # DYNSYMS-LLVM-NEXT:     Binding: Local (0x0)
 # DYNSYMS-LLVM-NEXT:     Type: None (0x0)
-# DYNSYMS-LLVM-NEXT:     Other: 0
+# DYNSYMS-LLVM-NEXT:     Other [ (0x0)
+# DYNSYMS-LLVM-NEXT:     ]
 # DYNSYMS-LLVM-NEXT:     Section: Undefined (0x0)
 # DYNSYMS-LLVM-NEXT:   }
 # DYNSYMS-LLVM-NEXT:   Symbol {
 # DYNSYMS-LLVM-NEXT:     Name: bar (1)
 # DYNSYMS-LLVM-NEXT:     Value: 0x0
 # DYNSYMS-LLVM-NEXT:     Size: 0
 # DYNSYMS-LLVM-NEXT:     Binding: Local (0x0)
 # DYNSYMS-LLVM-NEXT:     Type: None (0x0)
-# DYNSYMS-LLVM-NEXT:     Other: 0
+# DYNSYMS-LLVM-NEXT:     Other [ (0x0)
+# DYNSYMS-LLVM-NEXT:     ]
 # DYNSYMS-LLVM-NEXT:     Section: Undefined (0x0)
 # DYNSYMS-LLVM-NEXT:   }
 # DYNSYMS-LLVM-NEXT: ]
 
 # DYNSYMS-GNU:      Symbol table '.dynsym' contains 3 entries:
 # DYNSYMS-GNU-NEXT:  Num:    Value          Size Type    Bind   Vis       Ndx Name
 # DYNSYMS-GNU-NEXT:    0: 0000000000000000     0 NOTYPE  LOCAL  DEFAULT   UND
 # DYNSYMS-GNU-NEXT:    1: 0000000000000000     0 NOTYPE  LOCAL  DEFAULT   UND foo

 # NOPHDRS-LLVM: warning: '[[FILE]]': unable to parse DT_SYMTAB: virtual address is not in any segment: 0xffff1234
 # NOPHDRS-LLVM:      DynamicSymbols [
 # NOPHDRS-LLVM-NEXT:   Symbol {
 # NOPHDRS-LLVM-NEXT:     Name:  (0)
 # NOPHDRS-LLVM-NEXT:     Value: 0x0
 # NOPHDRS-LLVM-NEXT:     Size: 0
 # NOPHDRS-LLVM-NEXT:     Binding: Local (0x0)
 # NOPHDRS-LLVM-NEXT:     Type: None (0x0)
-# NOPHDRS-LLVM-NEXT:     Other: 0
+# NOPHDRS-LLVM-NEXT:     Other [ (0x0)
+# NOPHDRS-LLVM-NEXT:     ]
 # NOPHDRS-LLVM-NEXT:     Section: Undefined (0x0)
 # NOPHDRS-LLVM-NEXT:   }
 # NOPHDRS-LLVM-NEXT:   Symbol {
 # NOPHDRS-LLVM-NEXT:     Name: foo (1)
 # NOPHDRS-LLVM-NEXT:     Value: 0x0
 # NOPHDRS-LLVM-NEXT:     Size: 0
 # NOPHDRS-LLVM-NEXT:     Binding: Local (0x0)
 # NOPHDRS-LLVM-NEXT:     Type: None (0x0)
-# NOPHDRS-LLVM-NEXT:     Other: 0
+# NOPHDRS-LLVM-NEXT:     Other [ (0x0)
+# NOPHDRS-LLVM-NEXT:     ]
 # NOPHDRS-LLVM-NEXT:     Section: Undefined (0x0)
 # NOPHDRS-LLVM-NEXT:   }
 # NOPHDRS-LLVM-NEXT: ]
 
 # NOPHDRS-GNU:      warning: '[[FILE]]': unable to parse DT_SYMTAB: virtual address is not in any segment: 0xffff1234
 # NOPHDRS-NAMEWARN: warning: '[[FILE]]': unable to get the name of SHT_DYNSYM section with index 2: a section [index 2] has an invalid sh_name (0xffffffff) offset which goes past the end of the section name string table
 # NOPHDRS-GNU:      Symbol table '[[NAME]]' contains 2 entries:
 # NOPHDRS-GNU-NEXT:  Num:    Value          Size Type    Bind   Vis       Ndx Name

 
 # VERSIONED-UND-LLVM:       DynamicSymbols [
 # VERSIONED-UND-LLVM-NEXT:   Symbol {
 # VERSIONED-UND-LLVM-NEXT:     Name:  (0)
 # VERSIONED-UND-LLVM-NEXT:     Value: 0x0
 # VERSIONED-UND-LLVM-NEXT:     Size: 0
 # VERSIONED-UND-LLVM-NEXT:     Binding: Local (0x0)
 # VERSIONED-UND-LLVM-NEXT:     Type: None (0x0)
-# VERSIONED-UND-LLVM-NEXT:     Other: 0
+# VERSIONED-UND-LLVM-NEXT:     Other [ (0x0)
+# VERSIONED-UND-LLVM-NEXT:     ]
 # VERSIONED-UND-LLVM-NEXT:     Section: Undefined (0x0)
 # VERSIONED-UND-LLVM-NEXT:   }
 # VERSIONED-UND-LLVM-NEXT:   Symbol {
 # VERSIONED-UND-LLVM-NEXT:     Name: localversym (28)
 # VERSIONED-UND-LLVM-NEXT:     Value: 0x0
 # VERSIONED-UND-LLVM-NEXT:     Size: 0
 # VERSIONED-UND-LLVM-NEXT:     Binding: Local (0x0)
 # VERSIONED-UND-LLVM-NEXT:     Type: None (0x0)
-# VERSIONED-UND-LLVM-NEXT:     Other: 0
+# VERSIONED-UND-LLVM-NEXT:     Other [ (0x0)
+# VERSIONED-UND-LLVM-NEXT:     ]
 # VERSIONED-UND-LLVM-NEXT:     Section: Undefined (0x0)
 # VERSIONED-UND-LLVM-NEXT:   }
 # VERSIONED-UND-LLVM-NEXT:   Symbol {
 # VERSIONED-UND-LLVM-NEXT:     Name: globalversym (40)
 # VERSIONED-UND-LLVM-NEXT:     Value: 0x0
 # VERSIONED-UND-LLVM-NEXT:     Size: 0
 # VERSIONED-UND-LLVM-NEXT:     Binding: Local (0x0)
 # VERSIONED-UND-LLVM-NEXT:     Type: None (0x0)
-# VERSIONED-UND-LLVM-NEXT:     Other: 0
+# VERSIONED-UND-LLVM-NEXT:     Other [ (0x0)
+# VERSIONED-UND-LLVM-NEXT:     ]
 # VERSIONED-UND-LLVM-NEXT:     Section: Undefined (0x0)
 # VERSIONED-UND-LLVM-NEXT:   }
 # VERSIONED-UND-LLVM-NEXT:   Symbol {
 # VERSIONED-UND-LLVM-NEXT:     Name: aaa@v2 (65)
 # VERSIONED-UND-LLVM-NEXT:     Value: 0x0
 # VERSIONED-UND-LLVM-NEXT:     Size: 0
 # VERSIONED-UND-LLVM-NEXT:     Binding: Local (0x0)
 # VERSIONED-UND-LLVM-NEXT:     Type: None (0x0)
-# VERSIONED-UND-LLVM-NEXT:     Other: 0
+# VERSIONED-UND-LLVM-NEXT:     Other [ (0x0)
+# VERSIONED-UND-LLVM-NEXT:     ]
 # VERSIONED-UND-LLVM-NEXT:     Section: Undefined (0x0)
 # VERSIONED-UND-LLVM-NEXT:   }
 # VERSIONED-UND-LLVM-NEXT:   Symbol {
 # VERSIONED-UND-LLVM-NEXT:     Name: bbb@v3hidden (61)
 # VERSIONED-UND-LLVM-NEXT:     Value: 0x0
 # VERSIONED-UND-LLVM-NEXT:     Size: 0
 # VERSIONED-UND-LLVM-NEXT:     Binding: Local (0x0)
 # VERSIONED-UND-LLVM-NEXT:     Type: None (0x0)
-# VERSIONED-UND-LLVM-NEXT:     Other: 0
+# VERSIONED-UND-LLVM-NEXT:     Other [ (0x0)
+# VERSIONED-UND-LLVM-NEXT:     ]
 # VERSIONED-UND-LLVM-NEXT:     Section: Undefined (0x0)
 # VERSIONED-UND-LLVM-NEXT:   }
 # VERSIONED-UND-LLVM-NEXT:   Symbol {
 # VERSIONED-UND-LLVM-NEXT:     Name: ccc@v4 (57)
 # VERSIONED-UND-LLVM-NEXT:     Value: 0x0
 # VERSIONED-UND-LLVM-NEXT:     Size: 0
 # VERSIONED-UND-LLVM-NEXT:     Binding: Local (0x0)
 # VERSIONED-UND-LLVM-NEXT:     Type: None (0x0)
-# VERSIONED-UND-LLVM-NEXT:     Other: 0
+# VERSIONED-UND-LLVM-NEXT:     Other [ (0x0)
+# VERSIONED-UND-LLVM-NEXT:     ]
 # VERSIONED-UND-LLVM-NEXT:     Section: Undefined (0x0)
 # VERSIONED-UND-LLVM-NEXT:   }
 # VERSIONED-UND-LLVM-NEXT:   Symbol {
 # VERSIONED-UND-LLVM-NEXT:     Name: ddd@v5hidden (53)
 # VERSIONED-UND-LLVM-NEXT:     Value: 0x0
 # VERSIONED-UND-LLVM-NEXT:     Size: 0
 # VERSIONED-UND-LLVM-NEXT:     Binding: Local (0x0)
 # VERSIONED-UND-LLVM-NEXT:     Type: None (0x0)
-# VERSIONED-UND-LLVM-NEXT:     Other: 0
+# VERSIONED-UND-LLVM-NEXT:     Other [ (0x0)
+# VERSIONED-UND-LLVM-NEXT:     ]
 # VERSIONED-UND-LLVM-NEXT:     Section: Undefined (0x0)
 # VERSIONED-UND-LLVM-NEXT:   }
 # VERSIONED-UND-LLVM-NEXT: ]
 # VERSIONED-UND-LLVM:      VersionSymbols [
 # VERSIONED-UND-LLVM:          Name: localversym
 # VERSIONED-UND-LLVM:          Name: globalversym
 # VERSIONED-UND-LLVM:          Name: aaa@v2
 # VERSIONED-UND-LLVM:          Name: bbb@v3hidden

 
 # DYNSYM-EMPTY-LLVM:      DynamicSymbols [
 # DYNSYM-EMPTY-LLVM-NEXT:  Symbol {
 # DYNSYM-EMPTY-LLVM-NEXT:  Name: (0)
 # DYNSYM-EMPTY-LLVM-NEXT:  Value: 0x0
 # DYNSYM-EMPTY-LLVM-NEXT:  Size: 0
 # DYNSYM-EMPTY-LLVM-NEXT:  Binding: Local (0x0)
 # DYNSYM-EMPTY-LLVM-NEXT:  Type: None (0x0)
-# DYNSYM-EMPTY-LLVM-NEXT:  Other: 0
+# DYNSYM-EMPTY-LLVM-NEXT:  Other [ (0x0)
+# DYNSYM-EMPTY-LLVM-NEXT:  ]
 # DYNSYM-EMPTY-LLVM-NEXT:  Section: Undefined (0x0)
 # DYNSYM-EMPTY-LLVM-NEXT:  }
 # DYNSYM-EMPTY-LLVM-NEXT: ]
 
 # DYNSYM-EMPTY-GNU:      Symbol table '.dynsym' contains 1 entries:
 # DYNSYM-EMPTY-GNU-NEXT:   Num:    Value  Size Type    Bind   Vis       Ndx Name
 # DYNSYM-EMPTY-GNU-NEXT:     0: 00000000     0 NOTYPE  LOCAL  DEFAULT   UND
 

 # DYNSTR-INVALID-LLVM: warning: '[[FILE]]': the dynamic string table at 0x78 goes past the end of the file (0x2a8) with DT_STRSZ = 0xffffffff
 # DYNSTR-INVALID-LLVM:      DynamicSymbols [
 # DYNSTR-INVALID-LLVM-NEXT:   Symbol {
 # DYNSTR-INVALID-LLVM-NEXT:     Name:  (0)
 # DYNSTR-INVALID-LLVM-NEXT:     Value: 0x0
 # DYNSTR-INVALID-LLVM-NEXT:     Size: 0
 # DYNSTR-INVALID-LLVM-NEXT:     Binding: Local (0x0)
 # DYNSTR-INVALID-LLVM-NEXT:     Type: None (0x0)
-# DYNSTR-INVALID-LLVM-NEXT:     Other: 0
+# DYNSTR-INVALID-LLVM-NEXT:     Other [ (0x0)
+# DYNSTR-INVALID-LLVM-NEXT:     ]
 # DYNSTR-INVALID-LLVM-NEXT:     Section: Undefined (0x0)
 # DYNSTR-INVALID-LLVM-NEXT:   }
 # DYNSTR-INVALID-LLVM-NEXT: warning: '[[FILE]]': st_name (0xffffff00) is past the end of the string table of size 0x6
 # DYNSTR-INVALID-LLVM-NEXT:   Symbol {
 # DYNSTR-INVALID-LLVM-NEXT:     Name: <?> (4294967040)
 # DYNSTR-INVALID-LLVM-NEXT:     Value: 0x0
 # DYNSTR-INVALID-LLVM-NEXT:     Size: 0
 # DYNSTR-INVALID-LLVM-NEXT:     Binding: Local (0x0)
 # DYNSTR-INVALID-LLVM-NEXT:     Type: None (0x0)
-# DYNSTR-INVALID-LLVM-NEXT:     Other: 0
+# DYNSTR-INVALID-LLVM-NEXT:     Other [ (0x0)
+# DYNSTR-INVALID-LLVM-NEXT:     ]
 # DYNSTR-INVALID-LLVM-NEXT:     Section: Undefined (0x0)
 # DYNSTR-INVALID-LLVM-NEXT:   }
 # DYNSTR-INVALID-LLVM-NEXT:   Symbol {
 # DYNSTR-INVALID-LLVM-NEXT:     Name: test (1)
 # DYNSTR-INVALID-LLVM-NEXT:     Value: 0x0
 # DYNSTR-INVALID-LLVM-NEXT:     Size: 0
 # DYNSTR-INVALID-LLVM-NEXT:     Binding: Local (0x0)
 # DYNSTR-INVALID-LLVM-NEXT:     Type: None (0x0)
-# DYNSTR-INVALID-LLVM-NEXT:     Other: 0
+# DYNSTR-INVALID-LLVM-NEXT:     Other [ (0x0)
+# DYNSTR-INVALID-LLVM-NEXT:     ]
 # DYNSTR-INVALID-LLVM-NEXT:     Section: Undefined (0x0)
 # DYNSTR-INVALID-LLVM-NEXT:   }
 # DYNSTR-INVALID-LLVM-NEXT: ]
 
 # DYNSTR-INVALID-GNU: warning: '[[FILE]]': the dynamic string table at 0x78 goes past the end of the file (0x2a8) with DT_STRSZ = 0xffffffff
 # DYNSTR-INVALID-GNU:      Symbol table '.dynsym' contains 3 entries:
 # DYNSTR-INVALID-GNU-NEXT:    Num:    Value          Size Type    Bind   Vis       Ndx Name
 # DYNSTR-INVALID-GNU-NEXT:      0: 0000000000000000     0 NOTYPE  LOCAL  DEFAULT   UND

 # LINK-BROKEN-LLVM:      DynamicSymbols [
 # LINK-BROKEN-LLVM-NEXT: warning: '[[FILE]]': st_name (0x0) is past the end of the string table of size 0x0
 # LINK-BROKEN-LLVM-NEXT:   Symbol {
 # LINK-BROKEN-LLVM-NEXT:     Name: <?> (0)
 # LINK-BROKEN-LLVM-NEXT:     Value: 0x0
 # LINK-BROKEN-LLVM-NEXT:     Size: 0
 # LINK-BROKEN-LLVM-NEXT:     Binding: Local (0x0)
 # LINK-BROKEN-LLVM-NEXT:     Type: None (0x0)
-# LINK-BROKEN-LLVM-NEXT:     Other: 0
+# LINK-BROKEN-LLVM-NEXT:     Other [ (0x0)
+# LINK-BROKEN-LLVM-NEXT:     ]
 # LINK-BROKEN-LLVM-NEXT:     Section: Undefined (0x0)
 # LINK-BROKEN-LLVM-NEXT:   }
 # LINK-BROKEN-LLVM-NEXT: warning: '[[FILE]]': st_name (0x1) is past the end of the string table of size 0x0
 # LINK-BROKEN-LLVM-NEXT:   Symbol {
 # LINK-BROKEN-LLVM-NEXT:     Name: <?> (1)
 # LINK-BROKEN-LLVM-NEXT:     Value: 0x0
 # LINK-BROKEN-LLVM-NEXT:     Size: 0
 # LINK-BROKEN-LLVM-NEXT:     Binding: Local (0x0)
 # LINK-BROKEN-LLVM-NEXT:     Type: None (0x0)
-# LINK-BROKEN-LLVM-NEXT:     Other: 0
+# LINK-BROKEN-LLVM-NEXT:     Other [ (0x0)
+# LINK-BROKEN-LLVM-NEXT:     ]
 # LINK-BROKEN-LLVM-NEXT:     Section: Undefined (0x0)
 # LINK-BROKEN-LLVM-NEXT:   }
 # LINK-BROKEN-LLVM-NEXT: ]
 
 # LINK-BROKEN-GNU:      Symbol table '.dynsym' contains 2 entries:
 # LINK-BROKEN-GNU-NEXT:    Num:    Value  Size Type    Bind   Vis       Ndx Name
 # LINK-BROKEN-GNU-NEXT: warning: '[[FILE]]': st_name (0x0) is past the end of the string table of size 0x0
 # LINK-BROKEN-GNU-NEXT:      0: 00000000     0 NOTYPE  LOCAL  DEFAULT   UND <?>
 # LINK-BROKEN-GNU-NEXT: warning: '[[FILE]]': st_name (0x1) is past the end of the string table of size 0x0
 # LINK-BROKEN-GNU-NEXT:      1: 00000000     0 NOTYPE  LOCAL  DEFAULT   UND <?>

llvm/test/tools/llvm-readobj/ELF/sections-ext.test

 # SR-NEXT:      ]
 # ST-NEXT:      Symbols [
 # ST-NEXT:        Symbol {
 # ST-NEXT:          Name: foo (1)
 # ST-NEXT:          Value: 0x0
 # ST-NEXT:          Size: 0
 # ST-NEXT:          Binding: Local (0x0)
 # ST-NEXT:          Type: None (0x0)
-# ST-NEXT:          Other: 0
+# ST-NEXT:          Other [ (0x0)
+# ST-NEXT:          ]
 # ST-NEXT:          Section: .text (0x1)
 # ST-NEXT:        }
 # ST-NEXT:      ]
 # SD-NEXT:      SectionData (
 # SD-NEXT:      )
 # ALL-NEXT:   }
 # ALL-NEXT:   Section {
 # ALL-NEXT:     Index: 2

llvm/test/tools/llvm-readobj/ELF/symbol-shndx.test

 # SHNDX-ERR-LLVM-NEXT: LoadName: <Not found>
 # SHNDX-ERR-LLVM-NEXT: Symbols [
 # SHNDX-ERR-LLVM-NEXT:   Symbol {
 # SHNDX-ERR-LLVM-NEXT:     Name:  (0)
 # SHNDX-ERR-LLVM-NEXT:     Value: 0x0
 # SHNDX-ERR-LLVM-NEXT:     Size: 0
 # SHNDX-ERR-LLVM-NEXT:     Binding: Local (0x0)
 # SHNDX-ERR-LLVM-NEXT:     Type: None (0x0)
-# SHNDX-ERR-LLVM-NEXT:     Other: 0
+# SHNDX-ERR-LLVM-NEXT:     Other [ (0x0)
+# SHNDX-ERR-LLVM-NEXT:     ]
 # SHNDX-ERR-LLVM-NEXT:     Section: Undefined (0x0)
 # SHNDX-ERR-LLVM-NEXT:   }
 # SHNDX-ERR-LLVM-NEXT:   Symbol {
 # SHNDX-ERR-LLVM-NEXT:     Name:  (0)
 # SHNDX-ERR-LLVM-NEXT:     Value: 0x0
 # SHNDX-ERR-LLVM-NEXT:     Size: 0
 # SHNDX-ERR-LLVM-NEXT:     Binding: Local (0x0)
 # SHNDX-ERR-LLVM-NEXT:     Type: None (0x0)
-# SHNDX-ERR-LLVM-NEXT:     Other: 0
+# SHNDX-ERR-LLVM-NEXT:     Other [ (0x0)
+# SHNDX-ERR-LLVM-NEXT:     ]
 # SHNDX-ERR-LLVM-NEXT: warning: '[[FILE]]': found an extended symbol index (1), but unable to locate the extended symbol index table
 # SHNDX-ERR-LLVM-NEXT:     Section: Reserved (0xFFFF)
 # SHNDX-ERR-LLVM-NEXT:   }
 # SHNDX-ERR-LLVM-NEXT: ]
 
 --- !ELF
 FileHeader:
   Class: ELFCLASS64

llvm/test/tools/llvm-readobj/ELF/symbol-visibility.test

 ## Show that llvm-readobj prints the symbol visibility where recognised, or
 ## something sensible when not, for both GNU and LLVM output.
 
 ## Check how we dump symbols when they have only STV_* bits set for st_other.
 ## (This is the most common case).
 
 # RUN: yaml2obj --docnum=1 %s -o %t1.o
 # RUN: llvm-readobj --symbols %t1.o | FileCheck %s --check-prefix=LLVM
 # RUN: llvm-readelf --symbols %t1.o | FileCheck %s --strict-whitespace --check-prefix=GNU
 
 # LLVM:      Name: default
-# LLVM:      Other: 0
+# LLVM:      Other [ (0x0)
+# LLVM:      ]
 # LLVM:      Name: internal
 # LLVM:      Other [ (0x1)
 # LLVM-NEXT:   STV_INTERNAL (0x1)
 # LLVM-NEXT: ]
 # LLVM:      Name: hidden
 # LLVM:      Other [ (0x2)
 # LLVM-NEXT:   STV_HIDDEN (0x2)
 # LLVM-NEXT: ]

llvm/test/tools/llvm-readobj/ELF/symbols.test

 
 #      SYMBOLS-LLVM:Symbols [
 # SYMBOLS-LLVM-NEXT:  Symbol {
 # SYMBOLS-LLVM-NEXT:    Name:  (0)
 # SYMBOLS-LLVM-NEXT:    Value: 0x0
 # SYMBOLS-LLVM-NEXT:    Size: 0
 # SYMBOLS-LLVM-NEXT:    Binding: Local (0x0)
 # SYMBOLS-LLVM-NEXT:    Type: None (0x0)
-# SYMBOLS-LLVM-NEXT:    Other: 0
+# SYMBOLS-LLVM-NEXT:    Other [ (0x0)
+# SYMBOLS-LLVM-NEXT:    ]
 # SYMBOLS-LLVM-NEXT:    Section: Undefined (0x0)
 # SYMBOLS-LLVM-NEXT:  }
 # SYMBOLS-LLVM-NEXT:  Symbol {
 # SYMBOLS-LLVM-NEXT:    Name: foo (5)
 # SYMBOLS-LLVM-NEXT:    Value: 0x1
 # SYMBOLS-LLVM-NEXT:    Size: 0
 # SYMBOLS-LLVM-NEXT:    Binding: Local (0x0)
 # SYMBOLS-LLVM-NEXT:    Type: None (0x0)
-# SYMBOLS-LLVM-NEXT:    Other: 0
+# SYMBOLS-LLVM-NEXT:    Other [ (0x0)
+# SYMBOLS-LLVM-NEXT:    ]
 # SYMBOLS-LLVM-NEXT:    Section: Undefined (0x0)
 # SYMBOLS-LLVM-NEXT:  }
 # SYMBOLS-LLVM-NEXT:  Symbol {
 # SYMBOLS-LLVM-NEXT:    Name: bar (1)
 # SYMBOLS-LLVM-NEXT:    Value: 0x2
 # SYMBOLS-LLVM-NEXT:    Size: 0
 # SYMBOLS-LLVM-NEXT:    Binding: Local (0x0)
 # SYMBOLS-LLVM-NEXT:    Type: None (0x0)
-# SYMBOLS-LLVM-NEXT:    Other: 0
+# SYMBOLS-LLVM-NEXT:    Other [ (0x0)
+# SYMBOLS-LLVM-NEXT:    ]
 # SYMBOLS-LLVM-NEXT:    Section: Undefined (0x0)
 # SYMBOLS-LLVM-NEXT:  }
 # SYMBOLS-LLVM-NEXT:]
 
 #      SYMBOLS-GNU64:Symbol table '.symtab' contains 3 entries:
 # SYMBOLS-GNU64-NEXT:   Num:    Value          Size Type    Bind   Vis       Ndx Name
 # SYMBOLS-GNU64-NEXT:     0: 0000000000000000     0 NOTYPE  LOCAL  DEFAULT   UND 
 # SYMBOLS-GNU64-NEXT:     1: 0000000000000001     0 NOTYPE  LOCAL  DEFAULT   UND foo

 # STRTAB-LINK-ERR-LLVM:      Symbols [
 # STRTAB-LINK-ERR-LLVM-NEXT: warning: '[[FILE]]': unable to get the string table for the SHT_SYMTAB section: invalid section index: 255
 # STRTAB-LINK-ERR-LLVM-NEXT:   Symbol {
 # STRTAB-LINK-ERR-LLVM-NEXT:     Name: <?> (0)
 # STRTAB-LINK-ERR-LLVM-NEXT:     Value: 0x0
 # STRTAB-LINK-ERR-LLVM-NEXT:     Size: 0
 # STRTAB-LINK-ERR-LLVM-NEXT:     Binding: Local (0x0)
 # STRTAB-LINK-ERR-LLVM-NEXT:     Type: None (0x0)
-# STRTAB-LINK-ERR-LLVM-NEXT:     Other: 0
+# STRTAB-LINK-ERR-LLVM-NEXT:     Other [ (0x0)
+# STRTAB-LINK-ERR-LLVM-NEXT:     ]
 # STRTAB-LINK-ERR-LLVM-NEXT:     Section: Undefined (0x0)
 # STRTAB-LINK-ERR-LLVM-NEXT:   }
 # STRTAB-LINK-ERR-LLVM-NEXT:   Symbol {
 # STRTAB-LINK-ERR-LLVM-NEXT:     Name: <?> (1)
 # STRTAB-LINK-ERR-LLVM-NEXT:     Value: 0x1
 # STRTAB-LINK-ERR-LLVM-NEXT:     Size: 0
 # STRTAB-LINK-ERR-LLVM-NEXT:     Binding: Global (0x1)
 # STRTAB-LINK-ERR-LLVM-NEXT:     Type: None (0x0)
-# STRTAB-LINK-ERR-LLVM-NEXT:     Other: 0
+# STRTAB-LINK-ERR-LLVM-NEXT:     Other [ (0x0)
+# STRTAB-LINK-ERR-LLVM-NEXT:     ]
 # STRTAB-LINK-ERR-LLVM-NEXT:     Section: .symtab (0x1)
 # STRTAB-LINK-ERR-LLVM-NEXT:   }
 # STRTAB-LINK-ERR-LLVM-NEXT: ]
 
 # STRTAB-LINK-ERR-GNU:      warning: '[[FILE]]': unable to get the string table for the SHT_SYMTAB section: invalid section index: 255
 # STRTAB-LINK-ERR-GNU:      Symbol table '.symtab' contains 2 entries:
 # STRTAB-LINK-ERR-GNU-NEXT:    Num:    Value          Size Type    Bind   Vis       Ndx Name
 # STRTAB-LINK-ERR-GNU-NEXT:      0: 0000000000000000     0 NOTYPE  LOCAL  DEFAULT   UND <?>

 
 # SYMTAB-SHSTRTAB-ERR-LLVM:      Symbols [
 # SYMTAB-SHSTRTAB-ERR-LLVM-NEXT:   Symbol {
 # SYMTAB-SHSTRTAB-ERR-LLVM-NEXT:     Name:  (0)
 # SYMTAB-SHSTRTAB-ERR-LLVM-NEXT:     Value: 0x0
 # SYMTAB-SHSTRTAB-ERR-LLVM-NEXT:     Size: 0
 # SYMTAB-SHSTRTAB-ERR-LLVM-NEXT:     Binding: Local (0x0)
 # SYMTAB-SHSTRTAB-ERR-LLVM-NEXT:     Type: None (0x0)
-# SYMTAB-SHSTRTAB-ERR-LLVM-NEXT:     Other: 0
+# SYMTAB-SHSTRTAB-ERR-LLVM-NEXT:     Other [ (0x0)
+# SYMTAB-SHSTRTAB-ERR-LLVM-NEXT:     ]
 # SYMTAB-SHSTRTAB-ERR-LLVM-NEXT:     Section: Undefined (0x0)
 # SYMTAB-SHSTRTAB-ERR-LLVM-NEXT:   }
 # SYMTAB-SHSTRTAB-ERR-LLVM-NEXT:   Symbol {
 # SYMTAB-SHSTRTAB-ERR-LLVM-NEXT:     Name: foo (1)
 # SYMTAB-SHSTRTAB-ERR-LLVM-NEXT:     Value: 0x1
 # SYMTAB-SHSTRTAB-ERR-LLVM-NEXT:     Size: 0
 # SYMTAB-SHSTRTAB-ERR-LLVM-NEXT:     Binding: Global (0x1)
 # SYMTAB-SHSTRTAB-ERR-LLVM-NEXT:     Type: None (0x0)
-# SYMTAB-SHSTRTAB-ERR-LLVM-NEXT:     Other: 0
+# SYMTAB-SHSTRTAB-ERR-LLVM-NEXT:     Other [ (0x0)
+# SYMTAB-SHSTRTAB-ERR-LLVM-NEXT:     ]
 # SYMTAB-SHSTRTAB-ERR-LLVM-NEXT: warning: '[[FILE]]': section header string table index 255 does not exist
 # SYMTAB-SHSTRTAB-ERR-LLVM-NEXT:     Section: <?> (0x1)
 # SYMTAB-SHSTRTAB-ERR-LLVM-NEXT:   }
 # SYMTAB-SHSTRTAB-ERR-LLVM-NEXT: ]
 
 # SYMTAB-SHSTRTAB-ERR-GNU:      warning: '[[FILE]]': unable to get the name of SHT_SYMTAB section with index 1: section header string table index 255 does not exist
 # SYMTAB-SHSTRTAB-ERR-GNU:      Symbol table '<?>' contains 2 entries:
 # SYMTAB-SHSTRTAB-ERR-GNU-NEXT:    Num:    Value          Size Type    Bind   Vis       Ndx Name
 # SYMTAB-SHSTRTAB-ERR-GNU-NEXT:      0: 0000000000000000     0 NOTYPE  LOCAL  DEFAULT   UND
 # SYMTAB-SHSTRTAB-ERR-GNU-NEXT:      1: 0000000000000001     0 NOTYPE  GLOBAL DEFAULT     1 foo

llvm/test/tools/llvm-readobj/ELF/symtab-shndx.test

 # NOTAG-GNU-NEXT:      2: 00000000     0 NOTYPE  LOCAL  DEFAULT   RSV[0xffff] dynsym2
 
 # NOTAG-LLVM:      Symbol {
 # NOTAG-LLVM:          Name: dynsym1 (9)
 # NOTAG-LLVM-NEXT:     Value: 0x0
 # NOTAG-LLVM-NEXT:     Size: 0
 # NOTAG-LLVM-NEXT:     Binding: Local (0x0)
 # NOTAG-LLVM-NEXT:     Type: None (0x0)
-# NOTAG-LLVM-NEXT:     Other: 0
+# NOTAG-LLVM-NEXT:     Other [ (0x0)
+# NOTAG-LLVM-NEXT:     ]
 # NOTAG-LLVM-NEXT: warning: '[[FILE]]': found an extended symbol index (1), but unable to locate the extended symbol index table
 # NOTAG-LLVM-NEXT:     Section: Reserved (0xFFFF)
 # NOTAG-LLVM-NEXT:   }
 # NOTAG-LLVM-NEXT:   Symbol {
 # NOTAG-LLVM-NEXT:     Name: dynsym2 (1)
 # NOTAG-LLVM-NEXT:     Value: 0x0
 # NOTAG-LLVM-NEXT:     Size: 0
 # NOTAG-LLVM-NEXT:     Binding: Local (0x0)
 # NOTAG-LLVM-NEXT:     Type: None (0x0)
-# NOTAG-LLVM-NEXT:     Other: 0
+# NOTAG-LLVM-NEXT:     Other [ (0x0)
+# NOTAG-LLVM-NEXT:     ]
 # NOTAG-LLVM-NEXT: warning: '[[FILE]]': found an extended symbol index (2), but unable to locate the extended symbol index table
 # NOTAG-LLVM-NEXT:     Section: Reserved (0xFFFF)
 # NOTAG-LLVM-NEXT:   }
 
 ## In this case we have a SHT_SYMTAB_SHNDX section with a sh_link field that has a
 ## value that is larger than the number of sections. Check we report a warning.
 
 # RUN: yaml2obj --docnum=1 -DSHNDXLINK=0xFF %s -o %t4

 # MULTIPLE-GNU-NEXT:      2: 00000000     0 NOTYPE  LOCAL  DEFAULT   2 dynsym2
 
 # MULTIPLE-LLVM:      Symbol {
 # MULTIPLE-LLVM:        Name: dynsym1 (9)
 # MULTIPLE-LLVM-NEXT:   Value: 0x0
 # MULTIPLE-LLVM-NEXT:   Size: 0
 # MULTIPLE-LLVM-NEXT:   Binding: Local (0x0)
 # MULTIPLE-LLVM-NEXT:   Type: None (0x0)
-# MULTIPLE-LLVM-NEXT:   Other: 0
+# MULTIPLE-LLVM-NEXT:   Other [ (0x0)
+# MULTIPLE-LLVM-NEXT:   ]
 # MULTIPLE-LLVM-NEXT:   Section: .section3 (0x3)
 # MULTIPLE-LLVM-NEXT: }
 # MULTIPLE-LLVM-NEXT: Symbol {
 # MULTIPLE-LLVM-NEXT:   Name: dynsym2 (1)
 # MULTIPLE-LLVM-NEXT:   Value: 0x0
 # MULTIPLE-LLVM-NEXT:   Size: 0
 # MULTIPLE-LLVM-NEXT:   Binding: Local (0x0)
 # MULTIPLE-LLVM-NEXT:   Type: None (0x0)
-# MULTIPLE-LLVM-NEXT:   Other: 0
+# MULTIPLE-LLVM-NEXT:   Other [ (0x0)
+# MULTIPLE-LLVM-NEXT:   ]
 # MULTIPLE-LLVM-NEXT:   Section: .section2 (0x2)
 # MULTIPLE-LLVM-NEXT: }
 
 ## In this case we have a SHT_SYMTAB_SHNDX section placed right before
 ## the end of the file. This table is broken: it contains fewer entries than
 ## the number of dynamic symbols.
 ## Check we report a warning when trying to read an extended symbol index past
 ## the end of the file.

 # PASTEND-GNU-NEXT: 2: 00000000 0 NOTYPE  LOCAL  DEFAULT RSV[0xffff] dynsym2
 
 # PASTEND-LLVM:      Symbol {
 # PASTEND-LLVM:       Name: dynsym2 (1)
 # PASTEND-LLVM-NEXT:  Value: 0x0
 # PASTEND-LLVM-NEXT:  Size: 0
 # PASTEND-LLVM-NEXT:  Binding: Local (0x0)
 # PASTEND-LLVM-NEXT:  Type: None (0x0)
-# PASTEND-LLVM-NEXT:  Other: 0
+# PASTEND-LLVM-NEXT:  Other [ (0x0)
+# PASTEND-LLVM-NEXT:  ]
 # PASTEND-LLVM-NEXT: warning: '[[FILE]]': unable to read an extended symbol table at index 2: can't read past the end of the file
 # PASTEND-LLVM-NEXT:  Section: Reserved (0xFFFF)
 # PASTEND-LLVM-NEXT: }
 
 --- !ELF
 FileHeader:
   Class: ELFCLASS32
   Data:  ELFDATA2LSB

llvm/test/tools/llvm-readobj/ELF/versym-invalid.test

 # INVALID-ENT-SIZE-LLVM:      DynamicSymbols [
 # INVALID-ENT-SIZE-LLVM-NEXT: warning: '[[FILE]]': section [index 1] has invalid sh_entsize: expected 2, but got 3
 # INVALID-ENT-SIZE-LLVM-NEXT:   Symbol {
 # INVALID-ENT-SIZE-LLVM-NEXT:     Name: @<corrupt> (0)
 # INVALID-ENT-SIZE-LLVM-NEXT:     Value: 0x0
 # INVALID-ENT-SIZE-LLVM-NEXT:     Size: 0
 # INVALID-ENT-SIZE-LLVM-NEXT:     Binding: Local (0x0)
 # INVALID-ENT-SIZE-LLVM-NEXT:     Type: None (0x0)
-# INVALID-ENT-SIZE-LLVM-NEXT:     Other: 0
+# INVALID-ENT-SIZE-LLVM-NEXT:     Other [ (0x0)
+# INVALID-ENT-SIZE-LLVM-NEXT:     ]
 # INVALID-ENT-SIZE-LLVM-NEXT:     Section: Undefined (0x0)
 # INVALID-ENT-SIZE-LLVM-NEXT:   }
 # INVALID-ENT-SIZE-LLVM-NEXT:   Symbol {
 # INVALID-ENT-SIZE-LLVM-NEXT:     Name: foo@<corrupt> (1)
 # INVALID-ENT-SIZE-LLVM-NEXT:     Value: 0x0
 # INVALID-ENT-SIZE-LLVM-NEXT:     Size: 0
 # INVALID-ENT-SIZE-LLVM-NEXT:     Binding: Local (0x0)
 # INVALID-ENT-SIZE-LLVM-NEXT:     Type: None (0x0)
-# INVALID-ENT-SIZE-LLVM-NEXT:     Other: 0
+# INVALID-ENT-SIZE-LLVM-NEXT:     Other [ (0x0)
+# INVALID-ENT-SIZE-LLVM-NEXT:     ]
 # INVALID-ENT-SIZE-LLVM-NEXT:     Section: Undefined (0x0)
 # INVALID-ENT-SIZE-LLVM-NEXT:   }
 # INVALID-ENT-SIZE-LLVM-NEXT: ]
 # INVALID-ENT-SIZE-LLVM:      VersionSymbols [
 # INVALID-ENT-SIZE-LLVM-NEXT: warning: '[[FILE]]': cannot read content of SHT_GNU_versym section with index 1: section [index 1] has invalid sh_entsize: expected 2, but got 3
 # INVALID-ENT-SIZE-LLVM-NEXT: ]
 
 --- !ELF

llvm/tools/llvm-readobj/ELFDumper.cpp

void LLVMELFDumper<ELFT>::printSymbol(const Elf_Sym &Symbol, unsigned SymIndex,
   W.printHex("Value", Symbol.st_value);
   W.printNumber("Size", Symbol.st_size);
   W.printEnum("Binding", Symbol.getBinding(), makeArrayRef(ElfSymbolBindings));
   if (this->Obj.getHeader().e_machine == ELF::EM_AMDGPU &&
       SymbolType >= ELF::STT_LOOS && SymbolType < ELF::STT_HIOS)
     W.printEnum("Type", SymbolType, makeArrayRef(AMDGPUSymbolTypes));
   else
     W.printEnum("Type", SymbolType, makeArrayRef(ElfSymbolTypes));
-  if (Symbol.st_other == 0)
-    // Usually st_other flag is zero. Do not pollute the output
-    // by flags enumeration in that case.
-    W.printNumber("Other", 0);
-  else {
-    std::vector<EnumEntry<unsigned>> SymOtherFlags(std::begin(ElfSymOtherFlags),
-                                                   std::end(ElfSymOtherFlags));
-    if (this->Obj.getHeader().e_machine == EM_MIPS) {
-      // Someones in their infinite wisdom decided to make STO_MIPS_MIPS16
-      // flag overlapped with other ST_MIPS_xxx flags. So consider both
-      // cases separately.
-      if ((Symbol.st_other & STO_MIPS_MIPS16) == STO_MIPS_MIPS16)
-        SymOtherFlags.insert(SymOtherFlags.end(),
-                             std::begin(ElfMips16SymOtherFlags),
-                             std::end(ElfMips16SymOtherFlags));
-      else
-        SymOtherFlags.insert(SymOtherFlags.end(),
-                             std::begin(ElfMipsSymOtherFlags),
-                             std::end(ElfMipsSymOtherFlags));
-    } else if (this->Obj.getHeader().e_machine == EM_AARCH64) {
-      SymOtherFlags.insert(SymOtherFlags.end(),
-                           std::begin(ElfAArch64SymOtherFlags),
-                           std::end(ElfAArch64SymOtherFlags));
-    } else if (this->Obj.getHeader().e_machine == EM_RISCV) {
-      SymOtherFlags.insert(SymOtherFlags.end(),
-                           std::begin(ElfRISCVSymOtherFlags),
-                           std::end(ElfRISCVSymOtherFlags));
-    }
-    W.printFlags("Other", Symbol.st_other, makeArrayRef(SymOtherFlags), 0x3u);
-  }
+
   printSymbolSection(Symbol, SymIndex, ShndxTable);
 }
 
 template <class ELFT>
 void LLVMELFDumper<ELFT>::printSymbols(bool PrintSymbols,
                                        bool PrintDynamicSymbols) {
   if (PrintSymbols) {
     ListScope Group(W, "Symbols");