leonardchan (Leonard Chan)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 25 2018, 1:47 PM (4 w, 2 d)

Recent Activity

Today

leonardchan added inline comments to D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.
Fri, May 25, 11:23 AM · Restricted Project
leonardchan updated the diff for D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.

Changed flag names

Fri, May 25, 11:20 AM · Restricted Project

Yesterday

leonardchan added inline comments to D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.
Thu, May 24, 4:58 PM · Restricted Project
leonardchan updated the diff for D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.

Re-added individual getters/members for _Accum types

Thu, May 24, 4:58 PM · Restricted Project
leonardchan added a comment to D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.
In D46084#1111374, @jfb wrote:

Can you also add a test for _Bool _Accum.

Also, -enable-fixed-point -x c++ failing.

.
Done. Also the failing c++ case is under test/Frontend/fixed_point_errors.cpp

Thu, May 24, 2:20 PM · Restricted Project
leonardchan updated the diff for D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.
  • Added test case for _Bool _Accum
  • Getters for the _Accum bit widths return values for their corresponding integral types (ie. sizeof(short _Accum) == sizeof(short)). The only case where this may not happen is if the target architecture uses 16 bits for an int. N1169 requires that a signed/unsigned _Accum hold at least 15 fractional bits and 4 integral bits. To be able to fit these bits, the size is upgraded to that of a long which is guaranteed to be large enough to hold them.
Thu, May 24, 2:17 PM · Restricted Project
leonardchan updated the diff for D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.
Thu, May 24, 10:55 AM · Restricted Project
leonardchan added inline comments to D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.
Thu, May 24, 10:53 AM · Restricted Project
leonardchan updated the diff for D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.
  • Reverted changes involving name mangling since we will only support c++ for now. Will concurrently raise an issue on https://github.com/itanium-cxx-abi/cxx-abi/ to get characters for name mangling.
  • Added a flag that needs to be provided to enable usage of fixed point types. Not including this flag and using fixed point types throws an error. Currently, this patch allows for these types to be used in all versions of C, but this can be narrowed down to specific versions of C.
  • An error is thrown when using fixed point types in C++.
  • Fixed point types are ignored during USRGeneration since the type only gets mangled in C++.
  • Fixed point types their own width and alignment accessors/variables in TargetInfo.
  • Updated debug info to use DW_ATE_signed_fixed and DW_ATE_unsigned_fixed.
  • Added tests mixing _Accum with other type specifiers
Thu, May 24, 10:47 AM · Restricted Project

Wed, May 23

leonardchan added a comment to D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.

After further discussion, we think the best approach for now would be only supporting fixed point types in C, then go back and support C++ once there is a standardized way for mangling the fixed point types under itanium.

Wed, May 23, 7:59 PM · Restricted Project
leonardchan added inline comments to D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.
Wed, May 23, 5:58 PM · Restricted Project
leonardchan added inline comments to D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.
Wed, May 23, 11:22 AM · Restricted Project
leonardchan updated subscribers of D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.
Wed, May 23, 10:39 AM · Restricted Project

Tue, May 22

leonardchan updated the diff for D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.

pulled changes from source tree

Tue, May 22, 7:47 PM · Restricted Project
leonardchan updated the diff for D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.
Tue, May 22, 3:56 PM · Restricted Project
leonardchan updated the diff for D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.
Tue, May 22, 3:43 PM · Restricted Project
leonardchan updated the diff for D46986: [Fixed Point Arithmetic] Validation Test for Fixed Point Binary Operations and Saturated Addition.
  • formatting
  • Running lli threw a segfault in the test, though this was probably because it was using whatever hist jit was available to optimize the code instead of just interpreting it. Forcing it just interpret fixes this.
Tue, May 22, 3:34 PM · Restricted Project
leonardchan added inline comments to D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.
Tue, May 22, 9:33 AM · Restricted Project
leonardchan updated the diff for D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.
Tue, May 22, 9:30 AM · Restricted Project

Mon, May 21

leonardchan updated the diff for D46979: [Fixed Point Arithmetic] Test for Conversion Between Valid Builtin Types.

formatting

Mon, May 21, 4:30 PM · Restricted Project
leonardchan updated the diff for D46963: [Fixed Point Arithmetic] Test for All Builtin Operations.

formatting

Mon, May 21, 3:22 PM · Restricted Project
leonardchan updated the diff for D46960: [Fixed Point Arithmetic] Predefined Precision Macros.

formatting

Mon, May 21, 2:54 PM · Restricted Project
leonardchan updated the diff for D46927: [Fixed Point Arithmetic] Augmented Assignment for Fixed Point Types.

formatting

Mon, May 21, 2:53 PM · Restricted Project
leonardchan updated the diff for D46926: [Fixed Point Arithmetic] Conversion between Fixed Point and Floating Point Numbers.

formatting

Mon, May 21, 2:52 PM · Restricted Project
leonardchan updated the diff for D46925: [Fixed Point Arithmetic] Remaining Binary Operations on Primary Fixed Point Types.

formatting

Mon, May 21, 2:50 PM · Restricted Project

Fri, May 18

leonardchan updated the diff for D46917: [Fixed Point Arithmetic] Comparison and Unary Operations for Fixed Point Types.

formatting

Fri, May 18, 6:10 PM · Restricted Project
leonardchan updated the diff for D46915: [Fixed Point Arithmetic] Set Fixed Point Precision Bits and Create Fixed Point Literals.

formatting

Fri, May 18, 2:56 PM · Restricted Project
leonardchan updated the diff for D46911: [Fixed Point Arithmetic] Addition of the remaining fixed point types and their saturated equivalents.
Fri, May 18, 11:51 AM · Restricted Project
leonardchan updated the diff for D46911: [Fixed Point Arithmetic] Addition of the remaining fixed point types and their saturated equivalents.
Fri, May 18, 11:31 AM · Restricted Project
leonardchan updated the diff for D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.
Fri, May 18, 11:20 AM · Restricted Project
leonardchan updated the diff for D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.
Fri, May 18, 10:48 AM · Restricted Project
leonardchan updated the diff for D46911: [Fixed Point Arithmetic] Addition of the remaining fixed point types and their saturated equivalents.

Updated formatting

Fri, May 18, 9:55 AM · Restricted Project

Thu, May 17

leonardchan updated the diff for D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.

Undid git-clang-formatting on ASTBitcodes.h

Thu, May 17, 4:06 PM · Restricted Project
leonardchan added inline comments to D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.
Thu, May 17, 3:41 PM · Restricted Project
leonardchan updated the diff for D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.

Added break. We still assign Result since it cannot be null at the end of the switch stmt, though the value doesn't matter.

Thu, May 17, 3:39 PM · Restricted Project
leonardchan updated the diff for D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.

Ran git-clang-tidy on all affected files

Thu, May 17, 1:57 PM · Restricted Project
leonardchan added a dependent revision for D47030: [Fixed Point Arithmetic] Checks for Precision Macros: D47017: [Fixed Point Arithmetic] Validation Test for Saturated Shift Left, Saturated Unsigned _Fract Types, and Fix for Saturated Unsigned Addition.
Thu, May 17, 1:27 PM · Restricted Project
leonardchan added a dependency for D47017: [Fixed Point Arithmetic] Validation Test for Saturated Shift Left, Saturated Unsigned _Fract Types, and Fix for Saturated Unsigned Addition: D47030: [Fixed Point Arithmetic] Checks for Precision Macros.
Thu, May 17, 1:27 PM · Restricted Project
leonardchan updated the summary of D47017: [Fixed Point Arithmetic] Validation Test for Saturated Shift Left, Saturated Unsigned _Fract Types, and Fix for Saturated Unsigned Addition.
Thu, May 17, 1:27 PM · Restricted Project
leonardchan added a dependent revision for D47017: [Fixed Point Arithmetic] Validation Test for Saturated Shift Left, Saturated Unsigned _Fract Types, and Fix for Saturated Unsigned Addition: D47016: [Fixed Point Arithmetic] Validation Test for Saturated Division and Comparison Fix.
Thu, May 17, 1:26 PM · Restricted Project
leonardchan added a dependency for D47016: [Fixed Point Arithmetic] Validation Test for Saturated Division and Comparison Fix: D47017: [Fixed Point Arithmetic] Validation Test for Saturated Shift Left, Saturated Unsigned _Fract Types, and Fix for Saturated Unsigned Addition.
Thu, May 17, 1:26 PM · Restricted Project
leonardchan updated the summary of D47016: [Fixed Point Arithmetic] Validation Test for Saturated Division and Comparison Fix.
Thu, May 17, 1:26 PM · Restricted Project
leonardchan added a dependency for D46990: [Fixed Point Arithmetic] Validation Test for Saturated Multiplication: D47016: [Fixed Point Arithmetic] Validation Test for Saturated Division and Comparison Fix.
Thu, May 17, 1:26 PM · Restricted Project
leonardchan added a dependent revision for D47016: [Fixed Point Arithmetic] Validation Test for Saturated Division and Comparison Fix: D46990: [Fixed Point Arithmetic] Validation Test for Saturated Multiplication.
Thu, May 17, 1:26 PM · Restricted Project
leonardchan updated the summary of D46990: [Fixed Point Arithmetic] Validation Test for Saturated Multiplication.
Thu, May 17, 1:26 PM · Restricted Project
leonardchan added a dependent revision for D46990: [Fixed Point Arithmetic] Validation Test for Saturated Multiplication: D46987: [Fixed Point Arithmetic] Validation Test for Saturated Subtraction on Signed _Fracts.
Thu, May 17, 1:25 PM · Restricted Project
leonardchan added a dependency for D46987: [Fixed Point Arithmetic] Validation Test for Saturated Subtraction on Signed _Fracts: D46990: [Fixed Point Arithmetic] Validation Test for Saturated Multiplication.
Thu, May 17, 1:25 PM · Restricted Project
leonardchan updated the summary of D46987: [Fixed Point Arithmetic] Validation Test for Saturated Subtraction on Signed _Fracts.
Thu, May 17, 1:25 PM · Restricted Project
leonardchan added a dependent revision for D46987: [Fixed Point Arithmetic] Validation Test for Saturated Subtraction on Signed _Fracts: D46986: [Fixed Point Arithmetic] Validation Test for Fixed Point Binary Operations and Saturated Addition.
Thu, May 17, 1:25 PM · Restricted Project
leonardchan added a dependency for D46986: [Fixed Point Arithmetic] Validation Test for Fixed Point Binary Operations and Saturated Addition: D46987: [Fixed Point Arithmetic] Validation Test for Saturated Subtraction on Signed _Fracts.
Thu, May 17, 1:25 PM · Restricted Project
leonardchan updated the summary of D46986: [Fixed Point Arithmetic] Validation Test for Fixed Point Binary Operations and Saturated Addition.
Thu, May 17, 1:23 PM · Restricted Project
leonardchan added a dependency for D46979: [Fixed Point Arithmetic] Test for Conversion Between Valid Builtin Types: D46986: [Fixed Point Arithmetic] Validation Test for Fixed Point Binary Operations and Saturated Addition.
Thu, May 17, 1:23 PM · Restricted Project
leonardchan added a dependent revision for D46986: [Fixed Point Arithmetic] Validation Test for Fixed Point Binary Operations and Saturated Addition: D46979: [Fixed Point Arithmetic] Test for Conversion Between Valid Builtin Types.
Thu, May 17, 1:23 PM · Restricted Project
leonardchan updated the summary of D46979: [Fixed Point Arithmetic] Test for Conversion Between Valid Builtin Types.
Thu, May 17, 1:23 PM · Restricted Project
leonardchan added a dependent revision for D46979: [Fixed Point Arithmetic] Test for Conversion Between Valid Builtin Types: D46963: [Fixed Point Arithmetic] Test for All Builtin Operations.
Thu, May 17, 1:22 PM · Restricted Project
leonardchan added a dependency for D46963: [Fixed Point Arithmetic] Test for All Builtin Operations: D46979: [Fixed Point Arithmetic] Test for Conversion Between Valid Builtin Types.
Thu, May 17, 1:22 PM · Restricted Project
leonardchan updated the summary of D46963: [Fixed Point Arithmetic] Test for All Builtin Operations.
Thu, May 17, 1:22 PM · Restricted Project
leonardchan added a dependency for D46960: [Fixed Point Arithmetic] Predefined Precision Macros: D46963: [Fixed Point Arithmetic] Test for All Builtin Operations.
Thu, May 17, 1:22 PM · Restricted Project
leonardchan added a dependent revision for D46963: [Fixed Point Arithmetic] Test for All Builtin Operations: D46960: [Fixed Point Arithmetic] Predefined Precision Macros.
Thu, May 17, 1:22 PM · Restricted Project
leonardchan updated the summary of D46960: [Fixed Point Arithmetic] Predefined Precision Macros.
Thu, May 17, 1:21 PM · Restricted Project
leonardchan added a dependency for D46927: [Fixed Point Arithmetic] Augmented Assignment for Fixed Point Types: D46960: [Fixed Point Arithmetic] Predefined Precision Macros.
Thu, May 17, 1:21 PM · Restricted Project
leonardchan added a dependent revision for D46960: [Fixed Point Arithmetic] Predefined Precision Macros: D46927: [Fixed Point Arithmetic] Augmented Assignment for Fixed Point Types.
Thu, May 17, 1:21 PM · Restricted Project
leonardchan updated the summary of D46927: [Fixed Point Arithmetic] Augmented Assignment for Fixed Point Types.
Thu, May 17, 1:21 PM · Restricted Project
leonardchan added a dependency for D46926: [Fixed Point Arithmetic] Conversion between Fixed Point and Floating Point Numbers: D46927: [Fixed Point Arithmetic] Augmented Assignment for Fixed Point Types.
Thu, May 17, 1:21 PM · Restricted Project
leonardchan added a dependent revision for D46927: [Fixed Point Arithmetic] Augmented Assignment for Fixed Point Types: D46926: [Fixed Point Arithmetic] Conversion between Fixed Point and Floating Point Numbers.
Thu, May 17, 1:21 PM · Restricted Project
leonardchan updated the summary of D46926: [Fixed Point Arithmetic] Conversion between Fixed Point and Floating Point Numbers.
Thu, May 17, 1:20 PM · Restricted Project
leonardchan added a dependent revision for D46926: [Fixed Point Arithmetic] Conversion between Fixed Point and Floating Point Numbers: D46925: [Fixed Point Arithmetic] Remaining Binary Operations on Primary Fixed Point Types.
Thu, May 17, 1:20 PM · Restricted Project
leonardchan added a dependency for D46925: [Fixed Point Arithmetic] Remaining Binary Operations on Primary Fixed Point Types: D46926: [Fixed Point Arithmetic] Conversion between Fixed Point and Floating Point Numbers.
Thu, May 17, 1:20 PM · Restricted Project
leonardchan updated the summary of D46925: [Fixed Point Arithmetic] Remaining Binary Operations on Primary Fixed Point Types.
Thu, May 17, 1:20 PM · Restricted Project
leonardchan added a dependency for D46917: [Fixed Point Arithmetic] Comparison and Unary Operations for Fixed Point Types: D46925: [Fixed Point Arithmetic] Remaining Binary Operations on Primary Fixed Point Types.
Thu, May 17, 1:19 PM · Restricted Project
leonardchan added a dependent revision for D46925: [Fixed Point Arithmetic] Remaining Binary Operations on Primary Fixed Point Types: D46917: [Fixed Point Arithmetic] Comparison and Unary Operations for Fixed Point Types.
Thu, May 17, 1:19 PM · Restricted Project
leonardchan updated the summary of D46917: [Fixed Point Arithmetic] Comparison and Unary Operations for Fixed Point Types.
Thu, May 17, 1:18 PM · Restricted Project
leonardchan added a dependency for D46915: [Fixed Point Arithmetic] Set Fixed Point Precision Bits and Create Fixed Point Literals: D46917: [Fixed Point Arithmetic] Comparison and Unary Operations for Fixed Point Types.
Thu, May 17, 1:18 PM · Restricted Project
leonardchan added a dependent revision for D46917: [Fixed Point Arithmetic] Comparison and Unary Operations for Fixed Point Types: D46915: [Fixed Point Arithmetic] Set Fixed Point Precision Bits and Create Fixed Point Literals.
Thu, May 17, 1:18 PM · Restricted Project
leonardchan added a dependency for D46911: [Fixed Point Arithmetic] Addition of the remaining fixed point types and their saturated equivalents: D46915: [Fixed Point Arithmetic] Set Fixed Point Precision Bits and Create Fixed Point Literals.
Thu, May 17, 1:17 PM · Restricted Project
leonardchan updated the summary of D46915: [Fixed Point Arithmetic] Set Fixed Point Precision Bits and Create Fixed Point Literals.
Thu, May 17, 1:17 PM · Restricted Project
leonardchan added a dependent revision for D46915: [Fixed Point Arithmetic] Set Fixed Point Precision Bits and Create Fixed Point Literals: D46911: [Fixed Point Arithmetic] Addition of the remaining fixed point types and their saturated equivalents.
Thu, May 17, 1:17 PM · Restricted Project
leonardchan updated the summary of D46911: [Fixed Point Arithmetic] Addition of the remaining fixed point types and their saturated equivalents.
Thu, May 17, 1:17 PM · Restricted Project
leonardchan added a dependent revision for D46911: [Fixed Point Arithmetic] Addition of the remaining fixed point types and their saturated equivalents: D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.
Thu, May 17, 1:13 PM · Restricted Project
leonardchan added a dependency for D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type: D46911: [Fixed Point Arithmetic] Addition of the remaining fixed point types and their saturated equivalents.
Thu, May 17, 1:13 PM · Restricted Project
leonardchan removed a dependency for D46911: [Fixed Point Arithmetic] Addition of the remaining fixed point types and their saturated equivalents: D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.
Thu, May 17, 1:12 PM · Restricted Project
leonardchan removed a dependent revision for D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type: D46911: [Fixed Point Arithmetic] Addition of the remaining fixed point types and their saturated equivalents.
Thu, May 17, 1:12 PM · Restricted Project
leonardchan added a dependency for D46911: [Fixed Point Arithmetic] Addition of the remaining fixed point types and their saturated equivalents: D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.
Thu, May 17, 1:09 PM · Restricted Project
leonardchan added a dependent revision for D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type: D46911: [Fixed Point Arithmetic] Addition of the remaining fixed point types and their saturated equivalents.
Thu, May 17, 1:09 PM · Restricted Project
leonardchan created D47030: [Fixed Point Arithmetic] Checks for Precision Macros.
Thu, May 17, 1:05 PM · Restricted Project
leonardchan created D47017: [Fixed Point Arithmetic] Validation Test for Saturated Shift Left, Saturated Unsigned _Fract Types, and Fix for Saturated Unsigned Addition.
Thu, May 17, 8:24 AM · Restricted Project
leonardchan created D47016: [Fixed Point Arithmetic] Validation Test for Saturated Division and Comparison Fix.
Thu, May 17, 7:59 AM · Restricted Project

Wed, May 16

leonardchan created D46990: [Fixed Point Arithmetic] Validation Test for Saturated Multiplication.
Wed, May 16, 4:52 PM · Restricted Project
leonardchan updated the summary of D46987: [Fixed Point Arithmetic] Validation Test for Saturated Subtraction on Signed _Fracts.
Wed, May 16, 4:37 PM · Restricted Project
leonardchan updated the summary of D46986: [Fixed Point Arithmetic] Validation Test for Fixed Point Binary Operations and Saturated Addition.
Wed, May 16, 4:16 PM · Restricted Project
leonardchan created D46987: [Fixed Point Arithmetic] Validation Test for Saturated Subtraction on Signed _Fracts.
Wed, May 16, 4:03 PM · Restricted Project
leonardchan created D46986: [Fixed Point Arithmetic] Validation Test for Fixed Point Binary Operations and Saturated Addition.
Wed, May 16, 3:47 PM · Restricted Project
leonardchan created D46979: [Fixed Point Arithmetic] Test for Conversion Between Valid Builtin Types.
Wed, May 16, 2:56 PM · Restricted Project
leonardchan updated the diff for D46963: [Fixed Point Arithmetic] Test for All Builtin Operations.
Wed, May 16, 10:48 AM · Restricted Project
leonardchan created D46963: [Fixed Point Arithmetic] Test for All Builtin Operations.
Wed, May 16, 10:31 AM · Restricted Project
leonardchan created D46960: [Fixed Point Arithmetic] Predefined Precision Macros.
Wed, May 16, 9:54 AM · Restricted Project
leonardchan retitled D46927: [Fixed Point Arithmetic] Augmented Assignment for Fixed Point Types from Augmented Assignment for Fixed Point Types to [Fixed Point Arithmetic] Augmented Assignment for Fixed Point Types.
Wed, May 16, 9:42 AM · Restricted Project
leonardchan retitled D46926: [Fixed Point Arithmetic] Conversion between Fixed Point and Floating Point Numbers from Conversion between Fixed Point and Floating Point Numbers to [Fixed Point Arithmetic] Conversion between Fixed Point and Floating Point Numbers.
Wed, May 16, 9:42 AM · Restricted Project
leonardchan retitled D46925: [Fixed Point Arithmetic] Remaining Binary Operations on Primary Fixed Point Types from Remaining Binary Operations on Primary Fixed Point Types to [Fixed Point Arithmetic] Remaining Binary Operations on Primary Fixed Point Types.
Wed, May 16, 9:42 AM · Restricted Project
leonardchan retitled D46917: [Fixed Point Arithmetic] Comparison and Unary Operations for Fixed Point Types from Comparison and Unary Operations for Fixed Point Types to [Fixed Point Arithmetic] Comparison and Unary Operations for Fixed Point Types.
Wed, May 16, 9:42 AM · Restricted Project