Page MenuHomePhabricator

leonardchan (Leonard Chan)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 25 2018, 1:47 PM (47 w, 1 d)

Recent Activity

Thu, Mar 7

leonardchan added inline comments to D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
Thu, Mar 7, 5:11 PM · Restricted Project
leonardchan updated the diff for D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
Thu, Mar 7, 5:11 PM · Restricted Project
leonardchan removed a parent revision for D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic: D59119: [SelectionDAG] Check legality for ADDCARRY in expandMUL_LOHI.
Thu, Mar 7, 5:06 PM · Restricted Project
leonardchan added a parent revision for D59119: [SelectionDAG] Check legality for ADDCARRY in expandMUL_LOHI: D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
Thu, Mar 7, 5:06 PM · Restricted Project
leonardchan added a child revision for D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic: D59119: [SelectionDAG] Check legality for ADDCARRY in expandMUL_LOHI.
Thu, Mar 7, 5:06 PM · Restricted Project
leonardchan removed a child revision for D59119: [SelectionDAG] Check legality for ADDCARRY in expandMUL_LOHI: D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
Thu, Mar 7, 5:06 PM · Restricted Project
leonardchan added a child revision for D59119: [SelectionDAG] Check legality for ADDCARRY in expandMUL_LOHI: D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
Thu, Mar 7, 5:03 PM · Restricted Project
leonardchan added a parent revision for D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic: D59119: [SelectionDAG] Check legality for ADDCARRY in expandMUL_LOHI.
Thu, Mar 7, 5:03 PM · Restricted Project
leonardchan created D59119: [SelectionDAG] Check legality for ADDCARRY in expandMUL_LOHI.
Thu, Mar 7, 5:02 PM · Restricted Project

Wed, Mar 6

leonardchan added a comment to D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.

*ping*

Wed, Mar 6, 1:47 PM · Restricted Project
leonardchan updated the diff for D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
Wed, Mar 6, 1:47 PM · Restricted Project

Tue, Mar 5

leonardchan committed rG8f7caae00af0: [Fixed Point Arithmetic] Fixed Point and Integer Conversions (authored by leonardchan).
[Fixed Point Arithmetic] Fixed Point and Integer Conversions
Tue, Mar 5, 4:29 PM
leonardchan committed rL355462: [Fixed Point Arithmetic] Fixed Point and Integer Conversions.
[Fixed Point Arithmetic] Fixed Point and Integer Conversions
Tue, Mar 5, 4:28 PM
leonardchan committed rC355462: [Fixed Point Arithmetic] Fixed Point and Integer Conversions.
[Fixed Point Arithmetic] Fixed Point and Integer Conversions
Tue, Mar 5, 4:28 PM
leonardchan closed D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions.
Tue, Mar 5, 4:27 PM · Restricted Project
leonardchan added inline comments to D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions.
Tue, Mar 5, 4:26 PM · Restricted Project
leonardchan updated the diff for D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions.
Tue, Mar 5, 4:26 PM · Restricted Project

Fri, Mar 1

leonardchan updated the diff for D58321: [WIP] Support for relative vtables.
  • Remove hasHiddenLTOVisibility from CXXRecordDecl and rename the flag to -frelative-c++-abi-vtables
Fri, Mar 1, 3:23 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D58321: [WIP] Support for relative vtables.
Fri, Mar 1, 2:13 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D58321: [WIP] Support for relative vtables.

Update to current working version without needing LTO

Fri, Mar 1, 2:08 PM · Restricted Project, Restricted Project

Tue, Feb 26

leonardchan added a comment to D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions.

@rjmccall @ebevhan @bjope *ping* any other comments on this patch?

Tue, Feb 26, 11:41 AM · Restricted Project

Mon, Feb 25

leonardchan added a comment to D58321: [WIP] Support for relative vtables.
In D58321#1407362, @pcc wrote:

Can we start with a patch that just exposes a flag that enables the relative ABI unconditionally, and remove all the platform ABI compatibility stuff?

Mon, Feb 25, 2:01 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D58321: [WIP] Support for relative vtables.
Mon, Feb 25, 2:01 PM · Restricted Project, Restricted Project

Fri, Feb 22

leonardchan added a comment to D20749: Introduce support for relative C++ ABI gated on LTO visibility..

Hi @pcc , I'm working on revisiting this to see if this could help when building Fuchsia (D58321) and had a few questions I left inline.

Fri, Feb 22, 11:43 AM
leonardchan updated the summary of D58321: [WIP] Support for relative vtables.
Fri, Feb 22, 11:35 AM · Restricted Project, Restricted Project
leonardchan added inline comments to D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
Fri, Feb 22, 11:30 AM · Restricted Project
leonardchan updated the diff for D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
Fri, Feb 22, 11:30 AM · Restricted Project

Thu, Feb 21

leonardchan accepted D57226: [Fixed Point] [AST] Add an AST serialization code for fixed-point literals..

LGTM. Everything still seems to work on my end after applying this diff.

Thu, Feb 21, 3:19 PM · Restricted Project
leonardchan retitled D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration from [Attribute/Diagnostics] Print macro instead of whole attribute for address_space to [Attribute/Diagnostics] Print macro if definition is an attribute declaration.
Thu, Feb 21, 2:06 PM · Restricted Project
leonardchan committed rGce1d4f1bec41: [Fixed Point Arithmetic] Fixed Point Comparisons (authored by leonardchan).
[Fixed Point Arithmetic] Fixed Point Comparisons
Thu, Feb 21, 12:51 PM
leonardchan committed rL354621: [Fixed Point Arithmetic] Fixed Point Comparisons.
[Fixed Point Arithmetic] Fixed Point Comparisons
Thu, Feb 21, 12:49 PM
leonardchan committed rC354621: [Fixed Point Arithmetic] Fixed Point Comparisons.
[Fixed Point Arithmetic] Fixed Point Comparisons
Thu, Feb 21, 12:49 PM
leonardchan closed D57219: [Fixed Point Arithmetic] Fixed Point Comparisons.
Thu, Feb 21, 12:49 PM · Restricted Project
leonardchan updated subscribers of D57219: [Fixed Point Arithmetic] Fixed Point Comparisons.

*ping* @bevinh @rjmccall @bjope Any other comments on this patch?

Thu, Feb 21, 10:11 AM · Restricted Project

Wed, Feb 20

leonardchan added a comment to D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.

Oh I forgot to submit these inline comments

Wed, Feb 20, 5:59 PM · Restricted Project
leonardchan added inline comments to D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions.
Wed, Feb 20, 5:54 PM · Restricted Project
leonardchan added inline comments to D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions.
Wed, Feb 20, 5:53 PM · Restricted Project
leonardchan updated the diff for D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions.
Wed, Feb 20, 5:53 PM · Restricted Project

Tue, Feb 19

leonardchan committed rGa07f1b94e49c: Limit new PM tests to X86 registered targets. (authored by leonardchan).
Limit new PM tests to X86 registered targets.
Tue, Feb 19, 9:07 PM
leonardchan committed rC354435: Limit new PM tests to X86 registered targets..
Limit new PM tests to X86 registered targets.
Tue, Feb 19, 9:07 PM
leonardchan committed rL354435: Limit new PM tests to X86 registered targets..
Limit new PM tests to X86 registered targets.
Tue, Feb 19, 9:07 PM
leonardchan committed rGb94dde7f9bc9: Remove test on incompatible mpis target. (authored by leonardchan).
Remove test on incompatible mpis target.
Tue, Feb 19, 8:35 PM
leonardchan committed rC354432: Remove test on incompatible mpis target..
Remove test on incompatible mpis target.
Tue, Feb 19, 8:35 PM
leonardchan committed rL354432: Remove test on incompatible mpis target..
Remove test on incompatible mpis target.
Tue, Feb 19, 8:34 PM
leonardchan committed rG1a240ed25d68: [NewPM] Add other sanitizers at O0 (authored by leonardchan).
[NewPM] Add other sanitizers at O0
Tue, Feb 19, 7:50 PM
leonardchan committed rC354431: [NewPM] Add other sanitizers at O0.
[NewPM] Add other sanitizers at O0
Tue, Feb 19, 7:50 PM
leonardchan committed rL354431: [NewPM] Add other sanitizers at O0.
[NewPM] Add other sanitizers at O0
Tue, Feb 19, 7:50 PM
leonardchan closed D58424: [NewPM] Add other sanitizers at O0.
Tue, Feb 19, 7:50 PM · Restricted Project, Restricted Project
leonardchan added a comment to D57793: [NewPM][MSan] Add sanitizer at O0.

Will need to be rebased after rC353985. Should this also include tsan, unless this is just for msan specifically?

Yeah, I suspect so. If you want, maybe take this over? Would be great to get this landed.

Tue, Feb 19, 6:59 PM · Restricted Project
leonardchan created D58424: [NewPM] Add other sanitizers at O0.
Tue, Feb 19, 6:58 PM · Restricted Project, Restricted Project
leonardchan abandoned D54337: [ASan] Make AddressSanitizer a ModulePass.

Addressed in rC353985

Tue, Feb 19, 6:48 PM · Restricted Project, Restricted Project
leonardchan abandoned D53745: [ASan] Separate Initialization from AddressSanitizer Constructor.

Addressed in rC353985

Tue, Feb 19, 6:48 PM · Restricted Project
leonardchan added a comment to D57793: [NewPM][MSan] Add sanitizer at O0.

Will need to be rebased after rC353985. Should this also include tsan?

Tue, Feb 19, 5:36 PM · Restricted Project

Feb 15 2019

leonardchan created D58321: [WIP] Support for relative vtables.
Feb 15 2019, 11:49 PM · Restricted Project, Restricted Project

Feb 13 2019

leonardchan accepted D58214: [CMake][Fuchsia] Enable experimental pass manager by default.

LGTM. Doesn't seem to break anything as far as I can see.

Feb 13 2019, 8:36 PM · Restricted Project
leonardchan committed rG619b6d537855: Fix for asan bots (authored by leonardchan).
Fix for asan bots
Feb 13 2019, 5:08 PM
leonardchan committed rC353999: Fix for asan bots.
Fix for asan bots
Feb 13 2019, 5:07 PM
leonardchan committed rL353999: Fix for asan bots.
Fix for asan bots
Feb 13 2019, 5:07 PM
leonardchan committed rG436fb2bd82a7: [NewPM] Second attempt at porting ASan (authored by leonardchan).
[NewPM] Second attempt at porting ASan
Feb 13 2019, 2:23 PM
leonardchan committed rL353985: [NewPM] Second attempt at porting ASan.
[NewPM] Second attempt at porting ASan
Feb 13 2019, 2:22 PM
leonardchan committed rC353985: [NewPM] Second attempt at porting ASan.
[NewPM] Second attempt at porting ASan
Feb 13 2019, 2:22 PM
leonardchan closed D56470: [NewPM] Second attempt at porting ASan.
Feb 13 2019, 2:22 PM · Restricted Project, Restricted Project
leonardchan added inline comments to D56470: [NewPM] Second attempt at porting ASan.
Feb 13 2019, 2:18 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D56470: [NewPM] Second attempt at porting ASan.
Feb 13 2019, 2:18 PM · Restricted Project, Restricted Project

Feb 11 2019

leonardchan added a comment to D56470: [NewPM] Second attempt at porting ASan.

It's still missing the O0 part. I forgot adding it for msan and tsan, but we should do asan correctly from the start.

Feb 11 2019, 7:49 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D56470: [NewPM] Second attempt at porting ASan.
Feb 11 2019, 7:47 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.

Fixed mistake related to saturation during expansion. When we promote the operand and result type widths, this also changes the saturation width and affects the min/max values we compare against. This is easily solved by also shifting one of the operands after extension.

Feb 11 2019, 5:00 PM · Restricted Project

Feb 8 2019

leonardchan updated the diff for D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
Feb 8 2019, 3:16 PM · Restricted Project
leonardchan added a comment to D56470: [NewPM] Second attempt at porting ASan.

*ping* @philip.pfaffe Any last comments on this?

Feb 8 2019, 9:55 AM · Restricted Project, Restricted Project

Feb 7 2019

leonardchan abandoned D57553: [Fixed Point Arithmetic] Avoid resizing for types with the same width.

In regards to solving the problem of resizing for int conversions, I'm starting to think that we will need that initial resize since if we want to retain the min-max pattern for all conversions, then it would be necessary to extend and shift when converting from an int to fixed point. Otherwise, I think we'd have the initial pattern I proposed where we check against the source value, but not have this pattern.

Yes, I'm starting to think so too. It's just not possible to not resize and keep the minmax pattern at the same time. We can't upshift without resizing first (because any bits above the scale can affect saturation), and if we wanted to saturate purely on the non-rescaled value, then the (mandatory) rescaling after saturation could destroy the possibly saturated result (since it would shift in zeroes from the right if upscaling, which breaks the result if it saturated to max).

Sorry for going down this path, that was rather pointless.

Feb 7 2019, 12:38 PM · Restricted Project

Feb 6 2019

leonardchan added a parent revision for D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic: D57836: [Intrinsic] Unsigned Fixed Point Saturation Multiplication Intrinsic.
Feb 6 2019, 12:27 PM · Restricted Project
leonardchan added a child revision for D57836: [Intrinsic] Unsigned Fixed Point Saturation Multiplication Intrinsic: D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
Feb 6 2019, 12:27 PM · Restricted Project
leonardchan created D57836: [Intrinsic] Unsigned Fixed Point Saturation Multiplication Intrinsic.
Feb 6 2019, 12:26 PM · Restricted Project

Feb 4 2019

leonardchan added inline comments to D56470: [NewPM] Second attempt at porting ASan.
Feb 4 2019, 3:35 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D56470: [NewPM] Second attempt at porting ASan.
Feb 4 2019, 3:33 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D56470: [NewPM] Second attempt at porting ASan.
Feb 4 2019, 12:46 PM · Restricted Project, Restricted Project
leonardchan added a comment to D56470: [NewPM] Second attempt at porting ASan.

Updated. Before submitting, @chandlerc would you mind taking one last look at this to make sure everything is in order? I wouldn't want to accidentally cause another ASan related timeout.

Feb 4 2019, 12:45 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D56470: [NewPM] Second attempt at porting ASan.
Feb 4 2019, 12:41 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
Feb 4 2019, 11:20 AM · Restricted Project
leonardchan updated the diff for D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.

Updated and rebased

Feb 4 2019, 10:28 AM · Restricted Project
leonardchan committed rG68d428e57894: [Intrinsic] Unsigned Fixed Point Multiplication Intrinsic (authored by leonardchan).
[Intrinsic] Unsigned Fixed Point Multiplication Intrinsic
Feb 4 2019, 9:19 AM
leonardchan committed rL353059: [Intrinsic] Unsigned Fixed Point Multiplication Intrinsic.
[Intrinsic] Unsigned Fixed Point Multiplication Intrinsic
Feb 4 2019, 9:18 AM
leonardchan closed D55625: [Intrinsic] Unsigned Fixed Point Multiplication Intrinsic.
Feb 4 2019, 9:18 AM · Restricted Project

Feb 1 2019

leonardchan added a comment to D57553: [Fixed Point Arithmetic] Avoid resizing for types with the same width.

This doesn't seem to address the particular case in the integer conversion patch. In fact, I don't see those conversions at all.

Feb 1 2019, 8:48 PM · Restricted Project
leonardchan updated the diff for D57553: [Fixed Point Arithmetic] Avoid resizing for types with the same width.
Feb 1 2019, 8:26 PM · Restricted Project
leonardchan added inline comments to D57219: [Fixed Point Arithmetic] Fixed Point Comparisons.
Feb 1 2019, 8:00 PM · Restricted Project
leonardchan updated the diff for D57219: [Fixed Point Arithmetic] Fixed Point Comparisons.
Feb 1 2019, 8:00 PM · Restricted Project

Jan 31 2019

leonardchan added inline comments to D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions.
Jan 31 2019, 4:00 PM · Restricted Project
leonardchan added a parent revision for D57553: [Fixed Point Arithmetic] Avoid resizing for types with the same width: D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions.
Jan 31 2019, 3:59 PM · Restricted Project
leonardchan added a child revision for D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions: D57553: [Fixed Point Arithmetic] Avoid resizing for types with the same width.
Jan 31 2019, 3:59 PM · Restricted Project
leonardchan created D57553: [Fixed Point Arithmetic] Avoid resizing for types with the same width.
Jan 31 2019, 3:59 PM · Restricted Project
leonardchan added inline comments to D57219: [Fixed Point Arithmetic] Fixed Point Comparisons.
Jan 31 2019, 2:38 PM · Restricted Project
leonardchan updated the diff for D57219: [Fixed Point Arithmetic] Fixed Point Comparisons.
Jan 31 2019, 2:37 PM · Restricted Project
leonardchan added inline comments to D56470: [NewPM] Second attempt at porting ASan.
Jan 31 2019, 1:58 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D56470: [NewPM] Second attempt at porting ASan.
Jan 31 2019, 1:58 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D55625: [Intrinsic] Unsigned Fixed Point Multiplication Intrinsic.

Updated and rebased

Jan 31 2019, 11:54 AM · Restricted Project
leonardchan added a comment to D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.

Updated and rebased

Jan 31 2019, 11:36 AM · Restricted Project
leonardchan updated the diff for D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
Jan 31 2019, 11:35 AM · Restricted Project
leonardchan committed rL352783: [Intrinsic] Expand SMULFIX to MUL, MULH[US], or [US]MUL_LOHI on vector arguments.
[Intrinsic] Expand SMULFIX to MUL, MULH[US], or [US]MUL_LOHI on vector arguments
Jan 31 2019, 11:15 AM
leonardchan closed D56987: [Intrinsic] Expand SMULFIX to MUL, MULH[US], or [US]MUL_LOHI on vector arguments.
Jan 31 2019, 11:15 AM