- User Since
- Apr 25 2018, 1:47 PM (125 w, 4 d)
Mon, Aug 31
*ping* @aaron.ballman. Would you be able to sign off on this? Otherwise, I'll probably commit this in the next few days.
Fri, Aug 28
- Renamed unnamedfunc to unnamed_func.
- Replaced "equivalent to the resolved function at runtime" with "equivalent to the resolved function as a call target".
- Added section to LangRef.
The IR differences were caused by the new pass manager which is on by default for the Fuchsia builder. I've re-landed the patch with a fix for CodeGen/attr-arm-sve-vector-bits-call.c to use the legacy pm with -fno-experimental-new-pass-manager.
Thu, Aug 27
Update to reflect comments in the RFC.
Hi! The attr-arm-sve-vector-bits-call.c test seems to be failing on our clang builders:
Hi! I believe our mac builders are failing after this change with
Wed, Aug 26
Aug 21 2020
Aug 20 2020
Clean up some of the code.
Aug 18 2020
Aug 17 2020
Aug 14 2020
CC @aaron.ballman who committed Features.def for signing off or knowing someone who can sign off.
Hi. I believe this patch is incompatible with cmake 3.13.5. We're seeing
Aug 13 2020
Store a TargetCXXABI::Kind instead of a string in LangOpts.
Aug 12 2020
Ok. Ready for review!
- Check for lowercase flag values
- Remove fuchsia-specific changes
Aug 11 2020
Aug 10 2020
LGTM for LLVM readability.
The patch seems straightforward. Other than moving code and trimming llvm:: from types, not sure if there's anything else I should expect. LGTM.
Aug 7 2020
Jul 28 2020
Jul 27 2020
Jul 22 2020
Jul 20 2020
Add a method to TargetCodeGenInfo the returns if the target supports PC relative PLT relocations,
Jul 17 2020
Hello. This test seems to be failing for us (https://luci-milo.appspot.com/p/fuchsia/builders/ci/clang-linux-x64/b8874608488579495664?) and other builders that use the new pass manager (http://lab.llvm.org:8011/builders/clang-x86_64-debian-new-pass-manager-fast/builds/11949). Would you mind updating the test or reverting for now? Thanks.
Jul 16 2020
Jul 14 2020
Jul 13 2020
Jul 9 2020
It wouldn't just be restricted to fixed-point intrinsics, though. It would have to be added to intrinsics like uadd.sat and usub.sat as well, which aren't really tied to fixed-point at all.
Jul 8 2020
Jun 29 2020
Jun 26 2020
LGTM. Thanks for the fix.
Jun 25 2020
Jun 23 2020
Jun 22 2020
Jun 11 2020
Rebased and updated tests with assembly instead of yaml.
Jun 10 2020
Jun 9 2020
Lemme know if there's any more feedback. Will aim for committing this sometime at the end of the day.
Jun 8 2020
D81446 is the LLVM counterpart.
- Removed the llvm changes to be moved to a separate patch.
- Added a test for checking the relocation used with an undefined weak symbol. IIRC, the behavior of this is unspecified anyway.
- Added test for checking overflow.
Jun 4 2020
Jun 1 2020
May 29 2020
Hi! I think this patch might be the cause of the bug at https://bugs.llvm.org/show_bug.cgi?id=46137.
May 28 2020
Would be worthwhile to write a small test that asserts Sancov runs before the other sanitizers under the new PM?