Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

leonardchan (Leonard Chan)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 25 2018, 1:47 PM (283 w, 2 d)

Recent Activity

Thu, Sep 28

leonardchan committed rG6a2bc488134d: [compiler-rt][asan][Fuchsia] Tune the 64-bit asan allocator for riscv+fuchsia (authored by leonardchan).
[compiler-rt][asan][Fuchsia] Tune the 64-bit asan allocator for riscv+fuchsia
Thu, Sep 28, 12:00 PM · Restricted Project, Restricted Project
leonardchan closed D151157: [compiler-rt][asan][Fuchsia] Tune the 64-bit asan allocator for riscv+fuchsia.
Thu, Sep 28, 12:00 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D151157: [compiler-rt][asan][Fuchsia] Tune the 64-bit asan allocator for riscv+fuchsia.
Thu, Sep 28, 11:54 AM · Restricted Project, Restricted Project

Thu, Sep 14

leonardchan committed rG4db6803dc799: [lsan][fuchsia] Add extra check for allocator cache to avoid overflow (authored by leonardchan).
[lsan][fuchsia] Add extra check for allocator cache to avoid overflow
Thu, Sep 14, 4:05 PM · Restricted Project, Restricted Project
leonardchan closed D159518: [lsan][fuchsia] Add extra check for allocator cache to avoid overflow.
Thu, Sep 14, 4:05 PM · Restricted Project, Restricted Project
leonardchan requested review of D159518: [lsan][fuchsia] Add extra check for allocator cache to avoid overflow.
Thu, Sep 14, 3:19 PM · Restricted Project, Restricted Project
leonardchan committed rGf45f1c3585e6: Reland "[clang] Add experimental option to omit the RTTI component from the… (authored by leonardchan).
Reland "[clang] Add experimental option to omit the RTTI component from the…
Thu, Sep 14, 11:29 AM · Restricted Project, Restricted Project
leonardchan added a reverting change for rG070493ddbd94: Revert "Revert "Revert "[clang] Add experimental option to omit the RTTI…: rGf45f1c3585e6: Reland "[clang] Add experimental option to omit the RTTI component from the….
Thu, Sep 14, 11:29 AM · Restricted Project, Restricted Project
leonardchan added a comment to D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used.

Hi @leonardchan your change was still causing a failure on the PS4 linux bot, so I reverted it in 070493ddbd9473499d6f00ca62bc6aa92808ed79. I noticed earlier that the failing test omit-rtti-component-without-no-rtti.cpp was failing on both the linux and Windows PS bots, and I don't think it is because it was on Windows, but rather, these bots use PS4 and PS5 as the default targets, on which rtti is not enabled by default. The run command on line 4 in your test tests the "default" behavior which on most platforms seems to have rtti enabled by default. If I remove that line, the test then passes on both of the PS targets. To reland the change, you might want to consider removing that line as it makes an assumption which does not seem to be true for all targets.

Thu, Sep 14, 11:26 AM · Restricted Project, Restricted Project

Wed, Sep 13

leonardchan committed rGe16474ba2cba: Revert "Revert "[clang] Add experimental option to omit the RTTI component from… (authored by leonardchan).
Revert "Revert "[clang] Add experimental option to omit the RTTI component from…
Wed, Sep 13, 5:01 PM · Restricted Project, Restricted Project
leonardchan added inline comments to D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used.
Wed, Sep 13, 4:56 PM · Restricted Project, Restricted Project
leonardchan added a reverting change for D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used: rG87e11ecbaec9: Revert "[clang] Add experimental option to omit the RTTI component from the….
Wed, Sep 13, 4:55 PM · Restricted Project, Restricted Project
leonardchan committed rG87e11ecbaec9: Revert "[clang] Add experimental option to omit the RTTI component from the… (authored by leonardchan).
Revert "[clang] Add experimental option to omit the RTTI component from the…
Wed, Sep 13, 4:55 PM · Restricted Project, Restricted Project
leonardchan added a reverting change for rG6385c1df919f: [clang] Add experimental option to omit the RTTI component from the vtable when…: rG87e11ecbaec9: Revert "[clang] Add experimental option to omit the RTTI component from the….
Wed, Sep 13, 4:55 PM · Restricted Project, Restricted Project
leonardchan committed rG6385c1df919f: [clang] Add experimental option to omit the RTTI component from the vtable when… (authored by leonardchan).
[clang] Add experimental option to omit the RTTI component from the vtable when…
Wed, Sep 13, 4:18 PM · Restricted Project, Restricted Project
leonardchan closed D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used.
Wed, Sep 13, 4:18 PM · Restricted Project, Restricted Project
leonardchan added a comment to D147832: [libcxx] Introduce clang::lto_visibility_public attribute.

After careful consideration, I am left wondering why -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -fvisibility=hidden even makes sense. I understand that you want to minimize the number of symbols exported from your program and I think that's a desirable goal. However, let's say you take a typical program and just compile it normally without using -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -fvisibility=hidden -- what's the problem? What symbols end up being exported that you wouldn't want to export?

We already mark the vast majority of symbols in libc++ as hidden (using _LIBCPP_HIDE_FROM_ABI), and the ones that are not marked as hidden basically need to be public for correctness purposes.

Wed, Sep 13, 4:03 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used.
Wed, Sep 13, 3:17 PM · Restricted Project, Restricted Project

Tue, Sep 12

leonardchan added a comment to D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used.

Oh this is completely independent from relative vtables. I'll update the wording.

Great. I'd like to see us try some experiments with enabling both together in places like the Fuchsia kernel where we get benefit from relative-vtables today but it's all a single fungible internal ABI domain and there's no problem having a one-off ABI. It's also interesting of course for true embedded contexts, but those tend to be ILP32 where relative-vtables isn't a size savings anyway. In the Fuchsia kernel we should get some size savings from this and it would be nice to see what that is (probably not all that big, but interesting).

Tue, Sep 12, 5:15 PM · Restricted Project, Restricted Project
leonardchan added a comment to D147832: [libcxx] Introduce clang::lto_visibility_public attribute.

You say you build with -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -fvisibility=hidden which AFAICT defeats the purpose of a shared library, since it wouldn't export a single symbol.

My bad, I should've clarified on this. For fuchsia, we build everything with hidden visibility by default and individual binaries need to explicitly mark their symbols with default visibility if they want to be exported. This also means that when a fuchsia binary uses libc++, we need to make sure it doesn't accidentally export any libc++ symbols. Fuchsia binaries can consume libc++ as either a shared lib or a hermetic static lib, but we don't know at compile time how libc++ will eventually be consumed. If used as a shared lib, then symbols will be defined libc++.so. If linked in as a hermetic static lib, then we need to ensure those symbols have hidden visibility. To cover both cases and prevent us from having to compile twice, we just compile everything with -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -fvisibility=hidden.

I still don't understand your setup. So you compile the program using LTO and passing -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -fvisibility=hidden, right? That way the program itself doesn't export any libc++ symbols and everything in the program has hidden visibility AND hidden LTO visibility. But then you compile libc++.so with -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -fvisibility=hidden, which causes everything in libc++.so to have hidden visibility. But since you compile libc++.so with LTO disabled, everything in libc++.so has default LTO visibility.

Tue, Sep 12, 11:43 AM · Restricted Project, Restricted Project

Fri, Sep 8

leonardchan abandoned D72959: Relative VTables ABI on Fuchsia.

This was landed in various other smaller changes

Fri, Sep 8, 10:02 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Thu, Aug 31

leonardchan committed rG7ce67d33107f: [scudo][tests] Store the allocator instance in a global rather than… (authored by leonardchan).
[scudo][tests] Store the allocator instance in a global rather than…
Thu, Aug 31, 3:28 PM · Restricted Project, Restricted Project
leonardchan closed D158767: [scudo][tests] Store the allocator instance in a global rather than posix_memalign it.
Thu, Aug 31, 3:27 PM · Restricted Project, Restricted Project
leonardchan added a comment to D151157: [compiler-rt][asan][Fuchsia] Tune the 64-bit asan allocator for riscv+fuchsia.

ping for thoughts on this

Thu, Aug 31, 1:36 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D158767: [scudo][tests] Store the allocator instance in a global rather than posix_memalign it.
Thu, Aug 31, 1:34 PM · Restricted Project, Restricted Project

Aug 30 2023

leonardchan committed rG1abcf584023e: [lsan][Fuchsia] Fix bounds checking for thread_local allocator cache when… (authored by leonardchan).
[lsan][Fuchsia] Fix bounds checking for thread_local allocator cache when…
Aug 30 2023, 1:51 PM · Restricted Project, Restricted Project
leonardchan closed D156015: [lsan][Fuchsia] Fix bounds checking for thread_local allocator cache when scanning TLS regions.
Aug 30 2023, 1:50 PM · Restricted Project, Restricted Project

Aug 29 2023

leonardchan added a reverting change for rG34e2f4f2e28a: [sanitizer] Do not mmap FlagParser::flags_: rG21d72872691f: Revert "[sanitizer] Do not mmap FlagParser::flags_".
Aug 29 2023, 1:01 PM · Restricted Project, Restricted Project
leonardchan committed rG21d72872691f: Revert "[sanitizer] Do not mmap FlagParser::flags_" (authored by leonardchan).
Revert "[sanitizer] Do not mmap FlagParser::flags_"
Aug 29 2023, 1:01 PM · Restricted Project, Restricted Project
leonardchan added a reverting change for D158780: [sanitizer] Do not mmap FlagParser::flags_: rG21d72872691f: Revert "[sanitizer] Do not mmap FlagParser::flags_".
Aug 29 2023, 1:01 PM · Restricted Project, Restricted Project
leonardchan added a comment to D156015: [lsan][Fuchsia] Fix bounds checking for thread_local allocator cache when scanning TLS regions.

ping

Aug 29 2023, 12:16 PM · Restricted Project, Restricted Project
leonardchan committed rG34e2f4f2e28a: [sanitizer] Do not mmap FlagParser::flags_ (authored by leonardchan).
[sanitizer] Do not mmap FlagParser::flags_
Aug 29 2023, 12:09 PM · Restricted Project, Restricted Project
leonardchan closed D158780: [sanitizer] Do not mmap FlagParser::flags_.
Aug 29 2023, 12:08 PM · Restricted Project, Restricted Project
leonardchan added inline comments to D158767: [scudo][tests] Store the allocator instance in a global rather than posix_memalign it.
Aug 29 2023, 12:02 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D158767: [scudo][tests] Store the allocator instance in a global rather than posix_memalign it.
Aug 29 2023, 12:02 PM · Restricted Project, Restricted Project

Aug 28 2023

leonardchan committed rGafd170bdd983: [sanitizer] Consolidate some LowLevelAllocators to one (authored by leonardchan).
[sanitizer] Consolidate some LowLevelAllocators to one
Aug 28 2023, 4:14 PM · Restricted Project, Restricted Project
leonardchan closed D158786: [sanitizer] Consolidate some LowLevelAllocators to one.
Aug 28 2023, 4:13 PM · Restricted Project, Restricted Project
leonardchan committed rG56006757a091: [sanitizer] Set the min size to allocate for the LowLevelAllocator to (authored by leonardchan).
[sanitizer] Set the min size to allocate for the LowLevelAllocator to
Aug 28 2023, 4:05 PM · Restricted Project, Restricted Project
leonardchan closed D158783: [sanitizer] Add macro for specifying number of pages to allocate for LowLevelAllocator.
Aug 28 2023, 4:05 PM · Restricted Project, Restricted Project

Aug 25 2023

leonardchan updated the diff for D158767: [scudo][tests] Store the allocator instance in a global rather than posix_memalign it.
Aug 25 2023, 2:54 PM · Restricted Project, Restricted Project

Aug 24 2023

leonardchan updated subscribers of D158786: [sanitizer] Consolidate some LowLevelAllocators to one.
Aug 24 2023, 5:56 PM · Restricted Project, Restricted Project
leonardchan updated subscribers of D158783: [sanitizer] Add macro for specifying number of pages to allocate for LowLevelAllocator.
Aug 24 2023, 5:56 PM · Restricted Project, Restricted Project
leonardchan updated subscribers of D158780: [sanitizer] Do not mmap FlagParser::flags_.
Aug 24 2023, 5:55 PM · Restricted Project, Restricted Project
leonardchan added inline comments to D151157: [compiler-rt][asan][Fuchsia] Tune the 64-bit asan allocator for riscv+fuchsia.
Aug 24 2023, 5:55 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D151157: [compiler-rt][asan][Fuchsia] Tune the 64-bit asan allocator for riscv+fuchsia.
Aug 24 2023, 5:52 PM · Restricted Project, Restricted Project
leonardchan retitled D151157: [compiler-rt][asan][Fuchsia] Tune the 64-bit asan allocator for riscv+fuchsia from [compiler-rt][asan] Have RISCV allocator settings take precedence over Fuchsia's settings to [compiler-rt][asan][Fuchsia] Tune the 64-bit asan allocator for riscv+fuchsia.
Aug 24 2023, 5:51 PM · Restricted Project, Restricted Project
leonardchan updated the summary of D158783: [sanitizer] Add macro for specifying number of pages to allocate for LowLevelAllocator.
Aug 24 2023, 3:12 PM · Restricted Project, Restricted Project
leonardchan requested review of D158786: [sanitizer] Consolidate some LowLevelAllocators to one.
Aug 24 2023, 3:12 PM · Restricted Project, Restricted Project
leonardchan requested review of D158783: [sanitizer] Add macro for specifying number of pages to allocate for LowLevelAllocator.
Aug 24 2023, 2:41 PM · Restricted Project, Restricted Project
leonardchan updated the summary of D158780: [sanitizer] Do not mmap FlagParser::flags_.
Aug 24 2023, 2:15 PM · Restricted Project, Restricted Project
leonardchan requested review of D158780: [sanitizer] Do not mmap FlagParser::flags_.
Aug 24 2023, 2:14 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D158767: [scudo][tests] Store the allocator instance in a global rather than posix_memalign it.
Aug 24 2023, 2:03 PM · Restricted Project, Restricted Project
leonardchan added a comment to D158767: [scudo][tests] Store the allocator instance in a global rather than posix_memalign it.

Sorry I'm not familiar with the 39 bit vma. Could you share more context behind this? Is this only causing issue on Fuchsia RISCV?

Aug 24 2023, 2:03 PM · Restricted Project, Restricted Project
leonardchan added a reviewer for D158767: [scudo][tests] Store the allocator instance in a global rather than posix_memalign it: mcgrathr.
Aug 24 2023, 12:42 PM · Restricted Project, Restricted Project
leonardchan requested review of D158767: [scudo][tests] Store the allocator instance in a global rather than posix_memalign it.
Aug 24 2023, 12:41 PM · Restricted Project, Restricted Project

Aug 23 2023

leonardchan abandoned D158550: [sanitizer_common] Fallback to secondary allocator if primary allocator is exhausted.

This can happen if the region size happens to be relatively small and we allocate a bunch of objects that fit into the largest size class.

Can you elaborate? RISC-V?

Aug 23 2023, 3:48 PM · Restricted Project, Restricted Project

Aug 22 2023

leonardchan requested review of D158550: [sanitizer_common] Fallback to secondary allocator if primary allocator is exhausted.
Aug 22 2023, 2:06 PM · Restricted Project, Restricted Project
leonardchan committed rG3a4f471b11ff: [compiler-rt][Fuchsia] Use map name if provided (authored by leonardchan).
[compiler-rt][Fuchsia] Use map name if provided
Aug 22 2023, 1:40 PM · Restricted Project, Restricted Project
leonardchan closed D158537: [compiler-rt][Fuchsia] Use map name if provided.
Aug 22 2023, 1:39 PM · Restricted Project, Restricted Project
leonardchan requested review of D158537: [compiler-rt][Fuchsia] Use map name if provided.
Aug 22 2023, 11:58 AM · Restricted Project, Restricted Project
leonardchan closed D157128: [hwasan] Enable leak detection in hwasan for Fuchsia by default.

This was landed in fe195781ad2f1aaecd5def14f361f3590a17c79e

Aug 22 2023, 11:50 AM · Restricted Project, Restricted Project

Aug 4 2023

leonardchan added a comment to D157127: [CodeGen][AArch64] Don't split functions with a red zone on AArch64.

I think perhaps you can re-upload your diff to the original one.

Aug 4 2023, 4:58 PM · Restricted Project, Restricted Project, Restricted Project
leonardchan abandoned D157161: [CodeGen][AArch64] Don't split functions with a red zone on AArch64.
Aug 4 2023, 4:57 PM · Restricted Project, Restricted Project
leonardchan requested review of D157161: [CodeGen][AArch64] Don't split functions with a red zone on AArch64.
Aug 4 2023, 4:56 PM · Restricted Project, Restricted Project
leonardchan reopened D157127: [CodeGen][AArch64] Don't split functions with a red zone on AArch64.

Sorry I accidentally closed the revision. I think just re-opening it should be fine then when you commit it, you can still use this differential revision.

Aug 4 2023, 4:55 PM · Restricted Project, Restricted Project, Restricted Project
leonardchan added a comment to rGfe195781ad2f: [hwasan] Enable leak detection in hwasan for Fuchsia by default.

Looks like this lists the wrong differential revision.

You listed:
https://reviews.llvm.org/D157127

You probably meant:
https://reviews.llvm.org/D157128

This closes my active revision. Please fix!

Aug 4 2023, 4:29 PM · Restricted Project, Restricted Project
leonardchan committed rGfe195781ad2f: [hwasan] Enable leak detection in hwasan for Fuchsia by default (authored by leonardchan).
[hwasan] Enable leak detection in hwasan for Fuchsia by default
Aug 4 2023, 12:30 PM · Restricted Project, Restricted Project
leonardchan closed D157127: [CodeGen][AArch64] Don't split functions with a red zone on AArch64.
Aug 4 2023, 12:30 PM · Restricted Project, Restricted Project, Restricted Project
leonardchan requested review of D157128: [hwasan] Enable leak detection in hwasan for Fuchsia by default.
Aug 4 2023, 12:12 PM · Restricted Project, Restricted Project

Aug 3 2023

leonardchan updated the diff for D156015: [lsan][Fuchsia] Fix bounds checking for thread_local allocator cache when scanning TLS regions.
Aug 3 2023, 11:23 AM · Restricted Project, Restricted Project

Jul 31 2023

leonardchan added a comment to D155276: [libc++] Implement ostringstream members of P0408R7 (Efficient Access to basic_stringbuf's Buffer).

It looks like this change causes an out of range exception to be thrown for this snippet:

Jul 31 2023, 1:23 PM · Restricted Project, Restricted Project

Jul 21 2023

leonardchan added a comment to D156015: [lsan][Fuchsia] Fix bounds checking for thread_local allocator cache when scanning TLS regions.

Prior to this, it looks like we'd unconditionally mark pointers in the allocator cache as reachable. So we may find more leaks after this.

Jul 21 2023, 7:56 PM · Restricted Project, Restricted Project
leonardchan requested review of D156015: [lsan][Fuchsia] Fix bounds checking for thread_local allocator cache when scanning TLS regions.
Jul 21 2023, 7:55 PM · Restricted Project, Restricted Project

Jul 19 2023

leonardchan accepted D155119: [sancov] Switch to OptTable from llvm::cl.

LGTM but probably give it a day before landing to give others time to respond

Jul 19 2023, 2:41 PM · Restricted Project, Restricted Project

Jul 17 2023

leonardchan updated subscribers of D155119: [sancov] Switch to OptTable from llvm::cl.
Jul 17 2023, 3:54 PM · Restricted Project, Restricted Project

Jun 15 2023

leonardchan added a comment to D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal.

Hi. I think this is leading to the lldb test failures we're seeing on our linux builder (https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8778187770933863505/+/u/lldb/test/stdout?format=raw):

Jun 15 2023, 4:52 PM · Restricted Project, Restricted Project
leonardchan closed D153085: [compiler-rt] Go back to using the 32-bit allocator for Fuchsia+RISCV64 .

Woops. Forgot to add the differential revision: bit to the commit, but this was submitted in 17623e96b5b84c0868fe6b4a1456e3d7da275c95.

Jun 15 2023, 4:30 PM · Restricted Project, Restricted Project
leonardchan added a reverting change for rGf6c4808d9522: [compiler-rt] Allow 64-bit sanitizer allocator to be used if using RISCV64 and…: rG17623e96b5b8: [compiler-rt] Go back to using the 32-bit allocator for Fuchsia+RISCV64.
Jun 15 2023, 4:29 PM · Restricted Project, Restricted Project
leonardchan committed rG17623e96b5b8: [compiler-rt] Go back to using the 32-bit allocator for Fuchsia+RISCV64 (authored by leonardchan).
[compiler-rt] Go back to using the 32-bit allocator for Fuchsia+RISCV64
Jun 15 2023, 4:29 PM · Restricted Project, Restricted Project
leonardchan added a reverting change for D151159: [compiler-rt] Allow 64-bit sanitizer allocator to be used if using RISCV64 and Fuchsia: rG17623e96b5b8: [compiler-rt] Go back to using the 32-bit allocator for Fuchsia+RISCV64.
Jun 15 2023, 4:29 PM · Restricted Project, Restricted Project
leonardchan added a reverting change for rGf6c4808d9522: [compiler-rt] Allow 64-bit sanitizer allocator to be used if using RISCV64 and…: D153085: [compiler-rt] Go back to using the 32-bit allocator for Fuchsia+RISCV64 .
Jun 15 2023, 4:21 PM · Restricted Project, Restricted Project
leonardchan requested review of D153085: [compiler-rt] Go back to using the 32-bit allocator for Fuchsia+RISCV64 .
Jun 15 2023, 4:21 PM · Restricted Project, Restricted Project
leonardchan added a reverting change for D151159: [compiler-rt] Allow 64-bit sanitizer allocator to be used if using RISCV64 and Fuchsia: D153085: [compiler-rt] Go back to using the 32-bit allocator for Fuchsia+RISCV64 .
Jun 15 2023, 4:21 PM · Restricted Project, Restricted Project
leonardchan added a comment to rG879e88693338: Reland "[Clang][MS] Remove assertion on BaseOffset can't be smaller than Size.".

Looks like this is still causing the test to fail still (https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8778209096851671889/+/u/clang/test/stdout?format=raw):

Jun 15 2023, 11:37 AM · Restricted Project, Restricted Project

Jun 14 2023

leonardchan added a comment to D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size..

Hi. I think this caused the override-layout.cpp test to fail on our windows builder (https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8778279637538184401/+/u/clang/test/stdout?format=raw):

Jun 14 2023, 3:23 PM · Restricted Project, Restricted Project
leonardchan added a reverting change for rG2700da5fe28d: [LLD] Allow usage of LLD as a library: rGaa495214b39d: Revert "[LLD] Allow usage of LLD as a library".
Jun 14 2023, 1:37 PM · Restricted Project, Restricted Project
leonardchan committed rGaa495214b39d: Revert "[LLD] Allow usage of LLD as a library" (authored by leonardchan).
Revert "[LLD] Allow usage of LLD as a library"
Jun 14 2023, 1:37 PM · Restricted Project, Restricted Project
leonardchan added a reverting change for D119049: [LLD] Allow usage of LLD as a library: rGaa495214b39d: Revert "[LLD] Allow usage of LLD as a library".
Jun 14 2023, 1:37 PM · Restricted Project, Restricted Project, Restricted Project
leonardchan added a comment to D119049: [LLD] Allow usage of LLD as a library.

Hi. This fails for me locally with:

Jun 14 2023, 12:33 PM · Restricted Project, Restricted Project, Restricted Project
leonardchan added a comment to D152750: [RISCV] Enable SLP by default (when vectors are available).

Hi. It looks like this is failing to build for us on windows host https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8778294144728066337/+/u/clang/build/stdout?format=raw with:

Jun 14 2023, 12:23 PM · Restricted Project, Restricted Project

Jun 12 2023

leonardchan added a comment to D152585: [dsymutil] Skip duplicates files with identical time stamps in the debug map.

Hi. Looks like the static-archive-collision.test test is failing on our builders at https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8778475674577642785/overview. Would you mind sending out a fix or revert?

Jun 12 2023, 11:44 AM · Restricted Project, Restricted Project

Jun 8 2023

leonardchan added a comment to D132275: [clang] Create alloca to pass into static lambda.

Ok here's some of my findings. So there's a step in the attributor where it replaces some instructions with unreachable. One step is:

Jun 8 2023, 5:51 PM · Restricted Project, Restricted Project
leonardchan added a comment to D152322: [libc] Temporarily suppress -fsanitize=function for qsort comparator.

https://reviews.llvm.org/D152322 for qsort_r

Jun 8 2023, 2:12 PM · Restricted Project, Restricted Project

Jun 7 2023

leonardchan added a comment to D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used.

Can we extend the test cases to exercise both with and without relative-vtables also enabled?

Jun 7 2023, 5:19 PM · Restricted Project, Restricted Project
leonardchan added a reverting change for rG94e75469597f: Revert "[clang-format] Fix overlapping replacements before PPDirectives": rG9f00eb99759b: Revert "Revert "[clang-format] Fix overlapping replacements before….
Jun 7 2023, 5:16 PM · Restricted Project, Restricted Project
leonardchan committed rG9f00eb99759b: Revert "Revert "[clang-format] Fix overlapping replacements before… (authored by leonardchan).
Revert "Revert "[clang-format] Fix overlapping replacements before…
Jun 7 2023, 5:16 PM · Restricted Project, Restricted Project
leonardchan added a reverting change for rG4b9764959dc4: [clang-format] Fix overlapping replacements before PPDirectives: rG94e75469597f: Revert "[clang-format] Fix overlapping replacements before PPDirectives".
Jun 7 2023, 4:47 PM · Restricted Project, Restricted Project
leonardchan committed rG94e75469597f: Revert "[clang-format] Fix overlapping replacements before PPDirectives" (authored by leonardchan).
Revert "[clang-format] Fix overlapping replacements before PPDirectives"
Jun 7 2023, 4:47 PM · Restricted Project, Restricted Project
leonardchan added a reverting change for D151954: [clang-format] Fix overlapping whitespace replacements before PPDirective: rG94e75469597f: Revert "[clang-format] Fix overlapping replacements before PPDirectives".
Jun 7 2023, 4:46 PM · Restricted Project, Restricted Project, Restricted Project
leonardchan updated the summary of D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used.
Jun 7 2023, 4:14 PM · Restricted Project, Restricted Project