Page MenuHomePhabricator

leonardchan (Leonard Chan)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 25 2018, 1:47 PM (90 w, 2 d)

Recent Activity

Yesterday

leonardchan created D72959: Relative VTables ABI on Fuchsia.
Fri, Jan 17, 2:15 PM · Restricted Project, Restricted Project
leonardchan added a comment to D68945: [DebugInfo] Don't translate dbg.addr and similar intrinsics into indirect DBG_VALUEs.

Hi, it seems that this revision introduced the regression in https://bugs.llvm.org/show_bug.cgi?id=44585 that produces incorrect DWARF expressions when using safestack. Would you mind taking a look? Thanks.

Fri, Jan 17, 10:03 AM · Restricted Project

Mon, Jan 13

leonardchan accepted D72537: [NewPM] Port MergeFunctions pass.

LGTM with just one quick question

Mon, Jan 13, 11:03 AM · Restricted Project

Fri, Jan 10

leonardchan added a comment to rG61bd19206f61: [libc++] Explicitly enumerate std::string external instantiations..

Hi, it seems that this commit also introduces libc++ headers that are incompatible with gcc 9.2:

Fri, Jan 10, 2:06 PM

Thu, Jan 9

leonardchan added a comment to D71550: [Intrinsic] Add fixed point saturating division intrinsics..

LGTM for the code so far. Just want to confirm on my side that the codegen works as intended also.

Thu, Jan 9, 5:41 PM · Restricted Project
leonardchan added a comment to D71795: [ELF] Delete an unused special rule from isStaticLinkTimeConstant. NFC.

Yup, was able to confirm this is the faulty patch. Would you mind looking into this or reverting in the meantime?

Thu, Jan 9, 5:04 PM · Restricted Project
leonardchan added a comment to D71795: [ELF] Delete an unused special rule from isStaticLinkTimeConstant. NFC.

*Moved from the commit to here*

Thu, Jan 9, 4:26 PM · Restricted Project
leonardchan added a comment to rGb841e119d77e: [ELF] Delete an unused special rule from isStaticLinkTimeConstant. NFC.
Thu, Jan 9, 4:25 PM

Fri, Dec 20

leonardchan added a comment to D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used.

Hi! This seems to be causing some test failures on our bots: https://ci.chromium.org/p/fuchsia/builders/ci/clang-linux-x64/b8893521019883752048

Fri, Dec 20, 4:39 PM · Restricted Project, Restricted Project

Dec 6 2019

leonardchan accepted D70691: Optimization record for bytecode input missing- PR44000.

LGTM. Could you commit this soon to get the bots green again?

Dec 6 2019, 3:30 PM · Restricted Project
leonardchan added a comment to D70691: Optimization record for bytecode input missing- PR44000.

Hi! I believe the commit for this (a3b2552575d3c333e928446fac10cc5b0b4092a9) is causing a test failure on our bots (https://ci.chromium.org/p/fuchsia/builders/ci/clang-linux-x64/b8894791990609720880) and some buildbots (can't find the link since it scrolled past the end of the console). Could you look into it when you get a chance?

Dec 6 2019, 12:24 PM · Restricted Project
leonardchan added a comment to D70007: [Intrinsic] Add fixed point division intrinsics..

Alrighty, it looks like everything in this patch should be ok after those 2 changes. I can send you the script I used to generate tests if you'd like to use it also.

Dec 6 2019, 12:15 PM · Restricted Project
leonardchan accepted D71135: [cxx][cxxabi] Don't link libpthread and libdl on Fuchsia.
Dec 6 2019, 11:18 AM · Restricted Project

Dec 4 2019

leonardchan added inline comments to D70007: [Intrinsic] Add fixed point division intrinsics..
Dec 4 2019, 4:50 PM · Restricted Project
leonardchan added inline comments to D70007: [Intrinsic] Add fixed point division intrinsics..
Dec 4 2019, 2:10 PM · Restricted Project

Nov 27 2019

leonardchan added a comment to D70007: [Intrinsic] Add fixed point division intrinsics..

Sorry for the holdup. Right now I'm just writing a bunch of tests to validate the IR expansion produces the correct division results. As of now, the patch LGTM, but I'd prefer holding off submitting the revision until I finish validating (unless you think it's better to submit now then fix any potential bugs that may be found later since I don't think anyone will be immediately using this). Here's a few comments I have so far:

Nov 27 2019, 2:36 PM · Restricted Project

Nov 26 2019

leonardchan accepted D70747: [Fuchsia] Don't fail for unknown architectures.
Nov 26 2019, 6:52 PM · Restricted Project

Nov 25 2019

leonardchan accepted D70575: [Clang] Define Fuchsia C++ABI.
Nov 25 2019, 10:16 AM · Restricted Project

Nov 21 2019

leonardchan added a comment to D70575: [Clang] Define Fuchsia C++ABI.

Could you add a test to show that with a fuchsia target we end up returning this from constructors + destructors and ensure that this ABI is used?

Nov 21 2019, 5:41 PM · Restricted Project
leonardchan accepted D70576: [Clang] Always set -z now linker option on Fuchsia.

LGTM. But just to confirm, did you test this on CQ/bots by adding ["now", "-z"] as linker flags to the config("compiler") in Fuchsia + Zircon?

Nov 21 2019, 5:14 PM · Restricted Project

Nov 20 2019

leonardchan added a comment to D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline..

Hi! I think this patch might be causing some test failures on our mac bots:

Nov 20 2019, 4:07 PM · Restricted Project
leonardchan accepted D70477: [Clang] Enable RISC-V support for Fuchsia.
Nov 20 2019, 10:21 AM · Restricted Project

Nov 18 2019

leonardchan committed rG66b6b9276521: Revert "implement printing out raw section data of xcoff objectfile for llvm… (authored by leonardchan).
Revert "implement printing out raw section data of xcoff objectfile for llvm…
Nov 18 2019, 8:08 PM
leonardchan added a reverting change for rG8f8a9f3437d4: implement printing out raw section data of xcoff objectfile for llvm-objdump: rG66b6b9276521: Revert "implement printing out raw section data of xcoff objectfile for llvm….
Nov 18 2019, 8:08 PM
leonardchan added a comment to rG8f8a9f3437d4: implement printing out raw section data of xcoff objectfile for llvm-objdump.

I reverted this commit in 66b6b92765213a6bde96aea7a393621426027543.

Nov 18 2019, 8:08 PM
leonardchan added a comment to D70255: implement printing out raw section data of xcoff objectfile for llvm-objdump.

Hi! This patch seems to be causing test failures on our bots (https://luci-milo.appspot.com/p/fuchsia/builders/ci/clang-linux-x64/b8896419822706045584) and the llvm buildbots (http://lab.llvm.org:8011/builders/clang-cmake-x86_64-avx2-linux/builds/12040/steps/ninja%20check%201/logs/FAIL%3A%20LLVM%3A%3Axcoff-disassemble-all.test). Could you take a look into this? Thanks.

Nov 18 2019, 5:22 PM · Restricted Project

Nov 14 2019

leonardchan added a comment to rG9fcf4f372c7e: [Hexagon] Fix clang driver to parse -mcpu/-mvXX and -march properly..

Hi. This patch seems to be causing a test failure for our clang x64 bots:

Nov 14 2019, 1:29 PM

Nov 13 2019

leonardchan added a comment to D68407: [RISCV] Use compiler-rt if no GCC installation detected.

Hi. I think this patch is causing some test failures for us:

Nov 13 2019, 11:47 AM · Restricted Project

Nov 12 2019

leonardchan committed rGe278c138a937: [Sema] Add MacroQualified case for FunctionTypeUnwrapper (authored by leonardchan).
[Sema] Add MacroQualified case for FunctionTypeUnwrapper
Nov 12 2019, 4:26 PM
leonardchan closed D67992: [Sema] Add MacroQualified case for FunctionTypeUnwrapper.
Nov 12 2019, 4:26 PM · Restricted Project

Nov 8 2019

leonardchan added a comment to D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute.

Yup, a bisect shows it was this patch that caused it. I filed a bug for tracking at https://bugs.llvm.org/show_bug.cgi?id=43950 and attached a reproducer. Could you look into this? Thanks.

Nov 8 2019, 6:03 PM · Restricted Project
leonardchan added a comment to D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute.

Hi. I have a suspicion this patch is causing a segfault for us when building zircon: https://ci.chromium.org/p/fuchsia/builders/ci/fuchsia-x64-debug-clang/b8897388724384628544

Nov 8 2019, 5:44 PM · Restricted Project

Oct 31 2019

leonardchan added a reviewer for D69596: [Attributor] Add the Attributor to the new PM pipeline: chandlerc.

Adding @chandlerc for review. I'm not very comfortable reviewing changes to the backend pipeline.

Oct 31 2019, 10:22 AM · Restricted Project

Oct 30 2019

leonardchan added a comment to D58238: [DebugInfo] MachineSink: Insert undef DBG_VALUEs when sinking instructions, try to forward copies.

Is the extra cost here, or is it more work being generated for LiveDebugValues?

Oct 30 2019, 4:04 PM · Restricted Project
leonardchan added a comment to D58238: [DebugInfo] MachineSink: Insert undef DBG_VALUEs when sinking instructions, try to forward copies.

Hi! This patch seems to drastically increase compile times for some fuchsia builds. I'm working on creating a small reproducer that I can share, but just wanted to raise awareness in the meantime.

Oct 30 2019, 3:17 PM · Restricted Project

Oct 29 2019

leonardchan accepted D68790: [AddressSanitizer] Only instrument globals of default address space.
Oct 29 2019, 1:30 PM · Restricted Project, Restricted Project

Oct 28 2019

leonardchan committed rG85b718f53a35: [Driver] Enable ShadowCallStack, not SafeStack, by default on AArch64 Fuchsia (authored by leonardchan).
[Driver] Enable ShadowCallStack, not SafeStack, by default on AArch64 Fuchsia
Oct 28 2019, 3:28 PM
leonardchan closed D66712: [Driver] Enable ShadowCallStack, not SafeStack, by default on AArch64 Fuchsia.

Manually closed since git push didn't seem to automatically close this. Committed under https://github.com/llvm/llvm-project/commit/85b718f53a3575bca2f1b7fdb1b3aaa6df7c10e3.

Oct 28 2019, 2:59 PM · Restricted Project

Oct 24 2019

leonardchan accepted D69415: [CMake] Update Fuchsia build configuration.
Oct 24 2019, 4:35 PM · Restricted Project
leonardchan added a comment to rGc07fe307b48a: [AArch64][GlobalISel] Simplify zext/sext selection, use MachineIRBuilder. NFC..

Hello. I believe this patch is causing the assertion failure we see at https://bugs.llvm.org/show_bug.cgi?id=43794. Could you take a look? Thanks.

Oct 24 2019, 3:02 PM

Oct 14 2019

leonardchan added a comment to rG671651267039: [X86] scaleShuffleMask - use size_t Scale to avoid overflow warnings.

We're building a 2 stage build where the 1st stage is made using the fuchsia toolchain clang (which is just revision cea8882254f97ae82867e25e736959d1cfa31896) and the 2nd stage is made from the 1st stage clang. This is our cmake invocation:

Oct 14 2019, 2:32 PM
leonardchan added a comment to rG671651267039: [X86] scaleShuffleMask - use size_t Scale to avoid overflow warnings.

Hi! I'm not sure how this change could've caused it, but do you have an idea of how this could've caused the following error:

Oct 14 2019, 12:28 PM

Oct 11 2019

leonardchan accepted D68882: [test] Fix test failure.
Oct 11 2019, 1:45 PM · Restricted Project

Oct 10 2019

leonardchan committed rL374491: Request commit access for leonardchan.
Request commit access for leonardchan
Oct 10 2019, 5:59 PM
leonardchan accepted D68832: [tsan,msan] Insert module constructors in a module pass.

Thanks for finding the root cause of this!

Oct 10 2019, 3:03 PM · Restricted Project, Restricted Project

Oct 3 2019

Herald added a project to D20561: Warn when taking address of packed member: Restricted Project.

I think I found a false negative with this where if the member is accessed from a packed struct type returned from a function, the warning does not appear:

Oct 3 2019, 10:08 AM · Restricted Project, Restricted Project

Oct 1 2019

leonardchan committed rG8830975cf616: [ASan][NFC] Address remaining comments for https://reviews.llvm.org/D68287 (authored by leonardchan).
[ASan][NFC] Address remaining comments for https://reviews.llvm.org/D68287
Oct 1 2019, 1:49 PM
leonardchan committed rL373391: [ASan][NFC] Address remaining comments for https://reviews.llvm.org/D68287.
[ASan][NFC] Address remaining comments for https://reviews.llvm.org/D68287
Oct 1 2019, 1:49 PM
leonardchan added inline comments to D68287: [ASan] Make GlobalsMD member a const reference.
Oct 1 2019, 1:49 PM · Restricted Project, Restricted Project
leonardchan committed rG63663616f5a0: [ASan] Make GlobalsMD member a const reference. (authored by leonardchan).
[ASan] Make GlobalsMD member a const reference.
Oct 1 2019, 1:32 PM
leonardchan committed rL373389: [ASan] Make GlobalsMD member a const reference..
[ASan] Make GlobalsMD member a const reference.
Oct 1 2019, 1:32 PM
leonardchan closed D68287: [ASan] Make GlobalsMD member a const reference.
Oct 1 2019, 1:32 PM · Restricted Project, Restricted Project
leonardchan created D68287: [ASan] Make GlobalsMD member a const reference.
Oct 1 2019, 11:42 AM · Restricted Project, Restricted Project

Sep 26 2019

leonardchan added a comment to D67992: [Sema] Add MacroQualified case for FunctionTypeUnwrapper.

*ping* @rsmith

Sep 26 2019, 10:14 AM · Restricted Project

Sep 25 2019

leonardchan retitled D67992: [Sema] Add MacroQualified case for FunctionTypeUnwrapper from [Sema] Add FunctionTypeUnwrapper to [Sema] Add MacroQualified case for FunctionTypeUnwrapper.
Sep 25 2019, 10:28 AM · Restricted Project

Sep 24 2019

leonardchan updated subscribers of D67992: [Sema] Add MacroQualified case for FunctionTypeUnwrapper.
Sep 24 2019, 3:30 PM · Restricted Project
leonardchan created D67992: [Sema] Add MacroQualified case for FunctionTypeUnwrapper.
Sep 24 2019, 3:27 PM · Restricted Project
leonardchan created D67971: [WIP] Add warning when zero-initializing a union if its first member is not is largest.
Sep 24 2019, 10:38 AM · Restricted Project

Sep 16 2019

leonardchan added inline comments to rG5e37d7f9ff25: Implement std::condition_variable via pthread_cond_clockwait() where available.
Sep 16 2019, 2:27 PM

Sep 13 2019

leonardchan added a comment to D67287: [Diagnostics] Add -Wsizeof-array-div.

Not sure if we're still mentioning false positives here, but if we have something like a multidimensional array of a specific type and we want to find the number of elements inside it, this warning would also appear:

Sep 13 2019, 3:07 PM · Restricted Project

Sep 11 2019

leonardchan added a comment to rG81196a595c68: LiveIntervals: Split live intervals on multiple dead defs.

Hi! I think this patch is causing a test failure for DebugInfo/X86/live-debug-vars-discard-invalid.mir on our bots:

Sep 11 2019, 11:56 AM

Sep 10 2019

leonardchan added a comment to D67195: Adding support for overriding LLVM_ENABLE_RUNTIMES for runtimes builds..

You can see the bot at: https://luci-milo.appspot.com/p/fuchsia/builders/ci/clang-x64-linux/b8902661942095266432

Sep 10 2019, 5:33 PM · Restricted Project
leonardchan added a comment to D67195: Adding support for overriding LLVM_ENABLE_RUNTIMES for runtimes builds..

Hi. I think this might be causing some linker failures on our x64 bots:

Sep 10 2019, 5:23 PM · Restricted Project

Sep 8 2019

leonardchan committed rG486b173cfeb5: [NewPM][Sancov] Create the Sancov Pass after building the pipelines (authored by leonardchan).
[NewPM][Sancov] Create the Sancov Pass after building the pipelines
Sep 8 2019, 12:35 AM
leonardchan added a comment to D67262: [git-llvm] Do not reinvent `@{upstream}`.

Hi! I think this might've broken the normal workflow for using this helper script shown in https://llvm.org/docs/GettingStarted.html#for-developers-to-commit-changes-from-git

Sep 8 2019, 12:35 AM · Restricted Project
leonardchan committed rL371326: [NewPM][Sancov] Create the Sancov Pass after building the pipelines.
[NewPM][Sancov] Create the Sancov Pass after building the pipelines
Sep 8 2019, 12:29 AM
leonardchan closed D67323: [NewPM][Sancov] Create the Sancov Pass after building the pipelines.
Sep 8 2019, 12:29 AM · Restricted Project, Restricted Project, Restricted Project

Sep 7 2019

leonardchan created D67323: [NewPM][Sancov] Create the Sancov Pass after building the pipelines.
Sep 7 2019, 7:25 PM · Restricted Project, Restricted Project, Restricted Project

Sep 6 2019

leonardchan added inline comments to D67253: clang-misexpect: a standalone tool for verifying the use of __builtin_expect with PGO data.
Sep 6 2019, 11:11 AM · Restricted Project, Restricted Project
leonardchan accepted D57836: [Intrinsic] Unsigned Fixed Point Saturation Multiplication Intrinsic.

LGTM. Thanks for taking over this!

Sep 6 2019, 11:05 AM · Restricted Project

Sep 4 2019

leonardchan committed rGeca01b031d44: [NewPM][Sancov] Make Sancov a Module Pass instead of 2 Passes (authored by leonardchan).
[NewPM][Sancov] Make Sancov a Module Pass instead of 2 Passes
Sep 4 2019, 1:37 PM
leonardchan committed rL370971: [NewPM][Sancov] Make Sancov a Module Pass instead of 2 Passes.
[NewPM][Sancov] Make Sancov a Module Pass instead of 2 Passes
Sep 4 2019, 1:30 PM
leonardchan closed D66988: [NewPM][Sancov] Make Sancov a Module Pass instead of 2 Passes.
Sep 4 2019, 1:30 PM · Restricted Project, Restricted Project, Restricted Project

Sep 3 2019

leonardchan added a comment to D59754: [Sema] Add c++2a designated initializer warnings.

Hi! We've noticed that for our arm bots, we're getting some flaky builds that sometimes fail with error: array designators are a C99 extension [-Werror,-Wc99-designator] and sometimes don't fail. 2 questions:

Sep 3 2019, 12:09 PM · Restricted Project, Restricted Project
leonardchan added a comment to D66988: [NewPM][Sancov] Make Sancov a Module Pass instead of 2 Passes.

*ping*

Sep 3 2019, 11:12 AM · Restricted Project, Restricted Project, Restricted Project

Aug 30 2019

leonardchan added a comment to D66988: [NewPM][Sancov] Make Sancov a Module Pass instead of 2 Passes.

*ping* This patch also seems to fix an issue with mismatched PC table and inline counters:

Aug 30 2019, 2:27 PM · Restricted Project, Restricted Project, Restricted Project
leonardchan added a comment to D66181: [AArch64][GlobalISel] Add support for narrowScalar of G_ZEXT.

Hi! After running a bisect, I believe this patch is causing the assertion error in https://bugs.llvm.org/show_bug.cgi?id=43171. Could you look into this? There is a reproducer attached to the bug.

Aug 30 2019, 11:34 AM · Restricted Project

Aug 29 2019

leonardchan accepted D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM.

Sorry about that. Still LGTM.

Aug 29 2019, 8:23 PM · Restricted Project, Restricted Project
leonardchan accepted D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM.
Aug 29 2019, 7:34 PM · Restricted Project, Restricted Project
leonardchan created D66988: [NewPM][Sancov] Make Sancov a Module Pass instead of 2 Passes.
Aug 29 2019, 6:19 PM · Restricted Project, Restricted Project, Restricted Project

Aug 27 2019

leonardchan added a comment to rG1299945b8128: Change the X86 datalayout to add three address spaces for 32 bit signed, 32 bit….

Hi! I'm seeing a test failure on our bots that I think may originate from this patch:

Aug 27 2019, 3:22 PM

Aug 22 2019

leonardchan accepted D66622: [Bugfix] fix r369705 unit test.
Aug 22 2019, 3:50 PM · Restricted Project, Restricted Project
leonardchan added a comment to D66492: [Clang][CodeGen] set alias linkage on QualType.

I think this patch might be causing some test failures on our mac bots:

Aug 22 2019, 3:25 PM · Restricted Project, Restricted Project
leonardchan added a comment to D57836: [Intrinsic] Unsigned Fixed Point Saturation Multiplication Intrinsic.

I'll try to finish the work on this patch (hence the commandeer action). I hope @leonardchan won't mind that.

Aug 22 2019, 1:42 PM · Restricted Project

Aug 21 2019

leonardchan committed rG19ec31d1a5f5: [LTO] Always mark regular LTO units with EnableSplitLTOUnit=1 under the new… (authored by leonardchan).
[LTO] Always mark regular LTO units with EnableSplitLTOUnit=1 under the new…
Aug 21 2019, 10:25 AM
leonardchan committed rL369550: [LTO] Always mark regular LTO units with EnableSplitLTOUnit=1 under the new….
[LTO] Always mark regular LTO units with EnableSplitLTOUnit=1 under the new…
Aug 21 2019, 10:24 AM
leonardchan closed D66488: [LTO] Always mark regular LTO units with EnableSplitLTOUnit=1 under the new pass manager.
Aug 21 2019, 10:24 AM · Restricted Project, Restricted Project

Aug 20 2019

leonardchan accepted D66503: [Sanitizer] Remove unused functions.

Thanks for taking care of this! Sorry for not doing this earlier. Got caught up in other stuff.

Aug 20 2019, 3:53 PM · Restricted Project
leonardchan committed rGb0a7544ee2e3: [NewPM] Run ubsan-coroutines test under the legacy pass manager only (authored by leonardchan).
[NewPM] Run ubsan-coroutines test under the legacy pass manager only
Aug 20 2019, 1:57 PM
leonardchan committed rL369442: [NewPM] Run ubsan-coroutines test under the legacy pass manager only.
[NewPM] Run ubsan-coroutines test under the legacy pass manager only
Aug 20 2019, 1:55 PM
leonardchan closed D66493: [NewPM] Run ubsan-coroutines test under the legacy pass manager only.
Aug 20 2019, 1:55 PM · Restricted Project, Restricted Project
leonardchan added a comment to D44672: [CodeGen] Disable UBSan for coroutine functions.
In D44672#1637984, @vsk wrote:

It seems that this test leads to an UNREACHABLE under the new pass manager (can check this by adding -fexperimental-new-pass-manager to the test. I think this is because the passes for lowering the llvm.coro intrinsics are not yet ported to the new PM. Would it be fine to add -fno-experimental-new-pass-manager to the test to indicate it should be run under the legacy PM only? Thanks.

Sounds reasonable to me. It would be great to include a link to some master PR for the new PM porting effort with the test change.

Aug 20 2019, 1:37 PM · Restricted Project, Restricted Project
leonardchan created D66493: [NewPM] Run ubsan-coroutines test under the legacy pass manager only.
Aug 20 2019, 1:37 PM · Restricted Project, Restricted Project
leonardchan added a comment to D66490: [NewPM] Enable the New Pass Manager by Default in Clang.

As of now, from running check-llvm and check-clang there's 2 failing tests, but I'm trying to get those addressed.

Aug 20 2019, 12:13 PM · Restricted Project
leonardchan created D66490: [NewPM] Enable the New Pass Manager by Default in Clang.
Aug 20 2019, 12:11 PM · Restricted Project
leonardchan added a comment to D44672: [CodeGen] Disable UBSan for coroutine functions.

It seems that this test leads to an UNREACHABLE under the new pass manager (can check this by adding -fexperimental-new-pass-manager to the test. I think this is because the passes for lowering the llvm.coro intrinsics are not yet ported to the new PM. Would it be fine to add -fno-experimental-new-pass-manager to the test to indicate it should be run under the legacy PM only? Thanks.

Aug 20 2019, 12:02 PM · Restricted Project, Restricted Project
leonardchan created D66488: [LTO] Always mark regular LTO units with EnableSplitLTOUnit=1 under the new pass manager.
Aug 20 2019, 11:34 AM · Restricted Project, Restricted Project

Aug 19 2019

leonardchan added a comment to D65653: [AArch64] Change location of frame-record within callee-save area..

Could you temporarily revert this in the meantime? This is blocking our clang roll that we need to fix another Clang issue we're hitting.

Aug 19 2019, 10:49 PM · Restricted Project
leonardchan added a comment to D65653: [AArch64] Change location of frame-record within callee-save area..

Hi again. After some bisecting, we found that the relanding of this (rGf28e1128d9e) was causing a segfault on our aarch64 asan bots.

Aug 19 2019, 5:51 PM · Restricted Project

Aug 16 2019

leonardchan added a comment to rL369150: [TSan] Don't guard #include <xpc/xpc.h>.

I think this is causing this error on our mac builders:

Aug 16 2019, 3:43 PM