Page MenuHomePhabricator

leonardchan (Leonard Chan)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 25 2018, 1:47 PM (37 w, 6 d)

Recent Activity

Yesterday

leonardchan added inline comments to D55625: [Intrinsic] Unsigned Fixed Point Multiplication Intrinsic.
Tue, Jan 15, 4:49 PM
leonardchan updated the diff for D55625: [Intrinsic] Unsigned Fixed Point Multiplication Intrinsic.
Tue, Jan 15, 4:47 PM
leonardchan updated the diff for D56746: [Fixed Point Arithmetic] Add APFixedPoint to APValue.
Tue, Jan 15, 4:09 PM · Restricted Project
leonardchan added inline comments to D55447: [Sema] Fix Modified Type in address_space AttributedType.
Tue, Jan 15, 3:30 PM · Restricted Project
leonardchan updated the diff for D55447: [Sema] Fix Modified Type in address_space AttributedType.
Tue, Jan 15, 3:29 PM · Restricted Project
leonardchan added a comment to D53738: [Fixed Point Arithmetic] Fixed Point Addition.

I'm fine with making this change under the assumption that we've gotten the language rule right. Even if that weren't abstractly reasonable for general language work — and I do think it's reasonable when we have a good-faith question about the right semantics — this is clearly still an experimental implementation and will be for several months yet, and hopefully it won't take that long for us to get a response.

@rjmccall Have you received a response yet? If not, do you think you have an estimate on the response time, or also mind sharing the contact information if that's ok?

I just have a coworker who's part of the committee. I think you might be over-opimistic about how quickly things get answered with the C committee, though. We should not allow our work to be blocked waiting for a response.

The committee was less helpful than I hoped, but what I decided to take away from their response was that we should not artificially lose precision here by separating the signedness conversion from the operation.

Tue, Jan 15, 3:17 PM · Restricted Project
leonardchan added a comment to D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation.

Yeah, I would recommend splitting the APFixedPoint in APValue changes into a separate patch.

Tue, Jan 15, 3:07 PM · Restricted Project
leonardchan updated the diff for D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation.
Tue, Jan 15, 3:07 PM · Restricted Project
leonardchan added a comment to D56746: [Fixed Point Arithmetic] Add APFixedPoint to APValue.

Regarding tests, I couldn't actually find any under clang/unittests that test APValue specifically. Is it worth it to add some still?

Tue, Jan 15, 3:05 PM · Restricted Project
leonardchan added a parent revision for D56746: [Fixed Point Arithmetic] Add APFixedPoint to APValue: D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation.
Tue, Jan 15, 3:02 PM · Restricted Project
leonardchan added a child revision for D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation: D56746: [Fixed Point Arithmetic] Add APFixedPoint to APValue.
Tue, Jan 15, 3:02 PM · Restricted Project
leonardchan added a child revision for D56746: [Fixed Point Arithmetic] Add APFixedPoint to APValue: D53738: [Fixed Point Arithmetic] Fixed Point Addition.
Tue, Jan 15, 3:02 PM · Restricted Project
leonardchan added a parent revision for D53738: [Fixed Point Arithmetic] Fixed Point Addition: D56746: [Fixed Point Arithmetic] Add APFixedPoint to APValue.
Tue, Jan 15, 3:02 PM · Restricted Project
leonardchan created D56746: [Fixed Point Arithmetic] Add APFixedPoint to APValue.
Tue, Jan 15, 3:02 PM · Restricted Project
leonardchan added inline comments to D55447: [Sema] Fix Modified Type in address_space AttributedType.
Tue, Jan 15, 1:09 PM · Restricted Project
leonardchan added inline comments to D55447: [Sema] Fix Modified Type in address_space AttributedType.
Tue, Jan 15, 1:05 PM · Restricted Project

Mon, Jan 14

leonardchan updated the diff for D55447: [Sema] Fix Modified Type in address_space AttributedType.
Mon, Jan 14, 9:49 PM · Restricted Project
leonardchan updated the diff for D55447: [Sema] Fix Modified Type in address_space AttributedType.
Mon, Jan 14, 9:46 PM · Restricted Project
leonardchan added inline comments to D55447: [Sema] Fix Modified Type in address_space AttributedType.
Mon, Jan 14, 9:45 PM · Restricted Project
leonardchan updated the diff for D55447: [Sema] Fix Modified Type in address_space AttributedType.
Mon, Jan 14, 9:40 PM · Restricted Project

Fri, Jan 11

leonardchan added a comment to D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation.

I ended up adding a lot to this patch, so feel free to let me know if I should split this up if it's more difficult to review.

Fri, Jan 11, 8:33 PM · Restricted Project
leonardchan updated the diff for D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation.
Fri, Jan 11, 8:31 PM · Restricted Project

Wed, Jan 9

leonardchan updated the diff for D55844: [Fixed Point Arithmetic] Fixed Point Subtraction.
Wed, Jan 9, 1:35 PM · Restricted Project
leonardchan added a comment to D55625: [Intrinsic] Unsigned Fixed Point Multiplication Intrinsic.

Any more comments on this patch?

Wed, Jan 9, 1:08 PM
leonardchan added a comment to D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.

Nothing sticks out to me, so I think it looks good. Hard to tell if there are any sneaky edge cases in the lowering steps, though.

Maybe you should rebase this on top of the unsigned patch, since they're touching all the same places. Or are you waiting for it to land?

Wed, Jan 9, 1:08 PM
leonardchan added a comment to D56470: [NewPM] Second attempt at porting ASan.

I think a key thing that this is currently missing (or I'm missing it when looking at hte patch) the core shift that we made working through how to do sanitizer stuff with MSan.

Specifically, I suspect that we don't need any analysis layer, and the module and function layer can operate entirely independently. This would require roughly the following changes to the current ASan infrastructure:

Wed, Jan 9, 11:06 AM

Tue, Jan 8

leonardchan updated subscribers of D56470: [NewPM] Second attempt at porting ASan.
Tue, Jan 8, 7:00 PM
leonardchan added a comment to D54337: [ASan] Make AddressSanitizer a ModulePass.

Posted second attempt at porting ASan using an analysis at D56470.

Tue, Jan 8, 6:59 PM · Restricted Project
leonardchan created D56470: [NewPM] Second attempt at porting ASan.
Tue, Jan 8, 6:59 PM

Thu, Jan 3

leonardchan added a comment to D54337: [ASan] Make AddressSanitizer a ModulePass.

@leonardchan Are you making any progress here?

Thu, Jan 3, 10:37 AM · Restricted Project

Tue, Dec 18

leonardchan added a parent revision for D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation: D46925: [Fixed Point Arithmetic] Remaining Binary Operations on Primary Fixed Point Types.
Tue, Dec 18, 4:51 PM · Restricted Project
leonardchan added a child revision for D46925: [Fixed Point Arithmetic] Remaining Binary Operations on Primary Fixed Point Types: D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation.
Tue, Dec 18, 4:51 PM · Restricted Project
leonardchan added a parent revision for D53738: [Fixed Point Arithmetic] Fixed Point Addition: D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation.
Tue, Dec 18, 4:51 PM · Restricted Project
leonardchan added a child revision for D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation: D53738: [Fixed Point Arithmetic] Fixed Point Addition.
Tue, Dec 18, 4:51 PM · Restricted Project
leonardchan removed a parent revision for D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation: D53738: [Fixed Point Arithmetic] Fixed Point Addition.
Tue, Dec 18, 4:50 PM · Restricted Project
leonardchan removed a child revision for D53738: [Fixed Point Arithmetic] Fixed Point Addition: D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation.
Tue, Dec 18, 4:50 PM · Restricted Project
leonardchan added a child revision for D53738: [Fixed Point Arithmetic] Fixed Point Addition: D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation.
Tue, Dec 18, 4:50 PM · Restricted Project
leonardchan added a parent revision for D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation: D53738: [Fixed Point Arithmetic] Fixed Point Addition.
Tue, Dec 18, 4:50 PM · Restricted Project
leonardchan created D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation.
Tue, Dec 18, 4:50 PM · Restricted Project
leonardchan added a parent revision for D55844: [Fixed Point Arithmetic] Fixed Point Subtraction: D46925: [Fixed Point Arithmetic] Remaining Binary Operations on Primary Fixed Point Types.
Tue, Dec 18, 11:38 AM · Restricted Project
leonardchan added a child revision for D46925: [Fixed Point Arithmetic] Remaining Binary Operations on Primary Fixed Point Types: D55844: [Fixed Point Arithmetic] Fixed Point Subtraction.
Tue, Dec 18, 11:38 AM · Restricted Project
leonardchan added a child revision for D55844: [Fixed Point Arithmetic] Fixed Point Subtraction: D53738: [Fixed Point Arithmetic] Fixed Point Addition.
Tue, Dec 18, 11:37 AM · Restricted Project
leonardchan added a parent revision for D53738: [Fixed Point Arithmetic] Fixed Point Addition: D55844: [Fixed Point Arithmetic] Fixed Point Subtraction.
Tue, Dec 18, 11:37 AM · Restricted Project
leonardchan created D55844: [Fixed Point Arithmetic] Fixed Point Subtraction.
Tue, Dec 18, 11:33 AM · Restricted Project

Mon, Dec 17

leonardchan added a comment to D53738: [Fixed Point Arithmetic] Fixed Point Addition.

I'm fine with making this change under the assumption that we've gotten the language rule right. Even if that weren't abstractly reasonable for general language work — and I do think it's reasonable when we have a good-faith question about the right semantics — this is clearly still an experimental implementation and will be for several months yet, and hopefully it won't take that long for us to get a response.

Mon, Dec 17, 10:57 AM · Restricted Project

Dec 14 2018

leonardchan added a comment to D55625: [Intrinsic] Unsigned Fixed Point Multiplication Intrinsic.

Maybe a test with scale == bitwidth? Other than that it looks good to me.

Dec 14 2018, 3:02 PM
leonardchan updated the diff for D55625: [Intrinsic] Unsigned Fixed Point Multiplication Intrinsic.
Dec 14 2018, 3:02 PM
leonardchan created D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
Dec 14 2018, 2:19 PM

Dec 12 2018

leonardchan created D55625: [Intrinsic] Unsigned Fixed Point Multiplication Intrinsic.
Dec 12 2018, 3:39 PM

Dec 11 2018

leonardchan committed rL348912: [Intrinsic] Signed Fixed Point Multiplication Intrinsic.
[Intrinsic] Signed Fixed Point Multiplication Intrinsic
Dec 11 2018, 10:32 PM
leonardchan closed D54719: [Intrinsic] Signed Fixed Point Multiplication Intrinsic.
Dec 11 2018, 10:32 PM
leonardchan added inline comments to D55447: [Sema] Fix Modified Type in address_space AttributedType.
Dec 11 2018, 2:03 PM · Restricted Project
leonardchan added a comment to D54337: [ASan] Make AddressSanitizer a ModulePass.

Analysis can be any information which is not an IR itself. TargetLibraryInfo, DominatorTree, GlobalsMetadata... whatever.
The only problem that you might find when using your custom analysis from the pass will be similar to the current dichotomy of module & function ASan.
You can not *run* module analysis from within a function pass. It can only be run on a module level.

Dec 11 2018, 12:48 PM · Restricted Project
leonardchan added a comment to D54719: [Intrinsic] Signed Fixed Point Multiplication Intrinsic.

*ping* Any more comments on this patch?

Dec 11 2018, 9:50 AM

Dec 10 2018

leonardchan added inline comments to D55447: [Sema] Fix Modified Type in address_space AttributedType.
Dec 10 2018, 4:55 PM · Restricted Project
leonardchan updated the diff for D55447: [Sema] Fix Modified Type in address_space AttributedType.
  • Added the CXX11 test
Dec 10 2018, 4:55 PM · Restricted Project
leonardchan added a comment to D53738: [Fixed Point Arithmetic] Fixed Point Addition.

We sent the question out, but we haven't gotten a response yet. I think going forward under the idea that this just changes the type but does the operation on the original operand types is the right way to go forward in the short term.

Dec 10 2018, 12:34 PM · Restricted Project
leonardchan added inline comments to D55447: [Sema] Fix Modified Type in address_space AttributedType.
Dec 10 2018, 12:31 PM · Restricted Project
leonardchan updated the diff for D55447: [Sema] Fix Modified Type in address_space AttributedType.
Dec 10 2018, 12:31 PM · Restricted Project
leonardchan added a comment to D53738: [Fixed Point Arithmetic] Fixed Point Addition.

Okay, thanks, that makes sense to me.

I'll ask around to find a way to contact the C committee.

Dec 10 2018, 11:35 AM · Restricted Project
leonardchan updated the diff for D55447: [Sema] Fix Modified Type in address_space AttributedType.
Dec 10 2018, 10:41 AM · Restricted Project

Dec 7 2018

leonardchan updated the diff for D54719: [Intrinsic] Signed Fixed Point Multiplication Intrinsic.
Dec 7 2018, 3:42 PM
leonardchan updated the diff for D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space.
Dec 7 2018, 3:19 PM · Restricted Project
leonardchan added a parent revision for D55447: [Sema] Fix Modified Type in address_space AttributedType: D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space.
Dec 7 2018, 11:27 AM · Restricted Project
leonardchan added a child revision for D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space: D55447: [Sema] Fix Modified Type in address_space AttributedType.
Dec 7 2018, 11:27 AM · Restricted Project
leonardchan removed a child revision for D55447: [Sema] Fix Modified Type in address_space AttributedType: D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space.
Dec 7 2018, 11:27 AM · Restricted Project
leonardchan removed a parent revision for D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space: D55447: [Sema] Fix Modified Type in address_space AttributedType.
Dec 7 2018, 11:27 AM · Restricted Project
leonardchan added a child revision for D55447: [Sema] Fix Modified Type in address_space AttributedType: D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space.
Dec 7 2018, 11:27 AM · Restricted Project
leonardchan added a parent revision for D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space: D55447: [Sema] Fix Modified Type in address_space AttributedType.
Dec 7 2018, 11:27 AM · Restricted Project
leonardchan created D55447: [Sema] Fix Modified Type in address_space AttributedType.
Dec 7 2018, 11:27 AM · Restricted Project

Dec 6 2018

leonardchan added inline comments to D54719: [Intrinsic] Signed Fixed Point Multiplication Intrinsic.
Dec 6 2018, 1:09 PM
leonardchan updated the diff for D54719: [Intrinsic] Signed Fixed Point Multiplication Intrinsic.
Dec 6 2018, 1:06 PM

Dec 5 2018

leonardchan added inline comments to D54719: [Intrinsic] Signed Fixed Point Multiplication Intrinsic.
Dec 5 2018, 5:21 PM
leonardchan committed rL348442: [Sema/Attribute] Check for noderef attribute.
[Sema/Attribute] Check for noderef attribute
Dec 5 2018, 5:09 PM
leonardchan committed rC348442: [Sema/Attribute] Check for noderef attribute.
[Sema/Attribute] Check for noderef attribute
Dec 5 2018, 5:09 PM
leonardchan closed D49511: [Sema/Attribute] Check for noderef attribute.
Dec 5 2018, 5:09 PM · Restricted Project
leonardchan updated the diff for D49511: [Sema/Attribute] Check for noderef attribute.
Dec 5 2018, 5:06 PM · Restricted Project
leonardchan committed rL348434: [Sema] Push and Pop Expression Evaluation Context Records at the start and end….
[Sema] Push and Pop Expression Evaluation Context Records at the start and end…
Dec 5 2018, 4:14 PM
leonardchan committed rC348434: [Sema] Push and Pop Expression Evaluation Context Records at the start and end….
[Sema] Push and Pop Expression Evaluation Context Records at the start and end…
Dec 5 2018, 4:14 PM
leonardchan closed D54014: [Sema] Push and Pop Expression Evaluation Context Records at the start and end of function definitions.
Dec 5 2018, 4:13 PM · Restricted Project
leonardchan updated the diff for D54014: [Sema] Push and Pop Expression Evaluation Context Records at the start and end of function definitions.
Dec 5 2018, 4:10 PM · Restricted Project
leonardchan updated the diff for D54719: [Intrinsic] Signed Fixed Point Multiplication Intrinsic.
Dec 5 2018, 1:32 PM
leonardchan added a comment to D54719: [Intrinsic] Signed Fixed Point Multiplication Intrinsic.

*ping* @craig.topper @RKSimon Any more comments on this patch?

Dec 5 2018, 12:03 PM
leonardchan added inline comments to D53738: [Fixed Point Arithmetic] Fixed Point Addition.
Dec 5 2018, 11:48 AM · Restricted Project
leonardchan updated the diff for D53738: [Fixed Point Arithmetic] Fixed Point Addition.
Dec 5 2018, 11:48 AM · Restricted Project
Herald updated subscribers of D20749: Introduce support for relative C++ ABI gated on LTO visibility..
Dec 5 2018, 10:28 AM

Dec 4 2018

leonardchan added inline comments to D54719: [Intrinsic] Signed Fixed Point Multiplication Intrinsic.
Dec 4 2018, 3:56 PM
leonardchan added inline comments to D53738: [Fixed Point Arithmetic] Fixed Point Addition.
Dec 4 2018, 3:10 PM · Restricted Project
leonardchan added a comment to D54719: [Intrinsic] Signed Fixed Point Multiplication Intrinsic.

You might need PromoteIntOp_SMULFIX for certain targets, like 64-bit RISCV.

Dec 4 2018, 1:33 PM
leonardchan updated the diff for D54719: [Intrinsic] Signed Fixed Point Multiplication Intrinsic.
Dec 4 2018, 1:33 PM
leonardchan added a comment to D49511: [Sema/Attribute] Check for noderef attribute.

*ping* @rsmith Any more comments on this patch or the one before it (https://reviews.llvm.org/D54014)? That one has the fix for pushing and popping another ExprEvalContext before acting on a function body in this patch.

Dec 4 2018, 10:34 AM · Restricted Project
leonardchan added inline comments to D53738: [Fixed Point Arithmetic] Fixed Point Addition.
Dec 4 2018, 9:55 AM · Restricted Project

Dec 3 2018

leonardchan added a comment to D54719: [Intrinsic] Signed Fixed Point Multiplication Intrinsic.

@craig.topper @RKSimon @efriedma Any more comments on this patch?

Dec 3 2018, 2:54 PM
leonardchan added inline comments to D53738: [Fixed Point Arithmetic] Fixed Point Addition.
Dec 3 2018, 2:41 PM · Restricted Project

Nov 30 2018

leonardchan added a comment to D54719: [Intrinsic] Signed Fixed Point Multiplication Intrinsic.

*ping* Does anyone have any more comments on this patch?

Nov 30 2018, 2:33 PM
leonardchan added inline comments to D53738: [Fixed Point Arithmetic] Fixed Point Addition.
Nov 30 2018, 2:25 PM · Restricted Project
leonardchan updated the diff for D53738: [Fixed Point Arithmetic] Fixed Point Addition.
Nov 30 2018, 2:25 PM · Restricted Project

Nov 29 2018

leonardchan added inline comments to D53738: [Fixed Point Arithmetic] Fixed Point Addition.
Nov 29 2018, 2:31 PM · Restricted Project
leonardchan updated the diff for D53738: [Fixed Point Arithmetic] Fixed Point Addition.
Nov 29 2018, 2:30 PM · Restricted Project
leonardchan added a comment to D53738: [Fixed Point Arithmetic] Fixed Point Addition.

It's certainly interesting to degenerate integer-with-fixedpoint to just a mul (since the scaling factor is 2^-n * 2^0, which is just 2^-n), but in the general case you can't avoid doing the scale alignment. Unless I'm missing something.

Nov 29 2018, 10:08 AM · Restricted Project