Page MenuHomePhabricator

leonardchan (Leonard Chan)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 25 2018, 1:47 PM (218 w, 1 d)

Recent Activity

Yesterday

leonardchan added a comment to D128387: [hwasan] Add __hwasan_record_frame_record to the hwasan interface.

Could you please move refactoring (like extraction emitPrologue) into a separate CL?

We also need one test for runtime and one test for generated IR.

Thu, Jun 30, 3:38 PM · Restricted Project, Restricted Project, Restricted Project
leonardchan accepted D128754: Refactor LLVM compression namespaces (Part 1: remove crc32).

LGTM. Should probably add [llvm] to the subject also. Generally it's helpful for immediately knowing which subrepo you're touching.

Thu, Jun 30, 3:26 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
leonardchan accepted D128953: [NFC] refactor compression namespaces making way for a possible introduction of alternatives to zlib compression in the llvm toolchain..

LGTM. Should also probably add [NFC] to the start of the subject

Thu, Jun 30, 3:19 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Wed, Jun 29

leonardchan added inline comments to D128754: Refactor LLVM compression namespaces (Part 1: remove crc32).
Wed, Jun 29, 3:32 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Tue, Jun 28

leonardchan updated the diff for D128387: [hwasan] Add __hwasan_record_frame_record to the hwasan interface.

Added tests and this patch doesn't contain refactoring.

Tue, Jun 28, 4:57 PM · Restricted Project, Restricted Project, Restricted Project
leonardchan added a comment to D128754: Refactor LLVM compression namespaces (Part 1: remove crc32).

Feedback needed on:
this namespace approach will result in tooling compression methods being set at compile time, however we may want to aim for a runtime configurable approach in the future, likely a new revision of the compressed data formats that llvm interfaces with with outside tools IE:

  • clang ast serialization code could be changed so compressed data could have a flag indicating a compression type.
  • profile data code could be changed so compressed data could have a flag indicating a compression type as well.
Tue, Jun 28, 4:23 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
leonardchan added a comment to D108469: Improve handling of static assert messages..

I think this might be the cause of the many libc++ static_assert failures we're seeing on our builders: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8810079977358640657/overview

Tue, Jun 28, 2:52 PM · Restricted Project, Restricted Project, Restricted Project
leonardchan committed rG9553d695804c: [NFC][HWASan] Refactor hwasan pass (authored by leonardchan).
[NFC][HWASan] Refactor hwasan pass
Tue, Jun 28, 12:10 PM · Restricted Project, Restricted Project
leonardchan closed D128551: [NFC][HWASan] Refactor hwasan pass.
Tue, Jun 28, 12:09 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Jun 24

leonardchan added a comment to D128567: [WIP][Fuchsia] Set LLVM_TOOL_LLD_BUILD to allow some extra runtimes tests to run.

Won't be landing this until I'm sure any new tests that will be running from this won't fail locally.

Fri, Jun 24, 5:00 PM · Restricted Project, Restricted Project
leonardchan added a comment to D128567: [WIP][Fuchsia] Set LLVM_TOOL_LLD_BUILD to allow some extra runtimes tests to run.

An alternative approach to this is update this bit of cmake in compiler-rt/CMakeLists.txt:

Fri, Jun 24, 4:52 PM · Restricted Project, Restricted Project
leonardchan added a comment to D128567: [WIP][Fuchsia] Set LLVM_TOOL_LLD_BUILD to allow some extra runtimes tests to run.

Won't be landing this until I'm sure any new tests that will be running from this won't fail locally.

Fri, Jun 24, 4:50 PM · Restricted Project, Restricted Project
leonardchan requested review of D128567: [WIP][Fuchsia] Set LLVM_TOOL_LLD_BUILD to allow some extra runtimes tests to run.
Fri, Jun 24, 4:49 PM · Restricted Project, Restricted Project
leonardchan requested review of D128551: [NFC][HWASan] Refactor hwasan pass.
Fri, Jun 24, 12:32 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 22

leonardchan requested review of D128387: [hwasan] Add __hwasan_record_frame_record to the hwasan interface.
Wed, Jun 22, 3:27 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 8

leonardchan accepted D127334: [compiler-rt][test] Restore original symbolize_stack test.
Wed, Jun 8, 12:14 PM · Restricted Project, Restricted Project
leonardchan added a reverting change for rGb37d84aa8d59: Reland "[NFC][compiler-rt][asan] Unify asan and lsan allocator settings": rG060907dd0080: Revert "Reland "[NFC][compiler-rt][asan] Unify asan and lsan allocator….
Wed, Jun 8, 11:57 AM · Restricted Project, Restricted Project
leonardchan committed rG060907dd0080: Revert "Reland "[NFC][compiler-rt][asan] Unify asan and lsan allocator… (authored by leonardchan).
Revert "Reland "[NFC][compiler-rt][asan] Unify asan and lsan allocator…
Wed, Jun 8, 11:57 AM · Restricted Project, Restricted Project
leonardchan committed rG033af5a537e6: [compiler-rt][hwasan] Check address tagging mode in InitializeOsSupport on… (authored by leonardchan).
[compiler-rt][hwasan] Check address tagging mode in InitializeOsSupport on…
Wed, Jun 8, 11:35 AM · Restricted Project, Restricted Project
leonardchan closed D127262: [compiler-rt][hwasan] Check address tagging mode in InitializeOsSupport on Fuchsia.
Wed, Jun 8, 11:35 AM · Restricted Project, Restricted Project
leonardchan updated the diff for D127262: [compiler-rt][hwasan] Check address tagging mode in InitializeOsSupport on Fuchsia.
Wed, Jun 8, 10:57 AM · Restricted Project, Restricted Project

Tue, Jun 7

leonardchan committed rGb37d84aa8d59: Reland "[NFC][compiler-rt][asan] Unify asan and lsan allocator settings" (authored by leonardchan).
Reland "[NFC][compiler-rt][asan] Unify asan and lsan allocator settings"
Tue, Jun 7, 6:11 PM · Restricted Project, Restricted Project
leonardchan added a reverting change for rGdd045ddffc51: [NFC][compiler-rt][asan] Unify asan and lsan allocator settings: rG13eb4fc3ce1f: Revert "[NFC][compiler-rt][asan] Unify asan and lsan allocator settings".
Tue, Jun 7, 5:35 PM · Restricted Project, Restricted Project
leonardchan committed rG13eb4fc3ce1f: Revert "[NFC][compiler-rt][asan] Unify asan and lsan allocator settings" (authored by leonardchan).
Revert "[NFC][compiler-rt][asan] Unify asan and lsan allocator settings"
Tue, Jun 7, 5:35 PM · Restricted Project, Restricted Project
leonardchan added a reverting change for D126927: [NFC][compiler-rt][asan] Unify asan and lsan allocator settings: rG13eb4fc3ce1f: Revert "[NFC][compiler-rt][asan] Unify asan and lsan allocator settings".
Tue, Jun 7, 5:34 PM · Restricted Project, Restricted Project
leonardchan committed rGd1fb0a5a6343: Fix for e1d84c421df1bd496918bc4dd30f040d47906a77 (authored by leonardchan).
Fix for e1d84c421df1bd496918bc4dd30f040d47906a77
Tue, Jun 7, 5:30 PM · Restricted Project, Restricted Project
leonardchan committed rG4b15e665f8d9: [compiler-rt][lsan] Choose lsan allocator via SANITIZER_CAN_USE_ALLOCATOR64 (authored by leonardchan).
[compiler-rt][lsan] Choose lsan allocator via SANITIZER_CAN_USE_ALLOCATOR64
Tue, Jun 7, 5:24 PM · Restricted Project, Restricted Project
leonardchan closed D126825: [compiler-rt][lsan] Choose lsan allocator via SANITIZER_CAN_USE_ALLOCATOR64.
Tue, Jun 7, 5:24 PM · Restricted Project, Restricted Project
leonardchan committed rGdd045ddffc51: [NFC][compiler-rt][asan] Unify asan and lsan allocator settings (authored by leonardchan).
[NFC][compiler-rt][asan] Unify asan and lsan allocator settings
Tue, Jun 7, 5:22 PM · Restricted Project, Restricted Project
leonardchan closed D126927: [NFC][compiler-rt][asan] Unify asan and lsan allocator settings.
Tue, Jun 7, 5:21 PM · Restricted Project, Restricted Project
leonardchan requested review of D127262: [compiler-rt][hwasan] Check address tagging mode in InitializeOsSupport on Fuchsia.
Tue, Jun 7, 5:18 PM · Restricted Project, Restricted Project
leonardchan added a comment to D126927: [NFC][compiler-rt][asan] Unify asan and lsan allocator settings.

*ping*

Tue, Jun 7, 4:46 PM · Restricted Project, Restricted Project
leonardchan committed rGe1d84c421df1: [compiler-rt][sanitizer] Have all OOM-related error messages start with the… (authored by leonardchan).
[compiler-rt][sanitizer] Have all OOM-related error messages start with the…
Tue, Jun 7, 4:46 PM · Restricted Project, Restricted Project
leonardchan added a comment to D126825: [compiler-rt][lsan] Choose lsan allocator via SANITIZER_CAN_USE_ALLOCATOR64.

*ping*

Tue, Jun 7, 4:46 PM · Restricted Project, Restricted Project
leonardchan closed D127161: [compiler-rt][sanitizer] Have all OOM-related error messages start with the same format.
Tue, Jun 7, 4:46 PM · Restricted Project, Restricted Project
leonardchan accepted D126580: [compiler-rt] Avoid truncating Symbolizer output.
Tue, Jun 7, 2:48 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D127161: [compiler-rt][sanitizer] Have all OOM-related error messages start with the same format.
Tue, Jun 7, 11:55 AM · Restricted Project, Restricted Project

Mon, Jun 6

leonardchan added inline comments to D126580: [compiler-rt] Avoid truncating Symbolizer output.
Mon, Jun 6, 4:21 PM · Restricted Project, Restricted Project
leonardchan requested review of D127161: [compiler-rt][sanitizer] Have all OOM-related error messages start with the same format.
Mon, Jun 6, 3:39 PM · Restricted Project, Restricted Project

Thu, Jun 2

leonardchan updated the diff for D126927: [NFC][compiler-rt][asan] Unify asan and lsan allocator settings.
Thu, Jun 2, 4:08 PM · Restricted Project, Restricted Project
leonardchan added inline comments to D123822: [compiler-rt][lsan] Share platform allocator settings between ASan and LSan.
Thu, Jun 2, 3:22 PM · Restricted Project, Restricted Project
leonardchan requested review of D126927: [NFC][compiler-rt][asan] Unify asan and lsan allocator settings.
Thu, Jun 2, 3:21 PM · Restricted Project, Restricted Project

Wed, Jun 1

leonardchan updated the diff for D126825: [compiler-rt][lsan] Choose lsan allocator via SANITIZER_CAN_USE_ALLOCATOR64.
Wed, Jun 1, 2:14 PM · Restricted Project, Restricted Project
leonardchan added inline comments to D123822: [compiler-rt][lsan] Share platform allocator settings between ASan and LSan.
Wed, Jun 1, 2:11 PM · Restricted Project, Restricted Project
leonardchan requested review of D126825: [compiler-rt][lsan] Choose lsan allocator via SANITIZER_CAN_USE_ALLOCATOR64.
Wed, Jun 1, 2:10 PM · Restricted Project, Restricted Project

May 24 2022

leonardchan added a reverting change for rGf6038cdca031: [compiler-rt][scudo] Simplify TBI checks: rG6edbdf80cac1: Revert "[compiler-rt][scudo] Add missing preprocessor token" and "[compiler-rt]….
May 24 2022, 11:32 AM · Restricted Project, Restricted Project
leonardchan added a reverting change for rG676eaa2ca967: [compiler-rt][scudo] Add missing preprocessor token: rG6edbdf80cac1: Revert "[compiler-rt][scudo] Add missing preprocessor token" and "[compiler-rt]….
May 24 2022, 11:32 AM · Restricted Project, Restricted Project
leonardchan committed rG6edbdf80cac1: Revert "[compiler-rt][scudo] Add missing preprocessor token" and "[compiler-rt]… (authored by leonardchan).
Revert "[compiler-rt][scudo] Add missing preprocessor token" and "[compiler-rt]…
May 24 2022, 11:31 AM · Restricted Project, Restricted Project
leonardchan added a reverting change for D111080: [compiler-rt][scudo] Simplify TBI checks: rG6edbdf80cac1: Revert "[compiler-rt][scudo] Add missing preprocessor token" and "[compiler-rt]….
May 24 2022, 11:31 AM · Restricted Project, Restricted Project
leonardchan committed rG676eaa2ca967: [compiler-rt][scudo] Add missing preprocessor token (authored by leonardchan).
[compiler-rt][scudo] Add missing preprocessor token
May 24 2022, 11:12 AM · Restricted Project, Restricted Project
leonardchan committed rGf6038cdca031: [compiler-rt][scudo] Simplify TBI checks (authored by leonardchan).
[compiler-rt][scudo] Simplify TBI checks
May 24 2022, 10:53 AM · Restricted Project, Restricted Project
leonardchan closed D111080: [compiler-rt][scudo] Simplify TBI checks.
May 24 2022, 10:53 AM · Restricted Project, Restricted Project
leonardchan added a comment to D123822: [compiler-rt][lsan] Share platform allocator settings between ASan and LSan.

*ping* any more comments?

May 24 2022, 10:25 AM · Restricted Project, Restricted Project
leonardchan committed rGc8644ea88ea2: [compiler-rt][lsan] Update CanBeAHeapPointer for AArch64 (authored by leonardchan).
[compiler-rt][lsan] Update CanBeAHeapPointer for AArch64
May 24 2022, 10:24 AM · Restricted Project, Restricted Project
leonardchan closed D123814: [compiler-rt][lsan] Update CanBeAHeapPointer for AArch64.
May 24 2022, 10:24 AM · Restricted Project, Restricted Project

May 23 2022

leonardchan added inline comments to D126102: [compiler-rt][test] Fix flake in symbolize_stack test.
May 23 2022, 7:40 PM · Restricted Project, Restricted Project

May 6 2022

leonardchan accepted D125082: [CMake] Include llvm-debuginfod-find in Fuchsia toolchain.
May 6 2022, 3:57 PM · Restricted Project, Restricted Project

Apr 21 2022

leonardchan added inline comments to D123822: [compiler-rt][lsan] Share platform allocator settings between ASan and LSan.
Apr 21 2022, 1:20 PM · Restricted Project, Restricted Project
leonardchan added inline comments to D123814: [compiler-rt][lsan] Update CanBeAHeapPointer for AArch64.
Apr 21 2022, 12:23 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D123814: [compiler-rt][lsan] Update CanBeAHeapPointer for AArch64.
Apr 21 2022, 12:23 PM · Restricted Project, Restricted Project

Apr 14 2022

leonardchan updated the diff for D123822: [compiler-rt][lsan] Share platform allocator settings between ASan and LSan.
Apr 14 2022, 2:26 PM · Restricted Project, Restricted Project
leonardchan requested review of D123822: [compiler-rt][lsan] Share platform allocator settings between ASan and LSan.
Apr 14 2022, 2:25 PM · Restricted Project, Restricted Project
leonardchan requested review of D123814: [compiler-rt][lsan] Update CanBeAHeapPointer for AArch64.
Apr 14 2022, 12:47 PM · Restricted Project, Restricted Project

Mar 30 2022

leonardchan added a comment to rGa9909d23e9bb: [clang][extractapi] Tie API and serialization to the FrontendAction.

Hi, I suspect that either this patch or 529a0570f7e8c5144bd3ad057e43f00e3af58d1b led to the test failures we're seeing on our clang windows builders (https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-windows-x64/b8818245900241242433/test-results):

Mar 30 2022, 1:25 PM · Restricted Project, Restricted Project

Feb 11 2022

leonardchan accepted D119598: [sanitizers] Fix missing header for mac builds.
Feb 11 2022, 3:00 PM · Restricted Project
leonardchan abandoned D114053: Add JSONScopedPrinter as a subclass to ScopedPrinter with array output.
Feb 11 2022, 11:59 AM · Restricted Project
leonardchan commandeered D114053: Add JSONScopedPrinter as a subclass to ScopedPrinter with array output.

Can this be abandoned now?

Feb 11 2022, 11:59 AM · Restricted Project

Feb 8 2022

leonardchan committed rG4ac58b61022d: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the… (authored by leonardchan).
[clang][Fuchsia] Ensure static sanitizer libs are only linked in after the…
Feb 8 2022, 10:54 AM
leonardchan closed D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check.
Feb 8 2022, 10:53 AM · Restricted Project, Restricted Project
leonardchan added a comment to D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check.

Have you checked if all the tests are still passing?

Feb 8 2022, 9:33 AM · Restricted Project, Restricted Project
leonardchan updated the diff for D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check.
Feb 8 2022, 9:32 AM · Restricted Project, Restricted Project

Feb 7 2022

leonardchan updated the diff for D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check.
Feb 7 2022, 5:55 PM · Restricted Project, Restricted Project
leonardchan requested review of D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check.
Feb 7 2022, 4:08 PM · Restricted Project, Restricted Project

Jan 20 2022

leonardchan added a comment to D117537: [cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm.

Hi, I suspect that this patch (or D117815) led to the build failure we're seeing on our builders (https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8824480583333895809):

Jan 20 2022, 3:31 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 18 2022

leonardchan added a comment to D116179: [InstrProf][NFC] Do not assume size of counter type.

It looks like this (expectedly) broke our downstream builder (https://ci.chromium.org/ui/p/fuchsia/builders/ci/clang_toolchain.ci.core.x64-debug/b8824668235249206913/overview). We can do a soft transition by checking against the clang git revision in our build, then setting a macro if the clang includes this change, then toggling between types based on the macro, but this seems pretty messy. For future commits, would this perhaps constitute an update to INSTR_PROF_RAW_VERSION? If that's mainly reserved for binary format changes, would it perhaps be a good idea to introduce a macro for source-level API changes? While the binary format hasn't changed, downstream projects that use InstrProfData.inc could break from stuff like this.

Jan 18 2022, 4:48 PM · Restricted Project, Restricted Project

Dec 3 2021

leonardchan committed rGf178a05f2204: [libunwind] Fix unwind_leaffunction test (authored by leonardchan).
[libunwind] Fix unwind_leaffunction test
Dec 3 2021, 11:21 AM
leonardchan closed D114818: [libunwind] Fix unwind_leaffunction test.
Dec 3 2021, 11:21 AM · Restricted Project, Restricted Project

Dec 2 2021

leonardchan added a comment to D114818: [libunwind] Fix unwind_leaffunction test.

Will file a bug also once the bugzilla migration finishes.

Dec 2 2021, 7:09 PM · Restricted Project, Restricted Project
leonardchan abandoned D115020: [libunwind] Fix unwind_leaffunction.pass.cpp.

I meant to commandeer https://reviews.llvm.org/D114818 rather than make a new patch.

Dec 2 2021, 7:08 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D114818: [libunwind] Fix unwind_leaffunction test.
Dec 2 2021, 7:08 PM · Restricted Project, Restricted Project
leonardchan commandeered D114818: [libunwind] Fix unwind_leaffunction test.
Dec 2 2021, 7:07 PM · Restricted Project, Restricted Project
leonardchan requested review of D115020: [libunwind] Fix unwind_leaffunction.pass.cpp.
Dec 2 2021, 7:06 PM · Restricted Project, Restricted Project
leonardchan committed rG534d105e0334: [compiler-rt] Fix incorrect variable names used (authored by leonardchan).
[compiler-rt] Fix incorrect variable names used
Dec 2 2021, 11:47 AM
leonardchan added inline comments to D114818: [libunwind] Fix unwind_leaffunction test.
Dec 2 2021, 10:58 AM · Restricted Project, Restricted Project

Dec 1 2021

leonardchan added a comment to D114129: [libc++] Fix `uniform_int_distribution` for 128-bit result type.

Hi. I think the build issue we're seeing (https://ci.chromium.org/ui/p/fuchsia/builders/ci/clang_toolchain.ci.core.x64-debug-subbuild/b8829019800818975281/overview) is caused by this patch:

Dec 1 2021, 1:53 PM · Restricted Project
leonardchan added a comment to D114818: [libunwind] Fix unwind_leaffunction test.

Then the test passes, but it looks like unwinder skips past func (it jumps from _Z18crashing_leaf_funcv to main). Perhaps all this hints at an underlying issue in libunwind?

Is this a case where a function ends with a call instruction, and the return address points at the address after the call instruction, which would be the first instruction of the next function?

Can you provide disassembly of the linked binary (of the relevant functions) plus corresponding unwind info dumps (from e.g. llvm-dwarfdump)?

Dec 1 2021, 10:49 AM · Restricted Project, Restricted Project
leonardchan added a comment to D114818: [libunwind] Fix unwind_leaffunction test.

Interesting it works on Ubuntu20.04/Aarch64, I compile the code with ToT clang or gcc-10.
could you share an objdump of main?

Dec 1 2021, 10:32 AM · Restricted Project, Restricted Project

Nov 30 2021

leonardchan added a comment to D114818: [libunwind] Fix unwind_leaffunction test.

Hi @ldionne, @leonardchan

I ran these changes on Linux (Ubuntu 18.04)/Aarch64 board. The test gets failed because of missed 'main':

ubuntu@jetson8:/tmp$ ./t.tmp.exe 
info.dli_sname: _Z14signal_handleri
info.dli_sname: __kernel_rt_sigreturn
info.dli_sname: _Z18crashing_leaf_funcv
info.dli_sname: __libc_start_main
Nov 30 2021, 3:14 PM · Restricted Project, Restricted Project
leonardchan accepted D114818: [libunwind] Fix unwind_leaffunction test.

I haven't yet responded on D114385, but it looks like using __builtin_trap() still breaks the test for us because the unwinder doesn't iterate over the frame for main. Instead it goes from crashing_leaf_func to __libc_start_main, then runs out of frames. I'm still investigating why it does this. I don't think that should be a blocker for landing this though since this approach seems more correct than the raise, so LGTM.

Nov 30 2021, 1:17 PM · Restricted Project, Restricted Project

Nov 29 2021

leonardchan added a comment to D114385: [libunwind] Fix testing with sanitizers enabled.

Ok I did more digging and it looks like the issue is that my host libc doesn't have an FDE for raise, but it does have one for kill (which I don't have an explanation for). I suppose that would mean D114743 isn't a bad alternative, but I guess this means it could also fail again for any user with a libc that doesn't happen to have unwind info for kill (could be a wait-and-see scenario). If we want to avoid the potential missing unwind info altogether, we could perhaps having some inline assembly that does a bad memory reference, but that might not be very portable. Thoughts?

Nov 29 2021, 5:15 PM · Restricted Project, Restricted Project, Restricted Project
leonardchan added a comment to D114385: [libunwind] Fix testing with sanitizers enabled.

No, that doesn't ring a bell. I think this is a question for whoever provides the C Standard Library on your aarch64 bot. Perhaps libunwind is somehow unable to understand the stack frames below raise before it gets to the kernel? Honestly I'm kind of shooting in the dark.

I'd be fine with switching to kill(getpid(), SIGSEGV) temporarily to unbreak your bot, but I'd like to avoid doing a blind fix and get the ball rolling on this issue with the C library folks. Do you think you can provide a patch to switch to kill?

Nov 29 2021, 2:45 PM · Restricted Project, Restricted Project, Restricted Project
leonardchan requested review of D114743: [libunwind] Fix failing unwind_leaffunction.pass.cpp.
Nov 29 2021, 2:45 PM · Restricted Project, Restricted Project
leonardchan added a comment to D114385: [libunwind] Fix testing with sanitizers enabled.

The unwind_leaffunction.pass.cpp test was failing with ubsan because it was
relying on undefined behavior to "do the right thing" and result in a SIGSEGV.
IMO it makes more sense to simply raise a SIGSEGV directly, since that is guaranteed
to work.

Nov 29 2021, 1:54 PM · Restricted Project, Restricted Project, Restricted Project

Nov 17 2021

leonardchan committed rG1a84d1c81e12: [compiler-rt][asan] Re-add `self` (authored by leonardchan).
[compiler-rt][asan] Re-add `self`
Nov 17 2021, 3:49 PM

Nov 16 2021

leonardchan committed rGb75cc51df71d: Limit test to x86 for now. (authored by leonardchan).
Limit test to x86 for now.
Nov 16 2021, 2:47 PM
leonardchan committed rG25bcd9423453: [llvm-objcopy] Add --update-section (authored by leonardchan).
[llvm-objcopy] Add --update-section
Nov 16 2021, 2:12 PM
leonardchan closed D112116: [llvm-objcopy] Add --update-section.
Nov 16 2021, 2:12 PM · Restricted Project

Nov 15 2021

leonardchan added inline comments to D112116: [llvm-objcopy] Add --update-section.
Nov 15 2021, 5:04 PM · Restricted Project
leonardchan updated the diff for D112116: [llvm-objcopy] Add --update-section.
Nov 15 2021, 5:03 PM · Restricted Project

Nov 10 2021

leonardchan updated the diff for D112116: [llvm-objcopy] Add --update-section.
Nov 10 2021, 1:52 PM · Restricted Project