Page MenuHomePhabricator

leonardchan (Leonard Chan)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 25 2018, 1:47 PM (55 w, 3 d)

Recent Activity

Fri, May 17

leonardchan added a comment to D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.

LGTM! (if all comments from other reviewers has been taken care of) (maybe you should wait another day to see if anyone else object, but I think this patch has been open for a long time so there have been plenty of time for comments already)

Btw, I'm still having a hard time reviewing the X86 test cases with very long results, and a little bit worried that those just will give annoying churn when doing unrelated patches in the future, rather than help out detecting problems related to smul.fix. I currently have no more ideas on how to improve that.

Hopefully I'll be able to run some runtime comparison tests between X86 and our OOT target when this has landed (and when I've adapted our target to use these new intrinsics using "legal" lowering and not "expand").

Fri, May 17, 3:03 PM · Restricted Project
leonardchan created D62088: [compiler-rt][builtins] Scaled Integer log10().
Fri, May 17, 2:37 PM · Restricted Project, Restricted Project

Wed, May 15

leonardchan added inline comments to D58321: Support for relative vtables.
Wed, May 15, 4:20 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D58321: Support for relative vtables.
Wed, May 15, 4:20 PM · Restricted Project, Restricted Project
leonardchan added inline comments to D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
Wed, May 15, 12:20 PM · Restricted Project
leonardchan updated the diff for D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
Wed, May 15, 12:18 PM · Restricted Project

Tue, May 14

leonardchan committed rG048a97bca4da: Fix bots by adding target triple to test. (authored by leonardchan).
Fix bots by adding target triple to test.
Tue, May 14, 3:37 PM
leonardchan committed rC360720: Fix bots by adding target triple to test..
Fix bots by adding target triple to test.
Tue, May 14, 3:37 PM
leonardchan committed rL360720: Fix bots by adding target triple to test..
Fix bots by adding target triple to test.
Tue, May 14, 3:37 PM
leonardchan committed rG0cdd3b1d817a: [NewPM] Port HWASan and Kernel HWASan (authored by leonardchan).
[NewPM] Port HWASan and Kernel HWASan
Tue, May 14, 2:15 PM
leonardchan committed rL360707: [NewPM] Port HWASan and Kernel HWASan.
[NewPM] Port HWASan and Kernel HWASan
Tue, May 14, 2:15 PM
leonardchan added inline comments to D61709: [NewPM] Port HWASan and Kernel HWASan.
Tue, May 14, 2:15 PM · Restricted Project, Restricted Project
leonardchan committed rC360707: [NewPM] Port HWASan and Kernel HWASan.
[NewPM] Port HWASan and Kernel HWASan
Tue, May 14, 2:15 PM
leonardchan closed D61709: [NewPM] Port HWASan and Kernel HWASan.
Tue, May 14, 2:15 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
Tue, May 14, 12:54 PM · Restricted Project
leonardchan added inline comments to D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
Tue, May 14, 12:52 PM · Restricted Project

Sun, May 12

leonardchan committed rG4235a4edfebd: Fix test to use -cc1. (authored by leonardchan).
Fix test to use -cc1.
Sun, May 12, 3:47 PM
leonardchan committed rC360548: Fix test to use -cc1..
Fix test to use -cc1.
Sun, May 12, 3:42 PM
leonardchan committed rL360548: Fix test to use -cc1..
Fix test to use -cc1.
Sun, May 12, 3:42 PM
leonardchan added a comment to D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration.

This caused a regression when including mingw-w64 headers (in a case where they happen to include redundant/duplicate attribute specifications), triggering asserts. See https://bugs.llvm.org/show_bug.cgi?id=41852 for details.

Sun, May 12, 2:53 PM · Restricted Project
leonardchan committed rG69aec05bb155: Fix for P41852 where builtin attributes were being caught by… (authored by leonardchan).
Fix for P41852 where builtin attributes were being caught by…
Sun, May 12, 2:50 PM
leonardchan committed rC360544: Fix for P41852 where builtin attributes were being caught by….
Fix for P41852 where builtin attributes were being caught by…
Sun, May 12, 2:50 PM
leonardchan committed rL360544: Fix for P41852 where builtin attributes were being caught by….
Fix for P41852 where builtin attributes were being caught by…
Sun, May 12, 2:50 PM

Fri, May 10

leonardchan added a comment to D61680: [X86] Avoid SFB - Fix inconsistent codegen with/without debug info .

Hi, it seems that this patch results in an assertion error when building zircon:

Fri, May 10, 3:12 PM · Restricted Project
leonardchan committed rGbcb9bbc01122: Add target triple to test. (authored by leonardchan).
Add target triple to test.
Fri, May 10, 1:06 PM
leonardchan committed rC360465: Add target triple to test..
Add target triple to test.
Fri, May 10, 1:05 PM
leonardchan committed rL360465: Add target triple to test..
Add target triple to test.
Fri, May 10, 1:05 PM
leonardchan committed rGdc5d9759063a: Fix and test for assertion error in P41835. (authored by leonardchan).
Fix and test for assertion error in P41835.
Fri, May 10, 11:05 AM
leonardchan committed rL360448: Fix and test for assertion error in P41835..
Fix and test for assertion error in P41835.
Fri, May 10, 11:05 AM
leonardchan committed rC360448: Fix and test for assertion error in P41835..
Fix and test for assertion error in P41835.
Fri, May 10, 11:05 AM
leonardchan added a comment to D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration.

This caused https://bugs.llvm.org/show_bug.cgi?id=41835
Could you please look into it?

Fri, May 10, 11:05 AM · Restricted Project

Thu, May 9

leonardchan accepted D61768: [compiler-rt] Migrate to _zx_clock_get_new/_zx_clock_get_monotonic.
Thu, May 9, 4:13 PM · Restricted Project, Restricted Project
leonardchan added inline comments to D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
Thu, May 9, 4:07 PM · Restricted Project
leonardchan updated the diff for D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.

Sorry for the holdup.

Thu, May 9, 4:02 PM · Restricted Project
leonardchan committed rG992021335c14: [NFC][compiler-rt][builtins] Tidy and match comments for floating point… (authored by leonardchan).
[NFC][compiler-rt][builtins] Tidy and match comments for floating point…
Thu, May 9, 3:47 PM
leonardchan committed rL360389: [NFC][compiler-rt][builtins] Tidy and match comments for floating point….
[NFC][compiler-rt][builtins] Tidy and match comments for floating point…
Thu, May 9, 3:46 PM
leonardchan committed rCRT360389: [NFC][compiler-rt][builtins] Tidy and match comments for floating point….
[NFC][compiler-rt][builtins] Tidy and match comments for floating point…
Thu, May 9, 3:46 PM
leonardchan closed D61762: [NFC][compiler-rt][builtins] Tidy and match comments for floating point operations.
Thu, May 9, 3:46 PM · Restricted Project, Restricted Project
leonardchan created D61762: [NFC][compiler-rt][builtins] Tidy and match comments for floating point operations.
Thu, May 9, 3:22 PM · Restricted Project, Restricted Project
leonardchan updated the diff for D61709: [NewPM] Port HWASan and Kernel HWASan.
Thu, May 9, 12:43 PM · Restricted Project, Restricted Project

Wed, May 8

leonardchan committed rG95b7abdcc5be: [SelectionDAG] Expand ADD/SUBCARRY (authored by leonardchan).
[SelectionDAG] Expand ADD/SUBCARRY
Wed, May 8, 6:16 PM
leonardchan committed rL360303: [SelectionDAG] Expand ADD/SUBCARRY.
[SelectionDAG] Expand ADD/SUBCARRY
Wed, May 8, 6:15 PM
leonardchan closed D61411: [SelectionDAG] Expand ADD/SUBCARRY.
Wed, May 8, 6:15 PM · Restricted Project
leonardchan created D61709: [NewPM] Port HWASan and Kernel HWASan.
Wed, May 8, 5:46 PM · Restricted Project, Restricted Project

Tue, May 7

leonardchan committed rGaae9da70ffff: Fix for the greendragon bots. (authored by leonardchan).
Fix for the greendragon bots.
Tue, May 7, 10:58 PM
leonardchan committed rC360225: Fix for the greendragon bots..
Fix for the greendragon bots.
Tue, May 7, 10:57 PM
leonardchan committed rL360225: Fix for the greendragon bots..
Fix for the greendragon bots.
Tue, May 7, 10:57 PM
leonardchan committed rGbcaee49d001a: [Sema] Add missing VisitMacroQualifiedTypeLoc to TypeSpecLocFiller (authored by leonardchan).
[Sema] Add missing VisitMacroQualifiedTypeLoc to TypeSpecLocFiller
Tue, May 7, 1:11 AM
leonardchan committed rL360120: [Sema] Add missing VisitMacroQualifiedTypeLoc to TypeSpecLocFiller.
[Sema] Add missing VisitMacroQualifiedTypeLoc to TypeSpecLocFiller
Tue, May 7, 1:11 AM
leonardchan committed rC360120: [Sema] Add missing VisitMacroQualifiedTypeLoc to TypeSpecLocFiller.
[Sema] Add missing VisitMacroQualifiedTypeLoc to TypeSpecLocFiller
Tue, May 7, 1:11 AM

Mon, May 6

leonardchan committed rGc72aaf62d3f9: Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an… (authored by leonardchan).
Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an…
Mon, May 6, 8:19 PM
leonardchan committed rL360109: Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an….
Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an…
Mon, May 6, 8:18 PM
leonardchan committed rC360109: Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an….
Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an…
Mon, May 6, 8:18 PM
leonardchan committed rG415da7135594: [Sema] Fix for P41774 where `ExpectNoDerefChunk` is assigned twice (authored by leonardchan).
[Sema] Fix for P41774 where `ExpectNoDerefChunk` is assigned twice
Mon, May 6, 3:10 PM
leonardchan committed rC360089: [Sema] Fix for P41774 where `ExpectNoDerefChunk` is assigned twice.
[Sema] Fix for P41774 where `ExpectNoDerefChunk` is assigned twice
Mon, May 6, 3:09 PM
leonardchan committed rL360089: [Sema] Fix for P41774 where `ExpectNoDerefChunk` is assigned twice.
[Sema] Fix for P41774 where `ExpectNoDerefChunk` is assigned twice
Mon, May 6, 3:09 PM
leonardchan added inline comments to D49511: [Sema/Attribute] Check for noderef attribute.
Mon, May 6, 3:09 PM · Restricted Project

Thu, May 2

leonardchan committed rGef2dc25a962d: Revert "[Attribute/Diagnostics] Print macro if definition is an attribute… (authored by leonardchan).
Revert "[Attribute/Diagnostics] Print macro if definition is an attribute…
Thu, May 2, 8:27 PM
leonardchan added a reverting change for rGfc40cbd9d8c6: [Attribute/Diagnostics] Print macro if definition is an attribute declaration: rGef2dc25a962d: Revert "[Attribute/Diagnostics] Print macro if definition is an attribute….
Thu, May 2, 8:27 PM
leonardchan committed rL359859: Revert "[Attribute/Diagnostics] Print macro if definition is an attribute….
Revert "[Attribute/Diagnostics] Print macro if definition is an attribute…
Thu, May 2, 8:26 PM
leonardchan committed rC359859: Revert "[Attribute/Diagnostics] Print macro if definition is an attribute….
Revert "[Attribute/Diagnostics] Print macro if definition is an attribute…
Thu, May 2, 8:26 PM
leonardchan added a comment to D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration.
Thu, May 2, 5:53 PM · Restricted Project
leonardchan added inline comments to D61411: [SelectionDAG] Expand ADD/SUBCARRY.
Thu, May 2, 3:48 PM · Restricted Project
leonardchan updated the diff for D61411: [SelectionDAG] Expand ADD/SUBCARRY.
Thu, May 2, 3:48 PM · Restricted Project
leonardchan added inline comments to D61411: [SelectionDAG] Expand ADD/SUBCARRY.
Thu, May 2, 2:01 PM · Restricted Project
leonardchan updated the diff for D61411: [SelectionDAG] Expand ADD/SUBCARRY.
Thu, May 2, 2:00 PM · Restricted Project
leonardchan committed rGfc40cbd9d8c6: [Attribute/Diagnostics] Print macro if definition is an attribute declaration (authored by leonardchan).
[Attribute/Diagnostics] Print macro if definition is an attribute declaration
Thu, May 2, 1:38 PM
leonardchan committed rL359826: [Attribute/Diagnostics] Print macro if definition is an attribute declaration.
[Attribute/Diagnostics] Print macro if definition is an attribute declaration
Thu, May 2, 1:38 PM
leonardchan committed rC359826: [Attribute/Diagnostics] Print macro if definition is an attribute declaration.
[Attribute/Diagnostics] Print macro if definition is an attribute declaration
Thu, May 2, 1:38 PM
leonardchan closed D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration.
Thu, May 2, 1:37 PM · Restricted Project
leonardchan added a comment to D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration.

Thanks, looks great!

I think the handling of the expansion location in the MacroQualifiedTypeLoc isn't quite right yet (it looks like it will never actually be set at all, because the code to set it is not reachable) but it's also unused at the moment, so I'm happy with that being fixed as a follow-up change after you land this.

Thu, May 2, 1:37 PM · Restricted Project
leonardchan added inline comments to D61411: [SelectionDAG] Expand ADD/SUBCARRY.
Thu, May 2, 12:12 PM · Restricted Project
leonardchan updated the diff for D61411: [SelectionDAG] Expand ADD/SUBCARRY.
Thu, May 2, 12:11 PM · Restricted Project
leonardchan added a comment to D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration.

*ping*

Thu, May 2, 10:29 AM · Restricted Project

Wed, May 1

leonardchan abandoned D59119: [SelectionDAG] Check legality for ADDCARRY in expandMUL_LOHI.
Wed, May 1, 8:52 PM · Restricted Project
leonardchan added a comment to D61411: [SelectionDAG] Expand ADD/SUBCARRY.

LGTM

Please run some basic sanity tests before you merge to make sure this works correctly at runtime. The code looks right, but I don't really trust that. :) If you want to test something simpler than smul.fix, might make sense to just temporarily hack legalization for addition to use this codepath, or something like that, so you can easily understand what you're actually testing.

Wed, May 1, 8:49 PM · Restricted Project
leonardchan updated the diff for D61411: [SelectionDAG] Expand ADD/SUBCARRY.
Wed, May 1, 8:48 PM · Restricted Project
leonardchan added inline comments to D61411: [SelectionDAG] Expand ADD/SUBCARRY.
Wed, May 1, 5:01 PM · Restricted Project
leonardchan updated the diff for D61411: [SelectionDAG] Expand ADD/SUBCARRY.
Wed, May 1, 5:01 PM · Restricted Project
leonardchan added a comment to D59119: [SelectionDAG] Check legality for ADDCARRY in expandMUL_LOHI.

If this is fixing a SPARC issue, please add an appropriate testcase for the SPARC backend.

If iN ADDCARRY isn't legal, but iN is legal, it makes sense to handle that in SelectionDAGLegalize::ExpandNode, yes. I thought we had that code already, but I guess not. We should eventually implement ADDCARRY support for SPARC, but the code in SelectionDAGLegalize::ExpandNode will be useful for other targets which don't have an ADDCARRY-like instruction, like RISCV.

Wed, May 1, 4:17 PM · Restricted Project
leonardchan created D61411: [SelectionDAG] Expand ADD/SUBCARRY.
Wed, May 1, 4:16 PM · Restricted Project
leonardchan added a comment to D59119: [SelectionDAG] Check legality for ADDCARRY in expandMUL_LOHI.

I'm not sure what you're hoping to accomplish with this change. Even on targets where i64 ADDCARRY isn't legal, we have code to expand it (see DAGTypeLegalizer::ExpandIntRes_ADDSUBCARRY etc.), and it's still generally cheap.

Wed, May 1, 1:31 PM · Restricted Project
leonardchan added a comment to D58321: Support for relative vtables.

*ping*

Wed, May 1, 10:29 AM · Restricted Project, Restricted Project

Tue, Apr 30

leonardchan added inline comments to D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration.
Tue, Apr 30, 3:06 PM · Restricted Project
leonardchan updated the diff for D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration.
Tue, Apr 30, 3:06 PM · Restricted Project
leonardchan updated the diff for D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration.
Tue, Apr 30, 12:48 PM · Restricted Project
leonardchan added inline comments to D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration.
Tue, Apr 30, 12:39 PM · Restricted Project
leonardchan updated the diff for D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration.
Tue, Apr 30, 12:38 PM · Restricted Project

Mon, Apr 29

leonardchan updated the diff for D58321: Support for relative vtables.

Ok. Formally requesting for code reviews now.

Mon, Apr 29, 3:19 PM · Restricted Project, Restricted Project

Mon, Apr 22

leonardchan updated the diff for D58321: Support for relative vtables.

Uploading my latest version of this patch and reporting some results. Will proceed with formatting and cleanup and ask for official reviews later.


Mon, Apr 22, 10:14 PM · Restricted Project, Restricted Project

Apr 16 2019

leonardchan committed rG5c09f8d6c1f4: [NFC] Remove unused function (Sema::pushExternalDeclIntoScope) (authored by leonardchan).
[NFC] Remove unused function (Sema::pushExternalDeclIntoScope)
Apr 16 2019, 4:01 PM
leonardchan committed rC358538: [NFC] Remove unused function (Sema::pushExternalDeclIntoScope).
[NFC] Remove unused function (Sema::pushExternalDeclIntoScope)
Apr 16 2019, 4:00 PM
leonardchan committed rL358538: [NFC] Remove unused function (Sema::pushExternalDeclIntoScope).
[NFC] Remove unused function (Sema::pushExternalDeclIntoScope)
Apr 16 2019, 4:00 PM

Mar 7 2019

leonardchan added inline comments to D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
Mar 7 2019, 5:11 PM · Restricted Project
leonardchan updated the diff for D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
Mar 7 2019, 5:11 PM · Restricted Project
leonardchan removed a parent revision for D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic: D59119: [SelectionDAG] Check legality for ADDCARRY in expandMUL_LOHI.
Mar 7 2019, 5:06 PM · Restricted Project
leonardchan added a parent revision for D59119: [SelectionDAG] Check legality for ADDCARRY in expandMUL_LOHI: D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
Mar 7 2019, 5:06 PM · Restricted Project
leonardchan added a child revision for D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic: D59119: [SelectionDAG] Check legality for ADDCARRY in expandMUL_LOHI.
Mar 7 2019, 5:06 PM · Restricted Project
leonardchan removed a child revision for D59119: [SelectionDAG] Check legality for ADDCARRY in expandMUL_LOHI: D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
Mar 7 2019, 5:06 PM · Restricted Project
leonardchan added a child revision for D59119: [SelectionDAG] Check legality for ADDCARRY in expandMUL_LOHI: D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.
Mar 7 2019, 5:03 PM · Restricted Project