- User Since
- Apr 25 2018, 1:47 PM (283 w, 2 d)
Thu, Sep 28
Thu, Sep 14
Wed, Sep 13
Tue, Sep 12
Fri, Sep 8
This was landed in various other smaller changes
Thu, Aug 31
ping for thoughts on this
Aug 30 2023
Aug 29 2023
Aug 28 2023
Aug 25 2023
Aug 24 2023
Aug 23 2023
Aug 22 2023
This was landed in fe195781ad2f1aaecd5def14f361f3590a17c79e
Aug 4 2023
I think perhaps you can re-upload your diff to the original one.
Sorry I accidentally closed the revision. I think just re-opening it should be fine then when you commit it, you can still use this differential revision.
Aug 3 2023
Jul 31 2023
It looks like this change causes an out of range exception to be thrown for this snippet:
Jul 21 2023
Prior to this, it looks like we'd unconditionally mark pointers in the allocator cache as reachable. So we may find more leaks after this.
Jul 19 2023
LGTM but probably give it a day before landing to give others time to respond
Jul 17 2023
Jun 15 2023
Hi. I think this is leading to the lldb test failures we're seeing on our linux builder (https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8778187770933863505/+/u/lldb/test/stdout?format=raw):
Woops. Forgot to add the differential revision: bit to the commit, but this was submitted in 17623e96b5b84c0868fe6b4a1456e3d7da275c95.
Looks like this is still causing the test to fail still (https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8778209096851671889/+/u/clang/test/stdout?format=raw):
Jun 14 2023
Hi. I think this caused the override-layout.cpp test to fail on our windows builder (https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8778279637538184401/+/u/clang/test/stdout?format=raw):
Hi. This fails for me locally with:
Hi. It looks like this is failing to build for us on windows host https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8778294144728066337/+/u/clang/build/stdout?format=raw with:
Jun 12 2023
Hi. Looks like the static-archive-collision.test test is failing on our builders at https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8778475674577642785/overview. Would you mind sending out a fix or revert?
Jun 8 2023
Ok here's some of my findings. So there's a step in the attributor where it replaces some instructions with unreachable. One step is:
https://reviews.llvm.org/D152322 for qsort_r
Jun 7 2023
Can we extend the test cases to exercise both with and without relative-vtables also enabled?