This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Support CSRs of AIA ext
AbandonedPublic

Authored by sunshaoce on Aug 31 2022, 6:52 AM.

Diff Detail

Event Timeline

sunshaoce created this revision.Aug 31 2022, 6:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 31 2022, 6:52 AM
sunshaoce requested review of this revision.Aug 31 2022, 6:52 AM

Initial comment is your naming seems to be inconsistent with what's already in the file (and you can't even decide on Foo-Level vs Foo-level vs Foo Level); the current naming, taking from the ISA manual, does not use "level" anywhere, it's just "Machine Trap Handling" etc. Presumably these CSRs are currently defined in the evolving AIA spec and so aren't properly categorised with uniform names?

Initial comment is your naming seems to be inconsistent with what's already in the file (and you can't even decide on Foo-Level vs Foo-level vs Foo Level); the current naming, taking from the ISA manual, does not use "level" anywhere, it's just "Machine Trap Handling" etc. Presumably these CSRs are currently defined in the evolving AIA spec and so aren't properly categorised with uniform names?

Thanks for your review. I'll update the revision when the spec are ratified.

sunshaoce abandoned this revision.May 27 2023, 10:30 AM
evandro removed a subscriber: evandro.May 29 2023, 4:01 PM