When expanding IR atomics to target-specific atomics, copy all
!pcsections Metadata to expanded atomics automatically.
Depends on D130884
Paths
| Differential D130885
[AtomicExpandPass] Always copy pcsections Metadata to expanded atomics ClosedPublic Authored by melver on Aug 1 2022, 1:58 AM.
Details Summary When expanding IR atomics to target-specific atomics, copy all Depends on D130884
Diff Detail
Event Timelinemelver added a child revision: D130886: [GlobalISel] Propagate PCSections metadata to MachineInstr.Aug 1 2022, 1:59 AM vitalybuka added inline comments.
This revision is now accepted and ready to land.Sep 2 2022, 10:24 AM Closed by commit rGf0d6709e4a58: [AtomicExpandPass] Always copy pcsections Metadata to expanded atomics (authored by melver). · Explain WhySep 7 2022, 2:38 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 458399 llvm/lib/CodeGen/AtomicExpandPass.cpp
llvm/test/Transforms/AtomicExpand/AArch64/pcsections.ll
|
This seems too specific. Why do we need a new IRBuilder subclass just for this? Isn't there already an existing helper for metadata? We could also preserve a lot more metadata, like any aliasing info