Page MenuHomePhabricator

[SelectionDAG] Rename CallSiteDbgInfo to NodeExtraInfo
AcceptedPublic

Authored by melver on Mon, Aug 1, 1:56 AM.

Details

Summary

For information infrequently attached to SDNodes, it is useful to
provide a way to add this information out-of-line. This is already done
for call-site specific information.

Rename CallSiteDbgInfo to NodeExtraInfo in preparation of adding
additional information not necessarily related to call sites only.

Depends on D130876

Diff Detail

Unit TestsFailed

TimeTest
1,660 msx64 debian > libFuzzer.libFuzzer::fuzzer-finalstats.test
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -O2 -gline-tables-only -fsanitize=address,fuzzer -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/lib/fuzzer -m64 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/fuzzer/SimpleTest.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/fuzzer/X86_64DefaultLinuxConfig/Output/fuzzer-finalstats.test.tmp-SimpleTest

Event Timeline

melver created this revision.Mon, Aug 1, 1:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Aug 1, 1:56 AM
melver requested review of this revision.Mon, Aug 1, 1:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Aug 1, 1:57 AM

I looked at this and it looks good to me, but I don't feel like the right person to approve this.

melver updated this revision to Diff 450025.Thu, Aug 4, 9:56 AM
melver edited the summary of this revision. (Show Details)

Rebase.

vitalybuka accepted this revision.Fri, Aug 5, 5:02 PM
vitalybuka added inline comments.
llvm/include/llvm/CodeGen/SelectionDAG.h
275

SD is redundant as it's nested to SelectionDAG

This revision is now accepted and ready to land.Fri, Aug 5, 5:02 PM
melver updated this revision to Diff 450854.Mon, Aug 8, 10:02 AM
melver marked an inline comment as done.
melver retitled this revision from [SelectionDAG] Rename CallSiteDbgInfo into SDNodeExtraInfo to [SelectionDAG] Rename CallSiteDbgInfo to NodeExtraInfo.
melver edited the summary of this revision. (Show Details)

s/SDNodeExtraInfo/NodeExtraInfo/