Page MenuHomePhabricator
Differential D130876

[MachineInstr] Allow setting PCSections in ExtraInfo
AcceptedPublic
Actions

Authored by melver on Mon, Aug 1, 1:54 AM.

Details

Reviewers
dvyukov
vitalybuka
eugenis
pcc
MaskRay
Summary

Provide MachineInstr::setPCSection(), to propagate relevant metadata
through the backend. Use ExtraInfo to store the metadata.

Depends on D130875

Diff Detail

Event Timeline

melver created this revision.Mon, Aug 1, 1:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Aug 1, 1:54 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
melver requested review of this revision.Mon, Aug 1, 1:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Aug 1, 1:54 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
melver added a child revision: D130877: [MCObjectFileInfo] Add getPCSection() helper.Mon, Aug 1, 1:55 AM
Harbormaster completed remote builds in B178520: Diff 448944.Mon, Aug 1, 3:12 AM
melver added a reviewer: dvyukov.Mon, Aug 1, 11:37 PM
dvyukov added a comment.Tue, Aug 2, 12:49 AM

I looked at this and it looks good to me, but I don't feel like the right person to approve this.

melver updated this revision to Diff 450024.Thu, Aug 4, 9:56 AM

Rebase.

melver added a child revision: D130880: [SelectionDAG] Rename CallSiteDbgInfo to NodeExtraInfo.Thu, Aug 4, 9:56 AM
melver removed a child revision: D130877: [MCObjectFileInfo] Add getPCSection() helper.Thu, Aug 4, 10:11 AM
melver added reviewers: vitalybuka, eugenis, pcc, MaskRay.Thu, Aug 4, 10:29 AM
Herald added a subscriber: StephenFan. · View Herald TranscriptThu, Aug 4, 10:29 AM
Harbormaster completed remote builds in B179312: Diff 450024.Thu, Aug 4, 11:43 AM
vitalybuka accepted this revision.Fri, Aug 5, 4:57 PM
In D130876#3692805, @dvyukov wrote:

I looked at this and it looks good to me, but I don't feel like the right person to approve this.

same
if you guess better candidates please add them as "blocking".

This revision is now accepted and ready to land.Fri, Aug 5, 4:57 PM

Revision Contents
Changeset List

PathSize
llvm/
include/
llvm/
CodeGen/
3 lines
41 lines
lib/
CodeGen/
5 lines
46 lines
unittests/
CodeGen/
50 lines

Diff 450024

View Options

llvm/include/llvm/CodeGen/MachineFunction.h

Loading...
View Options

llvm/include/llvm/CodeGen/MachineInstr.h

Loading...
View Options

llvm/lib/CodeGen/MachineFunction.cpp

Loading...
View Options

llvm/lib/CodeGen/MachineInstr.cpp

Loading...
View Options

llvm/unittests/CodeGen/MachineInstrTest.cpp

Loading...