Page MenuHomePhabricator

melver (Marco Elver)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 20 2018, 1:39 PM (26 w, 4 d)

Recent Activity

Mon, Feb 4

melver added a comment to D56935: [NewPM] Add support for new-PM plugins to clang.

Landed it for you in r352972. Thanks!

Mon, Feb 4, 11:14 AM · Restricted Project

Wed, Jan 30

melver added a comment to D56935: [NewPM] Add support for new-PM plugins to clang.

Gentle ping. Need someone to land this on my behalf, as I do not have commit access. Many thanks!

Wed, Jan 30, 9:31 PM · Restricted Project

Sat, Jan 26

melver added a comment to D56935: [NewPM] Add support for new-PM plugins to clang.

It would be good to check, since the bots won't! Otherwise this looks good.

Sat, Jan 26, 2:32 PM · Restricted Project
melver updated the diff for D56935: [NewPM] Add support for new-PM plugins to clang.
  • Improve error reporting. While testing on Windows, noticed that Clang wants the error to be checked otherwise crashed quite verbosely.
Sat, Jan 26, 11:28 AM · Restricted Project

Jan 23 2019

melver added a comment to D56935: [NewPM] Add support for new-PM plugins to clang.

I'm not sure what the current state of plugins on windows is. They were broken and disabled last time I worked on this, but that might've changed in the meantime! Worth checking.

Jan 23 2019, 11:40 AM · Restricted Project
melver updated the diff for D56935: [NewPM] Add support for new-PM plugins to clang.
  • Revert use of SmallVector
Jan 23 2019, 11:38 AM · Restricted Project

Jan 22 2019

melver added a comment to D56935: [NewPM] Add support for new-PM plugins to clang.

This generally looks sane. What will happen on windows though? Will it silently fa

AFAIK PassPlugin::Load uses sys::DynamicLibrary::getPermanentLibrary, which uses DynamicLibrary::HandleSet::AddLibrary which works for Windows as well. (The story is similar to legacy -fplugin=).

Jan 22 2019, 4:35 PM · Restricted Project
melver added a comment to D56935: [NewPM] Add support for new-PM plugins to clang.

This generally looks sane. What will happen on windows though? Will it silently fail?

Jan 22 2019, 1:45 PM · Restricted Project
melver updated the diff for D56935: [NewPM] Add support for new-PM plugins to clang.
  • Use SmallVector in CodeGenOptions.h
Jan 22 2019, 1:41 PM · Restricted Project
melver added a reviewer for D56935: [NewPM] Add support for new-PM plugins to clang: fedor.sergeev.
Jan 22 2019, 12:07 PM · Restricted Project

Jan 18 2019

melver updated the summary of D56935: [NewPM] Add support for new-PM plugins to clang.
Jan 18 2019, 2:10 PM · Restricted Project
melver abandoned D56934: [NewPM] Add support for new-PM plugins to clang.
Jan 18 2019, 2:05 PM
melver created D56935: [NewPM] Add support for new-PM plugins to clang.
Jan 18 2019, 2:03 PM · Restricted Project
melver created D56934: [NewPM] Add support for new-PM plugins to clang.
Jan 18 2019, 1:55 PM

Sep 5 2018

melver added a comment to D51036: clang-format: Fix formatting C++ namespaces with preceding 'inline' or 'export' specifier.

Awaiting remaining reviewer acceptance.

FYI: I do not have commit commit access -- what is the procedure to commit once diff is accepted?

Many thanks!

Anyone with commit access can land it for you - I'm happy to do this.
@owenpan any concerns?

Sep 5 2018, 1:41 AM

Sep 4 2018

melver added a comment to D51036: clang-format: Fix formatting C++ namespaces with preceding 'inline' or 'export' specifier.

Awaiting remaining reviewer acceptance.

Sep 4 2018, 8:27 AM

Aug 27 2018

melver added inline comments to D51036: clang-format: Fix formatting C++ namespaces with preceding 'inline' or 'export' specifier.
Aug 27 2018, 4:42 AM
melver updated the diff for D51036: clang-format: Fix formatting C++ namespaces with preceding 'inline' or 'export' specifier.

Many thanks! PTAL.

Aug 27 2018, 4:42 AM

Aug 22 2018

melver added a reviewer for D51036: clang-format: Fix formatting C++ namespaces with preceding 'inline' or 'export' specifier: sammccall.
Aug 22 2018, 8:07 AM
melver updated the diff for D51036: clang-format: Fix formatting C++ namespaces with preceding 'inline' or 'export' specifier.

Many thanks for the suggestions!

Aug 22 2018, 8:04 AM

Aug 21 2018

melver added reviewers for D51036: clang-format: Fix formatting C++ namespaces with preceding 'inline' or 'export' specifier: klimek, djasper.
Aug 21 2018, 7:17 AM
melver created D51036: clang-format: Fix formatting C++ namespaces with preceding 'inline' or 'export' specifier.
Aug 21 2018, 7:15 AM