Page MenuHomePhabricator

melver (Marco Elver)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 20 2018, 1:39 PM (202 w, 15 h)

Recent Activity

Wed, Jun 15

melver accepted D127845: tsan: fix deadlock/crash in signal handling.
Wed, Jun 15, 5:50 AM · Restricted Project, Unknown Object (Project)

May 18 2022

melver accepted D125762: [tsan] Fix the longjmp sp slot on FreeBSD AArch64.
May 18 2022, 5:00 AM · Restricted Project, Unknown Object (Project)

May 17 2022

melver added a comment to D125762: [tsan] Fix the longjmp sp slot on FreeBSD AArch64.

Please add a brief commit message.

May 17 2022, 4:47 AM · Restricted Project, Unknown Object (Project)
melver added a reviewer for D125762: [tsan] Fix the longjmp sp slot on FreeBSD AArch64: dvyukov.
May 17 2022, 4:46 AM · Restricted Project, Unknown Object (Project)

May 6 2022

melver committed rG9ae87b597351: [Instrumentation] Share InstrumentationIRBuilder between TSan and SanCov (authored by melver).
[Instrumentation] Share InstrumentationIRBuilder between TSan and SanCov
May 6 2022, 12:16 AM · Restricted Project, Restricted Project
melver closed D125038: [Instrumentation] Share InstrumentationIRBuilder between TSan and SanCov.
May 6 2022, 12:15 AM · Restricted Project, Restricted Project

May 5 2022

melver added inline comments to D125038: [Instrumentation] Share InstrumentationIRBuilder between TSan and SanCov.
May 5 2022, 11:52 PM · Restricted Project, Restricted Project
melver updated the diff for D125038: [Instrumentation] Share InstrumentationIRBuilder between TSan and SanCov.

Remove unneeded constructors (and <utility>) for now. Can add back later when
we need it.

May 5 2022, 11:52 PM · Restricted Project, Restricted Project
melver added inline comments to D125038: [Instrumentation] Share InstrumentationIRBuilder between TSan and SanCov.
May 5 2022, 2:08 PM · Restricted Project, Restricted Project
melver updated the diff for D125038: [Instrumentation] Share InstrumentationIRBuilder between TSan and SanCov.

Add includes.

May 5 2022, 2:07 PM · Restricted Project, Restricted Project
melver requested review of D125038: [Instrumentation] Share InstrumentationIRBuilder between TSan and SanCov.
May 5 2022, 1:12 PM · Restricted Project, Restricted Project
melver committed rG47bdea3f7eb4: [ThreadSanitizer] Add fallback DebugLocation for instrumentation calls (authored by melver).
[ThreadSanitizer] Add fallback DebugLocation for instrumentation calls
May 5 2022, 6:50 AM · Restricted Project, Restricted Project
melver closed D124937: [ThreadSanitizer] Add fallback DebugLocation for instrumentation calls.
May 5 2022, 6:50 AM · Restricted Project, Restricted Project
melver updated the diff for D124937: [ThreadSanitizer] Add fallback DebugLocation for instrumentation calls.

Don't use auto.

May 5 2022, 6:14 AM · Restricted Project, Restricted Project

May 4 2022

melver requested review of D124937: [ThreadSanitizer] Add fallback DebugLocation for instrumentation calls.
May 4 2022, 9:36 AM · Restricted Project, Restricted Project

Apr 28 2022

melver accepted D124507: tsan: model atomic read for failing CAS.
Apr 28 2022, 3:58 AM · Unknown Object (Project), Restricted Project

Apr 27 2022

melver accepted D124518: tsan: avoid false positives related to epoll.
Apr 27 2022, 5:11 AM · Unknown Object (Project), Restricted Project
melver added a comment to D124507: tsan: model atomic read for failing CAS.

This is tricky, I am not 100% sure (1) it's the right thing to do, (2) that destruction safety problem (see the comment) will hit us or not (maybe there are some other cases I don't see).

also (3) do I do correct reading of the standard?
(4) is it correct to extend this guarantee to the __atomic builtins?

Apr 27 2022, 3:02 AM · Unknown Object (Project), Restricted Project

Apr 1 2022

melver accepted D122906: sanitizer_common: expose max_address from LoadedModule.
Apr 1 2022, 8:03 AM · Unknown Object (Project), Restricted Project
melver accepted D122905: sanitizer_common: add Mutex::TryLock.
Apr 1 2022, 8:00 AM · Unknown Object (Project), Restricted Project

Mar 31 2022

melver committed rGb8e49fdcb145: [AddressSanitizer] Allow prefixing memintrinsic calls in kernel mode (authored by melver).
[AddressSanitizer] Allow prefixing memintrinsic calls in kernel mode
Mar 31 2022, 2:22 AM · Restricted Project, Restricted Project
melver closed D122724: [AddressSanitizer] Allow prefixing meminstrinsic calls in kernel mode.
Mar 31 2022, 2:22 AM · Restricted Project, Restricted Project

Mar 30 2022

melver requested review of D122724: [AddressSanitizer] Allow prefixing meminstrinsic calls in kernel mode.
Mar 30 2022, 5:06 AM · Restricted Project, Restricted Project

Mar 18 2022

melver added inline comments to D121979: tsan: print signal num in errno spoiling reports.
Mar 18 2022, 2:34 AM · Unknown Object (Project), Restricted Project
melver added inline comments to D121979: tsan: print signal num in errno spoiling reports.
Mar 18 2022, 2:28 AM · Unknown Object (Project), Restricted Project
melver accepted D121979: tsan: print signal num in errno spoiling reports.
Mar 18 2022, 2:18 AM · Unknown Object (Project), Restricted Project

Mar 17 2022

melver committed rGb09439e20b46: [AtomicExpandPass][NFC] Reformat with clang-format (authored by melver).
[AtomicExpandPass][NFC] Reformat with clang-format
Mar 17 2022, 8:59 AM · Restricted Project
melver committed rGcbe1e67eade9: [Instruction] Introduce getAtomicSyncScopeID() (authored by melver).
[Instruction] Introduce getAtomicSyncScopeID()
Mar 17 2022, 7:24 AM · Restricted Project
melver closed D121910: [Instruction] Introduce getAtomicSyncScopeID().
Mar 17 2022, 7:23 AM · Restricted Project, Restricted Project
melver requested review of D121910: [Instruction] Introduce getAtomicSyncScopeID().
Mar 17 2022, 6:41 AM · Restricted Project, Restricted Project

Mar 16 2022

melver committed rG555df030121a: [SelectionDAG][NFC] Clean up SDCallSiteDbgInfo accessors (authored by melver).
[SelectionDAG][NFC] Clean up SDCallSiteDbgInfo accessors
Mar 16 2022, 9:46 AM · Restricted Project
melver closed D121820: [SelectionDAG][NFC] Clean up SDCallSiteDbgInfo accessors.
Mar 16 2022, 9:46 AM · Restricted Project, Restricted Project
melver requested review of D121820: [SelectionDAG][NFC] Clean up SDCallSiteDbgInfo accessors.
Mar 16 2022, 9:29 AM · Restricted Project, Restricted Project

Mar 10 2022

melver accepted D121363: tsan: fix another false positive related to open/close.
Mar 10 2022, 2:59 AM · Unknown Object (Project), Restricted Project

Mar 7 2022

melver accepted D121143: tsan: fix false positive during fd close.
Mar 7 2022, 12:26 PM · Restricted Project, Unknown Object (Project)

Mar 1 2022

melver committed rG17ce89fa8016: [SanitizerBounds] Add support for NoSanitizeBounds function (authored by ztong0001).
[SanitizerBounds] Add support for NoSanitizeBounds function
Mar 1 2022, 9:48 AM
melver closed D119816: [SanitizerBounds] Add support for NoSanitizeBounds function.
Mar 1 2022, 9:48 AM · Restricted Project, Restricted Project
melver added a comment to D119816: [SanitizerBounds] Add support for NoSanitizeBounds function.

Hi Marco,
@melver, Could you please help me landing it? I don't have write permission to the repo.
Please use Tong Zhang<ztong0001@gmail.com>

Mar 1 2022, 9:39 AM · Restricted Project, Restricted Project

Feb 28 2022

melver accepted D119816: [SanitizerBounds] Add support for NoSanitizeBounds function.

Let me know if you need help landing this.

Feb 28 2022, 8:54 AM · Restricted Project, Restricted Project

Feb 25 2022

melver added inline comments to D119816: [SanitizerBounds] Add support for NoSanitizeBounds function.
Feb 25 2022, 12:15 PM · Restricted Project, Restricted Project
melver added inline comments to D119816: [SanitizerBounds] Add support for NoSanitizeBounds function.
Feb 25 2022, 4:42 AM · Restricted Project, Restricted Project
melver requested changes to D119816: [SanitizerBounds] Add support for NoSanitizeBounds function.

Looks good. Few minor changes.

Feb 25 2022, 4:39 AM · Restricted Project, Restricted Project

Feb 24 2022

melver requested changes to D119816: [SanitizerBounds] Add support for NoSanitizeBounds function.

Thanks - this looks good so far.

Feb 24 2022, 9:01 AM · Restricted Project, Restricted Project

Feb 22 2022

melver added a comment to D119816: [SanitizerBounds] Add support for NoSanitizeBounds function.

Adding a new IR attribute comes with a whole slew of other required changes. Please see https://reviews.llvm.org/D102772 for an example.

Feb 22 2022, 4:20 AM · Restricted Project, Restricted Project

Feb 18 2022

melver updated subscribers of D119816: [SanitizerBounds] Add support for NoSanitizeBounds function.
Feb 18 2022, 10:14 AM · Restricted Project, Restricted Project
melver added a comment to D119816: [SanitizerBounds] Add support for NoSanitizeBounds function.

Right, I was able to repro this. The problem is the trap, which generally sucks that no_sanitize still leaves in the trap.

Feb 18 2022, 5:13 AM · Restricted Project, Restricted Project
melver added a comment to D119816: [SanitizerBounds] Add support for NoSanitizeBounds function.

What about this test then: https://github.com/llvm/llvm-project/blob/b0a0df980927ca54a7840a1b0c9766e98c05039b/clang/test/CodeGen/sanitize-coverage.c#L74

Feb 18 2022, 4:40 AM · Restricted Project, Restricted Project

Feb 14 2022

melver accepted D119726: [asan] Add support for disable_sanitizer_instrumentation attribute.
Feb 14 2022, 8:22 AM · Restricted Project, Restricted Project
melver added a comment to D114421: [asan] Add support for disable_sanitizer_instrumentation attribute.

I think we dropped the ball on this - was it ever re-reverted?
Is it still worth trying to land this?

Feb 14 2022, 6:47 AM · Restricted Project, Restricted Project

Feb 11 2022

melver added a comment to D119546: sanitizer_common: make internal/external headers compatible.

It's an interface struct. We can't delete. User code may be referring to it.

Feb 11 2022, 9:04 AM · Unknown Object (Project)
melver accepted D119546: sanitizer_common: make internal/external headers compatible.

Note, __sanitizer_sandbox_arguments seems unused, i.e. I don't see any of its members used anywhere?

Feb 11 2022, 8:53 AM · Unknown Object (Project)
melver added inline comments to D119546: sanitizer_common: make internal/external headers compatible.
Feb 11 2022, 7:51 AM · Unknown Object (Project)

Feb 3 2022

melver accepted D118910: sanitizer_common: fix __sanitizer_get_module_and_offset_for_pc signature mismatch.
Feb 3 2022, 9:29 AM · Unknown Object (Project)

Jan 20 2022

melver committed rGc65186c89f35: [clang] Improve -Wdeclaration-after-statement (authored by melver).
[clang] Improve -Wdeclaration-after-statement
Jan 20 2022, 10:57 AM
melver closed D117232: [clang] Improve -Wdeclaration-after-statement.
Jan 20 2022, 10:57 AM · Restricted Project
melver updated the diff for D117232: [clang] Improve -Wdeclaration-after-statement.

Use `..` in ReleaseNotes.rst.

Jan 20 2022, 10:35 AM · Restricted Project
melver updated the diff for D117232: [clang] Improve -Wdeclaration-after-statement.

Rebase and rework to include improvements over already submitted code.

Jan 20 2022, 8:33 AM · Restricted Project
melver added a comment to D117232: [clang] Improve -Wdeclaration-after-statement.

Looks like https://reviews.llvm.org/D114787 does the same thing and was submitted a week ago.

Jan 20 2022, 7:46 AM · Restricted Project
melver added a comment to D117232: [clang] Improve -Wdeclaration-after-statement.

A quick review would be much appreciated. I intend to submit this before Feb 1 so it may be included in Clang 14.

Jan 20 2022, 4:02 AM · Restricted Project

Jan 13 2022

melver requested review of D117232: [clang] Improve -Wdeclaration-after-statement.
Jan 13 2022, 8:48 AM · Restricted Project

Jan 12 2022

melver committed rG732ad8ea62ed: [clang][auto-init] Provide __builtin_alloca*_uninitialized variants (authored by melver).
[clang][auto-init] Provide __builtin_alloca*_uninitialized variants
Jan 12 2022, 6:20 AM
melver closed D115440: Provide __builtin_alloca*_uninitialized variants.
Jan 12 2022, 6:20 AM · Restricted Project

Jan 10 2022

melver added a comment to D115440: Provide __builtin_alloca*_uninitialized variants.

We need a solution for this problem, and because I haven't heard any objections I'll assume the general approach is fine -- @jfb already kindly confirmed that "[...] patch you propose here is a good idea".

Jan 10 2022, 6:44 AM · Restricted Project

Dec 23 2021

melver accepted D116128: [clang][driver] Warn when '-mno-outline-atomics' is used with a non-AArch64 triple.
Dec 23 2021, 8:34 AM · Restricted Project

Dec 22 2021

melver accepted D116128: [clang][driver] Warn when '-mno-outline-atomics' is used with a non-AArch64 triple.
Dec 22 2021, 3:14 AM · Restricted Project

Dec 21 2021

melver accepted D116095: tsan: always handle closing of file descriptors.
Dec 21 2021, 3:42 AM · Unknown Object (Project)
melver accepted D116091: tsan: fix failures after multi-threaded fork.
Dec 21 2021, 3:25 AM · Unknown Object (Project)

Dec 20 2021

melver accepted D116041: tsan: fix NULL deref in TraceSwitchPart.
Dec 20 2021, 8:29 AM · Unknown Object (Project)
melver accepted D116040: tsan: fix deadlock during race reporting.
Dec 20 2021, 8:28 AM · Unknown Object (Project)

Dec 16 2021

melver added a reviewer for D115440: Provide __builtin_alloca*_uninitialized variants: rjmccall.
Dec 16 2021, 4:46 AM · Restricted Project

Dec 15 2021

melver added a reviewer for D115440: Provide __builtin_alloca*_uninitialized variants: aaron.ballman.
Dec 15 2021, 3:49 PM · Restricted Project

Dec 14 2021

melver updated subscribers of D115440: Provide __builtin_alloca*_uninitialized variants.

@tstellar , we were told maybe you have some input.

Dec 14 2021, 2:45 AM · Restricted Project
melver reclaimed D115440: Provide __builtin_alloca*_uninitialized variants.

Let's consult libc's own documentation https://www.gnu.org/software/libc/manual/html_node/Variable-Size-Automatic.html

It states:

Automatic Storage with Variable Size
The function alloca supports a kind of half-dynamic allocation in which blocks are allocated dynamically but freed automatically.

Dec 14 2021, 12:49 AM · Restricted Project

Dec 13 2021

melver accepted D115613: tsan: deflake dlopen_static_tls.cpp.
Dec 13 2021, 3:00 AM · Unknown Object (Project)
melver accepted D115612: tsan: deflake flush_memory.cpp.
Dec 13 2021, 2:59 AM · Unknown Object (Project)

Dec 9 2021

melver abandoned D115440: Provide __builtin_alloca*_uninitialized variants.

GCC devs say that initializing explicit alloca() is a bug, because they aren't "automatic storage": https://lkml.kernel.org/r/20211209201616.GU614@gate.crashing.org
.. which is also the reason why GCC's behaviour differs here at the moment.

Dec 9 2021, 1:00 PM · Restricted Project
melver retitled D115440: Provide __builtin_alloca*_uninitialized variants from [clang][auto-init] Provide __builtin_alloca_uninitialized to Provide __builtin_alloca*_uninitialized variants.
Dec 9 2021, 7:33 AM · Restricted Project
melver added inline comments to D115440: Provide __builtin_alloca*_uninitialized variants.
Dec 9 2021, 5:23 AM · Restricted Project
melver updated the diff for D115440: Provide __builtin_alloca*_uninitialized variants.

For completeness, also provide __builtin_alloca_with_align_uninitialized().

Dec 9 2021, 5:23 AM · Restricted Project
melver requested review of D115440: Provide __builtin_alloca*_uninitialized variants.
Dec 9 2021, 4:44 AM · Restricted Project
melver added inline comments to D115236: [msan] Implement -msan-disable-checks..
Dec 9 2021, 3:31 AM · Restricted Project

Dec 8 2021

melver accepted D115236: [msan] Implement -msan-disable-checks..
Dec 8 2021, 5:18 AM · Restricted Project
melver added inline comments to D115236: [msan] Implement -msan-disable-checks..
Dec 8 2021, 1:13 AM · Restricted Project

Dec 6 2021

melver accepted D115142: tsan: disable dlopen_static_tls.cpp test on powerpc64.
Dec 6 2021, 3:49 AM · Unknown Object (Project)

Dec 3 2021

melver added a comment to D108394: add tsan shared library.

If possible please use arc diff and amend to get the canonical commit message format (see git log for other commits).
Otherwise Phabricator won't be able to track the history of what's been happening.

Dec 3 2021, 7:43 AM · Restricted Project, Unknown Object (Project)

Dec 2 2021

melver accepted D114972: tsan: disable munmap_invalid.cpp test on darwin.

Maybe Darwin kernel behaves a little differently here and crashes the program?
Maybe yln@ knows?

Dec 2 2021, 9:49 AM · Unknown Object (Project)
melver accepted D114953: tsan: fix false positives in dynamic libs with static tls.
Dec 2 2021, 8:08 AM · Unknown Object (Project)
melver accepted D114944: tsan: tolerate munmap with invalid arguments.
Dec 2 2021, 4:53 AM · Unknown Object (Project)

Nov 25 2021

melver accepted D114607: tsan: remember and print function that installed at_exit callbacks.
Nov 25 2021, 11:06 AM · Unknown Object (Project)
melver accepted D114606: tsan: add a test for on_exit.
Nov 25 2021, 10:58 AM · Unknown Object (Project)
melver accepted D114605: tsan: add test for __cxa_atexit.
Nov 25 2021, 10:55 AM · Unknown Object (Project)
melver accepted D114604: tsan: check stack in atexit4.cpp test.
Nov 25 2021, 10:52 AM · Unknown Object (Project)
melver accepted D114597: tsan: fix another potential deadlock in fork.
Nov 25 2021, 7:32 AM · Unknown Object (Project)
melver accepted D114594: tsan: optimize __tsan_read/write16.
Nov 25 2021, 7:31 AM · Unknown Object (Project)
melver accepted D114595: tsan: fix Java heap block begin in reports.
Nov 25 2021, 7:20 AM · Unknown Object (Project)
melver accepted D114593: tsan: add a benchmark for vector memory accesses.
Nov 25 2021, 7:17 AM · Unknown Object (Project)
melver accepted D114592: tsan: add a test for vector memory accesses.
Nov 25 2021, 7:14 AM · Unknown Object (Project)
melver accepted D114591: tsan: enable -msse4 when compiling tests.

Is COMPILER_RT_HAS_MSSE4_2_FLAG only true if the host has support?

Nov 25 2021, 7:12 AM · Unknown Object (Project)

Nov 24 2021

melver accepted D114532: tsan: include internal allocator into deadlock detection.

Nice!

Nov 24 2021, 6:27 AM · Unknown Object (Project)
melver accepted D114531: tsan: lock internal allocator around fork.
Nov 24 2021, 6:15 AM · Restricted Project