[lldb][DWARF5] Enable macro evaluation

[kpdev42]

Summary

Patch enables handing of DWARFv5 DW_MACRO_define_strx and DW_MACRO_undef_strx

~~~

OS Laboratory. Huawei RRI. Saint-Petersburg

[tschuett]

lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugMacro.h

27

If you would use a class instead of the struct, you could hide the member variables.

The class variant is slightly more verbose than the struct.

[clayborg]

lldb/source/Plugins/SymbolFile/DWARF/DWARFContext.cpp

95–97

This enum should be different otherwise this code change does nothing.

lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugMacro.cpp

22

I would make this DWARF64 compatible.

lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugMacro.h

28

"cu_offset" sounds like it is actually the offset of the compile unit. This is actually the compile unit offset for the string data for the compile unit in the string index section right? Maybe a name like "cu_str_offset" or "cu_strx_offset" would be a better name?

29

Can "data" ever be NULL? If not, then change this to a reference and add a constructor that inits the reference?

31

if you are going to keep "data" as a pointer, shouldn't this function also check "data" against nullptr?

lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

1239–1244

If we want to change "data" to be a reference, we will need a constructor:

DWARFStrOffsetsInfo str_offsets_info(dwarf_cu->GetStrOffsetsBase(), symfile.GetDWARFContext().getOrLoadStrOffsetsData());

[clayborg]

lldb/source/Plugins/SymbolFile/DWARF/DWARFContext.cpp

96

Never mind me! Just checked the LoadOrGetSection definition. They were all different for other sections, so I thought they needed to be different...

[kpdev42]

Address review notes

[kpdev42]

Ping

[aprantl]

This test fails to compile on Darwin

https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/46816/testReport/junit/lldb-api/commands_expression_macros/TestMacros_py/
https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/46811/

Can you please add a @skipIfDarwin decorator?

[aprantl]

Out of curiosity — did you get an email notification from the bot?

[kpdev42]

In D130062#3789671, @aprantl wrote:

Out of curiosity — did you get an email notification from the bot?

Hi, yes, I will add a priority to these notifications to react faster, sorry

[aprantl]

In D130062#3789858, @kpdev42 wrote:

In D130062#3789671, @aprantl wrote:

Out of curiosity — did you get an email notification from the bot?

Hi, yes, I will add a priority to these notifications to react faster, sorry

Great. I was asking because we had issues with the bot not sending these out recently.