- User Since
- Aug 19 2019, 4:12 AM (31 w, 6 d)
Sat, Mar 7
Feb 27 2020
Ok, thanks a lot )
Thank you. Should I close this revision?
Feb 26 2020
Change formatting in AArch64ISelDAGToDAG.cpp according to codestyle
Thank you for the review. (All of you)
Unfortunately I don't have commit access, would you please submit this change on my behalf? )
Update test with two uses of AND
All commentaries are resolved, patch is ready for review )
Feb 25 2020
Add a test case with two uses of AND instruction
Plus make some simplification of code in AArch64ISelLowering
Please take a look at this patch )
Feb 20 2020
All changes moved from InstrInfo to ISelLowering
Jan 29 2020
Update patch: move all changes to AArch64InstrInfo::optimizeCondBranch(MachineInstr &MI) as it was planned.
But I do not know if it is a finally version, because as I see from the discussion - moving this functionality to ISel is more preferable.
So, do I need to create another patch with ISel implementation (I mean - create another differential revision), or it is better to change this patch?
Jan 28 2020
Jan 27 2020
Ping. I would be grateful for your commentaries about this patch. Maybe this code should be changed in some way?
Dec 20 2019
In lambda IsWorthwile in mergeConditionalStoreToAddress added check for additional instructions which will be generated after select lowering
Dec 19 2019
Nov 25 2019
Nov 22 2019
Fix formatting in SimplifyCFG.cpp and remaster testcase (I reduced it more accurately to avoid overreducing)
Please @lebedev.ri take a look
Nov 20 2019
I changed my patch, now before merging blocks it calculates existing instructions in DomBB,
just to be sure that this block is not too big already
Maybe instead of using phi-node-folding threshold it is needed to use some other separate threshold.
Sep 16 2019
Yes, I think it is possible, that this code should be changed later in backend. It needs more investigation )
Sep 12 2019
I need to change my patch entirely, it needs discussion in mailing list and it will take time, so at the moment I will close this revision and after some time create another one.
Thanks to all.
Sep 11 2019
Yes, sure, will upload it in 24 hours, thank you!
Sep 10 2019
Rework patch. Allow merge store but bring additional check to FoldTwoEntryPHINode: before hoisting all instructions from IfBlock0 and IfBlock1 to DomBlock we check number of instructions in this DomBlock.
Simplify test case. Relevant C code is:
Sep 9 2019
I checked D67315 , unfortunately it does not help, generated code is the same.
Thank you for detailed answer.
Sep 6 2019
Maybe the reason of this regression is not here and I worked in wrong direction. If so - I will really appreciate any clarifications about it