Page MenuHomePhabricator

kpdev42 (Pavel Kosov)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2019, 4:12 AM (171 w, 2 d)

Recent Activity

Mon, Nov 21

kpdev42 added a comment to D138202: [OHOS] Add support for OpenHarmony.

Ping) Any thoughts, questions?

Mon, Nov 21, 2:52 AM · Restricted Project, Restricted Project

Thu, Nov 17

kpdev42 updated the diff for D138202: [OHOS] Add support for OpenHarmony.

Remove tls-related changes
Add link to dicourse thread

Thu, Nov 17, 11:48 AM · Restricted Project, Restricted Project
kpdev42 requested review of D138202: [OHOS] Add support for OpenHarmony.
Thu, Nov 17, 5:27 AM · Restricted Project, Restricted Project

Wed, Nov 9

Herald added a project to D112201: [CortexA55][SchedModels] Complete Cortex-A55 scheduler model: Restricted Project.

ping

Wed, Nov 9, 1:44 AM · Restricted Project, Restricted Project

Sep 14 2022

kpdev42 added a comment to D130062: [lldb][DWARF5] Enable macro evaluation.

Out of curiosity — did you get an email notification from the bot?

Sep 14 2022, 9:18 AM · Restricted Project, Restricted Project, Restricted Project
kpdev42 committed rGa0fb69d17b4d: [lldb][DWARF5] Enable macro evaluation (authored by kpdev42).
[lldb][DWARF5] Enable macro evaluation
Sep 14 2022, 1:33 AM · Restricted Project
kpdev42 closed D130062: [lldb][DWARF5] Enable macro evaluation.
Sep 14 2022, 1:32 AM · Restricted Project, Restricted Project, Restricted Project

Sep 7 2022

kpdev42 added a comment to D130062: [lldb][DWARF5] Enable macro evaluation.

Ping

Sep 7 2022, 2:53 AM · Restricted Project, Restricted Project, Restricted Project

Sep 5 2022

kpdev42 added a comment to D132490: [LoopVectorize] Emit runtime checks correctly for nested loops.

Thanks for the update. As I mentioned in the previous message, I think it would be good to just land the test in this patch and I'll submit the code change separately. The test looks good to me.

Thank you fer the review.
Lets keep buildbot green. Please land both fix and test case on your own

Thanks, the idea would be to commit the test first with the checks so it passes without the fix. The fix then only shows the improvements on the test case, so the bots would stay green at all time.

Sep 5 2022, 5:51 AM · Restricted Project, Restricted Project, Restricted Project

Aug 25 2022

kpdev42 updated the summary of D130062: [lldb][DWARF5] Enable macro evaluation.
Aug 25 2022, 12:37 AM · Restricted Project, Restricted Project, Restricted Project
kpdev42 updated the summary of D132490: [LoopVectorize] Emit runtime checks correctly for nested loops.
Aug 25 2022, 12:37 AM · Restricted Project, Restricted Project, Restricted Project
kpdev42 added a comment to D132490: [LoopVectorize] Emit runtime checks correctly for nested loops.

Thanks for the update. As I mentioned in the previous message, I think it would be good to just land the test in this patch and I'll submit the code change separately. The test looks good to me.

Aug 25 2022, 12:35 AM · Restricted Project, Restricted Project, Restricted Project

Aug 24 2022

kpdev42 updated the diff for D132490: [LoopVectorize] Emit runtime checks correctly for nested loops.
Aug 24 2022, 11:29 AM · Restricted Project, Restricted Project, Restricted Project

Aug 23 2022

kpdev42 updated the diff for D132490: [LoopVectorize] Emit runtime checks correctly for nested loops.

Remove unrelated changes

Aug 23 2022, 11:18 AM · Restricted Project, Restricted Project, Restricted Project
kpdev42 requested review of D132490: [LoopVectorize] Emit runtime checks correctly for nested loops.
Aug 23 2022, 10:52 AM · Restricted Project, Restricted Project, Restricted Project

Aug 16 2022

kpdev42 committed rGff9efe240c47: [LLDB][JIT] Set processor for ARM architecture (authored by kpdev42).
[LLDB][JIT] Set processor for ARM architecture
Aug 16 2022, 11:15 PM · Restricted Project
kpdev42 closed D131783: [LLDB][JIT] Set processor for ARM architecture.
Aug 16 2022, 11:15 PM · Restricted Project, Restricted Project

Aug 12 2022

kpdev42 requested review of D131783: [LLDB][JIT] Set processor for ARM architecture.
Aug 12 2022, 8:12 AM · Restricted Project, Restricted Project

Aug 10 2022

kpdev42 committed rGf63e2cfb7f52: [LLDB] Add basic floating point ops to IR interpreter (authored by kpdev42).
[LLDB] Add basic floating point ops to IR interpreter
Aug 10 2022, 6:36 AM · Restricted Project
kpdev42 closed D126359: [LLDB] Add basic floating point ops to IR interpreter.
Aug 10 2022, 6:35 AM · Restricted Project, Restricted Project
kpdev42 updated the diff for D130062: [lldb][DWARF5] Enable macro evaluation.

Address review notes

Aug 10 2022, 12:09 AM · Restricted Project, Restricted Project, Restricted Project

Aug 5 2022

kpdev42 updated the diff for D126359: [LLDB] Add basic floating point ops to IR interpreter.

Update test case so it compares JIT’ed and interpreted FP division results and also check operations on float type. Patch doesn’t implement long double, because IR interpreter currently doesn’t support instruction argument size of more than 64 bit which includes both fp128 and int128. This deserves a separate patch, I think

Aug 5 2022, 12:15 AM · Restricted Project, Restricted Project

Jul 26 2022

kpdev42 added inline comments to D126359: [LLDB] Add basic floating point ops to IR interpreter.
Jul 26 2022, 5:58 AM · Restricted Project, Restricted Project

Jul 19 2022

kpdev42 requested review of D130062: [lldb][DWARF5] Enable macro evaluation.
Jul 19 2022, 1:04 AM · Restricted Project, Restricted Project, Restricted Project

Jun 26 2022

kpdev42 updated the diff for D126359: [LLDB] Add basic floating point ops to IR interpreter.

Address review notes

Jun 26 2022, 9:50 PM · Restricted Project, Restricted Project

May 27 2022

kpdev42 updated the diff for D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support.

Well, after some investigation it turned out that:

  1. ARMv5 has DMB instruction in the form of mcr p15, #0, <Rd>, c7, c10, #5
  2. There is SWP instruction (deprecated on ARMv6), which does atomic exchange of 32-bit values

I've reimplemented sync ops using these primitves, PTAL
Theoretically this should work on ARMv6 and higher, though I didn't check this

May 27 2022, 12:18 AM · Restricted Project, Restricted Project, Restricted Project

May 25 2022

kpdev42 requested review of D126359: [LLDB] Add basic floating point ops to IR interpreter.
May 25 2022, 1:39 AM · Restricted Project, Restricted Project

May 24 2022

kpdev42 added a comment to D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support.

At the moment, in case of compiler-rt, __sync_add_and_fetch boils down to
__sync_add_and_fetch_N, where N is the size of data being fetched (4 for int).
The implementation of __sync_fetch_and_add_N does approximately the following:

May 24 2022, 6:02 AM · Restricted Project, Restricted Project, Restricted Project

May 18 2022

kpdev42 added a comment to D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support.

D120026 is merged now, which addresses the issue of the compiler generating __sync calls where it isn't supposed to.

Does anyone want to continue discussing what changes to compiler-rt would be appropriate? I didn't mean to completely shut down discussion with my comment.

May 18 2022, 6:28 AM · Restricted Project, Restricted Project, Restricted Project

Apr 15 2022

kpdev42 committed rGa5b7ea0783f7: [llvm-objdump] Implemented PrintBranchImmAsAddress for MIPS (authored by kpdev42).
[llvm-objdump] Implemented PrintBranchImmAsAddress for MIPS
Apr 15 2022, 2:49 PM · Restricted Project, Restricted Project
kpdev42 closed D123764: [llvm-objdump] Implemented PrintBranchImmAsAddress for MIPS.
Apr 15 2022, 2:48 PM · Restricted Project, Restricted Project
kpdev42 updated the diff for D123764: [llvm-objdump] Implemented PrintBranchImmAsAddress for MIPS.

Updated lld tests. Please note I have used the mask instead of annotated offsets. I did not use the mask where the offset value is important (relocs, etc.)

Apr 15 2022, 2:36 AM · Restricted Project, Restricted Project

Apr 14 2022

kpdev42 updated the diff for D123764: [llvm-objdump] Implemented PrintBranchImmAsAddress for MIPS.
  • Updated jal and jalx instructions
  • Fixed lld tests
  • Rebased
Apr 14 2022, 11:08 PM · Restricted Project, Restricted Project
kpdev42 requested review of D123766: [CompilerRT] Fix 128-bit floating point division.
Apr 14 2022, 1:41 AM · Restricted Project, Restricted Project, Restricted Project
kpdev42 requested review of D123764: [llvm-objdump] Implemented PrintBranchImmAsAddress for MIPS.
Apr 14 2022, 1:34 AM · Restricted Project, Restricted Project

Mar 29 2022

kpdev42 committed rLNTcbee5139ca43: [LNT] Fixed incorrect orders behavior in case of miss formatted… (authored by kpdev42).
[LNT] Fixed incorrect orders behavior in case of miss formatted…
Mar 29 2022, 12:49 PM · Restricted Project
kpdev42 closed D109577: [LNT] Fixed incorrect orders behavior in case of miss formatted llvm_project_revision.
Mar 29 2022, 12:49 PM · Restricted Project, Restricted Project
kpdev42 updated the diff for D109577: [LNT] Fixed incorrect orders behavior in case of miss formatted llvm_project_revision.

Add hashlib

Mar 29 2022, 5:48 AM · Restricted Project, Restricted Project

Mar 23 2022

kpdev42 added a comment to D109577: [LNT] Fixed incorrect orders behavior in case of miss formatted llvm_project_revision.

Actually, I just realized this has a serious bug. The hash function in python is salted, so results are different between process restarts.

https://docs.python.org/3/reference/datamodel.html#object.__hash__

Can you use a different hash function?

Mar 23 2022, 12:31 AM · Restricted Project, Restricted Project

Mar 2 2022

kpdev42 committed rLNT3f6e19818b68: [LNT] Combine perf data metrics from several files (authored by kpdev42).
[LNT] Combine perf data metrics from several files
Mar 2 2022, 3:26 PM · Restricted Project
kpdev42 closed D114770: [LNT] Combine perf data metrics from several files.
Mar 2 2022, 3:26 PM · Restricted Project, Restricted Project
kpdev42 committed rLNT44cd77705dc0: [LNT] Removed `0x` checking for offsets in profile assembly (authored by kpdev42).
[LNT] Removed `0x` checking for offsets in profile assembly
Mar 2 2022, 3:26 PM · Restricted Project
kpdev42 closed D120539: [LNT] Removed `0x` checking for offsets in profile assembly.
Mar 2 2022, 3:26 PM · Restricted Project, Restricted Project
Herald added a project to D120539: [LNT] Removed `0x` checking for offsets in profile assembly: Restricted Project.

Ping

Mar 2 2022, 1:51 AM · Restricted Project, Restricted Project

Feb 24 2022

kpdev42 requested review of D120539: [LNT] Removed `0x` checking for offsets in profile assembly.
Feb 24 2022, 10:40 PM · Restricted Project, Restricted Project

Feb 21 2022

kpdev42 updated the diff for D112201: [CortexA55][SchedModels] Complete Cortex-A55 scheduler model.

An update for Cortex-A55 model. It contains ASIMD fp, misc, crypto and crc instructions.

Feb 21 2022, 9:31 PM · Restricted Project, Restricted Project

Feb 17 2022

kpdev42 committed rG37fa99eda0f5: [SchedModels][CortexA55] Add ASIMD integer instructions (authored by kpdev42).
[SchedModels][CortexA55] Add ASIMD integer instructions
Feb 17 2022, 2:43 AM
kpdev42 committed rGf3809b20f2d9: [AArch64][SchedModels] Handle virtual registers in FP/NEON predicates (authored by kpdev42).
[AArch64][SchedModels] Handle virtual registers in FP/NEON predicates
Feb 17 2022, 2:43 AM
kpdev42 closed D117003: [SchedModels][CortexA55] Add ASIMD integer instructioins.
Feb 17 2022, 2:43 AM · Restricted Project
kpdev42 closed D114642: [AArch64][SchedModels] Handle virtual registers in FP/NEON predicates.
Feb 17 2022, 2:43 AM · Restricted Project

Feb 16 2022

kpdev42 committed rGf165c23bf359: [NFC][compiler-rt] Format file lib/builtins/arm/sync-ops.h (authored by kpdev42).
[NFC][compiler-rt] Format file lib/builtins/arm/sync-ops.h
Feb 16 2022, 11:22 PM
kpdev42 committed rG910a642c0a5b: [compiler-rt] Implement ARM atomic operations for architectures without SMP… (authored by kpdev42).
[compiler-rt] Implement ARM atomic operations for architectures without SMP…
Feb 16 2022, 11:12 PM
kpdev42 closed D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support.
Feb 16 2022, 11:11 PM · Restricted Project, Restricted Project, Restricted Project

Feb 11 2022

kpdev42 updated the diff for D117003: [SchedModels][CortexA55] Add ASIMD integer instructioins.

Addressed review comments

Feb 11 2022, 7:22 AM · Restricted Project
kpdev42 updated the diff for D114642: [AArch64][SchedModels] Handle virtual registers in FP/NEON predicates.

@dmgreen

Is it possible to a better example? COPY instructions (especially no-op copys like these) are often expected to be removed by reg-alloc and any scheduling info you give them is likely misleading.”

Feb 11 2022, 6:24 AM · Restricted Project
kpdev42 added a comment to D114770: [LNT] Combine perf data metrics from several files.

@cmatthews Hi, could you please review latest changes?

Feb 11 2022, 6:11 AM · Restricted Project, Restricted Project

Feb 7 2022

kpdev42 updated the diff for D117003: [SchedModels][CortexA55] Add ASIMD integer instructioins.

Addressed review comments

Feb 7 2022, 10:37 PM · Restricted Project
kpdev42 added inline comments to D117003: [SchedModels][CortexA55] Add ASIMD integer instructioins.
Feb 7 2022, 10:36 PM · Restricted Project

Feb 3 2022

kpdev42 committed rLNTf984afe87ae3: NFC, fixed typo (authored by kpdev42).
NFC, fixed typo
Feb 3 2022, 8:55 AM

Jan 27 2022

kpdev42 committed rLNT9846672b95f4: [LNT] Fix the graph page to show multiple metrics for the same test (authored by kpdev42).
[LNT] Fix the graph page to show multiple metrics for the same test
Jan 27 2022, 4:23 AM
kpdev42 closed D118170: [LNT] Fix the graph page to show multiple metrics for the same test.
Jan 27 2022, 4:23 AM · Restricted Project

Jan 25 2022

kpdev42 requested review of D118170: [LNT] Fix the graph page to show multiple metrics for the same test.
Jan 25 2022, 11:25 AM · Restricted Project

Jan 20 2022

kpdev42 added a comment to D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support.

Correct me if I'm wrong, but I don't think this stubs are async signal safe nor will they work for preemptive multitasking systems?

Jan 20 2022, 6:17 AM · Restricted Project, Restricted Project, Restricted Project
kpdev42 added a comment to D114642: [AArch64][SchedModels] Handle virtual registers in FP/NEON predicates.

Ping

Jan 20 2022, 5:43 AM · Restricted Project

Jan 19 2022

kpdev42 committed rLNTbbf46b2fe6b1: [LNT] Fix profile assigning to tests (authored by kpdev42).
[LNT] Fix profile assigning to tests
Jan 19 2022, 2:44 AM
kpdev42 closed D115702: [LNT] Fix profile assigning to tests.
Jan 19 2022, 2:44 AM · Restricted Project

Jan 18 2022

kpdev42 updated the diff for D115702: [LNT] Fix profile assigning to tests.

Address review commentaries. Thank you

Jan 18 2022, 11:18 PM · Restricted Project

Jan 12 2022

kpdev42 added a comment to D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support.

Ping

Jan 12 2022, 2:03 AM · Restricted Project, Restricted Project, Restricted Project
kpdev42 added a comment to D114770: [LNT] Combine perf data metrics from several files.

Ping

Jan 12 2022, 1:45 AM · Restricted Project, Restricted Project

Jan 11 2022

kpdev42 committed rLNTe4ede111df1f: [LNT] Fixed the time extraction from MMAP and MMAP2 events using the Layout (authored by kpdev42).
[LNT] Fixed the time extraction from MMAP and MMAP2 events using the Layout
Jan 11 2022, 8:48 AM
kpdev42 closed D117008: [LNT] Fixed the time extraction from MMAP and MMAP2 events using the Layout.
Jan 11 2022, 8:48 AM · Restricted Project
kpdev42 closed D117007: [LNT] NFC. Improvements to cPerf.
Jan 11 2022, 8:48 AM · Restricted Project
kpdev42 committed rLNTd08e89064afd: [LNT] NFC. Improvements to cPerf (authored by kpdev42).
[LNT] NFC. Improvements to cPerf
Jan 11 2022, 8:48 AM
kpdev42 added a comment to D115702: [LNT] Fix profile assigning to tests.

Ping

Jan 11 2022, 4:00 AM · Restricted Project
kpdev42 requested review of D117008: [LNT] Fixed the time extraction from MMAP and MMAP2 events using the Layout.
Jan 11 2022, 3:55 AM · Restricted Project
kpdev42 requested review of D117007: [LNT] NFC. Improvements to cPerf.
Jan 11 2022, 3:52 AM · Restricted Project
kpdev42 requested review of D117003: [SchedModels][CortexA55] Add ASIMD integer instructioins.
Jan 11 2022, 3:04 AM · Restricted Project
kpdev42 updated the diff for D114642: [AArch64][SchedModels] Handle virtual registers in FP/NEON predicates.

Strip unneeded code and fix compilation issues

Jan 11 2022, 2:44 AM · Restricted Project

Jan 9 2022

kpdev42 committed rG34a91d7748d4: [SchedModels][CortexA55] Fix scheduling of FP loads (authored by kpdev42).
[SchedModels][CortexA55] Fix scheduling of FP loads
Jan 9 2022, 11:15 PM
kpdev42 closed D116361: [SchedModels][CortexA55] Fix scheduling of FP loads.
Jan 9 2022, 11:15 PM · Restricted Project

Dec 29 2021

kpdev42 updated subscribers of D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support.
Dec 29 2021, 1:35 AM · Restricted Project, Restricted Project, Restricted Project

Dec 28 2021

kpdev42 added a comment to D112201: [CortexA55][SchedModels] Complete Cortex-A55 scheduler model.

OK Thanks. I presume this is run on a Cortex-A55? And the noise is low enough to make them meaningful?

Dec 28 2021, 10:37 PM · Restricted Project, Restricted Project
kpdev42 updated the summary of D112201: [CortexA55][SchedModels] Complete Cortex-A55 scheduler model.
Dec 28 2021, 10:31 PM · Restricted Project, Restricted Project
kpdev42 requested review of D116361: [SchedModels][CortexA55] Fix scheduling of FP loads.
Dec 28 2021, 10:31 PM · Restricted Project

Dec 20 2021

kpdev42 requested review of D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support.
Dec 20 2021, 10:41 PM · Restricted Project, Restricted Project, Restricted Project

Dec 15 2021

kpdev42 added a comment to D114642: [AArch64][SchedModels] Handle virtual registers in FP/NEON predicates.

Ping

Dec 15 2021, 2:17 AM · Restricted Project

Dec 14 2021

kpdev42 committed rLNT016a4a7b6b50: [LNT] Fixed cPerf tests (authored by kpdev42).
[LNT] Fixed cPerf tests
Dec 14 2021, 12:24 PM
kpdev42 closed D115703: [LNT] Fixed cPerf tests.
Dec 14 2021, 12:24 PM · Restricted Project
kpdev42 committed rLNT3c979d8effcc: [LNT] Fix sidebar (authored by kpdev42).
[LNT] Fix sidebar
Dec 14 2021, 12:24 PM
kpdev42 closed D115701: [LNT] Fix sidebar.
Dec 14 2021, 12:24 PM · Restricted Project
kpdev42 committed rLNT7f5f72a30e7c: [LNT] Fix the global_status page (authored by kpdev42).
[LNT] Fix the global_status page
Dec 14 2021, 12:24 PM
kpdev42 closed D115700: [LNT] Fix the global_status page.
Dec 14 2021, 12:24 PM · Restricted Project
kpdev42 updated the summary of D115700: [LNT] Fix the global_status page.
Dec 14 2021, 5:59 AM · Restricted Project
kpdev42 updated the diff for D115703: [LNT] Fixed cPerf tests.

Add a newline after the end of the docstring

Dec 14 2021, 5:58 AM · Restricted Project
kpdev42 updated the diff for D115700: [LNT] Fix the global_status page.

Fix flake8 "continuation line under-indented for visual indent"

Dec 14 2021, 5:45 AM · Restricted Project

Dec 13 2021

kpdev42 requested review of D115703: [LNT] Fixed cPerf tests.
Dec 13 2021, 10:58 PM · Restricted Project
kpdev42 requested review of D115702: [LNT] Fix profile assigning to tests.
Dec 13 2021, 10:55 PM · Restricted Project
kpdev42 requested review of D115701: [LNT] Fix sidebar.
Dec 13 2021, 10:51 PM · Restricted Project
kpdev42 requested review of D115700: [LNT] Fix the global_status page.
Dec 13 2021, 10:47 PM · Restricted Project
kpdev42 added inline comments to D114770: [LNT] Combine perf data metrics from several files.
Dec 13 2021, 1:08 AM · Restricted Project, Restricted Project